Commit graph

40187 commits

Author SHA1 Message Date
Lisa Cawley 5d9b84ff75
[DOCS] Clean up text (#90359) 2021-02-05 09:16:28 -08:00
Chandler Prall db899a9274
Upgrade EUI to v31.4.0 (#89648)
* Bump EUI to v31.4.0

* fix datagrid functional tests

* fix Lens unit tests

* fix table cell filter test

* Fix discover grid doc view test

* stabilize data table tests

* fix dashboard embeddable datagrid test

* Fix x-pack functional tests

* fix ml accessibility tests

* Fix discover grid context test

* Adapt expected nr of documents being displayed

* stabilize Lens a11y tests and skip data table

* Fix 2 ml functional tests

* enable lens datatable test; disable axe rule for datatable

* fix ml test

* fix Lens table test

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Joe Reuter <johannes.reuter@elastic.co>
Co-authored-by: Matthias Wilhelm <matthias.wilhelm@elastic.co>
Co-authored-by: Michail Yasonik <michail.yasonik@elastic.co>
2021-02-05 10:14:58 -07:00
Constance 3166ff3761
[Enterprise Search] eslint rule update: react/jsx-boolean-value (#90345)
* [Setup] Split rule that explicitly allows `any` in test/mock files into its own section

- so that the rules we're about to add apply correctly to all files

* Add react/jsx-boolean-value rule

* Run --fix

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-02-05 09:01:01 -08:00
Yuliia Naumenko 6ccb716c9c
[Alerting UI] Added EuiThemeProvider as an application wrapper for triggers_actions_ui (#90312) 2021-02-05 08:59:41 -08:00
Pete Harverson d3fd7bb7ca
[ML] Allow filtering by mlcategory in Anomaly Explorer Influencers list (#90282)
* [ML] Allow filtering by mlcategory in Anomaly Explorer Influencers list

* [ML] Use getFormattedSeverityScore for formatting anomaly scores
2021-02-05 16:32:49 +00:00
Matthias Wilhelm ae609c4aea
[Discover] Add missing key to DocViewer table (#90396) 2021-02-05 17:28:17 +01:00
Matthias Wilhelm b058f7852b
[Discover] Close document flyout when inspect flyout is displayed (#89679) 2021-02-05 11:42:59 +01:00
Stratoula Kalafateli 3a388c6bf0
[Visualize] Removes the dashboard callout for users without permission (#89979)
* [Visualize] Removes the dashboard callout for users without permission

* Check if the user has the createNew permission

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-02-05 12:01:46 +02:00
Pete Hampton f329ff84b8
[7.12][Security] - Collect Security ML job / datafeed statistics (#89705)
* inital setup and experiments.

* Cast into ML job metric.

* Update mappings file.

* small refactor. add basic test to build on.

* mock out anomoly detector for testing from the usage collector.

* [PH JD] collect first set of ml job stats.

* Update telemetry schema.

* Include create and finished time.

* Cache datafeed calls and find / filter by naming convention.

* Fix jest test temp.

* [PH JD] Add datafeed to the usage collector payload.

* Get e2e test working.

* Update time complexity detail / df stats lookup. O(n) -> O(1)

* Update var names.

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-02-05 08:44:35 +00:00
István Zoltán Szabó a63dd15eac
Adjusts button labels to match titles in Data Visualizer. (#90289)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-02-05 09:37:22 +01:00
Uladzislau Lasitsa 1f0da4f889
Removes editorConfig.collections (#89854)
* Removed editorConfig.collections

* Fix CI

* Update snapshots

* Fix comments

* Fix eslint

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-02-05 10:58:30 +03:00
Mikhail Shustov 81e4595eaf
prevent jest leaking into the prod build (#90318) 2021-02-05 07:16:17 +01:00
Mikhail Shustov 98c2de3db9
remove unused angular import from security solution (#90263)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-02-05 07:15:49 +01:00
Xavier Mouligneau 860152810b
[SECURITY SOLUTIONS] add property include_unmapped (#90341)
* simpler fix

* remove fields capabilities to get unmapper fields

* fix test

* bring back test
2021-02-04 22:38:38 -05:00
CJ Cenizal d8ea8af22f
Change Remote Clusters Cloud message to clarify that it's Elastic Cloud. (#90314) 2021-02-04 19:22:46 -08:00
Frank Hassanabad 0c5fb85bfd
Adds tests for issue with immutable (#90372)
## Summary

Adds e2e tests for https://github.com/elastic/kibana/pull/90326

* Adds e2 tests and backfills for updating actions and expected behaviors
* Adds two tests that would fail without the fix and if a regression happens this will trigger on the regression
* Adds two tests to the PATCH for exception lists even though there is no regression there. Reason is to prevent an accidental issue there.
* Adds tests to ensure the version number does not accidentally get bumped if PATCH or UPDATE is called on actions or exceptions for immutable rules.
* Adds utilities for cutting down noise.

### Checklist

- [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
2021-02-04 19:07:14 -07:00
Luke Elmers a971c251e9
Fix issue where logs fail to calculate size of gunzip streams. (#90353) 2021-02-04 17:43:03 -07:00
Larry Gregory 00a20268b1
Optimize performance of ES privilege response validation (#90074)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-02-04 19:18:10 -05:00
Frank Hassanabad 219a86dbe5
Fixes regression where tags are turning immutable to mutable within rules (#90326)
## Summary

Fixes regression: https://github.com/elastic/kibana/issues/90319 that has not been released where in some cases such as adding actions to a rule through an update we can and will update an immutable rule and do not expect the immutable to turn into a mutable through the tags.

Simple one-liner fix, I will update in a follow on PR with a regression test for this particular use case of actions but not with this one since we optimizing for speed of pull request to back-port.

Criticality is high and impact is high as this is data bug which can cause a lot of headaches and migrations if this goes out.

### Checklist

No unit test for this one, but a functional test will be added in a follow up
- [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
2021-02-04 17:06:10 -07:00
Kent Marten da9c4a89e7
[maps] Top hits per entity--change to title to use recent, minor edits (#89254)
* [maps] Top hits per entity--change to title to use recent, minor edits

* Updated TopHitsPerEntity title and description to use the term relevant

* updating top hits per entity topic to new title

Co-authored-by: Kent Marten <kmartastic@users.noreply.github.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-02-04 15:43:03 -08:00
Lisa Cawley 9a3977d66e
[DOCS] Update installation details (#90354) 2021-02-04 15:38:44 -08:00
Stacey Gammon bb3ed33ccc
RFC for automatically generated typescript API documentation for every plugins public services, types, and functionality (#86704)
* wip RFC for API doc infra

* update

* update

* rfc

* rfc

* Update RFC

* Update RFC post Arch Review

* add pr link

* Update based on review feedback

* Update 0014_api_documentation.md

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-02-04 17:22:22 -05:00
Nick Peihl 35fd85b8fa
Elastic Maps Server config is host not hostname (#90234)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-02-04 14:16:30 -08:00
Lisa Cawley 808bd44463
Use doc link services in index pattern management (#89937) 2021-02-04 12:49:46 -08:00
John Schulz 9e7e1e1708
[Fleet] Managed Agent Policy (#88688)
## Summary
Introduces the concept of a managed agent policy. Resolves most of the acceptance criteria from #76843. Remaining to be done in follow up PRs

- [x] Define hosted Agent Policy concept in Fleet.
    - [x] Flag in policy? **_yes, added `is_managed: boolean`_ in agent policy SO**
    - [x] Should not built only for cloud, an admin should be able to set theses restrictions.
    - [x] We should have an API to configure it _**Can `POST` and `PUT` to  `/api/fleet/agent_policies/{policy_id}`**_
    - [x] Integration should be editable, we expect integration author to do the right thing and limit what can be edited.
- [x] Research if we can ensure the right behavior of Hosted Agent policy and restrict the super user.
- [ ] Capabilities restrictions
  - [ ] An Agent enrolled in an Hosted Agent policy should not be able to be upgraded.
  - [x] An Agent enrolled in an Hosted Agent policy should not be able to be unenrolled.
  - [ ] No Agents cannot be enrolled into this policy by the user.
      - Hide the enrollment key?
      - Need to figure out the workflow.
  - [x] An Agent enrolled in an Hosted Agent policy should not be able to be reassigned to a different configuration.
- [x] As a user I should be prevented to do theses action. _**No user-level checks. Only Agent Policy. No UI changes, but API errors are shown for failed actions like reassigning**_
- [x] As an API user I should receive error messages.
- [x] If making a single "flag" is easier/faster let's do it.  _**Currently single `is_managed` property on agent policy SO.**_

Checks are implemented in service layer (is agent enrolled in a managed policy?)

No UI-specific changes added but UI is affected because HTTP requests (like `api/fleet/agents/{agentId}/reassign`) can fail. See screenshots below.

Tests at service (`yarn test:jest`) and http (`yarn test ftr`) layers for each of create policy, update policy, unenroll agent, and reassign agent

Bulk actions currently filter out restricted items. A follow-up PR will change them to throw an error and cause the request to fail.


## Managed Policy
Can create (`POST`) and update (`PUT`) an agent policy with an `is_managed` property. Each new saved object will have an `is_managed` property (default `false`)

<details><summary>HTTP commands</summary>

#### Create (`is_managed: false` by default)
```
 curl --user elastic:changeme -X POST localhost:5601/api/fleet/agent_policies -H 'Content-Type: application/json' -d'{ "name": "User created policy", "namespace": "default"}' -H 'kbn-xsrf: true'
{"item":{"id":"edc236a0-5cbb-11eb-ab2c-0134aecb4ce8","name":"User created policy","namespace":"default","is_managed":false,"revision":1,"updated_at":"2021-01-22T14:12:58.250Z","updated_by":"elastic"}}
```

#### Create with `is_managed: true`
```
 curl --user elastic:changeme -X POST localhost:5601/api/fleet/agent_policies -H 'Content-Type: application/json' -d'{ "name": "User created policy", "namespace": "default"}' -H 'kbn-xsrf: true'
{"item":{"id":"67c785b0-662e-11eb-bf6b-4790dc0178c0","name":"User created policy","namespace":"default","is_managed":false,"revision":1,"updated_at":"2021-02-03T14:45:06.059Z","updated_by":"elastic"}}
```

#### Update with `is_managed: true`
```
 curl --user elastic:changeme -X PUT  -H 'Content-Type: application/json' -H 'kbn-xsrf: 1234' localhost:5601/api/fleet/agent_policies/67c785b0-662e-11eb-bf6b-4790dc0178c0 -d '{ "name":"User created policy","namespace":"default","is_managed":true }'
{"item":{"id":"67c785b0-662e-11eb-bf6b-4790dc0178c0","name":"User created policy","namespace":"default","is_managed":true,"revision":2,"updated_at":"2021-02-03T14:47:28.471Z","updated_by":"elastic","package_policies":[]}}
```
</details>

## Enroll behavior
is not changed/addressed in this PR. Agents can still be enrolled in managed policies

## Unenroll Agent from managed policy behavior
#### Enrolled in managed agent policy, cannot be unenrolled
```
curl --user elastic:changeme -X POST http://localhost:5601/api/fleet/agents/441d4a40-6710-11eb-8f57-db14e8e41cff/unenroll -H 'kbn-xsrf: 1234' | jq
{
  "statusCode": 400,
  "error": "Bad Request",
  "message": "Cannot unenroll 441d4a40-6710-11eb-8f57-db14e8e41cff from a managed agent policy af9b4970-6701-11eb-b55a-899b78cb64da"
}
```

<details><summary>Screenshots for managed & unmanaged policies</summary>

#### Enrolled in managed agent policy, cannot be unenrolled
<img width="1931" alt="Screen Shot 2021-01-19 at 1 22 53 PM" src="https://user-images.githubusercontent.com/57655/105081614-67d05980-5a60-11eb-8faa-07e4e722a5b5.png">
<img width="1199" alt="Screen Shot 2021-01-19 at 1 30 26 PM" src="https://user-images.githubusercontent.com/57655/105081617-67d05980-5a60-11eb-9099-832dc6e04eca.png">
<img width="1971" alt="Screen Shot 2021-01-19 at 1 30 42 PM" src="https://user-images.githubusercontent.com/57655/105081618-67d05980-5a60-11eb-9a84-b80b6295ba19.png">

#### Enrolled agent policy is not managed, agent can be unenrolled<img width="1917" alt="Screen Shot 2021-01-19 at 1 44 12 PM" src="https://user-images.githubusercontent.com/57655/105081951-e3caa180-5a60-11eb-9308-7741b8986e8e.png">
<img width="2183" alt="Screen Shot 2021-01-19 at 1 44 19 PM" src="https://user-images.githubusercontent.com/57655/105081952-e3caa180-5a60-11eb-9833-1c721be0a107.png">

</details>


## Reassign agent 
#### No agent can be reassigned to a managed policy
```
 curl --user elastic:changeme -X 'PUT'  'http://localhost:5601/api/fleet/agents/482760d0-6710-11eb-8f57-db14e8e41cff/reassign' -H 'kbn-xsrf: xxx' -H 'Content-Type: application/json' -d '{"policy_id":"af9b4970-6701-11eb-b55a-899b78cb64da"}' 
{
  "statusCode": 400,
  "error": "Bad Request",
  "message": "Cannot reassign an agent to managed agent policy 94129590-6707-11eb-b55a-899b78cb64da"
}
```
<details><summary>Screenshots</summary>

<img width="1350" alt="Screen Shot 2021-02-04 at 2 14 51 PM" src="https://user-images.githubusercontent.com/57655/106943490-8044a300-66f3-11eb-9d2c-4b1ceef2e783.png">

</details>

#### Enrolled in managed agent policy, cannot be reassigned
```
 curl --user elastic:changeme -X 'PUT'  'http://localhost:5601/api/fleet/agents/482760d0-6710-11eb-8f57-db14e8e41cff/reassign' -H 'kbn-xsrf: xxx' -H 'Content-Type: application/json' -d '{"policy_id":"af9b4970-6701-11eb-b55a-899b78cb64da"}' 
{
  "statusCode": 400,
  "error": "Bad Request",
  "message": "Cannot reassign an agent from managed agent policy 94129590-6707-11eb-b55a-899b78cb64da"
}
```

<details><summary>Screenshots</summary>
<img width="1364" alt="Screen Shot 2021-01-19 at 2 58 38 PM" src="https://user-images.githubusercontent.com/57655/105086737-72dab800-5a67-11eb-8f5e-93cd7768b914.png">
<img width="1367" alt="Screen Shot 2021-01-19 at 2 58 44 PM" src="https://user-images.githubusercontent.com/57655/105086740-73734e80-5a67-11eb-8ef9-9c7005a0a4ea.png">
<img width="623" alt="Screen Shot 2021-01-19 at 2 59 27 PM" src="https://user-images.githubusercontent.com/57655/105086741-740be500-5a67-11eb-8fc2-721f8b5d178a.png">
</details>

#### Enrolled agent policy is unmanaged, agent can be reassigned to another unmanaged policy

<details><summary>Screenshots</summary>
<img width="1368" alt="Screen Shot 2021-01-19 at 3 00 01 PM" src="https://user-images.githubusercontent.com/57655/105086754-78d09900-5a67-11eb-86a5-9e3ac02d6e1f.png">
<img width="1363" alt="Screen Shot 2021-01-19 at 3 00 08 PM" src="https://user-images.githubusercontent.com/57655/105086761-7a01c600-5a67-11eb-991d-acf994e2a393.png">
<img width="625" alt="Screen Shot 2021-01-19 at 3 00 46 PM" src="https://user-images.githubusercontent.com/57655/105086764-7a9a5c80-5a67-11eb-8290-e79648d01579.png">
</details>

### Checklist

Delete any items that are not applicable to this PR.

- [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md)
- [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials
- [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
2021-02-04 15:16:45 -05:00
Scotty Bollinger 284842dc88
[Workplace Search] Fix Source Settings bug (#90242)
* Remove comment

Verified that this works as expected

* Replaces usage from SourceLogic to AddSourceLogic

* Remove unused duplicate code

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-02-04 13:58:44 -06:00
Constance 2955d65a18
[Enterprise Search] Refactor MockRouter test helper to not store payload (#90206)
* Update MockRouter to not pass/set a this.payload

- but instead intelligently validate payloads based on the request keys

* Fix relevance tuning API routes to not need a separate mock router for validating query & body

* Update all remaining tests to no longer pass a payload param to MockRouter
2021-02-04 11:46:47 -08:00
Lisa Cawley 0ef276dce1
Use doc link service in more Stack Monitoring pages (#89050)
Co-authored-by: igoristic <igor.zaytsev.dev@gmail.com>
2021-02-04 11:44:57 -08:00
Jason Stoltzfus 82df009fd1
[App Search] Relevance Tuning logic - actions and selectors only, no listeners (#89313) 2021-02-04 14:40:19 -05:00
Nathan L Smith 85e92b5ccd
Remove UI filters from UI (#89793)
* Start moving some stuff

* Move some stuff around

* more

* Transactions label

* some snake casing

* i18n fix

* Remove unused ui filters endpoints

* Updates to select

* remove projections

* Use urlHelpers.push

* License change
2021-02-04 13:27:17 -06:00
Greg Back 54b1fb6163
Use newfeed.service config for all newsfeeds (#90252)
Co-authored-by: Alejandro Fernández Haro <afharo@gmail.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-02-04 13:27:52 -05:00
Tiago Costa 0f45439a5f skip flaky suite (#85086)
(cherry picked from commit e564439348)
2021-02-04 10:15:11 -07:00
Aaron Caldwell 5052499e20
Add readme to geo containment alert covering test alert setup (#89625)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-02-04 09:47:47 -07:00
Cauê Marcondes 7a42a6f410
[APM] Enabling yesterday option when 24 hours is selected (#90017)
* enabling yesterday option when 24 hours is selected

* addressing PR comments

* addressing PR comments

* enabling select box
2021-02-04 17:20:50 +01:00
Bhavya RM e676617f69
Test user for maps tests under import geoJSON tests (#86015)
test user assignment for test files under import geoJSON files

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-02-04 11:04:30 -05:00
Joe Reuter 1741cef4ae
[Lens] Hide column in table (#88680) 2021-02-04 16:22:09 +01:00
Marshall Main e0133892f6
[Security Solution][Detections] Reduce detection engine reliance on _source (#89371)
* First pass at switching rules to depend on fields instead of _source

* Fix tests

* Change operator: excluded logic so missing fields are allowlisted

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-02-04 10:20:16 -05:00
Maja Grubic c37b0e1474
[Discover] Minor cleanup (#90260) 2021-02-04 15:00:22 +00:00
Liza Katz b5ce8ba26f
[Search Session][Management] Rename "cancel" button and delete "Reload" button (#90015)
* Rename management button to "delete"

* fix jest

* Delete reload action from management

* Added both cancel and delete session

* Improve texts

* fix test

* ts

* doc

* fix jest
2021-02-04 16:57:26 +02:00
Shaunak Kashyap f3a9c763df
Updating package registry snapshot distribution version (#89776) 2021-02-04 08:40:18 -05:00
Anton Dosov e82bbcff89
[Search Session] Revamp search session indicator UI and tour (#89703) 2021-02-04 14:36:19 +01:00
Luke Elmers 72670ebc77
[core.logging] Add response logs to the KP logging system. (#87939) 2021-02-04 06:05:06 -07:00
Joe Reuter 1818dd7f4a
memoize editor frame (#89865) 2021-02-04 11:37:50 +01:00
Joe Reuter caf9d833a7
add tsconfig for dashboard mode (#89855) 2021-02-04 11:36:01 +01:00
Alexey Antonov b413d9d5bf
[TSVB] Disable runtime fields showing up in TSVB (#90163)
* [TSVB] Disable runtime fields showing up in TSVB

* add tests

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-02-04 12:16:16 +03:00
Spencer df4eb0f726
[kbn/es] avoid splitting string esArgs into separate args (#90253)
Co-authored-by: spalger <spalger@users.noreply.github.com>
2021-02-03 21:58:28 -07:00
Tiago Costa 23d5ffb44f
chore(NA): support bazel and kbn packages in parallel on kbn pm and on distributable build scripts (#89961)
* chore(NA): bazel projects support initial flag on kbn pm

* chore(NA): every needed step to build production bazel packages except the final function

* chore(NA): include build bazel production projects on kibana distributable build

* chore(NA): support bazel packages when creating the package.json

* chore(NA): including last changes on kbn pm and build distributable to support both bazel and kbn packages

* chore(NA): missing annotation on build bazel packages

* chore(NA): changed values on bazelrc common

* chore(NA): fix bazel common rc

* chore(NA): auto discovery if a kbn package is a Bazel package

* chore(NA): last details to make bazel packages to built on distributable scripts

* chore(NA): removed wrongly added line to x-pack package.json

* chore(NA): apply correct formating

* chore(NA): move into bazel bin

* chore(NA): merge chnages on kbn pm

* chore(NA): correctly setup ignore files for new bazel aggregated folder

* chore(NA): merge with last master

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-02-04 04:39:35 +00:00
spalger 0938252f21 skip another suite failing es promotion (#90229) 2021-02-03 20:20:02 -07:00
Brandon Kobel 4584a8b570
Elastic License 2.0 (#90099)
* Updating everything except the license headers themselves

* Applying ESLint rules

* Manually replacing the stragglers
2021-02-03 18:12:39 -08:00
spalger 27a53cf4d7 skip flaky suite, and dependent suite (#90229) 2021-02-03 16:21:19 -07:00