Christiane (Tina) Heiligers
43df3a78ed
Reset dirty saved query on reload ( #43927 )
...
* Clears changes a loaded saved query before loading another one
* Adds general functional test to ensure changes to a saved query are discarded on reloading it
* Moves resetting a dirty saved query to the app controllers in Discover, Visualize and Dashboard
2019-08-27 12:00:47 -07:00
Mikhail Shustov
9a732014cb
Response factory parameters as named arguments ( #43248 )
...
* pass body as response parameter. use attributes for error responses
* update core
* update tests
* update x-pack code
* update x-pack tests
* regen docs
* update comment
* Review feedback and fixes after master merge
* Eslint fixes
2019-08-23 19:31:17 +02:00
Spencer
e1535d5660
[indexPatterns/bytesFormat] switch default decimal places to 1 ( #43785 )
...
* [indexPatterns/bytesFormat] switch default decimal places to 1
* set format:bytes:defaultPattern in some functional test suites
2019-08-23 07:03:23 -07:00
Matt Bargar
bba04a51e3
Save query form validation on blur ( #43726 )
...
This PR changes the save query form to only validate its inputs on blur. Previously we validated on every change. This could lead to the errors flashing in the user's face before they're done typing a valid input. For example, we allow spaces in the name field, but not at the beginning or end of the name. So if a user typed this is a long name with spaces they would see the error pop up every time they type a space, only to have it disappear when they type the next letter.
2019-08-22 17:39:29 -04:00
Daniil Suleiman
e568c3dfde
[Vis: Default editor] EUIficate gauge/goal options tab ( #43265 )
...
* Euificate gauge options
* Changes params places
* Add ranges validation
* Get rid of legacy translates
* Fix functional tests
* Split gauge to panel components
* Disable alignment option
2019-08-22 16:01:55 +03:00
Matt Bargar
e233e419cf
Implement saved queries and filters ( #39140 )
...
Introduces "saved queries". Saved queries are a new saved object type similar to saved searches but more limited in scope. They allow users to store the the query string in the query bar and optionally the set of filters and timefilter in order to reload them anywhere a query is expected: Discover, Visualize, Dashboard, anywhere that uses our full SearchBar component.
2019-08-21 16:53:19 -04:00
Josh Dover
5071c74945
Replace CSP 'nonce-<base64>' directive with 'self' directive ( #43553 )
2019-08-21 14:11:38 -05:00
Dmitry Lemeshko
9b9801f470
functional tests for input control range ( #42483 )
...
* [apps/visualize] functional tests for input control range
* update jest test to have 100% combined coverage with functional
2019-08-21 17:22:54 +02:00
dave.snider@gmail.com
b0a4181f7d
Upgrade EUI@13.3.0 ( #42858 )
...
Upgrades 13.3.0
2019-08-20 13:37:47 -07:00
Matthias Wilhelm
dd26316fd2
De-angularize DocViewer ( #42116 )
...
* Migrate doc-viewer directive to use React/TypeScript
* Refactor DocViewsRegistryProvider
* Add compatibility for 3rd party plugins still using angular
* Add tests
Angular rendering for usage in React component:
Co-authored-by: spalger <email@spalger.com>
2019-08-20 07:47:21 +02:00
Mikhail Shustov
00a0203584
Extend request handler with request scoped core capabilities ( #43103 )
2019-08-19 13:34:48 -05:00
Vadim Dalecky
d2166596b0
fix: 🐛 pass whole action context to isCompatible() method ( #43457 )
...
* fix: 🐛 pass whole action context to isCompatible() method
* test: 💍 add function test for saved search filtering in pie
* test: 💍 move save search functional test in its own test suite
2019-08-19 14:31:32 +02:00
Daniil Suleiman
df72f91878
[Vis: Default editor] EUIficate region map options tab ( #42944 )
...
* EUIficate region_map_options
* Reuse types
* Remove wms_options directive
* Remove style import
* Fix issue with join field default value
2019-08-15 21:09:28 +03:00
Matthias Wilhelm
6da05e0b8d
Restore discover histogram selection triggering fetch ( #43097 )
...
* Listen to timefilter fetch event to start fetching
* Improve functional test to catch error
2019-08-14 18:12:29 +02:00
Maryia Lapata
a892d58677
[Vis: Default editor] EUIficate Panel Setting tab ( #42828 )
...
* EUIficate pointe-series and grid
* Apply TS
* Show grid on a panel
* Remove extra space
* Add TS
* Use BasicOptions
* Adjust func test
* Add dataTestSubj prop to SelectOption
* Use id instead of data-sest-subj
* Disable show x-axis lines when there is histogram agg
* Add tooltip for disabled 'Show x-axis lines' config
* Remove extra space
2019-08-14 17:52:36 +03:00
Mike Côté
f6e137baf7
Re-enable failing test ( #43190 )
2019-08-13 10:56:55 -04:00
spalger
e3b0ff6e93
skip failing test ( #43163 )
2019-08-12 20:43:15 -07:00
Spencer
c29a17ce3c
[ftr] enable visualRegression jobs ( #42989 )
...
* enable visualRegression jobs
* skip the console and login visual tests
2019-08-12 10:50:22 -07:00
Vadim Dalecky
ece2c35de1
Embeddables 👉 NP-ready ( #41272 )
...
* refactor: 💡 create registries file
* docs: ✏️ add testing command to docs
* chore: 🤖 create state folder
* chore: 🤖 WIP
* refactor: 💡 remove static imports of stateful things
Make Embeddables ./triggers tests pass
* test: 💍 add await-of for testing
* refactor: 💡 move stateless code into shim's lib/ folder
* test: 💍 add registry tests
* feat: 🎸 add Embeddable plugin public "setup" API
* feat: 🎸 create Embeddable plugin shim
* refactor: 💡 minor improvements for new plugin structure
* refactor: 💡 move test helpers into shim
* feat: 🎸 add Embeddable setup.getTrigger() method
* feat: 🎸 inject setup API into pure setup functions
* refactor: 💡 generate Embeddable setup API in a loop
* feat: 🎸 add getTriggerActions() Embeddable setup function
* feat: 🎸 add getTriggerCompatibleActions() to Embeddable shim
* chore: 🤖 uninstall await-of package
* chore: 🤖 simplify imports/exports
* test: 💍 improve testing utilities
* feat: 🎸 add executeTriggerActions() Embeddables setup method
* fix: 🐛 remove non-existing import
* chore: 🤖 cleanup actions
* refactor: 💡 move errors into dedicated errors.ts file, add test
* test: 💍 add unit test for ApplyFilterAction class
* test: 💍 import helpers correctly after refactoring
* test: 💍 fix actions tests
* feat: 🎸 clean up /lib/embeddables
* test: 💍 fix /lib/containers tests
* test: 💍 make embeddable_panel.test.tsx tests pass
* refactor: 💡 work on briging EditPanelAction action to /actions
* test: 💍 make /containers tests pass
* test: 💍 make /actions and /embeddables tests pass
* test: 💍 clean up tests from legacy platform static imports
* feat: 🎸 add getEmbeddableFactories API method
* test: 💍 add tests for factory list method
* feat: 🎸 add start life-cycle API
* feat: 🎸 unify Embeddables API
* refactor: 💡 create /css folder, move all CSS there
* feat: 🎸 improve dashboard container shim
* feat: 🎸 progress on dashboard container shim
* feat: 🎸 implement getEmbeddableFactory Embeddable API method
* feat: 🎸 improve embeddable container shim
* test: 💍 fix dashboard container expand panel tests
* test: 💍 fix dashboard grid tests
* test: 💍 fix createPanel tests
* test: 💍 fix dashboard viewport tests
* test: 💍 fix dashboard container tests
* test: 💍 add Embeddable plugin mock
* test: 💍 improve tests after merge
* refactor: 💡 move new platform code into np_ready folders
* chore: 🤖 fix some TS errors after merge
* chore: 🤖 fix more TS errors after merge
* fix: 🐛 fix TypeScript errors in kbn_tp_sample_panel_action
* fix: 🐛 fix more TypeScript errors
* fix: 🐛 fix TypeScript in functional tests
* fix: 🐛 fix more TypeScript errors
* fix: 🐛 fix more TS errors
* refactor: 💡 pass deps through constructors
* refactor: 💡 improve dependency injection and fix tests
* test: 💍 fix container integration tests
* test: 💍 fix customize_panel_modal tests after refactor
* test: 💍 fix all tests in embeddable_api
* chore: 🤖 fix linter error
* test: 💍 fix dashboard_embeddable_container tests after merge
* test: 💍 fix /src TypeScript errors
* fix: 🐛 fix Jest tests and add global typings in demo plugin
* fix: 🐛 fix build errors
* fix: 🐛 make build start without errors
* fix: 🐛 in dashboard container don't import types from ui/*
* chore: 🤖 fix linter errors
* refactor: 💡 remove getUserData, remove another ui/new_platform
* chore: 🤖 fix linter errors
* refactor: 💡 remove ui/new_platform from HelloWorldAction
* refactor: 💡 remove ui/new_platform from SendMessageAction
* refactor: 💡 remove ui/new_platform from ContactCardEmbeddableF*
* chore: 🤖 fix ESLint errors
* feat: 🎸 throw if action or trigger with given ID already exists
* feat: 🎸 throw if embeddable factory already registered
* docs: ✏️ fix tsdoc
* chore: 🤖 remove unused @ts-ignore
* refactor: 💡 remove createEmbeddables() function
* refactor: 💡 use new NP inspector plugin
* fix: 🐛 fix TypeScript errors
* chore: 🤖 improve plugin manifests
* feat: 🎸 cherry pick exported API from Embeddable plugin
* refactor: 💡 do not import constants from Kibana App
* fix: 🐛 remove unnecessary any
* chore: 🤖 uncomment SASS files
* refactor: 💡 remove IndexPattern logic out of dashboard panel
* refactor: 💡 move RefreshInterval and TimeRange to New Platform
* fix: 🐛 revert back notifications usage
* chore: 🤖 export test samples from index.ts files
* test: 💍 re-enable ApplyFilterAction integration tests
* chore: 🤖 remove unused translation
* refactor: 💡 rename variable to something less React specific
* fix: 🐛 improve CSS imports, remove unused hack, remove any type
* fix: 🐛 fix Embeddables demo plugin
* fix: 🐛 fix missing SASS variable
* fix: 🐛 re-enable translation
* fix: 🐛 uncomment saved object flyout panel logic
* refactor: 💡 pass in <SavedObjectFinder> from top level
* test: 💍 re-enable add_panel_flyout tests
* refactor: 💡 pass in <ExitFullScreenButton> through args
* fix: 🐛 import specific constants to fix functional tests
* fix: 🐛 fix CI type_check error
* test: 💍 change import paths to fix functional tests on CI
* test: 💍 fix exit button test after refactoring
* refactor: 💡 make do not change page on grid error
* test: 💍 fix functional test
* refactor: 💡 move CSS next to components
* fix: 🐛 remove missing props
* test: 💍 try fixing functional test on CI
These tests pass locally, but fail on CI. This is a stab to fix it on
CI.
* refactor: 💡 move variables.scss one folder up
* test: 💍 disable Embeddable Explorer functional tests
* chore: 🤖 remove onCoreReady in functional tests
* test: 💍 disable maps functional test for embeddables
* chore: 🤖 remove comment, export types explicitly
* refactor: 💡 remove unused `firstName`, add link to issue
* refactor: 💡 remove double underscore __ in test registry names
* refactor: 💡 remove utils folder, move bootstrap() fn to top lvl
* test: 💍 uncomment edit_panel_action tests
* test: 💍 uncomment inspect_panel_action tests
2019-08-12 12:41:18 +02:00
Brandon Kobel
2ce2bfbca7
Adding "style-src 'unsafe-inline' 'self'" to default CSP rules ( #41305 )
...
* Adding "style-src 'unsafe-inline' 'self'" to default CSP rules
* Updating jest snapshot
* Fixing api integration smoke test
* Verifying all CSP responses
* Fixing OIDC implicit flow test
2019-08-09 15:15:40 -07:00
Dmitry Lemeshko
2198222f28
run chained_controls on Firefox to catch regression ( #43044 )
2019-08-09 21:40:34 +02:00
Dmitry Lemeshko
2ebbf1b091
[apps/dashboard] skip part of filtering tests on FF ( #43047 )
2019-08-09 20:46:28 +02:00
Peter Pisljar
06706b5748
fixes scaling logic to check agg type instead schema ( #42574 )
...
* fixes scaling logic to check agg type instead schema
* adding selenium test
* updating jest snapshot
* fixing test
* Change test order
* Fix test order
2019-08-08 18:09:14 +02:00
Dmitry Lemeshko
ce07151bf4
bump chromedriver version to 76 ( #42468 )
...
* bump chromedriver version to 76
* [test/interpreter_functional] update snapshots
* [test/interpreter_functional] skip failing tests
* Revert "[test/interpreter_functional] update snapshots"
This reverts commit 6401554882
.
* [test/interpreter_functional] skip snapshot tests
2019-08-07 22:52:02 +02:00
Josh Dover
5192dac0b6
Add ContextService to server ( #42395 )
2019-08-06 12:24:49 -05:00
Nicolas Chaulet
1aa21c123d
[Tests] Setup contract tests in x-pack ( #42345 )
2019-08-05 11:15:03 -04:00
Spencer
d66b3c74eb
[x-pack/ftr] refactor types to be more accurate/consistent wit… ( #42407 )
2019-08-02 15:43:05 -07:00
Matt Bargar
f6cb00a6f3
Allow sorting on multiple columns in Discover ( #41918 )
...
This commit enables sorting on multiple columns in Discover and in saved search panels on dashboards. The UI is simple and should be familiar based on the way multi-sort works in other common applications like file explorers. Each sortable column has a sort icon indicating which way it is sorted (or unsorted, in the case of two arrows pointing both up and down). Sort priority is determined by which column was clicked most recently, with the most recent being the lowest priority.
2019-08-02 17:18:54 -04:00
Spencer
f4e39159dc
[ftr/cheerio] improve cheerio types to include test subject me… ( #42534 )
2019-08-02 13:08:20 -07:00
Chandler Prall
da99d4520b
Upgraded EUI 13.0.0 -> 13.1.1 ( #42298 )
...
* Upgraded EUI 13.0.0 -> 13.1.0
* Bump to 13.1.1
* Reset MutationObserver polyfill to original operation
* Reset x-pack's MutationObserver polyfill to original operation
2019-08-02 12:42:07 -06:00
Vadim Dalecky
39b233a24d
Inspector 👉 New Platform ( #42164 )
...
* refactor: 💡 remove SASS and clean up InspectorView component
* refactor: 💡 clean up inspector, convert .js -> .ts
* feat: 🎸 add Inspector NP plugin boilerplate
* feat: 🎸 move view registry to NP, move types, add registerView
* docs: ✏️ move inspector README to NP plugin
* refactor: 💡 move ui/inspector/ui to NP
* refactor: 💡 move Inspector adapters to NP
* refactor: 💡 move Inspector.isAvailable to New Platform
* refactor: 💡 move Inspector.open to New Platform plugin
* test: 💍 move Inspector tests to NP plugin
* chore: 🤖 fix imports
* feat: 🎸 update translations
* test: 💍 fix failing translation snapshot
* test: 💍 fix yarn test:browser tests
* Update src/legacy/ui/public/inspector/build_tabular_inspector_data.ts
Co-Authored-By: Stacey Gammon <gammon@elastic.co>
* [ML] [Job wizards] switching to new kibana context provider
* fix: 🐛 specify translation path directly to the plugin
* docs: ✏️ add comment about Webpack config fix
* Update src/legacy/ui/public/inspector/build_tabular_inspector_data.ts
Co-Authored-By: Stacey Gammon <gammon@elastic.co>
* Update src/legacy/ui/public/inspector/build_tabular_inspector_data.ts
Co-Authored-By: Stacey Gammon <gammon@elastic.co>
* feat: 🎸 improve types as per review
* fix: 🐛 remove <InspectorView> comp and fix view layouts
* test: 💍 improve mocks
2019-08-02 17:00:35 +02:00
Jason Rhodes
b230ceb50d
Creates functional test README files ( #42389 )
...
* Creates x-pack functional test README
* Adds README to test/functional directory
* Adds link to Functional Test dev guide in x-pack root README
2019-07-31 15:41:15 -04:00
Brandon Kobel
f2f941fee3
Saved Objects export API stable type order ( #42310 )
...
* Sorting export's valid types
* Updating the saved object api integration export test
* Fixing OSS also
2019-07-30 19:28:44 -07:00
Dmitry Lemeshko
7d61cac2d8
FTR: fix testSubjects.missingOrFail ( #42290 )
...
* [services/test_subject] fix missingOrFail
* [services/test_subjects] allowHidden option for missingOrFail
* [page_objects/dashboard_page] wait for euiTable loaded, increase timeout for loading page check
2019-07-31 00:19:15 +02:00
Vitali Haradkou
2dfe167d7d
[TSVB] [Functional] unskip flaky test ( #41766 )
...
* unskip flaky test
2019-07-29 15:33:12 +03:00
Maryia Lapata
85f9ef6433
[Vis Editor] EUIfication of agg and agg-group directives ( #40866 )
...
* Create default_editor_agg.tsx
* Create default_editor_agg_group
* Apply drag and drop
* Remove unused dragula dependency
* Remove old mocha tests
* Add ts for state
* Update functional tests
* Update touched condition
* Apply styles for accordion button content
* Apply truncate for agg description
* Remove unused styles
* Separate common props
* Move aggGroupNamesMap to agg_group.js
* Update _sidebar.scss
* Pass schemas prop
* Prevent scroll bar and add space
* Remove unused min from stats
* Add OnAggParamsChange type
* Show error as an icon
* Update background color
* Update title size
* Remove Schema.deprecate since it's not used
2019-07-29 13:58:50 +03:00
Daniil Suleiman
91adbfc88b
[Vis: Default editor] EUIficate pie chart options tab ( #41901 )
...
* EUIficate pie chart options tab
* Fix tests
* Size titles down to xs
* Use FormattedMessage
2019-07-29 13:03:57 +03:00
Dmitry Lemeshko
044285cb3b
Functional tests: make sure clicked dashboard is opened ( #42006 )
...
* [page_objects/dashboard_page] make sure selected dashboard is opened
2019-07-26 15:01:58 +02:00
Dmitry Lemeshko
7df1f41857
Ftr/tsfy doc table ( #41710 )
...
* [services/doc_table] tsfy service and use parse dom to get rows
* [services/doc_table] do not pass table element as argument
* [services/doc_table] update service to minimize StaleElementReference cases
* [services/doc_table] add missing access modifier
* [services/doc_table] change getHeaderFields and fix return types
2019-07-25 08:42:04 +02:00
Dmitry Lemeshko
58f2a263d0
[service/remote] check env variable value ( #41909 )
2019-07-25 08:29:17 +02:00
Daniil Suleiman
ef5af4ce66
[Vis: Default editor] Create vis_options_react_wrapper ( #41746 )
...
* Add vis_options_react_wrapper
* Update jest tests
* Fix plugin functional test
2019-07-24 16:20:23 +03:00
Meir Meshi
db07f13253
Ensure visualizations in percentage mode respect the advanced settings percent format ( #39044 )
2019-07-23 23:47:27 -06:00
Liza Katz
de9d823ad4
Fix autorefresh in visualize editor ( #41657 )
2019-07-23 22:34:49 -06:00
dave.snider@gmail.com
c2b926e2e7
EUI 13.0.0 ( #41723 )
2019-07-23 15:09:16 -07:00
Tim Roes
e1bc154478
GoodBye Notifier ( #41663 )
...
* Begin notifier removal
* Remove remaining notifier traces
* Remove dead translations
* Remove Angular from config listener
* Import angular-sanitize explicitly in map
2019-07-23 18:26:50 +02:00
Stacey Gammon
a6fd0c3e2f
turn on filtering tests ( #41202 )
...
* turn on filtering tests
* run x-pack-firefoxSmoke ciGroup 40 times, run dashboard tests 20 times per job
* Revert "run x-pack-firefoxSmoke ciGroup 40 times, run dashboard tests 20 times per job"
This reverts commit 5ef02cc53ba5085c3f74431cb6ef20be2d876cde.
2019-07-23 12:18:33 -04:00
Ahmad Bamieh
9d7cf53eba
[telemetry] Analytics Package ( #41113 )
...
* kbn-analytics
* kbn-analytics
* expose provider
* add logger
* performance and stats reporters
* finalize ui stats metric
* functional tests
* remove readme file for now
* update readme
* add types file into to tsconfigs
* Update packages/kbn-analytics/src/report.ts
Co-Authored-By: Josh Dover <me@joshdover.com>
* fix typechecks
* use enum instead of strings for metric types
* getUiStatsReporter -> createUiStatsReporter
* fix special typo in README
* remove unused stop method
* fix tests
* default debug to false
* use chrome.getInjected
* add METRIC_TYPE to jest module mocks
* mock create fn
* handle enabled:false
* init ui_metric in test setup env
* regenerator runtime
* transform-regenerator
* update lock file
* update babel configs
* runtime dep
* add regenerator
* babel configs
* use env-preset
* merge conflicts
* fix workpad telemetry tests
* regeneratorRuntime attempt to fix number 30000
* env targets
* remove module config
* try again
* try without regenerator
* use kbn/babel-preset/webpack_preset only
* runtime
* just use typescript
* update tsconfig
* Caches trackers by app value for infra useTrackMetric hook
2019-07-23 15:46:56 +03:00
Liza Katz
4b8913cb53
hide top nav menu in full screen mode of maps and dashboard ( #41672 )
...
* hide top nav menu in full screen mode of maps and dashboard
* Fixed dashboard full screen mode and added full screen mode test to maps
2019-07-23 09:31:44 +03:00
Zacqary Adam Xeper
47d9756652
[Logs UI] Make column configurations reorderable ( #41035 )
...
* [Logs UI] Make column configurations reorderable
* Improve typing aand memoize callback
* Guard against index bounds and rename reorderLogColumns
* Fix useCallback memoization
* Add functional test for reordering log columns
* Use browser.keys instead of Key in functional test
2019-07-22 13:47:47 -05:00
Greg Thompson
dd63e73fb0
Upgrade EUI to 12.4.0 ( #41577 )
...
* eui 12.4.0
* styled-components ts conflict
* update combobox test service to always open on open call
* Revert "update combobox test service to always open on open call"
This reverts commit 43074e6006
.
* scroll combobox into view
* scroll before filter
2019-07-22 13:01:25 -05:00