Commit graph

37712 commits

Author SHA1 Message Date
Bill McConaghy 628b743a52
[DOCS] improving production documentation for task manager and alerting (#87484) (#87502)
* improving production documentation for task manager and alerting

* calling it Kibana Task Manager to be more explicit

* addressing PR feedback
2021-01-06 10:15:09 -05:00
Thomas Watson 00c3b18b93
Add deprecation warning if setting server.host to "0" (#87471) 2021-01-06 16:07:29 +01:00
Michael Olorunnisola 00bf2363bc
[7.x] [Security Solution][Resolver] - Maintain active node (#86682) (#87371)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-01-06 09:56:14 -05:00
Oliver Gupte 63de3445cf
Closes #87026 by ensuring the user also has save privileges for APM (#87343) (#87420)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-01-06 06:40:21 -08:00
Tyler Smalley 100bd91330
[Reporting] Use fork of Puppeteer (#87415) (#87430)
Applies a patch to resolve a known issue where specifying a Chrome
executable is ignored on ARM.

2ebf7489d4 (diff-d09eb6dc12121ed413d2820db7fa8ba1dff9260a2ad2486a6220c861a8e5e673)

Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
2021-01-06 06:27:10 -08:00
Steph Milovic f0257be70d
[Security Solution] [Case] Fixes "Case connector cannot be updated when created with a wrong field" (#87223) (#87398) 2021-01-06 07:10:21 -07:00
Christos Nasikas 938b993986
[7.x] [Security Solution][Case] Fix comment content when pushing alerts to external services (#86812) (#87441)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-01-06 15:49:15 +02:00
Pierre Gayvallet b6237b1cf1
Use management.getTitle for import summary (#87285) (#87462)
* fix import summary title

* remove TODO
2021-01-06 14:38:31 +01:00
Gidi Meir Morris 07e96fff34
[Alerting] revert the revert of Enforces typing of Alert's ActionGroups (#87382) (#87454)
The https://github.com/elastic/kibana/pull/86761 PR was reverted due to a small typing issue.

This PR reverts that revert and adds a commit to address the issue: 9e4ab2002c.
2021-01-06 13:09:40 +00:00
Garrett Spong da64375fa5
[Security Solution] [Detections] Update search after to use one single date range filter (#86921) (#87428)
## Summary

Ref: https://github.com/elastic/kibana/issues/86874



replaces `should` with a single lower bounded and upper bounded date range filter.

### Checklist

Delete any items that are not applicable to this PR.

- [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios

### For maintainers

- [ ] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

Co-authored-by: Devin W. Hurley <devin.hurley@elastic.co>
2021-01-06 05:02:14 -05:00
Casper Hübertz 24f9ed1e0e
[APM] Remove top padding from Waterfall container (#87312) (#87434)
* Removed unused imports and props
2021-01-06 10:58:45 +01:00
Nick Partridge 853dfaedcb
Rename chartLibrary setting to legacyChartsLibrary (#86529) (#87328)
* rename chartLibrary setting to legacyChartsLibrary

* fix spelling

* fix plugin setting check boolean
2021-01-06 10:26:53 +02:00
Davis Plumlee 00ccdac8f0
[Security Solution][Detection Rules] Adds a catch-all display tag for Mitre descriptions (#87240) (#87426) 2021-01-06 00:35:23 -07:00
Alexey Antonov 41aab669bc
[Data plugin] Wrong caching for Index pattern fields (#87116) (#87376)
* [Data plugin] Wrong caching for Index pattern fields

Closes: #84666

* remove can update index_pattern fields test

* fix tests

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
# Conflicts:
#	src/plugins/data/common/index_patterns/index_patterns/index_patterns.ts
2021-01-06 09:19:53 +03:00
Yara Tercero 4867610afb
[SecuritySolution][Detections] Fix "Closing a signal silently fails with reduced privileges" (#86908) (#87413)
## Summary

This PR introduces the following changes. If the user has insufficient write privileges on the signals index:

- we disable the status-changing actions on detection alerts ("Open alert", "Close Alert", "Mark in progress") in the context menu of an alert in alerts table
- we make sure to show the corresponding callout that tells about read-only access to detection alerts
- in the callout we provide links to docs for understanding why/how to fix

Co-authored-by: Georgii Gorbachev <georgii.gorbachev@elastic.co>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-01-05 22:23:25 -07:00
Ryland Herrick 14fcfba0cb
[Security Solution][Detections] Fix severity and risk score overrides when field mapping exists but the mapped fields do not (#87004) (#87411)
* Fix Source field combobox in Severity override and Risk score override sections

* Clean up

* Fix unit and Cypress tests

Co-authored-by: Georgii Gorbachev <georgii.gorbachev@elastic.co>
2021-01-05 22:22:49 -07:00
Nathan L Smith 37017f16b0
Fix service name wrapping on mobile on inventory (#87390) (#87407)
Fixes #85752.
2021-01-05 22:16:22 -06:00
Scotty Bollinger 609fb0d46f
[Enterprise Search] Add a helper for clearFlashMessages (#87383) (#87404)
This PR adds a convenience function for clearing flash messages to align with others.
2021-01-05 19:30:43 -06:00
Yuliia Naumenko fbc0d59d78
[Alerting UI] Alert and Connector flyouts Save and Save&Test buttons should be active by default. (#86708) (#87380)
* Alert and Connector flyouts Save and Save&Test buttons should be active by default.

* fixed typechecks

* fixed typechecks

* refactored repeted code

* fixed typechecks

* fixed typechecks

* fixed typechecks

* fixed due to comments

* fixed failing tests

* fixed due to comments

* fixed due to comments

* fixed due to comments

* fixed typescript checks
2021-01-05 14:17:01 -08:00
Cauê Marcondes abdd93b84a
[APM] transactionType should be required on service-specific endpoints (#86893) (#87315)
* making transaction type required on some apis

* addressing PR comments

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-01-05 22:23:52 +01:00
Cauê Marcondes c6ad33afa7
[APM] Alert preview threshold color doesn't match design.(#86958) (#87318)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-01-05 22:23:29 +01:00
Nicolas Chaulet 1e807e7701
[Fleet] Do not display inactive enrollment token in the agent enrollment flyout (#87300) (#87363) 2021-01-05 17:14:33 -04:00
Henry Harding 9044b515ab
update Logs/Metrics add data icons for consistency (#87193) (#87306) 2021-01-05 16:05:43 -05:00
Patryk Kopyciński 8062425ddb
[7.x] [Security Solution] JSON view for data is not displayed properly (#87008) (#87329)
* [Security Solution] JSON view for data is not displayed properly (#87008)

# Conflicts:
#	x-pack/plugins/security_solution/public/common/components/event_details/event_details.test.tsx

* Update event_details.test.tsx

Co-authored-by: Angela Chuang <6295984+angorayc@users.noreply.github.com>
2021-01-05 22:04:22 +01:00
Yuliia Naumenko ce8f529f15
Flaky test fix for Actions and Triggers app alerts should delete all selection (#86175) (#87366)
* Removed skip test for delete all alerts integration test

* fixed typechecks

* reduced nuber of selected alert to delete to a single one

* fixed due to comments

* removed long timing retry

* fixed typechecks

* fixed failing tests
2021-01-05 12:50:56 -08:00
Angela Chuang 17ad2c548c
[Security Solution] Fix pop up message (#86973) (#87204) 2021-01-05 21:43:52 +01:00
Yara Tercero 9251d6a492
[Security Solutions][Detections] - Fix exception list table referential deletion (#87231) (#87357)
### Summary

This PR concentrates on fixing the deletion on the exceptions list table view. This fix is intermediary and a more thorough, backend solution is needed. Currently, if you delete an exception list, it deletes the exception list SO, but does not remove references to it from rules. This PR allows for a quick fix conducting this logic client side.
2021-01-05 15:36:49 -05:00
ymao1 1ad8b59a9e
Disabling connectors for invalid connector types (#86910) (#87355)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-01-05 15:30:26 -05:00
Dominique Clarke 981678deaa
uptime add title to waterfall sidebar truncated text (#87102) (#87361)
* uptime add title to waterfall sidebar truncated text

* Uptime add tooltip and screen reader only text to MiddleTruncatedText

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-01-05 15:17:29 -05:00
Dominique Clarke d383e51ffe
[Uptime] only render ping status code badge when status code is available (#87096) (#87359)
* uptime only render ping status code badge when status code is available

* uptime update ResponseCodeColumn error state

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-01-05 15:16:39 -05:00
Constance 4bbb5593ab
[App Search] Minor var names follow-up (#87258) (#87345)
* Var rename

- so it doesn't sound negative or like a bug, but is instead an anticipated load/use case
- remove unncessary function
- move declaration down to right before it's used

* [Proposal] Other misc cleanup

- Rename engineNameParam to engineNameFromUrl to make reading flow a little bit more nicely + hopefully make the var source a bit clearer

- Change other references back to engineName for simplicity (they should really only be running after engineName has already been set, so there shouldn't be any race conditions there - moving engineBreadcrumb to after Loading should also solve that)
2021-01-05 11:38:14 -08:00
Brandon Morelli 44cc96de48
docs: APM 7.11 updates (#87072) (#87374) 2021-01-05 11:30:28 -08:00
Lukas Olson cf65d47277
[data.search.session] Add extend functionality to server-side search service (#86195) (#87320)
* [data.search.session] Store search strategy in saved object

* [data.search.session] Add extend functionality

* Update docs

* Update unit test to check strategy

* Throw kbnServerError instead of error

* Fix test

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-01-05 11:21:23 -07:00
Lisa Cawley cdb5ae5b60
Fix broken documentation link in Visualize app (#87250) (#87313) 2021-01-05 10:08:47 -08:00
Joe Portner 497383da91
Update security docs (#87215) (#87334) 2021-01-05 12:53:34 -05:00
Christiane (Tina) Heiligers 74f3472cf1
[7.x] Use new es client in Uptime usage collector (#86718) (#87321)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-01-05 10:51:51 -07:00
Lisa Cawley bb26154018
Add more URLs to documentation link service (#87265) (#87303) 2021-01-05 09:12:57 -08:00
gchaps 767cb55bfa
Add timestamp range example to kql docs (#87138) (#87323)
A few folks have asked me if it is possible to do timestamp ranges by using "now" in kql. This was missing from an example so I have added it to the docs.

(cherry picked from commit 48df620b1d30a9dcd08423204b66b453e50e587b)

Co-authored-by: Alex Close <alex.close@elastic.co>
2021-01-05 08:12:06 -08:00
Steph Milovic c7dac6502a
[Security Solution] Fixing jest warnings and errors (#86532) (#86652)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-01-05 09:10:10 -07:00
Lukas Olson 19f2de5614
[data.search.session] Store search strategy in saved object for background sessions (#86057) (#87264)
* [data.search.session] Store search strategy in saved object

* Update unit test to check strategy

* Fix test

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-01-05 08:27:10 -07:00
Mike Côté f5e6e4bc1b
Improve webhook errror messages (#87044) (#87297)
* Initial work

* Fix variables to pull from

* Rename some variables

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-01-05 10:23:03 -05:00
Larry Gregory 965eb079d2
Introduce mechanism to request default capabilities (#86473) (#87291) 2021-01-05 10:15:45 -05:00
Katrin Freihofner 76d8b49dd3
[7.x] [Logs UI] removes unnecessary panel in categories tabL (#86769) (#87283) 2021-01-05 16:02:54 +01:00
Katrin Freihofner 7cbf02682c
[7.x] [Synthetic check UI] waterfall view: moves arrow icon of next check btn to the right (#86878) (#87284)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-01-05 16:02:43 +01:00
Katrin Freihofner f93c0d71da
[7.x] [Logs UI] Adds purely visual changes to to the popovers and the settings view. (#86764) (#87282)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-01-05 16:02:26 +01:00
Bill McConaghy 52c963201e
adding docs about distinction between two and three curly braces for action variable interpolation (#87302) (#87307) 2021-01-05 10:01:09 -05:00
Nathan L Smith 4d9c635960
Toggle action and service icon menus (#87220) (#87262)
Make it so clicking the icon menu or action menu while the popover is open closes the popover. This also fixes the issue where the action menu would not close at all.

Rename the `onOpen` prop to `onClick` to match what it does.

Fixes #87161. Fixes #87131.
2021-01-05 08:56:56 -06:00
Casper Hübertz 66772ca31e
[APM] Settings: Move "HomeLink" into the sidebar (#87167) (#87289)
* Fixed responsive state when opening the menu

* Update x-pack/plugins/apm/public/components/app/Settings/index.tsx

Co-authored-by: Cauê Marcondes <55978943+cauemarcondes@users.noreply.github.com>
2021-01-05 15:36:58 +01:00
Vadim Dalecky 98485a5d57
[7.x] URL encoding for URL drilldown (#86902) (#87143)
* URL encoding for URL drilldown (#86902)

* feat: 🎸 use EuiSwitch for "Open in new window" toggle

* feat: 🎸 add "URL encoding" option and "Additional options"

* feat: 🎸 make "Open in new window" true by default

* feat: 🎸 respect encoding config setting

* test: 💍 add encoding tests

* feat: 🎸 add URI encoding Handlebars helpers

* docs: ✏️ add URL encoding methods to URL Drilldown docs

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

* test: 💍 align 7.x branch with master

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-01-05 15:00:38 +01:00
Devin W. Hurley 3e50b5f50f
[7.x] [Security Solution] [Detections] Multiple timestamp fields (#86368) (#86926)
* [Security Solution] [Detections] Multiple timestamp fields (#86368)

* query timestamp override and default @timestamp field, adds functional test for this

* fix logic for when to filter out timestamp override documents

* update the total hits field of the search result if we find hits within the secondary search. Without updating the total hits field, we could be finding events but not indexing them based on the bulk create logic

* update integration test, updates logic for performing second search and excluding documents with timestamp override field

* cleanup comments, remove commented out console logs, fix logic to break out of loop during secondary search after

* default param to 'succeeded'

* remove commented out code

* always perform a secondary search when timestamp override field is present

* perf improvement and fix bug where sortIds were being mixed between search after calls

* set sortIds to undefined when not present on search result

* exit loop and prevent extraneous searches from occurring if we exhaust sort ids

* skips test that was skipped in 8.0 / master
2021-01-05 08:16:45 -05:00