Commit graph

1211 commits

Author SHA1 Message Date
Alexey Antonov 69c4eb2859
Enable prototype pollution protection in TSVB (#85952) (#87087)
* Enable prototype pollution protection in TSVB

Closes #78908

* Update Dock API Changes

* Replace logging failed in validateObject validation with 400 error

* Move validateObject to kbn-std package and add a description

* Update Doc API Changes

* Rename validateObject function to ensureNoUnsafeProperties

* Rename other validateObject occurrences

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Diana Derevyankina <54894989+DziyanaDzeraviankina@users.noreply.github.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2020-12-31 12:58:36 +03:00
Spencer 943173b87f
[7.x] [ftr/flags] improve help text (#86971) (#86976)
Co-authored-by: spalger <spalger@users.noreply.github.com>
# Conflicts:
#	packages/kbn-test/src/functional_test_runner/cli.ts
2020-12-28 16:26:06 -07:00
Tyler Smalley 6597bfb732
[CI] Updates branch env variables (#86712) (#86865)
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
2020-12-23 09:00:18 -08:00
Nick Partridge 86563373c5
[7.x] Create vis_type_xy plugin to replace histogram, area and line charts (#78154) (#86534) 2020-12-18 22:00:58 -06:00
Brian Seeders 5ec653f170
Explicitly set Elasticsearch heap size during CI and local development (#86513) (#86573) 2020-12-18 19:56:24 -05:00
Dario Gieselaar 2df32de3a9
[7.x] expectSnapshot: throw on CI when snapshot is new (#85376) (#86450) 2020-12-18 20:30:02 +01:00
Garrett Spong 27ad160a9a
[Security Solution][Detections] - Add skeleton exceptions list tab to all rules page (#85465) (#86079)
## Summary

This PR is the first of 2 to complete the addition of a table displaying all exception lists on the all rules page. This PR focuses on the following:

- all exception lists displayed
- 'number of rules assigned to' displayed
- names and links of rules assigned to displayed
- refresh action button working
- no trusted apps list show
- search by `name`, `created_by`, `list_id`
  - just searching a word will search by list name
  - to search by `created_by` type `created_by:ytercero`
  - to search by `list_id` type `list_id:some-list-id`

#### TO DO (follow up PR)
- [ ] add tests
- [ ] wire up export of exception list
- [ ] wire up deletion of exception list

<img width="1121" alt="Screen Shot 2020-12-09 at 2 10 59 PM" src="https://user-images.githubusercontent.com/10927944/101676548-50498e00-3a29-11eb-90cb-5f56fc8c0a1b.png">

### Checklist
- [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md)
- [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials
- [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
- [ ] Any UI touched in this PR is usable by keyboard only (learn more about [keyboard accessibility](https://webaim.org/techniques/keyboard/))
- [ ] Any UI touched in this PR does not create any new axe failures (run axe in browser: [FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/), [Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))
- [ ] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
- [ ] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers)

### For maintainers

- [ ] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

Co-authored-by: Yara Tercero <yctercero@users.noreply.github.com>
2020-12-16 03:09:55 -05:00
Ahmad Bamieh 6c1d24fc31
[7.x] [Telemetry] Application Usage track sub application views (#85765) (#86072)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2020-12-16 06:11:57 +02:00
Alison Goryachev b3acc4b693
Handle multiple monaco editor instances for Painless lang (#85834) (#85962)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2020-12-15 13:45:11 -05:00
Tyler Smalley 82225db0a3
test:jest improvements to better support our monorepo (#84848) (#85880)
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
# Conflicts:
#	docs/developer/contributing/development-functional-tests.asciidoc
#	test/scripts/jenkins_unit.sh
#	test/scripts/jenkins_xpack.sh
#	x-pack/README.md

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2020-12-15 09:11:51 -08:00
Vadim Dalecky 3cc2de0ac7
Row trigger 2 (#83167) (#85766)
* feat: 🎸 add ROW_CLICK_TRIGGER

* feat: 🎸 wire row click event to UI Actions trigger in Lens

* feat: 🎸 add row click trigger to url drilldown

* feat: 🎸 add datatable to row click context

* feat: 🎸 pass in row index in row click trigger context

* feat: 🎸 add columns to row click trigger context

* feat: 🎸 fill values and keys event scope array

* feat: 🎸 generate correct row scope variables

* fix: 🐛 report triggers from lens embeddable

* feat: 🎸 add sample preview for row click trigger

* feat: 🎸 remove url drilldown preview box

* chore: 🤖 remove mock variable generation functions

* feat: 🎸 generate context and global variable lists

* feat: 🎸 preview event variable list

* feat: 🎸 show empty url error on blur

* feat: 🎸 add ability to always show popup for executed actions

* refactor: 💡 rename multiple action execution method

* fix: 🐛 don't add separator befor group on no main items

* feat: 🎸 wire in uiActions service into datatable renderer

* feat: 🎸 check each row if it has compatible row click actions

* feat: 🎸 allow passing data to expression renderer

* feat: 🎸 add isEmbeddable helper

* feat: 🎸 pass embeddable to lens table renderer

* feat: 🎸 hide lens table row actions which are empty

* feat: 🎸 re-render lens embeddable when dynamic actions chagne

* feat: 🎸 hide actions column if there are no row actions

* feat: 🎸 re-render lens embeddable on view mode chagne

* fix: 🐛 fix TypeScript errors

* chore: 🤖 fix TypeScript errors

* docs: ✏️ update auto-generated docs

* feat: 🎸 add hasCompatibleActions to expression layer

* feat: 🎸 remove "data" from expression renderer handlers

* fix: 🐛 fix TypeScript errors

* test: 💍 fix Jest tests

* docs: ✏️ update autogenerated docs

* fix: 🐛 wrap event payload into data

* test: 💍 add "alwaysShowPopup" test

* chore: 🤖 add comment requested in review

https://github.com/elastic/kibana/pull/83167#discussion_r537340216

* test: 💍 add hasCompatibleActions test

* test: 💍 add datatable renderer test

* test: 💍 add Lens embeddable input change tests

* test: 💍 add embeddable row click test

* fix: 🐛 add url validation

* test: 💍 add url drilldown tests

* docs: ✏️ remove url drilldown preview from docs

* docs: ✏️ remove preview from url templating

* docs: ✏️ add row click description

* chore: 🤖 move 36.5 KB bundle balance to url_drilldown

* test: 💍 simplify test case

* style: 💄 change types places

* refactor: 💡 clean up panel variable generation

* test: 💍 add getPanelVariables() tests

* fix: 🐛 generate runtime variables correctly

* fix: 🐛 improve getVariableList() and add tests for it

* feat: 🎸 add translation, improve types
# Conflicts:
#	packages/kbn-optimizer/limits.yml
2020-12-14 17:22:26 +01:00
Tyler Smalley 9e75c86101
Converts some Mocha unit tests to Jest (#85514) (#85687)
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
# Conflicts:
#	src/dev/code_coverage/ingest_coverage/either.test.js
#	src/dev/code_coverage/ingest_coverage/ingest_helpers.test.js
#	src/dev/code_coverage/ingest_coverage/team_assignment/enumerate_patterns.test.js
#	src/dev/code_coverage/ingest_coverage/team_assignment/enumeration_helpers.test.js
#	src/dev/code_coverage/ingest_coverage/transforms.test.js
2020-12-10 18:32:22 -08:00
Tyler Smalley 81508c664e
[@kbn/ui-framework] Removes all but dist files (#85347) (#85599)
This package has long since been deprecated and no longer maintained.
The only reason it still exists is that not all plugins have migrated
away from using the kui classes to EUI. This removes all src and build
files as a step forward.

Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
# Conflicts:
#	.eslintrc.js
#	packages/kbn-ui-framework/doc_site/src/components/guide_page/guide_page.js
#	yarn.lock
2020-12-10 11:32:31 -08:00
Spencer c72d5c0f08
[7.x] [mocha] find tests in ts files too (#85515) (#85608)
Co-authored-by: Spencer Alger <spalger@users.noreply.github.com>
Co-authored-by: Tyler Smalley <tyler.smalley@elastic.co>
2020-12-10 11:58:41 -07:00
Alison Goryachev 99f426c347
Update painless autocomplete definitions (#85464) (#85593) 2020-12-10 13:03:57 -05:00
Tiago Costa c3a0e2931c
chore(NA): add resolution for chokidar to prevent fsevents@1.x (#85171) (#85501)
* chore(NA): add fsevents resolution to 2.x

* chore(NA): add fsevents as an optionalDepedency to allow resolutions to be set for it

* chore(NA): remove fsevents resolution from package.json

* chore(NA): remove optionalDependencies from being declared

* chore(NA): update kbn pm dist

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2020-12-10 13:46:23 +00:00
Pierre Gayvallet 48a206334b
Add rolling-file appender to core logging (#84735) (#85524)
* You need to start somewhere

* revert comment

* rename default strategy to numeric

* add some tests

* fix some tests

* update documentation

* update generated doc

* change applyBaseConfig to be async

* fix integ tests

* add integration tests

* some renames

* more tests

* more tests

* nits on README

* some self review

* doc nits

* self review

* use `escapeRegExp` from lodash

* address some review comments

* a few more nits

* extract `isDevCliParent` check outside of LoggingSystem.upgrade

* log errors from context

* add defaults for policy/strategy
2020-12-10 12:26:43 +01:00
Josh Dover 5ea8281627
[7.x] Add server.publicBaseUrl config (#85075) (#85361) 2020-12-09 16:10:16 -07:00
Tyler Smalley 0c9a3c0979
[7.x] Removes Grunt abstraction from CI tasks (#85210) (#85448)
* Removes Grunt abstraction from CI tasks (#85210)

Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
# Conflicts:
#	tasks/config/run.js
#	test/scripts/jenkins_ci_group.sh
#	test/scripts/jenkins_unit.sh

* [CI] Set correct script execute permissions (#85475)

Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2020-12-09 14:54:03 -08:00
Spencer c2eb39d342
[ci/docker] stop removing containers to avoid disrupting chrome (#85425) (#85466)
Co-authored-by: spalger <spalger@users.noreply.github.com>

Co-authored-by: spalger <spalger@users.noreply.github.com>
2020-12-09 14:16:32 -07:00
Poff Poffenberger a6e71edbf0
[Time to Visualize] Add visualizations to dashboard from save modal (#83140) (#85345)
Co-authored-by: Ryan Keairns <contactryank@gmail.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>
# Conflicts:
#	packages/kbn-optimizer/limits.yml
2020-12-09 10:37:25 -06:00
Stacey Gammon e648af4fb9
Convert a README to mdx to get it slurped up by the new docs system (#84834) (#85335)
* Convert readme to mdx so it can get slurped into the new docs system

* Adjust plugin list doc generation so it accounts for mdx readmes

* fix eslint of discover_plugin file

* Fix link to readme in plugin list

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2020-12-08 20:46:03 -05:00
Alison Goryachev 928254db4b
Enhancements to painless autocomplete in monaco (#85055) (#85306) 2020-12-08 14:07:33 -05:00
Alison Goryachev 5667e60343
Implement error reporting in monaco for painless language (#84695) (#85283) 2020-12-08 13:03:10 -05:00
Spencer d51aaab791
[7.x] [esArchiver] support kibana and es ssl from cli (#85073) (#85187)
Co-authored-by: spalger <spalger@users.noreply.github.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: spalger <spalger@users.noreply.github.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2020-12-07 15:08:47 -07:00
Spencer 28663e102c
[7.x] [cli/dev] remove cluster module, modernize, test (#84726) (#85174)
Co-authored-by: Alejandro Fernández Haro <afharo@gmail.com>
Co-authored-by: spalger <spalger@users.noreply.github.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2020-12-07 13:20:03 -07:00
Alison Goryachev fb7bdf8dfc
Integrate painless autocomplete in runtime fields editor (#84943) (#85170) 2020-12-07 14:43:51 -05:00
Tiago Costa 9fc59820d1
chore(NA): check git version on pre-commit hook install (#84811) (#85058)
* chore(NA): checks installed git version when installing pre-commit hook

* chore(NA): throw an error instead of log a warning

* chore(NA): use createFailError instead

* fix(NA): apply feedback from pr review for isCorrectGitVersionInstalled

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2020-12-04 20:55:24 +00:00
Ahmad Bamieh 7824e075a3
[7.x] [Telemetry] Introduce UI Counters (#84224) (#85038)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2020-12-04 19:55:54 +02:00
Tyler Smalley 9a8351cce1
[CI] Enables APM collection (#81731) (#84929)
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
2020-12-03 11:13:53 -08:00
Mikhail Shustov 645eae82b7
[7.x] Rename server.xsrf.whitelist to server.xsrf.allowlist (#84791) (#84861)
* Rename server.xsrf.whitelist to server.xsrf.allowlist (#84791)

* rename xsrd.whitelist to xsrf.allowlist

* update docs

* update telemetry schema

* update kbn-config tests
# Conflicts:
#	src/core/server/config/deprecation/core_deprecations.ts

* Update core_deprecations.ts

* miss import
2020-12-03 15:51:44 +01:00
Thomas Watson 0b8e7a026f
Improve logging pipeline in @kbn/legacy-logging (#84629) (#84868) 2020-12-03 13:54:20 +01:00
Thomas Watson a4cad7735d
Catch @hapi/podium errors (#84575) (#84867) 2020-12-03 13:54:02 +01:00
Thomas Watson fdb71b6f44
Upgrade Node.js to version 14 (#83425) (#84846) 2020-12-03 09:35:10 +01:00
Tyler Smalley f9fd733a12
Jest multi-project configuration (#77894) (#84826)
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
# Conflicts:
#	src/dev/code_coverage/ingest_coverage/integration_tests/team_assignment.test.js
#	src/plugins/console/jest.config.js
#	x-pack/plugins/canvas/scripts/jest.js
2020-12-02 14:02:21 -08:00
Spencer af323c4c02
[7.x] declare kbn/monaco dependency on kbn/i18n explicitly (#84660) (#84683)
Co-authored-by: Mikhail Shustov <restrry@gmail.com>
2020-12-01 12:13:16 -07:00
Thomas Watson d4cc408bad
Update code-comments describing babel plugins (#84622) (#84655) 2020-12-01 17:38:44 +01:00
Mikhail Shustov 4efd1d9493
Cleanup tsconfig files (#84396) (#84568)
* remove unused "paths" from tsconfig

* remove unused test utils, import get-url from kbn/test

* dont pollute globals with jest when importing getUrl

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2020-11-30 23:30:31 +01:00
Alison Goryachev 9bc8d30bf4
Support for painless language autocomplete within monaco (#80577) (#84522) 2020-11-30 11:59:53 -05:00
Pierre Gayvallet 8e1fe698e9
increase stdout max listeners for legacy logging (#84497) (#84514)
* increase stdout max listeners for legacy logging

* add missing packages to CODEOWNERS
# Conflicts:
#	.github/CODEOWNERS
2020-11-30 17:16:25 +01:00
Spencer ad815fda58
[7.x] [dev/cli] detect worker type using env, not cluster module (#83977) (#84349)
* [dev/cli] detect worker type using env, not cluster module

* remove unused property

* assume that if process.send is undefined we are not a child

* update comment

Co-authored-by: spalger <spalger@users.noreply.github.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: spalger <spalger@users.noreply.github.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2020-11-25 11:29:56 -07:00
Thomas Watson 9d8d283f79
Use correct version of Podium (#84270) (#84280) 2020-11-25 07:19:42 +01:00
Tyler Smalley 66adfb625e
[@kbn/utils] Clean target before build (#84253) (#84274)
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
2020-11-24 16:26:28 -08:00
Brian Seeders 747c993d2c
[7.x] [CI] Initial TeamCity implementation (#83975) 2020-11-24 16:29:08 -05:00
Dario Gieselaar 5beb2433d4
Improve snapshot error messages (#83785) (#83806)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2020-11-24 22:02:10 +01:00
Mikhail Shustov e77769a9ac
[DX] Bump TS version to v4.1 (#83397) (#84234)
* bump version to 4.1.1-rc

* fix code to run kbn bootstrap

* fix errors

* DO NOT MERGE. mute errors and ping teams to fix them

* Address EuiSelectableProps configuration in discover sidebar

* use explicit type for EuiSelectable

* update to ts v4.1.2

* fix ts error in EuiSelectable

* update docs

* update prettier with ts version support

* Revert "update prettier with ts version support"

This reverts commit 3de48db3ec.

* address another new problem

Co-authored-by: Chandler Prall <chandler.prall@gmail.com>
# Conflicts:
#	test/functional/services/remote/remote.ts
2020-11-24 18:56:21 +01:00
Mikhail Shustov 264d05e29c
Move streams to kbn/utils (#84033) (#84219)
* move streams to kbn/std

* import streams from kbn/std

* fix styles

* remove unused shareWeakReplay

* move from kbn/std to kbn/utils

* import from subfolder since test mocks FS module and not compatible with kbn/utils

* remove new line at the end of json file
2020-11-24 18:08:15 +01:00
Spencer fa80376101
[7.x] [src/cli/dev] remove broken and unused --open flag (#83966) (#84137)
Co-authored-by: spalger <spalger@users.noreply.github.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: spalger <spalger@users.noreply.github.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2020-11-23 13:32:29 -07:00
Mikhail Shustov de6090c87b
[7.x] [DX] Prettier v2.2 (#83899) (#84114)
* [DX] Prettier v2.2 (#83899)

* update prettier with ts version support

* mute type-error

* run prettier on codebase

* fix examples

* fix errors after master merged
# Conflicts:
#	x-pack/plugins/index_management/public/application/components/mappings_editor/mappings_editor.tsx
#	x-pack/plugins/upgrade_assistant/server/lib/telemetry/usage_collector.ts

* fix add removed property
2020-11-23 21:24:39 +01:00
Tiago Costa 450571e027
chore(NA): remove yarn lock from kbn legacy logging (#84096) (#84125)
* Revert "[Search] Search batching using bfetch (#83418)"

This reverts commit 5708c5d004.

* chore(NA): remove yarn.lock from kbn-legacy-logging
2020-11-23 19:31:39 +00:00