Commit graph

35721 commits

Author SHA1 Message Date
Eric Davis 1c428ffed7
fixing encoding issue with \ for enroll command (#74379) 2020-08-05 14:11:27 -04:00
Nicolas Ruflin c0bb5375e0
[Ingest Manager] Update package registry for testing to f6b01d (#74341)
Many changes went into the registry and the packages recently. This is updating to the most recent version of the registry distribution currently in production.


Co-authored-by: Sonja Krause-Harder <sonja.krause-harder@elastic.co>
2020-08-05 20:01:52 +02:00
Tim Roes c8597ec84b
Change experimental message for visualizations (#74354) 2020-08-05 19:52:00 +02:00
Gidi Meir Morris 41e3128ecd
[Alerting] Reload the Alerts List when alerts are deleted (#73715)
Reloads the entire Alerts list when alerts are deleted through the UI.
2020-08-05 18:48:09 +01:00
Constance 47b9aba3bf
[Enterprise Search] Fix/DRY out plugin i18n strings (#74323)
* i18n refactor

- DRY out plugin details to constants and correctly i18n-ize front-end-facing strings

* DRY out new i18n constants

- refactor instances of i18n.translate to use new constants

* Fix non-i18n'd breadcrumb strings

* PR feedback: swap out more plugin ID strings for constants
2020-08-05 10:12:25 -07:00
Melissa Alvarez 4150a234c8
update empty prompt in analytics list (#74174) 2020-08-05 12:43:58 -04:00
Gidi Meir Morris 5c770e5930
[Task Manager] Correctly handle running tasks when calling RunNow and reduce flakiness in related tests (#73244)
This PR addresses two issues which caused several tests to be flaky in TM.

When `runNow` was introduced to TM we added a pinned query which returned specific tasks by ID.
This query does not have the filter applied to it which causes task to return when they're already marked as `running` but we didn't address these correctly which caused flakyness in the tests.
This didn't cause a broken beahviour, but it did cause beahviour that was hard to reason about - we now address them correctly.

It seems that sometimes, especially if the ES queue is overworked, it can take some time for the update to the underlying task to be visible (we don't user `refresh:true` on purpose), so adding a wait for the index to refresh to make sure the task is updated in time for the next stage of the test.
2020-08-05 17:35:38 +01:00
Marta Bondyra cf6413ab2f
[Lens] fix chart switching when on VisualizationDimensionEditor (#70689) 2020-08-05 18:25:16 +02:00
Yara Tercero e23c5eafa1
[Security Solution][Exceptions] - Fixes builder overflow and updates ux for nested entries (#74262)
## Summary

- updates the builder nested entries so that the children do not display the parent path - so instead of `parent.child` it just shows `child`
- updates the builder to fix overflow issue
2020-08-05 12:10:28 -04:00
MadameSheema 549c256390
[SIEM] Adds rule override Cypress tests (#74367)
* implements rule override test

* refactors the code
2020-08-05 17:45:30 +02:00
Mikhail Shustov 88c0631344
Update @typescript-eslint to ensure compatibility with TypeScript v3.9 (#74091)
* bump @typescript-eslint deps

* update rules

* fix errors in pacakges

* fix src/

* fix x-pack

* fix test

* fix typings

* fix examples

* allow _ as prefix and suffix

* roll back prefix and suffix changes

* add eslint-plugin-eslint-comments

* report unused rules

* remove unused eslint comments from tests

* remove unused eslint comments 2nd pass

* remove unused eslint comments from src/

* remove unused comments in x-pack

* use no-script-url and no-unsanitized/property for ts files

* remove unused eslint comments

* eui/href-or-on-click removed when not complained

* no import/* rules for ts files

* cleanup

* remove the unused eslint-disable

* rollback unnecessary changes

* allow underscore prefix & sufix in type name

* update docs

* fix type error in enterprise search plugin mocks

* rename platform hack __coreProvider --> _coreProvider

* rollback space removal in src/core/public/legacy/legacy_service.test.ts

* fix naming convention in APM
2020-08-05 17:32:19 +02:00
Melissa Alvarez 3fb77fb546
[ML] DF Analytics creation wizard: show link to results (#74025)
* show view results card once job complete

* update types

* update types and move css to own file
2020-08-05 10:31:47 -04:00
Mikhail Shustov 8759646576
update docs (#74364) 2020-08-05 15:28:03 +02:00
Alison Goryachev bf22fe54e1
[Ingest Node Pipelines] Refactor pipeline simulator code (#72328) 2020-08-05 09:21:57 -04:00
Tim Roes f9fc83fb1d
Add README files for Kibana app plugins (#74277)
* Add README files for Kibana app plugins

* Update src/plugins/timelion/README.md

Co-authored-by: Matthias Wilhelm <ankertal@gmail.com>

* Update src/plugins/vis_type_vislib/README.md

Co-authored-by: Matthias Wilhelm <ankertal@gmail.com>

Co-authored-by: Matthias Wilhelm <ankertal@gmail.com>
2020-08-05 14:28:56 +02:00
Cauê Marcondes 7a1b09dcf1
[APM] Average for transaction error rate includes null values (#74345) 2020-08-05 14:28:13 +02:00
Sonja Krause-Harder b26bd6175d
[Ingest Manager] Adjust dataset aggs to use datastream fields instead (#74342)
* [Ingest Manager] Adjust dataset aggs to use datastream fields instead

Elastic Agent and Elasticsearch are switching over from using dataset.* to datastream.*. This adjust the aggregation on the dataset page to get the datastreams.

For this to work properly, the most recent version of Elasticsearch 7.9 must be used and is pending updates on all the packages to ship also the datastream fields, see https://github.com/elastic/integrations/pull/213

* Update datastream to data_stream

* Update data stream name generation

* Fix typo

* Temporarily use datastream instead of data_stream

* updating to use `data_stream` instead of `datastream`

Co-authored-by: ruflin <spam@ruflin.com>
Co-authored-by: Jen Huang <its.jenetic@gmail.com>
2020-08-05 13:48:11 +02:00
Dima Arnautov 8231b0ccfc
[ML] Fix initial plugin's bundle size (#74047)
* [ML] use dynamic imports

* [ML] fix react-use imports

* [ML] change embeddables imports

* [ML] embeddable exports

* [ML] move SCSS import

* [ML] management page styles

* [ML] refactor with types and constants files

* [ML] move declarations
2020-08-05 13:18:29 +02:00
John Schulz beb7b8245d
[Ingest Manager] prevent crash on unhandled rejection from setupIngestManager (#74300)
* Add test to ensure setup rejects if errors thrown.

* Return the promise from setup so test passes
2020-08-05 07:08:04 -04:00
Alejandro Fernández 22d6f09d31
[Logs UI] Correct trial period duration in anomaly splash screen (#74249) 2020-08-05 11:19:41 +02:00
Matthias Wilhelm c24b17f334
[Discover] Inline noWhiteSpace function (#74331)
* Inline noWhiteSpace function

* Fix TypeScript

* Remove unused function file
2020-08-05 10:49:36 +02:00
EamonnTP f97641c84a
[DOCS] Add Observability topic (#73041)
* Add observability content

* Remove xpack from file name

* Updates following review

* Review edits

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-08-05 09:28:20 +01:00
spalger 7c60b09baa skip flaky suite (#74327) 2020-08-05 00:05:27 -07:00
Garrett Spong 22809274eb
[Security Solution][Detections] Fixes Severity Override not matching for Elastic Endpoint Security rule (#74317)
## Summary

Fixes an issue where the `Severity Override` would not match for the `Elastic Endpoint Security` rule. This is a temporary fix until we can provide more robust comparisons between the user provided `severityMapping.value` (string) and the `severityMapping.field`'s type.  

### Checklist

- [x] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios
2020-08-04 19:36:34 -06:00
Yara Tercero 6a77bec233
[Security Solution][Exceptions] - Fixes exceptions builder nested deletion issue and adds unit tests (#74250)
### Summary

- Updates logic for deleting exception item entries in the builder - found that there was a bug in deleting nested entries
- Adds more unit tests
2020-08-04 20:06:30 -04:00
Yuliia Naumenko 36f25e66e8
Fixed Alert details does not update page title and breadcrumb (#74214)
* Fixed Alert details does not update page title and breadcrumb

* Added alert name to details breadcrumb as a dynamic title

* Update x-pack/plugins/triggers_actions_ui/public/application/lib/breadcrumb.ts

Co-authored-by: Mike Côté <mikecote@users.noreply.github.com>

Co-authored-by: Mike Côté <mikecote@users.noreply.github.com>
2020-08-04 16:00:56 -07:00
Spencer 409779d1ed
[src/dev/build] build Kibana Platform bundles from source (#73591)
Co-authored-by: spalger <spalger@users.noreply.github.com>
2020-08-04 15:34:01 -07:00
Tim Sullivan 372d8817a7
[Reporting] Shorten asset path to help CLI FS Watcher (#74185) 2020-08-04 14:27:44 -07:00
Aaron Caldwell c123cfead7
Fix TMS not loaded in legacy maps (#73570)
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-08-04 15:15:57 -06:00
Angela Chuang 2eb67130f3
[Security Solution] styling for notes' panel (#74274)
* styling for notes' pannel

* styling

* remove additional const

* styling
2020-08-04 21:19:05 +01:00
Frank Hassanabad f506279a55
[Security Solution][Tech Debt] cleans up ts-ignore issues and some smaller linter issues (#74268)
## Summary

* Removes ts-ignore where it is not being used
* Replaces ts-ignore with the better alternative which is the ts-expect-error
2020-08-04 14:04:45 -06:00
Mike Côté 54e13ad6f6
Make the actions plugin support generics (#71439)
* Initial attempt at making the actions plugin support generics

* Export WebhookMethods

* Fix typings for registry

* Usage of Record<string, unknown>

* Apply feedback from Gidi

* Cleanup

* Fix validate_with_schema

* Cleanup pt2

* Fix failing tests

* Add generics to ActionType for ActionTypeExecutorResult

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-08-04 15:50:17 -04:00
Angela Chuang 8e0e228dbf
[Security Solution] Keep original note creator (#74203)
* keep original note creator

* unit test

* fix types

* typo

* wording
2020-08-04 15:35:00 -04:00
Brian Seeders ea4d36f713
[CI] Fix xpack kibana build dir in xpack visual regression script 2020-08-04 15:27:04 -04:00
Brian Seeders b7a8a4a54a
[CI] Fix baseline_capture job by adding parallel process number back 2020-08-04 14:19:26 -04:00
Chris Roberson de22caa0f6
[Monitoring] Ensure setup mode works on cloud but only for alerts (#73127)
* Ensure setup mode works on cloud but only for alerts

* Update snapshot

* Update translations

* Restructure tests to understand the failure better

* PR feedback

* Backwards, whoops

* Remove commented out code

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-08-04 13:32:21 -04:00
Thomas Neirynck 3067184c45
[Maps] Custom color ramps should show correctly on the map for mvt layers (#74169) 2020-08-04 13:30:09 -04:00
Spencer 0502fee651
[kbn/optimizer] remove unused modules (#74195)
Co-authored-by: spalger <spalger@users.noreply.github.com>
2020-08-04 10:19:51 -07:00
Brian Seeders 0ca8e99a9f
[CI] Add pipeline task queue framework and merge workers into one (#71268) 2020-08-04 13:13:51 -04:00
Jonathan Buttner 2dea17a8d0
Using msearch for tree api endpoint (#73813) 2020-08-04 12:54:20 -04:00
Kerry Gallagher 89dba39273
Handle modifier keys (#74237) 2020-08-04 17:13:32 +01:00
Angela Chuang b42f64d1a2
[Security Solution] Load prepackage timelines by default (#74209)
* load prepackage timelines by default

* fix unit tests
2020-08-04 16:57:53 +01:00
Sandra Gonzales 8e0ae5ffd1
add force install option (#74172) 2020-08-04 10:54:11 -05:00
Ben Skelker f3fbb7d79f
[Security Solution]Updates exception options and setting text (#73769)
* updates exception text

* updates modal text

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-08-04 17:42:51 +03:00
Poff Poffenberger 7208a5746a
[Canvas] Fix Custom Element functional test (and remove skip) (#73727)
* Remove skip of custom elements
2020-08-04 09:18:47 -05:00
Patryk Kopyciński ecc7fcec40
[Security Solution] Fix Fullscreen view (#74236) 2020-08-04 15:56:18 +02:00
Vadim Dalecky 23fedcf636
feat: 🎸 navigate from maps embeddable to app in SPA way (#74102) 2020-08-04 15:25:53 +02:00
Vadim Dalecky 4f2209b209
refactor: 💡 clean up and simplify replace panel input update (#74076) 2020-08-04 15:20:57 +02:00
Frank Hassanabad 73077c3d19
Fixes one more spot where we forgot to add plumbing for the strict_date_optional_time (#74211)
## Summary

Related closed issues:
https://github.com/elastic/kibana/issues/58965
https://github.com/elastic/kibana/pull/70713

If you add a custom mapping and go to the hosts details page you will get an error toaster:
<img width="838" alt="Screen Shot 2020-08-03 at 7 53 16 PM" src="https://user-images.githubusercontent.com/1151048/89244409-a7df7500-d5c3-11ea-933c-99d96bffc589.png">

If running local host you can configure your index patterns to use a custom one I setup with custom date time formats and a single record which can cause this:
<img width="1223" alt="Screen Shot 2020-08-03 at 7 50 12 PM" src="https://user-images.githubusercontent.com/1151048/89243967-8fbb2600-d5c2-11ea-8de2-4422e870f9f0.png">


Then visit this URL and set your date time to go backwards by 1 year
```ts
http://localhost:5601/app/security/hosts/app/security/hosts/MacBook-Pro.local/alerts
```

And with the fix you no longer get the error toaster.
2020-08-04 06:54:47 -06:00
Marco Liberati c78da24708
[ Functional Tests ] TVSB charts flaky tests on index pattern switch fix (#74110)
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-08-04 14:44:16 +02:00