## Summary
Fixes fully this issue: https://github.com/elastic/kibana/issues/49753
If you go to advanced settings and configure siemDefaultIndex to be an empty string or have empty spaces:
<img width="1291" alt="Screen Shot 2020-07-31 at 12 52 00 PM" src="https://user-images.githubusercontent.com/1151048/89067511-a9434000-d32c-11ea-9106-e2079a5db317.png">
You shouldn't get any toaster errors when going to any of the pages such as overview, detections, etc...
This fixes that and adds both unit and integration tests around those areas. The fix is to add a filter which will filter all the patterns out that are either empty strings or have the _all within them rather than just looking for a single value to exist.
### Checklist
Delete any items that are not applicable to this PR.
- [x] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios
* Temporarily unload all other functional tests.
* Unskip certificates test.
* Uncomment skipped test files.
* Add explicit fields to check generator call to prevent grouping issues that can lead to test flakiness.
* added wait for loading
* update missing func
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Co-authored-by: Shahzad <shahzad31comp@gmail.com>
* wip: add reducer action to switch to form
* rename getFormStateFromJobConfig
* wip: types fix
* show destIndex input when switching back from editor
* ensure validation up to date when switching to form
* cannot switch back to form if advanced config
* update types
* localization fix
* Ensure cursor is called until full results are receeived
* Fix Typecheck
* Convert dependencies to typescript
* Fix typings
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
- Migrate to React BrowserRouter and Kibana provided History including a fallback to redirect legacy hash based URLs.
- Migrate breadcrumbs away from hash based URLs.
- Make sure relative custom urls still work after migration.
## Summary
Addresses feedback from https://github.com/elastic/kibana/pull/72748
- Updates `plugins/lists` tests text from `should not validate` to `should FAIL validation` after feedback that previous text is a bit confusing and can be interpreted to mean that validation is not conducted
- Remove unnecessary spreads from one of my late night PRs
- Removes `siem_common_deps` in favor of `shared_imports` in `plugins/lists`
- Updates `build_exceptions_query.test.ts` to use existing mocks
* Same behavior as now. Just refactored.
* main branch uses epr-snapshot. Others use prod
* Link some types vs repeating them
* replace DEFAULT_REGISTRY_URL with getRegistryUrl in Endpoint tests
* Make an Endpoint test helper name more clear
* try/catch around getKibanaBranch
* Use branch & version from package.json as fallback
* No guards b/c kibana{Branch,Version} have defaults
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
## Summary
This PR provides a workaround for the autocomplete service not providing suggestions when the selected field is `someField.text`. As endpoint exceptions will be largely using `.text` for now, wanted to still provide the autocomplete service.
Updates to the autocomplete components were done after seeing some React errors that were popping up related to memory leaks. This is due to the use of `debounce` I believe. The calls were still executed even after the builder component was unmounted. This resulted in the subsequent calls from the autocomplete service not always going through (sometimes being canceled) when reopening the builder.
Moved the filtering of endpoint fields to occur in the existing helper function so that we would still have access to the corresponding `keyword` field of `text` fields when formatting the entries for the builder.
