Commit graph

27569 commits

Author SHA1 Message Date
Mike Côté 68ffe7e18b
Update alerting docs to mention manage_api_key cluster privilege requirement (#45375)
* Update alerting docs to mention manage_api_key cluster privilege requirement

* Update docs
2019-09-13 15:42:02 -04:00
Brian Seeders e3a3b7fbd8
Fix a few issues related to sending emails in pipeline (#45470) 2019-09-13 15:15:49 -04:00
Tim Sullivan 9a56d426ed
[Reporting/ESQueue] data read/write failures are error logs (#45478)
* [Reporting/ESQueue] data read/write failures are error logs

* fix warning level
2019-09-13 11:39:31 -07:00
Nate Archer 84a56d580a
[DOCS][CODE]: Rename "Getting started with Code" to "Import your first repo" (#44924) (#45471)
* [DOCS] Fix beta tag in Code Docs

* [DOCS][CODE]: Issue #44924 - Rename Get started to Import your first repo
2019-09-13 13:33:09 -05:00
Lisa Cawley 7c75aa2bb2
[DOCS] Moves monitoring content into user folder (#45594) 2019-09-13 11:31:12 -07:00
Spencer ef5c520826
Call failure reporter directly from Jenkinsfile (#45551)
* Run failed_tests/cli once per node

* force failures for testing

* Revert "force failures for testing"

This reverts commit 3ddd9240fe.
2019-09-13 11:15:38 -07:00
Tim Sullivan 4a9dc664c6
[Reporting/Typescript] Fix types for JobParamsPDF, BrowserConfig, ChromiumDriverFactory (#45209)
* [Reporting] Correct PDF Params type definition

* Fix types for BrowserConfig, ChromiumDriverFactory

* remove jobparams type

* spot fixes

* fix guard in compat shim

* fix legacy functional test

* fix jest test
2019-09-13 10:54:41 -07:00
Lisa Cawley 5478b4a610
[DOCS] Moves reporting content into user folder (#45588) 2019-09-13 10:47:55 -07:00
Lisa Cawley 87cdfd2ae1
[DOCS] Moves graph content into user folder (#45591) 2019-09-13 10:10:32 -07:00
Justin Kambic 271be95171
[Uptime] Add TLS cert expiry to GQL schema for individual docs (#44506)
* Add certificate expiration date to uptime GQL schema.

* Update test fixture/snapshot for broken unit test.

* Extract TLS data to two separate GQL types.

* Remove unused field from schema/adapters.

* Update broken functional tests.

* Extract TLS data to two separate GQL types.

* Remove unused field from schema/adapters.

* Update broken functional tests.

* Modify schema/types and parsing code to avoid weird data structure.

* Fix busted test snapshot/mock data.
2019-09-13 12:52:15 -04:00
Alison Goryachev 7e359276be
Address accessibility issues in management apps (#45024) 2019-09-13 12:14:26 -04:00
Ryland Herrick 79d531cecc
[Code] Results change with search context (#45545)
* Clean up test setup

Removes a redundant assignment.

* Update search suggestions after scope changes

Without the additional call to this.updateSuggestions, the autocomplete
suggestions remain from the previous scope and no action is taken until
the user submits the search form.

This also adds a null check on the `onSearchScopeChanged` prop.

* Test search scope change functionality

Adds a basic test around the search scope functionality in the QueryBar
component.

Unfortunately, due to the fact that the searchScope prop is actually
controlled in a parent, this test is of questionable utility.
2019-09-13 10:50:41 -05:00
gchaps af55ea9499
[DOCS] Updates Graph documentation (#45597)
* [DOCS] Updates Graph documentation

* [DOCS] Incorporates review feedback
2019-09-13 07:44:01 -07:00
Walter Rafelsberger d8cc11d87d
[ML] Single metric viewer: Fix race condition when changing jobs. (#45420)
Fixes a race condition where changing jobs in Single Metric Viewer could result in the focus chart being empty.
Applying the job change would cause two events to be triggered which would cause the Single Metric Viewer to refresh twice: The updated time range would be triggered via timefilter, the updated jobs via the globalState listener.
This PR solves the problem by setting a global flag skipRefresh which allows us to skip updating single metric viewer and only update again once both the new time range and jobs are set. The PR also adds some checks to avoid unnecessary updates in d3 code triggered by React render calls.
2019-09-13 07:36:26 -07:00
Joe Reuter 6763836bc7
[Graph] Settings EUI-ification (#44587)
* create graph listing page

* clean up app folder

* remove inline loading menu

* also add badge to workspace route

* fix tests

* fix graph spaces functional test

* generate documentation for new breadcrumb property

* fix test subject names

* remove unused translations

* start implementing save modal flow for Graph

* fix spaces functional test

* wip save modal

* wip save modal

* add and style save modal

* add placeholder to description field

* disable dirty check on breadcrumb navigation and fix delete function

* reactify most of settings

* improve onClick typing on breadcrumb

* fix newline error and use new types in dashboard app controller

* EUIify drilldown

* EUIify drilldown

* fix translation errors

* fix i18n translation for real

* fix icon and work on autoreplace template logic

* use switch instead of checkbox

* code review

* fix i18n phrases

* remove fragments

* add KQL encoder to be able to drill down to discover

* fix flyout overflow issue

* delete old settings logic

* remove obsolete files

* fix tests

* fix i18n phrase typo

* fix most translations

* start implementing review comments

* continue implementing review

* continue cleanup of settings forms

* remove unnecessary max-width and add commentary

* move to async syntax

* clean up implementation

* use description instead of title

* work on settings form

* fix snapshot

* fix drilldown list

* add tests for use_list_keys

* rename stuff and add documentation

* fix translatiojns

* fix some rename references

* start typing saving and loading

* typing persistence stuff

* adress review comments and set width for all save modals

* type serializing logic

* fix bug and improve typing

* fix classname

* wip

* wip

* add notes

* style blacklist group

* remove merge marker

* improve icon rendering

* wip

* start refactoring

* remove js implementation

* remove js implementation

* remove duplicate file

* add some tests

* Design cleanup

* Fix SASS files

* revert style fixes in app.js

* implement todos

* fix errors and prematurely enabling inspect panel

* deselect icon after clicking again

* fix types

* make icon list accessible

* clean up and add some more tests

* improve number handling

* fix deserialization

* polishing drilldown-ui

* rename types

* clean up imports

* fix tests

* add handling for canEditDrillDowns setting

* propagate changes to workspace client

* align tabs with other elements
2019-09-13 15:30:58 +02:00
Walter Rafelsberger ea4900b4c6
[ML] Single metric viewer: Fix cell selection flickering. (#45500)
- Fixes a flickering effect when selecting cells in the Single Metric Viewer's swimlane. Previously, during selection, dragSelect took care of highlighting cells. The dragSelect-selection would then be cleared and the d3-based selection only took over after new data was loaded which resulted in the selection not being visible during loading. Now, the dragSelect-selection is only cleared immediately if only cells not containing any anomalies were selected.
- Also fixes a bug where only the first and last cell in the overall swimlane would be highlighted instead of the full range of selected cells.
2019-09-13 06:18:55 -07:00
Devin W. Hurley 8bc8ae2053
[SIEM] Enable eslint rule for duplicate import statements (#45552)
* enable eslint rule for duplicate import statements

* updates lint warn to an error
2019-09-13 09:15:42 -04:00
Liza Katz e4225a70d9
Rename QueryBar to QueryBarTopRow (#45250)
* rename QueryBar to QueryBarTopRow

* Fixed test typo

* Fixed search bar mock
2019-09-13 16:11:25 +03:00
Walter Rafelsberger ec5d1a9ce9
[ML] Fixes getTab() to always return an array. (#45616)
- Fixes getTabs() to always return an array. I was wondering why TypeScript didn't flag the tabs.map(...) part because tabs could possibly be undefined. It's because Record assumes that every key exists. More on that can be found in this blog post.
- This PR fixes a) the type of TAB_MAP by wrapping it in Partial<...> so it correctly flags the tabs.map() part with tabs possibly being undefined and b) fixes getTabs()'s return value by always returning an array.
2019-09-13 05:39:38 -07:00
Artyom Gospodarsky fa7614b360
Move as_pretty_string.js (#45356)
* Convert asPrettyString to TS

* Migrate asPrettyString() to plugins/data
2019-09-13 14:29:41 +03:00
Xavier Mouligneau f5e91da99c
[SIEM] Fix paginated table state when switching tab (#45487)
* Keep state of host/netwrok table when switching tab

* keep state in the event viewer when switching tab in host page

* refactor test to ensure activePage updates from prop change

* rm comments

* add/fix unit test

* fix i18n

* need to rm weird files

* rm weird files

* fix inspect button for real + loading view between tabs

* cleanups

* commented by mistake

* fix logic loading

* review I

* review II

* review III

* review IV
2019-09-13 07:22:27 -04:00
Maryia Lapata 1223ab97a6
[Vis: Default Editor] EUIficate 'Metrics & Axis' tab (#43772)
* EUIficate pointe-series and grid

* Apply TS

* Show grid on a panel

* Remove extra space

* Add TS

* Use BasicOptions

* Adjust func test

* Add dataTestSubj prop to SelectOption

* Use id instead of data-sest-subj

* Disable show x-axis lines when there is histogram agg

* Add tooltip for disabled 'Show x-axis lines' config

* Add series_options.tsx

* Migrate series

* Improve changeValueAxis

* Create CategoryAxisPanel

* Create ValueAxesPanel

* Create CustomExtentsOptions

* File renaming

* Use TruncateLabelsOption

* Set min value

* Add validation

* Refactoring

* Move types upper

* Convert series logic

* Convert valueAxes logic

* Rename function

* Add validation and refactoring

* Adjust styles

* Fix rotates

* Apply config for other vis

* Remove old directives

* Fix useHook usage

* Update vislib_vis_type.js

* Fix

* Move Threshold line panel into a separate component

* Remove unused translations

* Apply ui suggestions

* Update functional tests

* Remove angular unit test

* Refactoring

* Fix dependencies

* Refactoring

* Add validation

* Add validation for other vis

* Refactoring of onPositionChanged handler

* Refactoring of addValueAxis

* Get rid of a useEffect

* Refactoring of updateAxisTitle

* Update useCallback

* Refactoring

* Refactoring of collections config

* Refactoring of setChartValueByIndex and setValueAxisByIndex

* Update metrics_axes_options.tsx

* Watch current tab for correct accordion height

* Revert axis title logic

* Fix axis id and name number

* Fix code review comments

* Fix functional tests

* Update visualize_page.js

* Move option tabs in common

* Fix code review comments

* Update index.tsx

* Refactoring

* Fix merge conflict

* Show ThresholdPanel when it's configured

* Fix passing a current tab to vis-options

* Localize 'Count' text

* Pass one axis to CategoryAxisPanel

* Fix y-axis name number when x-axis position changed

* Fix Y-axis name number when position Y-axis changed

* Fix refresh loop

* Re-organize controls

* Apply code review comments

* Refactoring

* Fix extents empty value

* Update y_extents.tsx

* Fix code review comments

* Fix updating several seriesParams when removing axis

* Add thresholdLine config to horizontal bar

* Refactoring

* Reset grid.valueAxis when the axis deleted

* Fix refresh loop

* Set interpolate config for line

* Enable "show dots"
2019-09-13 14:12:43 +03:00
Artyom Gospodarsky 680d84662c
Move highlight_html.js (#45372)
* Convert getHighlightHtml() to TS

* Convert htmlTags to TS

* Convert highlightTags to TS

* Convert getHighlightRequest() to TS

* Convert index.js to index.ts

* Move tests to TS

* Move highlight to plugins/data
2019-09-13 12:23:16 +03:00
Søren Louv-Jansen afb989a634
Bump backport to 4.7.0 (#45587)
* Bump backport to 4.7.0

* Bump to 4.7.1
2019-09-13 10:53:17 +02:00
Mike Place 384d2200ce
Respect xpack.monitoring.show_license_expiration (#45537) 2019-09-13 06:42:08 +00:00
Spencer f250b49e2e
don't log warning when env_keys script is reloaded in the same… (#45578)
(cherry picked from commit b47b0d194580e4cd21be05e01b768969637954f8)
2019-09-12 19:13:30 -07:00
Lisa Cawley 17f844a93a
[DOCS] More updates for security content in user folder (#45572) 2019-09-12 16:06:01 -07:00
Nathan Reese e5f72d54bc
[skip-ci][Maps] Point to point source docs (#45441)
* [skip-ci][Maps] Point to point source docs

* review feedback
2019-09-12 15:06:53 -06:00
Garrett Spong 42b80af630
[SIEM] Moves installation of jobs from initial page load to opening of Anomaly Detection UI (#45536) 2019-09-12 14:51:17 -06:00
Nathan Reese bdc2575d79
[Maps] fix adding filters in map embeddable (#45187) 2019-09-12 14:40:41 -06:00
Larry Gregory 7291e4468e
Adding copy-to-space section to saved objects docs (#45513)
* adding copy-to-space blurb to saved objects docs

* Apply suggestions from code review

Co-Authored-By: gchaps <33642766+gchaps@users.noreply.github.com>

* apply code review suggestions

* Update docs/management/managing-saved-objects.asciidoc

Co-Authored-By: Lisa Cawley <lcawley@elastic.co>
2019-09-12 16:14:38 -04:00
Lisa Cawley ce1d2f0f7b
[DOCS] Moves security content into user folder (#45555) 2019-09-12 12:13:54 -07:00
Catherine Liu 433d5b65de
[Canvas][i18n] Keyboard Shortcuts and Help Menu (#45056)
* Translated shortcut descriptions

* Added i18n to HelpMenu and KeyboardShortcutDocs components

* fixed i18n errors

* Removed unnecessary type

* Updated snapshot

* Adds a description for shortcut separator in the KeyboardShortcutsDoc
2019-09-12 12:07:43 -07:00
Liza Katz 090a4073cf Improved exports of expressions plugin (#45538)
* Improved exports of expressions plugin

* typo

* Remove unused interfaces
2019-09-12 13:50:00 -04:00
James Gowdy b5fc70e013
[ML] Adjusting module jobs model memory limit (#45502) 2019-09-12 18:12:40 +01:00
Lisa Cawley e0fdce6356
[DOCS] Moves ml content into user folder (#45482) 2019-09-12 08:53:44 -07:00
Robert Oskamp bd8c09e63b
Fix model bytes validation (#45508)
This PR adds `model_bytes` to the list of count details that are only validated to be present and re-enables the tests.
2019-09-12 17:17:21 +02:00
friol df21530c88 GUI enhancement: handle descriptions for visualizations (#20936) (#44702)
* Adds descriptions to visualizations

* Adds descriptions to visualizations

* Tests on the saved object (visualization) modal
2019-09-12 18:08:13 +03:00
CJ Cenizal 7506c7fd76
Remove index lifecycle phase filter from Index Management because the ES API doesn't provide the required information for us to implement the expected behavior. (#45486) 2019-09-12 07:58:38 -07:00
Brandon Morelli 40a505e89e
docs: move uptime guide to shared versions (#45378) 2019-09-12 16:42:36 +02:00
Nathan Reese 24ad526e6c
[Maps] set mapbox Popup maxWidth (#45253) 2019-09-12 08:37:07 -06:00
Alison Goryachev 43c033d942
[ILM] Delete min_age field if warm phase on rollover is enabled (#45412) 2019-09-12 10:26:52 -04:00
Brian Seeders e92857090b
Don't set any job properties from the Jenkinsfile (#45522) 2019-09-12 10:22:36 -04:00
Søren Louv-Jansen 15b5839fbd
[APM] Remove transaction.result filter from Errors overviews page (#45379) 2019-09-12 15:10:42 +02:00
Melissa Alvarez 9e3a3dc7c6
[ML] Reorganize ML navigation with top and sub level tabs (#45220)
* Add main nav tabs with sub tabs for new nav

* move transforms to top level main nav

* Make top nav normal font weight

* Update breadcrumbs to take top nav into account

* proper spacing when settings selected

* fix localization error

* Fix functional tests. Update breadcrumbs

* revert analytics breadcrumb update. save for follow up

* ensure main/sub tabs align left

* update dataVisualizer breadcrumbs

* update typescript for tabs
2019-09-12 09:09:36 -04:00
Liza Katz a45b0a7bbf
Split data and expression plugins (#45125)
* split data plugin from expression plugin

* added expressions as dependency to visualizations

* ui/agg import

* expressions start contract
replace __SECRET_INTERNALS_DO_NOT_USE_OR_YOU_WILL_BE_FIRED with __LEGACY

* Rename contract

* vis deps

* Fix build pipeline mocks

* Added expressions plugin to karma mock

* update imports

* export types from common

* Restore types.ts

* Remove unused expressions plugin server code
2019-09-12 15:57:58 +03:00
Larry Gregory 3e960e3e5c
Spaces - fix SecureSpaceMessage visibility (#44829)
* fix SecureSpaceMessage visibility

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2019-09-12 08:49:12 -04:00
Jean-Louis Leysens 5c2d0cae9c
Console to NP ready (#43346)
*  General structure of Public w/ legacy brace + autocomplete 🤔
 Refactor Resizer functionality (panel component)
 Refactor Play Button
 Refactor Auto-completion
 Refactor Docs opener
 Refactor Storage

* First refactor of kbn ace keyboard mode to TS+React

* clean up unused props

* console_menu.js -> console_menu.tsx

* Remove unused file from quarantine and added fixed ui ace keyboard mode react hook

* - Refactored history and storage to app-wide services
- Pre-emptive changes to tests
- sense-history -> HistoryList
- removed unused kbn top nav v2 component

* A lot of cleanup, re-introduced editor resize checker, re-introduced history viewer as TS+React. `history` still needs refactoring.

* First iteration of tap nav menu, with history toggle working

* Lots of fixes
Also moved over and integrated remaining three react components

* Moved a lot of files around again, tidied up NP set up

* Replace angular directive

* Remove used code

* Re-order imports and move all ace dependencies to same location

* Remove more unused code

* Revise quarantined setup mocks

* Don't suggest 'undefined' or other null-like values in autocomplete

* Clean up api_server folder

* Re-add missing style

* Updated karma spec mock

* Fix editors cutting of at bottom of screen

* Refactor console editors into single components
Refactor a lot of business logic to main.tsx container
Minor renaming of variables for better readability

* Updated use of contexts with better error message
Fixed broken render sync cycles (using useCallback)
Fixed Main container render cycle (added missing deps to useEffect)
Fixed default input and removed auto indent from being called on init for already formatted text

* Updated test mocks

* Update to be more in line with NP conventions https://github.com/elastic/kibana/blob/master/src/core/CONVENTIONS.md

* Update console history when making new requests
Fixed spacing between editor and console history
Moved registration of keyboard commands to TS
Fixed setup_mocks.js after renaming app to application

* Clean up git merge conflict artifact

* Use updated NP interfaces

* More typings fixed after updating local project dependencies

* Removing some dependencies on KUI and font awesome from legacy editor

* Fix clear history not re-rendering
Refactor prop name to be more descriptive

* Simplify split_panel and add tests

* Fix accessibility tabbing behaviour for ace editor

* Refactor ConsoleEditor into two separate components
Remove unused changeCursor code
Remove unused textArea ref
Use default lodash debounce (remove unnecessary arg)

* Major a11y fix when tabbing
Major fix for ace in IE11 and Edge browsers

* Update comment
2019-09-12 13:28:29 +02:00
Søren Louv-Jansen 19837fea23
[APM] Add "Quick links" to test plan 2019-09-12 13:23:32 +02:00
Søren Louv-Jansen 8a6b1518ef
Renamed tested-after-ff to apm-test-plan-done 2019-09-12 13:13:14 +02:00