Commit graph

38469 commits

Author SHA1 Message Date
Tiago Costa
6e8895403a
chore(NA): tool to find plugins circular dependencies between plugins (#82867)
* chore(NA): update gitignore to include first changes from moving into a single package.json

* chore(NA): update gitignore

* chore(NA): move all the dependencies into the single package.json and apply changes to bootstrap

* chore(NA): fix types problems after the single package json

* chore(NA): include code to find the dependencies used across the code

* chore(NA): introduce pure lockfile for install dependencies on build

* chore(NA): update clean task to not delete anything from xpack node_modules

* chore(NA): update gitignore to remove development temporary rules

* chore(NA): update notice file

* chore(NA): update jest snapshots

* chore(NA): fix whitelisted licenses to include a new specify form of an already included one

* chore(NA): remove check lockfile symlinks from child projects

* chore(NA): fix eslint and add missing declared deps on single pkg json

* chore(NA): correctly update notice

* chore(NA): fix failing jest test for storyshots.test.tsx

* chore(NA): fix cypress multi reporter path

* chore(NA): fix Project tests check

* chore(NA): fix problem with logic to detect used dependes on oss build

* chore(NA): include correct x-pack plugins dep discovery

* chore(NA): discover entries under dynamic requires on vis_type_timelion

* chore(NA): remove canvas

* chore(NA): add initial code to find circular deps

* chore(NA): ground work to integrate the circular deps scripts

* chore(NA): add correct filtering to find circular dependenices feature

* chore(NA): add ci mode flag into circular deps script

* chore(NA): feature complete circular dependencies detect script

* chore(NA): merge and solve conflicts with master

* chore(NA): remove unwanted changes

* chore(NA): remove unwanted changes on kbn storybook

* chore(NA): hook find circular deps tool into ci

* chore(NA): remove previous find plugin circular deps script

* chore(NA): add type for circular dep list

* chore(NA): add type for circular dep list for allowed list

* chore(NA): allow CI to fail check

* chore(NA): update deps allowed list

* chore(NA): run search circular deps script over examples too

* docs(NA): adds cli description

* chore(NA): use plugin search paths to build entries to find circular deps

* chore(NA): update allowed list

* chore(NA): snapshot update for kbn optimizer test

* chore(NA): update dpdm version

* chore(NA): remove thirdParty flag

* chore(NA): update docs to include info about the new tool

* docs(NA): update to link PR instead of the issue

* chore(NA): update debug logs to always output allowedList

* fix(NA): correctly list found differences number

* chore(NA): remove quiet flag

* fix(NA): correctly fail the CI if circular deps are found

* chore(NA): complete list of found circular deps

* chore(NA): used named capturing group into the regex

* docs(NA): update typescript best practices docs and styleguide

* chore(NA): introduce quick filter option flag

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2020-11-30 22:19:32 +00:00
Matthew Kime
e97aa520c5
[visualizations] get index pattern via service instead of saved object (#84458)
* embeddable - get index pattern via service instead of saved object
2020-11-30 14:34:01 -06:00
Paul Tavares
7ba6c73a71
[Fleet] Default Integration Policy Configuration section is only shown if no UI extension is registered (#84534)
* Do not render out-of-box integration policy configuration step if a custom UI extension is registered
* Remove endpoint specific logic from fleet and move it to UI extension
2020-11-30 14:17:19 -05:00
ymao1
69845cc161
Fixes Failing test: X-Pack Alerting API Integration Tests.x-pack/test/alerting_api_integration/security_and_spaces/tests/alerting/rbac_legacy·ts - alerting api integration security and spaces enabled Alerts alerts "before all" hook in "alerts" (#84255)
* Unskipping update test

* Changing order of tests

* Cleanup

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2020-11-30 13:41:41 -05:00
Mikhail Shustov
cb0a3595a3
[Core] mark legacy ES client methods deprecated (#84358)
* mark context ES client & ES client methods deprecated

* update docs

* improve comment
2020-11-30 19:15:17 +01:00
Mikhail Shustov
1ec2f1d078
Cleanup tsconfig files (#84396)
* remove unused "paths" from tsconfig

* remove unused test utils, import get-url from kbn/test

* dont pollute globals with jest when importing getUrl

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2020-11-30 19:12:00 +01:00
Bill McConaghy
614c85828d
[DOCS] better explanation of backup/key rotation for encryption key (#84529)
* better explanation of backup/key rotation for encryption key

* clarifying failure reason in lost key scenario

* fixing typo
2020-11-30 13:04:42 -05:00
Dima Arnautov
f39da3e680
[ML] Persisted URL state for Data Frame Analytics Exploration page (#84499)
* [ML] store query string in the URL state

* [ML] query state for the config step

* [ML] pagination in the URL state

* [ML] persisted URL state for outlier results exploration

* [ML] update URL generator

* [ML] do not update the url state when query string hasn't been changed

* [ML] store expandable panels state in the URL

* [ML] fix TS issue

* [ML] fix TS issue
2020-11-30 18:54:15 +01:00
renovate[bot]
647b9914c9
Update dependency @elastic/charts to v24.2.0 (#84223)
Co-authored-by: Renovate Bot <bot@renovateapp.com>
2020-11-30 18:42:34 +01:00
Gidi Meir Morris
bc1fd6ceb8
[Alerting] fixes buggy default message behaviour (#84202)
This PR addresses some weird UX we've identified with default values in Action Params components and their inferred defaults when placed inside of an Alerts flyout.
Key changes:

1. Typing of these components has been corrected to reflect that we expect these parameters to only be _partial_, as the form is used to set these values (for example, the `message` field of the Server Log action, might or might not be set, so it should be nullable, but in the typing we treated it as the _final_ valid state, which is message not being nullable).
2. When a default message is set by the params components, the are tracked against the value of the default, which means that if the default changes, then so will the value in the field. Custom values provided by the user will not be overridden when the default changes. This has to be handled by the component itself at the moment (hopefully in the future we can make this a concern of the flyout and not each component).
3. The concept of the "Recovered" action group has been removed from these components - that's an Alerting concern, not actions, and shouldn't appear in the action components' code.
2020-11-30 17:16:04 +00:00
Tim Roes
c48428ed22
[Graph] Use new ES client and change license API (#84398)
* Remove deprecated Graph licensing methods

* Use new elasticsearch client

* fix typing error

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2020-11-30 18:08:58 +01:00
Kaarina Tungseth
7ea2645704
[DOCS] Adds redirect to known plugins page (#84001) 2020-11-30 10:44:26 -06:00
Nathan Reese
a8d5b778ee
Update IndexPatternSelect to get fields from indexPatternService instead of savedObject attributes (#84376)
* Update indexPatternSelect to get fields from indexPatternService instead of savedObject attributes

* keep original search implemenation

* import from public

* remove unused code

* API updates

* review feedback
2020-11-30 09:40:45 -07:00
Jonathan Buttner
a82ebf8b25
Adding timestamps to created events so the sorting is stable (#84515) 2020-11-30 11:20:23 -05:00
Kaarina Tungseth
480a99381d
[DOCS] Redirects for drilldown links (#83846)
* Fixes lGo to URL links

* Fixes links pt 2

* Added redirects

* Added Lens and reformatted redirects

* Removed lens and fixed broken links

* Fixes to URL drilldowns link

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2020-11-30 10:18:11 -06:00
Paul Tavares
707dbcd2b1
[Fleet] Support for showing an Integration Detail Custom (UI Extension) tab (#83805)
* Support for rendering a custom component in Integration Details
* Refactor Fleet app initialization contexts in order to support testing setup
* New test rendering helper tool
* refactor Endpoint to use mock builder from Fleet
2020-11-30 11:12:39 -05:00
Scotty Bollinger
eee05ad82a
[Enterprise Search] Migrate shared Schema components (#84381)
* Migrate shared Schema components

These components were not changed, with the exception of lint fixes and TypeScript changes (adding types). The only exceptions are:

1. The `formatFieldName` in `SchemaAddFieldModal`. In `ent-search`, this was a shared util, but since it was not used anywhere else, I just added the method as a function in this component.

2. The `IFieldCoercionErrors` interface is only used here so I did not add it to the shared types file and instead jut added it to this component.

* Use EuiLinkTo instead of Link

* Add unit tests

* Better test for `hideName`

Coverage was fine but wasn’t actually testing correctly

* Add i18n

* FIx test that didn’t pass eslint

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2020-11-30 10:03:47 -06:00
Matthias Wilhelm
0017c2df1c
[Discover] Unskip date_nanos and shard links functional tests (#82878) 2020-11-30 16:56:50 +01:00
Cauê Marcondes
416dbde54b
[APM] ML anomaly detection integration: Displaying anomaly job results in the Transaction duration chart is not as intended (#84415)
* adding anomalies to transaction duration chart

* removing extra :

* fixing test

* addressing pr comments

* addressing pr comments

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2020-11-30 16:18:34 +01:00
Alison Goryachev
7691184184
Support for painless language autocomplete within monaco (#80577) 2020-11-30 10:14:33 -05:00
Joe Reuter
6828859cac
[Lens] Time scale ui (#83904) 2020-11-30 16:08:19 +01:00
Bill McConaghy
3af64cac34
removing beta callouts (#84510) 2020-11-30 09:56:00 -05:00
Marta Bondyra
f23d2e6ea1
[Lens] (Accessibility) add aria-label to chart type icon (#84493) 2020-11-30 15:45:26 +01:00
Bohdan Tsymbala
de5edaa278
Trusted Apps signer API. (#83661)
* Separated out service layer for trusted apps.

* Improved the type structure a bit to avoid using explicit string literals and to add possibility to return OS specific parts of trusted app object in type safe manner.

* Added support for mapping of trusted app to exception item and back.

* Changed schema to support signer in the API.

* Renamed utils to mapping.

* Exported some types in lists plugin and used them in trusted apps.

* Added tests for mapping.

* Added tests for service.

* Switched deletion to use exceptions for not found case.

* Added resetting of the mocks in service layer tests.

* Added handlers tests.

* Refactored mapping tests to be more granular based on the case.

* Restored lowercasing of hash.

* Added schema tests for signer field.

* Removed the grouped tests (they were split into tests for separate concerns).

* Corrected the tests.

* Lowercased the hashes in the service test.

* Moved the lowercasing to the right location.

* Fixed the tests.

* Added test for lowercasing hash value.

* Introduced OperatingSystem enum instead of current types.

* Removed os list constant in favour of separate lists in places that use it (each place has own needs to the ordering).

* Fixed the missed OperatingSystem enum usage.
2020-11-30 15:42:31 +01:00
Pierre Gayvallet
b99abe301a
increase stdout max listeners for legacy logging (#84497)
* increase stdout max listeners for legacy logging

* add missing packages to CODEOWNERS
2020-11-30 15:32:59 +01:00
Søren Louv-Jansen
a2b71f8bf9
[APM] Service overview: Add throughput chart (#84439) 2020-11-30 14:20:41 +01:00
Matthias Wilhelm
923a525923
[Discover] Unskip main functional tests (#84300) 2020-11-30 14:13:53 +01:00
Shahzad
2e6dca62f1
Uptime overview overhaul (#83406)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2020-11-30 13:51:11 +01:00
Cauê Marcondes
668ec44e3c
[APM] Adjust time formats based on the difference between start and end (#84470) 2020-11-30 13:25:28 +01:00
James Gowdy
090359ca5a
[ML] Renaming saved object repair to sync (#84311)
* [ML] Remaiming saved object repair to sync

* removing 0 from sync lists

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2020-11-30 12:24:03 +00:00
Alejandro Fernández Haro
cb55898c98
[UsageCollection] Remove formatBulkUpload and other unused APIs (#84313)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2020-11-30 11:30:47 +00:00
Fabien Baligand
d11ca6c1da
[Visualizations] Adds visConfig.title and uiState to build pipeline function (#84456)
* add visConfig.title to pipeline visualization function

- To be consistent with visualizations built with "buildPipelineVisFunction".
- To provide "title" information for visualizations.

* add uiState to pipeline visualization function

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2020-11-30 13:30:30 +02:00
Alejandro Fernández Haro
4c59629fdc
[Elasticsearch Migration] Update docs re UsageCollection (#84322) 2020-11-30 11:29:47 +00:00
Diana Derevyankina
06da0e77b5
TSVB field list performance issue on using annotations (#84407)
* TSVB field list performance issue on using annotations

* Add AbortController to fetchFields and change translation id in annotations_editor

* Rename fetchFields to debouncedFetchFields

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2020-11-30 14:08:50 +03:00
MadameSheema
454635228e
[Security Solution] Exceptions Cypress tests (#81759)
* improves 'Creates and activates a new custom rule' test

* fixes constant problem

* improves 'Creates and activates a new custom rule with override option' test

* improves 'Creates and activates a new threshold rule' test

* refactor

* fixes type check issue

* improves assertions

* removes unused code

* changes variables for constants

* improves 'waitForTheRuleToBeExecuted' test

* improves readability

* fixes jenkins error

* refactor

* blah

* more things

* finishes 'Creates an exception from rule details and deletes the excpetion' implementation

* implements 'Creates an exception from an alert and deletes the exception'

* updates VALUES_INPUT locator

* updates archiver

* refactor

* improves the code

* fixes CI error

* renames exceptions archive

* refactor

* fixes merge issue

* fixes CI issue

* debug

* refactor

* improves test data

* removes signals index after the execution

* removes unused line

* removes unused variable

* refactors 'numberOfauditbeatExceptionsAlerts' constant to camel case

* simplifies the archive

* waits for the rule to be executed after navigating to opened alerts tab

* cleaning data

* fixes tests flakiness

* cleans test data

* refactors code

* removes unsused archives

* cleans data

* simplifies data

* fixes CI issue

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2020-11-30 10:37:42 +01:00
James Gowdy
767286e2da
[ML] Fix spaces job ID check (#84404)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2020-11-30 09:34:33 +00:00
Madison Caldwell
bdf7b88b45
[Security Solution][Detections] Handle dupes when processing threshold rules (#83062)
* Fix threshold rule synthetic signal generation

* Use top_hits aggregation

* Find signals and aggregate over search terms

* Exclude dupes

* Fixes to algorithm

* Sync timestamps with events/signals

* Add timestampOverride

* Revert changes in signal creation

* Simplify query, return 10k buckets

* Account for when threshold.field is not supplied

* Ensure we're getting the last event when threshold.field is not provided

* Add missing import

* Handle case where threshold field not supplied

* Fix type errors

* Handle non-ECS fields

* Regorganize

* Address comments

* Fix type error

* Add unit test for buildBulkBody on threshold results

* Add threshold_count back to mapping (and deprecate)

* Timestamp fixes

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2020-11-29 22:10:23 -05:00
Tiago Costa
d21e4f5af4
skip flaky suite (#84440) 2020-11-28 03:49:04 +00:00
Tiago Costa
31c1ca0026
skip flaky suite (#84445) 2020-11-27 15:14:42 +00:00
Søren Louv-Jansen
f99766e7ab
[APM] Fix missing service.node.name (#84269) 2020-11-27 10:19:11 +01:00
Rudolf Meijering
ee5c9bceeb
Upgrade fp-ts to 2.8.6 (#83866)
* Upgrade fp-ts to 2.8.6

* reduce import size from io-ts

* removed unused imports

* remove usage of fpts from alerts

Co-authored-by: Gidi Meir Morris <github@gidi.io>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2020-11-26 20:34:06 +01:00
Yulia Čech
51f75a5655
Added data streams privileges to better control delete actions in UI (#83573)
* Added data streams privileges to better control delete actions in UI

* Fix type check issues

* Change data streams privileges request

* Fixed type check issue

* Fixed api integration test

* Cleaned up not needed code

* Renamed some data streams and added a default value for stats find

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2020-11-26 17:04:24 +01:00
Joe Portner
4d8b7f9084
Improve short-url redirect validation (#84366) 2020-11-26 10:51:10 -05:00
Alexey Antonov
93b0273ccd
TSVB offsets (#83051)
Closes: #40299

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2020-11-26 18:04:27 +03:00
Matthias Wilhelm
f0192c1c03
[Discover] Fix navigating back when changing index pattern (#84061) 2020-11-26 15:45:21 +01:00
Alejandro Fernández Gómez
b246701d39
[Logs UI] Polish the UI for the log entry examples in the anomaly table (#82139)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2020-11-26 14:18:42 +01:00
Alejandro Fernández Gómez
36ab99e546
[Logs UI] Limit the height of the "view in context" container (#83178)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2020-11-26 14:01:53 +01:00
Alejandro Fernández Haro
4004dd4012
[Application Usage] Update schema with new fleet rename (#84327) 2020-11-26 11:25:05 +00:00
Mikhail Shustov
d2552c426d
fix identation in list (#84301) 2020-11-26 12:08:47 +01:00
Shahzad
a4c8dca021
[Uptime] Fix headers io-ts type (#84089) 2020-11-26 10:08:45 +01:00