Commit graph

30397 commits

Author SHA1 Message Date
Joe Reuter 74b9ed6414
Move tsvb server to new platform (#55310) 2020-01-30 16:42:56 +01:00
Joe Reuter c504c40ba9
exclude tutorial resources from code ownership (#55987)
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-01-30 16:42:03 +01:00
Jean-Louis Leysens ed9cf94920
[Watcher] Follow up on flaky functional test (#56384)
* Skip flaky watcher FF test

* Give a bit more time for machines on CI

* Update watcher_test.js

* Revert "Update watcher_test.js"

This reverts commit 8a0289f9f1.

* Revert "Give a bit more time for machines on CI"

This reverts commit d11228d618.
2020-01-30 16:31:27 +01:00
Jean-Louis Leysens 6bc9cde843
Fix off by one issue for getting endpoint for opening docs and tracking (#56364)
Fix security docs
2020-01-30 16:00:42 +01:00
Jean-Louis Leysens 2d3a656b75
Sort returned list of objects (#56356) 2020-01-30 15:57:10 +01:00
Maja Grubic 371abf6fd2
[Filter Bar] Remove flickering when opening filter bar popover (#56222)
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-01-30 14:01:01 +00:00
Melissa Alvarez fb334ef566
[ML] New Platform server shim: update calendar routes to use new platform router (#56264)
* migrate calendar routes to NP

* add proper types for calendars and events

* set actual client in constructor so isLegacy is not stored

* remove unnecessary comments

* fix calendar schema for missing calendar_id and event_id properties
2020-01-30 08:26:16 -05:00
Shahzad a8622cfcd8
[Uptime] Use dynamic index pattern in Uptime (#55446)
* Using auto attribute field and fixed title

* added constant

* refactor index pattern state

* fixed type

* PR feedback

* resolve conflcits

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-01-30 12:10:30 +01:00
Daniil Suleiman 3e2e783a8d
[Vis: Default Editor] Fix advanced params rendering (#56295)
* Fix advanced params rendering

* Use EuiSpacer for margin
2020-01-30 13:50:49 +03:00
Anton Dosov 395e7b6907
[Bugfix][State Management] 'state:storeInSessionStorage' doesn’t take effect for dashboard without full page reload (#56284)
* bugfix: 'state:storeInSessionStorage' doesn’t take effect for dashboard without full page reload
* add test “changing 'state:storeInSessionStorage' also takes effect without full page reload”
2020-01-30 11:09:12 +01:00
Jean-Louis Leysens 952b61e049
[Console] Move out of legacy + migrate server side to New Platform (#55690)
* Initial move of public and setup of server skeleton

* Fix public paths and types

* Use new usage stats dependency directly in tracker also mark as an optional dependency

* WiP on getting server side working

* Restore proxy route behaviour for base case, still need to test custom proxy and SSL

* Add new type and lib files

* Clean up legacy start up code and add comment about issue in kibana.yml config for console

* Move console_extensions to new platform and introduce ConsoleSetup API for extending autocomplete
Add TODO regarding exposing legacy ES config

* Re-introduce injected elasticsearch variable and use it in public

* Don't pass stateSetter prop through to checkbox

* Refactor of proxy route (split into separate files). Easier testing for now.
Refactor file name of request.ts -> proxy_request.ts. This is consistent with the exported function now
Started fixing server side tests for the proxy route
  - Migrated away from sinon
  - Completed the body.js -> body.test.ts. Still have to do the rest

* headers.js test -> headers.test.ts and moved some of the proxy route mocking logic to a common space

* Finish migration of rest of proxy route test away from hapi
Add test for custom route validation

* Bring console application in line with https://github.com/elastic/kibana/blob/master/src/core/CONVENTIONS.md#applications
Change log from info level to debug level for console_extensions plugin

* Update i18nrc file for console

* Add setHeaders when passing back error response

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-01-30 10:51:02 +01:00
Joe Reuter 0d03ade9ea
NP Migration: Rollup plugin (#53503)
* Start shimming rollup plugin

* continued shimming rollup ui

* Remove unnecessarily return

* Register management section

* Replace ui/chrome

* Replace ui/documentation_links

* Replace ui/kfetch and ui/courier

* Start shimming rollup plugin

* continued shimming rollup ui

* Remove unnecessarily return

* Register management section

* Replace ui/chrome

* Replace ui/documentation_links

* Replace ui/kfetch and ui/courier

* Replace ui/notify

* Move ui/ imports to legacy_imports.ts

* Update NP mock for management

* Refactoring

* Read body from error object

* Update setup_environment.js

* Update unit tests

* Get rid of injectI18n

* Replace npStart and npSetup usage to services

* Import search strategy stuff from the top level of the data plugin

* Update unit tests

* Do not prepend the url

* Fix merge conflicts

* Refactoring

* Revert removal of setUserHasLeftApp

* Export getSearchErrorType

* Remove extra wrapper - Router

* Fix cause prop.

* Leave just static imports in legacy_imports.js

* Add TS

* Pass statusCode instead of statusText

* Move template in a separate file

* Move app register to setup

* Add karma mock for management setup

* Add EditorConfigProviderRegistry export

Co-authored-by: Maryia Lapata <mary.lopato@gmail.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-01-30 11:25:47 +03:00
Shahzad 326afbc304
[Uptime] In Ping histogram use auto date histogram (#55605)
* update ping histogram API

* update test

* fix tests

* update test

* unused code

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-01-30 08:01:40 +01:00
Sébastien Loix ae9cbfcb27
[Mappings editor] Bring improvements from #55804 PR to master (#56282) 2020-01-30 12:11:38 +05:30
Nathan L Smith 4084be7380
[APM] Fit service map to container (#56336)
* Set the height of the service map dynamically
* Move the loading overlay from the outside to the inside of the Cytoscape container
* Remove the EUI spacer from the Home and ServiceDetailTabs components and add it to the individual components that use them
2020-01-29 22:23:07 -06:00
Tyler Smalley 85000a57ab
Adds realm order to Kerberos FTR config (#56334)
In 8.0, the realm order setting is required

https://www.elastic.co/guide/en/elasticsearch/reference/master/breaking-changes-8.0.html#_the_realm_order_setting_is_required

Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-01-29 16:16:27 -08:00
Nathan Reese 2f9c41bc52
[Maps] add type icons to SingleFieldSelect component (#56313)
* [Maps] add type icons to SingleFieldSelect component

* clean up

* update jest snapshot
2020-01-29 17:36:57 -05:00
Xavier Mouligneau 18ddf0b8df
fix edit rule for detections (#56333)
fix duplicates rules

allow no filter on detail rule
2020-01-29 16:43:41 -05:00
Lee Drengenberg fd8cbde0d7
added note about yarn kbn clean and yarn cache clean 2020-01-29 15:22:52 -06:00
Jonathan Budzenski 304efed1eb
bump renovate label from 7.6 to 7.7 (#55621)
* bump renovate label from 7.6 to 7.7

* bump root config

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-01-29 15:11:01 -06:00
Kaarina Tungseth 2ff9d8b5c3
Added LDAP to Kibana autthentication provider page (#56045) 2020-01-29 14:49:33 -06:00
Ryan Keairns 993867805d
Update to Elastic brand graphics (#56094)
* update elastic brand graphics

* update card graphic

* update welcome test snapshot

* rename png file
2020-01-29 13:56:28 -06:00
Justin Kambic e7899ffe11
[Uptime] [Test] Add functional test for monitor with location name but no geo (#55915)
* Add unit test for missing geo on named location.

* WIP writing a functional test.

* New named-location with no geo data test is functioning.

* Update snaps for functional test attribute.

* Rename test.

* Remove unnecessary async syntax.

* Delete unneeded symbols.

* Remove unnecessary boolean conversion.

* Fix typo in a comment.
2020-01-29 12:05:37 -07:00
Patrick Mueller 90ad26038c
adds the Kibana server uuid to eventLog events (#56004)
resolves https://github.com/elastic/kibana/issues/55631

Also beefed up the event_logger test cases.
2020-01-29 13:05:14 -05:00
Joe Portner d0c6e7de84
Clarify documentation for TLS encryption setup (#55739) 2020-01-29 12:59:50 -05:00
Nathan Reese 59c90f15cb
[Maps] tighten default map zoom (#56069)
* [Maps] tighten default map zoom

* rework using bounds to work on multiple screen resolutions

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-01-29 12:31:17 -05:00
Zacqary Adam Xeper 759663c193
[Logs UI] Fix Check for New Data button on empty indices screen (#56239) 2020-01-29 11:27:41 -06:00
Janeen Mikell-Straughn 58722e586f
Added step to change to Kibana directory. (#56315) 2020-01-29 12:09:45 -05:00
Nick Partridge 6e352cdd60
[Timelion] Fix height of CodeEditor - Safari (#56050)
* Fix height on CodeEditor in timelion visualization in safari
2020-01-29 10:44:34 -06:00
Chris Cowan a8a28bce6a
[Metrics UI] Add aws.dimensions prefix to AWS metrics in Metrics Explorer (#56216)
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-01-29 10:38:06 -06:00
Nathan Reese 31e413ca33
[Maps] style icons by category (#55747)
* dynamic icons

* split symbols UI into 2 parts

* static dynamic icon editor UI

* rename style property symbolMarker to icon

* add field select to dynamic icon form

* icon map select component

* create property classes for icon style property

* dynamic icons from palette

* changes

* fix image problem

* implement legend details

* fix image-anchor setting for dynamic images

* update functional test expect because of migration

* fix jest tests

* migrate SIEM style descriptors

* modify IconSelect to show icon in input

* fix jest test

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-01-29 11:15:06 -05:00
Felix Stürmer 16b4ff4a59
[Logs UI] Allow Logs/ML integration result access with machine… (#55884)
This makes the "Log rate" and "Categories" tab visible on clusters with a suitable license for users which don't have the the `machine_learning_admin` role.
2020-01-29 16:27:12 +01:00
Daniil Suleiman 7f63118d6b
Vis default editor plugin (#55612)
* Shim the default_editor

* Update paths in vis_default_editor

* Update paths in dependent plugins

* Update the dependent plugins

* Create an entry point

* Wrap the editor with kibana context

* Fix circular re-renders

* Update sub aggs mapping

* Move schemas and agg_groups to agg_types, update jest tests

* Use services from kibana context, other fixes

* Fix useEffect maximum update depth

* Create i18n namesapce for visDefaultEditor, rename translations

* Fix tests

* Resolve paths

* Remove ui/vis/vis_types

* Fix vis import

* Move editor_config_provider to ui/vis
2020-01-29 17:41:18 +03:00
Jean-Louis Leysens c2aff7e2fb
Re-enable watcher FireFox functional test (#56112)
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-01-29 14:40:23 +01:00
Dmitry Lemeshko 25fb555a53
Code coverage: run functional tests from repo copy (#55195)
* run functional tests from cloned folders

* do not copy kibana.yml

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-01-29 14:36:47 +01:00
Cauê Marcondes 1838d76af6
[APM] x-axis labels on Error occurrences chart are incorrect based on Kibana timezone (#55686)
* adjusting x-axis to use kibana timezone

* adjusting x-axis to use kibana timezone

* refactoring
2020-01-29 13:29:35 +00:00
Matthias Wilhelm d8adb395b1
Migrate saved_object_save_as_checkbox directive to timelion (#56114)
- since it's only used there
2020-01-29 13:31:47 +01:00
Andrew Goldstein 9d4414d523
[SIEM] Overview page feedback (#56261)
## [SIEM] Overview page feedback

Implements feedback and fixes to the Overview page

### Overview (default theme)

![01-overview-default-theme](https://user-images.githubusercontent.com/4459398/73315509-899c5500-41ed-11ea-9949-82853dd4ba59.png)

### Overview (dark theme)

![02-overview-dark-theme](https://user-images.githubusercontent.com/4459398/73315527-902acc80-41ed-11ea-9701-6a2c5fa40cce.png)

## Highlights

* The new order of widgets is Signals, Alerts, Events, Host Events, Network events, per https://github.com/elastic/siem-team/issues/494

* Changed the default `External alerts count` `Stack by` to `event.module` https://github.com/elastic/siem-team/issues/491

*  Added `event.module` to the `Events count` histogram https://github.com/elastic/siem-team/issues/491

* Widget titles will no longer include the currently selected `Stack by option`. The widgets will use the same static title text that appears on the other pages (i.e.. `Signals count`, `External alerts count`, and `Events count`) https://github.com/elastic/siem-team/issues/491

* The `Signals count` includes a `Stack by` that defaults to `signal.rule.threat.tatic.name`

* Standardized on a 300px widget height for all histograms in the app (thanks @MichaelMarcialis for paring on this!)

* The `Open as duplicate timeline` action is `Recent timelines` is now only shown when hovering over a recent timeline

## Loading States

* The `Recent timelines` and `Security news` widgets now use the horizontal bar loading indicator

* The `Host events` and `Network events` widgets now use the horizontal bar loading indicator

* The `Host events` and `Network events` Showing _n_ events subtitles are now hidden on initial load

* The counts in the `Host events` and `Network events` Showing _n_ events subtitles are now hidden on initial load

* We no longer hide some histogram subtitles after initial load, to prevent shifting of content when a user makes a `Stack by` selection

## News Feed Error State

![news-feed-error-state](https://user-images.githubusercontent.com/4459398/73316060-1e538280-41ef-11ea-83f5-b8d6e9fa3741.png)

* Fixed an issue where the `Security news` header was hidden when an invalid URL is configured

* Added a space between the word `via` and the `SIEM advanced settings` link

* Removed the capital “N” from "News" in the error message

## Misc Visual Changes

* Fixed text truncation of the `Severity` column in the `Detections` page's `Signals` table

* Added the “showing” subtitle to the `Signals count` histogram on the Detections page

* Increased the `Stack by` histogram selector and the `View signals | alerts | events' buttons from 8 to 24px

* Tweaked the border rendering in the Overview `Host Events` and `Network events` widget headers

* Added 8px of spacing between the Overview `Host Events` and `Network events` widget accordion headers and their contents

* Fixed an issue where the `Host events` and `Networ events` widgets didn't render in ie11 https://github.com/elastic/siem-team/issues/499

## Non-Visual Fixes

* Removed an incorrect usage of `usememo`

* Removed the placeholder client-side username query from `x-pack/legacy/plugins/siem/public/components/recent_timelines/index.tsx`

* Updated the query of the Overview `Host events` widget to filter by "host.name exists"

* Updated the query of the Overview `Network events` widget to filter by "source.ip exists or destination.ip : exists"
2020-01-29 00:33:40 -07:00
MadameSheema 0b45c24043
refactor (#56131) 2020-01-29 07:20:56 +01:00
Maryia Lapata fd597e0a9e
[NP Cleanup] Remove ui/public/inspector (#55677)
* Use src/plugins/inspector instead of ui/inspector

* Remove unused ui/inspector

* Use `inspector` plugin directly to register view

* Fix path

* Use inspector from NP

* Revert view registration to a separate file
2020-01-29 09:08:42 +03:00
Xavier Mouligneau 9d709c7563
[SIEM] [TIMELINE] Only add endpoint logo when on event.module === endgame (#56263)
* only add endpoint logo when on event.module === endgame

* fix filter for value
2020-01-28 22:53:17 -05:00
Davis Plumlee 1ca013a026
Basic Functionality Alert List (#55800)
* sets up initial grid and data type

* data feeds in from backend but doesnt update

* sample data feeding in correctly

* Fix combineReducers issue by importing Redux type from 'redux' package

* Add usePageId hook that fires action when user navigates to page

* Strict typing for middleware

* addresses comments and uses better types

* move types to common/types.ts

* Move types to endpoint/types.ts, address PR comments

blah 2

Co-authored-by: Pedro Jaramillo <peluja1012@gmail.com>
2020-01-28 20:37:19 -07:00
patrykkopycinski 0d2ac94c6b
[SIEM] Fix filters on Hosts and Network page (#56234)
* [SIEM] Fix Hosts and Network Tabs filters

* cleanup

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-01-28 22:32:07 -05:00
Ryland Herrick 02befdebd2
[SIEM] Adds ability to infer the newsfeed.enabled setting (#56236)
* Always return a contract from the newsfeed plugin

Without a contract, dependent plugins have no way of knowing whether the
plugin is enabled or not as the contract will always be undefined.

* Export newsfeed contract types from public index

So that dependent plugins can use them.

* Declare newsfeed as an optional dependency of SIEM

We're going to use the availability of the newsfeed plugin as part of our
determination for whether or not to show the security newsfeed. If users
set `newsfeed.enabled: false`, the plugin will be unavailable and the
security feed will not be shown.

* Respect global newsfeed.enabled config in Security newsfeed

The presence of the newsfeed plugin means that newsfeed.enabled is true.
If both that and our local setting are true, we will show the Security
feed.

* Prefer object type over empty interface

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-01-28 21:06:37 -06:00
Frank Hassanabad 06890107b4
[SIEM][Detection Engine] critical blocker for updated rules
## Summary

Critical blocker for updated rules and content we need for the release. Given to me by randomuserid and from randomuserid

### Checklist

Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.

~~- [ ] This was checked for cross-browser compatibility, [including a check against IE11](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility)~~

~~- [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md)~~

~~- [ ] [Documentation](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#writing-documentation) was added for features that require explanation or tutorials~~

- [x] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios

~~- [ ] This was checked for [keyboard-only and screenreader accessibility](https://developer.mozilla.org/en-US/docs/Learn/Tools_and_testing/Cross_browser_testing/Accessibility#Accessibility_testing_checklist)~~

### For maintainers

~~- [ ] This was checked for breaking API changes and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)~~

~~- [ ] This includes a feature addition or change that requires a release note and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)~~
2020-01-28 17:31:31 -07:00
Frank Hassanabad 2bab2cc84a
[SIEM][Detection Engine] critical blocker, fixes ordering issue that causes rules to not run the first time
## Summary

Fixes ordering issue that @mikecote found for us with rules where we need to first update the rule before trying to enable it so there aren't issues with API keys.

These types of errors should no longer be seen:

```
{"type":"log","@timestamp":"2020-01-11T09:06:25-07:00","tags":["error","plugins","siem"],"pid":61190,"message":"Error from signal rule name: \"Windows Execution via Connection Manager\", id: \"0624c880-8e64-4c7c-90b4-226b77311ac4\", rule_id: \"f2728299-167a-489c-913c-2e0955ac3c40\" message: [security_exception] missing authentication credentials for REST request [/auditbeat-*%2Cendgame-*%2Cfilebeat-*%2Cpacketbeat-*%2Cwinlogbeat-*/_search?allow_no_indices=true&size=100&ignore_unavailable=true], with { header={ WWW-Authenticate={ 0=\"Bearer realm=\\\"security\\\"\" & 1=\"ApiKey\" & 2=\"Basic realm=\\\"security\\\" charset=\\\"UTF-8\\\"\" } } }"}
```

Testing:

```ts
./hard_reset.sh
```

Then load the pre-packaged rules and enable them all at once. Ensure you don't see any errors such as the ones above. 


### Checklist

Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.

~~- [ ] This was checked for cross-browser compatibility, [including a check against IE11](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility)~~

~~- [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md)~~

~~- [ ] [Documentation](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#writing-documentation) was added for features that require explanation or tutorials~~

- [x] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios

~~- [ ] This was checked for [keyboard-only and screenreader accessibility](https://developer.mozilla.org/en-US/docs/Learn/Tools_and_testing/Cross_browser_testing/Accessibility#Accessibility_testing_checklist)~~

### For maintainers

~~- [ ] This was checked for breaking API changes and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)~~

- [x] This includes a feature addition or change that requires a release note and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)
2020-01-28 16:37:25 -07:00
Xavier Mouligneau fe037bb28e
[SIEM] Add link to endpoint app through reference.url (#56211)
* add rule.reference

* Fix Load more

* Fix spacing

* Fix loading on hist graph detections

* add tooltip
2020-01-28 17:47:42 -05:00
Chris Cowan 76628cd3cd
[Metrics UI] Fixing title truncation in Metrics Explorer (#55917)
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-01-28 16:46:11 -06:00
Tudor Golubenco 6826be2927
[SIEM] Put the notice for rules in comment block (#56123)
* Put the notice for rules in comment block

This comment block marked by `@notice` is picked up by automation and included
in the Kibana NOTICE.txt that we ship with the tar.gz.

Follow up for #56090.
2020-01-28 23:10:15 +01:00
Frank Hassanabad 57f5d77a40
[SIEM][Detection Engine] critical blocker with the UI crashing
## Summary

If you have filters which do not have a $app and state it blows up which isn't what we want to happen. This adds a function which default adds it on the UI if it does not exist

<img width="915" alt="Screen Shot 2020-01-28 at 10 07 39 AM" src="https://user-images.githubusercontent.com/1151048/73296325-bd17b900-41c6-11ea-9ba4-30715224829c.png">

Test:

Post query with everything

```ts
./post_rule.sh ./rules/queries/query_with_everything.json
```

Then visit in the details section of the UI and it should no longer blow up.

### Checklist

Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.

~~- [ ] This was checked for cross-browser compatibility, [including a check against IE11](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility)~~

~~- [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md)~~

~~- [ ] [Documentation](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#writing-documentation) was added for features that require explanation or tutorials~~

- [x] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios

~~- [ ] This was checked for [keyboard-only and screenreader accessibility](https://developer.mozilla.org/en-US/docs/Learn/Tools_and_testing/Cross_browser_testing/Accessibility#Accessibility_testing_checklist)~~

### For maintainers

~~- [ ] This was checked for breaking API changes and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)~~

- [x] This includes a feature addition or change that requires a release note and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)
2020-01-28 15:07:24 -07:00