Commit graph

26291 commits

Author SHA1 Message Date
Brandon Morelli
7731e5ba94
docs: fix link (#41126) 2019-07-15 08:10:13 -07:00
Brandon Morelli
171f8a2698
[docs][uptime] Add links from kibana to uptime (#41024)
* docs: add links from kib -> uptime

* fix DTD error
2019-07-15 07:43:53 -07:00
Daniil Suleiman
d550145fba
Fix compressed error (#40997) 2019-07-15 17:22:59 +03:00
Tim Roes
c985c69f0c
Replace Notifier usage by toastNotifications (#40764)
* Replace Notifier usage by toastNotifications

* Fix $http errors
2019-07-15 16:10:35 +02:00
Larry Gregory
cef7fb614d
Spaces - expose space translation utilities (#40681)
* expose functions to translate between space id and namespace

* expose to legacy world

* address PR feedback

* adds server.plugins.spaces.getBasePath(spaceId)

* fix impl

* it helps when you actually commit your fixes
2019-07-15 09:26:27 -04:00
Larry Gregory
73a6b728b7
Allow SOC wrappers to be excluded (#40275)
* allow SOC wrappers to be excluded

* remove example route

* add tests

* more testing
2019-07-15 09:25:16 -04:00
Walter Rafelsberger
d5489fbf45
[ML] Fix loading forecasts from anomaly job list. (#41034)
Fixes a bug where opening a forecast from the anomaly jobs list several times would not show the forecast.
The bug was caused because the observable mlJobSelectService was triggered on mounting the mlJobSelectorReactWrapper to pass on the currently selected job. However, because this directive is a child of MlTimeSeriesExplorerController it would do this check only after this controller is already initialized but also need the current jobs. The result was that the controller would receive first the out-of-date jobs and only then the new job ids. The second trigger unsets the forecast, because it's expected to only be triggered multiple times by the job selector.
The fix introduced here solves the problem by triggered the observable directly from mlJobSelectService, because the service is only set up once in contrast to a directive. globalState offers some listeners which can be used to trigger callbacks on certain events within globalState. We can use save_with_changes to subscribe to updates when globalState.save() gets called.
2019-07-15 13:54:25 +02:00
WangQianliang
13af340f75
fix(code/frontend): data should be consistent with uri (#40851) 2019-07-15 15:30:44 +08:00
WangQianliang
20da681158
fix(code/frontend): should collapse folder if the subfolder of the subfolder open (#40836) 2019-07-15 15:26:32 +08:00
Matthias Wilhelm
1bbc74a7f3
De-angularize field-name directive (#40744) 2019-07-15 09:22:17 +02:00
Pengcheng Xu
352de87eb8
[Code] Fix style of ctags icon in dark mode (#41095) 2019-07-15 14:42:20 +08:00
WangQianliang
d42d4b2487
fix(code/frontend): only show form check message when submit (#40948) 2019-07-15 13:30:25 +08:00
Mengwei Ding
bcb6ac7d68
[Code] Add a clone scheduler to reclone job if necessary (#40922)
* [Code] Add a clone scheduler to reclone job if necessary

* [Code] update the repository processing progress handling logic for relcone repository
2019-07-14 19:26:00 -07:00
spalger
97a0920c4e skip flaky test (#41076) 2019-07-13 14:20:45 -07:00
spalger
bafc25b68b skip flaky test (#41050) 2019-07-13 14:04:14 -07:00
Yang Yang
f54e92f4b4 [Code] change index name generation rules for code (#40959)
from <readable repository name>-<hash before lowercased uri>
to <capped readable repository name>-<hash after lowercased uri>
1. support long code repo uri
2. make repo uri case insensitive
2019-07-14 01:07:38 +08:00
Aaron Caldwell
59fc30b15a
[File upload] File upload additional unit tests (#40192)
* Dice up validation and parsing

* Should call onRemove callback if there is one on reset

* Remove unneeded onRemove refs since reset is now being called instead

* Dice up json preview and parse & clean

* Unit tests for preview and parse & clean

* This isn't accurate for MultiPoint and will be refactored heavily anyway for dynamic mappings in the near future

* Move index pattern validity check to service file. Update index functions to return name arr

* Test index name/pattern validity check

* Review feedback

* Review feedback

* Review feedback

* Review feedback
2019-07-12 18:19:47 -06:00
Nathan Reese
5b5cc55824
[maps] Make default EMS tile layer auto select light or dark tiles based on isDark mode advanced setting (#40892)
* [maps] Make default EMS tile layer auto select light or dark tiles based on isDark mode advanced setting

* clean up

* remove console statements

* review feedback
2019-07-12 16:46:43 -06:00
Garrett Spong
b19c24fb5a
[SIEM] Machine Learning Integration UI Fixes (#40710)
## Summary

Updates the ML Integration UI to match the latest mockups and fixes the following issues:

* Automatically installs ConfigTemplate Jobs instead of prompting the user
* Checks for configured `indexPattern` the same way the ML API does before creating jobs (Kibana `saved_objects` api vs Kibana Advanced Settings SIEM configuration)
* When running jobs will only start the Datafeed a max of two weeks prior (https://github.com/elastic/ingest-dev/issues/577)
* More granular permissions check:
  * If Platinum/trial + ML Admin, show Config UI
  * If Platinum/trial + ML User, show no button (Anomalies will show throughout SIEM UI)
  * If not Platinum/Trial, show Subscription Upgrade UI

<img src="https://user-images.githubusercontent.com/2946766/61082775-6ba10b80-a3e7-11e9-9cac-916c21cf279a.gif" width=400>

#### Show only Elastic Jobs
<img src="https://user-images.githubusercontent.com/2946766/60940061-73519a80-a297-11e9-91b3-e2dbc63c5578.png" width=400>

#### Show only Custom 'SIEM' Jobs -- Paginated View
<img src="https://user-images.githubusercontent.com/2946766/60940078-7ea4c600-a297-11e9-8c4d-bfcaf9c55c44.png" width=400>

#### Empty View
Links to ML Job Management
<img src="https://user-images.githubusercontent.com/2946766/61082863-9d19d700-a3e7-11e9-8550-fc905780da30.png" width=400>


#### Upgrade UI 
Links to: https://www.elastic.co/subscriptions
<img src="https://user-images.githubusercontent.com/2946766/61082108-0ac50380-a3e6-11e9-8e18-d9e7266a61b3.png" width=300>




### Checklist

Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.

- [x] This was checked for cross-browser compatibility, [including a check against IE11](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility)
- [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md)
- [ ] ~[Documentation](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#writing-documentation) was added for features that require explanation or tutorials~
- [x] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios
- [ ] ~This was checked for [keyboard-only and screenreader accessibility](https://developer.mozilla.org/en-US/docs/Learn/Tools_and_testing/Cross_browser_testing/Accessibility#Accessibility_testing_checklist)~

### For maintainers

- [ ] ~This was checked for breaking API changes and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)~
- [ ] ~This includes a feature addition or change that requires a release note and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)~
2019-07-12 16:37:29 -06:00
Joel Griffith
d48d58b81f
Addresses an issue where Chromium user-data-dirs aren't removed (#40284)
* Addresses an issue where Chromium user-data-dirs aren't cleaned properly, and moves to TS

* Fixing renovate config issues

* Fixing issues with typedef's missing

* Using prior-set typedefs for logger
2019-07-12 15:33:48 -07:00
Poff Poffenberger
8be17fe616
[Canvas] Converting time filter (and children) component to typescript and adding to storybook (#40443)
* Converting time filter (and children) component to typescript and adding to storybook
2019-07-12 16:48:46 -05:00
James Rodewig
8571d56839
Revert "[DOCS] Fix broken links for ES API docs move (#41001)" (#41056)
This reverts commit dd34150467.
2019-07-12 17:40:59 -04:00
Tim Sullivan
a51d1bd244
[Reporting/FN Test] use a smaller archive for scripted field testing (#40815)
* [Reporting/FN Test] use a smaller archive for scripted field testing

* rename reporting/scripted to reporting/hugedata, for non-scripted purposes

* use small set for another scripted field test
2019-07-12 14:23:48 -07:00
Michael Marcialis
29a8bc88b5
[SIEM] Update Add Data References of "Security analytics" to "SIEM" (#40899)
* change add data security references to siem

* update links to siem add data page

* update snapshot

* fix translations
2019-07-12 15:11:17 -04:00
Nathan Reese
1f09b16715
[skip ci][Maps] rework terms join documentation (#40005)
* [Maps] revamp terms join docs

* clean up

* clarify how join adds properties to left source features

* move configuration to relavent area

* add sentence explaining that features without join properties are not visible

* paired with gchaps for edits

* cleanup

* suggested changes from gchaps
2019-07-12 13:05:42 -06:00
gchaps
8c22f0883e
[DOCS] Updates Snapshot and Restore docs (#40894) 2019-07-12 11:29:57 -07:00
Dmitry Lemeshko
df9d8e6f5d
FTR: upgrade chromedriver to 75 (#40791)
* ftr: update services to support chromedriver 75

* [services/webdriver] add browser logging

* update comment for W3C scrolling bug
2019-07-12 19:49:51 +02:00
Chris Roberson
8416635570
[Monitoring] Add log message for error scenario around missing licensing (#40660)
* Add log message

* PR feedback

* Add test

* Fix/add tests

* Use cluster name if possible

* Fix loc id

* Fix messaging
2019-07-12 13:39:54 -04:00
Brandon Kobel
174102c70c
Updating lodash (#40702)
* Updating to @elastic/lodash to 3.10.1-npm-kibana2

* Updating lodash to 4.17.13

There's a stray dependency to lodash 4.17.11 via cypress which doesn't
use "^". This is a dev dependency, so we can ignore it for a bit while
they update their package.json

* Updating some forgotten references to @elastic/lodash@3.10.1-kibana1

* Updating lodash-es to 4.17.13

* Updating to @elastic/lodash to 3.10.1-npm-kibana3

* Using the root resolutions to update cypress's version of lodash.

Thanks @spalger!!!
2019-07-12 10:32:45 -07:00
Stacey Gammon
66b99ecbed
Use embeddable v2 (#39126)
* Final Embeddable API V2 PR

* fix: import discover embeddable scss file

* address code review comments

* Add a functional test that would have caught the bug... will look to add a unit version once I discover the error.

* Fix bug cause by async loading calls and changes to parent input while child is being created. added jest test

* remove outdated readme in dashboard folder

* need to always refresh dashboard container, not just when "dirty"

* add a wait, this issue started appearing right when I added this to the test

* Remove test that kills kibana ci so it's not a blocker. jest test was added for this scenario

* fix issues when panel is added then removed before it completes loading

* fix logic error with maps embeddable and isLayerTOCOpen
2019-07-12 13:31:43 -04:00
Melissa Alvarez
7f94130175
[ML] NavMenu conversion to React (#40830)
* create NavigationMenu and TopNav components

* create timefilter wrapper class

* update timefilter type file

* use new navMenu

* use legacy timefilter for initial conversion

* remove comments

* Move navMenu tabs into separate component

* ensure dataFrame tab selected style works

* update test

* remove top padding when topNav not visible

* add refresh button functionality
2019-07-12 12:29:18 -04:00
Brandon Morelli
7c90d9d6ff
docs: fix uptime link (#41016) 2019-07-12 09:27:02 -07:00
James Rodewig
dd34150467
[DOCS] Fix broken links for ES API docs move (#41001) 2019-07-12 12:15:40 -04:00
Jonathan Budzenski
49c1bfe4f3
[contributing] add karma to quick reference (#40908) 2019-07-12 11:04:30 -05:00
Brandon Morelli
9903d2e772
[docs][uptime] Add Uptime Monitoring Guide (#40566)
* docs: uptime guide first draft

* docs: uptime guide updates

* docs: clean up duplication

* docs: nits

* temporarily remove link from kib to uptime

* reviewer feedback

* change from getting started to install
2019-07-12 09:02:58 -07:00
Lisa Cawley
19abe936d2
[DOCS] Removes links to out-dated ML tutorials (#40943) 2019-07-12 08:36:19 -07:00
Matthias Wilhelm
d672e3f2dc
Change tooltip of discover interval selector (#40895) 2019-07-12 17:21:07 +02:00
Vitali Haradkou
f2d234d02b
[TSVB] [UNIT] add metric series tests (#40707)
* add metric series tests
* wrap series tests into describe block
2019-07-12 17:03:04 +03:00
Yulong
0d8a818592
[Code] use isomorphic-git to handle git references (#40951)
* [Code] use isomorphic-git to read git references
2019-07-12 21:39:36 +08:00
Justin Kambic
97c7a738fc
[Uptime] Add link to Uptime documentation from header help menu (#40645)
* Add link to Uptime documentation from header help menu.

* Use parameterized docs URL generation.
2019-07-12 08:42:54 -04:00
Dmitry Lemeshko
9f9d0dcbb8
WebElementWrapper: Retry WebDriver atomic calls (#40423)
* [services/lib/web_element_wrapper] use Generics in replyCall

* [services/lib/web_element_wrapper] remove redundant return types

* [services/lib/web_element_wrapper/] set retryCall timeout to 200 ms

* [services/find] explcitly pass element to have locator===null by default

* use static method to create WebElementWrapper

* missed a couple uses

* move some values to constants

* remove some unnecessary type info
2019-07-12 13:47:26 +02:00
Spencer
3e1afa347b
[visualize] wait for save to complete before proceeding (#40916) 2019-07-12 05:32:46 -06:00
Justin Kambic
4f7876cd93
Fix size functionality for PingList component. (#40909) 2019-07-12 07:32:28 -04:00
Yulong
2ed38ee78e
[Code] remove dependency to vscode-jsonrpc from frontend code (#40940) 2019-07-12 12:59:14 +08:00
Yulong
15664c4f55
[Code] don't try write oom_adj if write oom_score_adj successfully (#40835) 2019-07-12 09:38:56 +08:00
Frank Hassanabad
ccf2932fe7
[SIEM] Fixes critical and blocker bugs with querying Anomalies from ML (#40885)
## Summary

* Fixes a critical and blocking bug where we were querying against _ALL_ ML Jobs. Now we _only_ query for jobs that have the SIEM Group tag.

* Fixes a critical and blocking bug where `ui/chrome` getBasePath() was not being added in the fetch API areas

* Fixes a critical and blocking bug where we were querying `influencers` rather than `criteriaFields` when showing scores within the details pages for the "Max Anomaly Jobs". This caused missing jobs from the details and incorrect results.

* Fixes a critical and blocking bug where we were not using `isInitialized` from the URL loading in which case we could be loading a slightly different time range or give incorrect results.

* Fixes a critical and blocking bug where we were not filtering on `source` vs `destination` on the IP details page. Instead we were querying for everything and then filtering to either of the two as in a "source OR destination". Now instead, we only show what the user selects. 

* Fixes an embarrassing and potentially critical bug where React Router was warning about the usage of React.Memo. Instead I swapped back to using recompose pure so that we do not see warnings about the `ml-hosts` and `ml-network` routes.

### Checklist

Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.

- [ ] This was checked for cross-browser compatibility, [including a check against IE11](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility)

~- [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md)~

~- [ ] [Documentation](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#writing-documentation) was added for features that require explanation or tutorials~

- [x] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios

~- [ ] This was checked for [keyboard-only and screenreader accessibility](https://developer.mozilla.org/en-US/docs/Learn/Tools_and_testing/Cross_browser_testing/Accessibility#Accessibility_testing_checklist)~

### For maintainers

- [x] This was checked for breaking API changes and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)
- [x] This includes a feature addition or change that requires a release note and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)
2019-07-11 18:43:46 -06:00
Catherine Liu
b87cc7d27b
[Canvas][Docs]Fixes multi arg annotation (#40934) 2019-07-11 17:31:16 -07:00
Nathan Reese
f961b8b10b
[skip ci][maps] clarify data driving styling behavior when there is no range (#40884)
* [skip ci][maps] clarify data driving styling behavior when there is no range

* remove extra words

* feedback
2019-07-11 17:16:19 -06:00
Nathan Reese
92d7dbe3e5
[skip ci][maps] troubleshooting documentation (#40539)
* trouble shooting docs

* more details

* gchaps feedback
2019-07-11 17:15:06 -06:00
spalger
3ed31282fe fix lint error 2019-07-11 15:53:50 -07:00