Commit graph

33570 commits

Author SHA1 Message Date
Dmitry Lemeshko
77abbf257d
Fix code coverage for jest, upload merged reports (#68149)
* replace path in json files

* upload combined reports to artifacts for debug purpose
2020-06-03 22:21:28 +02:00
Constance
b3e7ab3f5c
Update documentation/examples of deprecated namespaceAgnostic field (#68039)
* Update documentation/examples of deprecated namespaceAgnostic field to namespaceType

* Update src/core/CONVENTIONS.md

Co-authored-by: Brandon Kobel <brandon.kobel@gmail.com>

Co-authored-by: Brandon Kobel <brandon.kobel@gmail.com>
2020-06-03 12:40:11 -07:00
Kaarina Tungseth
ee323bd86e
[DOCS] Updates Canvas docs with new menus (#66061)
* [DOCS] Updates for Canvas menus

* Image set up

* Update docs/canvas/canvas-share-workpad.asciidoc

Co-authored-by: Catherine Liu <catherineqliu@outlook.com>

* Update docs/canvas/canvas-present-workpad.asciidoc

Co-authored-by: Catherine Liu <catherineqliu@outlook.com>

* Update docs/canvas/canvas-tutorial.asciidoc

Co-authored-by: Catherine Liu <catherineqliu@outlook.com>

* [DOCS] Adds Catherine's images and minor updates to content

* Final images and clean up

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Co-authored-by: Catherine Liu <catherineqliu@outlook.com>
2020-06-03 14:28:33 -05:00
Tiago Costa
20d60829b3
chore(NA): avoids imports of server or public code into common (#67231)
* chore(NA): avoids imports of server or public code into common

* chore(NA): fix imports from public or server into common

* chore(NA): fix typechecking for data plugin stubs

* chore(NA): fix types and tests related with licensing plugin

* chore(NA): fix problems on infra plugin

* chore(NA): fix typo on .eslintrc.js

Co-authored-by: Ryland Herrick <ryalnd@gmail.com>

* chore(NA): migrate to license mock usage on security plugin licensing module

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Co-authored-by: Ryland Herrick <ryalnd@gmail.com>
2020-06-03 20:21:38 +01:00
patrykkopycinski
c4d2ba306c
[SIEM] Fix GetOneTimeline graphql type (#68137) 2020-06-03 21:02:52 +02:00
spalger
ce6b61ebf7 skip flaky suite (#67838) 2020-06-03 12:01:31 -07:00
Justin Kambic
2c1a95950c
[Uptime] Add loading message for monitor list no items (#67378)
* Add loading message for monitor list no items.

* Add tests.

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-06-03 14:59:40 -04:00
Nicolas Ruflin
055880d3ef
[Ingest Manager] Update indexing strategy docs to use dataset.* (#68068)
Indexing strategy now uses dataset.* instead of stream.* fields. For this the indexing strategy docs are updated.

Part of https://github.com/elastic/package-registry/issues/491
2020-06-03 20:36:07 +02:00
Nicolas Chaulet
c6aacc6316
[Ingest Manager] Fix datasource validation for streams without vars (#67950) 2020-06-03 14:25:00 -04:00
spalger
fcbcc63b07 skip flaky suite (#51942) 2020-06-03 11:15:42 -07:00
Jen Huang
168e0e25ba
[Ingest Manager] Remove default namespace toggle (#66298)
* Remove default namespace toggle

* Fix i18n

* Add namespace validation

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-06-03 11:14:15 -07:00
Constance
43c5466801
Update documentation examples of AppMountParams to AppMountParameters (#68042) 2020-06-03 10:17:15 -07:00
CJ Cenizal
f190fd22a2
Clean up doc title when navigating away from Snapshot Restore. (#67906)
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-06-03 10:07:59 -07:00
Spencer
3b43821401
upgrade elastic/numeral and complete migration away from numeral (#68035)
Co-authored-by: spalger <spalger@users.noreply.github.com>
2020-06-03 10:07:11 -07:00
Nicolas Chaulet
642800c98e
[Ingest Manager] Fix invalidating agent output api key (#68021) 2020-06-03 12:51:52 -04:00
Alexey Antonov
d661d66faa
[New Platform Migration]: Management - Implement NP API (#66781)
* [New Platform Migration]: Management - Implement NP API

Part of #47432

* partial progress on a number of management sections

* fix passing history

* Fixed types

* Fixed routing for Ingest Node Pipelines

* introduce and use react router wrapped eui components

* react router utils

* work in progress => hashRouter to router

* more partial progress

* remove console.log

* use reactRouterNavigate for management_sidebar

* Breadcrumbs will need to make use of the reactRouterNavigate function

* [triggersActions] app. Hash Router -> Router

* Replace /app/kibana#/management urls to /app/management

* remove ui/public/management

* fix some links to management apps

* fix management url for functional tests

* add data-test-subj for EuiSideNavItem

* partial progress

* fix some of ts issues

* Fixed breadcrumbs for data index management

* [kibana/spaces] section

* fix functional test

* [role_management] fix Breadcrumbs

* [api_keys] fix Breadcrumbs and Navigation

* Fixed routing for remote cluster

* [role_mapping] Partial progress

* [users] partial progress

* [watcher] partial progress

* fix eslint issues

* [snapshot_restore] partial progress

* [rollup_jobs] partial progress

* Fixed routing for cross cluster replications (partial progress). Enhanced reactRouterNavigate

* Perf optimization: fix extra re-rendering

* fix TS errors

* x-pack fix config for functional tests

* Fixed routing for index lifecycle management

* fix some broken CI tests

* fix PR comment

* [snapshot_restore] move onClick into reactRouterNavigate

* fix some jest

* fix some functional tests

* fix functiona test: management  scripted fields testing regression for issue

* fix some functional tests

* [licence_management] partial progress

* Fixed x-pack jest tests

* [saved_object_management] partial progress

* Fixed some tests

* fix functional test: should add new role myroleEast

* Reverted part of changes for ml

* [transforms] partial progress

* fix TS errors

* fix functional:  redirects to Kibana home

* add support of Backward compatibility

* fix functional: Saved objects management feature controls saved objects management global visualize all privileges listing redirects to Kibana home

* fix PR comment

* fix TS issues

* Fixed x-pack jest tests

* fix oss JEST

* Fixed functional test

* fix functional test

* fix PR comment

* Fixed i18n

* fix typo

* fix Styles

* Fixed paths for cross_cluster_replication

* fix wrong link

* Fixed jest

* Fixed some comments

* fix sorting

* fix type check

* fixed x-pack jest

* fixed x-pack jest

* reverted using of parentHistory

* Add debugging toasts to CCR.

* Comment out non-CCR functional tests.

* Fix typo.

* Uncomment non-CCR functional tests.

* Enable CCR.

* fix CI

* Add comment to explain why CCR is enabled by default and move config variable back to original location in CCR plugin.

* revert some changes in APM

* add space between index pattern name and tags

* fix function test

* Update x-pack/plugins/security/public/management/management_urls.ts

Co-authored-by: Joe Portner <5295965+jportner@users.noreply.github.com>

* Update x-pack/plugins/security/public/management/api_keys/api_keys_management_app.tsx

Co-authored-by: Joe Portner <5295965+jportner@users.noreply.github.com>

* Update x-pack/plugins/spaces/public/management/spaces_management_app.tsx

Co-authored-by: Joe Portner <5295965+jportner@users.noreply.github.com>

* Update x-pack/plugins/security/public/management/roles/roles_management_app.tsx

Co-authored-by: Joe Portner <5295965+jportner@users.noreply.github.com>

* Update x-pack/plugins/security/public/management/users/users_management_app.tsx

Co-authored-by: Joe Portner <5295965+jportner@users.noreply.github.com>

* Update x-pack/plugins/security/public/management/management_urls.ts

Co-authored-by: Joe Portner <5295965+jportner@users.noreply.github.com>

* Update x-pack/plugins/security/public/management/management_urls.ts

Co-authored-by: Joe Portner <5295965+jportner@users.noreply.github.com>

* [security] getUrlForApp -> navigateToApp

* [mp] fix Uncaught (in promise) undefined

Co-authored-by: Matt Kime <matt@mattki.me>
Co-authored-by: Uladzislau Lasitsa <Uladzislau_Lasitsa@epam.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Co-authored-by: CJ Cenizal <cj@cenizal.com>
Co-authored-by: Joe Portner <5295965+jportner@users.noreply.github.com>
2020-06-03 18:55:06 +03:00
Nathan L Smith
a2f44bc27f
[APM] Fix query bar Japanese translation (#68037)
The order of the `select` statement items were reversed in the translation for `xpack.apm.kueryBar.placeholder`, causing an error in the KueryBar component which caused the page to fail to load.

Fix the translation, which fixes the error.

Fixes #67082.
2020-06-03 10:49:48 -05:00
Alexey Antonov
d7b830a6bf
Kibana 7.7.0: Chart split orientation is wrong (#67840)
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-06-03 17:42:11 +03:00
James Gowdy
c718afcbba
[ML] Fix expanded row bug when job has no datafeed (#68074) 2020-06-03 15:24:13 +01:00
James Gowdy
0897418795
[ML] Adding per_partition_categorization to job interface and schema (#67953)
* [ML] Adding per_partition_categorization to job interface and schema

* adding new fields to Category interface
2020-06-03 15:23:54 +01:00
Justin Kambic
6f3e1bfbe5
[Uptime] Create new atomic params type for status alerts (#67720)
* Create new atomic params type for status alerts.

* Update executor params typing to support both alert params types.

* Update snapshot for alert factory function.

* Fix broken types and refresh snapshots.

* Clean up naming of action/selector.

* Fix a bug and add tests.

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-06-03 09:48:54 -04:00
Joe Reuter
884704d847
relax color rule validation (#67759) 2020-06-03 15:15:30 +02:00
Joe Reuter
f8759d4571
Deprecate kibana.defaultAppId setting (#67635) 2020-06-03 13:34:14 +02:00
Joe Reuter
0a23bfb08c
TSVB: handle division by zero in math agg (#67111) 2020-06-03 13:29:54 +02:00
Joe Reuter
4a1b05c843
Lens editor auto refresh (#65868) 2020-06-03 11:35:55 +02:00
Liza Katz
fbcb74ce28
Add error if filter index pattern is missing (#66979)
* add error if filter index pattern is gone

* docs change - why?

* Fix i18n

* Added a functional test for broken filters (field + index pattern)

* Clarify readme

* Moved readme

* New warning status

* Remove getAll

* git pull upstream master

* Fix translation files

* Fix merge

* added filterbar texts

* disabled correction

* Disable check in maps test until #64861 is resolved

* Fix tests, warning state is not disabled.

* Adjust warning filter - ignore filters from "foreign" index pattern, that are still applicable

* Add an additional unrelaeted filter test

* Update src/plugins/data/public/ui/filter_bar/_global_filter_item.scss

Co-authored-by: Caroline Horn <549577+cchaos@users.noreply.github.com>

* Update src/plugins/data/public/ui/filter_bar/_global_filter_item.scss

Co-authored-by: Caroline Horn <549577+cchaos@users.noreply.github.com>

* Fixed test data

* Revert mapping

* Update data with missing test

* Update test to match data

* Code review

Co-authored-by: Caroline Horn <549577+cchaos@users.noreply.github.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-06-03 09:35:44 +03:00
Matthias Wilhelm
36c6cd9415
[Discover] Fix missing histogram time range update when query is refreshed (#67582) 2020-06-03 06:41:18 +02:00
Garrett Spong
4c30d912a9
[SIEM] [Detections] Renames Signals to Alerts (#67731)
## Summary

Resolves https://github.com/elastic/kibana/issues/65944

Renames `Signals` -> `Alerts` on the main Detection Engine page. Including:
* Timeline Event Selector
* Alerts Histogram
* Alerts Table

Does not include:
* `Detections` -> `Alerts` navigation rename
* `SignalsByCategory` rename as there already exists an `AlertsByCategory`, verify changing to `ExternalAlertsByCategory`
* Anything server-side or related to `siemSignalsIndex`


### Checklist

- [X] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md)
- [X] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios
2020-06-02 21:50:16 -06:00
spalger
fdd0c47e75 skip flaky suite (#53749) 2020-06-02 19:42:03 -07:00
Justin Kambic
d8b66cf7d0
[Uptime] Switch from EuiFieldNumber to EuiFieldText on settings page (#66425)
* Switch from `EuiFieldNumber` to `EuiFieldText` on settings page.

* Add unit tests for cert form fields.

* Improve validation.

* Add additional server-side settings check with tests.

* Only create number object for validation when value is string.

* Clean up validation function.

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-06-02 21:23:37 -04:00
Davis Plumlee
1d86a2abd2
[SIEM][Exceptions] Add success/error toast component on alert state change (#67406)
## Summary

Adds a success and error toast on open or close of alert(s). #65947

<img width="1035" alt="Screen Shot 2020-05-26 at 2 28 57 PM" src="https://user-images.githubusercontent.com/56367316/82947446-5086ae00-9f5d-11ea-848a-9edae48c47dc.png">

<img width="1022" alt="Screen Shot 2020-05-28 at 12 01 03 PM" src="https://user-images.githubusercontent.com/56367316/83176760-3f63ab80-a0db-11ea-9f4d-7b745d0b4bf0.png">


### Checklist

Delete any items that are not applicable to this PR.

- [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md)

### For maintainers

- [ ] This was checked for breaking API changes and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)
2020-06-02 19:23:15 -06:00
Jen Huang
eab74f4005
[Ingest Manager] Change agent config YAML view to flyout (#67918)
* Consolidate context menu/row action components and usage, and some export/imports

* Missed export

* Move agent config yaml tab to flyout, add and consolidate agent config action menus

* Fix i18n

* Add download config YAML endpoint and link from flyout, add common config->yaml service

* Actually remove the tab lol

* Fix i18n
2020-06-02 16:08:41 -07:00
Michail Yasonik
0247df4cfd
New Kibana app link order (#66320) 2020-06-02 16:46:21 -05:00
Dmitry Lemeshko
5e2a78bb52
[test/functional/services] convert dashboard and pie-chart to ts (#66703)
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-06-02 23:24:06 +02:00
Spencer
728a4b23e6
share core bundle with plugins (#67892)
Co-authored-by: spalger <spalger@users.noreply.github.com>
2020-06-02 14:18:37 -07:00
Spencer
48e3bcdaec
[scripts/type_check] increase memory limit for all x-pack* projects (#68007)
Co-authored-by: spalger <spalger@users.noreply.github.com>
2020-06-02 13:53:45 -07:00
Robert Austin
b83d145813
[Endpoint][SIEM] Adjust types related to subplugin's redux (#67768) 2020-06-02 16:52:19 -04:00
nnamdifrankie
9c5eb3a37b
[Endpoint]EMT-395: add policy configuration and reenable tests (#67967)
[Endpoint]EMT-395: add policy configuration and tests
2020-06-02 15:20:05 -04:00
spalger
6481402510 delete flaky suite with flaky beforeAll hook (#67554) (#67555) (#67556) 2020-06-02 11:41:23 -07:00
Christos Nasikas
92237517be
[SIEM] Update cypress to 4.5.0 (#67961) 2020-06-02 20:01:39 +03:00
Ryland Herrick
332a92d3d5
[SIEM][Detections] Allow synchronous rule actions to be updated via PATCH (#67914)
* Update synchronous actions in patchRules

This method was typed to accept actions, but it was not doing anything
with them. This was mainly a "bug by omission" so I'm simply adding
unit tests for regression purposes.

* Allow synchronous actions to be patched either individually or in bulk

Now that patchRules uses this field, we simply need to pass it.

Co-authored-by: Garrett Spong <spong@users.noreply.github.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-06-02 11:56:55 -05:00
Shahzad
13c24b0d81
[Uptime] Fix ping io ts type (#66926)
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-06-02 18:43:13 +02:00
Alejandro Fernández
77e7e0bb49
[Logs UI] Ensure live stream always gets latest entries (#67935)
LogPositionState doesn't always reevaluate the value of `endTimestamp`
when live stream is on. The [dependencies][1] for it to change rely on the
scroll position to update. If there's less than one scroll page or the
previous API call didn't return any entries, the `endTimestamp` would
not update.

We force `Date.now()` as an `endTimestamp` on the API call to ensure it
always gets the latest entries possible, regardless of the state. This
introduces some inconsistency that will be fixed once work beings on #65493.

[1]: fe4c164681/x-pack/plugins/infra/public/containers/logs/log_position/log_position_state.ts (L160-L173)
2020-06-02 17:36:47 +02:00
Corey Robertson
ce7940adc2
Allow functions to return falsy values (#67796)
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-06-02 11:31:30 -04:00
Andrew Goldstein
52c518a6ae
[SIEM] Fixes column drag and drop in timeline-based views (#67799)
## Summary

Fixes a bug in timeline-based views, (e.g. the Host Events table), where a column would revert back to it's original position after being dragged and dropped to a new position.

Only timeline-based views were effected, not the timeline itself.

To reproduce:

1) On the SIEM Overview page, click the `View events` button

2) Drag and drop any column in the Events table to a new position

**Expected Result**

- The column is relocated to the position where it was dropped

**Actual Result**

- The column reverts to it's original position

## Testing

- This PR adds a Cypress test for this scenario
  - The new test was successfully run (at least) 10 times via `node x-pack/plugins/siem/scripts/loop_cypress_tests.js`

- This fix was desk tested in:
  - Chrome `83.0.4103.61`
  - Firefox `76.0.1`
  - Safari `13.1`
2020-06-02 08:57:11 -06:00
Chris Roberson
a1a1d5d2f7
Ensure we query for more than 10 (#67172) 2020-06-02 10:41:04 -04:00
Nathan Reese
d550131b9e
[Maps] fix mapbox glyphs error when EMS access is turned off (#67427)
* [Maps] fix mapbox glyphs error when EMS access is turned off

* santize range parameter

* add api test

* clean up mapbox view

* add jest test for getGlyphsUrl

* add license file

* remove unneeded font files

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-06-02 08:38:25 -06:00
Pierre Gayvallet
a091124fab
Move application.applications$ to public contract (#67463)
* expose applications$ on public contract

* review comments
2020-06-02 15:15:21 +02:00
Sandra Gonzales
7d0ffb53bc
install default packages in parallel (#67893) 2020-06-02 08:32:24 -04:00
Kevin Logan
7da774ff5a
[Endpoint] add new policy fields (#67323) 2020-06-02 07:26:22 -04:00