Commit graph

43782 commits

Author SHA1 Message Date
Matthias Wilhelm
77b5b236e5
[Discover] Unskip and improve empty results query functional test (#102995) 2021-06-23 16:52:49 +02:00
Stratoula Kalafateli
a96eaa480f
[Visualize] Adds an info icon tip to the update button (#101469)
* [Visualize] Adds an info tooltip to the update button

* Add iconTip to the visEditor update button

* Move to the left and change the icon

* Update test

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-06-23 17:52:15 +03:00
Nathan Reese
91295fddd7
[Maps] remove undefined from map embeddable by_value URL (#102949)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-06-23 08:45:02 -06:00
Dmitry Tomashevich
4fa939d9c9
[Discover] Improve flaky test - doc navigation (#102859)
* [Discover] test flakiness

* [Discover] wait for doc loaded

* [Discover] update related test

* [Discover] clean statement
2021-06-23 17:40:58 +03:00
Nathan Reese
b4b17cfdec
[Maps] show radius when drawing distance filter (#102808)
* [Maps] show radius when drawing distance filter

* show more precision when radius is between 10km and 1km

* move radius display from line to left of cursor

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-06-23 08:37:15 -06:00
Nathan Reese
dd907e5487
[maps] fix user has to click back button twice to navigate back to dashboard from create maps screen (#103002)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-06-23 08:36:46 -06:00
Christiane (Tina) Heiligers
bb4e0cc1fc
Adds a versioned class name to a root DOM element (#102443) 2021-06-23 07:21:26 -07:00
David Sánchez
eb9726987c
[Security Solution][Endpoint] Hide endpoint event filters list in detections tab (#102644)
* Add event filters filter on exception list to hide it in UI

* Fixes unit test and added more tests for showEventFilters

* fixes test adding showEventFilters test cases

* Pass params as js object instead of individual variables

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-06-23 16:04:23 +02:00
Wylie Conlon
f49ecb3d1a
Update chart reference docs (#102430)
* Update chart reference docs

* Update from feedback

* Update from review feedback

* Update more from comments

* Apply left alignment
2021-06-23 09:53:16 -04:00
Alejandro Fernández Gómez
6d8f53d8d0
Adjust copy for non-removable integrations/packages (#103068) 2021-06-23 15:50:39 +02:00
Nicolas Chaulet
771f7de87b
[Fleet] Improve default port experience in the settings UI (#102982) 2021-06-23 08:26:46 -04:00
Liza Katz
f8a03829ea
Allow restored session to run missing searches and show a warning (#101650)
* Allow restored session to run missing searches and show a warning

* tests and docs

* improve warning

* tests for new functionality
NoSearchIdInSessionError type

* managmeent tests

* Update texts

* fix search service pus

* link to docs

* imports

* format import

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-06-23 15:20:21 +03:00
Gloria Hornero
b7aaa1fb91
Cypress baseline for osquery (#102265)
* Cypress baseline for osquery

* fix types

* Update visual_config.ts

Co-authored-by: Patryk Kopycinski <contact@patrykkopycinski.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-06-23 13:59:35 +02:00
Joe Reuter
b652ef677f
[Lens] Do not add math columns for pass-through operations (#102656) 2021-06-23 13:48:48 +02:00
Joe Reuter
2ab5d6bc46
disable missing switch for non-string fields (#102865) 2021-06-23 13:47:19 +02:00
Joe Reuter
498df213fa
fix time shift ux issues (#102709) 2021-06-23 13:46:59 +02:00
Vadim Dalecky
1386c330fc
Discover locator (#102712)
* Add Discover locator

* Add Discover locator tests

* Expose locator for Discover app and deprecate URL generator

* Use Discover locator in Explore Underlying Data

* Fix explore data unit tests after refactor

* fix: 🐛 update Discover plugin mock

* style: 💄 remove any

* test: 💍 fix test mock

* fix: 🐛 adjust property name after refactor

* test: 💍 fix tests after refactor

Co-authored-by: Vadim Kibana <vadimkibana@gmail.com>
2021-06-23 13:25:37 +02:00
John Schulz
868ae59c93
[Fleet] Support user overrides in composable templates (#101769)
## Summary
Closes #90454
Closes https://github.com/elastic/kibana/issues/72959

 * Rename the component templates which are [installed for some packages](https://github.com/elastic/kibana/blob/master/x-pack/plugins/fleet/server/services/epm/elasticsearch/template/install.ts#L197-L213) from `${templateName}-mappings` and `${templateName}-settings` to `${templateName}@mappings` and `${templateName}@settings`
 * When any package is installed, add a component template named `${templateName}@custom`
 * Any of above templates also include a `_meta` property with `{ package: { name: packageName } }`
 * On package installation, add any installed component templates to the `installed_es` property of the `epm-packages` saved object
 * On package removal, remove any installed component templates from the `installed_es` property of the `epm-packages` saved object

<details><summary>Kibana logs showing component templates added for package</summary>

```
   │ info [o.e.c.m.MetadataIndexTemplateService] [JFSIII.local] adding component template [logs-endpoint.events.file@mappings]
   │ info [o.e.c.m.MetadataIndexTemplateService] [JFSIII.local] adding component template [logs-endpoint.events.registry@mappings]
   │ info [o.e.c.m.MetadataIndexTemplateService] [JFSIII.local] adding component template [.logs-endpoint.diagnostic.collection@mappings]
   │ info [o.e.c.m.MetadataIndexTemplateService] [JFSIII.local] adding component template [logs-endpoint.events.library@mappings]
   │ info [o.e.c.m.MetadataIndexTemplateService] [JFSIII.local] adding component template [logs-endpoint.events.security@mappings]
   │ info [o.e.c.m.MetadataIndexTemplateService] [JFSIII.local] adding component template [logs-endpoint.events.network@mappings]
   │ info [o.e.c.m.MetadataIndexTemplateService] [JFSIII.local] adding component template [logs-endpoint.alerts@mappings]
   │ info [o.e.c.m.MetadataIndexTemplateService] [JFSIII.local] adding component template [metrics-endpoint.metrics@mappings]
   │ info [o.e.c.m.MetadataIndexTemplateService] [JFSIII.local] adding component template [logs-endpoint.events.process@mappings]
   │ info [o.e.c.m.MetadataIndexTemplateService] [JFSIII.local] adding component template [metrics-endpoint.policy@mappings]
   │ info [o.e.c.m.MetadataIndexTemplateService] [JFSIII.local] adding component template [metrics-endpoint.metadata@mappings]
   │ info [o.e.c.m.MetadataIndexTemplateService] [JFSIII.local] adding component template [logs-endpoint.events.registry@custom]
   │ info [o.e.c.m.MetadataIndexTemplateService] [JFSIII.local] adding component template [.logs-endpoint.diagnostic.collection@custom]
   │ info [o.e.c.m.MetadataIndexTemplateService] [JFSIII.local] adding component template [logs-endpoint.events.security@custom]
   │ info [o.e.c.m.MetadataIndexTemplateService] [JFSIII.local] adding component template [logs-endpoint.events.file@custom]
   │ info [o.e.c.m.MetadataIndexTemplateService] [JFSIII.local] adding component template [logs-endpoint.events.library@custom]
   │ info [o.e.c.m.MetadataIndexTemplateService] [JFSIII.local] adding component template [logs-endpoint.events.network@custom]
   │ info [o.e.c.m.MetadataIndexTemplateService] [JFSIII.local] adding component template [logs-endpoint.alerts@custom]
   │ info [o.e.c.m.MetadataIndexTemplateService] [JFSIII.local] adding component template [metrics-endpoint.metrics@custom]
   │ info [o.e.c.m.MetadataIndexTemplateService] [JFSIII.local] adding component template [metrics-endpoint.policy@custom]
   │ info [o.e.c.m.MetadataIndexTemplateService] [JFSIII.local] adding component template [logs-endpoint.events.process@custom]
   │ info [o.e.c.m.MetadataIndexTemplateService] [JFSIII.local] adding component template [metrics-endpoint.metadata@custom]
```

</details>

<details><summary>screenshot - component templates are editable in the Stack Management UI</summary>
<img width="1342" alt="Screen Shot 2021-06-17 at 4 06 24 PM" src="https://user-images.githubusercontent.com/57655/122465421-1502bb80-cf86-11eb-94f4-9880cb3ea844.png">
</details>


### Checklist

Delete any items that are not applicable to this PR.

- [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials
- [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
2021-06-23 06:57:39 -04:00
Tiago Costa
0477c4dae4
skip flaky suite (#84440) 2021-06-23 11:28:08 +01:00
Tiago Costa
e1ec8b05b6
chore(NA): moving @kbn/optimizer into bazel (#102965)
* chore(NA): moving @kbn/optimizer into bazel

* chore(NA): fix source import from kbn optimizer

* chore(NA): update snapshots
2021-06-23 11:11:13 +01:00
Jonathan Budzenski
38be1d06bc
[cli] Add kibana-encryption-keys.bat (#102070)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-06-23 11:10:57 +01:00
Nicolas Chaulet
a6bef93225
[OsQuery] fix usage collector when .fleet indices are empty (#102977) 2021-06-23 11:15:12 +02:00
Marco Liberati
c6e697f38c
[Lens] Remove rank direction tooltip (#102886) 2021-06-23 10:27:43 +02:00
Marco Liberati
7733950bde
[Lens] Avoid suggestion rendering and evaluation on fullscreen mode (#102757) 2021-06-23 10:27:27 +02:00
Vadim Dalecky
1315521760
Ingest pipeline locator (#102878)
* feat: 🎸 implement ingest pipeline locator

* feat: 🎸 improve ingest pipeline locator

* feat: 🎸 register ingest pipeline locator

* refactor: 💡 use locator in expand_row component

* chore: 🤖 remove ingest pipelines URL generator

* fix: 🐛 correct TypeScript errors

Co-authored-by: Vadim Kibana <vadimkibana@gmail.com>
2021-06-23 10:23:28 +02:00
Matthias Wilhelm
12aa46fad9
[Discover] Unskip Discover large field number test (#100692) 2021-06-23 09:58:10 +02:00
Robert Oskamp
5a8e7407b4 [ML] Functional tests - temporarily skip close_jobs API tests 2021-06-23 09:42:09 +02:00
Ashokaditya
b12ddfabf0
[Security Solution][Endpoint] Paginate actions log with infinite scroll (#102261)
* Show loading below the list when loading

fixes elastic/security-team/issues/1245

* use intersection observer to load data when callout is visible

fixes elastic/security-team/issues/1245

* remove unused `total` from API response

refs 4f7d18bee7

* toggle ability to paging based on API response and target intersection

fixes elastic/security-team/issues/1245

* use a invisible target

* display a message when end of log

fixes elastic/security-team/issues/1245

* remove search bar

fixes elastic/security-team/issues/1245

* refresh data

fixes elastic/security-team/issues/1245

* rename

refs 85e5add14e

* add refresh button to empty state

* add translations for copy

* remove refresh button

* load activity log for endpoint on activity log tab selection

fixes elastic/security-team/issues/1312

* reset paging correctly on activity log tab selection

* fix variable mixup

refs elastic/kibana/pull/101032/commits/c4e933a9c5954ce249942ca66bab380c1dfa79e2#diff-41a74ad41665921620230a0729728f3bf6e27a6f9dc302fb37b0d2061637c212R81

* fix react warning

refs 697a3c3bac

* clean up

review changes

* use the complicated flyout version instead of styled version

refs https://elastic.github.io/eui/#/layout/flyout#more-complicated-flyout
refs https://github.com/elastic/kibana/pull/99795/files#r635810660
refs c26a7d47b4

* Page only when scrolled (so that info message is shown after paging once)

fixes https://github.com/elastic/security-team/issues/1245#issuecomment-863440335

* add tests

fixes elastic/security-team/issues/1312
fixes elastic/security-team/issues/1245

* increase the parent container's height to ensure that the scroll target is well hidden below the footer

refs 48e3291681

* Update x-pack/plugins/security_solution/public/management/pages/endpoint_hosts/store/reducer.ts

Co-authored-by: Paul Tavares <56442535+paul-tavares@users.noreply.github.com>

* Update x-pack/plugins/security_solution/public/management/pages/endpoint_hosts/view/index.test.tsx

Co-authored-by: Paul Tavares <56442535+paul-tavares@users.noreply.github.com>

* address review changes

* cleanup callback and effect

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Paul Tavares <56442535+paul-tavares@users.noreply.github.com>
2021-06-23 09:19:13 +02:00
Jonathan Budzenski
3e952faf88 Revert "[alerting][actions] add task scheduled date and delay to event log (#102252)"
This reverts commit bb77fa6967.
2021-06-22 21:55:29 -05:00
Constance
01ac8d2d69
[App Search] Convert Synonyms page to new page template (#102828)
* Convert Synonyms page to new page template

* Update empty state for new page template

- Remove EuiPanel wrapper - KibanaPageTemplate does that automatically for us

- Include SynonymModal, required for header create button to work as expected

* Update router

* [UI polish] Proposed page description copy from Davey

- see 9807bf249a

* [UI polish] Add plus icon to create button

- To match other create buttons across app
2021-06-22 19:50:13 -07:00
Patrick Mueller
bb77fa6967
[alerting][actions] add task scheduled date and delay to event log (#102252)
resolves #98634

This adds a new object property to the event log kibana object named
task, with two properties to track the time the task was scheduled to
run, and the delay between when it was supposed to run and when it
actually started. This task property is only added to the appropriate
events.

	task: schema.maybe(
	  schema.object({
	    scheduled: ecsDate(),
	    schedule_delay: ecsNumber(),
	  })
	),
2021-06-22 20:57:26 -04:00
Dominique Clarke
450ababee5
[Uptime] Refactor cert alerts from batched to individual (#102138)
* refactor cert alerts from batched to individual

* remove old translations

* create new certificate alert rule type and transition old cert rule type to legacy

* update translations

* maintain legacy tls rule UI to support legacy rule editing

* update translations

* update TLS alert content, rule type id, and alert instance id schema

* remove extraneous logic and format date content

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-06-22 20:56:43 -04:00
Constance
e582549500
[App Search] Convert Curations pages to new page template (#102835)
* Update CurationRouter

- Remove breadcrumbs set in router (will get set by page template)
- Set up a curation breadcrumb helper for DRYness
- Remove NotFound route - curation ID 404 handling will be used instead

* Convert Curations page to new page template
+ move Empty State from table to top level

* Convert Curation creation page to new page template

* Convert single Curation page to new page template

+ remove breadcrumb prop

* Update router

* [Polish] Copy changes from Davey

- see https://github.com/elastic/kibana/pull/101958/files

- Per https://elastic.github.io/eui/#/guidelines/writing we shouldn't be using "new", so I removed that also

* [UI polish] Add plus icon to create button

- To match other create buttons across app
2021-06-22 17:35:00 -07:00
Constance
cf12c031cf
[App Search] Migrate Source Engines & Crawler pages to new page template (#102848)
* Convert meta engines Source Engines view to new page template

* Convert CrawlerLanding to new page template

* Convert CrawlerOverview to new page template

* Update routers

* Misc Source Engines UI polish

- move away from color=secondary, EUI is eventually deprecating it
- add (+) icon to match other views

* Fix bad merge conflict
2021-06-22 17:25:39 -07:00
CJ Cenizal
5df858aae1
Migrate Index Management to new solutions nav (#101548)
* Migrate index template and component template wizard pages to new nav.
* Convert index templates and component templates pages to new nav.
* Convert indices and data streams pages to new nav.
* Add PageLoading component to es_ui_shared.
* Refactor index table component tests.
* Add missing error reporting to get all templates API route handler.
2021-06-22 17:15:57 -07:00
Paul Tavares
e53da4e3eb
[Security Solution][Endpoint] Adjust Host Isolation form to match UI mocks (#102978)
* Change text on form to match mocks
* Switch to using EuiForm ++ EuiFormRow
2021-06-22 19:44:09 -04:00
Bhavya RM
859b453752
Replacing es_archives/reporting/ecommerce_kibana with kbn_archiver/reporting/ecommerce.json as part of migrating to kbn_archiver (#102825) 2021-06-22 19:16:53 -04:00
Xavier Mouligneau
4fa3dc46cb
[RAC] T-Grid is moving to a new home (#100265)
* wip

* First pass at standalone and embedded redux stores and usage

* wip

* First pass at standalone and embedded redux stores and usage

* wip

* clean up

* wip

* refact(NA): remove extra pkg_npm target and add specific target folders on @kbn/i18n

* cleanup

* - fixes type errors in tests

* WIP remove use_manage_timeline

* wip add query + selector

* finishing integrating timeline manage context from redux

* integrating t-grid in security solution

* fix RowRender type

* WIP begin to move components from package to plugin

* integration of t-grid inside of security solution

* wip to make redux work

* little trick to make  it render

* - fixes a few type errors

* better integration betwen tgrid and security solutions

* bringing back tsconfig on timeline

* wip integration t-grid in observability

* fix types

* fix type in security solutions

* add type to import + trie dto get the bundle size as small as possible

* fix type in integration test

* fix type in integration test

* - fix tests

* clean up to use technical fields

* - fixes unit tests

* - mocks the `useDateFormat` function of the `useKibana` service to fix unit tests

* fix t-grid settings vs create timeline + fix inspect button

* fix last suites test

* Update unit tests, snapshots and lint

* Fix bad merge

* fix plugin export

* Fix some failing tests

* fix unit tets in timelines plugins

* fix latest test

* fix i18n

* free obs from t-grid

* Fix timeline functional plugin types

* fix store provider

* Update failing defaultHeader test

* Fix i18n usage in security solution

* Fix remaining i18n errors in timelines plugin

* Dedupe common shared types

* move drag and drop utils in package to avoid duplication

* More shared type cleanup

* add feature flag

* review I

* fix merge  with master

* fix i18n translation

* More type deduping

* Use @kbn/common-utils, fix remaining types

* fix types

* fix tests

* missing type

* fix cypress tests

Co-authored-by: Kevin Qualters <kevin.qualters@elastic.co>
Co-authored-by: Tiago Costa <tiagoffcc@hotmail.com>
Co-authored-by: Andrew Goldstein <andrew.goldstein@elastic.co>
2021-06-22 18:56:33 -04:00
Søren Louv-Jansen
369127e8c2
[APM] Fix bug when error page is empty (#102940) 2021-06-23 00:12:05 +02:00
Constance
0548f98708
[App Search][Polish] API Logs empty state (#102998)
* Re-add noItemsMessage to ApiLogsTable

- Primarily for Engine Overview use - totally forgot about this 🤦

* Tweak API logs empty state copy

- after discussing w/ Davey
2021-06-22 17:46:47 -04:00
Constance
e580d5a1e2
[App Search] Convert Result Settings & Relevance Tuning pages to new page template (#102845)
* Convert Result Settings page to new page template

+ remove wrapper around empty state (auto handled by new page template)
+ update tests w/ new test helpers

* Convert Relevance Tuning page to new page template

- Remove old relevance_tuning_layout (which handled breadcrumbs, page header, flash messages, and callouts) in favor of simply using the new templtate + callouts (yay DRYing)

- Remove panel wrapper around empty state (handled by new page template)

* Update router

* [Polish] Spacing & icon polish from Davey

see https://github.com/elastic/kibana/pull/101958/files
2021-06-22 14:43:54 -07:00
Melissa Alvarez
b161bf03be
[ML] Anomaly Detection: Visualize delayed - data Part 2 (#102270)
* add link in datafeed tab.remove interval

* add annotation overlay to chart

* adds annotations checkbox

* ensure annotation with same start/end time show up in chart

* update annotations time format

* move time format to client

* adds info tooltip to modal title

* adds model snapshots to datafeed chart
2021-06-22 16:58:18 -04:00
Chris Roberson
dec77cfafb
[Alerting] Add event log entry when an action starts executing (#102370)
* First steps for adding action execution to event log

* Fix tests

* Move the event to the actions plugin

* Update functional tests

* Fix tests

* Fix types
2021-06-22 16:01:43 -04:00
Constance
b386ce149a
[App Search] Convert Schema pages to new page template (#102846)
* Convert Schema page to new page template

+ update empty state - remove panel wrapper, add create schema field modal

* Convert ReindexJob view to new page template

+ remove breadcrumb prop

* Convert Meta Engine Schema view to new page template

* Update routers

* [Polish] Misc Davey Schema UI tweaks

- see https://github.com/elastic/kibana/pull/101958/files

+ change color away from secondary, since that's going away in EUI at some point

* [UX] Fix SchemaAddFieldModal stuttering on first new schema field add

- With the new template, transitioning from the empty state to the filled schema state causes the modal to stutter due to the component rerender

- Changing the page to not instantly react/update `hasSchema` when local schema state changes but instead to wait for the server call to finish and for cachedSchema to update fixes the UX problem

* [UI polish] Revert button color change per Davey's feedback
2021-06-22 12:27:27 -07:00
Patrick Mueller
86fb2cc90e
[actions] add rule saved object reference to action execution event log doc (#101526)
resolves https://github.com/elastic/kibana/issues/99225

Prior to this PR, when an alerting connection action was executed, the event 
log document generated did not contain a reference to the originating rule. 
This makes it difficult to diagnose problems with connector errors, since 
the error is often in the parameters specified in the actions in the alert.

In this PR, a reference to the alerting rule is added to the saved_objects 
field in the event document for these events.
2021-06-22 15:18:35 -04:00
Clint Andrew Hall
2b0f1256dd
[canvas] New Home Page (#102446)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-06-22 14:11:15 -05:00
Constance
f422cbdcf1
[App Search] Convert API Logs page to new page template + empty state polish (#102820)
* Convert API Logs noItemsMessage to its own empty state prompt

- Will be used by new page template

* Convert API Logs view to new page template

+ use new empty state
+ add tests clarifying loading UX

* Update router

* Fix i18n ID
2021-06-22 11:40:10 -07:00
Joe Portner
00a6bdd401
Allow initialNamespaces to be used for isolated types (#102585) 2021-06-22 20:36:04 +02:00
Lisa Cawley
953a464e94
[Monitoring] Update Kibana rules/alerts language in setup mode (#102441) 2021-06-22 11:21:19 -07:00
Alison Goryachev
c33138e5cb
[Rollups] Migrate to new page layout (#102268) 2021-06-22 14:13:48 -04:00