- Caused by the wrapping <div> around the child views - removing that div and moving the `data-test-subj` hooks to the individual views fixes the issue
Co-authored-by: Constance <constancecchen@users.noreply.github.com>
* Remove isFederated from main app and routes
* Expose all overview cards that were hidden for federated auth
* Expose all user features that were hidden for groups
* Remove remaining isFederatedAuth references
* Lint fixes
* Add modified test back for Workplace Search
* Remove extraCell
Co-authored-by: Constance <constancecchen@users.noreply.github.com>
* Remove brackets
Co-authored-by: Constance <constancecchen@users.noreply.github.com>
* Update test name
Co-authored-by: Constance <constancecchen@users.noreply.github.com>
Co-authored-by: Constance <constancecchen@users.noreply.github.com>
Co-authored-by: Scotty Bollinger <scotty.bollinger@elastic.co>
Co-authored-by: Constance <constancecchen@users.noreply.github.com>
* Refactor NotFound component
- shared NotFound becomes NotFoundPrompt - returns only an EuiEmptyPrompt, and individual products/plugins are in charge of their own layout, rather than NotFound doing a bunch of arduous switch handling (also closer to how errorConnecting is a component set per-plugin)
- This is both due to the recent page template refactor and the fact that WS has extra complex logic of needing to switch between its kibana layout and personal dashboard layout
- logos are still hosted in shared/ since they need extra custom CSS to work correctly sizing wise and in dark mode. I renamed its folder from `assets`->`logos` for extra clarity
* [AS] Update current AS routers using NotFound
+ update EngineRouter to use NotFound
* [WS] Update app router
- Handle errorConnecting at the topmost level, instead of in WorkplaceSearchConfigured (to simplify various logic/expectations & match App Search)
- Simplify isOrganization check to use `useRouteMatch` instead of a regex
- Use new NotFound component
- Add NotFound component for the personal dashboard router
* [WS] Improve Source 404 UX
- Add NotFound to SourceRouter + add breadcrumbs for organization views
- When an actual source ID 404s, fix blanket redirect to a dashboard aware redirect - personal dashboard 404s should send the user back to personal sources, not organization sources
+ add a flash message error (similar to how App Search behaves for engine 404s)
+ harden error status checks (gracefully allow for non-http errors to fall back flashAPIErrors
* [WS] Improve Settings 404 UX
- This was the only remaining WS route I found that either did not have a 404 or a fallback to some overview page, so I tweaked the redirect order for a graceful redirect (vs a blank page)
* Fix settings router test
* Move away from custom product logos to OOTB Enterprise Search logo
Keeping it simple, etc. RIP in peace fancy logos
* [PR feedback] toContain over stringContaining
Co-authored-by: Constance <constancecchen@users.noreply.github.com>
* Improve field popover
* Slightly improve type safteyness
* Add unit tests for visualize trigger utils
* Remove unused div
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Tim Roes <tim.roes@elastic.co>
* Reporting: Task Manager integration for 7.x
* update test assertions, use more explicit types
* update comment
* Update x-pack/plugins/reporting/server/lib/store/store.ts
Co-authored-by: Vadim Dalecky <streamich@gmail.com>
* fix field mapping
* Update x-pack/plugins/reporting/server/lib/store/store.ts
Co-authored-by: Jean-Louis Leysens <jloleysens@gmail.com>
* Report also implements ReportDocumentHead
* the actual ID of the task is prefixed with `task:`
* remove pointless update to the report instance after failing
* comment clarification
* sync with 8.0
Co-authored-by: Vadim Dalecky <streamich@gmail.com>
Co-authored-by: Jean-Louis Leysens <jloleysens@gmail.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
## Summary
`public/applications/integrations/constants.tsx` and
`public/applications/integrations/sections/epm/constants.tsx` are identical except for this line in `public/applications/integrations/constants.tsx`
```ts
export * from '../../constants';
```
This PR removes all the duplication from the "upper" file (`public/applications/integrations/constants.tsx`) and leaves the other code "down" in `/sections/epm/` closer to where it's used.
Initially, I deleted `public/applications/integrations/constants.tsx` entirely but several files do `import` the constants it exports, so I left it.
Co-authored-by: John Schulz <john.schulz@elastic.co>
* [Discover] move focus on show chart
* [Discover] set actual moveFocus flag
Co-authored-by: Dmitry Tomashevich <39378793+Dmitriynj@users.noreply.github.com>
* Gate behind a config with warning message that helps users enable
* Update more files
* Fix docs formatting
* Preserve existing functionality
* Add in task type to the message
* Show multiple alert types that are over the threshold
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
* update the UI breadcrumbs in create policy package to always look like it came from integrations
* added comment about the removal of a path from fleet
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Jean-Louis Leysens <jloleysens@gmail.com>
resolves#98634
This adds a new object property to the event log kibana object named
task, with two properties to track the time the task was scheduled to
run, and the delay between when it was supposed to run and when it
actually started. This task property is only added to the appropriate
events.
task: schema.maybe(
schema.object({
scheduled: ecsDate(),
schedule_delay: ecsNumber(),
})
),
Note that these changes were previously merged to master in https://github.com/elastic/kibana/pull/102252 which had to be reverted - this PR contains the same commits, plus some additional ones to resolve the tests that were broken during the bad merge.
* Fix UBI source URL
This commit fix the source URL for UBI image to ensure that it stays
consistent with the URL generated in
https://artifacts.elastic.co/reports/dependencies/dependencies-current.html
* Update src/dev/run_licenses_csv_report.js
Co-authored-by: Jonathan Budzenski <jon@budzenski.me>
* Update src/dev/run_licenses_csv_report.js
Co-authored-by: Jonathan Budzenski <jon@budzenski.me>
* try to make eslint happy
Co-authored-by: Jonathan Budzenski <jon@budzenski.me>
Co-authored-by: Jonathan Budzenski <jon@budzenski.me>
* Use better loading indicator for `useLogSource`
* Use clearer name for the loading entries flag
* Reuse query object if its value persists
Co-authored-by: Alejandro Fernández Gómez <alejandro.fernandez@elastic.co>
* Rename method to close both flyouts
This is shared with the forthcoming user flyouts
closeRoleMappingFlyout -> closeUsersAndRolesFlyout
* Add logic for elasticsearch users and single user role mappings
* Add logic for various form states
- Showing and hiding flyouts
- Select and text input values
- User created state to turn flyout into a success message state
* Add User server routes
* Add logic for saving a user
* Add User components
* Add User list and User flyout to RoleMappings view
* Fix path
* Rename things
- Users & roles -> Users and roles
- roleId -> roleMappingId (matches other places in code)
- also added a missing prop to the actions col
* Set default group when modal closed
The UI sets the default group on page load but did not cover the case where the user has chosen a group in a previous interaction and the closed the flyout. This commit adds a method that resets that state when the flyout is closed
Part of porting of https://github.com/elastic/ent-search/pull/3865
Specifically:
a4131b95da
* Adds tooltip for external attribute
This was missed from the design
Part of porting of https://github.com/elastic/ent-search/pull/3865
Specifically:
03aa349cab
* Fix invitations link
* Fix incorrect role type
Role-> RoleTypes
🤷🏽♀️
* Add EuiPortal to Flyout
Wasn’t needed in ent-search; already done for RomeMappingFlyout. Hide whitespace changes plskthx
* Auth provider deprecation warning in mapping UI
Since we're moving fully into Kibana, we're losing our concept of auth providers. In 8.0, role mappings the specify an auth provider will no
longer work, so this adds a small deprecation warning in the role mappings table.
https://github.com/elastic/ent-search/pull/3885
* Email is no longer required
After a slack discussion, it was determined that email should be optional.
This commit also fixes another instance of the App Search role type being wrong.
* Existing users’ usernames should not be editable
* Use EuiLink instead of anchor
* Add validation tests
* Change URL for users_and_roles
Need to change folder and file names but will punt until after 7.14FF
I did throw in updating the logic file path
* Remove unused import
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Scotty Bollinger <scotty.bollinger@elastic.co>
* * Fix stale enrollment api token bug
* Refactored naming
* raise the state of the selected enrollment api key to parent to avoid state sync issues
* removed consts for onKeyChange and selectedApiKeyId
* fix typo
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Jean-Louis Leysens <jloleysens@gmail.com>
Both APM and Observability plugins have a `useBreadcrumbs` hook.
APM's takes the whole list of route definitions, creates the whole path of breadcrumbs, and has an effect to set the breadcrumbs and the page title.
The Observability plugin's `useBreadcrumbs` just takes an array of breadcrumb objects, adds onclick handlers for them, and has an effect to set the breadcrumbs and the page title.
Rename APM's `useBreadcrumbs` to `useApmBreadcrumbs`. It still constructs the path based on the routes and the current route, but then just calls out to the Observability plugin's `useBreadcrumbs` to do the breadcrumb and title setting.
Now all APM breadcrumbs begin with "Observability" which links to the Observability overview, but the rest of them remain the same.
Co-authored-by: Nathan L Smith <nathan.smith@elastic.co>
