Commit graph

16129 commits

Author SHA1 Message Date
CJ Cenizal
7cda1aae09 [eslint-config-kibana] Apply AirBnB spacing rules (#14522) (#14590)
* Add AirBnB key-spacing rule.
* Add AirBnB comma-spacing rule.
2017-10-25 15:19:19 -07:00
Stacey Gammon
332ce0dbb0 Use spread operator over Object.assign (#14496) 2017-10-25 15:43:31 -04:00
Chris Cowan
677a417b30 Fixes #14124 - removes the 1w label (#14577) 2017-10-25 11:26:25 -07:00
Court Ewing
dc0c08003d scripts: bump backport tool to 1.0.1 (#14581) (#14582) 2017-10-25 13:37:50 -04:00
Thomas Neirynck
553344ccb1 use proper SVG APIs to readout contents (#14458) (#14578) 2017-10-25 13:21:53 -04:00
Chris Cowan
854d88ab7c [TSVB] Remove console.log from Resize PR (#14555) 2017-10-25 09:54:04 -07:00
Matt Apperson
0638bcac6e [TSVB] change how the resize component works to not use timeouts (#14320)
* [WIP] Atempt to use a new resize component that does not use timeouts

* remove unused var

* add copyright notices
2017-10-25 09:53:40 -07:00
Jonathan Budzenski
21f22d3334
Bump node to 6.11.5 (#14568) 2017-10-25 09:26:59 -05:00
Tim Roes
8d7dce9276 [TSVB] Allow negative time offsets (#14494) (#14562)
* Allow negative offsets in TSVB

* Fix linting issue
2017-10-25 15:43:05 +02:00
Tim Roes
b79b175bd1 [Accessibility] Improve filter bar accessibility (#14474) (#14564)
* Prefix negative filters with "NOT"

* Make filters tabable and add ARIA
2017-10-25 11:14:24 +02:00
Nathan Reese
d49b1f1cc9 Scale histogram aggregation interval to avoid crashing browser (#14157) (#14531)
* update histogram agg to fetch min and max when search request started

* scale interval when too many buckets are created

* move min and max params into autoBounds param, remove typo in help text

* use decorated property instead of params to avoid changing agg state, add functional test

* remove sleep from functional test

* make args for onSearchRequest functions specific. Add getters and setters for autoBounds to AggConfig. Protect against divide by zero

* add unused arguments with eslint comment
2017-10-24 19:34:30 -06:00
CJ Cenizal
fa3daf82cb Fix broken kuiInputBackgroundColor reference. (#14558) (#14559) 2017-10-24 17:55:32 -07:00
CJ Cenizal
a477efdc0b [UI Framework] Improve KuiContextMenu keyboard navigation UX (#14434) (#14556)
* Refactor focus state logic to use the React lifecycle correctly.
* Update KuiPopover snapshots.
* Remove unnecessary isVisible prop from KuiContextMenu.
* Allow user to both tab AND use the arrow keys for navigation.
* Reinstate ability to tab and shift-tab to the title of KuiContextMenuPanel.
* Release focus from Dashboard panel options KuiContextMenu by closing it when you select an option.
* Update KuiContextMenu example to demonstrate best practice of closing the menu when an item is clicked.
* Replace native transitionend event handler with onAnimationEnd React event handler.
2017-10-24 17:39:53 -07:00
CJ Cenizal
5324bb9ea3 [11532] Improve local nav accessibility (#14365) (#14554)
* Use h2 elements for titles in Sharing dropdown.
* Override inherited typographic styles in kuiLocalDropdownTitle.
* Use h2 elements for titles in Console dropdowns.
* Update kuiLocalDropdownHeader__label class to be applicable to legend elements.
* Update Console settings menu with aria labeling and UI Framework styles.
* Remove unused config-close styles.
* Update Dashboard local nav dropdowns with form labels and h2 elements.
* Add support for dark theme to kuiCheckBox.
* Update Dashboard local nav dropdowns and saved-object-save-as-check-box directive with kuiCheckBoxLabel styles.
* Update Discover local nav with h2 elements.
* Update Visualize local nav with h2 element.
* Add aria-label to unlabeled inputs in Discover, Visualuze, and Timelion inputs.
* Update Timelion local nav with h2 elements.
* Update timepicker with tab roles, h2 elements, and UI Framework styles.
* Improve labeling and add aria-selected to timepicker tabs.
- Refactor timepicker tabs to adhere to tablist structure correctly.
* Add tablist role.
2017-10-24 17:28:53 -07:00
Nathan Reese
704214ae7d input controls icon (#14517) (#14552) 2017-10-24 17:28:16 -06:00
Chris Cowan
232ad9535e Math Aggregation to support Sibling Aggs for TSVB (#13681)
* Math Aggregation to support Sibling Aggs

* Fixing tests

* Deal with ResultSets

* including all var under params; updating docs

* Fixing bugs asscociated with blank Math aggs

* Adding aria props to elements

* Fixing aria labels; changing calculation label to bucket sript

* changing input to textarea

* Add compatability with percentiles; fix vars to be compatible with percentiles

* Adding comments

* Fixing typo in note
2017-10-24 15:55:07 -07:00
Chris Cowan
fe7e8a59df Table Visualization for TSVB (#12813)
* Adding table vis

* Making linter happy

* Getting the data api inline

* Fixing aggs for table vis

* Fixing aggs for table vis

* Adding table vis

* Adding uiState and sorting

* Adding sorting

* Adding sorting and removing display fields

* fixing color picker in timeseries and gauge; thresholds for trend arrows

* Removing thresholds from trends

* removing background color

* remvoing obsolete tests

* Fixing terminology... pivot doesn't make sense

* updating error message

* making the sort icons match the rest of the app

* Fixing eslint bullshit

* Fixing a few bugs from merges

* Fixing linting issues

* Adding a falsy check

* Adding aria labels

* Changing toggle to use a button

* Adding focus-ring back in

* Adding check for model and visData; they should never be null

* Changing ids to use new htmlIdGenerator function

* Switching to htmlIdGenerator

* Fixing the way sorting works; fixing the error handling

* making no data compatible with vis

* Fixing defaults bug; Adding missing css rule

* Fixing sorting bug
2017-10-24 15:53:40 -07:00
Matt Apperson
cb29f3b6f4 [TSVB] Display messaging to indicate no data vs empty charts (#14299)
* Visualization shows no data message vs empty charts
* added no data messaging to markdown variables
* Parse errors from handlebars and display clean errors to users
2017-10-24 15:53:04 -07:00
Stacey Gammon
22c5def3d0 Fix flaky test (#14543) (#14551)
Doesn’t fix the underlying issue (which hasn’t been determined yet) but
it should get the build passing consistently again.
2017-10-24 18:47:46 -04:00
Chris Cowan
e2a7fcba01 [TSVB] Adding predict option to moving average (#14268) 2017-10-24 14:06:50 -07:00
Chris Cowan
643fde53dd Fixes #14367 - Add courier's migrateFilters to dashboard context (#14481) 2017-10-24 14:00:56 -07:00
Court Ewing
01e5daf169 Add Backport to toolchain (#14525) (#14548) 2017-10-24 16:56:16 -04:00
Thomas Neirynck
a3739d1817 Re-enable the tilemap test (#14532) (#14538)
Enables the tile-map test. this was disabled due to CORS-issues on the server end. These are now resolved.

This reverts commit e7fb1b0d8f.
2017-10-24 14:03:37 -04:00
Kim Joar Bekkelund
cda309b153 Use Array.isArray instead of _.isArray (#14501) (#14533) 2017-10-24 17:49:54 +02:00
Tim Roes
03fe57f7e4 Fix crash when hitting shift+return in Dev Tools Console, fix #14468 (#14478) (#14507) 2017-10-24 14:50:25 +02:00
Stacey Gammon
e5e3dbb94d Introduce redux into dashboard (#14518) (#14521)
* Initial check in of introducing redux in dashboard

* Use redux-actions and redux-thunks to reduce boilerplate

* Make sure all panels are minimized from the start when a dashboard is loaded - we don't want a panel id from a different dashboard in the state tree on a fresh open.

* Remove unused file

* use classnames dependency instead of manual logic

* First pass on selectors, handleActions, and more segmented reducers.

* Fix bugs with selectors and reducers and add tests that would have caught them.

* Fix issue plus tests

discover was not returning a promise

* Make expanding a panel purely a css modification which avoids all re-renders

* Found another bug with initial state not being set correctly on a hard refresh

* Remove check for change handlers now that the event handler bug is fixed

* rename dashboardState => dashboard for reducers and redux state tree

* Remove unnecessary top level describe in jest tests

* Navigate back to landing page at the end of the newly added test suite

* Fix lint errors

* Stabilize flaky tests by waiting until saved object search is finished loading results

* Don't leak subscriptions to the store.

* use selectors to grab dashboard panel off state.

* Remove use of getState in dispatcher to avoid circular reference and still use selectors

* use spread over object.assign

* No need to pass second param in when the input is simply returned as-is.
2017-10-23 21:31:55 -04:00
Stacey Gammon
2765fea3e3 Comment out tile map tests to get the build passing again (#14519) 2017-10-23 17:49:52 -04:00
Chris Cowan
d35474589a Fixing css to nowrap value; removed duplication; removed comments (#14254) 2017-10-18 16:31:20 +02:00
Chris Cowan
3adc458944 [TSVB] Adding the ability to sort terms split by terms; Adding ability to change sort direction (#14213) 2017-10-18 16:27:00 +02:00
Chris Cowan
e4ad1c8472 [TSVB] UI Tweaks for data format picker (#14313) 2017-10-18 16:22:24 +02:00
Chris Cowan
117bd7ccc4 Fixes #14470 - Remove field restriction on cardinality agg (#14483) 2017-10-18 15:55:28 +02:00
Stacey Gammon
d0f5da4129 fix #14462 (#14463) (#14465)
Prevents handlers from being fired when emit is triggered right before
off is called, but in the same event loop.
2017-10-15 13:16:38 -04:00
Peter Pisljar
edf4a5428c some updates to visualize loader (#14404)
* some updates to visualize loader

* auto load Private (suggestion by thomas)
2017-10-15 07:11:11 +02:00
Kim Joar Bekkelund
8ddb1cf260 Use Boom.boomify instead of deprecated Boom.wrap (#14325) (#14437) 2017-10-13 11:42:13 +02:00
CJ Cenizal
e3292cf397 Fix margin for KuiLocalTabs which are applied to typographic elements. (#14451) 2017-10-12 16:06:36 -07:00
Stacey Gammon
448fb5e8ca Reactify visualize listing table (#14227) (#14447)
* Reactify visualize listing table

* refactor toolbar => toolBar

* use prompt prop to also cover loading and didn't match search logic.

* Use default alignment instead of ternary

* Add keys to array elements where missing

* Add align property to KuiTableHeaderCell

* Fix issue with filter not showing up in search tool bar

* onCheckChanged => onSelectionChanged

* pagerComponent => pager, actionComponent => actions

* use singular verbiage when only 1 item is selected

* exit early per style guide

* fix lint errors

* rename columns => header

* Refactor KuiTableHeaderCell into KuiListingTable

isChecked => isSelected

contents => content

refactor KuiTableRowCell internally

* fix lint errors

* areAllRowsChecked => areAllRowsSelected

* improve itemSelectedCount logic in KuiListingTableToolBarFooter

* React.Component => Component

* make header data a variable, not a function

* Only consider all rows selected if rows exist and they are all selected, not if there are no rows.

* Adding a few KuiListingTable tests

* Give one column sort attributes in examples page
2017-10-12 15:13:12 -04:00
Tim Roes
401e15b156 Add (GPL-2.0 OR MIT) license as allowed (#14439)
* Add GPL-2.0 OR MIT license as allowed
* Remove ua-parser-js from overwrites
2017-10-12 13:23:27 +02:00
Tim Roes
b05549a002 [UI Framework] KuiGalleryItem automatically becomes link or button (#14240)
* KuiGalleryItem automatically becomes link or button

* Add onClick tests

* Add doc example with onClick
2017-10-12 10:22:55 +02:00
Tim Roes
b15d12ac23 Apply correct ARIA roles for kuiLocalTabs (#14416)
* Fix kuiLocalTabs roles

* Fix tab roles in doc-viewer

* Apply tab roles to vis editor
2017-10-12 10:09:45 +02:00
CJ Cenizal
c107b0aea0 Add missing KuiPopover tests. (#14433) 2017-10-11 17:01:52 -07:00
Thomas Neirynck
13fbbcf410 Improve docs on spatial reference requirements (#14422) 2017-10-11 15:35:20 -04:00
Court Ewing
b50518f6fc test: move es proxy tests to api_integration (#14406)
Integration tests should go into the corresponding directory under
`test` and should use the appropriate testing framework that is designed
for long-running tests like those. Tests under __tests__ directories
should be fast-running unit tests only.
2017-10-11 13:59:36 -04:00
Court Ewing
2c8172d037 test: move url shortener tests to api_integration (#14411)
Integration tests should go into the corresponding directory under
test and should use the appropriate testing framework that is designed
for long-running tests like those. Tests under tests directories
should be fast-running unit tests only.
2017-10-11 13:58:00 -04:00
CJ Cenizal
02906ea362 Refine use of aria-label in Dashboard panel and top nav, Discover, and Management 'Edit index pattern' UI. (#14341) (#14430) 2017-10-11 10:43:29 -07:00
CJ Cenizal
b0671fd4a9 Update accessibility guide with note that it's valid to use aria-label directly on form elements. (#14361) 2017-10-11 09:51:10 -07:00
CJ Cenizal
d3a9647a04 Remove aria-hidden="true" from TSVB tabs and agg component to make their content screen-reader accessible. (#14345) (#14429) 2017-10-11 09:49:40 -07:00
CJ Cenizal
982eb870b7 Fix prop-types warnings in Jest tests (#14339) (#14428)
* Refine formatting of KuiCodeEditor.
* Update KuiButton and KuiLinkButton tests so aria-label warnings go away.
* Import brace dependencies into KuiCodeEditor example to make console error go away.
* Upgrade react-ace to 5.2.2 to make prop-types warnings go away.
2017-10-11 09:30:39 -07:00
CJ Cenizal
20742822bc [UI Framework] Add KuiContextMenu. (#14183) (#14427)
* Add KuiContextMenu.
- Update KuiPopover to use K7 code.
- Add KuiPanelSimple for use within KuiPopover; it's just the K7 KuiPanel renamed.
- Refactor/rewrite KuiExpression and KuiExpressionButton to depend upon KuiPopover.
- Add K7 shadow mixins and size and z-index vars to global_styling.

* Update Dashboard panel to use KuiContextMenu.
- Fix reloading issue when editing a visualization from within a dashboard.

* Completely refactor KuiContextMenu to enable a single panel.
- Move keyboard navigation logic into KuiContextPanel.
- Set focus on the item which shows the panel we're leaving within KuiContextMenu.
- Remove unnecessary logic from KuiPopoverTitle.
- Replace confusing idToPanelMap and idToPreviousPanelIdMap props with a panels prop.
- Replace panelRef prop with onHeightChange prop.
- Migrate transition state and logic from KuiContextMenu into KuiContextMenuPanel.
- Rename 'current panel' to 'incoming panel' for cohesion with 'outgoing panel.'
- Map panel items to panels up-front.
- Convert maps from state variables into instance variables.
2017-10-11 09:22:58 -07:00
Kim Joar Bekkelund
b1c759b0a2 Only exclude config at root (#14407) (#14408) 2017-10-11 09:22:37 +02:00
CJ Cenizal
0a1cb425b4 [UI Framework] Port KuiFlexItem, KuiFlexGroup, and KuiFlexGrid components from K7. (#14387)
* Port KuiFlexItem, KuiFlexGroup, and KuiFlexGrid components from K7.
* Remove unused breakpoints.
2017-10-10 11:26:38 -07:00