Commit graph

18698 commits

Author SHA1 Message Date
Brandon Kobel 84dfa9b21f
Reverting 22816, upgrading mocha is breaking the custom reporter (#24951) (#24956) 2018-11-01 14:37:51 -07:00
Nathan Reese 50c25cf43f
Unable to filter saved objects by single type (#24950) (#25010)
* display danger toast when savedObjectClient.find fails

* move toast notification out of is mounted check

* add test case for savedObjectsClient.find exeception

* compare query to current activeQuery from state to ignore out of order requests
2018-11-01 15:30:16 -06:00
Larry Gregory e7a3bbacec
[6.x] User management - email and name should be optional (#24842) (#24982)
Backports the following commits to 6.x:
 - User management - email and name should be optional  (#24842)
2018-11-01 16:09:00 -04:00
Jonathan Budzenski f91ac474bf
[config] transform plugin deprecations before checking for unused settings (#21294)
* transform plugin deprecations before checking for unused settings

* async deprecations provider

* refactor

* assign

* async tests
2018-11-01 15:01:33 -05:00
CJ Cenizal 9b11cb3838
Duplicate search strategy errors to correspond to the number of original requests. This fixes a bug in which more than one search request error would result in a fatal error. (#24952) (#24997) 2018-11-01 12:09:31 -07:00
CJ Cenizal 35cea77c81
[Rollups] Disable deletion of started rollup jobs (#24878) (#24995)
* Disable deletion of started rollup jobs.
* Update empty prompt icon.
* Add isUpdating selector and display a spinner instead of the action button when jobs are being updated.
* Localize Navigation component.
* Add noticeable delay of 300ms show spinner displays and doesn't flicker.
2018-11-01 12:09:15 -07:00
Bhavya RM be0f898c58 backport of Adding jsxa11y into eslint rules #23932 2018-11-01 13:32:41 -04:00
Jen Huang 2aee3bb3be
[Rollups] Mark beta in rollup index pattern creation (#24805) (#24957)
* Add beta UI tags to rollup index pattern creation

* Add test, update snapshots

* Address feedback, adjust copy, and localize rollup index pattern creation
2018-11-01 09:05:57 -07:00
pavel06081991 ce355247af
Fix/react intl testing helper functions (#24527) (#24975)
update testing helper functions for react-intl

now we use real intl object passed by IntlProvider via context instead of mocking intl object.
so now data(strings, JSX) passed to FormattedMessage component via values are compiled and
are inserted in the output of FormattedMessage component
2018-11-01 16:59:54 +03:00
James Gowdy 1dd6dbab5f
[ML] Fixing issues when trying to import non-timestamp data (#24894) (#24932)
* [ML] Fixing issues when trying to import non-timestamp data

* making results link time range optional

* small cleanup after fixing merge conflict
2018-11-01 13:50:26 +00:00
Matt Bargar 3ff4f71e94
More accurate info on scripted field querying 2018-11-01 09:14:52 -04:00
Walter Rafelsberger 40a0bcebfd
[ML] Fixes bug with category filtering flag for rare/population charts. (#24901) (#24919)
Fixes a bug where the filtering limit of categories for the rare chart was actually applied to the population chart variant.
2018-11-01 14:11:30 +01:00
Søren Louv-Jansen 994e8c7fee
[APM] Discover links with quoted values and use default 24h as time range (#24900) (#24971)
* [APM] Discover links with quoted values

* Use 24h as default time range
2018-11-01 13:49:54 +01:00
Ryan Keairns 40b6f481f4
add css grid style to prevent calendar bounce (#24913) (#24944) 2018-11-01 07:34:09 -05:00
Bhavya RM d3478eff88
Disabling es lint for 3 of the canvas files (#24902) (#24943)
disabling eslint for Canvas because we are adding in jsx-a11y rules to eslint and adding a missing copyright header
2018-11-01 07:20:44 -04:00
Bhavya RM 41193fc3d9
adding alt tag with empty text to fix jsx-a11y errors (#24922) (#24942) 2018-11-01 07:20:13 -04:00
Leanid Shutau b24ab5226d
[I18n] Sanitize angular directive message before inserting it to DOM (#24830) (#24967)
* [I18n] Sanitize message before inserting it to DOM

* Add tests
2018-11-01 13:54:01 +03:00
Walter Rafelsberger 789d3345b8
[ML] Display a ordinal y axis for low cardinality rare charts. (#24852) (#24910)
Introduces a categorical/ordinal y axis for rare charts with a cardinality of <= 10. This also adds unit tests for the rare/population chart which are the bulk of the PR.
2018-11-01 11:49:27 +01:00
Oliver Gupte 8fcf917124 [APM] Fix divide by 0 bug in percentage duration (#24675) (#24965)
* [APM] Fixes #40165 by consolidating logic where total duration could be 0 and handling it with a fallback value

* [APM] renamed file from .js to .ts and defined a default value for fallback

* [APM] Add type definitions for apm formatters

* [APM] add basic type definition for imported @elastic/numeral module

* [APM] rename getDurationPercent to asPercent

* [APM] Update tests with the renamed formatter function

* [APM] Pr feedback & typescript cleanup

* [APM] fix bucket & chart point type errors

* Fix typescript issue

* [APM] last minute code cleanup
2018-11-01 11:25:53 +01:00
pavel06081991 a0a0b29284
Translations for Dev Tools (#23951) (#24909)
translate dev-tools-console
2018-11-01 11:31:57 +03:00
Jason Rhodes 573b74b6a2
Reorders agents for on prem tutorial (#24872) (#24945) 2018-10-31 21:33:40 -04:00
Jen Huang 4eb49b1cab
[Rollups] Re-enable rollup support (#24888) (#24940)
* Re-enable rollup support extension points

* [Rollups] Hide rollups consumption behind a feature flag in Advanced Settings. (#24698)
2018-10-31 17:52:10 -07:00
Spencer 9a5a053ca4
[dev/build] avoid building packages twice (#24696) (#24954) 2018-10-31 17:07:44 -07:00
James Gowdy 0ff6999e4a
[ML] Fix for delimited data with whitespace in fields (#24899) (#24927)
* [ML] Fix for delimted data with whitespace in fields

* rewriting to use papaparse transform function
2018-10-31 21:43:03 +00:00
liza-mae bb02c8bcd1
Update CI setup for windows to install yarn in global path (#24558) (#24938)
* Update windows ci setup to install yarn global

* Keep formatting consistent

* Update yarn installation for linux

* Updating paths and removing cache folder
2018-10-31 14:47:08 -06:00
Bill McConaghy 64ef1a3c39
console: add ignore_failure to ingest common auto complete (#24915) (#24934) 2018-10-31 16:42:31 -04:00
Oliver Gupte 5f94cea820
[APM] fixes #23808 by adding docs links for user/tags transaction apis for the java agent (#24869) (#24917) 2018-10-31 13:16:41 -07:00
Jason Rhodes f2d988af1b
[6.x] Design clean-up for 6.5, Part Deux (#24862) (#24883)
* Design clean-up for 6.5, Part Deux (#24862)

* Fixes active tab state

* Removes beta labels from ML and search bar

* Reverts visual regression with right-to-left timeline fix

* Creates space for agent marks beneath tick marks

* Fixes ordering problem with timeline transaction icons

* Updates string 0 to be an integer instead for CSS bottom value

* Fixes APM snapshot for CSS value (#24898)
2018-10-31 16:13:19 -04:00
Josh Dover f5ebb5c4d4
Fix reporting typo in 6.0 migration doc (#24848) 2018-10-31 14:57:32 -05:00
Felix Stürmer ed9843a0af
[6.x] [InfraOps] Preserve time values when navigating from the waffle map to the logs and details pages (#24666) (#24911)
Backports the following commits to 6.x:
 - [InfraOps] Preserve time values when navigating from the waffle map to the logs and details pages  (#24666)
2018-10-31 20:28:46 +01:00
Lisa Cawley 8f9e176dd2 [DOCS] Updates monitoring diagram (#24851) 2018-10-31 09:51:22 -07:00
Tyler Smalley fc213d9304
Allows build to be ran on Windows (#24374) (#24885)
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
2018-10-31 09:49:43 -07:00
Oliver Gupte 8f321ed415
[APM] fixes #24563 by de-duping the column field id 'sample' (#24690) (#24876)
* [APM] fixes #24563 by replacing de-duping the twice-used column field id

* [APM] fixed issue with service column not sorting in ManagedTable

* [APM] make render field on ITableColumn optional and allowing it to use EUI's default value
2018-10-31 08:38:30 -07:00
Walter Rafelsberger 5e60b2ce77
[ML] Set new index pattern as default one if no default index pattern exists yet. (#24337) (#24895)
This replicates the behaviour of the management UI: If there's no default index pattern, the one created via file visualizer's import will be set as the default index pattern.
2018-10-31 16:03:42 +01:00
Matt Bargar fd039cf227
Fix Wildcard Queries Against The Default Field (#24778) (#24860)
When querying against the default field (i.e. querying without specifying a field) we weren't correctly handling values with wildcards in them.
2018-10-31 09:35:35 -04:00
Chris Roberson fe99bc155c
[Monitoring] Use the cluster name from metadata if it exists (#24495) (#24766)
* Use the cluster name from metadata if it exists

* PR comments
2018-10-31 09:01:24 -04:00
Stacey Gammon eda918a61e
Check for toast before waiting for page to finish loading to avoid mi… (#24424) (#24857)
* Check for toast before waiting for page to finish loading to avoid missing the toast by the time the page finishes

* turn test back on
2018-10-31 08:30:24 -04:00
Søren Louv-Jansen cd13ccb805
[APM] Hoist loading of waterfall and flatten it (#24651) (#24893)
* [APM] Hoist loading of waterfall and flatten it

Remove unused test

Convert to typescript

* Address feedback

* Make `totalDuration` optional

* Renamed rootTransaction to traceRoot

* [APM] Only show relevant service legends

* Adds services label to the service legend

* [APM] Clock skew fix

Only skew child spans from the same service

Take parent skew into account when finding diff

# Conflicts:
#	x-pack/plugins/apm/public/components/app/TransactionDetails/Transaction/WaterfallContainer/Waterfall/waterfall_helpers/__snapshots__/waterfall_helpers.test.ts.snap
#	x-pack/plugins/apm/public/components/app/TransactionDetails/Transaction/WaterfallContainer/Waterfall/waterfall_helpers/waterfall_helpers.test.ts
#	x-pack/plugins/apm/public/components/app/TransactionDetails/Transaction/WaterfallContainer/Waterfall/waterfall_helpers/waterfall_helpers.ts

* Use switch statement
2018-10-31 13:17:32 +01:00
Sébastien Loix b63b53de6d
refactor: Convert utils/collection to Typescript (#23992) (#24889) 2018-10-31 11:24:25 +01:00
pavel06081991 eb1009c3d4
Vega translations (#23677) (#24890)
add vega translations
2018-10-31 12:29:16 +03:00
pavel06081991 f86c62af09
add i18n angular module as dependency for nav bar directive (#24754) (#24847) 2018-10-31 12:28:35 +03:00
pavel06081991 f941d4ce29
Feature/translate new nav bar breadcrumb state (#24327) (#24846)
Translate new_nav_bar breadcrumbState
2018-10-31 10:06:17 +03:00
Tyler Smalley fe4e35e50a
Removes defunct function test runner Grunt task (#24673) (#24855)
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
2018-10-30 16:27:35 -07:00
CJ Cenizal 4ce8f35858
[Rollups] Fix i18n bugs (#23848) (#24868)
* Internationalize job details tabs and wrap instances in EuiErrorBoundary to visually localize the error.
* Localize no default index pattern message.
* Localize es interval errors.
* Localize job action menu and confirm delete modal.
* Remove unnecessary use of injectI18n from tabs.
* Localize job status.
* Localize steps.
* Remove template literals from FormattedMessages.
2018-10-30 16:21:11 -07:00
Marco Vettorello eec63051e4
Add a console.error to visualize errors (#24581) (#24866) 2018-10-31 00:20:47 +01:00
CJ Cenizal 4adaa0c1e3
Re-initialize Rollup Management userHasLeftApp state to fix bug with clearing URLjob deep-link when detail panel is closed. (#24841) (#24856) 2018-10-30 14:11:33 -07:00
Gil Raphaelli 9cc42d61c6
update apm-server start instructions for deb/rpm/windows (#24104) (#24853)
* update apm-server start instructions for deb/rpm

* update apm-server start instructions for windows
2018-10-30 15:57:53 -04:00
Chris Roberson efeca311c5
Add onBrush functionality to APM monitoring ui graphs (#24840) (#24849) 2018-10-30 15:02:22 -04:00
Brandon Kobel c3656ce91f
[6.x] Reporting Cookies #24752 (#24792)
* Revert "Reporting cookies (#24177) (#24222)"

This reverts commit 95997528c7.

* Take 2

* Fixing session test
2018-10-30 11:38:40 -07:00
Spencer 1f59c294da
[optimizer] ignore node_modules anywhere in the x-pack directory (#24797) (#24810)
I noticed the following message while watching the build output:

```
00:33:19.131    │ info [kibana] > /var/lib/jenkins/workspace/elastic+kibana+pull-request+multijob-x-pack/install/kibana/bin/kibana --optimize.useBundleCache=true --env.name=development --logging.json=false --server.port=5620 --optimize.watchPort=5630 --optimize.watchPrebuild=true --status.allowAnonymous=true --elasticsearch.url=http://elastic:changeme@localhost:9220 --elasticsearch.username=elastic --elasticsearch.password=changeme --server.uuid=5b2de169-2785-441b-ae8c-186a1936b17d --xpack.xpack_main.telemetry.enabled=false --xpack.security.encryptionKey="wuGNaIhoMpk5sO4UBxgr3NyW1sFcLgIf" --optimize.enabled=true --xpack.reporting.capture.browser.type=chromium --xpack.spaces.enabled=false
00:33:38.533    │ proc [kibana]   log   [23:20:25.923] [info][optimize] Optimizing and caching bundles for ml, stateSessionStorageRedirect, status_page, timelion, graph, monitoring, login, logout, dashboardViewer, apm, canvas, infra and kibana. This may take a few minutes
00:34:12.650    │ proc [kibana] [BABEL] Note: The code generator has deoptimised the styling of "/var/lib/jenkins/workspace/elastic+kibana+pull-request+multijob-x-pack/install/kibana/node_modules/x-pack/plugins/infra/node_modules/lodash/lodash.js" as it exceeds the max of "500KB".
00:36:11.346    │ proc [kibana]   log   [23:22:58.721] [info][optimize] Optimization of bundles for ml, stateSessionStorageRedirect, status_page, timelion, graph, monitoring, login, logout, dashboardViewer, apm, canvas, infra and kibana complete in 152.79 seconds
```

The "code generator has deoptimised" line specifically raised a red flag as babel shouldn't be running on node_modules. We have admittedly weak regular expressions in two places to enforce this. The first is in 49071132c3/src/setup_node_env/babel_register/register.js (L42), which I verified matched `node_modules` directories within the `node_modules/x-pack` directory, but the other is 49071132c3/src/optimize/base_optimizer.js (L152-L154) which does not. It only excludes files from babel in webpack if they are within a node_modules directory that is a direct child of `node_modules/xpack`, but with InfraOps and Canvas we now have node_module directories at `plugins/*/node_modules`.

This should probably be fixed by preventing plugins from installing their own node_modules, but since that would involve upgrading/moving plugins between major versions of dependencies like lodash that's somewhat impractical from where I stand, so instead I've just updated the webpack module rule to exclude any `node_modules/xpack/**/node_modules` directory.
2018-10-30 11:16:05 -07:00