Commit graph

40972 commits

Author SHA1 Message Date
Stacey Gammon 87a5b22626
API DOCS Step 3/3 (#92929)
* update api_docs from gitignore

* api doc files

* Update api_welcome.mdx

* Pretty print json

* Add new lines and extra frontmatter to warn github viewers

* update api_docs with new lines and frontmatter

* Remove all apis tagged @internal and add tests

* Update docs with all internal APIs removed

* fix typescript error in test fixtures

* Update core.json

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-03-02 22:02:17 -05:00
Tiago Costa a36b64e7a8
chore(NA): look for bazel packages on npm_module folder during distributable build (#93262) 2021-03-03 02:09:36 +00:00
Nathan Reese bd9b349dfd
rename advanced setting ml:fileDataVisualizerMaxFileSize to fileUpload:maxFileSize and increase max geojson upload size to 1GB (#92620)
* rename ml:fileDataVisualizerMaxFileSize to fileUppload:maxFileSize

* add saved object migration

* file preview

* importing status

* remove console statement

* import complete view

* fix geojson_importer test

* tslint

* i18n fixes

* cleanup

* update documenation for advanced setting rename

* advanced settings usage_collection

* remove ml:fileDataVisualizerMaxFileSize from schemas and types

* add copy buttons for import response and fix geojson upload functional tests

* tslint

* remove clipboard-read check

* return early if env does not support reading from clipboard

* fix reporting tests

* review feedback

* update GeoJsonFileSource to support showing results trimmed icon and tooltip

* add fileUpload to useMlKibana context and replace dependencyCache with useMlKibana

* tslint

* review feedback

* lower case file name

* default to selecting geo_shape when file contains both points and shapes

* fix wizard onError callback to not advance to next step

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-03-02 19:07:03 -07:00
Spencer 57a860ddb0
[kbn/optimizer] allow customizing the limits path from the script (#93153)
Co-authored-by: spalger <spalger@users.noreply.github.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-03-02 18:29:54 -07:00
ymao1 fda67adb9f
[Alerting][Docs] Adding template for documenting alert and action types (#92830)
* Alert type template

* Action type template

* Cleanup

* Cleanup

* Removing callout list

* Cleanup

* Apply suggestions from code review

Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>

* Adding title to actions page

* PR fixes

* PR fixes

* PR fixes

* PR fixes

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>
2021-03-02 18:08:58 -05:00
Spencer 3b6643144d
[jenkins] convert baseline capture job to use tasks (#93288)
Co-authored-by: spalger <spalger@users.noreply.github.com>
2021-03-02 18:03:00 -05:00
Bhavya RM 4218813464
removing the linked issue in comments from PR (#93303) 2021-03-02 17:21:28 -05:00
Tiago Costa 9d1df3f6f4
chore(NA): do not include fs within a storybook build (#93294) 2021-03-02 16:56:02 -05:00
Aaron Caldwell 21338080db
[Maps] Update Map extent queries to use bounding box logic for both point and shape queries (#93156) 2021-03-02 16:48:02 -05:00
Ece Özalp 819cb485dc
Add searchDuration to EQL and Threshold rules (#93149)
Closes #82861.
2021-03-02 16:47:09 -05:00
Thomas Neirynck 33010bebf9
[Maps] Abort ES-search when tile request is cancelled (#92069) 2021-03-02 16:46:09 -05:00
Yuliia Naumenko a102fa9a70
[Alerting][Docs] Moved alerting links from hard-coded to documentation link service. (#92953)
* [Alerting][Docs] Moved alerting links from hard-coded to documentation link service

* fixed due to comments

* Update x-pack/plugins/triggers_actions_ui/public/application/components/health_check.tsx

Co-authored-by: Mike Côté <mikecote@users.noreply.github.com>

* fixed jest tests

* fixed due to comments

Co-authored-by: Mike Côté <mikecote@users.noreply.github.com>
2021-03-02 13:43:10 -08:00
Melissa Alvarez 36523bb3a1
ensure regex works for filter with optional multiple spaces (#93071) 2021-03-02 15:40:10 -05:00
ymao1 319ad55cd7
Different screenshot (#92970) 2021-03-02 15:24:06 -05:00
Zacqary Adam Xeper 6be9adac0d
[Alerts] Add spaces as optional dep to triggers_actions_ui (#93267) 2021-03-02 14:08:55 -06:00
Zacqary Adam Xeper 1b8d20c1c1
[Fleet] Fix default integration name when adding 10+ names (#93278) 2021-03-02 15:08:03 -05:00
Lukas Olson aa6591afe9
Update KQL field autocompletion to suggest fields that match search (#92559)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-03-02 13:07:19 -07:00
renovate[bot] 9e354bdf28
Update dependency @elastic/charts to v25.1.0 (master) (#93151)
* Update dependency @elastic/charts to v25.1.0

Co-authored-by: Renovate Bot <bot@renovateapp.com>
2021-03-02 13:54:45 -06:00
Gabriel Landau 3c4595de5e
[7.12][Security] Shellcode telemetry update for schema adjustment (#93143)
* Shellcode telemetry update for schema adjustment

* Lint

* Lint

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-03-02 14:44:42 -05:00
Constance fd3b3eb8cd
[App Search] Refactor AppLogic to initialize data via props rather than action (#92841)
* [Misc cleanup] Move Access type to common

- it was being duplicated in server/check_access and InitialAppData

+ add mock access data to DEFAULT_INITIAL_APP_DATA
+ update server/ tests to account for access in DEFAULT_INITIAL_APP_DATA

* Update AppSearchConfigured to pass props to AppLogic vs calling initializeAppData

+ update tests to rerender a wrapper rather than doing {...DEFAULT_INITIAL_APP_DATA} repeatedly

* Update AppLogic to set values from props rather than a listener

- main goal of this PR is to prevent the flash of state between mount and initializeX being called

- note: I recommend turning off whitespace changes in the test file

* Update AppLogic typing so that app data is always expected

- which it should be in any case in a production environment

- note: I could have changed InitialAppData to remove the ? optional notation, but decided on this route instead since InitialAppData affects more than just App Search (e.g. server, WS), and I didn't want this to have potential far-reaching side effects

* Update type scenarios where AppLogic values were previously thought potentially undefined

- which is mostly just configuredLimits it looks like

* [PR feedback] Type name
2021-03-02 11:25:01 -08:00
Oliver Gupte 3f5473ef7d
[APM] Fixes duplicate ML job creation for existing environments (#85023) (#93098)
* [APM] Fixes duplicate ML job creation for existing environments (#85023)

* Removes commented out test code.

* Adds API integration tests

* clean up code for readability
2021-03-02 11:20:30 -08:00
Stacey Gammon 8bcec14727
update plugin list (#93259) 2021-03-02 14:00:32 -05:00
Dmitry d30be3f100
[code coverage] run more functional tests (#93249) 2021-03-02 21:56:42 +03:00
Christiane (Tina) Heiligers d230720e2d
[Usage Collection] Supports field descriptions as meta data (#92701)
Co-authored-by: Alejandro Fernández Haro <afharo@gmail.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-03-02 13:34:13 -05:00
Luke Elmers 81348b8693
[core.logging] Fix calculating payload bytes for arrays and zlib streams. (#92100) 2021-03-02 13:21:39 -05:00
ymao1 3dd3297371
[Actions][Docs] Moving subaction and subaction params back to README (#92878)
* Moving subaction and subaction params back to README

* Apply suggestions from code review

Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>

* PR fixes

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>
2021-03-02 13:09:53 -05:00
Clint Andrew Hall 84dc217aff
Convert Canvas docs to MDX for use in Elastic Docs (#91969)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-03-02 12:44:18 -05:00
Tyler Smalley 5521fe400f
[Bazel] More resilient Workspace Status (#93244)
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
2021-03-02 12:30:03 -05:00
Matthias Wilhelm b2b16d6aaf
[Discover] Change icon of saved search in open search panel and embeddable selection (#93001) 2021-03-02 18:23:12 +01:00
Scotty Bollinger 5788a6bd78
[Workplace Search] Role Mappings to Kibana (#93123)
* Add routes for role mapings

* Initial copy/paste

* Update RoleMappingsRouter

- Update all paths
- Change router to use children instead of render props
- Remove legacy app chrome

* Update RoleMappings

- Update all paths
- Use global flash messages

* Update RoleMapping

- Update all paths
- Use global flash messages
- Add types to fix errors
- Use React Router Hooks instead of legacy withRouter HOC

* Fix path in index and add route helper

* Update paths in RoleMappingsLogic

* Remove history in favor of KibanaLogic.navigateToUrl

* Add Role type

* Remove ID prop

This is not needed because the ID is actually passed in the URL itself and is not a requirement in the body of the request

* Replace contextual flash messages with global

It appeared that the server sometimes sent flash messages with the API response, but I checked the Rails server code and there is no `flashMessages` sent back from the server so I am omitting that from the `RoleMappingsServerDetails` interface as well.

* Replace Rails http with kibana http

* Fix route path

* Add route and update global navigation

* Add breadcrumb/page title

* Update flash messages in RoleMapping

I did this for RoleMappings but forgot this one

* Use explicit AttributeName type instead of string

* Add i18n

* Fix type issue

Because the shared role mapping components work for both App Search and Workplace Search, the more generic string is used here because App Search has different role names.

* Add tests for components and router

* Add optional to interface

In the case of a new role mapping, the server is called at the ‘/new’ route and the server responds without a roleMapping prop, as it has not yet been created.

* Add tests for RoleMappingsLogic

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-03-02 11:22:20 -06:00
John Schulz 1702cf98f0
[Fleet] Use type-only imports where possible (#92979)
## Summary

Use [type-only `import`](https://www.typescriptlang.org/docs/handbook/release-notes/typescript-3-8.html#type-only-imports-and-export) to differentiate between runtime values and (erasable) TS types.

<img width="1499" alt="Screen Shot 2021-02-27 at 6 34 46 PM" src="https://user-images.githubusercontent.com/57655/109403323-84e32c80-792a-11eb-94b7-854d0e5c3e99.png">

Allows Babel and `tsc` to make some optimizations since it can be sure what can be erased.

It can also be helpful in situations like below which highlights that even though `KibanaAssetType` and `KibanaSavedObjectType` are named a certain way and from `common/types`, they are JS values _not_ TS types. They are `enum`s which means they are JS objects at runtime; not eliminated at runtime.

d92a1a08d8/x-pack/plugins/fleet/common/types/models/epm.ts (L41-L63)
2021-03-02 12:10:39 -05:00
Marco Liberati 92134cb88e
[Lens] Set pie chart slices sorted clockwise (#92617)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-03-02 17:34:46 +01:00
Josh Dover 9fd28b67c5
Remove ms label from CPU load on status page (#92836)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-03-02 11:20:50 -05:00
Byron Hulcher 3d065739ea
[App Search] Migrate Create Meta Engine View (#92127)
* New empty MetaEngineCreation component

* Added MetaEngineCreation to AppSearchConfigured router

* Empty MetaEngineCreationLogic

* Add rawName value and setRawName action to MetaEngineCreationLogic

* Add indexedEngineNames value and setIndexedEngineNames action to MEtaEngineCreationLogic

* Add selectedIndexedEngineNames value and setIndexedEngineNames action to MetaEngineCreationLogic

* Add description to MetaEngineCreation

* Add name selector to MetaEngineCreationLogic

* Added MetaEngineCreationNameInput to MetaEngineCreation

* Add fetchIndexedEngineNames listener to MetaEngineCreationLogic

* Call fetchIndexedEngineNames when MetaEngineCreation first renders

* Add EuiComboBox for selectedEngineNames to MetaEngineCreation

* WIP Add meta engine source engine limit warning to MetaEngineCreation

* Add submitEngine listener to MetaEngineCreationLogic

* Add onEngineCreationSuccess to MetaEngineCreationLogic

* Fixing tests for MetaEngineCreationLogic

* Fix tests for MetaEngineCreation

* Add Create a meta engine button to EnginesOverview

* Use DEFAULT_META for fetching indexed engine names in MetaEngineCreationLogic

* Copy fixes

* Updating POST /api/engines tests

* Add noItemsMessage prop to EnginesTable

* Add empty prompt to Meta Engines table in EnginesOverview

* Apply suggestions from code review

Co-authored-by: Constance <constancecchen@users.noreply.github.com>

* Better form functionality in MetaEngineCreation

* Fix errors from github

* More MetaEngineCreation coverage

* Meta MetaEngineCreationLogic coverage

* Update x-pack/plugins/enterprise_search/public/applications/app_search/components/meta_engine_creation/meta_engine_creation_logic.ts

Co-authored-by: Constance <constancecchen@users.noreply.github.com>

* Update x-pack/plugins/enterprise_search/public/applications/app_search/components/meta_engine_creation/meta_engine_creation_logic.ts

Co-authored-by: Constance <constancecchen@users.noreply.github.com>

* Update x-pack/plugins/enterprise_search/public/applications/app_search/components/engines/constants.ts

Co-authored-by: Constance <constancecchen@users.noreply.github.com>

Co-authored-by: Constance <constancecchen@users.noreply.github.com>
2021-03-02 08:20:27 -08:00
Devon Thomson 41b81a1011
[Time to Visualize] Disable Visualize URL Tracker When Linked to OriginatingApp (#92917)
* changed url tracker for visualize to not save when linked to originating app
2021-03-02 11:03:27 -05:00
Jean-Louis Leysens cce6861b89
[ILM] Allow multiple searchable snapshot actions (#92789)
* remove logic that disables SS action in cold if no rollover and always show replicas field

* update test coverage to be consistent with new form behaviour and expand hot phase without rollover test

* only licensing can disable searchable snapshot field

* clean up i18n

* remove ss field callout

* update error reporting logic to include causes chain, also update UI to show causes

* updated searchable snapshot field in hot phase callout

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-03-02 16:00:11 +01:00
Larry Gregory 5cc480a375
Improve consistency for display of management items (#92694)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-03-02 09:54:43 -05:00
Tiago Costa b33ea364af
skip flaky suite (#93152) 2021-03-02 14:34:27 +00:00
Tiago Costa a8adbbf800
skip flaky suite (#93152) 2021-03-02 14:29:48 +00:00
Yulia Čech bf9517ed7b
[ILM] Refactor edit_policy client integration tests into separate feature files (#92826)
* Refactor edit_policy client integration tests into separate feature files

* Fixed merge conflicts with master

* Updated rollover tests to match master branch code

* Split reactive_form into smaller files

* Renamed flyout tests file
2021-03-02 15:28:12 +01:00
Stacey Gammon 3d54379da6
Add developer documentation about the building blocks we offer plugin developers (#92743)
* Create building_blocks.mdx

* Update dev_docs/building_blocks.mdx

Co-authored-by: Brandon Kobel <brandon.kobel@gmail.com>

* Update dev_docs/building_blocks.mdx

Co-authored-by: Brandon Kobel <brandon.kobel@gmail.com>

* Update dev_docs/building_blocks.mdx

Co-authored-by: Brandon Kobel <brandon.kobel@gmail.com>

* add description to Lens embeddable

Co-authored-by: Brandon Kobel <brandon.kobel@gmail.com>
Co-authored-by: Joe Reuter <johannes.reuter@elastic.co>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-03-02 09:21:28 -05:00
Angela Chuang 356d4609e8
[Security Solution] Case ui enhancement (#91863)
* ui enhancement

* fix actions

* unit test

* update row actions

* add case status all

* update find status

* fix type

* remove all case count from dropdown

* fix type error

* fix unit test

* disable bulk actions on status all

* clean up

* fix types

* fix cypress tests

* review

* review

* update status is only available for individual cases

* update available actions on status all

* fix unit test

* remove lodash get

* rename status all

* omit status if it is set to all

* do not sent status if itis set to all

* Remove all status from the backend

* Hide actions on all status

* fix unit test

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Christos Nasikas <christos.nasikas@elastic.co>
2021-03-02 09:13:55 -05:00
Devin W. Hurley 1bdf0022ee
[Security Solution] [Detections] Updates warning message when no indices match provided index patterns (#93094)
* updates warning messages and modifies warning message when endpoint security rule is missing index pattern

* fix integration test text
2021-03-02 09:10:59 -05:00
Sonja Krause-Harder ca25e5162c
Collect agent telemetry even when fleet server is disabled. (#93198) 2021-03-02 15:09:36 +01:00
Marco Liberati 547600b9b1
[Lens] Fix runtime validation error message (#93195) 2021-03-02 14:51:54 +01:00
Marta Bondyra 4077718a2a
[Lens] Remove warning about ordinal x-domain (#93049) 2021-03-02 14:49:32 +01:00
Andrew Goldstein 5a09a296d1
[Security Solution] Fixes the Customize Event Renderers modal by removing the EuiOverlayMask (#93150)
* ## [Security Solution] Fixes the Customize Event Renderers modal by removing the EuiOverlayMask

Fixes [this issue](https://github.com/elastic/kibana/issues/92798), introduced when [the EUI modal implementation changed](https://github.com/elastic/eui/pull/4480), such that it's no longer necessary to wrap modals in an `EuiOverlayMask`. The mask is now built-in to `EuiModal`.

The change above became effective throughout Kibana when it was upgraded to use a newer version of EUI via [this commit on Feb 16](8126488021 (diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519)).

This PR resolves the issue by removing the `EuiOverlayMask` around the `Customize Event Renderers modal`, shown in the `After` screenshot below:

### Before

![before](https://user-images.githubusercontent.com/59917825/109154007-b2e23880-7793-11eb-83bb-4774df77c5d6.png)

### After

![after](https://user-images.githubusercontent.com/4459398/109561954-0c4fad80-7a9b-11eb-9283-51d50ec8ea26.png)

### Desk testing

Desk-tested on a 16" 2019 MBP, and on the desktop with the following browser versions:

- Chrome `88.0.4324.192`
- Firefox `86.0`
- Safari `14.0.3`

* - force precommit git hooks to run

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-03-02 08:45:47 -05:00
Joe Portner 6ecffcc57c
Cleanup Security plugin imports (#93056) 2021-03-02 08:42:01 -05:00
Michael Olorunnisola 3c4a3b833e
[Security Solution] - Bug fixes (#92294)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-03-02 08:37:30 -05:00
Jason Stoltzfus 16a3780021
Updated doc links (#92968) 2021-03-02 07:39:04 -05:00