Commit graph

35070 commits

Author SHA1 Message Date
Spencer 8834ca3e9a
[src/dev/build] typescript-ify and convert tests to jest (#72525)
Co-authored-by: spalger <spalger@users.noreply.github.com>
2020-07-23 10:58:04 -07:00
Jen Huang 52a1b05623
Change copy to Agent ID (#72953) 2020-07-23 10:47:53 -07:00
Jen Huang e285beb148
[Ingest Manager] Match create agent config flyout with designs (#72973)
* Update create agent config flyout and form

* Remove cross icon from all flyout Close buttons

* Make tooltip icons in overview panels subdued

* Add tooltips to agent monitoring options
2020-07-23 10:47:40 -07:00
Nathan Reese cb48e6e98e
[maps] fix un-hiding layer not syncing data (#73039)
* [maps] fix un-hiding layer not syncing data

* revert syncDataForLayer to syncDataForLayerId

* remove unused method
2020-07-23 11:14:54 -06:00
Michael Olorunnisola 4b7c16c2ba
[Security Solution] [Resolver] Select origin node on load (#72946) 2020-07-23 13:04:11 -04:00
Nathan Reese e1a3dccf03
[Maps] fix cloned clustered documents layer returns error (#72975)
* [Maps] fix cloned clustered documents layer returns error

* tslint
2020-07-23 11:01:59 -06:00
Ryland Herrick 7d51b97806
[Security Solution][Detections] Fix display of exceptions after creation on Rule Details (#72951)
* Refresh rule details when exception list modal modifies the rule

This addresses a bug where, when opening the exceptions modal for the first
time and creating exceptions, the details page does not reflect these
created exceptions until a full refresh.

This is due to the hook performing the refresh being dependent on the
rule's exceptions_list attribute, which is not populated until after
opening the modal. Because the UI is not informed of the rule update, it
did not know to refresh the rule.

This adds the machinery necessary to make the above work. It:

* adds a new hook for fetching/refreshing a rule
* Adds an onRuleChange callback to both the ExceptionsViewer and the
mutating AddExceptionModal
* passes the refresh function in as the onRuleChange callback

There's currently a gross intermediate state here where the loading screen is
displayed while the rule refreshes in the background; I'll be fixing
that shortly.

* Do not show loading/blank state while refreshing rule

On Rule Details, when the Add Exceptions modal creates the rule's
exception list, we refresh quietly in the background by setting our rule
from null -> ruleA -> ruleB instead of null -> ruleA -> null -> ruleB.

This also simplifies the loading logic in a few places now that we're
using our new rule: we mainly care whether or not our rule is populated.

* Display toast error if rule fetch fails

This should now have feature parity with useRule, while additionally
providing a function to refresh the rule.

* Refactor tests to leverage existing helpers

* Add return type to our callback function

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-07-23 12:01:18 -05:00
spalger 52f3cc311d fix skip of flaky test (#72994) 2020-07-23 09:51:40 -07:00
Sandra Gonzales 2932b169a2
[Ingest Manager] Integration test install/uninstall a package (#72957)
* integration test for initial installation of package

* add all services to integration config

* rename files, test removing package

* remove import from merge conflict

* rename es_assets to all_assets package

* move install package to before clause and update test descriptions

* fix typo

* update ilm policy name

* use skipIfNoDockerRegistry helper
2020-07-23 11:45:38 -05:00
Quynh Nguyen 6d480c7f22
[ML] Add API integration tests for /filters and /calendars (#72564)
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-07-23 11:38:29 -05:00
Devon Thomson 0103cd3424
[Fix] Lose OriginatingApp Connection on Save As (#72725)
Reset originatingApp in lens and visualize when return to dashboard on saving is false
2020-07-23 12:21:31 -04:00
Spencer 367bece396
[kbn/test/failed_test_reporter] handle cypress junit better (#72968)
Co-authored-by: spalger <spalger@users.noreply.github.com>
2020-07-23 08:49:24 -07:00
Christos Nasikas 6b9a598f73
[Security Solution][Case] Fix long tag display (#72819) 2020-07-23 18:43:54 +03:00
Yuliia Naumenko badbfa0eb5
Added more {{context}} fields for Index Threshold alert type (including requested 'threshold' field). Extended action variables UX with tooltip containing variable description. (#71141)
* Added more {{context}} fields for Index Threshold alert type (including requested 'threshold' field). Extended action variables UX with tooltip containing variable description.

* Fixed type checks and failing tests

* fixed type check

* Splited params variables

* Fixed tests and type checks

* Fixed styles

* Fixed type check

* fixed styles

* fixed missing type

* Fixed due to comments

* fixed variables description

* fixed type check

* Fixed due to comments

* fixed typecheck

* Merge remote-tracking branch upstream/master into alerting-additional-context-fields

* fixed type checks and tests

* fixed tests
2020-07-23 08:39:51 -07:00
James Gowdy 18df677da7
[ML] Fixing file import, module creation and results viewing permission checks (#72825)
* [ML] Fixing file import and module creation permission checks

* correcting searches on results index

* fixing test

* removing unnecessary index

* updating apidoc

* fixing test

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-07-23 16:11:15 +01:00
Daniil Suleiman 2d9eaf013b
Fix view saved search through a visualization (#73040) 2020-07-23 18:00:52 +03:00
Tyler Smalley 15ccdc36ca [test] Skips flaky uptime test
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
2020-07-23 07:50:30 -07:00
Matthew Kime 2cf37a5326
Don't skip index pattern creation test (#73032) 2020-07-23 09:34:56 -05:00
Stratoula Kalafateli 1ee3cdb03d
[Functional Tests] Unskip tsvb timeseries test (#73011)
* [Functional Tests] Unskip tsvb timeseries test

* Add retry to dropdown selection when element is not found to headless mode
2020-07-23 17:00:16 +03:00
Madison Caldwell 7280b69e99
[Security Solution][Exceptions] Preserve rule exceptions when updating rule (#72977)
* Send exceptions_list with rule edit

* Handle exceptions list checkbox

* whoops

* Don't lose data when associating with endpoint list

* syntax

* Filter out the endpoint lists when disassociating

* Add tests

* Refactor per PR suggestions

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-07-23 09:54:08 -04:00
Vadim Dalecky 304445f007
fix: 🐛 don't show actions if Discover app is disabled (#73017)
* fix: 🐛 don't show actions if Discover app is disabled

* style: collapse ifs
2020-07-23 15:27:06 +02:00
Pierre Gayvallet 49782f9348
delete legacy apm_oss plugin (#73016) 2020-07-23 14:48:13 +02:00
Nicolas Chaulet 06f142d586
[Ingest Manager] Fix config rollout move to limit concurrent config change instead of config per second (#72931) 2020-07-23 08:06:16 -04:00
Cauê Marcondes 9a22b95b97
[APM] Custom link: Removing async check for callAPMApi (#73004)
* removing async check for callAPMApi

* removing async check for callAPMApi
2020-07-23 13:46:09 +02:00
Kevin Logan 5f6b9353e7
[SECURITY_SOLUTION] update Elastic Endpoint text in rules (#72613) 2020-07-23 07:38:27 -04:00
Vadim Dalecky 8f8cba5013
fix: 🐛 don't show action in dashboard_only mode (#73010) 2020-07-23 13:36:52 +02:00
Uladzislau Lasitsa cf3aa2c641
Migrated karma tests to jest (#72649) 2020-07-23 14:03:07 +03:00
Pierre Gayvallet 2178a14519
Migrate status page app to core (#72017)
* move http.anonymousPaths.register('/status'); logic into core, remove status_page plugin

* move status_page to core & migrate lib

* migrate the status_app components to TS/KP APIs

* update rendering snapshots

* use import type syntax

* moves `/status` server-side route to core

* fix route registration

* update generated file

* change statusPage i18n prefix

* (temporary) try to restore legacy plugin to check behavior

* add some FTR tests

* do not import whole lodash

* update snapshots

* review comments

* improve / clean component unit tests

* change url for legacy status app

* set status app as chromeless

* fix FTR test due to chromeless app

* fix typings

* add unit test for CoreApp /status registration
2020-07-23 12:15:03 +02:00
Alexey Antonov b2a473d6fe
Failing test: Jest Tests.src/plugins/vis_type_vega/public (#71834)
* Failing test: Jest Tests.src/plugins/vis_type_vega/public

* remove workaround for vega height bug

Related to #31461

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-07-23 12:38:21 +03:00
Marco Liberati 6befacfc19
Fix Firefox TSVB flaky test with switch index patterns (#72882) 2020-07-23 10:40:21 +02:00
James Gowdy d4a362018a
[ML] Fixing link to index management from file data visualizer (#72863) 2020-07-23 09:23:19 +01:00
Vadim Dalecky 4b359f4420
test: 💍 add test for sub-expression variables (#71644)
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-07-23 09:56:45 +02:00
Joe Reuter 5cdd0801b2
fix bug (#72809) 2020-07-23 09:35:36 +02:00
Jonathan Budzenski 119cb10993
[keystore] use get_keystore in server cli (#72954)
* [keystore] use get_keystore in server cli

* temporily add docker build so this can be retested in original env

* Revert "temporily add docker build so this can be retested in original env"

This reverts commit 25f401aa2e.
2020-07-23 02:24:22 -05:00
Sonja Krause-Harder 8b4c4c0abc
Show step number instead of incomplete step. (#72866) 2020-07-23 08:45:01 +02:00
Pedro Jaramillo ac8cdf34ba
Fix bug where user can't add an exception when "close alert" is checked (#72919)
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-07-22 20:22:51 -04:00
Chris Roberson bacf9f2aba
[Monitoring] Fix issues displaying alerts (#72891)
* Fix issues displaying alerts

* Fix type issues

* More support for multiple alerts

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-07-22 19:28:00 -04:00
John Schulz 1343643696
[Ingest Manager] Add more Fleet concurrency tests #71744 (#72338)
* Refactor to make more testable. Add more tests.

* Remove ts-ignores. Add comment re: testing limitation

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-07-22 18:24:04 -04:00
Yara Tercero f7a1679395
[Security Solution][Exceptions] - Update UI exceptions builder nested logic (#72490)
## Summary

This PR is meant to update the exception builder logic to handle nested fields. If you're unfamiliar with nested fields, you can read up more on it [here](https://www.elastic.co/guide/en/elasticsearch/reference/current/nested.html) and [here](https://github.com/elastic/kibana/issues/44554). It also does a bit of cleanup, so though it may look like a lot of changes, parts of it were just moving some things around.
2020-07-22 18:21:40 -04:00
spalger 1f155dea99 disable renovate masterIssue 2020-07-22 14:43:12 -07:00
Melissa Alvarez 1889c68c6b
[ML] API integration tests for UPDATE data frame analytics endpoint (#72710)
* add df analytics update api integration tests

* remove unnecessary commented code

* remove unused constant

* fetch job to check it was updated correctly
2020-07-22 16:50:18 -04:00
Justin Kambic 24ebe0a189
[Uptime] Fix accessibility issue in Uptime app nav links (#72926)
* Fix accessibility issue in Uptime app nav links.

* Refresh outdated snapshot.

* Introduce aria-label for hidden content.
2020-07-22 16:49:21 -04:00
Nathan Reese 8b27b1e83c
[Maps] fix removing global filter from layer can cause app to start thrashing (#72763) 2020-07-22 13:37:18 -06:00
Nathan Reese 80da1c6a54
[Maps] fix blended layer aggregation error when using composite aggregation (#72759) 2020-07-22 13:26:22 -06:00
spalger d39e97d972 fix unexpected arguments to unload command 2020-07-22 12:20:11 -07:00
Frank Hassanabad 4fa660c672
Limits the upload size of lists to 9 meg size (#72898)
## Summary

Limits the lists to 9 megs upload size so we don't blow up smaller Kibana installs. Users can change/override this using the switch of `xpack.lists.maxImportPayloadBytes` like so:

```
xpack.lists.maxImportPayloadBytes: 40000000
```

That will increase the amount of bytes that can pushed through REST endpoints from 9 megs to something like 40 megs if the end users want to increase the size of their lists and have enough memory in Kibana.

Metrics and suggestions from testing looks like:

```ts
Kibana with 1 gig of memory can upload ~10 megs of a list before possible out of memory issue
Kibana with 2 gig of memory can upload ~20 megs of a list before possible out of memory issue
```  

Things can vary depending on the speed of the uploads of the lists where faster connections to Kibana but slower connections from Kibana to Elastic Search can influence the numbers.  

### Checklist

- [x] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios
2020-07-22 13:19:27 -06:00
Justin Kambic ffd8ed2d97
[Uptime] Refactor overview filters reducer to use createAction (#69187)
* Refactor overview filters to use createAction.

* Refresh snapshot.

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-07-22 15:18:08 -04:00
spalger 2ef9657ecf fix SIEM es_archiver command syntax 2020-07-22 12:07:49 -07:00
Quynh Nguyen c9c2158682
[ML] Fix deleting DFA not showing index pattern check (#72904) 2020-07-22 14:05:53 -05:00
Lee Drengenberg e9ec039e8e
un-revert login_page change for SAML (#72892) 2020-07-22 14:00:57 -05:00