Commit graph

35411 commits

Author SHA1 Message Date
Mikhail Shustov
88c0631344
Update @typescript-eslint to ensure compatibility with TypeScript v3.9 (#74091)
* bump @typescript-eslint deps

* update rules

* fix errors in pacakges

* fix src/

* fix x-pack

* fix test

* fix typings

* fix examples

* allow _ as prefix and suffix

* roll back prefix and suffix changes

* add eslint-plugin-eslint-comments

* report unused rules

* remove unused eslint comments from tests

* remove unused eslint comments 2nd pass

* remove unused eslint comments from src/

* remove unused comments in x-pack

* use no-script-url and no-unsanitized/property for ts files

* remove unused eslint comments

* eui/href-or-on-click removed when not complained

* no import/* rules for ts files

* cleanup

* remove the unused eslint-disable

* rollback unnecessary changes

* allow underscore prefix & sufix in type name

* update docs

* fix type error in enterprise search plugin mocks

* rename platform hack __coreProvider --> _coreProvider

* rollback space removal in src/core/public/legacy/legacy_service.test.ts

* fix naming convention in APM
2020-08-05 17:32:19 +02:00
Melissa Alvarez
3fb77fb546
[ML] DF Analytics creation wizard: show link to results (#74025)
* show view results card once job complete

* update types

* update types and move css to own file
2020-08-05 10:31:47 -04:00
Mikhail Shustov
8759646576
update docs (#74364) 2020-08-05 15:28:03 +02:00
Alison Goryachev
bf22fe54e1
[Ingest Node Pipelines] Refactor pipeline simulator code (#72328) 2020-08-05 09:21:57 -04:00
Tim Roes
f9fc83fb1d
Add README files for Kibana app plugins (#74277)
* Add README files for Kibana app plugins

* Update src/plugins/timelion/README.md

Co-authored-by: Matthias Wilhelm <ankertal@gmail.com>

* Update src/plugins/vis_type_vislib/README.md

Co-authored-by: Matthias Wilhelm <ankertal@gmail.com>

Co-authored-by: Matthias Wilhelm <ankertal@gmail.com>
2020-08-05 14:28:56 +02:00
Cauê Marcondes
7a1b09dcf1
[APM] Average for transaction error rate includes null values (#74345) 2020-08-05 14:28:13 +02:00
Sonja Krause-Harder
b26bd6175d
[Ingest Manager] Adjust dataset aggs to use datastream fields instead (#74342)
* [Ingest Manager] Adjust dataset aggs to use datastream fields instead

Elastic Agent and Elasticsearch are switching over from using dataset.* to datastream.*. This adjust the aggregation on the dataset page to get the datastreams.

For this to work properly, the most recent version of Elasticsearch 7.9 must be used and is pending updates on all the packages to ship also the datastream fields, see https://github.com/elastic/integrations/pull/213

* Update datastream to data_stream

* Update data stream name generation

* Fix typo

* Temporarily use datastream instead of data_stream

* updating to use `data_stream` instead of `datastream`

Co-authored-by: ruflin <spam@ruflin.com>
Co-authored-by: Jen Huang <its.jenetic@gmail.com>
2020-08-05 13:48:11 +02:00
Dima Arnautov
8231b0ccfc
[ML] Fix initial plugin's bundle size (#74047)
* [ML] use dynamic imports

* [ML] fix react-use imports

* [ML] change embeddables imports

* [ML] embeddable exports

* [ML] move SCSS import

* [ML] management page styles

* [ML] refactor with types and constants files

* [ML] move declarations
2020-08-05 13:18:29 +02:00
John Schulz
beb7b8245d
[Ingest Manager] prevent crash on unhandled rejection from setupIngestManager (#74300)
* Add test to ensure setup rejects if errors thrown.

* Return the promise from setup so test passes
2020-08-05 07:08:04 -04:00
Alejandro Fernández
22d6f09d31
[Logs UI] Correct trial period duration in anomaly splash screen (#74249) 2020-08-05 11:19:41 +02:00
Matthias Wilhelm
c24b17f334
[Discover] Inline noWhiteSpace function (#74331)
* Inline noWhiteSpace function

* Fix TypeScript

* Remove unused function file
2020-08-05 10:49:36 +02:00
EamonnTP
f97641c84a
[DOCS] Add Observability topic (#73041)
* Add observability content

* Remove xpack from file name

* Updates following review

* Review edits

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-08-05 09:28:20 +01:00
spalger
7c60b09baa skip flaky suite (#74327) 2020-08-05 00:05:27 -07:00
Garrett Spong
22809274eb
[Security Solution][Detections] Fixes Severity Override not matching for Elastic Endpoint Security rule (#74317)
## Summary

Fixes an issue where the `Severity Override` would not match for the `Elastic Endpoint Security` rule. This is a temporary fix until we can provide more robust comparisons between the user provided `severityMapping.value` (string) and the `severityMapping.field`'s type.  

### Checklist

- [x] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios
2020-08-04 19:36:34 -06:00
Yara Tercero
6a77bec233
[Security Solution][Exceptions] - Fixes exceptions builder nested deletion issue and adds unit tests (#74250)
### Summary

- Updates logic for deleting exception item entries in the builder - found that there was a bug in deleting nested entries
- Adds more unit tests
2020-08-04 20:06:30 -04:00
Yuliia Naumenko
36f25e66e8
Fixed Alert details does not update page title and breadcrumb (#74214)
* Fixed Alert details does not update page title and breadcrumb

* Added alert name to details breadcrumb as a dynamic title

* Update x-pack/plugins/triggers_actions_ui/public/application/lib/breadcrumb.ts

Co-authored-by: Mike Côté <mikecote@users.noreply.github.com>

Co-authored-by: Mike Côté <mikecote@users.noreply.github.com>
2020-08-04 16:00:56 -07:00
Spencer
409779d1ed
[src/dev/build] build Kibana Platform bundles from source (#73591)
Co-authored-by: spalger <spalger@users.noreply.github.com>
2020-08-04 15:34:01 -07:00
Tim Sullivan
372d8817a7
[Reporting] Shorten asset path to help CLI FS Watcher (#74185) 2020-08-04 14:27:44 -07:00
Aaron Caldwell
c123cfead7
Fix TMS not loaded in legacy maps (#73570)
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-08-04 15:15:57 -06:00
Angela Chuang
2eb67130f3
[Security Solution] styling for notes' panel (#74274)
* styling for notes' pannel

* styling

* remove additional const

* styling
2020-08-04 21:19:05 +01:00
Frank Hassanabad
f506279a55
[Security Solution][Tech Debt] cleans up ts-ignore issues and some smaller linter issues (#74268)
## Summary

* Removes ts-ignore where it is not being used
* Replaces ts-ignore with the better alternative which is the ts-expect-error
2020-08-04 14:04:45 -06:00
Mike Côté
54e13ad6f6
Make the actions plugin support generics (#71439)
* Initial attempt at making the actions plugin support generics

* Export WebhookMethods

* Fix typings for registry

* Usage of Record<string, unknown>

* Apply feedback from Gidi

* Cleanup

* Fix validate_with_schema

* Cleanup pt2

* Fix failing tests

* Add generics to ActionType for ActionTypeExecutorResult

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-08-04 15:50:17 -04:00
Angela Chuang
8e0e228dbf
[Security Solution] Keep original note creator (#74203)
* keep original note creator

* unit test

* fix types

* typo

* wording
2020-08-04 15:35:00 -04:00
Brian Seeders
ea4d36f713
[CI] Fix xpack kibana build dir in xpack visual regression script 2020-08-04 15:27:04 -04:00
Brian Seeders
b7a8a4a54a
[CI] Fix baseline_capture job by adding parallel process number back 2020-08-04 14:19:26 -04:00
Chris Roberson
de22caa0f6
[Monitoring] Ensure setup mode works on cloud but only for alerts (#73127)
* Ensure setup mode works on cloud but only for alerts

* Update snapshot

* Update translations

* Restructure tests to understand the failure better

* PR feedback

* Backwards, whoops

* Remove commented out code

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-08-04 13:32:21 -04:00
Thomas Neirynck
3067184c45
[Maps] Custom color ramps should show correctly on the map for mvt layers (#74169) 2020-08-04 13:30:09 -04:00
Spencer
0502fee651
[kbn/optimizer] remove unused modules (#74195)
Co-authored-by: spalger <spalger@users.noreply.github.com>
2020-08-04 10:19:51 -07:00
Brian Seeders
0ca8e99a9f
[CI] Add pipeline task queue framework and merge workers into one (#71268) 2020-08-04 13:13:51 -04:00
Jonathan Buttner
2dea17a8d0
Using msearch for tree api endpoint (#73813) 2020-08-04 12:54:20 -04:00
Kerry Gallagher
89dba39273
Handle modifier keys (#74237) 2020-08-04 17:13:32 +01:00
Angela Chuang
b42f64d1a2
[Security Solution] Load prepackage timelines by default (#74209)
* load prepackage timelines by default

* fix unit tests
2020-08-04 16:57:53 +01:00
Sandra Gonzales
8e0ae5ffd1
add force install option (#74172) 2020-08-04 10:54:11 -05:00
Ben Skelker
f3fbb7d79f
[Security Solution]Updates exception options and setting text (#73769)
* updates exception text

* updates modal text

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-08-04 17:42:51 +03:00
Poff Poffenberger
7208a5746a
[Canvas] Fix Custom Element functional test (and remove skip) (#73727)
* Remove skip of custom elements
2020-08-04 09:18:47 -05:00
Patryk Kopyciński
ecc7fcec40
[Security Solution] Fix Fullscreen view (#74236) 2020-08-04 15:56:18 +02:00
Vadim Dalecky
23fedcf636
feat: 🎸 navigate from maps embeddable to app in SPA way (#74102) 2020-08-04 15:25:53 +02:00
Vadim Dalecky
4f2209b209
refactor: 💡 clean up and simplify replace panel input update (#74076) 2020-08-04 15:20:57 +02:00
Frank Hassanabad
73077c3d19
Fixes one more spot where we forgot to add plumbing for the strict_date_optional_time (#74211)
## Summary

Related closed issues:
https://github.com/elastic/kibana/issues/58965
https://github.com/elastic/kibana/pull/70713

If you add a custom mapping and go to the hosts details page you will get an error toaster:
<img width="838" alt="Screen Shot 2020-08-03 at 7 53 16 PM" src="https://user-images.githubusercontent.com/1151048/89244409-a7df7500-d5c3-11ea-933c-99d96bffc589.png">

If running local host you can configure your index patterns to use a custom one I setup with custom date time formats and a single record which can cause this:
<img width="1223" alt="Screen Shot 2020-08-03 at 7 50 12 PM" src="https://user-images.githubusercontent.com/1151048/89243967-8fbb2600-d5c2-11ea-8de2-4422e870f9f0.png">


Then visit this URL and set your date time to go backwards by 1 year
```ts
http://localhost:5601/app/security/hosts/app/security/hosts/MacBook-Pro.local/alerts
```

And with the fix you no longer get the error toaster.
2020-08-04 06:54:47 -06:00
Marco Liberati
c78da24708
[ Functional Tests ] TVSB charts flaky tests on index pattern switch fix (#74110)
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-08-04 14:44:16 +02:00
Clint Andrew Hall
53131313df
[kbn-storybook] Kill tsdocgen for immediate perf improvement (#74059)
* [kbn-storybook] Kill tsdocgen for immediate perf improvement

* Addressing feedback
2020-08-04 08:19:02 -04:00
Xavier Mouligneau
5c741a1e00
reset datepicker of timeline (#74210) 2020-08-04 07:37:22 -04:00
Xavier Mouligneau
8e7d0b86cc
[SECURITY] Bug do not allow saving when opening a timeline (#74139)
* only saved timeline when you are duplicating them

* fix unit test
2020-08-04 07:36:21 -04:00
Cauê Marcondes
fc04ef9152
Observabilty overview APM section doesn't fully collapse (#74224) 2020-08-04 12:46:49 +02:00
Mikhail Shustov
e57f4d2b25
[KP] update ES client migration guide (#73241)
* add note about error format and FTR service

* add notice about lack of response typings

* more detailes example of search response type usage
2020-08-04 09:50:32 +02:00
MadameSheema
fb3370d99b
updates file picker label (#74136) 2020-08-04 09:17:03 +02:00
Jen Huang
3cce216f2e
[Ingest Manager] Improve agent config list -> detail UI transition (#73566)
* Improve agent config detail page loading state

* Show ID instead of loading icon

* Fix types
2020-08-03 19:24:48 -07:00
Andrew Goldstein
4031f55701
[Security Solution] Fixes scroll issues related to the sticky header (#74062)
## [Security Solution] Fixes scroll issues related to the sticky header

Fixes scrolling issues related to the sticky header.

The Security solution hid the app navigation links (e.g. `Overview`, `Detections`, `Hosts` ...) in the sticky header when the page was scrolled (to maximize the available vertical space), but in recent `7.9` BCs, sometimes this [created issues while scrolling](https://github.com/elastic/kibana/issues/73882).

With the introduction of Full Screen mode in Timeline-based views, it's no longer necessary to hide the app navigation links while scrolling. (The navigation links are hidden when Timeline-based views are placed into full screen mode.)

Fixes: https://github.com/elastic/kibana/issues/73882

## Desk testing

Desk tested in:
- Chrome `84.0.4147.105`
- Firefox `79.0`
- Safari `13.1.2`
2020-08-03 18:25:12 -06:00
Jonathan Buttner
64126b425e
[Security Solution][Resolver] Handle info and change events for children (#74007)
* Handle info and change events for children

* Disabling tests for children search_after

* Addressing comments
2020-08-03 20:01:11 -04:00
Ryland Herrick
63500c89c3
Do not display our app URL field on read-only view (#74183)
This is a "hidden" field added as metadata during rule creation. It is
omitted from all other views, but in the case of an error response
during rule creation, the read-only view will display this field.

In lieu of any broad changes here, this simply hides that field from the
(really, any) read-only view of that data.
2020-08-03 18:41:20 -05:00