Commit graph

26726 commits

Author SHA1 Message Date
Nick Peihl 8a3b96d768
[Maps] Load Maki icons from spritesheet (#42499)
* Load Maki icons from spritesheet
2019-08-06 13:32:04 -07:00
Dmitry Lemeshko 077ae4dc65
add await for browser calls (#42515) 2019-08-06 21:58:03 +02:00
Tim Sullivan 0d7eab77f8
[Reporting/Refactor] Break up screenshots.ts, consolidate logging (#42304)
* [Reporting] Sanitize 409 error log message

* [Reporting] Break up screenshots libs

* Revert "[Reporting] Sanitize 409 error log message"

This reverts commit 61998b5847.

* [Reporting] Sanitize 409 error log message

* this is for later
2019-08-06 12:19:29 -07:00
Luke Elmers 6cd3a67d98
Remove deprecated index patterns field methods. (#42643) 2019-08-06 13:02:40 -06:00
Mike Côté b94c16da75
Fix task manager flaky middleware test (#42418)
* Fix flaky test

* Cleanup beforeEach code
2019-08-06 14:53:29 -04:00
Rudolf Meijering e137477b5a
[Core] Public saved objects client (#39891)
* Move SavedObjectClient files to core/public

* Initial SavedObjectsService in public Core

* Public SavedObjectsClient tests

* Import SimpleSavedObject from src/core/public

* Use types from source files for kibana.d.ts

* Add html raw loader to x-pack/jest

* Cleanup

* Drop case utilities and improve test coverage

* Update types and documentation

* Fix build breaking when importing directly from /server in /public

* Ensure that all option paramaters are picked and renamed

* Fix option mapping and introduce stronger types

* Eslint: allow imports from src/core/*/types

* Add compatibility layer for kfetch vs http.fetch error responses

* Improve documentation

* Expose SavedObjectsMigrationLogger

* Documentation and type tweaks

* Revert type changes from 73e601f and update api docs

* Refactor request into savedObjectFetch + test

* Make legacy SavedObject compatible with http.fetch exceptions

* Fix types and tests

* simple_saved_object import from src/core/server

* server imports from root instead of server/types

* Make SavedObjectsService a class

* Don't pick unkown keys from server response

* Rename SavedObjectsFindResponse to SavedObjectsFindResponsePublic

* Remove err.response from SavedObjects fetch errors

* Revert "Remove err.response from SavedObjects fetch errors"

This reverts commit 61705ca361.

* Don't introduce err.response until we deprecate err.res
2019-08-06 20:53:05 +02:00
Mengwei Ding fe1389cc90
[Code] Do not persist git update error (#42629)
* [Code] Update log level for scheduler

* [Code] Do not persist git update error

* remove console.log
2019-08-06 11:43:37 -07:00
Rudolf Meijering f7568e6fbf
Fixes #40714: Import API don't override SavedObjectClient errors (#41125)
* Import API: Don't override SavedObjectClient errors

* Review comments: rely on default hapi error behaviour
2019-08-06 19:49:07 +02:00
Josh Dover 5192dac0b6
Add ContextService to server (#42395) 2019-08-06 12:24:49 -05:00
Bart Van Remortele 98b445a6e0 [APM] Transaction duration chart always shows duration in ms (#42375)
* make the transaction chart use the appropriate unit depending on the max value

* fix TimeFormatter type not being imported
2019-08-06 18:42:57 +02:00
CJ Cenizal c571d2fab3
Fix flakiness in request lib tests (#42647)
* Remove flakiness from 'pollIntervalMs' test by making timing irrelevant.
* Remove flakiness from 'state' tests by increasing wait time.
* Fix flakiness with 'resets the pollIntervalMs' test by increasing the wait time.
2019-08-06 08:48:48 -07:00
Mike Côté ef02bf9e0e
Make task manager index configurable again (#42394)
* Initial work

* Fix type check

* Accept core API changes

* Fix broken tests

* Destructure index pattern
2019-08-06 11:22:59 -04:00
Corey Robertson 85b0f22eb2
Fix autocomplete not working (#42183) 2019-08-06 10:01:44 -05:00
Nathan Reese e32ae12fea
[Maps] fix flaky tests caused by missed Add Layer clicks (#42659)
* [Maps] fix flaky tests caused by missed Add Layer clicks

* unskip add layer import panel tests

* fix call to waitForLayerAddPanelClosed
2019-08-06 08:44:59 -06:00
Poff Poffenberger 3b739144bc
Updating canvas layout flex basis to auto for IE11 (#42544) 2019-08-06 09:33:48 -05:00
Patrick Mueller 25026381ec
Adds config-schema nullable composite type (#41728)
The `nullable` type is very similar to the `maybe` type, except that
it validates nulls and undefined values to null, instead of undefined.
Eg,

    maybe(T): T | undefined
    nullable(T): T | null
2019-08-06 09:46:00 -04:00
Jean-Louis Leysens 9f6188f314
[Rollup] Clone an existing rollup job (#41891)
* WIP: Clone Rollup functionality

* WIP: Course correct for better UX

* Fix formatting issues

* wip continues, refactoring to clone job pattern.

* First pass of clone functionality working end to end.

* Only re-type when necessary

* Show cloned errors immediately after choosing to clone a rollupjob

* Remove pluralised label for now

* cherry pick master changes

* First pass at new start-on-create feature with error handling

* Added tests and did a minor naming refactor for tests

* Combine job create review tests into one file, following steps performed: 1) correctly mock out http requests 2) increase the wait time given the 500ms sleep

* Go with potentially incorrect pluralisation for now

* Use JS paramter default

* Simplify on click event listener

* Cleanup use of lodash imports, fix spec after change to event listener, make code a bit more defensive

* Remove unnecessary span

* Updated checkbox copy

* Moved start after create checkbox to immediate right of start button

* Update checkbox vertical alignment

* Re-integrate changes with master

* Switch job action menu ui component to using i18n.translate

* More descriptive variable name

* Use initialState for job clear

* Simplify and rephrase comment

* Remove lodash import and add missing period to end of sentence.

* Fix defaulting to something when it should be nothing

* Fix i18n compatibility checks

* Tests for cloning jobs

* Test cleanup

* Fix whitespace noise

* Fix button labels assertion to be more robust

* Updated validation logic for rollups - rollups names are non unique
Added "-copy" to end of cloned rollup job name/id

* Whitespace

* clean up unused code and double clicking of component in test

* Update test suite name

* Added comments to create from clone test

* Added better expectations for results of smoke test

* Whitespace
2019-08-06 14:01:12 +02:00
Kerry Gallagher ad111bed1f
[LogsUI] [InfraUI] Turn source configuration into a tab and standardize the main navigation (#42243)
* Setup Logs routing for multiple pages

* Adds nested routing for logs
* Adds an index page to handle shared concerns
* Adds the Stream page at /logs/stream

* Introduce shared settings page

* Introduces shared/settings page
* Adds shared/settings page as a tab in the Logs routes
* Removes previous source configuration flyout traces from Logs pages

* Begin styling adjustments to settings page

* Implements use of EUI Panels
* Centers page content

* Add discard button

* Add discard button to allow resetting the form

* Fix button alignment

* Align Apply and Discard buttons to the right
* Align Loading button to the right

* Add EuiDescribedFormGroup for all form fields

* Add EuiDescribedFormGroup for name panel
* Add EuiDescribedFormGroup for indices panel
* Add EuiDescribedFormGroup for fields panel

* Remove all SourceConfigurationFlyout traces from the Infrastructure UI

* Add a ViewSourceConfigurationButton

* Adds a ViewSourceConfigurationButton component that will route to the /settings page
* Replace all instances of "View Configuration" buttons that were opening the flyout with the new button

* Enable settings tab amongst Infrastructure routes

* Change navigation to mimic SIEM

* Introduces an AppNavigation component
* Amends styling / handling of RoutedTabs to match SIEM implementation
* Adds new AppNavigation component to Infrastructure and Logs indexe pages

* Functional test amendments (WIP)

* Temporarily disable certain functional tests

* Remove unused imports

* Disable imports so build can pass

* Amend I18N errors

* I18N

* Automatically fix issues with i18n (node scripts/i18n_check --fix result)

* Functional tests

* Amend tests so they pass locally. Pending CI test.

* Amend RoutedTabs (without link focus style)

* Tweak RoutedTabs and AppNavigation for better performance / visuals

* Ensure outline isn't cut off
* Ensure only the react-router instance is hit for performance
* Ensure links still have href attributes for things like "Open in a new tab" even if history.push ultimately navigates

* Fix i18n usages

* node scripts/i18n_check --fix

* Amend functional test config (post Master merge fix)

* Remove unused function and fix unused import

* Add a Prompt to notify users when form changes will be lost

* Add aria-label to Button
2019-08-06 11:34:25 +01:00
Rudolf Meijering 560ac8f449
Fixes #42519 dashboard migration bug (#42520)
* Fixes #42519 dashboard migration bug

* Tests

* Dashboard migration errors: log stack and dashboard document
2019-08-06 11:05:29 +02:00
Daniil Suleiman 8eb99b4d3f
[Vis: Default editor] EUIficate coordinate map (tile map) options tab (#42517)
* EUIficate tile_map_vis_options

* Add basic options

* Get rid of vislib_basic_options

* Move wms_options directive to region_map

* Get rid if TileMapVisParams directive

* Update region_map namespaces

* Support of injecting of any dependency
2019-08-06 12:00:27 +03:00
Alexey Antonov b7f980a3fa
[Tag Cloud] (Step 2) Shim new platform - renaming tagcloud-> vis_type_tagcloud (#42589) 2019-08-06 11:29:10 +03:00
Alexey Antonov 872b56d61e
[Metric Vis] (Step 2) Shim new platform - renaming metric_vis -> vis_type_metric (#42590) 2019-08-06 11:28:08 +03:00
Alexey Antonov 018e07129a
[Markdown Vis] Shim new platform - cleanup markdown_fn.ts (#42592) 2019-08-06 11:26:16 +03:00
Henry Wong 2dc61533c1
[code] Enable go langserver under non-detach mode. (#42352)
* [code] Enable go langserver under non-detach mode.

* [code] Enable go langserver under non-detach mode #part 2.

* [code] Enable go langserver under non-detach mode #part 3

We should keep the kibana code data inside the 'kibana/data' . That
means go-langserver has nothing to do with dev machine except '$PATH'.

* [code] Enable go langserver under non-detach mode #part 4

Since we use socket as the process communication media, remove the
unused parameter.
2019-08-06 16:11:00 +08:00
WangQianliang eba68fa928
feature(code/frontend): apply new document symbol api (#42324) 2019-08-06 13:50:36 +08:00
WangQianliang 0d6d2553e9
feature(code/frontend): show loading indicator if file loading time exceed some amount of time (#42571) 2019-08-06 10:53:57 +08:00
Nathan Reese f617a65313
[Maps] fix flaky test in documents_source/search_hits·js (#41841) 2019-08-05 20:51:57 -06:00
Thomas Neirynck 1823f7d8d6 [Maps] Skip flaky test (#42638)
* skip test

* also skip closing

* skip failing test (#42630)

* Revert "disable all maps tests"

This reverts commit 42c35e0e12.

* skip file_indexing_panel tests
2019-08-05 19:31:30 -06:00
Spencer 9ddbd84f66
move vault setup into repo so all ci logic is in the repo (#42642)
* move vault setup into repo so all ci logic is in the repo

* turns out I'm used to less strict bash...

* unset VAULT_ADDR
2019-08-05 17:20:23 -07:00
spalger 42c35e0e12 disable all maps tests 2019-08-05 16:05:40 -07:00
Zacqary Adam Xeper db4fcc33f8
Fix broken CONTRIBUTING.md link (#42548) 2019-08-05 17:43:18 -05:00
Luke Elmers 191697b238
Update MIGRATION.md with note about karma mocks for new platform services. (#42302) 2019-08-05 16:11:36 -06:00
gchaps 3d4b3e9bd8
[DOCS] Removes outdated image (#42624) 2019-08-05 12:25:58 -07:00
Patrick Mueller 6acb716b2c
Changes action create/update http apis to return bodies (#42493)
Prior to this PR, the create and update http apis for actions returned
an object with the shape `{ id: <id of relevant action> }`.

This PR changes the responses to be the complete body of the action that
was created / updated, not just the `id`.

I believe this is the final piece of the "fix http apis for actions / alerts"
issue https://github.com/elastic/kibana/issues/41828
2019-08-05 14:42:58 -04:00
patrykkopycinski 396edb9504 Fix links in x-pack/README.md (#42187) 2019-08-05 13:29:04 -05:00
Jean-Louis Leysens 735a56b282
[Console] Added doc_values to list of completion items for mapping (#42581)
* Added doc_values to list of completion items for mapping

* Added one other autocompletion.
2019-08-05 18:09:22 +02:00
Thomas Neirynck 495b1a055e
[Maps] Prepare EMSClient for vector tile support (#42384) 2019-08-05 11:44:20 -04:00
Nicolas Chaulet 1aa21c123d
[Tests] Setup contract tests in x-pack (#42345) 2019-08-05 11:15:03 -04:00
Pengcheng Xu 04b68997ab
[Code] Upgrade ctags-langserver to use universal ctags (#42509) 2019-08-05 23:03:21 +08:00
WangQianliang da45c99503
fix(code/frontend): fix button group text size (#42566) 2019-08-05 22:24:20 +08:00
polmanova c01ea80bbf Add icon for geo_shape fields in Discover (#42087) 2019-08-05 13:39:06 +02:00
James Gowdy 5d3d3131c1
[ML] Fixing new jobs from saved searches (#42474) 2019-08-05 11:35:06 +01:00
James Gowdy e0156d6fd2
[ML] Fixing ml when spaces feature is disabled (#42564)
* [ML] Fixing ml when spaces feature is disabled

* correcting grammar in comment

* fixing typo
2019-08-05 11:08:15 +01:00
Artyom Gospodarsky 8d00d26900 [TSVB] Shim new platform (#39169)
* Shim server side to new platform

* Shim public to new platfrom

* Break by services

* Add dependencies to the TSVB plugin

* Change folder structure for the shim

* Pass services as a second argument of setup() and small fixes

* Add start() to the Plugin

* Get rid of the Private

* Pass the core to setup()

* Get rid of NP folder

* Set config to timezoneProvider()

* Take an external dependency from EditorController

* Take an extra dependency out from Request Handler

* Rename metricsPlugin to Plugin

* Fix reviews

* Add types to .setup()

* Change types of TSVB

* Divide the plugin, its setup config and and entry point

* Get rid of @ts-ignore

* Add a server type to the CustomCoreSetup interface

* Revert kbn_vis_type settings

* Restructure public assets

* Move setup.js inner to the legacy.ts

* clean up

* fix PR commnets
2019-08-05 11:10:36 +03:00
Alexey Antonov 51c48b7c3c
[Metric Vis] Shim new platform (#42240)
* Add New Platform mocks for data plugin

* [Metric Vis] Shim new platform

* move metric_vis_controller to components folder

* fix PR comments

* change interpreter type for colorRange and font

* change interpreter type for colorRange and font
2019-08-05 10:59:40 +03:00
Alexey Antonov 5d3970fb9c
[Tag Cloud] Shim new platform (#42348)
* [Tag Cloud] Shim new platform

* fix PR comments
2019-08-05 10:57:03 +03:00
CJ Cenizal d5ce67f5ed Disable flaky request lib tests. Add es_ui_shared plugin to CODEOWNERS. 2019-08-04 12:36:53 -07:00
Mike Place 15c43b73ef
Add disk space percentage to node listing (#42145)
* Add disk space percentage to node listing

* Test modification for totalSpace

* Fix test mockup

* Add totalSpace to fixture

* Test fixup

* Remove trailing space per review suggestion

* More fixture updates

* More fixture update

* More fixture updates

* Update mock

* More fixture changes
2019-08-03 12:03:57 +00:00
Angela Chuang 392b8e16f7
[SIEM] Add chart interactions - update date picker after brush selection on charts (#42440)
* add click and brush events

* replace setAbsoluteRangeDatePicker

* fix type error

* remove a not necessary export
2019-08-03 19:08:59 +08:00
Mikhail Shustov d394ded2ac
Document HTTP service (#42331)
* improving naming, add TSDoc

* re-genereate docs

* use response name in migration guide

* Apply suggestions from code review

Co-Authored-By: Josh Dover <me@joshdover.com>

* place docs near the related code

* re-generate docs

* mark code as example to reduce noise in http-service.md
2019-08-03 09:58:35 +02:00