Commit graph

36988 commits

Author SHA1 Message Date
Brian Seeders
9011f42d7f Skip failing suite (#79522) 2020-10-05 14:30:49 -04:00
Aleh Zasypkin
dca9e70616
Ignore intermediate unauthenticated session during repeated authentication attempt. (#79300) 2020-10-05 20:07:23 +02:00
Patrick Mueller
a812db3e26
[Alerts] resolve flaky lastExecutionDate tests (#79436)
resolves https://github.com/elastic/kibana/issues/79249

The tests that were flaky were capturing a date while the test was running,
and then comparing to a lastExecutionDate field.  Most of the time this
worked, but were sometimes out of order because of the way the searches
are done and status changing dynamically.  The only current dates we can test
against are really at the very beginning and very end of the tests.
2020-10-05 14:05:34 -04:00
Quynh Nguyen
ad89e6f956
[ML] Add runtime fields support (#78700)
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2020-10-05 13:00:58 -05:00
Poff Poffenberger
ead4ebc9f6
[Canvas] Disable datasource UI when expression contains an expression argument (#79369)
* Disable datasource UI when expression contains an expression argument

* Removing unnecessary type coercion
2020-10-05 12:52:12 -05:00
Sushrut Kasture
8c3af56e2b
Update user table after user is deleted (#79491) 2020-10-05 13:41:25 -04:00
Jean-Louis Leysens
e98e2796d5
[Ingest Pipelines] Fix description field bug (#79445)
* rendering optimisation of text fields

* fix description disappearing bug

* refactor fix to get value from form serializer
2020-10-05 19:40:19 +02:00
Walter Rafelsberger
c7caac61a2
[ML] Data Frame Analytics: Expandable sections for classification and regression (#79414)
Applies the expandable section based layout to the results pages of classification and regression analytics jobs.
2020-10-05 19:23:13 +02:00
Gidi Meir Morris
4fdf2f1566
[Actions] makes savedObjectId field optional (#79186)
This PR makes the `savedObjectId` parameter optional in the Jira, ServiceNow and IBM Resilient Connectors.
This allows them to execute without this field outside of Alerts, as it is currently populated using the `alertId` which isn't available in other places.
Additionally this adds an optional field in the `Params` Components for all three of the connectors, which allows users to provide a value for the `savedObjectId` field if the so wish.
2020-10-05 18:21:20 +01:00
Shahzad
de130abfbc
[UX] Add core web vitals in obsv homepage (#78976) 2020-10-05 19:15:13 +02:00
Nicolas Chaulet
28278abdda
[Ingest Manager] Fix agent tests and short polling timeout (#79442) 2020-10-05 13:10:17 -04:00
Constance
5812217631
[Enterprise Search] Update chrome/breadcrumbs to support dynamic/nested breadcrumbs (#79231)
* [Setup] Add new stripLeadingSlash util

- will be used by upcoming breadcrumb/path logic
- rename folder + update references
+ clean up tests

* Update breadcrumb helpers with new useGenerateBreadcrumbs
- responsible for generating an array of IBreadcrumb objs with correct react router paths, given an array of breadcrumb text

+ rename previous generic useBreadcrumbs helper to a more specific useEuiBreadcrumbs (indicates the type of transforming happening)

+ misc typing updates/improvements

* Update SetChrome helpers
- to use new useGenerateBreadcrumbs() helper

+ simplify props - remove `isRoot` and `text` (now just accepts a single `trail` array - an empty trail creates the same effect as isRoot
+ simplify/improve typing as a result (yay!)
- improve docs

+ useEffect update - update breadcrumbs/titles if `trail` ever changes. This will primarily be most helpful for pages that fetch dynamic data on page load (e.g. a dynamic engineName, groupName, etc.)
- note that in the above case trail arrays should probably be wrapped in useMemo() to reduce unnecessary rerenders

* Update all instances of SetPageChrome to new props

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2020-10-05 10:08:13 -07:00
Sonja Krause-Harder
ce4641aa97
[Ingest Manager] Install uploaded package (#77986)
* Refactor: installPackage -> installPackageFromRegistry

* Refactor: factor out source-agnostic installation steps

* Unpack and cache uploaded zip and tgz files.

* Add basic archive verification and parse manifest.

* Catch error when zip archive is uploaded as gzip.

* Add API integration tests.

* Remove unnecessary use of "package key" concept.

* Add 'install_source' property to saved object epm-packages.

* Adjust tests.

* Add API integration test for manifest missing fields.

* Refactor loadArchive -> loadArchivePackage.

* Refactor caching of package archive content

* Get datasets and config templates from manifest files.

* Use file paths from archive instead of asset paths from registry.

* Correctly load registry packages into cache

* Use InstallablePackage instead of RegistryPackage where possible.

* Actually install uploaded package.

* Add missing field to saved objects in tests.

* Adjust unit test to pick buffer extractor.

* Adjust unit test.

* Fix and re-enable getAsset() test.

* Adjust integration tests.

* Make error message match test.

* Pick data_stream.dataset from manifest if set.

* dataset -> data_stream also in comments

* Remove unused variable.

* Use pkgToPkgKey() where appropriate.

* More dataset -> data stream renaming.

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2020-10-05 18:51:06 +02:00
Uladzislau Lasitsa
90b6442ca6
[Visualize] Horizontal Bar Graph Visualizations have Vertical Bar Graph Type (#78536)
* Fixed useEffect in metric_axes. Update type in params instead of type of vis

* Fixed tests

* Fixed tests

* Update current chart type definition

Co-authored-by: sulemanof <daniil_suleiman@epam.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2020-10-05 19:46:02 +03:00
Ryland Herrick
951034cf0c
[Search]Add EQL search strategy (#78645)
* Add EQL search strategy

Since EQL is an x-pack feature, this strategy will live in the
x-pack plugin data_enhanced.

* Refactor our test setup to minimize shared state

* Ensures that the same variable is not used for both test setup and
  test assertions
* Ensures that mocks are reinstantiated on every test

* Use explicit top-level exports

* Move async search options to a helper function

* Move our workaround to a helper function

This was repeated in five places, time to consolidate.

* Commit documentation changes

We export a few new helper functions.

* Mark our internal methods as such

Updates documentation accordingly.

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2020-10-05 11:30:32 -05:00
Liza Katz
5f53d4f34b
[RFC][Search] Background sessions RFC (#73281)
RFC

Co-authored-by: Lukas Olson <olson.lukas@gmail.com>
2020-10-05 19:18:30 +03:00
Shahzad
897a609c35
Remove resize panels (#79428) 2020-10-05 18:16:21 +02:00
Patryk Kopyciński
fd27e5b735
[Security Solution] Align skip logic across SearchStrategy queries (#79085) 2020-10-05 18:10:40 +02:00
Sébastien Loix
0d378e488c
Form lib enhancements (#78588)
Co-authored-by: Patryk Kopycinski <contact@patrykkopycinski.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2020-10-05 18:09:50 +02:00
Paul Tavares
1dacabc534
Un-skip endpoint policy details tests (#79460) 2020-10-05 12:02:29 -04:00
Patryk Kopyciński
88ddde817c
[Security Solution] Fix source.ip and destination.ip draggables (#79399) 2020-10-05 17:42:48 +02:00
Sandra Gonzales
53f22dcf36
[Ingest Manager] Upgrade Agents in Fleet (#78810)
* add kibanaVersion context and hook, add upgrade available indications

* add agent upgrade modals and action buttons

* fix import

* add bulk actions api and remove source_uri as required

* add upgrading to AgentHealth status

* buildKueryForUpgradingAgents

* bulk actions UI

* remove source_uri

* add release type to agent details

* don't allow upgrade of unenrolled/unenrolling agent

* hide upgradeable button when not upgradeable

* fix test

* add udpating agent status

* remove upgrade available filter button for now

* update isUpgradeAvailable to use local_metadata upgradeable

* add UPDATING to agent event subtype

* use saved object for updating agent status

* add updating badge type label

* add upgrade available button and update agent list endpoint to accept showUpgradeable

* add schema and type for UPDATING

* fix type

* dont try to upgrade local_metadata

* exclude from AAD upgrade_started_at and upgraded_at

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2020-10-05 11:33:41 -04:00
igoristic
f490268a2e
[Monitoring] JVM memory usage alert (#79039)
* Memory usage first draft

* Fixed tests

* CR feedback

* Feedback and tests

* Added size to optimize query

* Removed scheduled check

* Removed globalstate date

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2020-10-05 11:22:17 -04:00
Bhavya RM
14e58fbadb
A11y tests for user page (#79199) 2020-10-05 11:09:14 -04:00
Jean-Louis Leysens
f6729dc3f4
[Ingest Pipelines] Processors editor a11y focus states (#79122)
* Fix showing of accessibility border

- fix use of flex items (removed unnecessary use thereof)
- also fixed overflow when tabbing through drop zones (compressed)

* refactor isLast to compressed

* optimize keyboard focus states in move mode

* fix jest test

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2020-10-05 17:05:10 +02:00
Alison Goryachev
18a67b68b1
[Ingest pipelines] Clean up component integration tests (#78838) 2020-10-05 10:52:08 -04:00
Vadim Dalecky
59e4e06316
Drilldowns in examples (#75640)
* feat: 🎸 add telemetry for in-chart "Explore underlying data"

* feat: 🎸 add telemetry for in-chart "Explore underlying data"

* refactor: 💡 move all drilldowns into a sub-folder

* feat: 🎸 setup example app section for ui_actions_enhanced

* feat: 🎸 set up Drilldown Manager section

* feat: 🎸 open drilldown manager from example plugin

* refactor: 💡 rename supportedTriggers -> triggers prop

* feat: 🎸 show dev warning if triggers prop is empty

* refactor: 💡 rename "supportedTriggers" -> "triggers" props

* feat: 🎸 open and close drilldown manager from example plugin

* feat: 🎸 add sample ML job trigger

* feat: 🎸 add sample ML URL drilldown

* refactor: 💡 move KibanaURL to share plugin

* refactor: 💡 add index file to ml drilldown

* feat: 🎸 add AbstractDashboardDrilldown

* refactor: 💡 make dashboard drilldown use abstract drilldown

* refactor: 💡 rename dashboard drilldown to embeddable drilldown

* feat: 🎸 add Dashboard drilldown to sample plugin

* feat: 🎸 open dashboard drilldown in list view

* feat: 🎸 add drilldown execute button

* refactor: 💡 move drilldown React hooks into /hooks folder

* test: 💍 fix tests after renaming triggers

* chore: 🤖 populate "requireBundles"

* fix: 🐛 fix TypeScript errors

* fix: 🐛 fix Kibana plugin dependency

* chore: 🤖 remoe unused import

* feat: 🎸 persist drilldown manager state across app navigations

* refactor: 💡 move no-embeddable example into a seprate file

* feat: 🎸 set up example with embeddable

* feat: 🎸 improve embeddable example

* refactor: 💡 rename without embeddable example

* feat: 🎸 set up no-embeddable single click example

* feat: 🎸 add dashboard drilldown to single button example

* fix: 🐛 remove unused margin

* fix: 🐛 make "Get more actions" translation static

* chore: 🤖 remove old dashboard drilldown definition

* refactor: 💡 rename samples to generic names

* refactor: 💡 make app 1 example drilldown "hello world"

* chore: 🤖 remove unused required bundle

* chore: 🤖 add dashboardEnhanced back

* [kbn/optimizer] only build xpack examples when building xpack plugins

* move alerting_example into x-pack/examples

* remove filter for alertingExample plugin in oss plugins CI step

* revert unrelated change

* fix: 🐛 use correct prop name

* test: 💍 fix embeddable-to-dashboard drilldown mock

* test: 💍 fix a test after refactor

* chore: 🤖 remove unused import

* chore: 🤖 add dashboard_enahcned to example plugin

* chore: 🤖 address review comments

* feat: 🎸 add description to UI Actions Enhanced examples

* docs: ✏️ improve docs of example plugin

Co-authored-by: spalger <spalger@users.noreply.github.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2020-10-05 16:31:30 +02:00
Nathan L Smith
13a737e675
Storybook and Jest cleanup (#79305)
* Fix all broken stories
* Get rid of all Jest warnings
* Remove `@ts-expect-error`s added for JSON imports and fix their type errors
* Convert some stories to [Component Story Format](https://storybook.js.org/docs/react/api/csf)
* Replace story for Service Map with many external services with one for the popover with many external services
* Center and fit cytoscape maps in stories
* Rename some files to snake_case
2020-10-05 09:18:24 -05:00
MadameSheema
fdc6562350
adds EQL sequence rule test (#79287)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2020-10-05 16:17:48 +02:00
Michail Yasonik
a66259aaa1
PR template a11y checklist item improvement (#79243) 2020-10-05 09:16:06 -05:00
Jonathan Buttner
cc633a4a91
[Security Solution] Adding tests for dns pipeline in the endpoint package (#79177)
* Adding tests for dns pipeline in the endpoint package

* Adding test to make sure non dns events are ingested correctly

* Bring the docker container with the new endpoint package

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2020-10-05 10:11:28 -04:00
Quynh Nguyen
e067604d78
[ML] Only adjust the bounds of SMV if annotations are visible (#79210)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2020-10-05 09:06:55 -05:00
Mikhail Shustov
5ca87308ea
global search to ts refs (#79446) 2020-10-05 16:00:27 +02:00
Sébastien Loix
a8b1b9e281
[Index management] Update TemplateDeserialized interface (#78913)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2020-10-05 15:19:36 +02:00
Ahmad Bamieh
f960e89ef6
[Telemetry] server fetcher check all collectors ready before sending (#79398)
Co-authored-by: Alejandro Fernández Haro <afharo@gmail.com>
2020-10-05 16:16:07 +03:00
Sébastien Loix
519d4905bc
[Mappings editor] Fix app crash when selecting "other" field type (#79434) 2020-10-05 15:15:38 +02:00
Alejandro Fernández Haro
43493bb0d9
[/api/stats] Add documentation + small improvement (#79330)
Co-authored-by: Christiane (Tina) Heiligers <christiane.heiligers@elastic.co>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Ahmad Bamieh <ahmadbamieh@gmail.com>
2020-10-05 12:40:00 +01:00
Alexey Antonov
3ff90ce709
[Discover] "View surrounding documents" encodes spaces in filters (#79283)
* [Discover] "View surrounding documents" encodes spaces in filters

Closes: #72958

* fix CI

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2020-10-05 14:34:31 +03:00
Marta Bondyra
ce97982522
[Lens] refactor DimensionContainer and fix flyout bug (#79277) 2020-10-05 12:41:09 +02:00
Alexey Antonov
4db22034d7
[Vega] Maps still experimental (#79114)
* [Vega] Maps still experimental

* fix TS issues

* cleanup

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2020-10-05 12:29:51 +03:00
Pierre Gayvallet
1e9135c0e5
[GS] Show all applications when opening the search bar (#78741)
* increase default number of results to show all apps

* fix circuit breaker

* fix ut

* add unit test
2020-10-05 11:04:25 +02:00
Spencer
9e1c44fcc0
add core-js production dependency (#79395)
Co-authored-by: spalger <spalger@users.noreply.github.com>
2020-10-04 21:33:12 -07:00
Joe Portner
caa5da26f0
Add support for sharing saved objects to all spaces (#76132) 2020-10-04 23:28:49 -04:00
Yuliia Naumenko
1d9a2a4492
[Alerting UI] Display a banner to users when some alerts have failures, added alert statuses column and filters (#79038)
* Added ui for alert failures banner

* Added UI for alerts statuses

* Adjusted form

* Added banned on the details page

* Fixed failing intern. check and type checks

* Added unit test for displaying alert error banner

* Fixed type check

* Fixed due to comments

* Changes due to comments

* Fixed due to comments

* Fixed text on banners

* Added i18n translations
2020-10-04 15:32:05 -07:00
Mikhail Shustov
5cc945f9e8
load js-yaml lazily (#79092) 2020-10-04 21:10:19 +02:00
Brian Seeders
acedb35033 skip flaky suite (#77278) 2020-10-03 21:07:45 -04:00
Paul Tavares
e859fe7c65
Fix agentPolicyUpdateEventHandler() to use app context soClient for creation of actions (#79341)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2020-10-03 19:24:39 -04:00
Angela Chuang
513ebb50f9
[Security Solution] Untitled Timeline created when first action is to add note (#78988)
* init tests

* Untitled Timeline created

* remove console

* fix from server side

* set timeline status to draft if created by saving notes

* add unit test

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-10-03 17:50:23 +01:00
Frank Hassanabad
6da7dc8695
[Security Solutions][Detection Engine] Updates the edit rules page to only have what is selected for editing (#79233)
## Summary

Before when you would edit rules you get all the rules as disabled but you cannot switch between them in edit mode as it's already a rule you created:
<img width="1063" alt="Screen Shot 2020-10-01 at 5 06 18 PM" src="https://user-images.githubusercontent.com/1151048/94872518-0bdaba00-040a-11eb-8b7d-3b3a59980e99.png">

After, now we remove those cards and only show the card of the rule type you're editing:
<img width="1074" alt="Screen Shot 2020-10-02 at 6 29 48 PM" src="https://user-images.githubusercontent.com/1151048/94978954-50835580-04dd-11eb-9e08-8e473fc216bf.png">

Changes the card's icon placement and text.

Before:
<img width="1098" alt="Screen Shot 2020-10-02 at 9 27 44 AM" src="https://user-images.githubusercontent.com/1151048/94979008-9dffc280-04dd-11eb-8bce-88cd49b063a8.png">

After:
<img width="1190" alt="Screen Shot 2020-10-02 at 6 31 01 PM" src="https://user-images.githubusercontent.com/1151048/94979005-95a78780-04dd-11eb-92ec-e81bc3ce436e.png">

Fixes the Schedule/Actions and weirdness with CSS.
Before:
<img width="588" alt="Screen Shot 2020-10-02 at 5 42 09 PM" src="https://user-images.githubusercontent.com/1151048/94979030-c5568f80-04dd-11eb-9c91-683d75dc37da.png">
<img width="516" alt="Screen Shot 2020-10-02 at 5 42 05 PM" src="https://user-images.githubusercontent.com/1151048/94979035-c8ea1680-04dd-11eb-9049-120c9d676b1a.png">

After:
<img width="1099" alt="Screen Shot 2020-10-02 at 5 42 51 PM" src="https://user-images.githubusercontent.com/1151048/94979038-d0112480-04dd-11eb-8a2a-8eb314023669.png">

<img width="1067" alt="Screen Shot 2020-10-02 at 5 42 57 PM" src="https://user-images.githubusercontent.com/1151048/94979040-d30c1500-04dd-11eb-85ab-a09e4def6adb.png">

### Checklist

Delete any items that are not applicable to this PR.

- [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
- [ ] This was checked for [keyboard-only and screenreader accessibility](https://developer.mozilla.org/en-US/docs/Learn/Tools_and_testing/Cross_browser_testing/Accessibility#Accessibility_testing_checklist)
- [ ] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server)
- [ ] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers)

### For maintainers

- [ ] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
2020-10-03 09:08:02 -06:00
Patryk Kopyciński
8a8066ffe8
Cleanup yarn.lock from duplicates (#66617) 2020-10-03 11:53:03 +02:00