Commit graph

16281 commits

Author SHA1 Message Date
Spencer
90e2aa001b
[savedObjects] Use index template (#14271)
* [es][savedObjects/index] put template on each savedObject write

The elasticsearch plugin currently checks for the Kibana index on each iteration of the healthCheck, and creates it if it does not exist. This removes that step from the healthCheck and instead, before each savedObject is written to elasticsearch, ensures that Elasticsearch has the necessary index template should the write result in index creation.

The healthCheck still has the `patchKibanaIndex()` logic, which checks the type in the Kibana index and adds any missing types. This step now does nothing when the Kibana index does not exist, and does what it has always done when it does.

* [ftr] remove unused kibanaIndex service

(cherry picked from commit b1ef897dafeb6d43fe279776e44a9d793a389dc3)

* [savedObjects/integration] create now creates kibana index

* [es/healthCheck] remove use of format()

* [es/healthCheck/tests] use sinon assertions

* [es/patchKibanaIndex] test for kibana index missing behavior

* [savedObjects/errors] add tests for EsAutoCreateIndexError

* [savedObjects/config] deprecate and remove savedObjects.indexCheckTimeout config

* use dangling commas consistently

* [ui/error_auto_create_index] fix class names

* [ui/savedObjectsClient] no need to specify basePath

* [eslint] fix linting issue
2017-11-21 17:05:46 -07:00
Lukas Olson
cd1a49c392
Show nothing for match all query (#14644) 2017-11-21 15:53:39 -07:00
gchaps
28a736aa0b
Change may to might in Readme (#15099)
For localization, might is a better term than may.
2017-11-21 14:18:42 -08:00
Spencer
e1f2336674
Fix fieldFormat plugins (#14984)
* [ui/registry] allow custom provider invokation

* [fieldFormats] define custom formats as functions of FieldFormat class

* [fieldFormats/registerFieldFormat] call format creator to get class

* [fieldFormats/fieldFormatsService] fix tests

* [fieldFormats/registerFieldFormat] add tests

* [metrics/tickFormatter] fix import from test
2017-11-21 13:32:27 -07:00
Nathan Reese
16de1e863d
feature directory copy (#15047)
* feature directory copy

* update home page copy

* icons - ya

* saved objects icon
2017-11-21 13:24:59 -07:00
Nathan Reese
c584123abe
IndexedArray - ignore case when ordering array (#15069)
* update IndexedArray sorting to ignore case

* remove _.cloneDeep because it removes functions from objects

* use slice to avoid sorting original array

* use spread operator for copying arrays

* Convert all values into strings to avoid complicated logic
2017-11-21 13:24:45 -07:00
Stacey Gammon
45eaa09b9a
add some new tests that the uiState migration in the url will benefit from (#15063) 2017-11-21 15:07:58 -05:00
Peter Pisljar
4e982c0a6d
Introduce lab mode for visualizations (#15050)
* apply patch

add styling

remove cruft

split up concept of experimental and labs

adjust wording

* improve wording

* improve wording & punctuation. remove concept of feedback-url

* remove duplicate labeling between labs/experimental; resolve some typos

* merging isExperimental and isLabs flags to a stage setting

* adding the option to override feedback message back (and improving it)

* updating the docs

* change text labs to lab

* visualize:enableLabsVisualizations to visualize:enableLabs

* fixing github link
2017-11-21 20:49:24 +01:00
Tim Roes
6e1faea678
Adding scope to all table headers, fix #12401 (#15079)
* Add scope for all th in Kibana

* Add scope to <th> in ui framework

* Update jest snapshots with scope

* Fix wrong usage of colgroup
2017-11-21 20:48:58 +01:00
Tim Roes
d4442e78d7
Fix Kibana crashing when resizing a tag cloud too small (#15001)
* Don't allow d3-cloud to run on 0 size, fix #14833

* Add test that validates correct resizing
2017-11-21 20:48:26 +01:00
Peter Pisljar
60b58a0a50
fixing gauge update logic so it wont break tsvb (#15076)
* updating gauge/metric to new version

* fixing, tests were failing
2017-11-21 20:21:01 +01:00
Peter Pisljar
f22cd98825
removing more tile map tests which are flaky (#15082) 2017-11-21 19:59:30 +01:00
Stacey Gammon
8bb0c87684
Hide all panel titles option at the dashboard level (#15006)
* Hide all panel titles option at the dashboard level

* Hide panel titles in edit mode too
2017-11-21 11:51:35 -05:00
Jonathan Budzenski
ace0173adf
Adds task to export a CSV of all dependencies (#15068)
* Adds task to export a CSV of all dependencies

Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>

* Fixes tests and changes argument name to `out`

Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>

* Uses csv as argument for output file

Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>

* Removes unused columns

Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>

* [license csv] Fetch all licenses by default, add release flag to only generate release dependencies
2017-11-21 10:29:12 -06:00
Tim Roes
db7f9a1f64
Make sorting and resizing the chart in TSVB keyboard accessible, fix #14343 (#15058)
* Allow resizing charts via keyboard

* Use React updater function

* Allow sorting of series via keyboard
2017-11-21 09:15:43 +01:00
Peter Pisljar
c56360b908
Improve Region Maps for use without network connection (#15056)
* enable turning on/off of warnings

* add tooltip

* add server setting so users can opt out of connecting to the EMS service

* replace WMS options with custom directive, so we can reuse it in region maps

* add wms settings form to Region Map

* no need to recreate map after leaflet upgrade

* add WMS map to region map

* linting issues

* fix rebase

* improve wording

* add global config

* fix typo
2017-11-21 08:27:39 +01:00
Spencer
319832774a
[dashboard/functionalTests] stabilize initialization ordering (#15031) 2017-11-20 17:01:41 -07:00
Spencer
95329c581f
[precommit hook] add dev script (#14890)
* [precommitHook] move to dev script

* [eslint] fix lint error

* [dev/eslint] do simply boolean checks first

* [dev] use shared REPO_ROOT constant

* [dev/File] precompute relative/ext of path

* [dev/eslint] fix relative import

* [dev/eslint] fix typos

* [grunt] remove unused run:eslintStaged config

* [dev/run] only create log if we are going to use it

* [dev/run/isFailError] ensure return value is Boolean

* [dev/precommitHook] use less intermediate vars
2017-11-20 14:22:24 -07:00
Nathan Reese
cf602c60ff
make react route finer grained so other apps don't route to home page while angular is routing to those apps (#15059) 2017-11-20 11:57:47 -07:00
Stacey Gammon
39faeaa73e
Reactify full screen mode placeholder and remove from scope (#14886)
* Reactify full screen mode placeholder and remove from scope

With the toggle in react, no need to store it on scope.

* Simplify implementation by bringing in chrome.setVisible internal to the react placeholder

* rename FullScreenModePlaceholder => ExitFullScreenButton

* div => KuiButton

* Add jest tests for exit full screen button

* Use native Object.values.map instead of loadash _.map

* get rid of unnecessary return value
2017-11-20 12:51:53 -05:00
Stacey Gammon
856d012b46
ensure time picker open in retry loop (#15034)
* ensure time picker open in retry loop

* clean up isTimepickerOpen to use testSubjects.exists
2017-11-20 09:55:28 -05:00
Peter Pisljar
b03eac4376
removing failing tilemap tests (#15048) 2017-11-20 13:18:06 +01:00
Stacey Gammon
d80ff83bdc
Fix issue with debounce and a quick page switch (#15045) 2017-11-18 10:15:33 -05:00
Stacey Gammon
337def12bd
Fix mistakes added in bwc url test PR (#15038)
* Fix mistakes in bcc tests

* Correct data-test-subj name
2017-11-17 18:06:27 -05:00
Nathan Reese
810345682c
Set timeout and terminate_after parameters when fetching terms for Input Controls (#14977)
* set parameters like suggestions api

* provide timeout and terminate_after in initial state instead of using search_source set

* remove shard_size param and add comment about needed to replace searchsource with suggestions API
2017-11-17 16:04:52 -07:00
Stacey Gammon
57d64bf13b
Fixes https://github.com/elastic/kibana/issues/14908 (#15003) 2017-11-17 17:50:31 -05:00
Spencer
237ee635a4
[server/rootRedirect] remove browser-based redirect (#14698)
* [server/rootRedirect] remove browser-based redirect

With Kibana 4.2 we added the /app/kibana portion of the URL. This introduced a breaking change for URLs from 4.0-4.1, which required a redirect from '/#discover' to '/app/kibana#discover', but we still have the `defaultRoute` parameter, which meant that we needed to distinguish between `/` and `/#discover`. This is impossible on the server alone, unfortunately, so we had to do the redirect in the browser.

We are a long way from Kibana 4.2 at this point, and I think it's time we reduce the number of moving parts and just rely on the server for redirection.

* [server/rootRedirect] test location header
2017-11-17 15:33:58 -06:00
Stacey Gammon
7152d334cf
Add BWC url tests for 6.0 (#15033)
Also adds some stabilization by refactoring some retries and
expectations.
and fixes a bug that snuck in between two PRS where the pie slice css
changed.
2017-11-17 14:59:16 -05:00
Spencer
60298ec8b2
[ftr] default window size (#14834)
* [ftr/mocha] revert Mocha UI assigments after loading test files

* [ftr] add beforeTopLevelSuite and afterTopLevelSuite lifecycle hooks

* [ftr] add defaultWindowWidth and defaultWindowHeight options

Adds two configuration parameters to the functional test runner which
will set the windowSize before running the tests in any file and
restores the original window size when the tests complete.

Individual test files can set the windowSize within its own before() or
beforeEach() handlers using the same `command.setWindowSize()` command.

* [ftr/assignmentProxy] use better naming

* [ftr] restore initial window size after each suite

* [ftr] improve error message for unexpected suite definitions

* [ftr/remote] remove configuration option, rely on suite-level changes

* [ftr] fix stack manipulation order

* [ftr/remote] write tests for window size management
2017-11-17 11:15:02 -06:00
Nathan Reese
8f1aa33604
give info msg instead of error msg when no default index pattern (#15010)
* give info msg instead of error msg when no default index pattern

* fix tests

* use _.get instead of _.has plus turnary operator
2017-11-17 08:58:28 -07:00
Stacey Gammon
de1b98cdb7
Add a couple tests with queries and saved searches linked to visualizations (#14878)
* Add a couple tests with queries and saved searches linked to visualizations

Fix issue when edit link is clicked too soon and embeddable hasn't finished loading

* attempt to fix flakiness

* remove duplicate lines
2017-11-17 10:24:08 -05:00
Tim Roes
be54f367e9
Remove ready:vis and application.load event (#14988)
* Remove ready:vis event

* Remove application.load event

* Remove commented code

* Fix comment

* Fix broken indentation
2017-11-17 10:46:02 +01:00
Peter Pisljar
5793410a35
pie chart labels (#12174)
* pie labels

* add simple unit test

* fixing dashboard test

* fixing basedo on review

* simplifying conflict resolution

* removing unused code

* cleanup code

* minor changes based on review

* updating option templates to match new design

* updating truncate_labels to work with chars instead pixels
2017-11-17 09:57:02 +01:00
Tim Roes
1d8d835ab7
[Accessibility] Load angular-aria for kibana module (#14969)
* Load angular-aria for kibana module

* Fix indentation

* Add documentation
2017-11-17 09:33:11 +01:00
Nathan Reese
50f708f47f
[timelion] trim number of colors when there are more colors than gradient stops (#14906)
* trim number of colors when there are more colors than gradient stops

* simplify if/else logic as suggested by timroes
2017-11-16 14:41:13 -07:00
Stacey Gammon
c2c1b51be8
Add a feature for custom panel titles (#14831)
* Add a feature for custom panel titles

* Add tests and put back data-test-subjs

* sync with master and add padding to form

* UI/UX cleanup

- add enter on close functionality
- make reset title a link instead of a button
- Push css to visualizations instead of the panel. This means
background colors will be flush to the panel.  Override for tile maps
which apparently need it (yet region maps don’t for some reason??)

* Fix refactor miss from merge

* whoops, put block display back to make link fall to bottom

* Undo accidental delete visualization name change

* Color top pop over arrow correctly

* Use naming Options and Customize Panel

* update jest snapshot

* Use custom panels for data-title attributes
2017-11-16 14:53:22 -05:00
Lisa Cawley
39c02c75f9
[DOCS] Add placeholder for 7.0.0-alpha1 Release Notes (#14585)
* [DOCS] Added 7.0.0-alpha1 Release Notes

* [DOCS] Removed X-Pack text from Release Notes
2017-11-16 10:09:24 -08:00
Chris Roberson
b20bdae627
[Management] Ensure non alphanumeric characters do not affect index pattern searching (#14973)
* - Fix issue with non alphanumeric characters affecting index pattern search
- Restructure and add tests

* More tests
2017-11-16 11:42:28 -05:00
Kim Joar Bekkelund
b1ae3f6125
Revert "Remove 401 error wrapping (#14324)" (#14996)
This reverts commit f167a00543.
2017-11-16 17:37:12 +01:00
Brandon Kobel
8d4d56a0b0
Sharing - Preserve Layout (#14707)
* Adding method to expose the dashboard app container size to reporting

* Adding a data-shared-items-container attribute to the viewport

* Making visualize tell us how large they are

* Removing the controller methods that returned the item size

* Moving the sharing attributes to be on the actual elements, so we can
figure out their dimensions

* Passing the savedObj to the Visualize elements adding the data- attrs

* Adding the title/description to the Dashboard

* Dispatching the initial title/description

* Reverting some accidental whitespace changes

* Fixing metadata selectors

* Adding newline at end of file...

* Putting the $emit('renderComplete') back

* Passing only the savedObj to the Visualize Editor Controller

* Setting the description on the $scope.vis so we don't have to pass the
SavedObj

* Reverting more TSVB title/description code

* Removing savedObj from scope

* Putting $scope.vis back to vis
2017-11-16 08:02:15 -05:00
Kim Joar Bekkelund
f167a00543
Remove 401 error wrapping (#14324) 2017-11-16 12:06:37 +01:00
Nathan Reese
25ed343633
[home] feature directory - make icon and description be part of href (#14947)
* make icon and description be part of feature href

* do not change background color - just underline title
2017-11-15 19:48:52 -07:00
CJ Cenizal
b0985f9f2c
Add (MIT AND Zlib) to acceptable licenses. (#14985) 2017-11-15 17:12:32 -08:00
Lisa Cawley
85293f9750
[DOCS] Remove X-Pack release note reference (#14983) 2017-11-15 15:22:03 -08:00
dave.snider@gmail.com
fb8c72e802
Fix some accessibility coloring issues (#14972)
Fixes table contract and some discover contrast issues.
2017-11-15 14:41:35 -08:00
Stacey Gammon
d7c8e76cfb
Stop listening for ready:vis to fetch from courier (#14848)
* Stop listening for ready:vis to fetch from courier

This means saved searches will get requested in their own msearch but
this actually improves dashboard loading because waiting on saved
searches can slow down a whole dashboard.  Splitting up visualizations
from saved searches is an improvement and it cleans up the code, so I
think we should do this.

* Push courier.fetch into search_embeddable_handler
2017-11-15 11:31:39 -05:00
Tim Roes
815cfe1069
[Accessibility] Refactor font slider for accessibility (#14817)
* Refactor font slider for accessibility, fix #12905

* Limit input fields min/max values

* Prevent crossing of min/max values

* Revert "Prevent crossing of min/max values"

This reverts commit 575dfac0b5.

* Use UI framework classes
2017-11-15 14:36:18 +01:00
Spencer
5cddc10077
Upgrade to eslint 4 (#14862)
* [eslint] upgrade to 4.10.0

* [eslint-config-kibana] limit jest config to jest test files

* [ui_framework] remove trailing comma from rest-spreads

* [dashboard/tests] tag jest helpers with .test.js suffix

* explicitly import expect.js where used

* [eslint] apply auto-fixes

* [eslint] manually add/wrap some parens for compliance

* [npm] point to local packages for testing/review

* [jest] remove .test extension from jest helpers

* [ui_framework] fix trailing comma removal from 3bc661a1c8

* [packages] upgrade eslint packages
2017-11-14 18:16:59 -07:00
Nathan Reese
94b2b324aa
Timelion typeahead for argument values (#14801)
* timelion argument value suggestions for legend function

* update functions with argument value suggestions

* use async/await instead of promise resolve/reject for suggestion generation

* lookup value suggestions for es index and timefield arguments

* custom handlers for es metric and split arguments

* update suggestions unit test

* remove duplicate code from insertSuggestion switch

* refactor arg_value_suggestions to provide three methods instead of single getSuggetions method

* template literal

* update es index argument desc to include note about type ahead support
2017-11-14 10:56:16 -07:00
Spencer
a3014d7a63
[eslint] add eslint dev script (#14889) 2017-11-14 10:11:59 -07:00