Commit graph

36613 commits

Author SHA1 Message Date
Mikhail Shustov 90f76994d2
Update typescript eslint to v4.8 (#83520) (#83677)
* update deps

* update rules

use type-aware @typescript-eslint/no-shadow instead of no-shadow. do not use no-undef, rely on TypeScript instead

* fix or mute all lint errors

* react-hooks eslint plugin fails on ? syntax

* fix wrong typings in viz

* remove React as a global type

* fix eslint errors

* update version to 4.8.1

* fix a new error
2020-11-18 20:50:46 +01:00
Zacqary Adam Xeper dd3ea9c5d0
[7.x] [Metrics UI] Add Process tab to Enhanced Node Details (#83477) (#83668) 2020-11-18 12:37:15 -06:00
Pierre Gayvallet 5d0917fb24
SO Tagging: fix flaky test and re-enable it (#82930) (#83653)
* fix flaky test and re-enable it

* wait for table to load before to perform operations

* move everything out of ciGroup2 for flaky test runner

* add debug block for flaky runner

* use correct vis name

* remove test sync

* Revert "move everything out of ciGroup2 for flaky test runner"

This reverts commit db86c3b5
2020-11-18 18:51:03 +01:00
Chris Cowan 3e6f716d42
[Metrics UI] Converting legend key to optional (#83495) (#83648)
* [Metrics UI] Converting legend key to optional

* Adding check and default to legend component
2020-11-18 10:12:03 -07:00
Candace Park 5c7421c5dd
[Security Solution][Endpoint][Admin] Malware user notification is a platinum tiered feature (#82894) (#83643) 2020-11-18 12:05:17 -05:00
Dmitry d6d73ef41c
update chromedriver dependency to 87 (#83624) (#83636) 2020-11-18 17:22:16 +01:00
Aaron Caldwell ac31e639e1
[7.x] [Maps] Fix threshold alert issue resolving nested fields (#83577) (#83605)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2020-11-18 07:46:52 -07:00
Diana Derevyankina 026de8ee8f
[TSVB] Y-axis has number formatting not considering all series formatters in the group (#83438) (#83630)
* [TSVB] Y-axis has number formatting not considering all series formatters in the group

* Replace check for percent with a check for same formatters in common

* Remove unnecessary series check
2020-11-18 17:42:05 +03:00
Sébastien Loix 0323d3b583
[7.x] [Runtime fields] Editor phase 1 (#81472) (#83616)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: spalger <spalger@users.noreply.github.com>
# Conflicts:
#	packages/kbn-optimizer/limits.yml
2020-11-18 14:58:47 +01:00
Phillip Burch 46e2eb4b9b
Don't show loading screen during auto-reload (#83376) (#83584)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2020-11-18 07:49:43 -06:00
Alejandro Fernández Gómez f1ef98ee84
[7.x] [Logs UI] Update <LogStream /> internal state when its props change (#83302) (#83623)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2020-11-18 14:08:50 +01:00
Pierre Gayvallet b33823c7f4
Add tag bulk action context menu (#82816) (#83618)
* add the delete tag bulk action

* add unit tests for bulk delete

* fix duplicate i18n key

* add RBAC test on bulk delete

* add functional tests

* self review

* design nits

* add maxWidth option for confirm modal and add missing doc

* change bulk delete confirm modal max width

* add more missing doc

* only show loading state when performing the bulk delete

* use spacer instead of custom margin on horizontal rule

* use link instead of button to remove custom styles

* remove spacers, just use styles

* add divider when action menu is displayed

* set max-width for single delete confirm

* a11y fixes

* address nits

* add aria-label to delete action

Co-authored-by: Michail Yasonik <michail.yasonik@elastic.co>

Co-authored-by: Michail Yasonik <michail.yasonik@elastic.co>
2020-11-18 12:25:11 +01:00
Alejandro Fernández Haro 1e8882a23e
[7.x] [UsageCollection] Expose KibanaRequest to explicitly opted-in collectors (#83413) (#83615) 2020-11-18 10:55:51 +00:00
Dima Arnautov 3a2741f762
[ML] Persisted URL state for the Data frame analytics jobs and models pages (#83439) (#83574)
* [ML] support table settings from the URL state

* [ML] fix management page

* [ML] models page support

* [ML] update URL generator

* [ML] rename id column

* [ML] update types and tests

* [ML] fix id column name and field

* [ML] remove legacy functions

* [ML] set id key for the job query text

* [ML] fix id column rendering

* [ML] ad jobs with usePageUrlState

* [ML] update unit tests for solutions
2020-11-18 10:18:19 +01:00
Tiago Costa b25d019122
chore(NA): remove usage of unverified es snapshots (#83589) (#83604)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2020-11-18 04:19:53 +00:00
Nathan Reese 46bace45a7
[7.x] [Maps] saved object tagging (#83197) (#83509)
* [Maps] saved object tagging (#83197)

* add tag selector to save modal

* save tag references onSave

* populate tags when unwrapping attributes

* tslint

* update listing page to show tags

* fix data-test-subj id in functional tests

* i18n cleanup

* tslint

* remove unused import

* use listingTable service for functional tests

* tslint and fix mvt grid layer functional test

* review feedback

* add tags to all privileges and add test user to find, delete, get, get_all, and update tests

* move functions to module scope

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

* mappings.json

* add map saved object mapping

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2020-11-17 20:00:38 -07:00
Greg Thompson ce49c2ace5
[7.x] Upgrade EUI to v30.2.0 (#82730) (#83588)
* Upgrade EUI to v30.2.0 (#82730)

* eui to v30.2.0

* src snapshot updates

* x-pack euipanel snapshot updates

* x-pack external link updates

* security_solution_cypress external link text

* clean up

* fix bad merge resolution
2020-11-17 17:22:13 -07:00
IgorG 548b5c0547
[7.x] New events resolver (#82170) (#83443)
* New events resolver (#82170)

* Added Test for event.library

* renamed data directry and gzip data file

* rename expectedData file

* Changes per Charlie request

* Changes for the enable_APM-ci branch

* Update resolver.ts

* Added comment per Charlie request

* Update resolver.ts

* Added Alert Test for Resolver and fix for the APM enabled Run fail

* Added Alert Test for Resolver and fix for the APM enabled Run fail

* removed commented out code

* Fixing CI fail

* Fixing CI fail

* Removed Alert Resolver test

* aAdding Alert test back

* Adding Alert test back

* Adding Alert test back

* Adding info log for debuging

* Adding info log for debuging

* Adding info log for debuging

* Adding info log for debuging

* Adding info log for debuging

* Adding info log for debuging

* adding one more verification for Data

* stripedd Data file

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

* Update hosts_page.ts

* Update resolver.ts

* Update resolver.ts

* Update hosts_page.ts

* Update resolver.ts

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2020-11-17 15:13:38 -08:00
Tiago Costa 8735b4626b
Functional tests - fix esArchive mappings with runtime fields (#83530) (#83581)
* Functional tests - fix esArchive mappings with runtime fields

* Modify jenkinsfile to run with unverified ES snapshot

* Adjust security index fields test for the new mapping structure

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Robert Oskamp <robert.oskamp@elastic.co>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2020-11-17 22:14:32 +00:00
Tiago Costa b4b3e0ca40
[docker] removes workaround for missing crypto-policies-scripts subpackage (#83455) (#83579)
* Revert "[build] Use 8.2 tag of ubi-minimal (#82688)"

This reverts commit a89176e265.

* chore(NA): remove workaround for missing crypto-policies-scripts subpackage

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2020-11-17 21:39:47 +00:00
Jonathan Budzenski 242eae05ff [rpm] Create default environment file at "/etc/sysconfig/kibana" (#82144)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2020-11-17 14:13:21 -06:00
Quynh Nguyen 5c23f74cdd
[7.x] [ML] Improve support for script and aggregation fields in anomaly detection jobs (#81923) (#83569)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2020-11-17 13:27:21 -06:00
Jason Stoltzfus 88206b28a8
[App Search] Added all Document related routes and logic (#83324) (#83548) 2020-11-17 13:59:18 -05:00
Elizabet Oliveira 5e51b8ec04
[Maps] Improve icons for all layer types (#83503) (#83555)
* Improve icons for all layer types

* EMS boundaries icon

* Adding tracks layer icon
2020-11-17 18:08:25 +00:00
Julien Guay 69e869abf3 adds xpack.security.authc.selector.enabled setting (#83551)
setting xpack.security.authc.selector.enabled introduced in 7.7.0 by https://github.com/elastic/kibana/pull/53010 is currently missing for docker entrypoint script
2020-11-17 12:07:30 -06:00
Quynh Nguyen cb8f2641c3
[7.x] [ML] Add UI test for feature importance features (#82677) (#83556)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2020-11-17 11:48:17 -06:00
Melissa Alvarez 31d20f2697
Replace experimental badge with Beta (#83468) (#83553) 2020-11-17 12:46:09 -05:00
Tyler Smalley 5261a18797 skip flaky suite (#77279) 2020-11-17 09:37:39 -08:00
Shahzad 3935938d9e
[7.x] [Uptime] Mock implementation to account for math flakiness test (#83535) (#83550) 2020-11-17 18:08:40 +01:00
Yuliia Naumenko 4052c4c6a0
Used SO for saving the API key IDs that should be deleted (#82211) (#83547)
* Used SO for saving the API key IDs that should be deleted and create a configuration option where can set an execution interval for a TM task which will get the data from this SO and remove marked for delete keys.

* removed invalidateApiKey from AlertsClient

* Fixed type checks

* Fixed jest tests

* Removed test code

* Changed SO name

* fixed type cheks

* Moved invalidate logic out of alerts client

* fixed type check

* Added functional tests

* Fixed due to comments

* added configurable delay for invalidation task

* added interval to the task response

* Fixed jest tests

* Fixed due to comments

* Fixed task

* fixed paging

* Fixed date filter

* Fixed jest tests

* fixed due to comments

* fixed due to comments

* Fixed e2e test

* Fixed e2e test

* Fixed due to comments. Changed api key invalidation task to use SavedObjectClient

* Use encryptedSavedObjectClient

* set back flaky test comment
2020-11-17 08:32:45 -08:00
Shahzad 222cbaa643
[7.x] [Uptime] Fix monitor list down histogram (#83411) (#83543) 2020-11-17 16:45:21 +01:00
John Schulz b2a7efe371
[bundle optimization] Update to semver 7.x to get tree-shaking (#83020) (#83542)
## What's changed in this PR
### Update to latest available `semver`: `7.3.2`
 * `semver` 5.x pulls in the entire library in one large file (~38k uncompressed / ~9k gz), when we might only use 1-2K.
 * `semver` 7.0+ supports tree-shaking: https://github.com/npm/node-semver/blob/master/CHANGELOG.md#700

### Update paths to only import individual function(s) used instead of the entire library
  * Getting the smaller bundle requires a different import style [as shown in the docs](https://github.com/npm/node-semver#usage)
  * Only changed code in `public` & `common` folders; not `server`. We could also update `server` as well for consistency, but I skipped because the new import style is more verbose and the filesize didn't seem as important on the server

### Results
The build stats show a 10K+ improvement for initial page bundles https://github.com/elastic/kibana/pull/83020#issuecomment-724724432

| id | [before](c6afc47f32) | [after](213bb52a8c) | diff |
| --- | --- | --- | --- |
| `ingestManager` | 386.2KB | 373.9KB | -12.3KB |
| `telemetry` | 63.5KB | 50.1KB | -13.5KB |
| `upgradeAssistant` | 74.5KB | 60.5KB | -14.0KB |
| total |  |  | -39.7KB |

### The import paths look odd. Are they required?
I agree and, no, they're not strictly required. If you'd like me to revert to the prior style just drop a comment and I'll undo them.

The caveat is that the current style (in `master` & this PR) pulls in the entire `semver` library. In 7.x that added ~15K to the initial size. Some more details in the comments: https://github.com/elastic/kibana/pull/83020#issuecomment-724859130

### Possible issues
Moving 2 major versions. We're currently on 5.7 and the latest available is 7.3. 
  * changelog says 5.x (our current) to 6.0 should be safe: https://github.com/npm/node-semver/blob/master/CHANGELOG.md#60
  * There 6.x & 7.x changes all appear to be new features or bugfixes around the `includePrerelease` flag added in 5.6, but I'm not sure if those "fixes" will break existing code
    * https://github.com/npm/node-semver/blob/master/CHANGELOG.md#613
    * https://github.com/npm/node-semver/blob/master/CHANGELOG.md#722

### Stats / screenshots
generated with `node scripts/build_kibana_platform_plugins.js --profile --focus=ingestManager`
<details><summary><b>Ingest Manager in `master`</b>: imports entire `semver` lib, totals 40k+, only 1 large file (orange arc below)</summary>

<img width="972" alt="Screen Shot 2020-11-09 at 6 50 23 PM" src="https://user-images.githubusercontent.com/57655/98666188-a50ac380-231a-11eb-9b8a-6ca784752714.png">
</details>

<details><summary><b>Ingest Manager in PR after upgrade to 7</b>: still imports entire lib. file size *increased* to ~60k, but now individual files are imported (orange arcs below)</summary>
<img width="825" alt="Screen Shot 2020-11-09 at 5 46 30 PM" src="https://user-images.githubusercontent.com/57655/98666355-e602d800-231a-11eb-803f-bc04beb4eaf1.png">
<img width="963" alt="Screen Shot 2020-11-09 at 5 47 06 PM" src="https://user-images.githubusercontent.com/57655/98666357-e69b6e80-231a-11eb-92d3-c66904f92c30.png">
</details>

<details><summary><b>Ingest Manager in PR after changing `import`s:</b> total imported size down to ~20k. Can see individual imported files</summary>
<img width="926" alt="Screen Shot 2020-11-10 at 6 10 23 AM" src="https://user-images.githubusercontent.com/57655/98667058-e64fa300-231b-11eb-9690-5e36ed6475e0.png">
<img width="895" alt="Screen Shot 2020-11-10 at 6 10 53 AM" src="https://user-images.githubusercontent.com/57655/98667059-e780d000-231b-11eb-8abf-98d8bdbcf061.png">
</details>

### Checklist

- [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
2020-11-17 10:42:33 -05:00
Jonathan Budzenski c858019138 Move src/legacy/server/keystore to src/cli (#83483)
Currently keystore parsing is in the legacy http server folder.
Keystore references end in src/cli so instead of migrating to
core/server the I opted for the closest fit in the CLI folder.

Closes #52107
2020-11-17 09:22:32 -06:00
Jason Stoltzfus 112e3c75b5
[Enterprise Search] Added a shouldShowActiveForSubroutes option (#83338) (#83540) 2020-11-17 09:58:36 -05:00
Vadim Dalecky 3a29b3b959
Clean up UI Actions Enhanced server plugin (#83442) (#83515)
* chore: 🤖 remove unused code

* refactor: 💡 don't pass plugin definition to a function

* perf: ️ fetch factory from registry only once
2020-11-17 15:28:39 +01:00
Matthias Wilhelm 47c7eccd0b
[Discover] Allow custom name for fields via index pattern field management (#70039) (#83536)
Co-authored-by: Matt Kime <matt@mattki.me>
2020-11-17 15:21:23 +01:00
Marco Liberati 583f757d39
[7.x] [Lens] Avoid unnecessary data fetching on dimension flyout open (#82957) (#83538)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2020-11-17 15:20:02 +01:00
ymao1 871df72597
[Alerting UI] Fix console error when setting connector params (#83333) (#83537)
* Fixing console errors

* Setting defaults for undefined inputs in text area/field with message variables

* Cleanup

* Cleanup

* Fixing pagerduty timestamp validation

* Fixing test

* Pagerduty params

* Reverting unnecessary changes
2020-11-17 09:16:10 -05:00
kaisecheng 3d9480298d
fix logstash central pipeline management test (#83281) (#83528)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2020-11-17 14:31:49 +01:00
kaisecheng a338220083
Update logstash pipeline management to use system index APIs (#80405) (#83526)
This change updates the logstash pipeline management plugin to use
pipeline management APIs in Elasticsearch rather than directly
accessing the .logstash index. In Elasticsearch 8.0, direct access to
system indices will no longer be allowed when using standard APIs.
Given this change, a new set of APIs has been created specifically for
the management of Logstash pipelines and this change makes use of the
APIs.

Co-authored-by: Kaise Cheng <kaise.cheng@elastic.co>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

ES:#53350
LS:#12291

Co-authored-by: Jay Modi <jaymode@users.noreply.github.com>
2020-11-17 14:31:13 +01:00
Dima Arnautov 7357680b1b
[ML] Update apidoc config with the Trained models endpoints (#83274) (#83534)
* [ML] fix apidoc annotations

* [ML] add trained models

* [ML] use full path to the apidoc-markdown package
2020-11-17 14:24:35 +01:00
Mikhail Shustov 2ed3cb4d5a
remove headers timeout hack, rely on nodejs timeouts (#83419) (#83533) 2020-11-17 14:20:11 +01:00
Dimitris Athanasiou 46b9db3d94
[7.x][ML] Update console autocomplete for ML data frame evaluate API (#83151) (#83527)
We have added evaluation for all types of data frame analysis
since the last update. This commit updates autocomplete accordingly.

Backport of #83151
2020-11-17 14:49:32 +02:00
nnamdifrankie b596ed9b00
[Security Solution]: add policy summary api (#81686) (#83488)
[Security Solution]: add policy summary api
2020-11-17 07:40:47 -05:00
James Gowdy 72933f6ccb
[ML] Additional job spaces initialization (#83127) (#83516)
* [ML] Additional job spaces initialization

* adding logs test

* updating integrations

* updating test text

* fixing logs jobs error

* fix bug with duplicate ids

* updating initialization log text

* fixing initialization text

* adding metrics overrides

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2020-11-17 12:27:55 +00:00
Thomas Watson 076b2cd9ff
Bump Node.js from 12.19.0 to 12.19.1 (#83452) (#83518) 2020-11-17 13:19:22 +01:00
Joe Reuter 495fc8b8e2
[Lens] Color in dimension trigger (#76871) (#83524) 2020-11-17 12:05:27 +01:00
Joe Reuter c0c398a185
create metric before bucket agg (#83432) (#83523) 2020-11-17 12:05:14 +01:00
Aleh Zasypkin 2997bc0229
[7.x] Upgrade nodemailer dependency (4.7.06.4.16). (#83517) 2020-11-17 11:13:47 +01:00
Bohdan Tsymbala 80e0153344
Btsymbala/registered av (#81910) (#83475)
* Moved out type for OperatingSystem and moved OS translations one level higher.

* Changed the translation to be consistent between trusted apps and policy.

* Unified translations of OS types between trusted apps and policy.

* Removed unused types.

* Added registered AV form section.

* Changed the property structure to match the format expected by endpoint.

* Fixed the visual alignment of titles in the form and added responsiveness.

* Updated snapshots.

* Moved out type for OperatingSystem and moved OS translations one level higher.

* Added config form heading component.

* Cleaned up translations.

* Fixed type error with initialization.

* Fixed error in trusted app creation form test.

* Removed the guard for now in favour of better initialization.

* Fixed the store test.

* Fixing functional test data.

* Added functional test config option to account for a custom header within security app.

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2020-11-17 11:10:57 +01:00