Commit graph

33698 commits

Author SHA1 Message Date
Clint Andrew Hall 91e4fd46f4
Enable exhaustive-deps; correct any lint warnings (#68453)
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-06-09 11:54:37 -05:00
Clint Andrew Hall 7c0f838aaf
[pre-req] Convert Workpad Config and state to TS (#68615) 2020-06-09 11:48:37 -05:00
Kaarina Tungseth 835964b346
Updated the Writing documentation section in CONTRIBUTING.md (#68434)
* Updated the Writing documentation section in CONTRIBUTING.md

* More changes
2020-06-09 10:43:24 -05:00
gchaps 4a38772764
[DOCS] Adds documentation for drilldowns (#68122)
* [DOCS] Adds documentation for drilldowns

* [DOCS] Incorporates review comments

* [DOCS] Fixes to text

* Updated gif sans nav bars

* [DOCS] Adds image of drilldowns and other tweaks to text

Co-authored-by: KOTungseth <kaarina.tungseth@elastic.co>
2020-06-09 08:23:58 -07:00
Alejandro Fernández Haro 6bb9e3fcf9
[Telemetry] telemetry.sendUsageFrom: "server" by default (#68071)
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-06-09 15:56:54 +01:00
Dima Arnautov 1160d08857
[ML] Transforms: Support sub-aggregations (#68306)
* [ML] WIP UI support for the sug-aggs

* [ML] extract sug-aggs from es config

* [ML] fix for range filter

* [ML] delete sub-aggregation

* [ML] isConfigInvalid

* [ML] fix actions, support parent agg

* [ML] update getAggConfigFromEsAgg

* [ML] unit tests

* [ML] SubAggsSection

* [ML] fix snapshot, add validation

* [ML] fix label capping

* [ML] rename Filter query label

* [ML] fix updateSubAggregation validation

* [ML] fix state update warning

* [ML] increase MAX_NESTING_SUB_AGGS

* [ML] functional tests for sub-aggregations

* [ML] change the tooltip message

* [ML] update functional tests

* [ML] fix typo
2020-06-09 16:13:01 +02:00
Yuliia Naumenko f6e93a19d3
Fixed pre-configured docs link points to the wrong page and functional tests configs (#68606)
* Fixed pre-configured docs link points to the wrong page and functional tests configs

* Fixed doc link
2020-06-09 07:00:31 -07:00
Jen Huang bc6aadd0fa
[Ingest Manager] Update queries from stream.* to dataset.* (#68322)
Resolves #67672

Part of https://github.com/elastic/package-registry/issues/491

See https://github.com/elastic/package-registry/pull/492 for package registry changes.

Updates existing queries to use `dataset.*` fields. from `stream.*` fields.

I looked at the EPM code paths for asset installation, and did not find anything that would need to be changed based on the above package registry changes. We don't hardcode anything specific for field names. The package information (i.e. [nginx package info](https://epr.elastic.co/package/nginx/0.1.2/)) is not affected by the current package registry changes.
2020-06-09 15:42:12 +02:00
CJ Cenizal 41af396259
Enable Watcher by default to fix bug in which Watcher doesn't render in the side nav (#68602) 2020-06-09 06:38:32 -07:00
CJ Cenizal 605b79e8ca
Convert Index Templates API routes to snakecase. (#68463)
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-06-09 06:36:56 -07:00
Devin W. Hurley 994dba102c
[SECURITY SOLUTION] [Detections] Add / Update e2e tests to ensure initial rule runs are successful (#68441)
* adds/modifies e2e tests to ensure find_status returns succeeded after rules are created, instead of just 'going to run'

* add documentation around newly created e2e tests explaining bug and specific regression to be on the lookout for if these start failing
2020-06-09 08:41:37 -04:00
John Schulz 974dcab917
[Ingest] OpenAPI spec file (#68323)
* All(?) routes
Lots have one or more things wrong but it's a start

* Some Agent-related models & routes.

Plus some examples for request and responses

* Ignore rule requring PascalCase interfaces
It's not an option to change interface name, afaict
lowercase matches the OpenAPI spec/key name

* Remove generated specs

* Fix misplaced schema

Response shape was listed as a request body

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-06-09 08:23:07 -04:00
Tiago Costa bebbd6d2c4
chore(NA): skip apis Endpoint plugin Endpoint policy api (#68638) 2020-06-09 12:24:30 +01:00
Peter Pisljar 0a73891714
bumping makelogs version to v6.0.0 (#66163) 2020-06-09 12:21:42 +02:00
Angela Chuang 88f252ac50
[SIEM] Add create template button (#66613)
* add template btn

* rename file

* unit test

* replace connector with useDispatch

* comments

* add disableTemplate

* rename flag

* fix types

* remove snapshot

* fix types

* add fix action

* move disableTemplate flag into constants

* fix types

* Fix timelineType

* button style

* unit test

* unit test

* fix types

* Update x-pack/plugins/siem/public/timelines/components/timeline/properties/create_timeline_btn.tsx

Co-authored-by: patrykkopycinski <contact@patrykkopycinski.com>

* fix unit test

* add unit test

* add unit test

* fix types

* fix tests

* fix unit

* fix i18n key

* remove snapshot

* fix crud

* fix crud

* fix unit

* fix tag

* fix unit

* disable template timeline

* Update use_create_timeline.tsx

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Co-authored-by: Patryk Kopycinski <contact@patrykkopycinski.com>
2020-06-09 11:20:36 +01:00
dependabot[bot] 9208708b53
Bump websocket-extensions from 0.1.3 to 0.1.4 (#68414)
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-06-09 06:14:02 -04:00
Robert Oskamp 004df98c87
[ML] Sample data modules - use event.dataset instead of index name (#68538)
This PR adds event.dataset to the Kibana ecommerce sample data and makes the ML modules for ecommerce and weblog sample data use event.dataset to recognize the modules and also as the corresponding datafeed query instead of looking for the index name.
2020-06-09 11:30:15 +02:00
Robert Oskamp 0b3391a8fd
[ML] Functional tests - fix job validation API test with maxModelMemoryLimit (#68501)
This PR fixes the job validation API integration test for the scenario that the test environment has xpack.ml.max_model_memory_limit set.
2020-06-09 11:28:43 +02:00
Robert Oskamp 5377dbb758
[ML] Functional tests - stabilize DFA job creation (#68495)
This PR stabilizes the classification and regression creation tests.
2020-06-09 11:25:59 +02:00
Stratoula Kalafateli 88754d2cb2
[TSVB] Allows the user to change the tooltip mode (#67775)
* Allows the user to select the tooltip mode

* Fix problem on new TSVB and add new field to schema

* Change default value on tooltip dropdown for the focused series option
2020-06-09 10:04:05 +03:00
Tiago Costa e74440b138
chore(NA): skip apis Endpoint plugin Endpoint alert API when data is in elasticsearch (#68613) 2020-06-09 03:50:27 +01:00
Tiago Costa bc5d8c20c1
chore(NA): skip endpoint Endpoint Alert Page: when es has data and user has navigated to the page (#68596) 2020-06-09 03:36:12 +01:00
Frank Hassanabad d99cf75814
[SIEM][Detection Engine] Converts from joi to use io-ts and moves the types to common (#68127)
## Summary
* https://github.com/elastic/siem-team/issues/646
* Converts the detection rules and REST to use io-ts
* Removes their joi counterparts
* Updates all tests to use it
* Fixes a bug with the risk_score that was being sent in as a string from the UI instead of a number
* Fixes a bug within the exactCheck validating where it can now accept null value types for optional body messages.
* Fixes a bug in the FindRoute where it did not send down fields from REST
* Changes the lists plugin to utilize the io-ts types from siem rather than having them duplicated.
* Makes some stronger validations
* Adds a lot of codecs

**Things to look out for:**

* Generic testing to ensure I didn't break something that was not part of the tests.
* Fix for the risk_score from string to number is in:
```
x-pack/plugins/security_solution/public/alerts/components/rules/step_about_rule/index.test.tsx
```
* Fix for the exact check (unit tests are written and added)
```
x-pack/plugins/security_solution/public/alerts/components/rules/step_about_rule/index.test.tsx
```
* Within all the types I added are there any misspelled things or copy-pasta mistakes with strings:
x-pack/plugins/security_solution/common/detection_engine/schemas/types
* Fix for `find_rules_route.ts:58`
```
x-pack/plugins/security_solution/server/lib/detection_engine/routes/rules/find_rules_route.ts
```

**Follow on things that this PR doesn't do we need to:**
* Add linter rule to forbid NodeJS code within common section
* The `[object Object]` formatter issues seen in the code such as:
```
// TODO: Fix/Change the formatErrors to be better able to handle objects
'Invalid value "[object Object]" supplied to "note"',
```
* Formatter issues such as: `'Invalid value "" supplied to ""'`
* Remove the hapi server object from lists plugin

### Checklist

Delete any items that are not applicable to this PR.

- [x] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios
2020-06-08 19:54:09 -06:00
Tiago Costa e49888f2ec
chore(NA): skip apis Endpoint plugin test metadata api POST /api/endpoint/metadata when index is not empty (#68586) 2020-06-09 01:31:33 +01:00
Jen Huang 299a6026fd
[Ingest Manager] Copy fixes (#68325)
* #68153 Change Elastic integrations to Integrations

* Fix copy casing

* #68152 Update create data source CTA copy

* #68166 Remove icon next to top-level navigation when user is on new Kibana navigation style

* Fix i18n

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-06-08 17:16:30 -07:00
Nathan L Smith d1ed207945
APM TypeScript improvements (#68572)
* Add `compilerOptions.noErrorTrunctation` to the tsconfig template
* Remove unused parameters

Not adding `noUnusedParamaters` to the tsconfig since we get too many hits from dependencies when running `tsc`. These do show up in the editor as warnings, though.
2020-06-08 17:56:06 -05:00
Spencer ab226f02ae
[kbn/pm] log levels (#68203)
Co-authored-by: spalger <spalger@users.noreply.github.com>
2020-06-08 15:53:16 -07:00
Jen Huang b39234ce80
#68163 Make footer messaging sticky to bottom of page (#68327)
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-06-08 15:20:36 -07:00
Phillip Burch e591aa99d3
Add timestamp context variable (#67482)
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-06-08 17:16:01 -05:00
gchaps 56ed61e303
[DOCS] Edits titles in Setup section for consistency (#68451)
* [DOCS] Fixes titles in Setup section for consistency

* [DOCS] Fixes to titles and orders of docs in Set up
2020-06-08 14:46:26 -07:00
gchaps de62abbd4e
[DOCS] Fixes typo in Console docs (#68536) 2020-06-08 14:45:55 -07:00
Josh Dover f090775280
Add url overflow handling to KP (#67899) 2020-06-08 15:03:41 -06:00
Jonathan Budzenski 1e45e988e8
[deb/rpm] manage pid folder (#68262)
* [deb/rpm] manage pid folder

This adds a tmpfiles.d configuration file for systemd users, and changes
the path for both systemd and sysv to /var/run/kibana/kibana.pid.  pid
file generation is left unmodified for a future pr.

* cleanup

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-06-08 14:25:27 -05:00
Justin Kambic 858523eac6
[Uptime] Edit uptime alerts (#68005)
* Extract store creation to plugin start, add redux providers to alert registration.

* Update unit test.

* Move alert registration to `setup` function.

* Allow external editing of uptime client alert types.

* Move alert initialization back to `start`.

* Clean up interfaces for alert types.

* Add code that will work for settings link even outside uptime app.

* Create new atomic params type for status alerts.

* Update executor params typing to support both alert params types.

* Update snapshot for alert factory function.

* Fix broken types and refresh snapshots.

* Allow edits of filters for monitor alerts.

* Support default parameter value for numTimes.

* Support default parameter values for timerange.

* Modify kuery bar to work for alert edits, fix some filter issues.

* Clean up tests and fix types.

* Fix types and add a test.

* Add callout and validation handling for old alerts while editing.

* Add a test for updated validation function.

* Define window for overview filters fetch action.

* Revert store initialization.

* Make monitor counter function while editing alerts.

* Refresh snapshot.

* Move snapshot count in monitor status alert to callout.

* Add new state for selected filters.

* Add basic functional tests for uptime alert flyouts.

* Fix broken types.

* Update unit tests with mock provider.

* Remove unneeded params from hook.

* Add more unit tests.

* Reducing functional test flakiness.

* Alert flyout controls update url only within Uptime app.

* Extract context interaction to container component, update snapshots.

* Add missing parameter to test file.

* Remove flaky functional test.

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Co-authored-by: Shahzad <shahzad31comp@gmail.com>
2020-06-08 15:15:47 -04:00
Nathan Reese 891342a76f
[Maps] fix regression in adding TMS layer (#68471)
* [Maps] fix regression in adding TMS layer

* simplify endDataLoad signature

* rename

* review feedback

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-06-08 13:05:00 -06:00
Spencer 25e71c1096
upgrade npm-run-path (#68539)
Co-authored-by: spalger <spalger@users.noreply.github.com>
2020-06-08 11:29:09 -07:00
Matthias Wilhelm 23be466c97
[Discover] Replace EuiTooltip by native title for better performance (#68280) 2020-06-08 20:24:54 +02:00
Lukas Olson 8174b5ce29
[Search] Refactor service to register search strategies, not providers (#60342)
* Add async search strategy

* Add async search

* Fix async strategy and add tests

* Move types to separate file

* Revert changes to demo search

* Update demo search strategy to use async

* Add async es search strategy

* Return response as rawResponse

* Poll after initial request

* Add cancellation to search strategies

* Add tests

* Simplify async search strategy

* Move loadingCount to search strategy

* Update abort controller library

* Bootstrap

* Abort when the request is aborted

* Add utility and update value suggestions route

* Fix bad merge conflict

* Update tests

* Move to data_enhanced plugin

* Remove bad merge

* Revert switching abort controller libraries

* Revert package.json in lib

* Move to previous abort controller

* Add support for frozen indices

* Fix test to use fake timers to run debounced handlers

* Revert changes to example plugin

* Fix loading bar not going away when cancelling

* Call getSearchStrategy instead of passing  directly

* Add async demo search strategy

* Fix error with setting state

* Update how aborting works

* Fix type checks

* Add test for loading count

* Attempt to fix broken example test

* Revert changes to test

* Fix test

* Update name to camelCase

* Fix failing test

* Don't require data_enhanced in example plugin

* Actually send DELETE request

* Use waitForCompletion parameter

* Use default search params

* Add support for rollups

* Only make changes needed for frozen indices/rollups

* Only make changes needed for frozen indices/rollups

* Add back in async functionality

* Fix tests/types

* Fix issue with sending empty body in GET

* Don't include skipped in loaded/total

* Don't wait before polling the next time

* Add search interceptor for bulk managing searches

* Simplify search logic

* Fix merge error

* Review feedback

* UI to stop async searches

* Add service for running beyond timeout

* Refactor abort utils

* Remove unneeded changes

* Add tests

* Refactor search service to register strategies directly

* Remove accidental change

* re-generate docs

* Fix merge

* types

* doc

* eslint

* Fix async strategy jest test

* type fix

* Use getStartServices in search strategies

* Code review + snapshot

* eslint

* Type script

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Co-authored-by: Liza K <liza.katz@elastic.co>
2020-06-08 21:22:09 +03:00
Corey Robertson 16fbbf4345
[Canvas] Tear down history instances (#68277)
* [Canvas] Tear down history instances

* Always create history on Canvas startup

Co-authored-by: Poff Poffenberger <poffdeluxe@gmail.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-06-08 14:11:51 -04:00
Thomas Neirynck 0189ae5c3f
[Maps] Enable gridding/clustering/heatmaps for geo_shape fields (#67886)
Enables heatmap, clusters, and grid layers for index-patterns with geo_shape field. This feature is only available for Gold+ users.
2020-06-08 11:51:04 -04:00
Melissa Alvarez e2f11e9fe9
[ML] DFAnalytics results: ensure ml result fields are shown in data grid (#68305)
* wip: ensure top classes and influencer result col show up correctly

* ensure ml subFields columns are populated
2020-06-08 11:19:01 -04:00
Robert Austin bc3918671c
[security_solution] enable react-hooks/exhaustive-deps (#68470)
* Enable `react-hooks/exhaustive-deps` rule for security_solution
* Disable it anywhere that it would catch an issue
2020-06-08 10:43:10 -04:00
Oliver Gupte 2bedb59c8e
Closes #66867 by adding missing, requried API params (#68465)
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-06-08 07:30:14 -07:00
Stratoula Kalafateli fcab9745e0
[Telemetry] collect number of visualization saved in the past 7, 30 and 90 days (#67865)
* Update telemetry for visualizations to also count the vis from the past 30 and 90 days

* Also add metrics for the saved visualizations for the past 7 days

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-06-08 17:29:20 +03:00
Alejandro Fernández e66eaf74fd
[Logs UI] View in context tweaks (#67777)
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-06-08 15:49:26 +02:00
Stacey Gammon f89e911f64
Kibana developer examples landing page (#67049)
* Kibana developer examples

* Batch explorer tests should be run in examples config

* Fix tests

* add codeowner for new developer examples plugin & readme cleanup

* Try to frame embeddable wording based on what a developer's goals are.

* Add noopener noreferer, fix bad merge

* Remove bfetch.png

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-06-08 09:47:51 -04:00
Joe Portner c29fcbb46b
Bump decompress package version (#68386) 2020-06-08 09:45:06 -04:00
Peter Pisljar de4eaf9ae7
fix #66185 (#66186) 2020-06-08 15:31:14 +02:00
Joe Portner 77ab709976
Bump pdfmake package version (#68395) 2020-06-08 09:19:32 -04:00
Anton Dosov 49171516d7
Unskip embeddables/adding_children suite (#68111)
Giving it another chance *cross fingers* 
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-06-08 15:01:55 +02:00