Commit graph

16264 commits

Author SHA1 Message Date
Spencer 95329c581f
[precommit hook] add dev script (#14890)
* [precommitHook] move to dev script

* [eslint] fix lint error

* [dev/eslint] do simply boolean checks first

* [dev] use shared REPO_ROOT constant

* [dev/File] precompute relative/ext of path

* [dev/eslint] fix relative import

* [dev/eslint] fix typos

* [grunt] remove unused run:eslintStaged config

* [dev/run] only create log if we are going to use it

* [dev/run/isFailError] ensure return value is Boolean

* [dev/precommitHook] use less intermediate vars
2017-11-20 14:22:24 -07:00
Nathan Reese cf602c60ff
make react route finer grained so other apps don't route to home page while angular is routing to those apps (#15059) 2017-11-20 11:57:47 -07:00
Stacey Gammon 39faeaa73e
Reactify full screen mode placeholder and remove from scope (#14886)
* Reactify full screen mode placeholder and remove from scope

With the toggle in react, no need to store it on scope.

* Simplify implementation by bringing in chrome.setVisible internal to the react placeholder

* rename FullScreenModePlaceholder => ExitFullScreenButton

* div => KuiButton

* Add jest tests for exit full screen button

* Use native Object.values.map instead of loadash _.map

* get rid of unnecessary return value
2017-11-20 12:51:53 -05:00
Stacey Gammon 856d012b46
ensure time picker open in retry loop (#15034)
* ensure time picker open in retry loop

* clean up isTimepickerOpen to use testSubjects.exists
2017-11-20 09:55:28 -05:00
Peter Pisljar b03eac4376
removing failing tilemap tests (#15048) 2017-11-20 13:18:06 +01:00
Stacey Gammon d80ff83bdc
Fix issue with debounce and a quick page switch (#15045) 2017-11-18 10:15:33 -05:00
Stacey Gammon 337def12bd
Fix mistakes added in bwc url test PR (#15038)
* Fix mistakes in bcc tests

* Correct data-test-subj name
2017-11-17 18:06:27 -05:00
Nathan Reese 810345682c
Set timeout and terminate_after parameters when fetching terms for Input Controls (#14977)
* set parameters like suggestions api

* provide timeout and terminate_after in initial state instead of using search_source set

* remove shard_size param and add comment about needed to replace searchsource with suggestions API
2017-11-17 16:04:52 -07:00
Stacey Gammon 57d64bf13b
Fixes https://github.com/elastic/kibana/issues/14908 (#15003) 2017-11-17 17:50:31 -05:00
Spencer 237ee635a4
[server/rootRedirect] remove browser-based redirect (#14698)
* [server/rootRedirect] remove browser-based redirect

With Kibana 4.2 we added the /app/kibana portion of the URL. This introduced a breaking change for URLs from 4.0-4.1, which required a redirect from '/#discover' to '/app/kibana#discover', but we still have the `defaultRoute` parameter, which meant that we needed to distinguish between `/` and `/#discover`. This is impossible on the server alone, unfortunately, so we had to do the redirect in the browser.

We are a long way from Kibana 4.2 at this point, and I think it's time we reduce the number of moving parts and just rely on the server for redirection.

* [server/rootRedirect] test location header
2017-11-17 15:33:58 -06:00
Stacey Gammon 7152d334cf
Add BWC url tests for 6.0 (#15033)
Also adds some stabilization by refactoring some retries and
expectations.
and fixes a bug that snuck in between two PRS where the pie slice css
changed.
2017-11-17 14:59:16 -05:00
Spencer 60298ec8b2
[ftr] default window size (#14834)
* [ftr/mocha] revert Mocha UI assigments after loading test files

* [ftr] add beforeTopLevelSuite and afterTopLevelSuite lifecycle hooks

* [ftr] add defaultWindowWidth and defaultWindowHeight options

Adds two configuration parameters to the functional test runner which
will set the windowSize before running the tests in any file and
restores the original window size when the tests complete.

Individual test files can set the windowSize within its own before() or
beforeEach() handlers using the same `command.setWindowSize()` command.

* [ftr/assignmentProxy] use better naming

* [ftr] restore initial window size after each suite

* [ftr] improve error message for unexpected suite definitions

* [ftr/remote] remove configuration option, rely on suite-level changes

* [ftr] fix stack manipulation order

* [ftr/remote] write tests for window size management
2017-11-17 11:15:02 -06:00
Nathan Reese 8f1aa33604
give info msg instead of error msg when no default index pattern (#15010)
* give info msg instead of error msg when no default index pattern

* fix tests

* use _.get instead of _.has plus turnary operator
2017-11-17 08:58:28 -07:00
Stacey Gammon de1b98cdb7
Add a couple tests with queries and saved searches linked to visualizations (#14878)
* Add a couple tests with queries and saved searches linked to visualizations

Fix issue when edit link is clicked too soon and embeddable hasn't finished loading

* attempt to fix flakiness

* remove duplicate lines
2017-11-17 10:24:08 -05:00
Tim Roes be54f367e9
Remove ready:vis and application.load event (#14988)
* Remove ready:vis event

* Remove application.load event

* Remove commented code

* Fix comment

* Fix broken indentation
2017-11-17 10:46:02 +01:00
Peter Pisljar 5793410a35
pie chart labels (#12174)
* pie labels

* add simple unit test

* fixing dashboard test

* fixing basedo on review

* simplifying conflict resolution

* removing unused code

* cleanup code

* minor changes based on review

* updating option templates to match new design

* updating truncate_labels to work with chars instead pixels
2017-11-17 09:57:02 +01:00
Tim Roes 1d8d835ab7
[Accessibility] Load angular-aria for kibana module (#14969)
* Load angular-aria for kibana module

* Fix indentation

* Add documentation
2017-11-17 09:33:11 +01:00
Nathan Reese 50f708f47f
[timelion] trim number of colors when there are more colors than gradient stops (#14906)
* trim number of colors when there are more colors than gradient stops

* simplify if/else logic as suggested by timroes
2017-11-16 14:41:13 -07:00
Stacey Gammon c2c1b51be8
Add a feature for custom panel titles (#14831)
* Add a feature for custom panel titles

* Add tests and put back data-test-subjs

* sync with master and add padding to form

* UI/UX cleanup

- add enter on close functionality
- make reset title a link instead of a button
- Push css to visualizations instead of the panel. This means
background colors will be flush to the panel.  Override for tile maps
which apparently need it (yet region maps don’t for some reason??)

* Fix refactor miss from merge

* whoops, put block display back to make link fall to bottom

* Undo accidental delete visualization name change

* Color top pop over arrow correctly

* Use naming Options and Customize Panel

* update jest snapshot

* Use custom panels for data-title attributes
2017-11-16 14:53:22 -05:00
Lisa Cawley 39c02c75f9
[DOCS] Add placeholder for 7.0.0-alpha1 Release Notes (#14585)
* [DOCS] Added 7.0.0-alpha1 Release Notes

* [DOCS] Removed X-Pack text from Release Notes
2017-11-16 10:09:24 -08:00
Chris Roberson b20bdae627
[Management] Ensure non alphanumeric characters do not affect index pattern searching (#14973)
* - Fix issue with non alphanumeric characters affecting index pattern search
- Restructure and add tests

* More tests
2017-11-16 11:42:28 -05:00
Kim Joar Bekkelund b1ae3f6125
Revert "Remove 401 error wrapping (#14324)" (#14996)
This reverts commit f167a00543.
2017-11-16 17:37:12 +01:00
Brandon Kobel 8d4d56a0b0
Sharing - Preserve Layout (#14707)
* Adding method to expose the dashboard app container size to reporting

* Adding a data-shared-items-container attribute to the viewport

* Making visualize tell us how large they are

* Removing the controller methods that returned the item size

* Moving the sharing attributes to be on the actual elements, so we can
figure out their dimensions

* Passing the savedObj to the Visualize elements adding the data- attrs

* Adding the title/description to the Dashboard

* Dispatching the initial title/description

* Reverting some accidental whitespace changes

* Fixing metadata selectors

* Adding newline at end of file...

* Putting the $emit('renderComplete') back

* Passing only the savedObj to the Visualize Editor Controller

* Setting the description on the $scope.vis so we don't have to pass the
SavedObj

* Reverting more TSVB title/description code

* Removing savedObj from scope

* Putting $scope.vis back to vis
2017-11-16 08:02:15 -05:00
Kim Joar Bekkelund f167a00543
Remove 401 error wrapping (#14324) 2017-11-16 12:06:37 +01:00
Nathan Reese 25ed343633
[home] feature directory - make icon and description be part of href (#14947)
* make icon and description be part of feature href

* do not change background color - just underline title
2017-11-15 19:48:52 -07:00
CJ Cenizal b0985f9f2c
Add (MIT AND Zlib) to acceptable licenses. (#14985) 2017-11-15 17:12:32 -08:00
Lisa Cawley 85293f9750
[DOCS] Remove X-Pack release note reference (#14983) 2017-11-15 15:22:03 -08:00
dave.snider@gmail.com fb8c72e802
Fix some accessibility coloring issues (#14972)
Fixes table contract and some discover contrast issues.
2017-11-15 14:41:35 -08:00
Stacey Gammon d7c8e76cfb
Stop listening for ready:vis to fetch from courier (#14848)
* Stop listening for ready:vis to fetch from courier

This means saved searches will get requested in their own msearch but
this actually improves dashboard loading because waiting on saved
searches can slow down a whole dashboard.  Splitting up visualizations
from saved searches is an improvement and it cleans up the code, so I
think we should do this.

* Push courier.fetch into search_embeddable_handler
2017-11-15 11:31:39 -05:00
Tim Roes 815cfe1069
[Accessibility] Refactor font slider for accessibility (#14817)
* Refactor font slider for accessibility, fix #12905

* Limit input fields min/max values

* Prevent crossing of min/max values

* Revert "Prevent crossing of min/max values"

This reverts commit 575dfac0b5.

* Use UI framework classes
2017-11-15 14:36:18 +01:00
Spencer 5cddc10077
Upgrade to eslint 4 (#14862)
* [eslint] upgrade to 4.10.0

* [eslint-config-kibana] limit jest config to jest test files

* [ui_framework] remove trailing comma from rest-spreads

* [dashboard/tests] tag jest helpers with .test.js suffix

* explicitly import expect.js where used

* [eslint] apply auto-fixes

* [eslint] manually add/wrap some parens for compliance

* [npm] point to local packages for testing/review

* [jest] remove .test extension from jest helpers

* [ui_framework] fix trailing comma removal from 3bc661a1c8

* [packages] upgrade eslint packages
2017-11-14 18:16:59 -07:00
Nathan Reese 94b2b324aa
Timelion typeahead for argument values (#14801)
* timelion argument value suggestions for legend function

* update functions with argument value suggestions

* use async/await instead of promise resolve/reject for suggestion generation

* lookup value suggestions for es index and timefield arguments

* custom handlers for es metric and split arguments

* update suggestions unit test

* remove duplicate code from insertSuggestion switch

* refactor arg_value_suggestions to provide three methods instead of single getSuggetions method

* template literal

* update es index argument desc to include note about type ahead support
2017-11-14 10:56:16 -07:00
Spencer a3014d7a63
[eslint] add eslint dev script (#14889) 2017-11-14 10:11:59 -07:00
Tyler Smalley 188796314d
Removes index.mapper.dynamic from test fixture (#14930)
This was removed in ES 6.0+

Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
2017-11-14 07:25:38 -08:00
lcawley e41564c991 [DOCS] Fixed broken link in tilemap.asciidoc 2017-11-13 19:48:37 -08:00
Court Ewing 0bfeb8cdf9 docs: fix erroneous references to es-ref 2017-11-13 20:28:56 -05:00
Matt Bargar 5321d7a567
Remove support for expression based scripted fields (#14310)
This PR removes the ability to create scripted fields with the expression language. It also adds an error message to the scripted field list page if any expression scripts already exist which instructs the user to convert all their scripts to painless.
2017-11-13 15:39:53 -05:00
Chris Roberson a5bd0af318
[Management] Address UI searching bug with index pattern creation (#14646)
* Move this logic to a separate directive. Also fix a couple bugs with it around how it interacts with angular.

* Updated variable name

* Handle some edge cases and simplify code

* Fixing typo and further simplyfing code
2017-11-13 14:10:37 -05:00
Tyler Smalley fb4a381514
Adds keystore for securely storing settings (#14714)
Introduces bin/kibana-keystore providing create, list, add, and remove actions.

Settings stored within the keystore will be loaded at runtime.

Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
2017-11-13 10:25:10 -08:00
Jonathan Budzenski b4565aabdf
Revert "Bump react-grid-layout to 0.16.0 (#14620)" (#14912)
This reverts commit 2b06e4bac6.
2017-11-10 18:30:49 -06:00
Jonathan Budzenski 05f4ad0344
[console] assorted autocomplete fixes (#14770)
* [console] add miminum_should_match to match query

* [console] source include,exclude -> includes,excludes

* [console] Remove lowercase expanded terms

* [console] _source_{include,exclude} -> _source_{includes,excludes}

* [console] autocomplete for rollover api

* [console] autocomplete for extended_bounds
2017-11-10 12:26:17 -06:00
Jonathan Budzenski 2b06e4bac6
Bump react-grid-layout to 0.16.0 (#14620) 2017-11-10 11:47:12 -06:00
CJ Cenizal 3bde84393c
Fix Jest warnings for ConfirmModal. (#14892) 2017-11-10 07:56:06 -08:00
Tim Roes 30238e8744
Fix broken date range look, fix #12731 (#14837) 2017-11-10 16:31:14 +01:00
Stacey Gammon 9fa4a0435c
fix console warning about missing required prop (#14876) 2017-11-10 08:24:29 -05:00
Peter Pisljar 5f1f28ba41 reverts metric visualization (#14052)
Uses the previous html/css rendering code instead of the svg-based rendering for simple metrics.
2017-11-09 14:49:58 -05:00
Stacey Gammon 9bf1c78435
rename EmbeddableHandler/s => EmbeddableFactory/ies (#14863) 2017-11-09 14:42:26 -05:00
Stacey Gammon 6d4972869b
Add new title query param to dashboard listing page (#14760)
* introduce a mechanism to load a dashboard by title is a single one is found, if not, to refill the search box on the listing page

* Make case insensitive and prevent listing page from "blipping" up on the screen before the redirect

* Add tests
2017-11-09 14:23:14 -05:00
CJ Cenizal b6b0e6134c
[UI Framework] Add isReadOnly prop to KuiCodeEditor. (#14804)
* Add isReadOnly prop to KuiCodeEditor.
* Place cursor at beginning of code editor if it's read-only.
* Surface prompt for isReadOnly mode. Only show cursor when the editor is focused.
2017-11-09 09:22:48 -08:00
Chris Cowan 680cf1abd4
[TSVB] Change term sorting to match Kibana Core (#14679)
* [TSVB] Change term sorting to make Kibana Core

* removing last bucket changes

* Update tests to reflect new sorting metric
2017-11-09 07:23:45 -07:00