Commit graph

23283 commits

Author SHA1 Message Date
Spencer 96206bd092
[eslint] merge custom rules into a single plugin (#33733)
I'd like to add another custom eslint rule, but there isn't a very good place to do that right now. We have the `eslint-plugin-kibana-custom` package, which is super simple but isn't in the `@kbn` namespace and isn't included in the root eslint config, and `@kbn/eslint-plugin-license-header` is too specific, so I've merged those two packages into `@kbn/eslint-plugin-eslint`, which is a little redundant but allows is to refer to the rules within it as `@kbn/eslint/{rule}`, which feels nice.

Thoughts?

_**NOTE:**_ merging the eslint rules from the two packages means enabling prettier for the code from `@kbn/eslint-plugin-license-header`, all those changes are made in 42c7da6fe2. [View the changes without the prettier updates](b647f2b...74e07a0)
2019-03-22 17:12:14 -07:00
Spencer 6cbecd2fe8
remove unused system-loader implementation (#33747)
This code was added when we were first experimenting with the new platform in the UI, isn't being used by anything, and is very similar to the implementation we ended up going with in https://github.com/elastic/kibana/blob/master/src/core/server/plugins/plugin.ts and https://github.com/elastic/kibana/blob/master/src/core/server/plugins/plugins_system.ts
2019-03-22 16:12:07 -07:00
spalger ef70258714 update kbn/pm dist 2019-03-22 15:42:26 -07:00
Spencer 29badf7655
[ftr/dashboard] wait for importFile() to finish (#33723)
* [ftr/dashboard] wait for importFile() to finish

* move waitUntilLoadingHasFinished() into importFile() call

* remove unnecessary page object
2019-03-22 15:15:21 -07:00
Spencer 96c39b695d
[jest/integration] set default test timeout to 30 seconds (#33718)
* [jest/integration] set default test timeout to 30 seconds

* move into dev/jest/setup directory
2019-03-22 15:13:08 -07:00
Lisa Cawley ce96df1e70
[DOCS] Adds notable highlights tags (#33675) 2019-03-22 15:04:15 -07:00
Josh Dover 53ab06898b
Exclude ambient type definitions from checkTsProjects (#33737) 2019-03-22 16:48:53 -05:00
Josh Dover 74d3301b08
[optimizer] Make thread-loader worker count configurable (#33731)
* [optimizer] Make thread-loader worker count configurable

* Make minimum 1
2019-03-22 16:48:38 -05:00
Spencer b647f2ba6a
[reporting/extract] replace fixtures that look like source (#33739)
The fixtures used by reporting's `extract()` tests have tripped me and others up several times because from the outside they look and behave like source files, but require updating archive fixtures whenever the source is touched. The source of this file is irrelevant though, since the tests are just making sure that the extraction is accurate.

This PR updates the fixture to a markdown file with Lorem Ipsum in it, so it won't look relevant to people making broad strokes changes to files like https://github.com/elastic/kibana/pull/33733
2019-03-22 14:46:04 -07:00
Matthew Kime ab8a2b1777
Dashboard typescript (#32703)
Typescript Dashboard bits - grid, panel, viewport
ui/exit_full_screeen
2019-03-22 14:53:24 -05:00
Lisa Cawley 4c152965b6
Fixes broken link (#33724) 2019-03-22 11:57:06 -07:00
Justin Kambic 45d2c84826
[Uptime] Add first draft of uptime docs (#31814)
* Add first draft of uptime docs.

* Add first draft of uptime docs.

* Implement PR feedback.

* Add role info to uptime docs

* Impelement some more PR feedback.

* Attempt to add more copy focusing on the 'why' of each piece of the docs.

* uptime docs: grammar, formatting, order

* move location of uptime docs

* Implement more PR feedback.

* Add screenshots.
2019-03-22 12:59:53 -04:00
Pete Harverson 5ff422d353
[ML] Skip invalid modules when data recognizer lists matches (#33703)
* [ML] Skip invalid modules when data recognizer lists matches

* [ML] Append error to data recognizer module load console logs
2019-03-22 16:45:01 +00:00
spalger 33083c80eb skip flaky test suite (#33504) 2019-03-22 09:25:36 -07:00
Thomas Neirynck 41d4172fe5
[Maps] coerce string doc-values to numbers if used in styling (#33657) 2019-03-22 11:51:31 -04:00
Jonathan Budzenski 4d60e86287
[monitoring] only create license check if separate monitoring cluster (#33590) 2019-03-22 10:22:11 -05:00
Søren Louv-Jansen ed2874bf54
[APM] Fix Datepicker double loading and move date parsing to urlParams (#33560) 2019-03-22 15:56:57 +01:00
Jason Rhodes 721161f3d1
Upgrades EUI to 9.5 (#33672)
* Updates EUI to 9.5.0

* Remove duplicate type

* Updates snapshots and fixes a few type errors

* Updates x-pack snapshots
2019-03-22 10:28:37 -04:00
Felix Stürmer cee5f7536d
[Infra + Logs UI] Add source configuration ui to the docs (#33535)
This adds the new source configuration ui to the documentation of both the Infrastructure UI and the Logs UI. It also removes the `BETA` badge to reflect the status change.

fixes elastic/kibana#31124

Co-authored-by: Brandon Morelli <bmorelli25@gmail.com>
2019-03-22 12:25:08 +01:00
Oliver Gupte 8ccd5715ab
[APM] Related error count in transaction timeline (#33100)
* Closes #29688 by adding related error count in timeline with links to error
overview filtered by the related trace/transaction ids. Also update the errors
link in the sticky transaction properties to match the timeline pattern.

* [APM] leverage EUI theme colors, tweak sticky transaction properties column
sizes, and reorder timeline error count to show duration after only on hover

* [APM] Renamed ErrorsOverviewLink -> ErrorCountBadge. Differentiate the labeled
vs non-labeled variaions of ErrorCountBadge. Replace state hooks for hovered
styles with plain css :hover

* [APM] Revert duration display on hover to render display all the time.

* remove unnecessary props object spread
2019-03-21 21:38:14 -07:00
Peter 96fda610c7
Fix clipping of wide vega tooltip tables (#33465)
* fix wide vega table tooltips, desktop and mobile (#33436)
2019-03-21 16:01:20 -04:00
Josh Dover b21e646dcb
Replace start with setup lifecycle event (#33455)
* Move `start` lifecycle functions to `setup` in core/server

* Move `start` lifecycle functions to `setup` in core/public
2019-03-21 13:27:59 -05:00
Robert Monfera 7b5d559f4d
[Canvas] Fix: no stuck hover on key based page back/forth (#33631)
* Fix: no stuck hover on key based page back/forth

* Fix: no stuck hover on key based page back/forth
2019-03-21 18:55:16 +01:00
Aleh Zasypkin e7e26b05b9
Typesciptify SAML Authentication provider. (#33559) 2019-03-21 16:56:33 +01:00
gchaps c52ca4c8b1
[DOCS] Removes beta tag from Canvas docs (#33630) 2019-03-21 07:53:14 -07:00
Liza Katz 3cc70257b8
New platform dropdown (#33520)
* Removed old dropdown code from dev tools consle

* Removed old dropdown from vega tools

* Deleted dropdown directives from angular bootstrap

* Deleted ui.bootstrap.dropdown test (irrelevant, since directive was deleted)
2019-03-21 15:02:27 +02:00
Alexey Antonov e9c41c211c
[TSVB] Table View - critical issue after cleaning the 'Group by' field (#33645) 2019-03-21 15:24:45 +03:00
Liza Katz 0e4e50854e
New platform agg_types deps (#33372)
* Moved auto_select_if_only_one directive

* Moved validate-date-interval directive

* Moved scroll-bottom directive

* Moved input number directive + Fix validate-date-interval directive

* Moved validate ip and validate cidr mask directives

* Moved validate date math and documentation href directives

* Moved validate agg directive

* Moved click focus directive

* removed validate date interval from autoload
2019-03-21 11:28:02 +02:00
Peter Pisljar fec0f6c40a
adding runPipeline tests (#27015) 2019-03-21 07:12:25 +01:00
Robert Monfera e110de3e59
Refactor: make interaction target acquisition faster and more robust (#33503) 2019-03-20 23:17:10 +01:00
Catherine Liu 9563c49d21
[Canvas] Show current workpad in workpad loader (#33531)
* Bolds loaded workpad in workpad loader

* Extracted helper function
2019-03-20 14:25:21 -07:00
gchaps a8c919afc8
[DOCS] Adds information about enabling/disabling rollover (#33600) 2019-03-20 13:28:46 -07:00
Melissa Alvarez a650dc172d
Add missing whitespace to modelPlotCardinality + cardinalityNotValid messages (#33599) 2019-03-20 16:12:25 -04:00
Alison Goryachev 08594c814e
refetch autocomplete info after updating dev console settings (#32587)
* refetch autocomplete info after updating dev console settings

* address review feedback

* only update autocomplete settings if user has changed settings

* refactor code to only refetch autocomplete settings on change

* simplify logic based on review feedback

* address review feedback
2019-03-20 16:04:05 -04:00
Luke Elmers 2783ffdeb8
Add unit tests for core interpreter functions (#32377) 2019-03-20 12:46:29 -06:00
Court Ewing 7e224b2455
Update RFC-0001 with PR and issue links (#33598) 2019-03-20 14:15:47 -04:00
Liza Katz e9863f386e
New platform cleanup tabs (#33425)
This PR includes the removal of the angular-boostrap directives:

* tabset
* tab

To achieve that, tabs were replaced in 2 places in the code (screenshots attached) with a simple React + EUI implementation.

* search profiler
* timelion app help documentation
2019-03-20 20:11:17 +02:00
Justin Kambic d15a6771de
[Uptime] Change copy on empty state component (#33044)
* Change copy on Uptime empty state component to use "collecting" instead of "logging".

* Update jest snapshot for changed component.

* Update empty prompt link to send users to Add Data tutorial.

* Update empty state tests for new changes.
2019-03-20 14:10:08 -04:00
Justin Kambic df89596e92
[Uptime] Add Global Help support to uptime (#31493)
* Add comments to kibana framework adapter file's render function for better annotation.

* Add global help link for uptime.

* Add return function to help API handler.
2019-03-20 14:09:30 -04:00
Josh Dover 14cce19c67
[UA] Move Kibana stacktrace from UI to logs (#33150) 2019-03-20 12:16:38 -05:00
Josh Dover 2a10de423c
Fix custom icon image paths in NavDrawer (#33573) 2019-03-20 11:10:16 -05:00
Melissa Alvarez 2a695a4294
[ML] Anomaly explorer add/remove filter via Anomalies table (#33377)
* create utils file for kqlFilterBar

* add filer icons to influecer cell

* wip: apply filter from table

* update filterbar value from table

* error handling for filter by table

* Add filtering icons in expanded row

* Add tests + keep filterBar utils in same dir

* don't add filter if exists already

* update error message

* update error message and add link

* update entityCell comment + add getQueryPattern test

* Update entityCell comment

* update job switch handling with icon filter changes
2019-03-20 11:52:19 -04:00
Josh Dover e51f329781
Inject UI plugins into injectedMetadata (#31840)
This modifies the PluginService to expose a Map of UI plugins and their manifests, in topological order by their dependencies. That data is then exposed to injectedMetadata via the ui_render_mixin in the legacy platform, and read back out via the new platform's client-side InjectedMetadataService, preserving the topological order.
2019-03-20 10:26:06 -05:00
Jonathan Budzenski 8a007464ea
[es-browser] override default 9200 port (#33523) 2019-03-20 09:45:54 -05:00
Aleh Zasypkin 4b1dd01188
Exclude .test.ts files from x-pack build. (#33565) 2019-03-20 14:28:44 +01:00
Joe Reuter f0b66465e8
Add missing formatting for values in table titles (#33566) 2019-03-20 14:25:04 +01:00
Liza Katz 3ac95dc213
moved btn-radio directive to vis editor (#33373) 2019-03-20 11:54:51 +02:00
Robert Monfera dfd9401cf0
[Canvas] No dummy commit for keyboard events (#33414)
* Chore: typo fix

* Chore: no longer use possibly obsolete `states`

* Fix: cause update to component upon keyboard shortcut interactions

* Refactor: more honest name for the React rerender enforcer call

* Chore: we know we return falsey
2019-03-20 08:11:54 +01:00
Peter Pisljar 40fce1aad8
adding interpreter uiExports (#33391) 2019-03-20 06:41:37 +01:00
jinmu03 d0db18dfad
Modify labels for release notes in Contributing guide (#33450)
* release notes

* release notes

* release notes

* Update CONTRIBUTING.md

Co-Authored-By: jinmu03 <36862642+jinmu03@users.noreply.github.com>

* Update CONTRIBUTING.md

Co-Authored-By: jinmu03 <36862642+jinmu03@users.noreply.github.com>

* modify release notes labels
2019-03-19 21:07:45 -07:00