Commit graph

41099 commits

Author SHA1 Message Date
Frank Hassanabad
972bf0adc1
[Security Solutions] Unrevert and fix tests (#93834)
## Summary

Unreverts:
https://github.com/elastic/kibana/pull/93548

By fixing tests that are relying on date times to be less strict.

### Checklist

- [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
2021-03-05 18:41:00 -05:00
Davis Plumlee
b5ee9f451f
[Security Solution][Detection Rules] Fixes rule details spacing on rules with long queries (#93831) 2021-03-05 18:19:14 -05:00
Brian Seeders
654435249e
Skip uptime test blocking ES snapshot promotion (#93828) 2021-03-05 18:12:55 -05:00
Lukas Olson
c9b0b1577a
[KQL] Do not generate nested AST/Elasticsearch queries for same-level AND/OR clauses (#93506)
* [KQL] Do not generate nested AST for same-level AND/OR clauses

* Update tests

* Update snapshots
2021-03-05 15:52:49 -07:00
Devin W. Hurley
fd1d796564
[Security Solution] [Detections] Fixes validation on response from find status route (#93684)
* fix validation on response of find status route when rule has a partial failure status

* replaces warning in rule status service with partial failure to maintain backwards compatibility from an API standpoint, also displays 'warning' on UI if a rule's status is partial failure

* display partial failure as 'warning' on all rules table and update e2e test to check for partial failure not warning

* add util function, show 'warning' on monitoring table, fix e2e tests
2021-03-05 17:24:47 -05:00
Marshall Main
352af43b29
Return results from find and read rules even if they don't validate (#93713) 2021-03-05 17:07:09 -05:00
Chris Cowan
eb104651b1
[Metrics UI] Disable anomaly alerting (#93813) 2021-03-05 14:48:46 -07:00
Lee Drengenberg
ad5a7a528a
wait for index pattern button to be enabled (#93677)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-03-05 15:30:36 -06:00
Thomas Watson
a79ebbe613
Upgrade geckodriver from 1.21.0 to 1.22.2 (#93802) 2021-03-05 15:26:10 -05:00
Jonathan Budzenski
9019946f95
[license checker] Neutral naming (#93783)
This changes text in our license checker to support our neutral naming
efforts in #71398.

LICENSE_WHITELIST -> LICENSE_ALLOWED
DEV_ONLY_LICENSE_WHITELIST -> DEV_ONLY_LICENSE_ALLOWED
2021-03-05 13:26:21 -06:00
Mike Côté
23ce8dcfdb
Rename alerts plugin to alerting (#92898)
* Rename alerts plugin to alerting

* Deprecate old config values

* Few more renames

* Update plugin list

* Rename xpack.alerts -> xpack.alerting

* Fix some ESLint rules

* Fix typecheck

* Fix some test failures

* Some more renames

* Fix ESLint

* Fix some test failures

* Fix failing jest test

* Undo exclusive test

* Fix APM deps

* Fix docs

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-03-05 13:59:34 -05:00
Nicolas Chaulet
02be8c16c9
[Fleet] Improve error status code for package (#93696) 2021-03-05 13:50:14 -05:00
Tre
14069d5c2c
[QA][Code Coverage] Assign teams and ingest faster (#92710)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-03-05 11:36:01 -07:00
Dima Arnautov
15cda17f2d
[ML] Fix creation of alert instances for Anomaly detection alert type (#93605)
* [ML] use static alert instance key, remove logic for handling duplicates

* [ML] use job id as an alert instance id

* [ML] beta label

* [ML] round time interval

* [ML] fix preview button

* [ML] improve the default template

* [ML] remove redundant kibanaBaseUrl
2021-03-05 12:26:58 -05:00
Scotty Bollinger
5755d7907c
[Workplace Search] Port RoleMappings changes (#93458)
This PR ports changes from the ent-search RoleMappings to Kibana

Reference PR: https://github.com/elastic/ent-search/pull/3148
2021-03-05 13:18:10 -04:00
Alexey Antonov
a3b848a5be
[Timelion] Build optimization - move parser_async to chunk (#93766)
* [Timelion] Build optimization - move parser_async to chunk

* Update parser_async.ts
2021-03-05 19:52:50 +03:00
Michael Dokolin
542d66643e
[Reporting] Fix chromium driver factory to emulate browser timezone (#73242) 2021-03-05 17:47:49 +01:00
Jen Huang
b310138717
Don't truncate package name in package details page title (#93716) 2021-03-05 08:14:50 -08:00
Brandon Morelli
433b55353c
Update link to index template documentation (#93709) 2021-03-05 08:02:32 -08:00
Madison Caldwell
840edacecf
[Security Solution][Detections][Threshold Rules][7.12] Final Threshold Rule Fixes for 7.12 (#93553)
* refactor

* Add explicit to/from

* cleanup

* A bit more cleanup

* Fix threshold signal history bug when rule is edited

* Added comments

* more cleanup, fix tests

* Add tests later

* Reverse the tuples array

* Fix getThresholdBucketFilters test

* Fix translations
2021-03-05 10:26:00 -05:00
Vadim Dalecky
89020354eb
Unskip "Explore underlying data" skipped functional test (#93627)
* ci: 🎡 enable flaky test for running through flaky test runner

* ci: 🎡 unskip skipped test
2021-03-05 15:25:59 +01:00
Tiago Costa
0f261ef670
skip flaky suite (#93737) 2021-03-05 14:16:11 +00:00
Tiago Costa
50c5f0617b
skip flaky suite (#93735) 2021-03-05 14:11:31 +00:00
Sonja Krause-Harder
3cd0d455c6
[Fleet] Don't add extra quotes to YAML strings from manifest files (#93585)
* Add UI validation for string YAML values in policies.

* Do not quote YAML strings containing special characters.

* Add test case for wildcards in the middle of strings.

* Add multiline test case.

* Polish test case.

* Update API docs

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-03-05 15:00:31 +01:00
Candace Park
bf1dcb7679
[Security Solution][Endpoint][Admin] Fixes bug where license watch updates policy in fleet (#93691) 2021-03-05 08:35:24 -05:00
Dmitry
d0b6891abf
[coverage] bootstrap from root (#93690)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-03-05 14:50:21 +03:00
Gidi Meir Morris
7cfd15c038
[Alerting] adds Connectors APIs and deprecates old Actions APIs as per the new Alerting terminology (#92451)
* moved legacy actions api to legacy folder

* introduced connector create api

* added new delete route

* added new execute and get_all

* introduced all connector APIs

* renamed action to connector in Apis

* comment on camel case type

* fixed va

* updated docs

* legacy title

* corrected APIs

* legacy links

* added linik to deprecatred APIs

* added linik to deprecatred APIs from index

* moved legacy apis down one level

* Apply suggestions from code review

Co-authored-by: ymao1 <ying.mao@elastic.co>

* renamed route file for connectorTypesRoute

* define legacy route

* Update docs/api/actions-and-connectors/legacy/index.asciidoc

Co-authored-by: Mike Côté <mikecote@users.noreply.github.com>

* api docs

Co-authored-by: ymao1 <ying.mao@elastic.co>
Co-authored-by: Mike Côté <mikecote@users.noreply.github.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-03-05 06:49:06 -05:00
Gidi Meir Morris
46247c6c55
[Alerting] Renames the "ES query" alert type to "Elasticsearch query" (#93584)
Tweaks UX for 7.12
2021-03-05 11:41:37 +00:00
Alejandro Fernández Haro
00d448bc50
[Telemetry] Default to namespaces:['*'] in soClient.find requests (#93289)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-03-05 11:11:14 +00:00
Alejandro Fernández Haro
c86f6a2306
[Telemetry] Fix flaky "after" delete (#93636) 2021-03-05 12:07:35 +02:00
Angela Chuang
229ffd902e
[Security Solution] Fix a flacky cypress test in data_providers.spec (#93655)
* extend timeout when dragging

* drop in the middle of the area
2021-03-05 09:13:02 +00:00
Pierre Gayvallet
d53894aa5a
Display Kibana overall status in the logs and have FTR wait for green status before running tests (#92568)
* add licensing plugin status

* simplify log message

* review comments
2021-03-05 09:55:14 +01:00
Tyler Smalley
1f936a1571 Revert "[Security Solutions] Sets our default date time to be "today" instead of "Last 24 hours" to enable cachability and fixes one date math bug in the URL (#93548)"
This reverts commit 47bb9773a1.
2021-03-04 22:06:17 -08:00
liza-mae
27f2c75921
Upgrade smoke tests (#92893)
* Upgrade smoke tests

* Fix lint issues

* Remove duplicate line

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-03-04 20:22:20 -07:00
Jonathan Budzenski
84344391ba skip should apply query to fit to bounds. #93718 2021-03-04 20:24:54 -06:00
Xavier Mouligneau
f13dabbb5c
{SECURITY SOLUTION] EQL timeline bug (#93555)
* timeline eql -> 1-Do not default tiebreaker 2-Close EQL setting popover

* review I

* review focus trap is a trap

* no need to mock it for everybody
2021-03-04 20:41:48 -05:00
Patrick Mueller
1c4c7c26a4
[eventLog][docs] updates README.md (#92563)
resolves https://github.com/elastic/kibana/issues/89998

The README.md for the event log was a bit old, and was more focused on
implementation details and information for plugin developers writing events.
There wasn't much information available that was useful for folks using
the event log for problem diagnosis.

So the docs have been updated a bit in general, and more information has
been added on the event document structure, and the actions and alerts
events specifically.
2021-03-04 19:23:55 -05:00
Joe Portner
171567d70a
ESLint rules for Spaces and Security (#93644) 2021-03-04 18:47:39 -05:00
Angela Chuang
7c9e08e269
styling (#93663) 2021-03-04 22:59:38 +00:00
Devon Thomson
a21f48a9f2
Make Dashboard Unsaved Changes Space Specific (#92680)
* Made dashboard unsaved changes space specific
2021-03-04 17:06:58 -05:00
Jason Stoltzfus
8381fdd60e
Hide Value and Funtional boost for geolocation (#93683) 2021-03-04 17:06:03 -05:00
Jen Huang
0d4ca46cf0
[Fleet] Set all keyword and text fields for index.query.default_field index template setting (#91791)
* Set all keyword and text fields for `index.query.default_field` setting

* Update tests and snapshots

* Fix test

* Add default field limit safeguard

* Add logging when beyond limit

* Update tests to mock app context (because I added logger usage)

* Update api integration test

* Rename consts
2021-03-04 16:34:47 -05:00
Xavier Mouligneau
abb71b471f
can not query the world (#93556) 2021-03-04 16:22:58 -05:00
Frank Hassanabad
47bb9773a1
[Security Solutions] Sets our default date time to be "today" instead of "Last 24 hours" to enable cachability and fixes one date math bug in the URL (#93548)
## Summary

Enables caching in our application by setting the default date time of our application to be `from: now/d` and `to: now/d`. When users go to the advanced settings they will see this now:
<img width="1243" alt="Screen Shot 2021-03-04 at 11 53 08 AM" src="https://user-images.githubusercontent.com/1151048/110014626-43fb6700-7ce0-11eb-94ee-0c4cc7a8a10f.png">

In their date time bars on page loads they will see today instead of 24 hours:
<img width="556" alt="Screen Shot 2021-03-04 at 11 50 18 AM" src="https://user-images.githubusercontent.com/1151048/110015216-dac82380-7ce0-11eb-935d-2d71078c1170.png">

When before they used to have `from: now-24` and `to: now`. This new date time frame plays well with Elastic caches and no longer "busts" them for users on each page request. Now users will send the same date time frame on each query which will cache the views as the default.

This also fixes a small bug with the URL's where the "to" was not being rounded up when it was a dynamic date time on first load. For example if you went to the URL, `/app/security/hosts/allHosts` with no additional state information but have a default of `from: now/d` and `to: now/d` it would not round up the date time. Now it rounds it up through the date math utilities which only rounds when it sees that it is a dynamic date math.

When requests are being sent, expect to see this where you have `from` rounded down and `to rounded up. This should be a consistent non-sliding date time math for caching to operate:
<img width="608" alt="Screen Shot 2021-03-04 at 11 33 11 AM" src="https://user-images.githubusercontent.com/1151048/110015357-01865a00-7ce1-11eb-8580-efacf791b573.png">

If you change the `to` to be another date math such as `now+1d/d` expect to see it also rounded up. This behavior mirrors that of discover:
<img width="608" alt="Screen Shot 2021-03-04 at 11 33 11 AM" src="https://user-images.githubusercontent.com/1151048/110015440-17941a80-7ce1-11eb-832d-e826962829ed.png">

You can manually verify this behavior by setting the same now dates in discover as well as security solutions and both should work as is even when you remove the URL state from the right side of a `?`


### Checklist

- [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
2021-03-04 14:22:37 -07:00
Candace Park
28750e913b
[Security Solution][Endpoint][Admin][Policy] Register as AV os restrictions tooltip note (#93306) 2021-03-04 16:05:46 -05:00
Peter Pisljar
a58e3bdbbf
fix agg config sub agg dsl generation (#93276) 2021-03-04 21:59:25 +01:00
Kerry Gallagher
e45718d0ff
[Logs UI] Fix log stream data fetching (#93201)
* Use ReplaySubject and amend date comparisons

* Assess date range expressions separately

* Only add dataset filter to view in stream links if one exists
2021-03-04 19:50:14 +00:00
Jason Stoltzfus
6ab3fc0107
[App Search] Added relevance tuning search preview (#93054) 2021-03-04 11:47:10 -08:00
Corey Robertson
d673f5601d
[Canvas] Fix reports embeddables (#93482)
* wip

* WIP

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-03-04 14:30:30 -05:00
John Dorlus
572f6888c2
[ILM] Added new functional test in ILM for creating a new policy (#92936)
* Added data-test-subj for ILM policies row and added a functional UI test to create a new ILM policy.

* Removed .only from test to allow entire test suite to run again.

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-03-04 13:55:00 -05:00