Commit graph

29421 commits

Author SHA1 Message Date
Spencer 9f94c39960
[7.x] build immutable bundles for new platform plugins (#53976) (#57528)
* build immutable bundles for new platform plugins (#53976)

* build immutable bundles for new platform plugins

* only inspect workers if configured to do so

* [navigation] use an index.scss file

* add yarn.lock symlink

* set pluginScanDirs in test so fixtures stay consistent

* cleanup helpers a little

* fix type error

* support KBN_OPTIMIZER_MAX_WORKERS for limiting workers via env

* test support for KBN_OPTIMIZER_MAX_WORKERS

* expand the available memory for workers when only running one or two

* add docs about KBN_OPTIMIZER_MAX_WORKERS environment variable

* fix README link

* update kbn/pm dist

* implement bundle caching/reuse

* update kbn/pm dist

* don't check for cache if --no-cache is passed

* update renovate config

* standardize on index.scss, move console styles over

* add support for --no-cache to cli

* include worker config vars in optimizer version

* ignore concatenated modules

* update integration test

* add safari to browserslist to avoid user-agent warnings in dev

* update docs, clean up optimizer message/misc naming

* always handle initialized messages, don't ignore states that are attached to specific events

* reword caching docs, add environment var to disable caching

* tweak logging and don't use optimizer.useBundleCache as that's disabled in dev

* handle change notifications

* batch changes for 1 second

* rename CompilerState type to CompilerMsg

* getChanges() no longer needs to assign changes to dirs

* remove unused deps

* split up run_worker.ts and share cacheKey generation logic

* add a couple docs

* update tests and remove unused imports

* specify files when creating bundle cache key

* remove one more unused import

* match existing dev cli output more closely

* update kbn/pm dist

* set KBN_NP_PLUGINS_BUILT to avoid warning in CI

* avoid extending global window type

* add note to keep pluginScanDirs in sync

* pass browserslistEnv in workerConfig so it is used for cache key

* load commons.bundle.js in parallel too

* emit initialized+success states if all bundles are cached

* load bootstraps as quickly as possible

* skip flaky suite

* bump

* update jest snapshots

* remove hashing from cache key generation

* remove unnecessary non-null assertion

* improve docs and break up Optimizer#run()

* remove unused import

* refactor kbn/optimizer to break up observable logic, implement more helpful cache invalidation logic with logging

* fix tests

* add initializing phase

* avoid rxjs observable constructor

* remove unnecessary rxjs helper, add tests for bundle cache

* update consumers of optimizer

* update readme with new call style

* replace "new platform" with "kibana platform"

* fix a couple more renames

* add support for several plain-text file formats

* fix naming of OptimizerMsg => OptimizerUpdate, use "store" naming too

* one more OptimizerMsg update

* ensure bundles are not cached when cache config is false

* test for initializing states and bundle cache events

* remove unnecessary timeout change

* Remove unnecessary helpers

* Add tests for BundleCache class

* Add tests for Bundle class

* test summarizeEvent$

* missing paths are no longer listed in mtimes map

* add tests for optimizer/cache_keys

* Add some extra docs

* Remove labeled loop

* add integration test for kbn-optimizer watcher components

* querystring-browser removed

* tweak logging a smidge, improve info and final message

* remove unused imports

* remove duplication of getModuleCount() method

* move type annotation that validates things

* clear up the build completion message

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

* [kbn/optimizer] Fix windows support (#57592)

* [kbn/optimizer] simplify run_workers.ts a smidge

* use Path.resolve() to create windows paths from normalized ones

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
(cherry picked from commit 343bc9c303)

* remove istanbul/code coverage references

* fix webpack config syntax

* removal of querystring-browser was backported to 7.x

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-02-14 11:35:24 -07:00
Walter Rafelsberger 98bbf2cd48
[ML] Fix single metric viewer chart resize. (#57578) (#57687)
Fix to trigger a chart update with the correct width when resizing the browser window. Previously after a browser refresh, or opening the view from a bookmarked URL, the chart would not resize until a state change was made to the view (such as moving the zoom slider or altering the time range).
2020-02-14 16:47:33 +01:00
Kaarina Tungseth 7e742230fb
[7.x] [DOCS] Adds known issue to 7.6 Release Notes (#57462) (#57495)
* [DOCS] Adds known issue to 7.6 Release Notes

* Removed Discover

* Added workaround
2020-02-14 09:39:17 -06:00
Mike Côté aa88885755
Skip flaky test (#57675) (#57688) 2020-02-14 10:34:22 -05:00
Robert Oskamp b70de973f9 Transform functional tests - disable saved search test 2020-02-14 16:10:48 +01:00
Jean-Louis Leysens 2e33bfe208
[Console] Fix performance bottleneck for large JSON payloads (#57668) (#57682)
* Fix Console performance bug for large request bodies

The legacy_core_editor implemenation was calculating the current editor line
count by .split('\n').length on the entire buffer which was very inefficient
in a tight loop. This caused a performance regression. Now we use the cached
line count provided by the underlying editor implementation.

* Fix performance regression inside of ace token_provider implementation

* Clean up another unnecessary use of getValue().split(..).length.

Probably was not a performance issue, just taking unnecessary steps. Not
sure that this function is even being used.
2020-02-14 15:58:44 +01:00
Joe Reuter c1089efc7e
Clean up shims of Graph, Home, Dashboard, Visualize (#57331) (#57684) 2020-02-14 15:52:30 +01:00
Lee Drengenberg 6a23965971
handle viewing sample dashboards on default dist (#57510) (#57625)
* handle viewing sample dashboards on default dist

* re-work change to not break jest test

* Update snap for addition of data-test-subj

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-02-14 08:44:23 -06:00
Walter Rafelsberger d9becbb052
[ML] Fix brush visibility. (#57564) (#57676)
Fixes brush visibility. The brush will no longer be hidden if it covers the full available timespan. Removes all code that was earlier used to manage brush visibility.
2020-02-14 15:01:36 +01:00
Pierre Gayvallet a43ce0aa65
[7.x] Use app id instead of pluginId to generate navlink from legacy apps (#57542) (#57670)
* Use app id instead of pluginId to generate navlink from legacy apps (#57542)

* properly use app id instead of pluginId to generate navlink

* extract convertToNavLink, add more tests

* use distinct mapping methods

* fix linkToLastSubUrl default value

* nits & doc

* update generated doc
2020-02-14 14:57:01 +01:00
Shahzad 552e8f83af
[Uptime] Implemented drag and select on charts (#57089) (#57665)
* Implemented drag and select on charts

* fix test

* unused

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-02-14 14:54:17 +01:00
Shahzad ba8b610424
[Uptime] Fix/host connected components (#56969) (#57666)
* added test for pages

* fixed types

* moved redux logic to connected

* comment

* update type

* type fix
2020-02-14 14:54:01 +01:00
Joe Reuter ecc03e9468
Migrate vega and graph configs to new platform (#57011) (#57661) 2020-02-14 14:12:54 +01:00
Joe Reuter 15ea696531
TSVB validation: Allow empty strings for number inputs (#57294) (#57662) 2020-02-14 14:12:45 +01:00
Matthias Wilhelm 46bb78ec3e
[Discover] Improve functional test of context (#57575) (#57654)
By converting adding filters to a sequential mode, the test of clicking on a context link in the discover table should no longer be flaky
2020-02-14 13:39:35 +01:00
Pierre Gayvallet 6f6cc356f9
Preserve the original error name instead of returning raw AbortError (#57550) (#57653)
* Preserve the original error name instead of returning raw AbortError

* use Error as the default error name
2020-02-14 11:50:16 +01:00
spalger c23d770536 disable firefox smoke tests so we can fix flakiness out of band
(cherry picked from commit fe3864282a)
2020-02-14 00:47:19 -07:00
Joe Portner 65f065e5f0
Fix detection of "system requests" in plugins (#57149) (#57639)
This aligns plugin usage with the new way that the Kibana Platform
handles checking for system requests.
2020-02-14 00:01:35 -05:00
Jonathan Budzenski bc75eb2c11 skip flaky tests 2020-02-13 19:04:02 -06:00
Ryland Herrick bbef07aebd
Use default spaces suffix for signals index if spaces disabled (#57244) (#57521)
Addresses #57221.

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-02-13 17:19:50 -06:00
spalger 0cc10f2c56 skip flaky suite (#50018)
(cherry picked from commit b058dc2fe7)
2020-02-13 15:21:51 -07:00
Jonathan Budzenski 8806698b79 skip settings tests (#57608) 2020-02-13 16:20:57 -06:00
spalger 4841bfb2b6 skip failing suite (#44631)
(cherry picked from commit 8aa718d11e)
2020-02-13 15:17:16 -07:00
Melissa Alvarez 55f87c0438
[7.x] [ML] New Platform server shim: update job service routes to use new platform router (#57403) (#57595)
* [ML] New Platform server shim: update job service routes to use new platform router (#57403)

* wip: convert jobService route file to TS and use NP router

* add schema definitions for route params

* add api docs description for routes

* update schema and rename client

* update calendarManager

* fix typo in schema

* use NP context savedObjectsClient for rollup true

* request no longer passed to JobServiceProvider

* update anomalyDetectors schema for job update

* add missing key to anomalydetectors schema

* update schema
2020-02-13 16:33:34 -05:00
Nathan Reese 8d0254c5b0
[Maps] allow simultaneous opening of multiple tooltips (#57226) (#57610)
* split TooltipPopover from TooltipContent

* display multiple tooltips

* hack to fix spacing

* hover tooltip

* fix jest tests for new props

* update snapshots

* simplify jest tests

* avoid opening up multiple tooltips in same location

* remove duplicated code

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-02-13 14:03:21 -07:00
Mikhail Shustov 2031b95a4d
Use log4j pattern syntax (#57433) (#57568)
* address comments

* use log4j-like syntax in layout pattern

* %timestamp --> %date to match log4j conversion pattern

* %context --> %logger to match log4j pattern

* remove file from pre-defined appenders.

file name is required. let users to setup everything

* matchAll is not polyfilled in runtime

* document available patterns and migration path

* document BWC requirements

* Revert "matchAll is not polyfilled in runtime"

This reverts commit 9f491d4f53.

* address comments

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-02-13 21:46:52 +01:00
spalger 2f63376267 skip flaky suite (#44631)
(cherry picked from commit 6e4efdfa7c)
2020-02-13 13:41:25 -07:00
spalger b31c9b5ae3 skip flaky test (#57377)
(cherry picked from commit 59672ab5da)
2020-02-13 12:35:10 -07:00
Jonathan Budzenski d97c88bf0b Skip save query tests (#57589)
Several tests using the
savedQueryManagementComponent.saveNewQueryMissingOrFail method have been
failing with 'waiting for element'.  Temproary adding a skip for tests
using this method

Related #50018
Related #44631
Related #45348

(cherry picked from commit 431a1e9c89)
2020-02-13 12:32:03 -07:00
Gidi Meir Morris 332df381bf
address flaky test where instances might have different start… (#57506) (#57549) 2020-02-14 08:02:05 +13:00
Gidi Meir Morris 2459c6831c
[7.x] [Alerting] make actionGroup name's i18n-able (#57404) (#57505)
* [Alerting] make actionGroup name's i18n-able (#57404)

We want to make the Action Group i18n-able for display in the AlertDetails page, so instead of just a list of ids, the AlertType now registers an object where key is the id and value is the human readable, and translatable, value.

* fixed issue introduced by merge conflict

* fixed merge conflict

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-02-14 08:01:14 +13:00
Brandon Kobel b1e03cc1ab
Add autocomplete="off" for input type="password" to appease the scanners (#56922) (#57523)
* Add autocomplete="off" for input type="password" to appease the scanners

* Using new-password instead of off for the new/confirm passwords

* Setting more autoComplete="new-password" attributes

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-02-13 10:38:00 -08:00
Nathan Reese 4e470ebf07
[Maps] Fix document source top hits split by scripted field (#57481) (#57585)
* [Maps] Fix document source top hits split by scripted field

* fix i18n message

* review feedback

* remove unneeded scss file
2020-02-13 11:28:22 -07:00
Brandon Morelli cddfa9f0af
[logs][metrics][docs] Update screenshots for 7.6 (#57254) (#57598) 2020-02-13 09:52:01 -08:00
Shahzad b845f710ff
[Uptime] Added tests for pages (#56736) (#57554)
* added test for pages

* fixed types

* update types

* update snap

* PR feedback

* PR feedback
2020-02-13 18:50:10 +01:00
James Gowdy 204767e221
[ML] Categorization field example endpoint tests (#57471) (#57566)
* [ML] Categorization example endpoint tests

* adding data

* removing debug code

* adding endpoint error test

* updating version in archive
2020-02-13 15:30:31 +00:00
Peter Pisljar d481a32c9a
fixing maps (#56706) (#57511) 2020-02-13 10:26:51 -05:00
Nathan Reese 8ad8c72535
[Maps] do not show border color for icon in legend when border width is zero (#57501) (#57561)
* [Maps] do not show border color for icon in legend when border width is zero

* fix jest tests

* fix jest tests

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-02-13 08:04:11 -07:00
Joe Reuter b8b275f5ad
Lens client side shim cleanup (#56976) (#57562) 2020-02-13 15:36:28 +01:00
Devin W. Hurley 8ca0cef8a9
[SIEM] [Detection Engine] Reject if duplicate rule_id in request payload (#57057) (#57526)
* prevents creation of rules when duplicate rule_id is present

* adds unit test to reflect change

* genericizes duplicate discovery functions, allows creation of non-duplicated rules even when duplicates are discovered, keeps same return type signature, updates relevant test for duplicates in request payload

* utilizes countBy and removes reduce in favor of a filter on getDuplicates function

* fix type

* removes skip from e2e test for duplicates on bulk create, updates expected response in e2e test, fixes bug where duplicated error messages appeared for each instance of a duplicated rule_id (found this one through the e2e tests)! Adds unit test to catch this case.

* getDuplicate returns empty array instead of null, removes unnecessary return logic

* removes null coalescing from includes in filter

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-02-13 08:48:24 -05:00
MadameSheema 25ae43acd7
refactors 'data-providers' tests (#57474) (#57553) 2020-02-13 14:16:49 +01:00
MadameSheema 70fcc3d887
refactors pagination tests (#57348) (#57464) 2020-02-13 12:30:51 +01:00
Pierre Gayvallet 07ceb70278
add absolute option to getUrlForApp (#57193) (#57543) 2020-02-13 12:28:03 +01:00
Gidi Meir Morris f75c10f30e
fixed flaky test (#57490) (#57500)
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-02-14 00:09:58 +13:00
Dario Gieselaar 8159718eee
[7.x] [APM] Remove initial time range for service maps (#57308) (#57450)
* [APM] Remove initial time range for service maps

The initial time range for the service maps request might no longer be necessary, from what I can tell. Not having it improves the overall loading time and the user experience.

* Remove loading indicator for service maps

* Don't unnecessarily paginate

* Unset loading indicator if component unmounts
2020-02-13 11:52:42 +01:00
Ahmad Bamieh d02fb7a928
[7.x] [Telemetry] Migrate public to NP (#56285) (#57534) 2020-02-13 11:41:31 +02:00
Alexey Antonov f3104aa77e
[ui/utils/query_string]: Remove unused methods & migrate apps to querystring lib (#56957) (#57533)
* replace querystring (querystring-browser) -> query-string

* QueryString remove encode/decode methods

* remove query_string file

* remove querystring-browser from package.json

* add kibana_utils\url module

* cleanup

* update notice.txt

* fix merge conflict

* fix CI

* fix wrong import

* fix CI

* fix X-Pack firefox smoke test

* remove urlUtils.parseUrlQuery

* remove url.stringifyUrlQuery

* use url.encodeQuery

* Record<string, any> -> ParsedQuery

* Update src/plugins/console/public/application/containers/editor/legacy/console_editor/editor.tsx

Co-Authored-By: Luke Elmers <lukeelmers@gmail.com>

* add more tests for APM

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Co-authored-by: Luke Elmers <lukeelmers@gmail.com>

# Conflicts:
#	x-pack/plugins/endpoint/public/applications/endpoint/store/alerts/middleware.ts
2020-02-13 12:18:46 +03:00
Tiago Costa 13de160e00
fix(NA): support legacy plugins path in plugins (#57472) (#57530)
* fix(NA): support legacy plugins path in plugins

* chore(NA): add newly build dist
2020-02-13 04:45:13 +00:00
Matthew Kime e96f0f4b11
Management Api - add to migration guide (#56892) (#57517)
* update management info in migration guide
2020-02-12 19:10:06 -06:00
Nathan Reese 2c5a5131ba
[Maps] Autocomplete for custom color palettes and custom icon palettes (#56446) (#57504)
* [Maps] type ahead for stop values for custom color maps and custom icon maps

* use Popover to show type ahead suggestions

* datalist version

* use EuiComboBox

* clean up

* wire ColorStopsCategorical to use StopInput component for autocomplete

* clean up

* cast suggestion values to string so boolean fields work

* review feedback

* fix problem with stall suggestions from previous field

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-02-12 16:08:11 -07:00