Commit graph

31662 commits

Author SHA1 Message Date
Nathan L Smith
a0a85dbb90
Simplify service map layout (#60949)
Clean up the cytoscape component and event handlers to simplify the layout logic.

Make all centering animations animated.

Add logging of cytoscape events when we're in debug mode.

Add Elasticsearch icon.
2020-03-23 16:13:56 -05:00
Dario Gieselaar
d5c13c043b
[APM] use span.destination.service.resource (#60908)
* [APM] use span.destination.service.resource

Closes #60405.

* update snapshots

Co-authored-by: Nathan L Smith <smith@nlsmith.com>
2020-03-23 16:13:32 -05:00
Wylie Conlon
f7a3049843
[Lens] Improve suggestions when dragging field for the second time (#60687)
* [Lens] Improve suggestions when dragging into an existing visualization

* Include 0 metrics case

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-03-23 17:11:09 -04:00
Devon Thomson
ec2972c224
Dashboard/add panel flow (#59918)
Added an emphasize prop to the top nav menu item and used it for a new 'Create new' button which redirects to the 'new visualization' modal.

Co-authored-by: Ryan Keairns <rkeairns@chef.io>
2020-03-23 17:03:01 -04:00
Wylie Conlon
3c924d9f87
[Lens] Use new charts APIs to simplify series naming (#60708)
* build: update @elastic/charts to v18.1.0

* tests: fix breaking-change on legendItem className

* fix: type changes and ml custom tooltip data

* tests: fix snapshot test

* [Lens] Use new charts APIs to simplify series naming

* Fix types

* Fix naming

* Remove accidental file

* Update snapshots

Co-authored-by: Marco Vettorello <vettorello.marco@gmail.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-03-23 16:44:57 -04:00
Nicolas Chaulet
3eeb8df172
[Fleet] add Agent config details yaml view (#60943) 2020-03-23 16:40:33 -04:00
Thomas Neirynck
88d41fa352
[Maps] Remove client-side scaling of ordinal values (#58528)
This removes the rescaling of ordinal values to the [0,1] domain, and modifies the creation of the mapbox-style rules to use the actual RangeStyleMeta-data. This is an important prerequisite for Maps handling tile vector sources. For these sources, Maps does not have access to the raw underlying GeoJson and needs to use the stylemeta directly.
2020-03-23 16:09:09 -04:00
Nathan Reese
d32c4c8390
[Maps] fix point to point source regression (#60930)
* [Maps] fix pew pew regression

* add functional test for pew pew source
2020-03-23 13:40:24 -06:00
Jen Huang
73deba16cc
Ensure that the default datasources use the default config's namespace (#60823)
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-03-23 12:22:26 -07:00
Lee Drengenberg
afca33b520
add relationship test on Saved Objects (#59968)
* just a demo of function to return saved object table elements

* fix esArchive data, extend import objects test case for relationships

* improved data-test-subjs

* update snapshot for jest test

* unskip other half of the tests

* removed commented-out code

* use new findByTestSubject methods

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-03-23 14:18:35 -05:00
Justin Kambic
ef48205f15
[Uptime] Add configurable page size to monitor list (#60573)
* Add configurable page size to monitor list.

* Add functional tests for new feature.

* Update outdated snapshots.

* Extract UI concerns for size select component to dedicated function.

* Add missing props to resolve type check errors.

* Add unit test for new UI functionality.

* Refresh snapshots after additional changes.

* Introduce new parameter to API test function.

* Update flex behavior for new UI component.

* Clean up code in functional page object file.

* Refresh snapshots that were broken by previous feedback implementation.

* Fix async error introduced to test framework by other patch.
2020-03-23 15:18:11 -04:00
Søren Louv-Jansen
65359856a0
[APM] Remote Agent Config: Add additional (java) options (#59860) 2020-03-23 20:14:26 +01:00
Poff Poffenberger
2da5d635bf
Re-enable a CSS fix for the Monaco Editor's focus behavior (#60803)
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-03-23 14:09:05 -05:00
Alejandro Fernández Haro
452193fdba
[Telemetry] Server-side Migration to NP (#60485)
* [Telemetry] Migration to NP

* Telemetry management advanced settings section + fix import paths + dropped support for injectVars

* Fix i18nrc paths for telemetry

* Move ui_metric mappings to NP registerType

* Fixed minor test tweaks

* Add README docs (#60443)

* Add missing translation

* Update the telemetryService config only when authenticated

* start method is not a promise anymore

* Fix mocha tests

* No need to JSON.stringify the API responses

* Catch handleOldSettings as we used to do

* Deal with the forbidden use case in the optIn API

* No need to provide the plugin name in the logger.get(). It is automatically scoped + one missing CallCluster vs. APICaller type replacement

* Add empty start method in README.md to show differences with the other approach

* Telemetry collection with X-Pack README

* Docs update

* Allow monitoring collector to send its own ES client

* All collections should provide their own ES client

* PR feedback

* i18n NITs from kibana-platform feedback

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-03-23 18:49:38 +00:00
Gidi Meir Morris
d8d06e7343
[Alerting] Fixes flaky test in Alert Instances Details page (#60893)
Fixes flaky test in Alert Instances Details page
2020-03-23 18:23:26 +00:00
Peter Pisljar
ed55531207
cleanup visualizations api (#59958) 2020-03-23 19:19:39 +01:00
Matthias Wilhelm
c537d453e6
Inline timezoneProvider function, remove ui/vis/lib/timezone (#60475)
* Inline getTimezone in discover, vis_type_timeseries,  timelion app & vis_type_timelion
2020-03-23 19:14:14 +01:00
MadameSheema
10afcf4be8
[SIEM] Adds 'Open one signal' Cypress test (#60484)
* adds data for having closed signals

* adds 'Open one signal when more than one closed signals are selected' test'

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-03-23 18:46:35 +01:00
Alison Goryachev
85481a7017
[UA] Upgrade assistant migration meta data can become stale (#60789) 2020-03-23 13:35:27 -04:00
Zacqary Adam Xeper
3c66662630
[Metrics Alerts] Remove metric field from doc count on backend (#60679)
* Remove metric field from doc count on backend

* Fix tests

* Type fix

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-03-23 12:33:00 -05:00
Andrew Cholakian
8143c078b6
[Uptime] Skip failing location test temporarily (#60938) 2020-03-23 12:54:49 -04:00
James Gowdy
de7151e204
[ML] Disabling datafeed editing when job is running (#60751)
* [ML] Disabling datafeed editing when job is running

* changing variable

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-03-23 16:40:56 +00:00
Mike Côté
91e8e3e883
Adding authc.invalidateAPIKeyAsInternalUser (#60717)
* Initial work

* Fix type check issues

* Fix test failures

* Fix ESLint issues

* Add back comment

* PR feedback

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-03-23 12:39:55 -04:00
Ryland Herrick
21e8cea183
[SIEM] Add license check to ML Rule form (#60691)
* Gate ML Rules behind a license check

If they don't have a Platinum or Trial license, then we disable the ML
Card and provide them a link to the subscriptions marketing page.

* Add aria-describedby for new ML input fields

* Add data-test-subj to new ML input fields

* Remove unused prop

This is already passed as isLoading

* Fix capitalization on translation id

* Declare defaulted props as optional

* Gray out entire ML card when ML Rules are disabled

If we're editing an existing rule, or if the user has an insufficient
license, we disable both the card and its selectability. This is more
visually striking, and a more obvious CTA.
2020-03-23 11:10:40 -05:00
Brandon Kobel
cca23c26fc
Adding authc.grantAPIKeyAsInternalUser (#60423)
* Parsing the Authorization HTTP header to grant API keys

* Using HTTPAuthorizationHeader and BasicHTTPAuthorizationHeaderCredentials

* Adding tests for grantAPIKey

* Adding http_authentication/ folder

* Removing test route

* Using new classes to create the headers we pass to ES

* No longer .toLowerCase() when parsing the scheme from the request

* Updating snapshots

* Update x-pack/plugins/security/server/authentication/http_authentication/http_authorization_header.ts

Co-Authored-By: Aleh Zasypkin <aleh.zasypkin@gmail.com>

* Updating another inline snapshot

* Adding JSDoc

* Renaming `grant` to `grantAsInternalUser`

* Adding forgotten test. Fixing snapshot

* Fixing mock

* Apply suggestions from code review

Co-Authored-By: Aleh Zasypkin <aleh.zasypkin@gmail.com>
Co-Authored-By: Mike Côté <mikecote@users.noreply.github.com>

* Using new classes for changing password

* Removing unneeded asScoped call

Co-authored-by: Aleh Zasypkin <aleh.zasypkin@gmail.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Co-authored-by: Mike Côté <mikecote@users.noreply.github.com>
2020-03-23 09:03:13 -07:00
Devon Thomson
05c995a939
Support Histogram Data Type (#59387)
Added the histogram field type to Kibana, to be used in the percentiles, percentiles ranks, and median aggregations.
2020-03-23 11:53:51 -04:00
Jean-Louis Leysens
938ad37640
[Upgrade Assistant] Fix edge case where reindex op can falsely be seen as stale (#60770)
* Fix edge case where reindex op is can falsely be seen as stale

This is for multiple Kibana workers, to ensure that an item just
coming off the queue is seen as "new" we set a "startedAt" field
which will update the reindex op and give it the full timeout
window.

* Update tests to use new api too

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-03-23 16:47:49 +01:00
Steph Milovic
969811eb20
[SIEM] [Cases] Update case icons (#60812) 2020-03-23 09:42:35 -06:00
Daniil Suleiman
1b583a2e27
[TSVB] Fix percentiles band mode (#60741)
* Fix percentiles band mode

* Add support of bar chart, fix tests

* Use accessor formatters

* Fix tests
2020-03-23 18:42:04 +03:00
Wylie Conlon
85615bdb3f
Fix formatter on range aggregation (#58651)
* Fix formatter on range aggregation

* Fix test that was using unformatted byte ranges

* Fix test

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-03-23 11:32:07 -04:00
Luke Elmers
3401ae42e0
Goodbye, legacy data plugin 👋 (#60449) 2020-03-23 09:17:27 -06:00
Phillip Burch
a790877694
[Metrics UI] Alerting for metrics explorer and inventory (#58779)
* Add flyout with expressions

* Integrate frontend with backend

* Extended AlertContextValue with metadata optional property

* Progress

* Pre-fill criteria with current page filters

* Better validation. Naming for clarity

* Fix types for flyout

* Respect the groupby property in metric explorer

* Fix lint errors

* Fix text, add toast notifications

* Fix tests. Make sure update handles predefined expressions

* Dynamically load source from alert flyout

* Remove unused import

* Simplify and add group by functionality

* Remove unecessary useEffect

* disable exhastive deps

* Remove unecessary useEffect

* change language

* Implement design feedback

* Add alert dropdown to the header and snapshot screen

* Remove icon

* Remove unused props. Code cleanup

* Remove unused values

* Fix formatted message id

* Remove create alert option for now.

* Fix type issue

* Add rate, card and count as aggs

* Fix types

Co-authored-by: Yuliia Naumenko <yuliia.naumenko@elastic.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Co-authored-by: Henry Harding <henry.harding@elastic.co>
2020-03-23 10:02:11 -05:00
Alison Goryachev
8572e3f18f
[Remote clustersadopt changes to remote info API (#60795) 2020-03-23 10:42:40 -04:00
Brian Seeders
42539a56eb
Only run xpack siem cypress in PRs when there are siem changes (#60661) 2020-03-23 10:30:14 -04:00
Brian Seeders
c22dbb1764
[CI] Add error steps and help links to PR comments (#60772) 2020-03-23 10:29:33 -04:00
Dmitry Lemeshko
c7b0ade01d
skip flaky functional test (#60898) 2020-03-23 17:06:19 +03:00
Gidi Meir Morris
a5aafc039d
[Alerting] Fixes mistake in empty list assertion (#60896) 2020-03-23 13:56:26 +00:00
Bhavya RM
e235321903
a11y tests for login and logout (#60799)
a11y login screen
2020-03-23 09:45:19 -04:00
Gidi Meir Morris
7dc45f5441
removed boom errors from AlertNavigationRegistry (#60887) 2020-03-23 13:12:53 +00:00
Cauê Marcondes
7eec879547
[APM]Create custom link from Trace summary (#59648)
* adding custom links to actions menu

* user should have at least gold license to be able to manage custom links

* replacing variable for the correspondent value

* refactoring license prompt to a shared place

* fixing query to return filters that were saved separated by comma

* refactoring license prompt to a shared place

* fixing query to return filters that were saved separated by comma

* adding unit test, splitting value by comma and removing empty ones

* adding custom links to actions menu

* UI fixes

* moving stuff to common

* changing flyout texts

* refactoring getSelectOption

* refactoring getSelectOption

* refactoring filter options name

* adding preview panel

* adding preview panel

* fixing test

* adding unit test for replace template variables

* fixing typo

* polishing preview panel

* fixing pr comments

* fixing pr comments

* adding links

* fixing unit test

* removing servicemap license prompt
2020-03-23 12:48:58 +01:00
James Gowdy
b03a3628dd
[ML] Fixing app clean up (#60853) 2020-03-23 10:38:51 +00:00
Tudor Golubenco
7bafeb1d6f
[SIEM] Use ECS categorisation for Authentication widgets (#60734)
* Update the Authentication histogram to use categorization fields

* linting

* Use categorization fields for the Authentications table

* Use event.outcome for authentications KPIs

* Adjust mock to fix unit test

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-03-23 10:29:38 +01:00
Daniil Suleiman
afd1179c0d
[NP] Remove kbnUrl usage in discover/dashboard/visualize (#60016)
* Remove kbnUrl usages from disciver/dashboard/visualize

* Remove kbnUrl usage in angular_config

* Wrap with encodeURIComponent

* Fix reloading when base path

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-03-23 10:57:03 +03:00
Brian Seeders
8b2ffafa1d
Skip failing test 2020-03-22 20:32:42 -04:00
Shahzad
b909742a40
[Uptime]Update fetch effect failed action handling (#60742)
* update fetch effect

* added test

* update type
2020-03-22 18:17:03 +01:00
Spencer
33af1c154b
[npm] upgrade elastic/maki (#60829)
Co-authored-by: spalger <spalger@users.noreply.github.com>
2020-03-21 17:37:55 -07:00
Andrew Cholakian
c2e57af277
[Uptime] Add Settings Page (#53550)
Adds a settings page to the Uptime UI. The settings page values are per-space. The only current setting is heartbeatIndices.

To test this against alternate indices try changing setup.ilm.rollover_alias in heartbeat.yml to something like alt-prefix. See the ilm docs for more details.

This should be tested with read-only and write only roles. To test this in kibana try creating two users with two different roles in kibana. One roll should have read access to the Uptime space in kibana. The other should have all access. Both should have read permissions for the heartbeat-* index pattern.

This patch also splits API perms from just heartbeat to uptime-read and uptime-write.

This patch also refactors some of the header component functionality, using hooks for breadcrumbs, and making the top links optional.

Fixes elastic/uptime#43
2020-03-21 18:13:01 -05:00
Søren Louv-Jansen
d3a9531270
[APM] service maps: avoid unnecesary useDeepObjectIdentity (#60836)
* [APM] service maps: avoid unnecesary `useDeepObjectIdentity`

* Remove unused dep
2020-03-21 21:41:54 +01:00
Sébastien Loix
8ccaa2e62f
[Index management] Re-enable index template tests (#60780) 2020-03-21 17:01:01 +01:00
Yuliia Naumenko
0390251f69
Fixed UI/UX issues: alerts delete confirmation, combobox behaviors (#60703)
* Fixed UI/UX issues: alerts delete confirmation

* Fixed 4. Popover disappears when clearing the field selector

* Fixed tests

* Fixed due to comments

* fixed tests

* Fixed test
2020-03-20 21:29:06 -07:00