Commit graph

42727 commits

Author SHA1 Message Date
Aaron Caldwell 7a92ea3e10
[Maps][File upload] Add validation check that ensure index name has been provided (#99118) 2021-05-03 18:42:01 -04:00
Jonathan Budzenski c7977614ed
[docs/build] Update build dependencies list (#98545)
Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-05-03 17:04:34 -05:00
Nicolas Chaulet b2a20fc9af
[Fleet] Fix fleet server host port during settings creation (#99084) 2021-05-03 17:42:07 -04:00
Tiago Costa 4af6e9c691
chore(NA): moving @kbn/analytics into bazel (#98917)
* chore(NA): moving @kbn/analytics into bazel

* chore(NA): fix type check for package migration

* chore(NA): fix type check for package migration

* chore(NA): fix type check for package migration

* chore(NA): separate type generating from server code

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-05-03 22:34:53 +01:00
Aaron Caldwell 58b3c1bf13
Fix malformed geo alerts call to transformResults (#98094)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-05-03 17:30:19 -04:00
Constance 292b6d2638
[Enterprise Search] Refactor shared SchemaAddFieldModal component (#99096)
* Move SchemaAddFieldModal to its own folder

+ misc test cleanup - remove unnecessary jest.spyOn in individual tests, it's already in the beforeEach

* i18n fixes

- Move constants to subfolder
- Fix various i18n IDs/var names - modal titles is not a fieldNote title
- Fix an i18n string that should be a FormattedMessage (could have grammar issues otherwise)
- Add missing i18n strings - labels (shared, AS will also use these as column headers) & placeholder
- Import order

* Move formatFieldName util to its own file

- simplify leading/trailing trimming regex
- add unit tests - primarily for documenting regexes & providing examples

* Refactor modal form submission

- See https://elastic.github.io/eui/#/layout/modal#forms-in-a-modal for documentation - form should be submitted via ID & EuiModalFooter form={id}

* Misc props cleanup

- Move optional props to bottom of type list
- Remove unnecessary props (default EUI behavior)
- Data test subj cleanup
- Add missing `disabled` passed prop, add unit test for disableForm prop
2021-05-03 14:29:36 -07:00
Yara Tercero ae2e0766f9
[Security Solution][Timeline] - update flakey timeline cypress tests (#99097)
###Summary

Removes some anti-patterns I introduced in my last PR and makes use of Cypress' chainable pattern that will hopefully help with the flakiness.
2021-05-03 13:34:16 -07:00
Nicolas Chaulet 0401d2f5c8
[Fleet] Remove Agent events saved object and unused types (#98739) 2021-05-03 15:45:01 -04:00
Justin Ibarra 28168714f0
[Detection Rules] Add 7.13 rules (#98975) 2021-05-03 11:43:41 -08:00
Spencer a5c7f6cfdc
[x-pack/build] exclude plugins/*/target when copying source to build (#99009)
Co-authored-by: spalger <spalger@users.noreply.github.com>
2021-05-03 12:34:16 -07:00
CJ Cenizal 9acdfaaf66
Reintroduce 96111: Provide guidance of "Custom" allocation behavior in ILM (#99007) 2021-05-03 12:29:57 -07:00
Jason Stoltzfus ad9f1c3155
Fixed Search UI route (#99065) 2021-05-03 13:57:39 -04:00
Brian Seeders f404305eaa
[CI] Create a ciGroup just for tests that use Docker (#98535) 2021-05-03 13:53:22 -04:00
Poff Poffenberger da785eae04
Revert "Revert "Add essql search strategy and integrate in canvas (#94754)" (#98841)
* Revert "Revert "Add essql search strategy and integrate in canvas (#94754)""

This reverts commit 0f15a12420.

* Update squel usage to safe-squel

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-05-03 12:42:26 -05:00
Tim Sullivan 1ce0cf6f5d
Reporting/Docs: update version of reporting_user deprecation (#98988) 2021-05-03 10:35:12 -07:00
Dima Arnautov 4da34bb0f3
[ML] Fix pagination and sorting on trained models list page (#99061) 2021-05-03 19:28:34 +02:00
Constance 49b6583946
[Enterprise Search] Refactor out IndexingStatus to just a SchemaErrorsCallout (#98969)
* Create new SchemaErrorsCallout component
- will replace IndexingStatus and IndexingStatusErrors

- The concept of "indexing status"/loading no longer really exists, now that schema updates instantly

* Update views to use new SchemaErrorsCallout
- instead of IndexingStatus component

* Remove remaining concepts of an indexing job/loading progress

+ remove /status reindex_job routes, since we no longer need to poll for indexing status

* Remove IndexingStatus components

* Update i18n

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-05-03 12:50:27 -04:00
Patryk Kopyciński 3f39f5e275
[Osquery] Fix Live query form errors handling (#99015) 2021-05-03 18:50:07 +02:00
Nathan Reese 85b78711c6
[Maps] add attribution to layer editor (#98328)
* [Maps] add attribution to layer editor

* update sources to getAttributionProvider

* remove attribution UI from EMS_XYZ source

* remove attribution UI from WMS source editor

* clean up

* tslint

* AttributionFormRow jest test

* add migration

* tslint

* i18n fixes

* attribution

* [Maps] Improving design and a11y for attribution layer settings (#38)

* Design and a11y improvements

* Buttons aria labels

* Addressing PR review

* tslint and i18n fixes

* update jest snapshots

* remove placeholder for url

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Elizabet Oliveira <elizabet.oliveira@elastic.co>
2021-05-03 10:42:07 -06:00
Tiago Costa 24fd3a1e18
fix(NA): @kbn/babel-code-parser bazel build to link to the local .babelrc config (#99003)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-05-03 17:29:14 +01:00
Cauê Marcondes f1365eaa80
[APM] Creating e2e test for Comparison Feature (#98291)
* creating e2e test comparison feature

* fixing test

* comparison e2e tests

* addressing comments

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-05-03 11:59:42 -04:00
Brandon Kobel 5b50bee17d
Adding section about how the RFC's approach scales (#99050) 2021-05-03 08:26:51 -07:00
Yara Tercero a0e20c010a
[Security Solution][Timeline] - Fix the continued flake for one of the timeline cypress tests (#98637)
This PR addresses continued flake with the notes tab cypress tests.
2021-05-03 08:04:43 -07:00
Sergi Massaneda b3640079bf
check data present for apm indices to consider it exists on seach strategy (#98940)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-05-03 17:02:26 +02:00
Walter Rafelsberger 763e08a1dd
[ML] Transforms/Data Frame Analytics: Fix data grid height. (#98923)
Adds a short term fix/override for the height of data grid in transform and data frame analytics wizards.
EUI itself sets the height style of euiDataGrid__virtualized. For some reason it's not able to adjust that height within the wizards when you toggle histogram visibility or change rows shown per page.
This PR fixes it by wrapping the data grid with EuiMutationObserver to listen for updates within the data grid and setting the height of euiDataGrid__virtualized to auto on every update. For now this should be a safe short term fix since we don't use the full screen option.
2021-05-03 16:55:00 +02:00
Tiago Costa 38a8989a9c
skip flaky suite (#98247) 2021-05-03 15:44:51 +01:00
ymao1 951da754e0
Allowing validation of multiple actions with same connector id (#98065)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-05-03 10:11:49 -04:00
Nathan L Smith 2fbfca63d7
Turn off progress plugin in storybook (#98253)
Before:

```
info => Loading static files from /Users/smith/Code/kibana/node_modules/@kbn/ui-shared-deps/target and serving at /.
info => Loading presets
info => Loading presets
info => Loading 8 other files in "x-pack/plugins/apm/.storybook"
info => Adding stories defined in "x-pack/plugins/apm/.storybook/main.js"
info => Using default Webpack setup
... like 300MB of output ...
webpack built 0f7b67ae2a8a0401f5af in 105247ms
```

After:

```
info => Loading static files from /Users/smith/Code/kibana/node_modules/@kbn/ui-shared-deps/target and serving at /.
info => Loading presets
info => Loading presets
info => Loading 8 other files in "x-pack/plugins/apm/.storybook"
info => Adding stories defined in "x-pack/plugins/apm/.storybook/main.js"
info => Using default Webpack setup
... yeah it just sits there for a bit, but were you reading this and did you believe the percentages you were being told? ...
webpack built 0f7b67ae2a8a0401f5af in 105247ms
```

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-05-03 07:36:17 -05:00
Alejandro Fernández Gómez 4c4dddfac1
[Fleet] Namespace - Provide better descriptions and access to more info (#98779)
Co-authored-by: Brandon Morelli <bmorelli25@gmail.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-05-03 08:35:28 -04:00
John Schulz 62635aeade
[Fleet] Remove disabled uninstall button for some integrations (#98970)
* Update integration settings tab. Remove uninstall button for some integrations.

* Fix i18n & type/logic
2021-05-03 12:58:41 +02:00
Alexey Antonov 582e6362c7
[visualizations] Reduce page load bundle to under 100kB (#98302)
* [visualizations] Reduce page load bundle to under 100kB

* move scss to async chunks

* fix CI

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-05-03 13:22:40 +03:00
Anton Dosov ff3badd80d
[Search Sessions] adjust docs for 7.13 changes (#98919)
Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>
2021-05-03 11:22:07 +02:00
Quynh Nguyen cbcc800a6b
[ML] Remove versioning check for Analytics list row expansion content functional tests (#98828)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-05-02 21:34:43 -05:00
spalger d40adb9b70 Revert "Provide guidance of "Custom" allocation behavior in ILM (#96111)"
This reverts commit 8ae49a4900.
2021-05-01 01:10:32 -07:00
CJ Cenizal 8ae49a4900
Provide guidance of "Custom" allocation behavior in ILM (#96111)
* Provide allocation behavior guidance when the user has selected Custom, but no attributes are available and:
  ...data nodes are in use, so indices will allocate to data nodes.
  ...data tiers are available, so indices will allocate to data tiers.
  ...data tiers are available but not for the given phase's tier, so indices will be allocated to a fallback data tier.
  ...no data tiers are available, so allocation won't occur.
* Provide link to the migration docs.
* Adjust copy to consistently notify the user that node attributes are missing and guide them to use role-based allocation.
* Localize disableDataTierOption flag instead of passing it as a prop, to make it easier to reason about.
* Clarify the scenario in which the user has selected node_attrs allocation but no data tiers are available.
* Remove inapplicable frozen tier from NoTiersAvailableNotice.
* Refactor and update tests.
  * Split up node allocation tests to improve discoverability. Refactor test helpers to define suite-specific helper interfaces, to improve maintainability.
  * Refactor tests to make the [using node attributes, using node roles] branch and the various conditions within easier to contrast and compare.
  * Add coverage for NoTiersAvailableUsingNodeAttributesNotice scenario.
  * Add some helpers for improved maintainability and readability.
  * Create helpers/types file to store extracted Phase type.
2021-04-30 21:37:42 -07:00
Nicolas Chaulet 5ff845a512
[Fleet] Enforce port in fleet server url even for default http|https port (#98957) 2021-04-30 20:58:50 -04:00
Tim Sullivan 832d3b7ffd
[Reporting] code cleanup for reporting browser build/install/setup utilities (#98799)
* [Reporting] code cleanup for reporting browser setup utilities

* fix target_cpu

* Update README.md

* Update README.md

* add note about target_cpu

* Update paths.ts

* more cleanup

* Update src/dev/chromium_version.ts

Co-authored-by: Michael Dokolin <dokmic@gmail.com>

* remove bug

Co-authored-by: Michael Dokolin <dokmic@gmail.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-04-30 19:25:19 -04:00
Frank Hassanabad 93b064930a
Fixes some flake by loosening up some test logic around 0 (#98959)
## Summary

Fixes test flake:
https://github.com/elastic/kibana/issues/97365

By changing exact to an above count. I think the view of the index this large is not being given back consistent and could be a possible tooling gotcha, but I don't think we have a bug around this area. Either way, the test is still a valid test to ensure we don't blow up with errors, I just don't also test for exactness anymore. 

Since this fixes tests and has no other inherit risk but should bring stability, I marked it as being back ported into the 7.13 branch for the next BC build of 7.13.

### Checklist

- [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
2021-04-30 17:17:32 -06:00
John Schulz 3b869e85b5
[Fleet] Hide delete policy button for default policies (#98962)
* Hide delete policy button for default policies

* Update x-pack/plugins/fleet/public/applications/fleet/sections/agent_policy/components/agent_policy_form.tsx

Co-authored-by: Nicolas Chaulet <n.chaulet@gmail.com>

* Fix formatting

Co-authored-by: Nicolas Chaulet <n.chaulet@gmail.com>
2021-04-30 18:00:45 -04:00
Tiago Costa 788bf329b1
chore(NA): moving @kbn/eslint-plugin-eslint into bazel (#98926)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-04-30 22:31:38 +01:00
CJ Cenizal 6bc8ed8ec0
Update ILM searchable snapshot copy to refer to fully-mounted indices and partially-mounted indices (#98693)
* Change Searchable snapshot repository label to to Snapshot repository.
2021-04-30 14:25:48 -07:00
Jason Stoltzfus 7cabbb81ba
[App Search] Add logic and routes for Search UI (#98641) 2021-04-30 17:10:41 -04:00
Brian Seeders 9cec2ae99b skip flaky suite (#98910) 2021-04-30 17:06:17 -04:00
Spencer 246f4be00e
require successful ci-stats for build success in PRs (#98846)
Co-authored-by: spalger <spalger@users.noreply.github.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-04-30 13:49:00 -07:00
Constance 8810e8484c
[Enterprise Search] Refactor SchemaExistingField component to SchemaFieldTypeSelect (#98955)
* Refactor SchemaExistingField to just the select component

- Removes unnecessary CSS, conditionals, etc. (letting AS & WS manage their own table/row views & styling)
+ Move to its own component folder for organization

* Update WS to use new SchemaFieldTypeSelect component

* Update SchemaAddFieldModal to dogfood SchemaFieldTypeSelect component

- DRY's out fieldTypeSelectOptions to only having to exist within SchemaFieldTypeSelect

* i18n cleanup

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-04-30 16:25:08 -04:00
Marshall Main 2236633184
Allow saved_query rules to validate properly for query executor (#98921)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-04-30 16:22:08 -04:00
Kevin Logan 5203859cf9
[Security Solution][Detections] Make Endpoint Exception field options aware of OS, introduce OS selection to Endpoint Exceptions flow (#95014) 2021-04-30 16:18:40 -04:00
Jonathan Budzenski 3d8f1b1b3b
[packages] Move @kbn/legacy-logging to Bazel (#98810) 2021-04-30 14:34:37 -05:00
Tiago Costa 93ed44d2d4
chore(NA): moving @kbn/eslint-import-resolver-kibana into bazel (#98798) 2021-04-30 20:14:18 +01:00
Dominique Clarke 82c3cba739
uptime - update uptime page styles (#98936) 2021-04-30 14:56:26 -04:00