Commit graph

42727 commits

Author SHA1 Message Date
Kevin Qualters a80cdf7bd2
[RAC][Alert Triage][TGrid] Update the alerts table/tgrid API to support customized leadingControlColumns and trailingControlColumns (#98845)
* Leading/trailing control columns first pass

* Add leading and trailing action column tests

* Remove unused prop type

* Use control column array constants
2021-04-30 14:36:48 -04:00
Frank Hassanabad af228f0f20
[Security Solutions] (Phase 1) Adds an application cache called metrics entities and integrates it within Security Solutions behind a feature flag (#96446)
## Summary

Phase 1 of a multi-phase cautious approach for adding an experimental application cache for Kibana solutions called `metric_entities` and integrates it within Security Solutions.

Phase 1 is putting experimental support into the application without breaking existing features. Lots of TODO's, conversations and a possible RFC from phase 1 to phase 2 approach. Some features are missing, but for phase 1 the general idea and code is all there.

To enable this first phase after checking out the branch add this to your `kibana.dev.yml`

```yml
xpack.metricsEntities.enabled: true
xpack.securitySolution.enableExperimental: ['metricsEntitiesEnabled']
```

Then go into Stack Management -> Advanced Settings (Under Security Solutions) and set the enabled to true like so:
<img width="1229" alt="Screen Shot 2021-04-08 at 2 21 02 PM" src="https://user-images.githubusercontent.com/1151048/114091276-b3cbb700-9875-11eb-9083-5c1d91dd20ed.png">

Next go to the security_solutions page and you will see it being activated and you will have these transforms running if you look under stack management:
<img width="1710" alt="Screen Shot 2021-04-29 at 2 00 27 PM" src="https://user-images.githubusercontent.com/1151048/116611174-4a2e4e00-a8f3-11eb-9e15-55cb504dfb2a.png">

On the hosts page, network, page, etc... You can see them being activated when you have no query/filter and you click on request:
<img width="1405" alt="Screen Shot 2021-04-29 at 2 01 28 PM" src="https://user-images.githubusercontent.com/1151048/116611274-6a5e0d00-a8f3-11eb-9998-9f5b3d1c5c63.png">

You will see in the request the index patterns all starting with `estc_xyz*`

### Checklist

Delete any items that are not applicable to this PR.

- [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md)

We have lots of TODO's but no concrete docs with this just yet.
- [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials

Behind a feature flag and this isn't there yet.
- [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
2021-04-30 12:36:06 -06:00
Dima Arnautov 4686f442ee
[ML] Fix alerting rule preview (#98907) 2021-04-30 14:03:05 -04:00
Shahzad d9bc163603
[Exploratory view] Restore links for ux/synthetics data (#98759) 2021-04-30 13:08:45 -04:00
Michael Olorunnisola 78e721fdce
[Security_Solution][ Fix alert details table and resolver scroll bug (#98546) 2021-04-30 12:45:56 -04:00
Alison Goryachev ddeffb5b5e
[Upgrade Assistant] Improve loading/error states for deprecation toggle (#97294) 2021-04-30 12:34:53 -04:00
Alison Goryachev 7a6dccaa38
[Snapshot and Restore] Remove box shadow from panels (#98292) 2021-04-30 12:30:36 -04:00
Nicolas Chaulet 1875ea0a64
[Fleet] Create default fleet server hosts during fleet migration (#98913) 2021-04-30 11:23:13 -05:00
Constance a5d910d50c
[App Search] Schema: route & bare-bones views setup (#98679)
* Set up basic Schema skeleton views+router

* Update engine router + nav with new schema routes

* Breadcrumbs

* PR feedback: derpin

Co-authored-by: Jason Stoltzfus <jastoltz24@gmail.com>

* reindexJobId pls

* my life is in shambles

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Jason Stoltzfus <jastoltz24@gmail.com>
2021-04-30 09:22:16 -07:00
Constance 40282f8128
[Enterprise Search] Refactor shared schema types (#98801)
* Move schema-specific shared types to shared/schema folder

- This helps provide more context when people are reaching into shared types grab items, and keeps concepts/components together
+ minor comment updates

* Convert interfaces to Records where applicable

- see https://www.typescriptlang.org/docs/handbook/utility-types.html#recordkeystype

* [Opinionated] Change schema types to enums and DRY out field_types constants

- in favor of using SchemaType enum keys and iterating

- Not 100% sure about this as the internet seems to think string unions are still pretty good, but since we're using const references for the types anyway, it seems like the use case fits

* Update files to use new schema type enum

* Update all remaining files (basic imports)

* [Misc] DRY out FieldCoercionErrors type

+ change to record
- AS will also use this type
2021-04-30 09:14:58 -07:00
Lisa Cawley 23b832b6ab
Use doc link services in CCR (#98436)
Co-authored-by: Alison Goryachev <alisonmllr20@gmail.com>
2021-04-30 09:04:54 -07:00
Larry Gregory a5e80567e4
Reduce security plugin page load bundle (#98819) 2021-04-30 11:19:39 -04:00
Brandon Morelli bab9065f3d
docs: update service overview for comparison (#98843) 2021-04-30 08:03:32 -07:00
Nathan Reese ff8f4fb2a5
[Maps] 7.13 doc updates (#98687)
* [Maps] 7.13 doc updates

* tooltip updates

* clean up

* Update docs/maps/search.asciidoc

Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>

* Update docs/maps/search.asciidoc

Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>

* Update docs/maps/vector-tooltips.asciidoc

Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>

* review feedback

Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>
2021-04-30 08:45:31 -06:00
Felix Stürmer 0e948cffc9
[Logs UI] Prevent broken KIP references from breaking the Logs UI (#98532)
This fixes problems in handling broken KIP references and reduces the risk of broken references occurring the first place.
2021-04-30 16:18:52 +02:00
Alison Goryachev 577948bea3
[Upgrade Assistant] Support Kibana deprecations (#97159) 2021-04-30 09:03:44 -04:00
Diana Derevyankina 36ee2a7582
Pie: Field names are not escaped in expression (#98115)
* Pie: Field names are not escaped in expression

* Add a test case for single and double quotes to pie_fn.test

* Revert pie_fn and its test, remove escaping for vis config

* Update to_ast_pie

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-04-30 15:23:59 +03:00
Tim Roes 5cf1d10a77
Replace old elasticsearch client types by new ones (#98740) 2021-04-30 14:16:49 +02:00
Kerry Gallagher f5581240bb
Handle undefined case (#98728) 2021-04-30 12:51:20 +01:00
Walter Rafelsberger 5793719b13
[ML] Align transform id validation with regexp used in ES code. (#98783)
Fixes isTransformIdValid() to use the same RegExp used in Elasticsearch's transform code.
2021-04-30 12:42:48 +02:00
Walter Rafelsberger 98a284038b
[ML] Data Frame Analytics: Fix special character escaping for Vega scatterplot matrix. (#98763)
- Fixes correctly escaping the characters .[] in field names with double backslashes since Vega treats dots/brackets in field names special to be able to access attributes in object structures. This replaces the old approach that replaced dots with a similar but different UTF-8 character but missed the brackets.
- Additionally adds an EuiErrorBoundary component around the VegaChart component so we don't crash the whole page should another issue with Vega bubble up.
2021-04-30 12:40:11 +02:00
Mikhail Shustov 33eecc2979
improve type safety for integration test helpers (#98731)
* convert functional_tests/lib into TS

* convert ES cluster factory into TS

* fix exports from kbn-test

* fix core test_helpers

* remove legacy ES client usage in ui_settings tests

* remove unnecessary ts-expect-errors comments

* initialize DEFAULT_SETTINGS_WITH_CORE_PLUGINS lazily to prevent failure when imported outside of FTR context

* throw an exception on invalid process.env.TEST_ES_PORT
2021-04-30 05:31:17 -04:00
Pierre Gayvallet 05e2ab4df1
Add upsert support for savedObjects update (#98712)
* Add upsert support for savedObjects update

* fix types

* update generated docs

* update docs

* fix types

* do not use update attributes for upsert
2021-04-30 11:10:50 +02:00
Diana Derevyankina 6b6ad111c0
[TSVB] Timeseries Drop last bucket set default to false (#97257)
* [TSVB] Timeseries Drop last bucket should default to false

* Rename isLastBucketDropped prop and move series domain calculation to a separate file

* Fix failing tests because of wrong default value

* update drop_last_bucket.js

* Refactor drop_last_bucket and some functional tests

* Change infra metrics test values because of last bucket value changed

* Refactor series_domain_calculation and related code

* Update series_domain_calculations.test

* Update series_domain_calculations.test

* Fix tooltip showing wrong time

* Refactor index

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Alexey Antonov <alexwizp@gmail.com>
2021-04-30 11:48:10 +03:00
Jean-Louis Leysens e297fec23e
[Watcher] Migrate to new ES client (#97260)
* initial migration away from ILegacyScopedClusterClient to
IScopedClusterClient and from "isEsError" to "handleEsError"

* re-instate ignore: [404]

* remove use of ignore_unavailable

* get the correct payload from the response

* fix use of new licensePreRoutingFactory

* fix jest tests

* address CJs feedback and re-add ignore_unavailable, clean up remaining TODOs

* remove legacy client config

* undo renaming as part of destructuring assignment

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-04-30 10:44:08 +02:00
Matthias Wilhelm a8d4145afb
[Discover] Revert default grid back to legacy (#98508) 2021-04-30 10:29:41 +02:00
Dima Arnautov 036821d46a
[ML] show legend on the view by swim lane (#98754) 2021-04-30 10:01:20 +02:00
Shahzad b6b1d6970a
[Uptime] Fix uptime monitor status alert search param editing (#98514)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-04-30 09:28:46 +02:00
Marta Bondyra 78bb6413a7
fix duplication of columns with references (#97802)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-04-30 09:17:01 +02:00
Dominique Clarke 707a0ca1f2
unskip flaky jest settings-test (#98525)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-04-29 22:54:15 -04:00
Dominique Clarke e08d36d22c
[Uptime] unskip monitor state scoping tests (#98519)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-04-29 22:53:55 -04:00
Ross Wolf 0ddea04544
Make security rules optional (revert #97191) (#98854) 2021-04-29 19:59:52 -06:00
Nicolas Chaulet 8bd47f4194
[Fleet] Remove fleet_enroll user reference (#98745) 2021-04-29 21:00:42 -04:00
Marshall Main f16f98b502
[Security Solution] Improve export rules performance (#98446)
* Retrieve rules to export with a single query, greatly improving export performance

* Chunk rule IDs so exporting more than 1024 rules works

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-04-29 21:00:22 -04:00
Dominique Clarke d594da640b
[Uptime] - anomaly detection - adjust content for SelectSeverity (#97841)
* Uptime - anomaly detection - adjust content for SelectSeverity

* uptime - update anomaly alert to use getSeverity util

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-04-29 18:24:15 -04:00
Cauê Marcondes d111c27808
[APM] Transaction duration histogram buckets without samples are clickable (#98540)
* adding no samples label on distribution chart

* adding custom tooltip

* addressing PR comments
2021-04-29 16:57:06 -04:00
Jonathan Budzenski 0f15a12420 Revert "Add essql search strategy and integrate in canvas (#94754)"
This reverts commit 2628cea05e.
2021-04-29 15:52:18 -05:00
Nicolas Chaulet 613267f94d
[Fleet] Add sudo to fleet managed instructions (#98803) 2021-04-29 16:45:46 -04:00
Constance d26f1dc82b
[App Search] Synonyms: Create/update/delete & modal behavior (#98344)
* Add SynonymsLogic create/update/delete actions & modal state

* [Setup] Update MultiInputRows to work with a ModalFooter submit + allow hiding submit button

* Add SynonymModal component

* Update existing views with modal behavior

* PR feedback: Fix MultiInputRows to not render a form component for Relevance Tuning / onChange-only components

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-04-29 13:35:57 -07:00
Poff Poffenberger 2628cea05e
Add essql search strategy and integrate in canvas (#94754)
* Add essql search strategy, new escount temporary function, and new essql temporary function

* Move old es* functions to legacy, add esdocs to use search strategy, add parameter arg for essql

* Clean up

* cleanup

* cleanup

* Move request builder files to common

* cleanup

* add comment

* PR Feedback

* Removing old types

* update type

* Add data.search to labs and fix error messages

* Fix function help type

* Add data service to usage collector types

* Update telemetry

* remove unrelated telemetry change

* Enable multi value leniency for SQL  queries

* Display data service lab project
2021-04-29 14:58:11 -05:00
Zacqary Adam Xeper 0f6923ac0c
[Fleet] Hide Fleet Server policies in standalone agent instructions (#98787) 2021-04-29 15:18:49 -04:00
Tiago Costa 480483bacc
chore(NA): correctly define sourceRoot for @kbn/config-schema (#98788) 2021-04-29 20:16:30 +01:00
Larry Gregory 10961cd9c7
Handle 503 responses from the status API (#98738)
* Handle 503 responses from the status API

* PR feedback: additional test
2021-04-29 15:10:25 -04:00
Spencer 1cd101a3eb
[cli/serve/integrationTests] log stdout from process when parsing fails (#98699)
Co-authored-by: spalger <spalger@users.noreply.github.com>
2021-04-29 14:59:40 -04:00
Cauê Marcondes a48b7b049c
[APM] Improving e2e test setup (#98743)
* creating different users to run the test

* fixing ts file

* fixing TS issues

* improving e2e tests

* removing commented lines

* fixing ts issues

* fixing ts issues

* fixing ts issues
2021-04-29 14:46:22 -04:00
Quynh Nguyen dc4437a7d0
[ML] Disable Single Metric Viewer and Anomaly explorer charts for nested terms aggregations (#98510) 2021-04-29 13:33:09 -05:00
Andrew Goldstein 6198419e30
[Security Solution][Timeline] Fixes an issue where many OR clauses take up too much vertical space (#98706)
## [Security Solution][Timeline] Fixes an issue where many `OR` clauses take up too much vertical space

This PR makes Timeline's drag and drop query area resizable and scrollable to fix an issue reported by @aarju, where many `OR` clauses take up too much vertical space in Timeline.

To fix this issue:

* Timeline's drop area is now resizable
* The drop area still grows vertically, up to one third the size of the view hight
* A vertical scroll bar will automatically be displayed when entire query doesn't fit vertically within the drop area

The fix is shown in the animated gif below:

![resize_drop_area](https://user-images.githubusercontent.com/4459398/116512337-1caabb80-a885-11eb-8118-8eba46753435.gif)

_Above: Timeline's drop area is now resizable and scrollable_

### Side-by-side comparison

The side-by-side browsers in the image below show the same timeline in full screen mode before the fix (on the left), and after the fix (on the right):

![before_and_after](https://user-images.githubusercontent.com/4459398/116512491-5aa7df80-a885-11eb-9235-498d9e3a99ff.png)

_Above: Timeline in full screen mode before the fix (left), and after the fix (right)_

### Steps to reproduce

1. Create a new timeline
2. Drag approximately 15 fields as separate OR clauses to the timeline, as shown in the screenshot below:

![many_or_clauses](https://user-images.githubusercontent.com/4459398/116495389-076f6600-a860-11eb-8e43-e9e399149103.png)

**Expected behavior:**

* The drop area can be resized and scrolled

**Actual behavior:**

* The drag area keeps growing and pushing the table content down
2021-04-29 12:07:55 -06:00
Quynh Nguyen d9a80d5bca
[ML] Fix Single Metric Viewer annotation tooltip hard to trigger (#98233)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-04-29 12:55:17 -05:00
gchaps 41ded7a8a2
[DOCS] Updates saved searches doc (#97936)
* [DOCS] Updates saved searches doc

* [DOCS] Adds info on adding a saved search to a dashboard

* [DOCS] Fixes silly typo

* Update docs/discover/save-search.asciidoc

Co-authored-by: Matthias Wilhelm <ankertal@gmail.com>

* Update docs/discover/save-search.asciidoc

Co-authored-by: Matthias Wilhelm <ankertal@gmail.com>

* Update docs/discover/save-search.asciidoc

Co-authored-by: Matthias Wilhelm <ankertal@gmail.com>

* [DOCS] Incorporates review feedback

* [DOCS] Updates doc per review comments

* [DOCS] Fixes description of saved query

* [DOCS] Incorporates review comments

Co-authored-by: Matthias Wilhelm <ankertal@gmail.com>
2021-04-29 10:26:34 -07:00
gchaps 7ef187ec89
[DOCS] Updates images and text in Discover (#98694)
* [DOCS] Updates images and text in Discover

* [DOCS] Edits after walkthrough

* [DOCS] Fixes typo

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-04-29 10:25:50 -07:00