Commit graph

25731 commits

Author SHA1 Message Date
Nathan Reese
a3a1e0c18d
[Maps] use coalesce to ensure number always passed to interpolate for data driven size styling (#38427)
* [Maps] use coalesce to ensure number always passed to interpolate for data driven size styling

* update docs with behavior when feature property is not defined

* Update docs/maps/vector-style.asciidoc

Co-Authored-By: gchaps <33642766+gchaps@users.noreply.github.com>

* Update docs/maps/vector-style.asciidoc

Co-Authored-By: gchaps <33642766+gchaps@users.noreply.github.com>

* move first note into description paragraph

* add coalesce wrapper around icon-size extraction expression
2019-06-17 15:14:53 -06:00
Frank Hassanabad
8032f82b18
[SIEM] Enhance URL to handle ISO-8601 date times within them. (#39045)
## Summary
* Added ISO Handler called normalizeTimeRange
* Added unit tests
* Implemented and tested with Machine Learning Jobs to ensure it works as expected
* Moved around Omit Utility to the common area
* https://xkcd.com/1179/
### Checklist

Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.

~~- [ ] This was checked for cross-browser compatibility, [including a check against IE11](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility)~~
~~- [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md)~~
~~- [ ] [Documentation](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#writing-documentation) was added for features that require explanation or tutorials~~

- [x] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios

~~- [ ] This was checked for [keyboard-only and screenreader accessibility](https://developer.mozilla.org/en-US/docs/Learn/Tools_and_testing/Cross_browser_testing/Accessibility#Accessibility_testing_checklist)~~

### For maintainers

~~- [ ] This was checked for breaking API changes and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)~~
~~- [ ] This includes a feature addition or change that requires a release note and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)~~
2019-06-17 14:58:41 -06:00
Spencer
eb4308d464
[failure-reporting] ignore a couple other failure types (#39000) 2019-06-17 13:52:28 -07:00
Melissa Alvarez
c47a0d5cdf
[ML] New Platform Migration - server (#38360)
* wip: pull out all server dependencies

* create new platform plugin

* shim newPlatform plugin into legacy init

* update server tests for migration refactor

* cleanup interfaces

* Only add ML links for sample data sets if full license from - 38120

* update test and fix typescript errors

* Remove unused types
2019-06-17 16:08:13 -04:00
Dario Gieselaar
4526e2a2b5
[APM]: Inferred types for aggregations (#37360)
* [APM]: Inferred types for aggregations

Previously, aggregations returned by the ESClient were 'any' by default, and the return type had to be explicitly defined by the consumer to get any type safety. This leads to both type duplication and errors because of wrong assumptions.

This change infers the aggregation return type from the parameters passed to ESClient.search.

* Fix idx error

* Safeguard against querying against non-existing indices in functional tests

* Improve metric typings

* Automatically infer params from function arguments

* Remove unnecessary type hints
2019-06-17 21:56:23 +02:00
Dario Gieselaar
16fffe0a95
[APM] Don't redirect to default sample before data has been loaded (#39069)
Fixes an issue w/ the transaction sample redirect being too aggressive & redirecting to the default sample before the data has been fully loaded. This makes deeplinking to samples unreliable.
2019-06-17 21:39:57 +02:00
Zacqary Adam Xeper
d5d4d6bf2c
Change 'Metrics explorer' to 'Metrics Explorer' (#39101) 2019-06-17 13:46:55 -05:00
Corey Robertson
6b3ffb8491
Convert common/lib files to Typescript and Jest (#37640)
* Remove unused lib and associated tests

* Convert unquote string to TS and Jest

* Convert getFieldType to TS and Jest

* Convert httpurl to TS and Jest

* Remove latest_change and tests

* Convert pivot_object_array to TS and Jest

* Address PR feedback
2019-06-17 14:38:58 -04:00
Joe Reuter
49e9b5ba4c
add default values for filter labels (#38644) 2019-06-17 20:34:29 +02:00
Karen Metts
4322346d28
[Doc]Add docs for siem app (#39030)
* Add docs for siem app

* Incorporate more review comments

* Fix punctuation
2019-06-17 14:28:52 -04:00
Nathan Reese
151d2e1413
[Maps] add functional test for tooltip filter actions (#38988) 2019-06-17 12:13:59 -06:00
Melissa Alvarez
76777c5c92
[ML] File Data Visualiser - Link for timestamp notation docs/guide (#39037)
* add helpText with doc link to timestamp format

* add internationalization

* update snapshot
2019-06-17 14:07:57 -04:00
CJ Cenizal
d4e3e3d779
Fix field autocomplete suggestions in Console (#38948)
* Retrieve autocomplete fields when a request has completed.
 - Updating polling logic so that dispatching a request resets the poll timer.
2019-06-17 10:11:42 -07:00
Dmitry Lemeshko
581755098a
[firefox] Run functional tests in dedicated CI groups (#38416)
* 2 jobs for Firefox tests

* review fixes

* make sh files executable

* add check reporter
2019-06-17 19:31:41 +03:00
Kerry Gallagher
22d1786908
Align text overflow styles for Label and Value (#39068) 2019-06-17 16:35:30 +01:00
Daniil Suleiman
e74f22d36a
Upgarde enzyme to v3.10.0 (#38766)
* Upgarde enzyme to v3.10.0

*update snapshots (React components which are using Memo());

*revert pending test in list_control_editor.test.js;

*replace component.html() and component.text() function calls
 which expect null to component.isEmptyRender() for consistency
2019-06-17 18:33:37 +03:00
Justin Kambic
ab97f1fe97
Update uptime docs screenshots. (#38896) 2019-06-17 11:13:46 -04:00
Angela Chuang
de927603d7
update button size (#39051) 2019-06-17 23:08:35 +08:00
Marco Vettorello
922e111dd5
Upgrade @elastic/charts to 6.0.1 (#38783)
* Upgrade @elastic/charts to 5.2.0

* Upgrade @elastic/charts to 6.0.1

* Add darkMode theme mock
2019-06-17 15:45:53 +02:00
Marco Vettorello
1c495aec2f
Add required default markdown visState (#38390)
The markdownVis expression has the markdown string property configured as required.The current implementation of the markdown vis doesn't have a default value (actually it's undefined) and this cause the error to be thrown when creating a new markdown vis.

fix #38127
2019-06-17 15:45:26 +02:00
Ahmad Bamieh
b36aad350a
[i18n] extract untracked translations and prettier logging (#35171)
* extract untracked translations and prettier logging

* self code review

* Update src/dev/run_i18n_check.ts

Co-Authored-By: Bamieh <ahmadbamieh@gmail.com>

* updating listR

* run new i18n_check and fix errors

* kbnEmbeddables -> embeddableApi

* remove any type

* Update src/legacy/core_plugins/embeddable_api/public/panel/panel_header/panel_actions/add_panel/add_panel_flyout.tsx

Co-Authored-By: Stacey Gammon <gammon@elastic.co>

* Update src/legacy/core_plugins/embeddable_api/public/panel/panel_header/panel_actions/add_panel/add_panel_action.tsx

Co-Authored-By: Stacey Gammon <gammon@elastic.co>

* self code review fixes

* fix extract and integrate scripts

* ts-ignore js file
2019-06-17 16:03:12 +03:00
Felix Stürmer
5b9c231a51
[Infra UI] Make queries more robust against missing indices (#38976)
This fixes several queries that failed when indices didn't exist and were not specified using a wildcard at the same time.
2019-06-17 06:43:04 -04:00
Felix Stürmer
2228863440
[Infra/Logs UI][skip ci] Add infra plugin readme with contribution notes (#38696)
This adds a README file to the `infra` plugin directory with additional contribution notes.

Co-Authored-By: Kerry Gallagher <k.gallagher.05@gmail.com>
2019-06-17 06:33:11 -04:00
Matthias Wilhelm
0351559aa8
Set XAxis ordered.interval differently for date and numeric values in histogram (#38824)
* Add test for numeric interval values
2019-06-17 11:44:57 +02:00
Angela Chuang
399adcddcd
[SIEM] add middleware for handling refetch (#38697)
* add middleware for handling refetch

* add unit test for error links

* add unit test
2019-06-17 01:29:40 +08:00
Mikhail Shustov
de5c452f14
Unify base path in HttpService (#38237)
* unify modifyUrl on client and server

* create BasePath as a separate entity on server

* use BasePath class in http server

* use BasePath a separate entity on client

* use BasePath class on Http service on the client

* switch client code to the new api

* improve setver http service mocks

* address comments #1

* address comments #2

* update docs

* add comment why we define own typings
2019-06-16 16:36:02 +02:00
Spencer
9c1bdb9298
[percy] only execute percy setup when necessary (#39043) 2019-06-16 07:23:36 -07:00
Rashmi Kulkarni
5d90300224
extend timeout (#39001)
trying it out - so that test runner runs are clean...
2019-06-14 15:47:56 -07:00
chongzhe
bb19f9497c
[Code] update enable config in doc and screenshots to reflect new UI change (#39034) 2019-06-14 15:28:37 -07:00
Tim Roes
2d37b05a43
Improve jest mocking infrastructure (#38760)
* Always mock metadata/chrome in OSS

* Enable jest env in jest mocks

* Exclude jest mocks in karma bundles

* Use setupFilesAfterEnv in config

* Remove chrome/metadata mock from x-pack

* Remove kuery mock

* Add missing mock to SIEM test

* Fix typo in mock import

* Remove top level capabilities x-pack mock

* Move kfetch mock to ui/public

* Move moment-timezone to mocks file

* Unmock kfetch in kfetch specific tests

* Make kfetch mock manual

* Removed unnecessary jest.mock

* Remove kfetch unmocks
2019-06-14 23:36:51 +02:00
Greg Thompson
c22b706b25
Upgrade EUI to 11.3.2 (#38262)
* eui 11.3.1

* EuiSuperSelect TS updates

* EuiColorPicker updates

* EuiBadge updates

* a11y updates

* i18n service updates

* remove unused translations

* move valueOfSelected logic to private method

* update EuiColorPicker class name

* Updated canvas storyshots

* i18n fixes; maps color selection position

* i18n snapshot updates

* update canvas storyshots

* snapshot updates

* 11.3.2

* maps colorpicker

* space avatar colorpicker
2019-06-14 15:45:35 -05:00
Lisa Cawley
b12c1eb9ca
[DOCS] Adds data frame link (#39019) 2019-06-14 13:16:59 -07:00
Davey Holler
b05b0ea35b
[Code] Updates to copy in the Code docs (#39003) 2019-06-14 12:31:20 -07:00
Brandon Morelli
05d802ff5f
[APM][Docs] 7.2 documentation updates (#38577) 2019-06-14 12:25:46 -07:00
CJ Cenizal
93e8fcf003
Fix Search Profiler's 'Index' input's placeholder color contrast accessibility. (#38952) 2019-06-14 11:39:54 -07:00
Lisa Cawley
c1a88c6d85
[DOCS] Updates data frame security details (#39009) 2019-06-14 11:33:45 -07:00
CJ Cenizal
b7d94b8b4c
Fix Console bug caused by rapidly opening and closing the History tab. (#38950) 2019-06-14 11:26:51 -07:00
Chris Roberson
b09e3a622f
[Monitoring] Metricbeat migration flyout and instructions (#35228)
* Initial attempt at a reactor of how this works

* Enter and exiting setup mode with migration buttons working

* Adding monitoring url step back in and some small cleanup

* Elasticsearch steps

* Add missing file

* Better organization here

* Remove this debug logic

* Clean up

* PR feedback

* Add in monospacing

* Persist monitoring url in local storage

* Rework the steps

* Change node to server, and add missing files

* Fix linting issues

* Fix api integration tests

* PR feedback

* Pass down if the product is the "primary" or not, then use that to show certain warnings in the UI (just supported for Kibana right now)

* Elasticsearch migration will work slightly differently in that all nodes must be partially migrated before we can disable internal collection

* More PR feedback

* PR feedback

* Better links

* Fix tests

* This should open in a new tab

* PR feedback

* Design and PR feedback

* Fix these tests

* PR feedback

* Remove debug

* PR feedback

* Update the import path

* Update this import path too

* PR feedback

* Fix i18n
2019-06-14 14:21:53 -04:00
Steph Milovic
cd76109a2c
[SIEM] Fix url state request once initial state (#38955)
[SIEM] Fix url state request once initial state
2019-06-14 11:42:52 -06:00
CJ Cenizal
a106da9477
Unsplit i18n strings in ILM's MinAgeInput component. (#38854) 2019-06-14 10:29:31 -07:00
Aleh Zasypkin
7f3f579894
Make Kerberos authentication provider to accept requests with Authorization: Bearer xxx header to support reporting use case. Disable Kerberos support for the Windows Chromium build. (#38796) 2019-06-14 18:54:44 +02:00
Stacey Gammon
156467e535
Typescript (most of) the rest of dashboard code (#38546)
* Typescript the rest of dashboard code, including the main dashboard_app entry file

* Update jest snapshot after unused compressed parameter

* fix: accidental logic change prevented clone modal from closing

* Update based on review feedback
2019-06-14 12:51:11 -04:00
Matthias Wilhelm
2d9975c147
Date nanos context typescript conversion (#38735) 2019-06-14 18:48:08 +02:00
Aleh Zasypkin
5badcbd0cc
Whitelist additional OIDC/SAML realm settings for Kibana docker images. (#38861) 2019-06-14 18:39:12 +02:00
Spencer
b5ac046314
[kbn/es] auto retry snapshot download on unexpected errors (#38944)
* [kbn/es] auto retry snapshot download on unexpected errors

* missed an await

* pass log to retry()
2019-06-14 09:38:39 -07:00
liza-mae
0003a32f56
[WIP] FTR Percy changes (#36897)
* [ftr/percy] integrate percy with functional test runner

* execute ftr within `percy exec`

* share PERCY_BIN and GRUNT_BIN vars in setup

* [license] whitelist `(Unlicense OR Apache-2.0)`

* [percy] include pr/parallel info in env

* echo the actual variable value

* destructure required modules

* [ci] calculate percy env in a script

* remove outdated eslint overrides

* oops, nonce should be the same for each build

* take snapshots in context tests

* add percy snapshots to some dashboard tests

* account for extra execution of PERCY_BIN

* remove usage of percy service

* rename service to `visualTesting`

* write a simple test

* switch left-over percy test to visualTesting

* set log level for percy agent

* trigger ci

* try using the system chrome install instead of downloading one

* fix export definition

* Don't skip chromium download

* Add Spencer's fix to point to chrome installation

* Attempting to split tests into own ci job and test files

* Renumber job

* Add tag to decorations file

* Try new files with existing CI job

* Try again to create a new CI job

* Fix eslint problem with space

* eslint updates

* fix console test

* make test names unique

* Update ci group names

* Try old name again

* save

* add separate visual_regression ci job

* add visual regression ci job

* add new job to jobs.yml

* update path to take_percy_snapshot script

* use fixed percy job total

* fix common services import

* move visual_create_and_add_embeddables to visual_regression project

* finish moving create_and_add_embeddables

* add x-pack visual regression job

* migrate dashboard_snapshots tests to visual_regression

* remove references to removed test files

* restore some unnecessary changes

* reimplement the login page tests

* yarn.lock update

* fix test

* remove old CI_GROUP 100 block

* update failed_tests trap

* reduce yarn.lock changes

* disable debug logging

* disable visual-regression tests for now, we can enable them in specific prs
2019-06-14 10:35:23 -06:00
Alison Goryachev
da13b9b763
[IM] improve ux for permissions error (#38916) 2019-06-14 10:27:36 -04:00
Zacqary Adam Xeper
74a90b25c0
[Infra UI] Format arrays as ul elements in LogEntryFieldColumn (#38692)
* [Infra UI] Format arrays as ul elements in LogEntryFieldColumn

* Add enzyme test for LogEntryFieldColumn

* Fix tests

* Swap ul's for comma separation

* Use semantic markup for inline list

* Fix tests

* Use ::after element for comma separation

* Move ::after element to :not(:last-child)

* Hoist CommaSeparatedLi

* Use EuiThemeProvider in tests instead of isEnzyme prop

* Suppress type error with issue link
2019-06-14 10:07:35 -04:00
Vadim Dalecky
0c34b0d6d3
State containers 📦 (#38758)
* feat: 🎸 add initial createStore() implementation

* test: 💍 test observable $state interface

* style: 💄 apply prettier

* chore: 🤖 upgrade react-redux lib

* refactor: 💡 rename $state -> state$

* feat: 🎸 add initial React context and connect implementation

* feat: 🎸 improve connect()() HOC TypeScript typings

* feat: 🎸 export store methods

* feat: 🎸 implement store mutations

* chore: 🤖 add TODO list

* refactor: 💡 rename .mutations -> .createMutations

* feat: 🎸 use name Redux actions for mutations

* fix: 🐛 fix TypeScript errors

* feat: 🎸 store mutations inside store object

* style: 💄 run Prettier on test file

* refactor: 💡 rename mutation -> mutator

* chore: 🤖 set :AppArch team as code owners of kibana_utils

* chore: 🤖 update x-pack package.json react-redux dependencies

* chore: 🤖 run yarn kbn bootstrap

* chore: 🤖 revert back react-redux package upgrade

* refactor: 💡 rename remaining mutation -> mutator

* feat: 🎸 implement first set of React hooks

* chore: 🤖 revert back react-redux upgrade

* refactor: 💡 use useState() inside <Consumer>

* feat: 🎸 implement useSelector() React hook

* docs: ✏️ add store creation docs

* docs: ✏️ add mutators documentation

* docs: ✏️ add getter and Redux docs

* docs: ✏️ add react reference

* docs: ✏️ typo

* docs: typo

Co-Authored-By: Stacey Gammon <gammon@elastic.co>

* docs: typo

Co-Authored-By: Stacey Gammon <gammon@elastic.co>

* docs: remove private link
2019-06-14 16:00:32 +02:00
Pete Harverson
1a03c5135b
[ML] Increase max data frames in list from 100 to 1000 (#38973) 2019-06-14 14:32:55 +01:00