* Fixes assignment v comparison and null type check in metrics detail page
* Updated docs to specify new optional TS generic
* Switches new generic to extending the interface
* Removes previously added core generic type and defaults to unknown
* Reverts unknown change, saves for later
* Reverts unknown/any change for now
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
* Make the flyout `s` instead of `m` size
* Remove flyout tabs
* Make flyout description list `compressed`
* Make spacer before description list `s` size
* Use `EuiPageTemplate` on alerts and cases pages.
* Move SchemaErrorsAccordion to its own folder
+ give it its own export
* Move errors-specific copy to its own file
+ Capitalize ID heading
* [UI polish] Accordion header tweaks
- Fix responsive behavior
- Make Review button more accessible (a within a button is not semantically correct)
- Add <code> markup for field type
* [UI polish] CSS tweaks
- use OOTB EUI CSS classes for borders (see https://elastic.github.io/eui/#/layout/accordion#styled-for-forms)
- tweak spacing
- misc fixes
* [Code polish] Misc cleanup
- Simplify / DRY out props types
- Prefer unique IDs/names over map indexes for React keys
- Improve var names
* Simplify conditional "view" column + misc fixes
- Rename prop to match AS's generateSomePath helpers
- Remove need for itemId - AS should be able to generate its own URL route without it
- Fix accessibility for view column - should be totally hidden to screen readers if not present
- Fix semantics of view link - should be an <a> link not a button
* Update WS's use of SchemaErrorsAccordion
* Adding query to identify long running rules to docs
* Wording suggestsion from PR review
* Adding event.provider to query. Allowing copy to console
* Adding note for system privileges
* Adding runtime field to query
* Removing extra dollar sign
* PR fixes
* chore(NA): moving @kbn/analytics into bazel
* chore(NA): fix type check for package migration
* chore(NA): fix type check for package migration
* chore(NA): fix type check for package migration
* chore(NA): separate type generating from server code
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
* Move SchemaAddFieldModal to its own folder
+ misc test cleanup - remove unnecessary jest.spyOn in individual tests, it's already in the beforeEach
* i18n fixes
- Move constants to subfolder
- Fix various i18n IDs/var names - modal titles is not a fieldNote title
- Fix an i18n string that should be a FormattedMessage (could have grammar issues otherwise)
- Add missing i18n strings - labels (shared, AS will also use these as column headers) & placeholder
- Import order
* Move formatFieldName util to its own file
- simplify leading/trailing trimming regex
- add unit tests - primarily for documenting regexes & providing examples
* Refactor modal form submission
- See https://elastic.github.io/eui/#/layout/modal#forms-in-a-modal for documentation - form should be submitted via ID & EuiModalFooter form={id}
* Misc props cleanup
- Move optional props to bottom of type list
- Remove unnecessary props (default EUI behavior)
- Data test subj cleanup
- Add missing `disabled` passed prop, add unit test for disableForm prop
###Summary
Removes some anti-patterns I introduced in my last PR and makes use of Cypress' chainable pattern that will hopefully help with the flakiness.
* Create new SchemaErrorsCallout component
- will replace IndexingStatus and IndexingStatusErrors
- The concept of "indexing status"/loading no longer really exists, now that schema updates instantly
* Update views to use new SchemaErrorsCallout
- instead of IndexingStatus component
* Remove remaining concepts of an indexing job/loading progress
+ remove /status reindex_job routes, since we no longer need to poll for indexing status
* Remove IndexingStatus components
* Update i18n
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Adds a short term fix/override for the height of data grid in transform and data frame analytics wizards.
EUI itself sets the height style of euiDataGrid__virtualized. For some reason it's not able to adjust that height within the wizards when you toggle histogram visibility or change rows shown per page.
This PR fixes it by wrapping the data grid with EuiMutationObserver to listen for updates within the data grid and setting the height of euiDataGrid__virtualized to auto on every update. For now this should be a safe short term fix since we don't use the full screen option.
Before:
```
info => Loading static files from /Users/smith/Code/kibana/node_modules/@kbn/ui-shared-deps/target and serving at /.
info => Loading presets
info => Loading presets
info => Loading 8 other files in "x-pack/plugins/apm/.storybook"
info => Adding stories defined in "x-pack/plugins/apm/.storybook/main.js"
info => Using default Webpack setup
... like 300MB of output ...
webpack built 0f7b67ae2a8a0401f5af in 105247ms
```
After:
```
info => Loading static files from /Users/smith/Code/kibana/node_modules/@kbn/ui-shared-deps/target and serving at /.
info => Loading presets
info => Loading presets
info => Loading 8 other files in "x-pack/plugins/apm/.storybook"
info => Adding stories defined in "x-pack/plugins/apm/.storybook/main.js"
info => Using default Webpack setup
... yeah it just sits there for a bit, but were you reading this and did you believe the percentages you were being told? ...
webpack built 0f7b67ae2a8a0401f5af in 105247ms
```
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
* Provide allocation behavior guidance when the user has selected Custom, but no attributes are available and:
...data nodes are in use, so indices will allocate to data nodes.
...data tiers are available, so indices will allocate to data tiers.
...data tiers are available but not for the given phase's tier, so indices will be allocated to a fallback data tier.
...no data tiers are available, so allocation won't occur.
* Provide link to the migration docs.
* Adjust copy to consistently notify the user that node attributes are missing and guide them to use role-based allocation.
* Localize disableDataTierOption flag instead of passing it as a prop, to make it easier to reason about.
* Clarify the scenario in which the user has selected node_attrs allocation but no data tiers are available.
* Remove inapplicable frozen tier from NoTiersAvailableNotice.
* Refactor and update tests.
* Split up node allocation tests to improve discoverability. Refactor test helpers to define suite-specific helper interfaces, to improve maintainability.
* Refactor tests to make the [using node attributes, using node roles] branch and the various conditions within easier to contrast and compare.
* Add coverage for NoTiersAvailableUsingNodeAttributesNotice scenario.
* Add some helpers for improved maintainability and readability.
* Create helpers/types file to store extracted Phase type.
## Summary
Fixes test flake:
https://github.com/elastic/kibana/issues/97365
By changing exact to an above count. I think the view of the index this large is not being given back consistent and could be a possible tooling gotcha, but I don't think we have a bug around this area. Either way, the test is still a valid test to ensure we don't blow up with errors, I just don't also test for exactness anymore.
Since this fixes tests and has no other inherit risk but should bring stability, I marked it as being back ported into the 7.13 branch for the next BC build of 7.13.
### Checklist
- [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios