Commit graph

377 commits

Author SHA1 Message Date
Matthias Wilhelm a8d4145afb
[Discover] Revert default grid back to legacy (#98508) 2021-04-30 10:29:41 +02:00
Spencer fad45022c1
[npm] upgrade all jest related dependencies (#96367)
Co-authored-by: spalger <spalger@users.noreply.github.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-04-21 15:32:10 -04:00
Uladzislau Lasitsa 4a17123ef8
Advanced JSON input in visualize editor is always light scheme (#97232)
* Use CodeEditor from react-utils which supports dark theme instead of deprecated EuiCodeEditor

* fix CI

* Fix CI

* Fix tests

* Update monaco_editor.ts

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-04-21 12:19:12 +03:00
Matthias Wilhelm 2ecbca0d8d
[Discover] Enable EuiDataGrid (#89264)
* Now the new EuiDataGrid based document table is the default

* Columns can be sorted by drag and drop

* Column width can be changed by drag and drop

* There's a fullscreen mode

* There's document selection 

* There's document navigation in the flyover of a expanded document

* Sorting is much more user friendly, less confusing and sort order can be changed by drag and drop
2021-04-20 14:43:02 +02:00
Matthias Wilhelm 7c5f41e171
[Discover] Unskip functional saved queries test 2021-04-19 16:13:03 +02:00
Catherine Liu 3b31d81196
[Dashboard] Makes lens default editor for creating new panels (#96181)
* Makes lens default editor in dashboard

Added all editors menu to dashboard panel toolbar

Fixed toggle on editor menu

Removed unnecessary comments

Added data test subjects to editor menu buttons

Populated editor menu with vis types

Removed unused imports

Fixed imports

Adds showCreateNewMenu prop to AddPanelFlyout

Rearranged order of editor menu options

Fixed ts errors

Added groupnig to embeddable factory

Use embeddable state transfer service to redirect to editors

Added showGroups to TypeSelectionState

Fixed add panel flyout test

Fixed data test subjects

Fixed factory groupings

Removed unused import

Fixed page object

Added telemtry to dashboard toolbar

Added telemtry to editor menu

Fix ml embeddable functional tests

Fix lens dashboard test

Fix empty dashboard test

Fixed ts errors

Fixed time to visualize security test

Fixed empty dashboard test

Fixed clickAddNewEmbeddableLink in dashboardAddPanel service

Fixed agg based vis functional tests

Revert test changes

Fixed typo

Fix tests

Fix more tests

Fix ts errors

Fixed more tests

Fixed toolbar sizes and margins to align with lens

Fix tests

Fixed callbacks

Fixed button prop type

New vis modal copy updates

Added savedObjectMetaData to log stream embeddable factory

Addressed feedback

Fixed ts error

Fix more tests

Fixed ts errors

Updated dashboard empty prompt copy

Adds tooltip to log stream embeddable factory saved object meta data

Made icons monochrome in toolbar

Fixed icon colors in dark mode

Cleaned up css

Fixed ts errors

Updated snapshot

Fixed map icon color

* Added tooltips for ML embeddables

* Restored test

* Added empty dashboard panel test

* Fixed i18n id

* Fix dashboard_embedding test

* Removed unused service

* Fixed i18n error

* Added icon and description properties to embeddable factory definition

* Fixed ts errors

* Fixed expected value

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-04-17 22:29:27 -07:00
Rashmi Kulkarni 3ba640403f
unskip accessibility - dashboard_edit_panel tests (#96710)
* unskip

* added render complete

* added render complete in couple other places

* minor corrections

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-04-14 15:05:12 -07:00
Matthias Wilhelm 8cce4805d4
[Discover][EuiDataGrid] Add document selector (#94804)
Co-authored-by: Ryan Keairns <rkeairns@chef.io>
2021-04-13 15:54:42 +02:00
Maja Grubic 2d0b32a40a
[Discover] Integration of Runtime Fields editor - edit operation (#95498)
* [Discover] Updating a functional test

* [Discover] Support for edit operation

* Fix unit tests

* Fix typescript

* Fixing failing functional test

* Fixing wrongly commented line

* Uncomment accidentally commented line

* Reintroducing accidnetally removed unit test

* Trigger data refetch onSave

* Remove refreshAppState variable

* Bundling observers together

* Clean state before refetch

* Update formatting in data grid

* [Discover] Updating a functional test

* Adding a functional test

* Fixing package.json

* Reset fieldCount after data fetch

* [Discover] Updating a functional test

* Don't allow editing of unmapped fields

* Fix issues with mobile display

* Allow editing if it's a runtime field

* [Discover] Updating a functional test

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-04-12 15:25:50 +01:00
Matthew Kime ae4dae46d9
Index pattern field editor - Add warning and type 'confirm' on delete or save (#95237)
* add runtime field change/delete confirm dialog
2021-03-26 09:03:13 -05:00
Ece Özalp d70d02ee83
Add a11y test coverage to Rule Creation Flow for Detections tab (#94377)
[Security Solution] Add a11y test coverage to Detections rule creation flow (#80060)
2021-03-25 15:05:23 -04:00
Matthias Wilhelm fad3b74f2f
[Discover] Unskip functional test of saved queries (#94705) 2021-03-25 19:33:16 +01:00
Dima Arnautov edaa64f150
[ML] Functional tests for Anomaly swim lane (#94723)
* [ML] update @elastic/charts

* [ML] swim lane service, axes tests

* [ML] check single cell selection and current URL

* [ML] clear selection

* [ML] assert anomaly explorer charts

* [ML] fix unit test

* [ML] assert anomalies table and top influencers list

* [ML] update apiDoc version

* [ML] exclude host from the URL assertion

* [ML] clicks view by swim lane

* [ML] fix method for cell selection

* [ML] brush action tests

* [ML] use debug state flag

* [ML] declare window interface

* [ML] pagination tests

* [ML] enable test

* [ML] scroll into view for swim lane actions

* [ML] rename URL assertion method

* [ML] fix assertion for charts count

* [ML] extend assertion

* [ML] refactor test subjects selection

* [ML] fix assertSelection

* [ML] reduce timeout for charts assertion
2021-03-24 10:38:58 -04:00
Joe Reuter 52a1ce1723
[Lens] Runtime field editor (#91882) 2021-03-18 08:21:39 +01:00
Anton Dosov 4ed09420ce
[QueryBar] a11y improvements, focus glitches fixes, unskip tests (#94148) 2021-03-17 15:02:37 +01:00
Diana Derevyankina bdcd2ec859
Replace EuiCodeBlock with JsonCodeEditor in DiscoverGrid (#92442)
* Replace EuiCodeBlock with JsonCodeEditor in DiscoverGrid

* Add optional "hasLineNumbers" property to JsonCodeEditor and removed line numbers from the popover

* Update json_code_editor snapshot

* Add functional test for cell expanded content popover

* Remove unused code

* Fix geo point case and refactor some code

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-03-17 11:17:48 +03:00
Michail Yasonik d23c01b4be
Enabling Uptime and Dashboard a11y test (#91017) 2021-02-19 19:21:20 -05:00
Dmitry 119199ef41
[coverage] change worker, save json files in original path (#91683)
* [coverage] write data to original path

* [coverage] change worker size
2021-02-17 19:45:06 +01:00
Devon Thomson 6e8622fadb
[Time to Visualize] Copy Panel to Dashboard (#90856)
* Added copy to dashboard action
2021-02-11 17:15:30 -05:00
Catherine Liu 30e86ac065
[Dashboard] Adds Save as button to top menu (#90320)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-02-11 12:17:09 -08:00
Uladzislau Lasitsa 4c878be613
Bump "monaco-editor" and "react-monaco-editor" to latest versions (#90158)
* Update version of react-monaco-editor and monaco-editor libraries

* Fix yarn lock file

* Fix CI

* Fix unit tests

* Fix CI

* Fix comment

* move monaco instance in window.MonacoEnvironment

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-02-10 23:05:46 +03:00
Catherine Liu 3cf00d2bb4
[Time to Visualize] Adds functional tests for linking/unlinking panel from embeddable library (#89612) 2021-02-08 15:21:06 -08:00
Chandler Prall db899a9274
Upgrade EUI to v31.4.0 (#89648)
* Bump EUI to v31.4.0

* fix datagrid functional tests

* fix Lens unit tests

* fix table cell filter test

* Fix discover grid doc view test

* stabilize data table tests

* fix dashboard embeddable datagrid test

* Fix x-pack functional tests

* fix ml accessibility tests

* Fix discover grid context test

* Adapt expected nr of documents being displayed

* stabilize Lens a11y tests and skip data table

* Fix 2 ml functional tests

* enable lens datatable test; disable axe rule for datatable

* fix ml test

* fix Lens table test

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Joe Reuter <johannes.reuter@elastic.co>
Co-authored-by: Matthias Wilhelm <matthias.wilhelm@elastic.co>
Co-authored-by: Michail Yasonik <michail.yasonik@elastic.co>
2021-02-05 10:14:58 -07:00
Anton Dosov e82bbcff89
[Search Session] Revamp search session indicator UI and tour (#89703) 2021-02-04 14:36:19 +01:00
Brandon Kobel 4584a8b570
Elastic License 2.0 (#90099)
* Updating everything except the license headers themselves

* Applying ESLint rules

* Manually replacing the stragglers
2021-02-03 18:12:39 -08:00
Devon Thomson 9232a5a26a
[Time to Visualize] Remove Panels from URL (#86939)
Removed panels from dashboard URLs

Co-authored-by: Ryan Keairns <contactryank@gmail.com>
2021-02-03 17:23:01 -05:00
Marta Bondyra 1b8c3c1dcc
[Lens] Refactor reorder drag and drop (#88578) 2021-02-01 11:54:16 +01:00
Joe Reuter 0b798f7d10
make drag drop test more stable (#88614) 2021-01-21 14:29:23 +01:00
Brandon Kobel 170a2956c8
Updating the License (#88343)
* Updating the Licenses, except for applying eslint, building

* Applying ESLint rules,building @kbn/pm, regenerating api docs
2021-01-19 17:52:56 -08:00
Anton Dosov d3303f28bb
[Search] Search Sessions with relative time range (#84405) 2021-01-12 14:51:04 +01:00
Angela Chuang 4986bea8b6
[Security Solution] Unskip cypress tests (#86653)
* unskip data provider cypress test

* remove extra whitespace for filter classes

* remove cy.wait

* update functional test

* fix cypress and add tabType to dataTestSubj

* fix cypress test

* revert createNewTimeline task

* fix dependency

* fix line error

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-01-08 06:59:05 +00:00
Devon Thomson cdee8599d1
[Time to Visualize] Align Lens & Visualize Top nav Buttons & Behaviour (#86922)
* Aligned Lens & Visualize Top nav behaviour and look
2021-01-07 12:02:11 -05:00
Joe Reuter 3c7bd2fdd0
[Lens]Test color syncing (#86906) 2021-01-07 14:28:58 +01:00
Matthias Wilhelm a417690ced
[Discover] Integration of EuiDataGrid (#67259)
Co-authored-by: Michail Yasonik <michail.yasonik@elastic.co>
Co-authored-by: Marta Bondyra <marta.bondyra@elastic.co>
Co-authored-by: Dave Snider <dave.snider@gmail.com>
Co-authored-by: Andrea Del Rio <delrio.andre@gmail.com>
Co-authored-by: cchaos <caroline.horn@elastic.co>
2020-12-23 09:05:29 +01:00
Devon Thomson 8ce9b474d6
[Time to Visualize] Fix Dashboard OnAppLeave (#86193)
Added isTransferInProgress to embeddable_state_transfer for apps to determine whether or not to show onAppLeave confirm
2020-12-18 15:07:36 -05:00
Nick Partridge ddea10e718
Create vis_type_xy plugin to replace histogram, area and line charts (#78154) 2020-12-18 08:38:07 -06:00
Daniil 845f716271
[Data table] Reactify & EUIficate the visualization (#70801)
* Use data grid for table vis

* Create basic table template

* Add table_vis_split component

* Apply cell filtering

* Add aria-label attributes

* Use field formatters for values

* Add no results component

* Remove legacy dependencies

* Add usePagination

* Create usePagination util

* Use percentage column and total row

* Use csv export button

* Update labels

* Fix merge conflicts

* Use split table

* Fix functional tests

* Fix dashboard tests

* Update data table functional tests

* Fix missed test

* Introduce showToolbar option

* Remove useless package

* Fix merge conflicts

* Return back kibanaUtils required bundle

* Revert "Remove useless package"

This reverts commit 144a7cd77c.

* Use feature flag for legacy vis

* Add footer row

* Remove lock files

* Revert "Remove lock files"

This reverts commit 5c5acd79f4.

* Minor fixes

* Use common no result message

* Fix broken tests

* Use ui state sorting

* Fix error

* Fix merge conflicts

* Add legacy functional tests

* Pull pagination footer up to keep with table

and fix column split growing continuously in dashboard

* Comments fixes

* Use cell actions for filtering

* Fix translations

* Fix comments

* Reduce legacy tests amount

* Update sorting

* Update split column layout

* Add telemetry for legacy vis

* Apply latest changes for split table

* Fix eslint errors

* Use aria labels with values

* Use aria label for export btn

* Fix functional test

* Update translations

* Cleanup

* Truncate cells content

* Enhance types in table_vis_response_handler.ts

* Persist columns width on change

* Fix sorting history

* Add a migration script for toolbar

* Export sorted table

* Use reportUiCounter instead of reportUiStats

* Fix integration tests

* Fix typos

* Adjust FieldFormat type

* Hide the density selector

* Update docs

* Fix pagination

* Restrict hiding the toolbar

* Fix column index on filter

* Add closePopover action

Co-authored-by: cchaos <caroline.horn@elastic.co>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2020-12-15 14:44:20 +03:00
Stratoula Kalafateli 1cdaea78ac
[TSVB] Fix functional tests flakiness and unskip them (#85388)
* [TSVB] Fix functional tests flakiness and unskip them

* Fix functional test failure

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2020-12-15 11:12:31 +02:00
Mikhail Shustov 5ec6fe315f
[DX] Bump TS version to v4.1 (#83397)
* bump version to 4.1.1-rc

* fix code to run kbn bootstrap

* fix errors

* DO NOT MERGE. mute errors and ping teams to fix them

* Address EuiSelectableProps configuration in discover sidebar

* use explicit type for EuiSelectable

* update to ts v4.1.2

* fix ts error in EuiSelectable

* update docs

* update prettier with ts version support

* Revert "update prettier with ts version support"

This reverts commit 3de48db3ec.

* address another new problem

Co-authored-by: Chandler Prall <chandler.prall@gmail.com>
2020-11-24 16:04:33 +01:00
Joe Reuter 7d8ca10fbc
[Lens] Do not reset filter state on incoming app navigation (#83786) 2020-11-24 13:26:54 +01:00
Aleh Zasypkin e3ca8a928d
Implement AnonymousAuthenticationProvider. (#79985) 2020-11-23 11:41:08 +01:00
Pierre Gayvallet b3eefb97da
SO Tagging: fix flaky test and re-enable it (#82930)
* fix flaky test and re-enable it

* wait for table to load before to perform operations

* move everything out of ciGroup2 for flaky test runner

* add debug block for flaky runner

* use correct vis name

* remove test sync

* Revert "move everything out of ciGroup2 for flaky test runner"

This reverts commit db86c3b5
2020-11-18 16:43:12 +01:00
Nathan Reese a2c91f18c6
[Maps] saved object tagging (#83197)
* add tag selector to save modal

* save tag references onSave

* populate tags when unwrapping attributes

* tslint

* update listing page to show tags

* fix data-test-subj id in functional tests

* i18n cleanup

* tslint

* remove unused import

* use listingTable service for functional tests

* tslint and fix mvt grid layer functional test

* review feedback

* add tags to all privileges and add test user to find, delete, get, get_all, and update tests

* move functions to module scope

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2020-11-16 19:52:15 -07:00
Thomas Watson 4c49d5d1be
Upgrade Node.js to version 12 (#61587) 2020-11-12 22:00:57 +01:00
Wylie Conlon ac150da49d
[Lens] Functional tests for drag and drop (#82796) 2020-11-11 12:36:04 +01:00
Stratoula Kalafateli 5710f6763b
[Visualize] New visualization wizard (#79627)
* [Visualizations] New vis wizard

* Update functional tests

* Create oss plugins for maps and lens and unregister alias function

* Add new plugins to .i18nrc.json

* Add readme and codeowners to the new plugins

* update docs

* fix tests

* fix types

* fixes

* Update development docs

* fix oss functional tests

* Fix jest and x-pack functional tests

* Fix functional test

* changes on the layout

* Cleanup and responsiveness

* cleanup unecessary code

* add common folder to the new OSS plugins

* remove unecessary translations

* Update limits.yml file

* Fix basic label

* Add experimental badge on controls vis

* Nice improvements

* fixes

* Improving styles

* Making modal go full height on smaller screens

* Fixing sass lint warning

* fix lint error

* fix internationalization error

* PR fixes

* PR changes

* Use useCallback where possible

* Remove translations that need to be translated again

* Lazy Load wizard modal

* Remove legacyMapVisualizationWarning

* Import the OSS plugins constants from the plugins

* Export constant from lensOss

* Change the new oss plugins from OSS to Oss

* Add a new line to the kibana.json files of the new plugins

* New nit fix

* Fix spaces

* Change the texts for the first step of the modal

* Fix test

* Fixes some of the PR comments

* Add onClick funtionality to the entire aggregation based card

* Cards description changes, introduce a copyFromRoot method to solve the problem of when disabling the x-pack plugic, to also disable the oss

* Create new FTR for testing the functionality of the wizard when both maps and lens apps are disabled

* fix eslint error

* Change groupTitles and descriptions

* Change input vis description

* Remove the copyFromRoot from the signature of the ConfigDeprecationFactory and export it from the main entrypoint

* Make the disabled cards badge clickable

* Changes from code review

* Fix functional tests failures

* Rename groupTitle to titleInWizard to be more specific

* Change vega vis note

* minor design changes

* fix problem with plugins list docs

* Retrieve maps and lens landing page from docs service and add tracking url param

* Fix funtional test for the new dashboard flow

* Fix logic in alias registry for removing the discardOnRegister alias

* no need to remove the alias entry from the discardOnRegister array

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: miukimiu <elizabet.oliveira@elastic.co>
2020-11-06 18:03:44 +02:00
Alexey Antonov 0faf8c24ee
Use monacco editor in the inspector request panel (#82272)
* Use monacco editor in the inspector request panel

Closes: #81921

* insRequestCodeViewer -> insRequestCodeViewer

* remove uiSettings from props

* fix functional tests

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2020-11-06 11:34:57 +03:00
Robert Austin f2aad1201f
[Resolver] Screenshot the nodes of the test plugin. (#81405)
This PR adds screenshot comparison tests for the nodes in the graph on the test plugin.
Run the tests using this command:
`yarn test:ftr --config x-pack/test/plugin_functional/config.ts --grep Resolver`
2020-11-03 14:49:37 -05:00
Pierre Gayvallet d4b2a5145a
SavedObjects tagging MVP (#79096)
* create xpack plugin skeleton, start to implement management section

* add tag creation modal

* first implementation of the tags table

* use InMemoryTable

* add edit modal and delete action

* update plugin list

* add tag list, fix types

* add capabilities check on client-side

* add tag combo box component

* add missing i18n keys

* fix privilege FTR tests

* add base structure for FTR tests

* fix feature ftr test

* use string literals for i18n

* create savedObjectsTaggingOss plugin, move API types to oss plugin, start to wire to SO management page.

* update plugin list

* fix types

* allow to use `_find` with multiple references

* add FTR test for _find API on references fields

* add _find integration tests

* update generated doc

* start to implement tag filtering on SO management section

* update generated docs

* wire tagging API to dashboard listing page

* fix i18n namespace

* fix type & tests

* update dashboard listing snapshots

* adapt FTR listingTable service to search for parsable queries

* wite tagging API to visualize listing

* update tagging plugin limits

* add server-side and client-side validation for tag create/edit

* rename title field to name

* fix types

* fix types bis

* add removeReferencesTo API to SOR/SOC

* update generated doc

* add server-side unit test for `savedObjectsTagging` plugin

* move tagging API types to its own file

* add savedObjectsTaggingOss mock

* add tags_cache tests

* add tests for client-side tag client

* extract uiApi to distinct files

* various API improvements

* add more tests

* add link between tag and so management sections + add connection counts

* add base functional test suite for tagging

* add more FTR tests

* improve feature control func test

* update codeowners

* update generated doc

* fix access to proxy modal

* adapt SO save modal to allow to add tag field

* add SO decorator registry and tag implementation

* add unit tests for SO tag decorator

* add functional tests for visualize integration

* add tag SO read permission for vis/dash feature

* add RBAC api integ tests

* add API integration tests

* add test for getTagConnectionsUrl

* add SOM test suite

* add dashboard integration suite

* remove test line

* add missing unit tests

* improve API types doc

* fix create modal save button label

* remove console.log

* improve doc

* self review

* add refresh interval for tag cache

* improve page object doc

* minor cleanup

* address review comments

* small layout fixes

* add initial focus

* use lazy accessor for tag request handler context

* adapt SOM export and export route to handle references

* remove icon from feature config due to master changes

* fix SO table tests

* update generated docs

* sort tags by name in filter dropdown and listing component

* wire SO tagging to dashboard save modal

* fix types

* - add 'create tag' action in tag selector
- add notifications on update/create/delete from management
- delete modal wording

* add description max length validation

* remove real-time validation

* fix i18n bundle id

* update expected size of savedObjectsTagging plugin

* use own useIfMounted

* update limit again, contract components cannot be lazy loaded atm.

* math is hard

* remove single usage of lodash for bundle size

* add async imports for create/edit modal

* add FTR test for 'create tag' action from tag selector

* allow 'create new' option to prepopulate name field

* extract savedObjectToTag

* add advancedSettings read user for security api_integ suite

* add audit login for security client wrapper

* use import type when possible

* wire SO tagging to lens visualization

* fix lens jest test

* Fix `create tag` option being selected when closing the selector dropdown

* add sorting to tag column from getTableColumnDef

* address some of restrry comments

* rename tag selector's setSelected option to onTagsSelected

* fix audit logging even type for saved_object_remove_references

* update plugin size limit to current size

* adapt maxlength validation wording

* remove selection column until we have batch action menu

* remove connections link when user lack read privilege to savedObjectManagement

* forbid registering multiple SO decorators with the same priority

* add so decorator test

* extract getTagFindReferences and create API mock

* update audit-logging ascidoc

* doc nit

* throw conflict error if update returns any failure

* use refresh=true as default

* wording nits

* export: rename `references` to `hasReference`

* update generated doc

* set description max length to 100

* do not initialize tag cache on anonymous pages

* split fetchObjectsToExport into two distinct functions

* change tag client `delete` call order

* tsdoc nits

* more nits

* add README for oss plugin

* add oss plugin start tests

* SavedObject.find: rename `references` to `hasReference`

* change section description label

* remove url prefix constants

* last nits and comments

* update generated doc
2020-11-03 10:33:18 +01:00
Spencer 441890ccb3
[ftr/menuToggle] provide helper for enhanced menu toggle handling (#81709)
Co-authored-by: spalger <spalger@users.noreply.github.com>
2020-10-27 09:09:41 -07:00