Commit graph

30368 commits

Author SHA1 Message Date
Joe Reuter 22117abf49
fix tutorial documentation (#55996) 2020-01-28 15:02:04 +01:00
Walter Rafelsberger e237c9cf33
[ML] Fix persist/restore of time/refreshInterval in data visualizer. (#56122)
Fixes persist/restore of time/refreshInterval in data visualizer.
2020-01-28 14:52:24 +01:00
Alison Goryachev b7eef03a34
[Index Management] Fix errors with validation (#56072) 2020-01-28 08:33:18 -05:00
Alison Goryachev 92a106220a
[Index Management] Add try/catch when parsing index filter from URI (#56051) 2020-01-28 08:23:48 -05:00
Mikhail Shustov a831710c6d
[NP] add HTTP resources testing strategies (#54908)
* add HTTP resources testing strategies

* address comments

* add error message test and update error test

* Apply suggestions from code review

Co-Authored-By: Rudolf Meijering <skaapgif@gmail.com>

* add controller testing example

Co-authored-by: Rudolf Meijering <skaapgif@gmail.com>
2020-01-28 14:21:43 +01:00
Walter Rafelsberger 885f315623
[ML] Single Metric Viewer: Fix brush update on short recent timespans. (#56125)
Fixes an issue where the context chart brush would render incorrectly for short recent time spans (e.g. 'now-15min`). Adds a check whether to display the brush and hide it if context and focus chart have the same timespan.
2020-01-28 13:56:39 +01:00
Justin Kambic a2a0f118d6
[Uptime] Add timeout for slow process to skipped functional tests (#56065)
* Reorder assertions in functional tests.

* Introduce retry to functional tests.
2020-01-28 05:50:30 -07:00
MadameSheema 5e9db02e92
refactor (#56121) 2020-01-28 13:19:40 +01:00
Daniil Suleiman 4d43639f0e
Move tests in dashboard into appropriate folders (#55304)
* Move tests in dashboard into appropriate folders

* Remove unused imports
2020-01-28 13:43:27 +03:00
MadameSheema 24ac6d2931
[SIEM] Inspect readable (#56110)
* extracts methods to tasks

* uses cypress api for assertions

* refactor

* Inspect refactor

* fixes rebase issue
2020-01-28 11:32:36 +01:00
James Gowdy ecc8240dcb
[ML] Reseting categorization validation if category field is cleared (#56029) 2020-01-28 09:44:59 +00:00
MadameSheema fc10fb6b4f
[SIEM] Fields browser readable (#56000)
* extracts methods to tasks

* uses cypress api for assertions

* refactor

* removes tag
2020-01-28 10:04:41 +01:00
Brandon Morelli 3db8cb34b0
[docs] Remove unused callout (#56032) 2020-01-27 21:03:06 -08:00
Matthias Wilhelm 1504e830ac
Refactor saved object management registry usage (#54155)
* Migrate registry to TypeScript

* Migrate management code

* Migrate SavedObjectLoader services registration to management section

* Replace Angular SavedSearchLoader in transform plugin

* Migrate saved_visualizations from visualize to visualizations plugin
2020-01-28 05:36:12 +01:00
Frank Hassanabad 4f65985979
[SIEM][Detection Engine] critical blocker, updates the pre-packaged rules, removes dead ones, adds license file (#56090)
## Summary

* Adds updated pre-packaged rules with more meta-data (from randomuserid)
* Deletes older rules not shipping (from randomuserid)
* Adds license file for rules (from randomuserid)

### Checklist

Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.

~~- [ ] This was checked for cross-browser compatibility, [including a check against IE11]~~(https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility)
~~- [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md)~~
~~- [ ] [Documentation](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#writing-documentation) was added for features that require explanation or tutorials~~
~~- [ ] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios~~
~~- [ ] This was checked for [keyboard-only and screenreader accessibility]~~(https://developer.mozilla.org/enUS/docs/Learn/Tools_and_testing/Cross_browser_testing/Accessibility#Accessibility_testing_checklist)~~

### For maintainers

- [x] This was checked for breaking API changes and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)
- [x] This includes a feature addition or change that requires a release note and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)
2020-01-27 20:26:01 -07:00
Brian Seeders e792292923
Fix failing snapshot artifact tests when using env var (#56063) 2020-01-27 21:44:58 -05:00
Brian Seeders ba151fea0b
Fix Github PR comment formatting (#56078) 2020-01-27 20:45:24 -05:00
Nathan Reese 1488aa9eaf
[Maps] fix join metric field selection bugs (#56044)
* lint fixes

* move aggregation check to MEtricEditor

* fix functional test, handle case where fields are not loaded
2020-01-27 20:13:21 -05:00
Phillip Burch 1ec7ee79b6
Create a new menu for observability links (#54847)
* Create a new menu for observability links. Use it on inentory page.

* Change the order of props for clarity

* Fix default message

* Composition over configuration

* Show ids and ips. PR feedback.

* Don't wrap subtitle. Use fields in inventory model for name

* Tooltip was becoming hacky. Keep it simple and wrap the id.

* Create observability plugin. Add action menu to it.

* Fix path

* Satisfy linter and fix test

* Please the linter

* Update translastions

* Update test for disabled links

* Update more tests

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-01-27 19:10:34 -06:00
Garrett Spong 80087a399f
[SIEM] [Detection Engine] Fixes histogram intervals (#55969)
## Summary

This PR wraps up the remaining `Detection Engine` meta tickets: https://github.com/elastic/kibana/issues/55585, https://github.com/elastic/kibana/issues/54935, and https://github.com/elastic/siem-team/issues/498
- [x] Histogram bar interval (bar counts and widths) consistency (https://github.com/elastic/kibana/issues/55585)
  - [x] Make the bar intervals a consistent 32 bars across the board
  * Enabled `extended_bounds`, `min_doc_count: 0`, and now setting consistent `fixed_interval` when querying to ensure the entire daterange is displayed across all histograms.
- [x] Filter out the "untitled" timelines from both timeline selection options during rule creation (https://github.com/elastic/siem-team/issues/498)
  - [ ] ~Import query from saved timeline~
    * For 7.7 tracking ticket here: https://github.com/elastic/kibana/issues/56079
  - [x] `Investigate detections using this timeline template` 
- [x] Everywhere we use "Alerts" (Overview page, Host Tab, Network Tab) we should change the term to "External Alerts"
  - [x] Updated Host Page Tab/Table/Histogram/Breadcrumbs
  - [x] Updated Network Page Tab/Table/Histogram/Breadcrumbs
- [x] Updated DE permission/index  error doc links to go to [corresponding DE docs section](https://www.elastic.co/guide/en/siem/guide/7.6/detection-engine-overview.html#detections-permissions)
- [x] Removed `frequency` in favor of `count` for remaining histograms

##### Inconsistent Histogram intervals
![image](https://user-images.githubusercontent.com/2946766/73161560-04a82300-40a9-11ea-950f-ea56f9a5bfd7.png)


##### Consistent Histogram Intervals
![image](https://user-images.githubusercontent.com/2946766/73159564-fefc0e80-40a3-11ea-9b9d-4d15899dabd2.png)


cc @MichaelMarcialis @cwurm @MikePaquette 

### Checklist

Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.

- [ ] ~This was checked for cross-browser compatibility, [including a check against IE11](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility)~
- [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md)
- [ ] ~[Documentation](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#writing-documentation) was added for features that require explanation or tutorials~
- [ ] ~[Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios~
- [ ] ~This was checked for [keyboard-only and screenreader accessibility](https://developer.mozilla.org/en-US/docs/Learn/Tools_and_testing/Cross_browser_testing/Accessibility#Accessibility_testing_checklist)~

### For maintainers

- [ ] ~This was checked for breaking API changes and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)~
- [ ] ~This includes a feature addition or change that requires a release note and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)~
2020-01-27 16:44:58 -07:00
Spencer d66489df37
make test less flaky by retrying if list is re-rendered (#55949)
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-01-27 16:27:36 -07:00
Brian Seeders 99f224097c
Remove matrix build support (#54202) 2020-01-27 17:10:34 -05:00
Nathan L Smith 551e4dc472
Add animation to service map layout (#56042)
We had previously deleted the animation because the method we were using for adding nodes to the map would wipe the whole map out before redrawing it and make for very awkward animation.

The way it works now is the Cytoscape component calls `add` on the cytoscape instance when new elements are added, so the animation looks ok.

Fixes #54796.

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-01-27 15:31:09 -06:00
Poff Poffenberger be9d9c2ffe
[Canvas] Remove Angular and unnecessary reporting config from Canvas (#54050)
* Remove Angular from Canvas

* Remove reporting config behavior from Canvas since it's no longer needed

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-01-27 15:01:26 -06:00
Andrew Cholakian 35603c8832
[Uptime] Simplify snapshot max to Infinity (#55931)
Fixes https://github.com/elastic/uptime/issues/119

Rather than relying on a contant for the max number of monitors, it's
easier to just use infinity. This is simpler than making the iterator
more complex with an 'infinite' mode.

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-01-27 14:42:56 -06:00
Justin Kambic 1df019021f
[Uptime] Reintroduce a column for url (#55451)
* Reintroduce a column for url.

* Reintroduce original URL column.

* Update busted test snapshots.

* Truncate long URLs.

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-01-27 13:07:39 -07:00
Mike Côté 8fe39aef9d
Cleanup action task params objects after successful execution (#55227)
* Cleanup action task params saved objects after use

* Fix jest tests

* Add integration test to ensure object gets cleaned up

* Add unit tests

* Fix comment

* Re-use updated_at instead of creating createdAt

* Consider null/undefined returned from executor as success as well

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-01-27 15:02:44 -05:00
Brian Seeders 4df1c4c9c1
[CI] Retry flaky tests (#53961) 2020-01-27 14:46:05 -05:00
Alexey Antonov 5d6dbf07b0
Expose NP FieldFormats service to server side (#55419)
* Expose NP FieldFormats service to server side

* fix CI

* fix PR comments

* fix PR comments

* fix CI

* getFieldFormatsRegistry -> getFieldFormatRegistry

* fix CI

* memoize - add resolve cache function

* fix Jest

* move IFieldFormatMetaParams to types.ts

* FieldFormatRegistry -> FieldFormatsRegistry

* update src/core/MIGRATION.md

* update public contract

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-01-27 22:25:39 +03:00
nnamdifrankie 9301531249
[Endpoint] EMT-65: make endpoint data types common, restructure (#54772)
[Endpoint] EMT-65: make endpoint data types common, use schema changes
2020-01-27 14:23:56 -05:00
Mikhail Shustov aa695ec637
Normalize EOL symbol in platform docs (#56021)
* use api-extractor generate command with api-documenter config

* update docs

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-01-27 18:42:45 +01:00
Kaarina Tungseth 17011b7559
[DOCS] Empty dashboard screen (#55727)
* [DOCS] AdEmpty dashboard screen redesign

* Review comments f from Gail

* Comments from Gaiail pt 2
2020-01-27 11:33:20 -06:00
Joe Reuter c71f4dd162
Switch back to first page when fetching new items (#55821) 2020-01-27 17:58:46 +01:00
Matthias Wilhelm 66be6ffae8
Don't throw exception when refreshing fields of an indexpattern (#55836)
* An exception when refreshing fields of an selected index pattern causes Discover to load incompletely
* Add index ID + Title to the error message for
2020-01-27 17:40:51 +01:00
Joe Portner 13593344a0
Add lockfile symlinks (#55440)
This is to enable dependency scanning tools to correctly resolve
the dependencies in each package.json file that is used in
production.
2020-01-27 11:38:20 -05:00
Tim Roes 455a96e107
Hide nested fields across Kibana apps (#55278)
* Hide nested fields across Kibana apps

* Filter out nested fields in TSVB

* Fix import paths

* Hide nested fields in timelion autocomplete

* Fix remaining map places

* Filter out nested fields in graph

* Fix remaining map places

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-01-27 17:25:54 +01:00
Dmitry Lemeshko 82446048cf
skip tests due to issue #55992 (#55995) 2020-01-27 16:49:59 +01:00
James Gowdy 7fa5707ad6
[ML] Fixing module setup error for insufficient index pattern privileges (#55989) 2020-01-27 15:48:36 +00:00
Brian Seeders 1a856c7de7
Skip failing watcher tests 2020-01-27 10:39:06 -05:00
Mikhail Shustov efd3e99064
Revert "Normalize EOL symbol for the platform docs (#55689)" (#56020)
This reverts commit 1ea175e2c6.
2020-01-27 16:29:27 +01:00
James Gowdy 6f0bfa009a
[ML] Fixing "aggs" use in datafeeds (#56002)
* [ML] Fixing "aggs" use in datafeeds

* removing use of Record
2020-01-27 15:22:53 +00:00
Alejandro Fernández Haro 4c2d901dc5
[X-Pack][Monitoring][Telemetry] Ensure 24h time range when fetching Kibana usage stats (#55171)
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-01-27 14:50:08 +00:00
Mike Côté 72a8da2dcb
Re-enable skipped tests for unmuting an alert (#55861)
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-01-27 09:39:02 -05:00
Liza Katz 133c2994ca
Move search service code to NP (#55430)
* Move get search params into search strategy

* Move search strategy to NP and clean up courier exports

* Move fetch to NP

* Moved search source to NP

* Move shard failure to data/ui folder

* move getflattenedobject to core/utils

* fix discover

* eslint

* fix scss

* fix ts

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-01-27 16:18:27 +02:00
Mikhail Shustov 1ea175e2c6
Normalize EOL symbol for the platform docs (#55689)
* use api-extractor generate command with api-documenter config

* update docs
2020-01-27 14:39:56 +01:00
Mikhail Shustov e00f2628af
[NP] Platform exposes API to get authenticated user data (#55327)
* expose auth.get/isAuthenticated. move getAuthHeaders to internal type

* update mocks

* update docs

* update docs

* add integration test for auth
2020-01-27 13:57:06 +01:00
Jean-Louis Leysens 35edfb0e56
[Watcher] More robust handling of license at setup (#55831)
* Only register watcher app if we have received an indication of license first
Enable app to react to license updates from backend

* Return setup to a synchronous function.

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-01-27 13:35:40 +01:00
Dima Arnautov 94297f37b8
[ML] fix the annotation area tooltip offset (#55955) 2020-01-27 11:19:51 +01:00
Anton Dosov 987dfbc5b7
[State Management] - Remove GlobalState from dashboard (#55158)
Removes GlobalState from dashboard app
2020-01-27 10:51:24 +01:00
patrykkopycinski 2d3b569653
[SIEM] Unify Histograms loading states (#55961) 2020-01-27 08:15:46 +01:00