Commit graph

30368 commits

Author SHA1 Message Date
Chris Cowan a8a28bce6a
[Metrics UI] Add aws.dimensions prefix to AWS metrics in Metrics Explorer (#56216)
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-01-29 10:38:06 -06:00
Nathan Reese 31e413ca33
[Maps] style icons by category (#55747)
* dynamic icons

* split symbols UI into 2 parts

* static dynamic icon editor UI

* rename style property symbolMarker to icon

* add field select to dynamic icon form

* icon map select component

* create property classes for icon style property

* dynamic icons from palette

* changes

* fix image problem

* implement legend details

* fix image-anchor setting for dynamic images

* update functional test expect because of migration

* fix jest tests

* migrate SIEM style descriptors

* modify IconSelect to show icon in input

* fix jest test

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-01-29 11:15:06 -05:00
Felix Stürmer 16b4ff4a59
[Logs UI] Allow Logs/ML integration result access with machine… (#55884)
This makes the "Log rate" and "Categories" tab visible on clusters with a suitable license for users which don't have the the `machine_learning_admin` role.
2020-01-29 16:27:12 +01:00
Daniil Suleiman 7f63118d6b
Vis default editor plugin (#55612)
* Shim the default_editor

* Update paths in vis_default_editor

* Update paths in dependent plugins

* Update the dependent plugins

* Create an entry point

* Wrap the editor with kibana context

* Fix circular re-renders

* Update sub aggs mapping

* Move schemas and agg_groups to agg_types, update jest tests

* Use services from kibana context, other fixes

* Fix useEffect maximum update depth

* Create i18n namesapce for visDefaultEditor, rename translations

* Fix tests

* Resolve paths

* Remove ui/vis/vis_types

* Fix vis import

* Move editor_config_provider to ui/vis
2020-01-29 17:41:18 +03:00
Jean-Louis Leysens c2aff7e2fb
Re-enable watcher FireFox functional test (#56112)
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-01-29 14:40:23 +01:00
Dmitry Lemeshko 25fb555a53
Code coverage: run functional tests from repo copy (#55195)
* run functional tests from cloned folders

* do not copy kibana.yml

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-01-29 14:36:47 +01:00
Cauê Marcondes 1838d76af6
[APM] x-axis labels on Error occurrences chart are incorrect based on Kibana timezone (#55686)
* adjusting x-axis to use kibana timezone

* adjusting x-axis to use kibana timezone

* refactoring
2020-01-29 13:29:35 +00:00
Matthias Wilhelm d8adb395b1
Migrate saved_object_save_as_checkbox directive to timelion (#56114)
- since it's only used there
2020-01-29 13:31:47 +01:00
Andrew Goldstein 9d4414d523
[SIEM] Overview page feedback (#56261)
## [SIEM] Overview page feedback

Implements feedback and fixes to the Overview page

### Overview (default theme)

![01-overview-default-theme](https://user-images.githubusercontent.com/4459398/73315509-899c5500-41ed-11ea-9949-82853dd4ba59.png)

### Overview (dark theme)

![02-overview-dark-theme](https://user-images.githubusercontent.com/4459398/73315527-902acc80-41ed-11ea-9701-6a2c5fa40cce.png)

## Highlights

* The new order of widgets is Signals, Alerts, Events, Host Events, Network events, per https://github.com/elastic/siem-team/issues/494

* Changed the default `External alerts count` `Stack by` to `event.module` https://github.com/elastic/siem-team/issues/491

*  Added `event.module` to the `Events count` histogram https://github.com/elastic/siem-team/issues/491

* Widget titles will no longer include the currently selected `Stack by option`. The widgets will use the same static title text that appears on the other pages (i.e.. `Signals count`, `External alerts count`, and `Events count`) https://github.com/elastic/siem-team/issues/491

* The `Signals count` includes a `Stack by` that defaults to `signal.rule.threat.tatic.name`

* Standardized on a 300px widget height for all histograms in the app (thanks @MichaelMarcialis for paring on this!)

* The `Open as duplicate timeline` action is `Recent timelines` is now only shown when hovering over a recent timeline

## Loading States

* The `Recent timelines` and `Security news` widgets now use the horizontal bar loading indicator

* The `Host events` and `Network events` widgets now use the horizontal bar loading indicator

* The `Host events` and `Network events` Showing _n_ events subtitles are now hidden on initial load

* The counts in the `Host events` and `Network events` Showing _n_ events subtitles are now hidden on initial load

* We no longer hide some histogram subtitles after initial load, to prevent shifting of content when a user makes a `Stack by` selection

## News Feed Error State

![news-feed-error-state](https://user-images.githubusercontent.com/4459398/73316060-1e538280-41ef-11ea-83f5-b8d6e9fa3741.png)

* Fixed an issue where the `Security news` header was hidden when an invalid URL is configured

* Added a space between the word `via` and the `SIEM advanced settings` link

* Removed the capital “N” from "News" in the error message

## Misc Visual Changes

* Fixed text truncation of the `Severity` column in the `Detections` page's `Signals` table

* Added the “showing” subtitle to the `Signals count` histogram on the Detections page

* Increased the `Stack by` histogram selector and the `View signals | alerts | events' buttons from 8 to 24px

* Tweaked the border rendering in the Overview `Host Events` and `Network events` widget headers

* Added 8px of spacing between the Overview `Host Events` and `Network events` widget accordion headers and their contents

* Fixed an issue where the `Host events` and `Networ events` widgets didn't render in ie11 https://github.com/elastic/siem-team/issues/499

## Non-Visual Fixes

* Removed an incorrect usage of `usememo`

* Removed the placeholder client-side username query from `x-pack/legacy/plugins/siem/public/components/recent_timelines/index.tsx`

* Updated the query of the Overview `Host events` widget to filter by "host.name exists"

* Updated the query of the Overview `Network events` widget to filter by "source.ip exists or destination.ip : exists"
2020-01-29 00:33:40 -07:00
MadameSheema 0b45c24043
refactor (#56131) 2020-01-29 07:20:56 +01:00
Maryia Lapata fd597e0a9e
[NP Cleanup] Remove ui/public/inspector (#55677)
* Use src/plugins/inspector instead of ui/inspector

* Remove unused ui/inspector

* Use `inspector` plugin directly to register view

* Fix path

* Use inspector from NP

* Revert view registration to a separate file
2020-01-29 09:08:42 +03:00
Xavier Mouligneau 9d709c7563
[SIEM] [TIMELINE] Only add endpoint logo when on event.module === endgame (#56263)
* only add endpoint logo when on event.module === endgame

* fix filter for value
2020-01-28 22:53:17 -05:00
Davis Plumlee 1ca013a026
Basic Functionality Alert List (#55800)
* sets up initial grid and data type

* data feeds in from backend but doesnt update

* sample data feeding in correctly

* Fix combineReducers issue by importing Redux type from 'redux' package

* Add usePageId hook that fires action when user navigates to page

* Strict typing for middleware

* addresses comments and uses better types

* move types to common/types.ts

* Move types to endpoint/types.ts, address PR comments

blah 2

Co-authored-by: Pedro Jaramillo <peluja1012@gmail.com>
2020-01-28 20:37:19 -07:00
patrykkopycinski 0d2ac94c6b
[SIEM] Fix filters on Hosts and Network page (#56234)
* [SIEM] Fix Hosts and Network Tabs filters

* cleanup

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-01-28 22:32:07 -05:00
Ryland Herrick 02befdebd2
[SIEM] Adds ability to infer the newsfeed.enabled setting (#56236)
* Always return a contract from the newsfeed plugin

Without a contract, dependent plugins have no way of knowing whether the
plugin is enabled or not as the contract will always be undefined.

* Export newsfeed contract types from public index

So that dependent plugins can use them.

* Declare newsfeed as an optional dependency of SIEM

We're going to use the availability of the newsfeed plugin as part of our
determination for whether or not to show the security newsfeed. If users
set `newsfeed.enabled: false`, the plugin will be unavailable and the
security feed will not be shown.

* Respect global newsfeed.enabled config in Security newsfeed

The presence of the newsfeed plugin means that newsfeed.enabled is true.
If both that and our local setting are true, we will show the Security
feed.

* Prefer object type over empty interface

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-01-28 21:06:37 -06:00
Frank Hassanabad 06890107b4
[SIEM][Detection Engine] critical blocker for updated rules
## Summary

Critical blocker for updated rules and content we need for the release. Given to me by randomuserid and from randomuserid

### Checklist

Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.

~~- [ ] This was checked for cross-browser compatibility, [including a check against IE11](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility)~~

~~- [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md)~~

~~- [ ] [Documentation](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#writing-documentation) was added for features that require explanation or tutorials~~

- [x] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios

~~- [ ] This was checked for [keyboard-only and screenreader accessibility](https://developer.mozilla.org/en-US/docs/Learn/Tools_and_testing/Cross_browser_testing/Accessibility#Accessibility_testing_checklist)~~

### For maintainers

~~- [ ] This was checked for breaking API changes and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)~~

~~- [ ] This includes a feature addition or change that requires a release note and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)~~
2020-01-28 17:31:31 -07:00
Frank Hassanabad 2bab2cc84a
[SIEM][Detection Engine] critical blocker, fixes ordering issue that causes rules to not run the first time
## Summary

Fixes ordering issue that @mikecote found for us with rules where we need to first update the rule before trying to enable it so there aren't issues with API keys.

These types of errors should no longer be seen:

```
{"type":"log","@timestamp":"2020-01-11T09:06:25-07:00","tags":["error","plugins","siem"],"pid":61190,"message":"Error from signal rule name: \"Windows Execution via Connection Manager\", id: \"0624c880-8e64-4c7c-90b4-226b77311ac4\", rule_id: \"f2728299-167a-489c-913c-2e0955ac3c40\" message: [security_exception] missing authentication credentials for REST request [/auditbeat-*%2Cendgame-*%2Cfilebeat-*%2Cpacketbeat-*%2Cwinlogbeat-*/_search?allow_no_indices=true&size=100&ignore_unavailable=true], with { header={ WWW-Authenticate={ 0=\"Bearer realm=\\\"security\\\"\" & 1=\"ApiKey\" & 2=\"Basic realm=\\\"security\\\" charset=\\\"UTF-8\\\"\" } } }"}
```

Testing:

```ts
./hard_reset.sh
```

Then load the pre-packaged rules and enable them all at once. Ensure you don't see any errors such as the ones above. 


### Checklist

Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.

~~- [ ] This was checked for cross-browser compatibility, [including a check against IE11](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility)~~

~~- [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md)~~

~~- [ ] [Documentation](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#writing-documentation) was added for features that require explanation or tutorials~~

- [x] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios

~~- [ ] This was checked for [keyboard-only and screenreader accessibility](https://developer.mozilla.org/en-US/docs/Learn/Tools_and_testing/Cross_browser_testing/Accessibility#Accessibility_testing_checklist)~~

### For maintainers

~~- [ ] This was checked for breaking API changes and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)~~

- [x] This includes a feature addition or change that requires a release note and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)
2020-01-28 16:37:25 -07:00
Xavier Mouligneau fe037bb28e
[SIEM] Add link to endpoint app through reference.url (#56211)
* add rule.reference

* Fix Load more

* Fix spacing

* Fix loading on hist graph detections

* add tooltip
2020-01-28 17:47:42 -05:00
Chris Cowan 76628cd3cd
[Metrics UI] Fixing title truncation in Metrics Explorer (#55917)
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-01-28 16:46:11 -06:00
Tudor Golubenco 6826be2927
[SIEM] Put the notice for rules in comment block (#56123)
* Put the notice for rules in comment block

This comment block marked by `@notice` is picked up by automation and included
in the Kibana NOTICE.txt that we ship with the tar.gz.

Follow up for #56090.
2020-01-28 23:10:15 +01:00
Frank Hassanabad 57f5d77a40
[SIEM][Detection Engine] critical blocker with the UI crashing
## Summary

If you have filters which do not have a $app and state it blows up which isn't what we want to happen. This adds a function which default adds it on the UI if it does not exist

<img width="915" alt="Screen Shot 2020-01-28 at 10 07 39 AM" src="https://user-images.githubusercontent.com/1151048/73296325-bd17b900-41c6-11ea-9ba4-30715224829c.png">

Test:

Post query with everything

```ts
./post_rule.sh ./rules/queries/query_with_everything.json
```

Then visit in the details section of the UI and it should no longer blow up.

### Checklist

Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.

~~- [ ] This was checked for cross-browser compatibility, [including a check against IE11](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility)~~

~~- [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md)~~

~~- [ ] [Documentation](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#writing-documentation) was added for features that require explanation or tutorials~~

- [x] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios

~~- [ ] This was checked for [keyboard-only and screenreader accessibility](https://developer.mozilla.org/en-US/docs/Learn/Tools_and_testing/Cross_browser_testing/Accessibility#Accessibility_testing_checklist)~~

### For maintainers

~~- [ ] This was checked for breaking API changes and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)~~

- [x] This includes a feature addition or change that requires a release note and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)
2020-01-28 15:07:24 -07:00
Brandon Kobel 597e7ea64b
Consistent timeouts for the Space onPostAuth interceptor tests (#56158)
* Consistent timeouts for the Space onPostAuth interceptor tests

* Run 100 times

* Revert "Run 100 times"

This reverts commit 6054ac462e.
2020-01-28 12:59:13 -08:00
Brian Seeders b8c81019a1
Skip tests that depend on other skipped test 2020-01-28 15:13:07 -05:00
Devin W. Hurley 8360faf7bd
[SIEM] [Detection Engine] Timestamps for rules (#56197)
* utilize createdAt and updatedAt from the alerting saved object

* revert accidental change to test rule

* updatedAt is not a part of savedObject attributes passed back from alerting, it's at the top level
2020-01-28 14:56:31 -05:00
Tyler Smalley ff37dd1c25
Sort server-side in SavedObject export (#55128)
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
2020-01-28 11:55:08 -08:00
Tim Sullivan 265c079a8a
[Reporting] Document the 8.0 breaking changes (#56187) 2020-01-28 12:30:55 -07:00
Chris Roberson bd08eb7efc Revert "[Monitoring] Change all configs to monitoring.*" (#56214)
This reverts commit 04ad88cd77.
2020-01-28 14:05:23 -05:00
Mikhail Shustov 06acf2f42a
add owners for es_archiver (#56184) 2020-01-28 19:57:44 +01:00
Mike Côté febb840570
Remove alerts and actions from feature catalogue (#56140) 2020-01-28 13:35:39 -05:00
Mike Côté f97bc898bb
Migrate UI capabilities to use new platform APIs (#56070) 2020-01-28 13:33:43 -05:00
cachedout 54d40e3670
[Stack Monitoring] Prefer units if they are defined when rende… (#43709)
* Prefer units if they are defined when rendering cells

* Jest snapshot update

* Lint recommendations

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-01-28 18:28:45 +00:00
Frank Hassanabad 5108eb378d
[SIEM][Detection Engine] critical blocker bug fixes ancestor mapping
## Summary

* Fixes critical bug with ancestor mapping being object and not correct mappings.

Testing you should now be able to do operations and it will show up on KQL
<img width="1111" alt="Screen Shot 2020-01-28 at 9 33 59 AM" src="https://user-images.githubusercontent.com/1151048/73284943-86d03e80-41b2-11ea-93a4-0d648169d223.png">

<img width="1116" alt="Screen Shot 2020-01-28 at 9 33 22 AM" src="https://user-images.githubusercontent.com/1151048/73285062-b0896580-41b2-11ea-8dfd-6dafa7f28fa9.png">


### Checklist

Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.

~~- [ ] This was checked for cross-browser compatibility, [including a check against IE11](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility)~~

~~- [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md)~~

~~- [ ] [Documentation](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#writing-documentation) was added for features that require explanation or tutorials~~

~~- [ ] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios~~

~~- [ ] This was checked for [keyboard-only and screenreader accessibility](https://developer.mozilla.org/en-US/docs/Learn/Tools_and_testing/Cross_browser_testing/Accessibility#Accessibility_testing_checklist)~~

### For maintainers

~~- [ ] This was checked for breaking API changes and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)~~

~~- [ ] This includes a feature addition or change that requires a release note and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)~~
2020-01-28 11:14:28 -07:00
Joe Portner 04049609f8
Add lockfile symlinks check for correct path (#56043)
Scanning tools may not be able to follow symlinks of symlinks. This
adds an additional check to make sure the lockfile symlink points
directly to the project root's lockfile.
2020-01-28 13:01:24 -05:00
Matthias Wilhelm b9d18c4930 Skip 'context view for date_nanos with custom timestamp' functional test (#56178) 2020-01-28 09:53:21 -08:00
Tim Sullivan f0fbb99088
[Reporting/NP] Migration of Reporting Security dependency (#56046)
* first pass at new security integration

* fix tests

* cosmetic

* specialize security parameter for get user factory
2020-01-28 10:47:28 -07:00
Ben Skelker 0b1d308e3a
fixes map index message (#56104) 2020-01-28 19:36:39 +02:00
Melissa Alvarez b34db43057
[ML] Add functional tests for analytics UI: creation addition and regression/outlier results (#56059)
* add description input functional test to analytics creation test

* regression results functional tests - add initial tests

* outlier results functional tests - add initial test

* ensure description is saved correctly

* fix no key react warning
2020-01-28 12:19:04 -05:00
Brian Seeders 708713496d
Skip flaky visualize_security test 2020-01-28 12:13:56 -05:00
Chris Roberson 04ad88cd77
[Monitoring] Change all configs to monitoring.* (#54919)
* Initial config renaming - not working

* Tweak config key names and move to core_deprecations

* Remove new ones from this PR

* Fix mocha tests

* Update more configs

* Update config in test

* Add note to move these

* Missed one

* Fix mocha tests

* Fix tests
2020-01-28 11:38:35 -05:00
Frank Hassanabad a157513cfa
[SIEM][Detection Engine] critical blocker updates to latest ECS version
## Summary

* Updates to the latest ECS version right before us shipping as expected by taking it from:
https://raw.githubusercontent.com/elastic/ecs/master/generated/elasticsearch/7/template.json



Testing:
* Ensure I remembered to put `"dynamic": false`
* Do a ./hard_reset.sh
* Test run a few things to make sure everything still works as expected.

### Checklist

Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.

~~- [ ] This was checked for cross-browser compatibility, [including a check against IE11](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility)~~

~~- [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md)~~

~~- [ ] [Documentation](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#writing-documentation) was added for features that require explanation or tutorials~~

~~- [ ] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios~~

~~- [ ] This was checked for [keyboard-only and screenreader accessibility](https://developer.mozilla.org/en-US/docs/Learn/Tools_and_testing/Cross_browser_testing/Accessibility#Accessibility_testing_checklist)~~

### For maintainers

~~- [ ] This was checked for breaking API changes and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)~~

~~- [ ] This includes a feature addition or change that requires a release note and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)~~
2020-01-28 09:32:16 -07:00
Chris Roberson 30dbdf7350
[Monitoring] Fix inaccuracies in logstash pipeline listing metrics (#55868)
* Change how we fetch pipeline listing metrics to match what other charts show

* Fix tests

* Fix tests

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-01-28 11:29:16 -05:00
igoristic 9685eca401
Resetting errors and removing duplicates (#56054) 2020-01-28 11:25:04 -05:00
Joe Reuter 8c2980213e
Add flag to opt out from sub url tracking (#55672)
* introduce flag for disabling sub url tracking

* re-generate documentation and extend ui_app

* fix ui_nav_link test

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-01-28 16:51:07 +01:00
Frank Hassanabad 24a6eb2cde
[SIEM][Detection Engine] critical bug, fixes duplicate tags
## Summary

You can get duplicate tags that keep growing with each update which is not good at all and will cause major data issues for customers.

<img width="467" alt="Screen Shot 2020-01-27 at 10 22 23 PM" src="https://user-images.githubusercontent.com/1151048/73242235-9d01de80-4161-11ea-9c5d-56cafc865dd5.png">

Testing:

Create a rule, then update it

```sh
./post_rule.sh
./update_rule.sh
```

Grab the id of the rule and run the `get_saved_objects.sh` like so:

```sh
./get_saved_objects.sh alert ${id}
```

You shouldn't have duplicates in tags, it should look like this:

```sh
    "tags": [
      "__internal_rule_id:query-rule-id",
      "__internal_immutable:false"
    ],
```


### Checklist

Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.

~~- [ ] This was checked for cross-browser compatibility, [including a check against IE11](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility)~~

~~- [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md)~~

~~- [ ] [Documentation](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#writing-documentation) was added for features that require explanation or tutorials~~

- [x] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios

~~- [ ] This was checked for [keyboard-only and screenreader accessibility](https://developer.mozilla.org/en-US/docs/Learn/Tools_and_testing/Cross_browser_testing/Accessibility#Accessibility_testing_checklist)~~

### For maintainers

~~- [ ] This was checked for breaking API changes and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)~~

- [x] This includes a feature addition or change that requires a release note and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)
2020-01-28 08:49:49 -07:00
Walter Rafelsberger 106ddf918c
[ML] Anomaly Detection: Fix persist/restore of refreshInterval in globalState. (#56113)
Fixes persist/restore of the date picker's refreshInterval in globalState.
2020-01-28 16:26:36 +01:00
Walter Rafelsberger 5ecd34afda
[ML] Single Metric Viewer: Fix annnotations refresh. (#56107)
When creating/editing/deleting an annotation, the Single Metric Viewer page wouldn't update with the applied changes. This fixes it by tracking the change in the outer component with lastRefresh/previousRefresh and making it a condition in contextChartSelected() to trigger an update after a refresh.
2020-01-28 16:07:31 +01:00
Pierre Gayvallet a1ccb29731
adapt ObjectToConfigAdapter.getFlattenedPaths to consider arrays as final values (#56105)
* adapt getFlattenedPaths to consider arrays as final values

* add getUnusedConfigKeys test

* improve tests
2020-01-28 16:04:43 +01:00
Josh Dover 7d2074a95a
Add Appender.receiveAllLevels option to fix LegacyAppender (#55752) 2020-01-28 07:34:27 -07:00
David Roberts 9fcbeb3dd8
[ML] Process delimited files like semi-structured text (#56038)
Changes the file upload functionality to process delimited
files by splitting them into to messages, then sending
these to the ingest pipeline as a single field for further
processing in Elasticsearch.

The csv_importer has been removed and the old sst_importer
replaced with a similar message_importer that has been
enhanced to cover the edge cases required by delimited
file processing.

Previously the file upload functionality parsed CSV in the
browser, but by parsing CSV in the ingest pipeline it
makes the Kibana file upload functionality more easily
interchangable with Filebeat such that the configurations
it creates can more easily be used to import data with the
same structure repeatedly in production.

Companion to elastic/elasticsearch#51492
2020-01-28 14:16:50 +00:00
Nick Partridge 05ed2d63b5
Charts plugin (combining ui/color_maps and EuiUtils) (#55469)
* Combine ui/color_maps and EuiUtils into new Charts plugin
* EuiUtils is now the theme service
* ui/color_maps is now the colorMaps service
* Fix all imports of each to pull from new Charts plugin
* Add theme methods to both setup and start contracts
* Move and jestify heatMapColors tests
* Convert remaining js files to ts
* Move vis/color to Charts plugin
* Update missed visTypeVislib naming
2020-01-28 08:13:56 -06:00