* WIP: Adding in new reporting diag tool
* WIP: chrome-binary test + log capturing/error handling
* More wip on diagnostic tool
* More work adding in diagnose routes
* Alter link in description + minor rename of chrome => browser
* Wiring UI to API + some polish on UI flow
* WIP: Add in screenshot diag route
* Adding in screenshot diag route, hooking up client to it
* Add missing lib check + memory check
* Working screenshot test + config check for RAM
* Small test helper consolidation + screenshot diag test
* Delete old i18n translations
* PR feedback, browser tests, rename, re-organize import statements and lite fixes
* Lite rename for consistency
* Remove old validate check i18n
* Add config check
* i18n all the things!
* Docs on diagnostics tool
* Fixes, better readability, spelling and more for diagnostic tool
* Translate a few error messages
* Rename of test => start_logs for clarity. Move to observables
* Gathering logs even during process exit or crash
* Adds a test case for the browser exiting during the diag check
* Tap into browser logs for checking output
* Rename asciidoc diag id
* Remove duplicate shared object message
* Add better comment as to why we merge events + wait for a period of time
* Cloning logger for mirroring browser stderr to kibana output
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
* Add new x-pack advanced setting searchTimeout and use it in the EnhancedSearchInterceptor
* docs
* Rely on server timeout in OSS (?)
Use UI setting in xpack.
* Rename function
* doc
* Remove esShard from client
* cleanup request parameters from FE
* doc
* doc
* Align request parameters on server,
Remove leftover parameters from client
Shim responses for search and msearch routes
* docs
Stop using toSnakeCase
Updates jest tests
* add management docs
* docs
* Remove import
* Break circular dep + fix msearch test
* Remove deleted type
* Fix jest
* Bring toSnakeCase back
* docs
* fix jest
* Fix merge
* Fix types
* Allow timeout to be undefined
* Fix jest test
* Upldate docs
* Fix msearch jest
* docs
* Fix rollup search merge
* docs
Co-authored-by: Lukas Olson <olson.lukas@gmail.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
* Converted maps_router and store operations files
* Converted files in map routes to typescript
* Removed an unwanted ts-expect-error
* Fixed the lint errors from jenkins
* Naming changes, type for mapStateJSON etc.
* More type fixes in map routes
* More type fixes in map routes
* Added back some removed props
* Added types to app state manager
* Autogenerated api documentation
* Type fixes
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
* New Search API for timelion
* Using timeout from config
* Use only es strategy)
* Fixed remarks
* Fixed tests
* Fixed fixtures
* Fixed ci
* Fixed typecheck
* Fixed eslint
* Fixed remarks
* Fix changes
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
* [DOCS] Add default time range filter to advanced settings
* [DOCS] More edits
* [DOCS] Adds behaviour when disabled
* [DOCS] Synchs setting name changes
* [DOCS] More edits
* [Lens] Drag to replace
* Add jest tests for drag and drop
* Fix bug in dragging to empty
* Hide dragged dimension when drag starts
* Make table metrics required
* Update class names
* Implement styles on non-droppable items
* Replace drag and drop image in docs
* Remove extra specificity
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
* Simple benchmark tests for kuery
* Building manually is "better" still not free
* Building the KueryNode manually
* Removing benchmark tests
* Another query is building the KueryNode manually
* Empty strings are inherently falsy
* No longer reaching into the data plugin, import from the "root" indexes
* Using AGENT_ACTION_SAVED_OBJECT_TYPE everywhere
* Adding SavedObjectsRepository#find unit test for KueryNode
* Adding KQL KueryNode test for validateConvertFilterToKueryNode
* /s/KQL string/KQL expression
* Updating API docs
* Adding micro benchmark
* Revert "Adding micro benchmark"
This reverts commit 97e19c0bf3.
* Adding an empty string filters test
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
* KQL autocomplete cut off in visualize editor
Closes#70964
* Refactor some code
* Accept api changes, refactor query_string_input and suggestions_component
* Add a comment to suggestions_component
* Fix dropdown position, add close event on scroll and hide description if it doesn't fit
* Update tests to pass type check
* Fix displaying bugs
* Remove closeList
* Replace dropdownHeight with className
* Update suggestions_component.test and public.api.md
* KQL autocomplete cut off in visualize editor with styled-components
* Update suggestions_component.test values
* Add logic to open the list up
* Remove unnecessary semicolon
* Remove a gap between the list and input by inlining offset -2px from _suggestion.scss
* Rename the constants and add docs to them
* Wrap div inside SuggestionsComponent by styled component instead of wrapping the whole component
* Update public.api.md
* Refactor .kbnTypeahead__popover--top style
* Remove unnecessary condition
* Fix eslint problems
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
* rename uuid service to environment service
* adapt resolve_uuid to directly use the configurations
* move data folder creation to core
* update generated doc
* fix types
* fix monitoring tests
* move instanceUuid to plugin initializer context
* update generated doc
* add asciidoc support for generated plugin list
Try level offset "=+2" instead of "=+1" to stop the inlining of the includes.
remove +2 back to +1
* Remove asciidoc, switch to regex. Rearrange dev guide to avoid nesting limit.
* Add tests for regex
* add a description to not throw off the table. Remove the heading from the paragraph snippet.
* Fix more READMEs so table renders correctly
* Update plugin list
* Remove code-exploration file, moved to plugin-list
* fix typo
* Add link to developer examples
* Update plugin list
* fix typo
* Add support for decorating 429 errors in the saved objects client
* Update the docs
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
* improve test stability
* Replace SearchRequest = any with Record<string, any>
* Remove SearchResponse = any from data plugin
* docs
* logs
* Revert "Replace SearchRequest = any with Record<string, any>"
This reverts commit 9914ab5a01.
* code review
* list control
* null check
* null null null
* Jest fix
* add security solution search strategy on server side
* get security solution search strategy in the public app for all host
* fix types
* fix Check core API changes
* thank you cypress test
* Remove any by the right type IESearchRequest
Co-authored-by: Lukas Olson <olson.lukas@gmail.com>
* add translation and filter error when we abort the query
* pr review
* fix translation
* review II
* fix merge issue
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Co-authored-by: Lukas Olson <olson.lukas@gmail.com>
* Add Index Management README and quick testing steps for data streams.
* Surface data stream health in Data Streams tab (table and detail panel).
- Extract out DataHealth component for use in both Data Streams and Indices tabs.
- Refactor detail panel to use data structure & algo to build component.
- Refactor detail panel to use i18n.translate instead of FormattedMessage.
* Render index template name and index lifecycle policy name in the detail panel.
* Render storage size and max timestamp information in table and detail panel.
- Add 'Include stats' switch.
- Add humanizeTimeStamp service, localized to data streams.
* Bringing Vega out of experimental
Closes: #21721
* fix CI group 12
* remove experimental flag from doc
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Adds support for `version` one the SavedObjectsClient's create api.
This sallows us to retain Optimistic concurrency control when using create to overwrite an existing document.
* Route options timeout -> timeout.payload
* timeout.idleSocket can now be specified per route
* Removing nested ternary
* Fixing integration tests
* Trying to actually fix the integration tests. Existing tests are hitting
idle socket timeout, not the payload timeout
* Fixing payload post timeout integration test
* Fixing PUT and DELETE payload sending too long tests
* Fixing type-script errors
* GET routes can't specify the payload timeout, they can't accept payloads
* Removing some redundancy in the tests
* Adding 'Transfer-Encoding: chunked' to the POST test
* Fixing POST/GET/PUT quick tests
* Adding idleSocket timeout test
* Removing unnecessary `isSafeMethod` call
* Updating documentation
* Removing PUT/DELETE integration tests
* Working around the HapiJS bug
* Deleting unused type import
* The socket can be undefined...
This occurs when using @hapi/shot directly or indirectly via
Server.inject. In these scenarios, there isn't a socket. This can also
occur when a "fake request" is used by the hacky background jobs:
Reporting and Alerting...
* Update src/core/server/http/http_server.ts
Co-authored-by: Josh Dover <me@joshdover.com>
* Adding payload timeout functional tests
* Adding idle socket timeout functional tests
* Adding better comments, using ?? instead of ||
* Fixing the plugin fixture TS
* Fixing some typescript errors
* Fixing plugin fixture tsconfig.json
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Co-authored-by: Josh Dover <me@joshdover.com>
* wip deprecation notice on timelion app
* Add a deprecation notice on timelion app
* Minor, add visualize and timelion on the docLinks
* Chage the layout a bit
* Change the deprecation notice message
* Change the deprecation notice message
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
* timelion deprecation doc wip
* Create Timelion Deprecation section to Visualize
* Code review changes
* minor changes
* Make some changes in order to give priotization on how to replace an existing timelion worksheet to a dashboard
* Syntax related improvements
* Final touch
* Remove extra lines and some minor changes
- Introduce `indexPattern.fields.getAll()` and use where possible
- Rename `index_patterns/fields/fields.mocks.ts.ts => index_patterns/fields/fields.mocks.ts`
- FieldSpec - make `count` and `scripted` fields optional
- use `indexPattern.fields.getByName` instead of filter where possible
- Better distinction and relationship between IndexPatternField and its spec
- IndexPatternField class is no longer defined via object mutation
- Reduction of dependencies
- UI code moved into Index Pattern class (will be removed in next ticket)
- IndexPattern field list was previously composed of IndexPatternFields or specs, now only IndexPatternFields
- IndexPattern field list was previously redefined when loading fields, now only its contents are replaced.
Fixes#71461 regression since 7.7
New state syncing utils didn't properly handle errors,
Errors happening during URL parsing or writing wasn't handled, so state syncing could stop or in worth case blow out. (see #71461)
There are not much scenarios where missing proper error handling could really impact users, except the one described in #71461:
Kibana users state:storeInSessionStorage
Users often intuitively share hashed dashboard urls directly
When someone opens those urls - there is a blank screen with warning
In 7.6 - dashboard would still load with default state.
Since 7.7 these still could be achieved by removing query params for URL, but it is not obvious for regular users.
This PR makes sure that behaviour is similar to one we had before 7.7.
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
* [Search] Send ID in path, rather than body
* Fix typo in merge
* Update docs
* Revert to using POST instead of GET
* Revert accidental change
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
* [Search] Fix telemetry collection to not send extra requests
* Update tracker to collect duration from ES response
* Fix type check
* Update docs and types
* Fix typescript
Co-authored-by: Liza K <liza.katz@elastic.co>
* mark legacy ES client types as deprecated
* expose es client to plugins and update mocks
* ElasticSearchClientMock --> ElasticsearchClientMock
* expose es client mocks
* expose es client via RequestHandlerContext
* convert test/plugin_functional/config into ts
* convert top_nav test into ts
* add an integration test for the es client
* update comments to refer to the new es client
* fix import paths. do not use extensions
temp
* update docs
* fix other refs
* add test for a custom client
* fix context
* add test for scoped client
* update docs
* improve test stability
* query string input manager (needed for search demo)
* docs
* dashboard
* Fix jest
* mock fix
* Allow restoring a saved query
* sync url
* Luke's fix to test
* cleanup
* lens jest tests
* docs
* use queryStringManager.getDefaultQuery
Don't sync query to global state
* Update app.test.tsx
lens mock
* jest fix
* jest
* use new api in the example
* Rename state param to query to match url state
* Apply changes to discover
* Update src/plugins/data/public/query/query_string/index.ts
Co-authored-by: Anton Dosov <dosantappdev@gmail.com>
* Improve query string state manager
* Cleanup dashboard code
* Handle refresh button
* Set initial dashboard state
* visualize state
* remove unused
* docs
* fix example
* fix jest
* fix filter app state in discover
* fix maps test
* jest
Co-authored-by: Anton Dosov <anton.dosov@elastic.co>
Co-authored-by: Anton Dosov <dosantappdev@gmail.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
## Summary
By default the upload time limit for payloads is 10 seconds. This is really too short and we were getting internal QA bug reports that uploads are timing out on large value list importing. This PR adds the plumbing and unit tests to make the timeout configurable for routes.
* Adds a single timeout option for routes and then normalizes that through Hapi for the socket, payload, and server timeouts.
* Adds unit tests which test the various options
* Adds integration tests which test the various options
* Adds some NOTES about where there are odd behaviors/bugs within Hapi around validations and the timeouts
* Adds a configurable 5 minute timeout to the large value lists route
**Manual testing of the feature**
You can manually test this by adding a configurable option to your chrome network throttle like so below where you throttle upload by some configurable amount. I chose to use 300 kbs/s upload
<img width="556" alt="Screen Shot 2020-07-23 at 11 26 01 AM" src="https://user-images.githubusercontent.com/1151048/88318015-5ab3f700-ccd7-11ea-9d9b-7e3649ec65de.png">
And then run an import of large value lists using a large enough file that it will exceed 5 minutes:
After 5 minutes you should see this message within your server side messages if you have configured your kibana.dev.yml to allow for these messages:
```ts
server respons [10:52:31.377] [access:lists-all] POST /api/lists/items/_import?type=keyword 408 318292ms - 9.0B
```
Note that it should show you that it is trying to return a `408` after `318292ms` the timeout period. Sometimes you will get the 408 in the browser and sometimes the browser actually will not respect the 408 and continue staying in a pending state forever. This seems to be browser side issue and not a client/user land issue. If you get the browser message it will be this error toaster
### Checklist
- [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md)
- [x] [Documentation](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#writing-documentation) was added for features that require explanation or tutorials
- [x] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios
### For maintainers
- [x] This was checked for breaking API changes and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)
* Copying api integration tests into their own directory
* Removing api integration tests and using ingest docker image
* Fixing typo
* Fixing type errors and empty string and reenabling tests
* Rebuilding docs
* Renaming url override variable
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
* move http.anonymousPaths.register('/status'); logic into core, remove status_page plugin
* move status_page to core & migrate lib
* migrate the status_app components to TS/KP APIs
* update rendering snapshots
* use import type syntax
* moves `/status` server-side route to core
* fix route registration
* update generated file
* change statusPage i18n prefix
* (temporary) try to restore legacy plugin to check behavior
* add some FTR tests
* do not import whole lodash
* update snapshots
* review comments
* improve / clean component unit tests
* change url for legacy status app
* set status app as chromeless
* fix FTR test due to chromeless app
* fix typings
* add unit test for CoreApp /status registration
* use KibanaClient interface instead of Client
* add back helpers to ElasticsearchClient interface
* use TransportRequestPromise for transport.request
* update generated doc
* Add a few asciidoc readmes
* add updated code-exploration. Need to fix the script in another go to add asciidoc support. The snippet didn't show up anyway.
* rename float to discrete
* use same section title level on all source files
* Elasticsearch => {es}
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
* [search] Refactor the way search strategies are registered/retrieved on the server
* Fix types and tests and update docs
* Fix failing test
* Fix build of example plugin
* Fix functional test
* Make server strategies sync
* Move strategy name into options
* docs
* Remove FE strategies
* TypeScript of hell
delete search explorer
* Fix search interceptor OSS tests
* typos
* test cleanup
* Update search interceptor tests and abort utils
* [Search] Add telemetry for data plugin search service
* Add tracking of average query time
* Add tests and rename to collectors
* Fix TS
* Fixed interceptor jest tests
* Add to kibana json
* docs
* Properly use observables rather than only during setup
* Update or create
* Swallow version conflict errors
Co-authored-by: Liza K <liza.katz@elastic.co>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
* [DOCS] Adds API keys to API docs
* Fixes link title
* Update docs/api/using-api.asciidoc
Co-authored-by: Brandon Morelli <bmorelli25@gmail.com>
Co-authored-by: Brandon Morelli <bmorelli25@gmail.com>
* [search] Refactor the way search strategies are registered/retrieved on the server
* Fix types and tests and update docs
* Fix failing test
* Move strategy name into options
* Remove FE strategies
* TypeScript of hell
delete search explorer
* Fix search interceptor OSS tests
* test cleanup
* fix
* return search wrapper
* initial api
* Shiny happy cleanup
* docs
* fix jest test
* simplify strategy registration
* fix rebase
* fix rebase
* fix backport
* types
* TS for strategy
* docs
Co-authored-by: Lukas Olson <olson.lukas@gmail.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
* Fix dimension popover layout and color picker “Auto”
* Created ToolbarButton
* Move disabled help text to tooltip for missing values
* Darker side panel backgrounds
* Adding to .asciidoc about where to put the SASS import
* Moving `SASS` guidelines to STYLEGUIDE.md
* Fix keyboard focus of XY settings popover
* Fix dark mode
* [Data Plugin] Allow server-side date formatters to accept custom timezone
When Advanced Settings shows the date format timezone to be "Browser,"
this means nothing to field formatters in the server-side context. The
field formatters need a way to accept custom format parameters. This
allows a server-side module that creates a FieldFormatMap to set a
timezone as a custom parameter. When custom formatting parameters exist,
they get combined with the defaults.
* add more to tests - need help though
* simplify changes
* api doc changes
* fix src/plugins/data/public/field_formats/constants.ts
* rerun api changes
* re-use public code in server, add test
* fix path for tests
* weird api change needed but no real diff
* 3td time api doc chagens
* move shared code to common
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
* Move kibana-keystore from data/ to config/
This is a breaking change to move the location of kibana-keystore.
Keystores in other stack products live in the config directory, so this
updates our current path to be consistent.
Closes#25746
* add breaking changes
* update comment
* wip
* fix docs
* read from both keystore locations, write priority to non-deprecated
* note data directory fallback
* add tests for get_keystore
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
* chore(NA): load NODE_OPTIONS from options files across environments
* chore(NA): move node.ci.options to config folder
* docs(NA): update docs to explain how to set node options from the cfg fil
* chore(NA): removed test npm scripts
* fix(NA): typo on setup script for CI
* chore(NA): add debug info
* chore(NA): export options on CI
* chore(NA): remove debug info
* chore(NA): support for configurable config folder using env var
* chore(NA): add node.options file into docker img
* fix(NA): use calculated config dir on node options for ci
* chore(NA): node bin scripts bootstrap and node_with_options implementation for bash
* chore(NA): complete node_with_options scripts with bat version
* chore(NA): add bin/node dev script and remove cli for run_with_node_options
* chore(NA): increase default maxBuffer
* chore(NA): remove run with options script from package.json
* chore(NA): include kbn-node script and underlying usage of it
* chore(NA): remove change on eslint
* chore(NA): correct typo on kbn node script comment
Co-authored-by: Tyler Smalley <tylersmalley@me.com>
* chore(NA): correct typo on kbn node script comment
Co-authored-by: Tyler Smalley <tylersmalley@me.com>
* chore(NA): add line to describe each option should be specified in a separated line
* chore(NA): remove node options from dev and ci env
* chore(NA): remove changes from package.json
* chore(NA): fix docker image build
* chore(NA): change value for example of --max-old-space-size in the node.options file
Co-authored-by: Tyler Smalley <tylersmalley@me.com>
* chore(NA): remove --no-warnings from node.options and force it in the bin scripts
* chore(NA): prevent 'The system cannot find the file' error message
* chore(NA): introduce slash when building path for %DIR%
* chore(NA): read options from file only if it exists
Co-authored-by: Jonathan Budzenski <jbudz@users.noreply.github.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Co-authored-by: Tyler Smalley <tylersmalley@me.com>
