* Update buildNum mapping from string/not_analyzed to keyword
* Change index-pattern type mappings from string -> keyword
* Updating unit test
* Updating string mappings for various saved object types
* Fixing mapping for index pattern title field
This needs to be text because other types in the Kibana index also have a field named "title", whose mapping needs to be text. We can't have the same field have different mappings in different types within the same index.
* Removing unused files
* Removing test file because corresponding source file is gone now
* Save/rename flow fix
- Use auto generated ids instead of coupling the id to the title which
creates problems.
- Adjust UI to make the save flow more understandable.
- Remove confirmation on overwrite since we will now be creating
duplicate objects even if they have the same title.
* use undefined instead of null
* Change titleChanged function name
* address code review comments
* Add isSaving flag to avoid checkbox flicker, fix regression bug from refactor.
Added tests and fixed a couple bugs
Updated info message
* Update doc and nav title with new name on rename
don't hardcode Dashboard
The deepModules hacks in the build system were added to support the long
paths that resulted from npm2, but npm3 fundamentally addresses that
problem, so deepModules is no longer necessary. In practical terms, npm3
shouldn't ever cause path lengths to become so long that they trigger
path length problems on certain operating systems.
Tests fails intermittently, and for identical reasons. When this occurs, skip the test. This only occurs in CI and cannot be reproduced locally.
Additional changes:
- Use async/await to improve legibility.
- Move async behaviour to beforeEach and keep test stubs synchronous to improve labeling of tests.
If the ui settings status is not green, that means there is at least one
dependency (so elasticsearch at the moment) that is not met in order for
it to function correctly, so we shouldn't attempt to determine user
settings at all.
This ensures that when something like the version check fails in the
elasticsearch plugin, Kibana correctly behaves by not attempting
requests to elasticsearch, which prevents 500 errors and allows users to
see the error status on the status page.
We also now periodically check for compatible elasticsearch versions so
that Kibana can automatically recover if the elasticsearch node is
upgraded to the appropriate version.
* Use uniquely and semantically named data attribute to select loading message, instead of CSS class since that creates a brittle coupling between JS and CSS.
* Formalize this rule in the CSS style guide.
This change, which was originally introduced in #9136, resulted in much
larger installs for Kibana (50MB larger in dev mode), which isn't a
reasonable tradeoff for the convenience that global-style provides.
* Improve robustness
Tagcloud was subsceptible to race conditions, potentially yielding stale clouds.
- Introduced queue to explicitly keep track of outstanding jobs and avoid clobbering of the state.
- Expanded unit tests
* ensure tagcloud expands to full height in reporting
* remove magic numbers
* Fix filters for complex painless scripted fields
Painless scripted fields that consisted of more than a single expression
would break when the user attempted to filter on them in Discover or
Visualize because of the naive way we were building them. We now wrap
the user's script in a lambda so that it can be as complex at they need
it to be. The only special exception is that the user cannot define
named functions since those cannot go inside a Painless lambda.
Fixes https://github.com/elastic/kibana/issues/9024
Related https://github.com/elastic/elasticsearch/pull/21635
* DRY it up
* Phrase tests
* Only include necessary comparators and add tests
* fix issue with hiding loading message in embedded mode
* Fix match as well
This chunk of logic only matched on =embed, not =embed=true, which is
what the url given by sharing uses.
Note there is a bug that already exists in timeline where the
notify.info message disappears immediately. Not fixing in this PR, but
the delete info message suffers the same bug as the save info message
does already.
* [server/uiSettings+shortUrl] surface errors from es
* [uiExports/replaceInjectedVars] update the uiSettings stub
* [uiSettings] correct test cases after moving from 401 -> 403
* correctly use implementsRenderComplete from vis config
* set implementsRenderComplete on all vis types
* emit on DOM instead of the vis
* vis doesn't need to be an EventEmitter
* listen for renderComplete on visualize
set and update element attributes as the event(s) fire, and indicate if they ever will
* [vislib/handler] fall through to lower return
* [vislibRenderbot/tests] reduce expected call count
* [vis/tests] add $element to test injectors
* [markdownVis] fix test
A tag cloud visualization is a visual representation of text data, typically used to visualize free form text. Tags are usually single words. The font size of word corresponds with its importance.
Installing dependencies "global-style" creates a top-level directory in `node_modules` for each direct dependency, and then creates a flat tree of dependencies inside each of those.
I prefer this method because it prevents accidentally depending on a dependency of a dependency, and makes it easier to find dependencies in `node_modules`.
Unfortunately the `node_modules` directory will be a little deeper.
* Update PageObjects for Visualize, Dashboard, and Discover to use data-test-subj selectors for menu items.
* Run checkPlugins task as part of test:ui:runner task.
* support scripted fields
* update column_chart test to check brush for ordered data
* brush histogram
* incorporate changes request by cjcenizal
* fixed typo
* support scripted fields
* update column_chart test to check brush for ordered data
* Fix init_x_axis unit tests.
* add brush_event test
* Fix small timezone bug in brushEvent tests. Polish test descriptions.
* [uiExports] add replaceInjectedVars() export type
* [ui] do not assume es plugin is always there
* [server/status] fix typo
* [ui] add errror handling to /app/{id} endpoint
* [ui] add tests for replaceInjectedVars()
* [npm] swap out jsdom with cheerio
* [server/ui] continue extender => replacer rename
* Add original message back to loading screen. Run CSS through autoprefixer.
* Make kibanaWelcomeView and kibanaWelcomeLogo styles available to plugins which may need them, by moving them into ui_app.jade.
Multi-statement scripts are currently incompatible with the way we
create filters on scripted fields. We're investigating the possibility
of enhancing elasticsearch to fix this issue, but we may have to
fallback on showing users a warning if we can't reach an agreement in
the near term.
See https://github.com/elastic/kibana/issues/9024
Related https://github.com/elastic/elasticsearch/issues/21479
