* [ML] Restore missing job timepicker modal.
* [ML] Added a karma/mocha test to verify dependencies are loaded correctly for new_job_controller.
* [ML] Use consistent import style.
* Refactor service colors
* Calculate duration from full waterfall
* Ensure timeline label is not truncated
* Adjust child if it starts after parent has ended
* Add mark for traceRootDuration instead of xMax
* Fix tests
* refact(NA): make canvas common lib ready for static analysis.
* refact(NA): change export named to export all on canvas commmon lib datatable.
* tes(NA): fix isValid http url function name.
* refact(NA): rename parse to parseDataUrl
* display error messages for failed checks vs disableing plugin
* update text
* change order of check
* tweak security check
* re-disable on invalid license, update text
* update text
* tweaks
* tweak text
This PR changes the aggregation for calculating the CPU usage for hosts to match the metrics overview calculation by adding both system and user together then dividing it by the number of cores. This PR also includes a fix for the Docker cpu field.
Resolves#25007.
Outbound traffic is generally denoted with TX, abbreviation for Transmit, instead of RX, abbreviation of Receive.
This PR fixes this minor typo.
* Consistently format errors with showApiWarning and showApiError helpers.
* Use fatalError for unexpected errors.
* Localize errors.
* Surface error in Job List when the jobs can't be loaded.
* Added sort order to share menu options.
Sorts ascending on sort order first then ascending on name. Any menu item without a sort order gets set to zero.
* Moved new sortOrder property from node_modules
* Had to rerun the snapshot for the share menu with the sortOrder in it.
PR fixes issues with the socket connection.
- handle socket failures
- previously would either leave Canvas in an infinite loading state, or load the app even when it wouldn't function
- upgrade socket.io
- add headers to socket connection and modify auth connection
This fixes `yarn run lint` from within the Canvas plugin path.
- Point to the correct eslint config file
- Use absolute path for `packageDir`
- Remove extraneous `packageDir` settings
* [build] Support version-qualifier flag
* add help description
* fix test
* is-release
* temp: re-add alpha1 to package.json
* use version qualifier in build
* fix merge
* Revert "temp: re-add alpha1 to package.json"
This reverts commit a70688542c.
* x-pack
* remove ci build flag
* remove ci build flag
* remove qualifier from canvas
* remove qualifier from infra
* fix x-pack argv
* update comment
* Adds aliases to details for indicies.
* Lists aliases when there is more than one.
Fixes reload call using duplicate code atm.
Removes unintentional formatting change.
* Silly line ending removed by accident.
* Simplifies fetching aliases to single method/file.
* Adds superfluous logs statement.
* Uses the correct i18n translation variable for the header.
* Sets the translation variable to the correctly spelled variable.
* Simplifies building an array of aliases.
* Does not export fetchAliases as default.
* Makes the code more readable by destructing results.
* Adds test for expected results and no results.
* Adds custom font as option in font picker
* Adjusted font sizes in ecommerce sample worpad
* Adjusted font sizes in sample flight workpad
* Adjusted font sizes in smaple web logs workpad
* Changes for new PNG image output for reports
Change PNG button name from Download to Generate
Changes for new PNG image output for reports
Change PNG button name from Download to Generate
Remove compatabilityShim from PNG and move to PDF folders
Changed API parameters to contain only required parameters
Added test cases for PNG reporting and added title back into the PNG API call
Merge of security changes for PNG reporting
Fixed issues with test cases for both PDF and PNG
Updated test snapshots for PNG and PDF test changes
* Adding new security changes made for PDF into new PNG code
* Removed commented out lines that were not needed
* Disable deletion of started rollup jobs.
* Update empty prompt icon.
* Add isUpdating selector and display a spinner instead of the action button when jobs are being updated.
* Localize Navigation component.
* Add noticeable delay of 300ms show spinner displays and doesn't flicker.
* Adding very basic place for the logged out page
* Redirecting to logged_out when we aren't using SLO
* Basing styles on the login styles
* Fixing linting errors
* Responding to PR feedback
* Fixing issue with the basepath and the login link
* Adding proper i18n prefix
* Updating unit tests
update testing helper functions for react-intl
now we use real intl object passed by IntlProvider via context instead of mocking intl object.
so now data(strings, JSX) passed to FormattedMessage component via values are compiled and
are inserted in the output of FormattedMessage component
* [APM] Fixes#40165 by consolidating logic where total duration could be 0 and handling it with a fallback value
* [APM] renamed file from .js to .ts and defined a default value for fallback
* [APM] Add type definitions for apm formatters
* [APM] add basic type definition for imported @elastic/numeral module
* [APM] rename getDurationPercent to asPercent
* [APM] Update tests with the renamed formatter function
* [APM] Pr feedback & typescript cleanup
* [APM] fix bucket & chart point type errors
* Fix typescript issue
* [APM] last minute code cleanup
Introduces a categorical/ordinal y axis for rare charts with a cardinality of <= 10. This also adds unit tests for the rare/population chart which are the bulk of the PR.
This replicates the behaviour of the management UI: If there's no default index pattern, the one created via file visualizer's import will be set as the default index pattern.
* [APM] Hoist loading of waterfall and flatten it
Remove unused test
Convert to typescript
* Address feedback
* Make `totalDuration` optional
* Renamed rootTransaction to traceRoot
* [APM] Only show relevant service legends
* Adds services label to the service legend
* [APM] Clock skew fix
Only skew child spans from the same service
Take parent skew into account when finding diff
# Conflicts:
# x-pack/plugins/apm/public/components/app/TransactionDetails/Transaction/WaterfallContainer/Waterfall/waterfall_helpers/__snapshots__/waterfall_helpers.test.ts.snap
# x-pack/plugins/apm/public/components/app/TransactionDetails/Transaction/WaterfallContainer/Waterfall/waterfall_helpers/waterfall_helpers.test.ts
# x-pack/plugins/apm/public/components/app/TransactionDetails/Transaction/WaterfallContainer/Waterfall/waterfall_helpers/waterfall_helpers.ts
* Use switch statement
* Fixes active tab state
* Removes beta labels from ML and search bar
* Reverts visual regression with right-to-left timeline fix
* Creates space for agent marks beneath tick marks
* Fixes ordering problem with timeline transaction icons
* Updates string 0 to be an integer instead for CSS bottom value
* [APM] fixes#24563 by replacing de-duping the twice-used column field id
* [APM] fixed issue with service column not sorting in ManagedTable
* [APM] make render field on ITableColumn optional and allowing it to use EUI's default value
* Internationalize job details tabs and wrap instances in EuiErrorBoundary to visually localize the error.
* Localize no default index pattern message.
* Localize es interval errors.
* Localize job action menu and confirm delete modal.
* Remove unnecessary use of injectI18n from tabs.
* Localize job status.
* Localize steps.
* Remove template literals from FormattedMessages.
Fixes the missing y-axis description for rare charts in the form of y-axis event distribution split by {{fieldName}}. The intention is to briefly clarify that the type of chart is different than the other ones which have a count or metric based y-axis. This text is in addition to the text provided (but hidden without hovering) in the info icon tooltip.
In certain cases tickInterval mistakenly could end up being negative which made getTickValues() run into a call stack size exception. This PR fixes it by a) adding a check to getTickValues() that interval must not be 0 or smaller and b) changing the way the tickInterval is determined in the Anomaly Explorer Charts.
In order to support esjs apiVersion 6.5 we need to upgrade to the newly released version of elasticsearch-js. Bumping makelogs allowed us to keep only one version of the elasticsearch module installed.
* Revert "Reporting cookies (#24177)"
This reverts commit 9f4ec18000.
* Take 2
* Adding comment
* Better escaping and encoding for use in eval
* Checking for an empty string also
* Fixing session test
Instead of immediately throwing an error if a watch Action is invalid (an email for example), there is now an `option` object that we can pass to the `fromUpstreamJson()` method and receive back any error that might exist in a Watch.
The Watch has a new "watchErrors" property to display configuration error in the UI.
fixes#20305fixes#20970
* Fixes rare cases where KibanaLink will be loaded outside of React context and requires no redux connect dependency
* Fixes tests for updated Kibana link component
* Removes obsolete snapshot
* Updates waterfall item design for timeline rows
* Adjusts span and tx flyouts and updates tooltips to EUI
* Heading size fixes and clean up
* Updates tooltip snapshots
* Review tweaks and snapshot updates
* Revert experiment :)
Co-Authored-By: jasonrhodes <jason.matthew.rhodes@gmail.com>
* Fixes bug with v1 waterfall state
* Fixes bug with timeline bar height
* Updates snapshot tests
* Updated test so it doesn't mount and rely on EUI makeId() which is non-deterministic per test run
Replaces https://github.com/elastic/kibana/pull/23301
Closes https://github.com/elastic/kibana/issues/23080
---
This is a minimal threading implementation for Canvas. There's still a lot to be done to make this concept great, but this is a start.
What it does:
- Creates a server side abstraction on top of the interpreter
- Determines where to send the expression by checking the first function to be run
- Loads common functions in a separate worker thread on the server.
- Routes to a single forked worker (thread), the main thread (server), or the browser (browser), in that order
- Defers back to the router when a function isn't found. Fails if the function isn't found in any of the above 3 environments
- Times out the worker if it takes too long, and respawns it as needed.
- Simplifies the error dialog to remove the stack.
What is does not.:
- Round robin a pool of workers
- Queue. If one expression in the threaded env fails then anything sent to it in the meantime will fail. The upstream environment handles managing timeouts. I think this would only make sense todo with a pool.
- Client side. This doesn't implement web workers, but we could use roughly the same architecture.
- Implement a specific, pluggable `worker` environment on the server. Right now it's just common functions, so plugin authors will always end up in a thread if they put their function in the common directory.
What I don't like:
- The socketProvider code. This was reused across the server & browser, but now that it's only used in the browser there's no good reason for the abstraction
- The serialize/deserialize stuff feels messy. Do we really need serialization?
* Replace defaultValue with value
Added default value for size in text_style_picker
Made page_config select compressed
Added default values for props in appearance_form
Switched select to superselect in border_form
Refactored datacolumn
refactored simple_math_function
Fixed page_config
* Added an euispacer to border form
Enabled:
- View/Manage/Create rollup jobs
Disabled:
- Create a rollup index pattern
- Create rollup visualizations
- Add rollup visualizations to dashboards
- View raw rollup documents in Discover
* adds upload file and functionbeat to home
* removes functionbeat, adds ml file upload href
* remove functionbeat callout, add ml file url
* fix tests for basepath
* less caveman sounding
* update code editor snapshot
* make link conditional, copy changes
* update ml link
* move mlEnabled to ml plugin
* copy edits
* [APM] Add contextual docs links for PropertiesTable with no data #22755
* [APM] tweak style of table info header according to PR feedback #22755
* [APM] fix StickeyProperties style regression in ErrorGroupDetails
* [APM] update the layout of the StickeyProperties in ErrorDetails
* Add handles graph
* Add limits in the UI
* Remove debug
* Update api tests
* Fix tests
* Fix snapshots
* Skip this test for now
* Fix this test and re-enable it
* Adds beta messages to traces overview and timeline
* Left over formatting fix
* Fixes bug with inaccurate types for transaction.context.system
* Updates TraceLink to be called TransactionLink more accurately
* Updated learn more about DT link
* Snapshot update for number format change
* Updates to asDecimal to preserve decimal place significance in service list
## Summary
Closes https://github.com/elastic/kibana/issues/23303 ~(@cqliu1 can you confirm this too?)~ confirmed
Fixes the way we capture the request info when configuring the socket and providing it to plugins via `callWithRequest`. Instead of exposing a route that returns the info, simply use the request object that comes back from `server.inject`.
Also adds a check in the `elasticsearchClient` handler exposed to plugins to ensure the session is still valid because using `callWithRequest`.
*Note:* the actual error message is a bit different, but this is how the failure is exposed to the user
* Canvas saved objects for sample data
* fix line break in MACHINE element
* store canvas saved objects in json files instead of js files to avoid build problems
* remove logging statement
* set canvas-workpad timestamps to current time so they are displayed at top of list when sorted by date
* Rendering the space selector in either the header or the globalnav
* Adding link title
* Doing it the React way
* Updating snapshots
* Adding withTitle prop
* Adds traces overview with mock data (#22628)
* Updates service overview snapshots
* Adds tests for ManagedTable and ImpactBar
* Refactored transaction overview to use new managed table component
* Removed jsconfig file in apm
* [APM] Distributed tracing - Trace details (waterfall) (#22763)
* [APM] Add typescript to waterfall (#23635)
* [APM] Migrate get_trace and constants to Typescript (#23634)
* [APM] Add types for setup_request (#23762)
* [APM] Adds trace overview queries and some refactoring (#23605)
* ImpactBar component to align EuiProgress usage for impact bars
* Sharing some logic between transaction and trace queries
* Typescript support
* Quick fix ‘banana’
* [APM] Ensure backwards compatibility for v1 and v2 (#23636)
* Make interfaces versioned
* Rename eventType to docType
* Fixes trace links on traces overview (#24089)
* [APM] use react-redux-request (#24117)
* Updated yarn lockfile for new yarn version
* Updated dependency issues for react-router-dom types
* [APM] Display transaction info on span flyout (#24189)
* [APM] Display transaction info on span flyout
* Brings in real location and url param data for transaction flyout
* Converts flyout to TS
* Adds query param state for flyouts with ts support
* Updates styles and uses EuiTabs for transaction flyout
* [APM] Transaction flyout
* [APM] Minor docs cleanup (#24325)
* [APM] Minor docs cleanup
* [APM] Fix issues with v1 spans (#24332)
* [APM] Add agent marks (#24361)
* [APM] Typescript migration for the transaction endpoints (#24397)
* [APM] DT transaction sample header (#24294)
Transaction sample header completed
* Fixes link target for traces overview to include trans/trace ids as query params
* Converts Transaction index file to TS
* Adds trace link to sample section
* Refactors the trace link and applies it to two usages
* Implements transaction sample action context menu
* Calculates and implements duration percentage
* Re-typed how transaction groups work
* Fixes transaction flyout links and context menu
* Removes unnecessary ms multiplication
* Removes unused commented code
* Finalizes infra links
* Fixes some type shenanigans
* [ML] File datavisualizer initial commit (#22828)
* [ML] File datavisualizer initial commit
* removing mocked data and adding initial stats
* adding card styling to fields
* Revert "". accidentally added with no commit message
This reverts commit d762d20b706e6a770e631f863b9e7d8879bb7ee6.
* adding date type to timestamp field
* renaming FileStats to FieldsStats
* code clean up
* changes based on review
* changes to error handling
* [ML] Adding file datavisualizer overrides (#23194)
* [ML] Adding file datavisualizer overrides
* improvements to overrides
* removing comment
* small refactor
* removing accidentally added file
* updates based on review
* fixing broken test
* adding missing grok pattern override
* fixing test
* [ML] Refactoring override option lists (#23424)
* [ML] Refactoring override option lists
* moving lists out of class
* updating test snapshot
* [ML] Fixing field editing (#23500)
* [ML] Changes to timestamp formats (#23498)
* [ML] Changes to timestamp formats
* updating test snapshot
* [ML] Allow Datavisualizer use on basic license (#23748)
* [ML] Allow ML use on basic license
* removing timeout change
* adding permission checks
* updating tests
* removing unnecessary checks
* [ML] Adds new page for choosing file or index based data visualizer (#23763)
* [ML] Adding license check to datavisualizer landing page (#23809)
* [ML] Adding license check to datavisualizer landing page
* removing comments
* updating redirect to landing page
* [ML] Adding ability to upload data to elasticsearch from datavisualizer (#24042)
* [ML] Initial work for delimited file upload
* adding results links cards
* adding nav menu
* removing accidental debugger
* initial work for importing semi structured text
* using ingest pipeline for import
* adding json importer and better error reporting
* better progress steps
* time range added to results links
* first import only creates index and pipeline
* adding status constants
* using status constants
* adding explanation comment
* updating yarn.lock
* changes based on review
* fixing space
* fixing space again, stort it out git
* removing oversized background container causing constant scrollbar
* [ML] Adding basic license check when loading privileges (#24173)
* [ML] Adding basic license check
* missing import
* [ML] Adds an About panel to the file data visualizer landing page (#24260)
* [ML] Adds an About panel to the file data visualizer landing page
* [ML] Remove unnecessary style from file data visualizer scss
* [ML] Adding better error reporting for reading and importing data (#24269)
* [ML] Adding better error reporting for reading and importing data
* changes to endpoint errors
* displaying errors
* step logic refactor
* removing log statements
* [ML] Switch file data visualizer to use Papa Parse for CSV parsing (#24329)
* [ML] Fixes layout of Data Visualizer selector page for IE (#24387)
* [ML] Adding ability to override various settings when importing data (#24346)
* [ML] Adding ability to override various settings when importing data
* second commit with most of the outstanding code
* improving index pattern name validation
* better index pattern matching
* adding comments
* adding empty index pattern check
* changes based on review
* fixing test
* [Infra UI] Adding time ranges to detail links
- Adds timeranges to hosts, containers, and pods links
- Fixes#24228 - Typos and what not prevented urls from working
* remove argument hard coded formatting
* Cleaning up query arg generation
* Adding missing file
* removing rison hard coded string
- Fixes the job validation for the lower bound of the model memory limit. Previously the check was against zero, now it's again less than 1MB, which is the same as the backend expects.
- If the user entered model memory limit is less than half the value of the estimated model memory limit, a warning type message gets triggered. If the user entered model memory limit is more than half the value but less then the actual value of the estimated model memory limit, then the already existing info type message is shown. The unit tests have been updated to reflect that behavior.
