Commit graph

58 commits

Author SHA1 Message Date
Marco Liberati d2012c0ce3
[Lens] Make table and metric show on top Chart switcher (#96601)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-04-12 14:25:15 +02:00
Wylie Conlon fe66162ef2
[Lens] Fully unmount React when flyout closes (#95359)
* [Lens] Fully unmount React when flyout closes

* Fix bug with editor frame unmounting

* Fix type

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-03-29 12:33:05 -04:00
Marta Bondyra 755c186c28
[Lens] Multiple drop targets (#93616) 2021-03-29 14:07:39 +02:00
Marco Liberati 8f6a6e2ae5
[Lens] Improves lost indexpattern scenario in saved visualization (#91377)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-03-18 14:29:17 +01:00
Joe Reuter 33fbe74e4e
[Lens] Transpose columns (#89748) 2021-03-11 13:51:50 +01:00
Marco Liberati 8e6d4ee2f8
[Lens] Fix wrong suggestions from Datatable to other visualizations (#93920)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-03-09 15:31:17 +01:00
Marco Liberati 03cc5cc0c2
[Lens] Introduces new chart switcher (#91844)
Co-authored-by: Wylie Conlon <wylieconlon@gmail.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-03-02 11:25:35 +01:00
Marta Bondyra 65be9e0306
[Lens] Drag and drop performance improvements (#91641) 2021-02-21 10:02:04 +01:00
Marta Bondyra 351990068d
[Lens] Drag and drop accessibility messages (#91494)
* [Lens] copy dnd

* Update x-pack/plugins/lens/public/drag_drop/providers.tsx

Co-authored-by: Wylie Conlon <wylieconlon@gmail.com>

Co-authored-by: Wylie Conlon <wylieconlon@gmail.com>
2021-02-17 16:48:26 +01:00
Wylie Conlon 16d86b022f
[Lens] Support histogram mapping type for all numeric functions (#90357)
* [Lens] Support histogram mapping type

* Fix field stats and allow max/min

* Fix types

* Revert to regular sample data

* Simplify server code

* Add test for edge case

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-02-16 11:51:03 -05:00
Marco Liberati e9e7453e1d
[Lens] Improves error messages when in Dashboard (#90668)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-02-15 13:00:31 +01:00
Marta Bondyra 43e8ff8f8f
[Lens] Add new drag and drop capabilities (#89745) 2021-02-05 18:17:03 +01:00
Joe Reuter 1741cef4ae
[Lens] Hide column in table (#88680) 2021-02-04 16:22:09 +01:00
Brandon Kobel 4584a8b570
Elastic License 2.0 (#90099)
* Updating everything except the license headers themselves

* Applying ESLint rules

* Manually replacing the stragglers
2021-02-03 18:12:39 -08:00
Marta Bondyra 1b8c3c1dcc
[Lens] Refactor reorder drag and drop (#88578) 2021-02-01 11:54:16 +01:00
Marco Liberati 9733d2fdaa
[Lens] Use datagrid with resizable columns for datatable (#88069)
Co-authored-by: Joe Reuter <johannes.reuter@elastic.co>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-01-29 12:09:26 +01:00
Marco Liberati ecf512a048
[Lens] Make Lens visualization load faster on Dashboard (#88953)
* 🚀 Load indexPatternRefs only on edit mode

* :white_mark_check: Fix test with new editor init flag

* 🐛 Avoid to save to localStorage undefined indexPattern

* :white_mark_check: Adapted tests to new conditional ref loading

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-01-26 19:06:40 +01:00
Marta Bondyra 0cd8c90a7c
[Lens] (Accessibility) Added button to execute drag and drop to workspace (#85960) 2021-01-20 17:11:37 +01:00
Marco Liberati 898385c2e2
[Lens] Clean full reference operation error state when switching to other operation (#87064)
* 🐛 Make sure to check incomplete columns before saved ones

* ⚗️ Try a different approach

* 🐛 Isolate the fullRef to field transition and trigger the removal + tests

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-01-18 16:58:23 +01:00
Josh Dover 0af81310b6
Remove dynamic mapped types from UiActions (#87075)
* Remove dynamic mapped types from UiActions

* Remove import between data <-> embeddables

* remove outdated comments, export action types from discover_enhanced

* fix notice.txt

Co-authored-by: restrry <restrry@gmail.com>
2021-01-05 10:11:05 +01:00
Marco Liberati bd908c6ba3
[Lens] Integrate searchSessionId into Lens app (#86297)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2020-12-29 14:18:30 +01:00
Luke Elmers 9a3e2910a3
App Services: Remove remaining uiActions, expressions, data, embeddable circular dependencies. (#82791)
* Move applyFilter, selectRange, valueClick triggers to data/embeddables.

* Update imports.

* Remove embeddable references to non-existent data plugin dependency.

* remove data mocks from embeddable

* Remove query, filters, timeRange from EmbeddableInput and move to apps.

* Remove data plugin imports from embeddable test samples.

* Remove circular dependencies caused by expressions renderer handlers.

* Update circular deps allowList.

* Remove data dependency on embeddable.

* Revert accidental data plugin change.

* Fix new circular deps issues.

* Update generated docs.

* Fix type errors in vis_type_xy

* Fix inspector data table.
2020-12-18 18:34:07 -07:00
Marco Liberati 62623cdab9
[Lens] New sorting feature for the datatable visualization (#84435)
Co-authored-by: Wylie Conlon <wylieconlon@gmail.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2020-12-15 12:37:59 +01:00
Vadim Dalecky b01a327076
Row trigger 2 (#83167)
* feat: 🎸 add ROW_CLICK_TRIGGER

* feat: 🎸 wire row click event to UI Actions trigger in Lens

* feat: 🎸 add row click trigger to url drilldown

* feat: 🎸 add datatable to row click context

* feat: 🎸 pass in row index in row click trigger context

* feat: 🎸 add columns to row click trigger context

* feat: 🎸 fill values and keys event scope array

* feat: 🎸 generate correct row scope variables

* fix: 🐛 report triggers from lens embeddable

* feat: 🎸 add sample preview for row click trigger

* feat: 🎸 remove url drilldown preview box

* chore: 🤖 remove mock variable generation functions

* feat: 🎸 generate context and global variable lists

* feat: 🎸 preview event variable list

* feat: 🎸 show empty url error on blur

* feat: 🎸 add ability to always show popup for executed actions

* refactor: 💡 rename multiple action execution method

* fix: 🐛 don't add separator befor group on no main items

* feat: 🎸 wire in uiActions service into datatable renderer

* feat: 🎸 check each row if it has compatible row click actions

* feat: 🎸 allow passing data to expression renderer

* feat: 🎸 add isEmbeddable helper

* feat: 🎸 pass embeddable to lens table renderer

* feat: 🎸 hide lens table row actions which are empty

* feat: 🎸 re-render lens embeddable when dynamic actions chagne

* feat: 🎸 hide actions column if there are no row actions

* feat: 🎸 re-render lens embeddable on view mode chagne

* fix: 🐛 fix TypeScript errors

* chore: 🤖 fix TypeScript errors

* docs: ✏️ update auto-generated docs

* feat: 🎸 add hasCompatibleActions to expression layer

* feat: 🎸 remove "data" from expression renderer handlers

* fix: 🐛 fix TypeScript errors

* test: 💍 fix Jest tests

* docs: ✏️ update autogenerated docs

* fix: 🐛 wrap event payload into data

* test: 💍 add "alwaysShowPopup" test

* chore: 🤖 add comment requested in review

https://github.com/elastic/kibana/pull/83167#discussion_r537340216

* test: 💍 add hasCompatibleActions test

* test: 💍 add datatable renderer test

* test: 💍 add Lens embeddable input change tests

* test: 💍 add embeddable row click test

* fix: 🐛 add url validation

* test: 💍 add url drilldown tests

* docs: ✏️ remove url drilldown preview from docs

* docs: ✏️ remove preview from url templating

* docs: ✏️ add row click description

* chore: 🤖 move 36.5 KB bundle balance to url_drilldown

* test: 💍 simplify test case

* style: 💄 change types places

* refactor: 💡 clean up panel variable generation

* test: 💍 add getPanelVariables() tests

* fix: 🐛 generate runtime variables correctly

* fix: 🐛 improve getVariableList() and add tests for it

* feat: 🎸 add translation, improve types
2020-12-14 13:28:23 +01:00
Luke Elmers 3b5ed46c9d
[data.search] Clean up arguments to esaggs. (#84973) 2020-12-10 07:40:50 -07:00
Wylie Conlon 0fdf76e779
[Lens] Don't assign dimension until it becomes valid (#84972) 2020-12-08 11:29:07 +01:00
Wylie Conlon f176e8b7fd
[Lens] Remove extra render when closing flyout with valid column (#84951)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2020-12-04 11:00:10 -05:00
Marta Bondyra 6900ce2b96
[Lens] Provide single-value functions to show the "First" or "Last" value of some field (#83437) 2020-12-02 19:55:58 +01:00
Wylie Conlon c73de26773
[Lens] Refactor function selection invalid state (#84599)
* [Lens] Refactor function selection invalid state

* Fix types per review comment
2020-12-02 11:16:59 -05:00
Marta Bondyra f23d2e6ea1
[Lens] (Accessibility) add aria-label to chart type icon (#84493) 2020-11-30 15:45:26 +01:00
Marco Liberati 423888c14e
[Lens] CSV Export for Lens (#83430)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2020-11-24 12:37:27 +01:00
Joe Reuter 95e44f25a6
[Lens] Color in dimension trigger (#76871) 2020-11-17 10:19:13 +01:00
Wylie Conlon ccb0b35452
[Lens] Use entire layers, not specific columns (#82550)
* [Lens] Use entire layers, not specific columns

* Fix types

* Move all of state_helpers over

* Fix tests

* Fix crash and add tests to prevent future issues

* Prevent users from dropping duplicate fields

* Respond to review feedback

* Fix review feedback

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2020-11-10 13:45:46 -05:00
Marco Liberati 97e2dc853b
[Lens] Extend Datasource props validation with VisualizationGroups (#82607)
*  First pass with visualization validation + error messages

* 🔥 Remove indexpattern error handling for now

* 🏷️ Fix type issues

*  Add getErrorMessage test for data table

*  Add tests for pie and metric error messages

* 🌐 Fix i18n checks issues

* 🐛 Fix last issue

*  Add more tests for the XY visualization validation code

* 👌 Included all feedback from first review

* ✏️ Off by one message

* 🌐 Fix i18n duplicate id

* 🌐 Fix last i18n issue

* 🐛 Fixed a hook reflow issue

* ♻️+ Reworked validation flow + tests

* 🏷️ Fix type issue

* 🐛 Improved XY corner cases validation logic

* 🐛 Fix empty datatable scenario

*  +  Improved error messages for invalid datasources + tests

* 🌐 Add missing i18n translation

* 🏷️ Fix type issues

* 🌐 Fix i18n issues

*  Filter out suggestions which fail to build

* 🚚 Migrate datatable validation logic to the building phase, handling it as building state

* 🏷️ Fix type issue

* ✏️ Add comment for future enhancements

* ✏️ Updated comment

* :world_with_meridians: Refactor axis labels

* 🌐 Reworked few validation messages

* 🐛 Fix break down validation + percentage charts

*  Align tests with new validation logic

* ♻️ Fix suggestion panel validation to match main panel

* 🌐 Fix i18n issues

* 🔧 Fix some refs for validation checks in suggestions

* 🐛 Fix missing key prop in multiple errors scenario

* 🐛 Fix swtich issue from XY to partition

* 🌐 Fix i18n messages and aligned tests

* 🐛 Fix suggestions switching bug

* :refactor: Add more validation + refactored validation logic in a single place

* ✏️ Add note about lint hooks disable rule

* 🚨 Fix linting issue

* 🏗️ Add infra API for datasource advanced validation

*  Align tests with new API

*  Fix type issues in tests

* 👌 Early exists added

*  Add layers groups to the API

*  Fix some broken test after the validation change

* 👌 Move to disctionary shape

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2020-11-09 15:22:21 +01:00
Joe Reuter 651345b18b
[Lens] Expose active data in some places (#79851) 2020-11-06 17:05:34 +01:00
Marco Liberati 53ea09078f
[Lens] Visualization validation and better error messages (#81439)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2020-11-04 18:28:00 +01:00
Joe Reuter fe3b0538ff
[Lens] Categorical color palettes (#75309) 2020-11-04 11:27:52 +01:00
Marta Bondyra 6689167b64
[Lens] Drag within dimension group to reorder (#80547) 2020-11-03 21:18:44 +01:00
Peter Pisljar c90dabaeba
removing kibana_datatable in favor of datatable (#80548) 2020-10-16 18:46:51 +02:00
spalger 6eeab00944 Revert "removing kibana_datatable in favor of datatable` (#75184)"
This reverts commit 255b865be8.
2020-10-13 08:53:14 -07:00
Peter Pisljar 255b865be8
removing kibana_datatable in favor of datatable` (#75184) 2020-10-13 17:00:38 +02:00
Joe Reuter 11886bf51c
[Lens] Add search to chart switcher (#77631) 2020-10-06 17:17:41 +02:00
Stratoula Kalafateli 08a4586b14
[Lens] Navigate from discover to lens (#77873)
* Create lens action and unregister the visualize one

* remove console

* Implement Discover to Lens, wip, missing tests

* Add unit tests

* fix embed lens to empty dashboard functional tests

* fix suggestions on save

* Fix bug on save button, query and filters should be transferred from discover

* Add functional test for the navigation from Discover to Lens

* PR update after code review

* unregister visualize action only if the action exists

* Change the test to not be flaky

* Move suggestions to editor frame and hide the emptyWorkspace for visualize field

* Update ui actions docs

* Add a retry to remove test flakiness

* Fix bug of infinite loader when removing the y axis dimension

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2020-10-06 11:15:41 +03:00
Marco Liberati 198c5d9988
[Lens] Fix embeddable title and description for reporting and dashboard tooltip (#78767)
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-10-01 18:02:37 +02:00
Joe Reuter dbef60d3f1
[Lens] Reduce initial bundle size (#78142) 2020-09-29 19:00:29 +02:00
Joe Reuter 63f0cc0519
[Lens] Stack as percentage (#70703) 2020-09-15 11:24:02 +02:00
Caroline Horn 5a2f7ae897
[Lens] Move configuration popover to flyout (#76046)
* Moving to a Flyout implementation
* Fix up inner layout of flyout
* Fix up form rows
2020-09-14 18:23:13 -04:00
Wylie Conlon 9ca8551cda
[Lens] Drag dimension to replace (#75895)
* [Lens] Drag to replace

* Add jest tests for drag and drop

* Fix bug in dragging to empty

* Hide dragged dimension when drag starts

* Make table metrics required

* Update class names

* Implement styles on non-droppable items

* Replace drag and drop image in docs

* Remove extra specificity

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-09-04 10:11:41 -04:00
Wylie Conlon 8364d8d67a
[Lens] Decouple visualizations from specific operations (#75703)
* [Lens] Decouple visualizations from specific operations

* Remove unused mock
2020-08-26 18:27:40 -04:00
Joe Reuter 86f73cb0c2
[Lens] Register saved object references (#74523) 2020-08-21 18:08:25 +02:00