Commit graph

42108 commits

Author SHA1 Message Date
renovate[bot] ad25fb3f12
Update dependency @elastic/charts to v28.2.0 (master) (#97005)
* Update dependency @elastic/charts to v28.2.0

Co-authored-by: Renovate Bot <bot@renovateapp.com>
Co-authored-by: nickofthyme <nick.ryan.partridge@gmail.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Marco Vettorello <vettorello.marco@gmail.com>
2021-04-15 22:34:01 +02:00
Scotty Bollinger 3a32817a7a
[Workplace Search] Add ErrorReasons fix from ent-search (#97299)
Ports https://github.com/elastic/ent-search/pull/3393 to Kibana
2021-04-15 16:23:59 -04:00
Nathan Reese fdb7be3d11
Remove field type filtering from IndexPatternSelect (#97035)
* Remove field type filtering from IndexPatternSelect

* remove unused import

* api doc updates

* update jest snapshots

* another fix for jest test

* review feedback

* tslint

* update jest snapshot for changes

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-04-15 12:26:25 -06:00
ymao1 b09e418e51
[Actions][Telemetry] Counting number of alert history connectors in use (#97063)
* Counting number of alert history connectors in use

* Telemetry for preconfigured alert history config enabled

* Updating telemetry mappings

* Updating tests

* Adding descriptions to new telemetry fields

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-04-15 14:13:19 -04:00
Alejandro Fernández Haro b7067dea16
[Usage Collection/Cloud Provider] Fix isReady bug (#97279) 2021-04-15 14:04:52 -04:00
Matthias Wilhelm f4e7941e7d
[Discover] Unskip doc navigation functional test (#96948) 2021-04-15 19:58:19 +02:00
Ashokaditya d47ee56e93
[Security Solution] Breaks very long hostnames so they are readable (#97253)
* Breaks very long hostnames so they are readable

fixes elastic/kibana/issues/96282

* use utility class instead

review change
2021-04-15 19:16:56 +02:00
Justin Ibarra 069b04bed6
[Detection Rules] Remove empty values in threshold.field array for threshold rules (#97111)
## Issues
related to https://github.com/elastic/detection-rules/issues/1097
related to https://github.com/elastic/detection-rules/pull/1099

## Summary

`threshold.field` is an array that currently requires at least one value. An empty string `""` was required if no value was supplied. Instead, this needs to be replaced with no string and just an empty array.
### Checklist

Delete any items that are not applicable to this PR.

- [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md)
2021-04-15 11:08:45 -06:00
Marco Liberati 83831ce990
[Graph] Fix fields clearing within the Editor (#96767)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-04-15 18:56:33 +02:00
Melissa Alvarez 53e2d5d725
[ML] Data Frame Analytics: Ensure creation and results views display nested fields correctly (#96905)
* create analytics field service

* remove unnecessary field filter. update types

* create common base class for newJobCapabilites classes for AD and DFA

* fix column schema for histogram

* update endpoint to be consistent with AD job caps

* add unit test for removeNestedFieldChildren helper function

* removes obsolete const
2021-04-15 12:52:09 -04:00
Phillip Burch e11ac98b3a
[Metrics UI] Add anomalies tab to enhanced node details (#96967)
* Adapt the anomalies table to work in overlay

* Wire up the onClose function

* Make "show in inventory" filter waffle map

* Remove unused variable

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-04-15 11:37:47 -05:00
Dario Gieselaar 5bb9eecd26
[RAC] Populate Observability alerts table with data from alerts indices (#96692)
* Set up Observability rule APIs

* Populate alerts table with data from API

* Move field map types/utils to common

* Format reason/link in alert type

* Format reason/link in alert type

* Fix issues with tsconfigs

* Storybook cleanup for example alerts

* Use `MemoryRouter` in the stories and `useHistory` in the component to get the history
* Replace examples with ones from "real" data
* Use `() => {}` instead of `jest.fn()` in mock registry data

* Store/display evaluations, add active/recovered badge

* Some more story fixes

* Decode rule data with type from owning registry

* Use transaction type/environment in link to app

* Fix type issues

* Fix API tests

* Undo changes in task_runner.ts

* Remove Mutable<> wrappers for field map

* Remove logger.debug calls in alerting es client

* Add API test for recovery of alerts

* Revert changes to src/core/server/http/router

* Use type imports where possible

* Update limits

* Set limit to 100kb

Co-authored-by: Nathan L Smith <smith@nlsmith.com>
2021-04-15 18:25:50 +02:00
Jean-Louis Leysens 5ecf09843e
[ILM] Support max primary shard size rollover field (#96545)
* added max primary shard size rollover field

* large-ish refactor of the hot phase component to move the rollover fields to their own components

* added comment

* address i18n issue

* - fixed jest tests
- fixed behaviour to show missing value for rollover
- updated jest snapshots

* added field deprecation component

* added test for whether deprecation icon is visible

* remove unused import, remove type generic from FormSchema

* fixed getting "getFields" from incorrect object

* wip!!!

* - removed FieldDeprecationWarning component and associated tests
- implmented always showing the warning icon and updated the color
- cleaned up test helpers

* - more tightly grouped the numeric inputs with their unit selects
  by reducing the gutter size before defazios feedback
- fixed alignment issue between numeric rollover inputs and their
  unit select field by adding flex-end styling to the groups

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-04-15 18:02:18 +02:00
Joe Reuter 6c07eb2382
fix test leak (#97082) 2021-04-15 17:57:44 +02:00
Joe Portner e675429b98
Harden saved object deserialization (#94842) 2021-04-15 11:57:24 -04:00
Stacey Gammon 503cfcf8c9
Track API stats as part of ci (#95733)
* Track stats and add extra output information

* Update api docs output

* Clean up id names

* update api docs

* Consolidate error messages and fix a bug

* Update docs

* Update get_declaration_nodes_for_plugin.ts

* Fix bug with removeBrokenLinks not being recursive

* Update docs

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-04-15 11:36:10 -04:00
Frank Hassanabad ede8ed3f95
[Security Solutions ] Fixes failed to query DNS data - too_many_buckets_exception (#97069)
## Summary

Fixes a bug where on the DNS tab of networks you can get a `too_many_buckets_exception`. Worked through the query with @angorayc and together I think we figured out that the query could be re-written with aggregations in a way to get the same results without having to query a large amount of terms which causes the buckets exception.

Added a e2e test and one way of being able to call bsearch in the e2e when it returns the search is still in progress so we don't have the large query test cause flakiness 🤞 .

### Checklist

- [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
2021-04-15 09:22:56 -06:00
Kerry Gallagher 9b456ac0fe
[Logs UI] Provide support for Kibana Index Patterns in the logs source configuration (#96454)
* Provide support for Kibana Index Patterns in the logs source configuration

Co-authored-by: Felix Stürmer <weltenwort@users.noreply.github.com>
2021-04-15 16:15:11 +01:00
Alejandro Fernández Haro c710cb9bbd
[DocLinks] Update outdated docs (#97217) 2021-04-15 16:01:36 +01:00
Robert Oskamp d20ecaf939
[ML] Functional tests - fix transform _nodes API test for cloud (#97240)
This PR fixes the transform _node API tests for cloud, where more than one transform node could be available.
2021-04-15 16:32:27 +02:00
Chris Roberson 9a76d34b04
[Alerting] Show more user friendly ES error message when executor fails (#96254)
* WIP for ES error parser

* Fix tests

* Ensure the error shows up in the UI too

* wip

* Handle multiple types here

* Fix tests

* PR feedback

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-04-15 10:15:40 -04:00
Andrew Pease 8f2f65d30c
[Timeline] Add Indicator Match Timeline Template (#95840)
* added threat-match timeline template

* added indicator match timeline template

* updated name to threat match

* updated name to threat match

* changed file name to threat.json

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-04-15 09:09:14 -05:00
Thomas Watson 005745e649
Log if no plugins are installed when listing plugins in cli (#97235) 2021-04-15 09:58:58 -04:00
Thomas Watson 41bf9e8427
Remove blank line at the end of cli plugin list (#97234) 2021-04-15 09:39:37 -04:00
Thomas Neirynck e38a3dabf7
[Maps] Add cache control to mvt endpoints (#94861) 2021-04-15 09:07:34 -04:00
Shahzad cbf24cd640
[Lens] Open lens in new tab via state transfer (#96723) 2021-04-15 14:49:55 +02:00
Matthew Kime fa959c9d23
Index pattern management - fix runtime fields icon (#95117)
* account for fields from saved object
* use correct icon for runtime fields
2021-04-15 07:47:57 -05:00
Dominique Clarke 1bd951cfa9
[Uptime] - Synthetics add transfer size, resource size, and status to waterfall flyout (#97042) 2021-04-15 08:42:07 -04:00
Sandra Gonzales 18bc53880f
[Metrics UI] handle ES query errors in snapshot endpoint, improve UI error messaging (#96871)
* handle es errors in snapshot api, show error message as toast danger in UI

* use err.message if no err.body.message

* use updated handleEsError
2021-04-15 08:34:19 -04:00
Marco Liberati dd142b92ae
[Lens] Close dimension panel on escape key (#96783)
*  Close panel on escape key

* 👌 Stabilize callback ref

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-04-15 14:29:40 +02:00
Robert Oskamp d5a4a708f9
[ML] Functional tests - stabilize swim lane pagination test (#97214)
This PR stabilizes the swim lane pagination test by adding a retry to the assertion.
2021-04-15 14:15:10 +02:00
Dmitry Tomashevich 198be4cb8c
[TSVB] fix not populating fields list if "Auto apply" is off (#96298)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-04-15 15:11:16 +03:00
Felix Stürmer 1a7095365a
[Logs UI] Allow for missing properties on ES shard failure responses (#96768)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-04-15 13:28:26 +02:00
Maja Grubic 6501b393a2
[Discover] Runtime Fields Editor integration: Add + Delete operation (#96762)
* [Discover] Updating a functional test

* [Discover] Support for edit operation

* Fix unit tests

* Fix typescript

* Fixing failing functional test

* Fixing wrongly commented line

* Uncomment accidentally commented line

* Reintroducing accidnetally removed unit test

* Trigger data refetch onSave

* Remove refreshAppState variable

* Bundling observers together

* Clean state before refetch

* Update formatting in data grid

* [Discover] Runtime fields editor : add operation

* [Discover] Updating a functional test

* Adding a functional test

* Fixing package.json

* Reset fieldCount after data fetch

* [Discover] Updating a functional test

* Don't allow editing of unmapped fields

* Add functionality

* Fix issues with mobile display

* Allow editing if it's a runtime field

* Add a functional test

* [Discover] Updating a functional test

* Add functional test

* Remove unnecessary debugger statement

* Add more tests

* Add delete functionality

* Include runtimeFields in doc search

* Add another functional test

* [Discover] Updating a functional test

* Fix failing i18n check

* Fix package.json

* Addressing PR comments

* Addressing design input

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-04-15 12:03:57 +01:00
Alexey Antonov 5686ec9b24
[TSVB] Fix error handling issue for KQL queries (#97088)
* [TSVB] Fix error handling issue for KQL queries

* remove KQLSyntaxError

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-04-15 06:31:48 -04:00
Shahzad c68eab6298
[Exploratory view] Improve/Polish components usage (#96782) 2021-04-15 11:55:57 +02:00
Maja Grubic 2fb8b92ec9
[Discover] Fix redirect from Dashboard (#97098)
* [Discover] Fix redirect from Dashboard

* Updating a unit test
2021-04-15 07:59:25 +01:00
István Zoltán Szabó 579ddd0b2e
[ML] Changes custom rule terminology on the ML UI (#96999)
Co-authored-by: Lisa Cawley <lcawley@elastic.co>
2021-04-15 07:53:34 +02:00
Stratoula Kalafateli c6043f0452
[XY Axis] Fixes problem with series being displayed twice (#96773)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-04-15 08:53:08 +03:00
István Zoltán Szabó b24b87a6f3
[ML] Changes text in mean recall tooltip. (#96990) 2021-04-15 07:52:38 +02:00
Nicolas Chaulet b96172e27c
[Fleet] Fleet server onboarding UI (#96867) 2021-04-15 01:22:32 -04:00
Candace Park 1cd11d4deb
[Security Solution][Endpoint][Admin] Fix policy details test warning (#97182) 2021-04-15 00:10:12 -04:00
Tiago Costa 2bb97f234a
chore(NA): moving @kbn/utility-types into bazel (#97151)
* chore(NA): moving @kbn/utility-types into bazel

* chore(NA): solve ts config errors
2021-04-15 02:33:38 +01:00
spalger 82b7082459 skip flaky suite (#97085) 2021-04-14 16:41:05 -07:00
John Schulz de4bcdb9d9
[Fleet] Rename force to revoke agent unenroll APIs (#97041)
## Summary

 - fcbc9d9 Rename `force` param to `revoke` for `/agents/{agent_id}/unenroll` & `/agents/bulk_unenroll`
 - 03b9b90 Add new `force` param

See https://github.com/elastic/kibana/issues/96873 for background

<table>
  <thead>
    <tr>
      <td rowspan="2"></td><td colspan="2">Unenroll Agent</td><td rowspan="2">Revoke API Keys</td>
    </tr>
    <tr>
      <td>Regular</td><td>Hosted</td></td>
    </tr>
  </thead>
  <tr><td colspan="4"><strong>Rename <code>force</code> to <code>revoke</code></strong></td></tr>
  <tr><td>Current <code>force=false|undefined</code></td><td></td><td></td><td></td></tr>
  <tr><td>Proposed <code>revoke=false|undefined</code></td><td></td><td></td><td></td></tr>
  <tr><td>Current <code>force=true</code></td><td></td><td></td><td></td></tr>
  <tr><td>Proposed <code>revoke=true</code></td><td></td><td></td><td></td></tr>
  <tr><td colspan="4"><strong>Change <code>force</code> param </strong></td></tr>
  <tr><td>Proposed <code>force=false|undefined</code></td><td></td><td></td><td></td></tr>
  <tr><td>Proposed <code>force=true</code></td><td></td><td></td><td></td></tr>
  <tr><td>Proposed <code>force=true</code> & <code>revoke=true</code></td><td></td><td></td><td></td></tr>
</table>

### Checklist

- [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios

### Changes required for consumers
Any call to `/agents/{agent_id}/unenroll` & `/agents/bulk_unenroll` which passes the `force` param should change to `revoke` to maintain the current behavior.
2021-04-14 19:27:06 -04:00
Bhavya RM f92ce3074b
Test user for maps test verifying sample data maps (#96109)
test user for sample maps test & removing geoall_writer_role from add layer
2021-04-14 19:22:18 -04:00
Lee Drengenberg 3270c64271
add images and content for functional UI test debugging tutorial (#96790) 2021-04-14 18:05:13 -05:00
Constance 2a281c99c6
[App Search] Refactor out a shared MultiInputRows component (#96881)
* Add new reusable MultiInputRows component

- basically the CurationQuery component, but with a generic values var & allows passing in custom text for every string

* Update CurationQueries with MultiInputRows

* Update MultiInputRows to support on change behavior

- for upcoming Relevance Tuning usage

* Update Relevance Tuning value boost form to use new component

- relevance_tuning_form.test.tsx fix: was getting test errors with mount(), so I switched to shallow()

* Change submitOnChange to onChange fn

- more flexible - allows for either an onSubmit or onChange, or even potentially both

* Convert MultiInputRowsLogic to keyed Kea logic

- so that we can have multiple instances on the same page - primarily the value boosts use case

* Update LogicMounter helper & tests to handle keyed logic w/ props

* [Misc] LogicMounter helper - fix typing, perf

- Use Kea's types instead of trying to rewrite my own LogicFile
- Add an early return for tests that pass `{}` to values as well for performance

* PR feedback: Change values prop to initialValues

+ bonus - add a fallback for initially empty components
+ add a test to check that the logic was mounted correctly

* PR feedback: Remove useRef/on mount onChange catch for now

- We don't currently need the extra catch for any live components, and it's confusing
2021-04-14 18:11:25 -04:00
Rashmi Kulkarni 3ba640403f
unskip accessibility - dashboard_edit_panel tests (#96710)
* unskip

* added render complete

* added render complete in couple other places

* minor corrections

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-04-14 15:05:12 -07:00
Zacqary Adam Xeper deaa7794d5
[Fleet] Add ability to specify which integration variables should be configurable (#97163) 2021-04-14 17:00:18 -05:00