Commit graph

27678 commits

Author SHA1 Message Date
Gidi Meir Morris
6ee9ce8653
[task-manager] Improves messaging on errors due to inline scripts being disabled (#49860) (#49951)
This PR detects when claiming tasks fails due to inline scripts being disabled in Elasticsearch and improves the message reported in the Kibana log.
2019-11-01 21:48:39 +00:00
Chris Davies
4f8aa1528a
Fix Lens auto date bug (#49967) (#49974) 2019-11-01 17:16:07 -04:00
Thomas Neirynck
6c12c761d5
[Maps] Ensure the query-object is populated (#49917) (#49935) 2019-11-01 17:11:52 -04:00
Mike Côté
baad55f464
Return referenced by count with each action on the find API (#49104) (#49970)
* Initial work

* .kibana index configurable, NP ready implementation

* Fix broken jest tests

* Fix broken functional tests

* Add functional test

* Cleanup actions_client.test.ts
2019-11-01 17:03:47 -04:00
Justin Kambic
5de00ef779
Add assertCloseTo calls to prevent off-by-one errors in unit tests for backend adapter. (#49928) (#49948) 2019-11-01 16:39:19 -04:00
Mike Côté
dbc278599a
Add ability to name alerts (#49035) (#49960)
* Ability to name alerts

* Fix RawAlert TypeScript interface

* Update docs
2019-11-01 15:13:42 -04:00
Melissa Alvarez
cd68b00505
[ML] DF Analytics Regression results: Ensure error handling and table sort works correctly (#49929) (#49954)
* add error handling for regression jobConfig fetch

* fix sorting change causing blank table by removing table render timeout

* Add label to table for number of docs obtained

* parameterize searchSize in documents fetched text
2019-11-01 13:39:35 -04:00
Aaron Caldwell
6cf48bc4b6
[File upload] Switch to index pattern service shim (#49893) (#49943)
* Switch to index pattern service shim

* Fix test breaking due to unrelated import in same file

* Move mock and require out of before call to top of file since they're not directly test-related

* Some minor cleanup

* One more thing...
2019-11-01 09:13:21 -06:00
Maryia Lapata
69db61374d
[7.x] [Visualize] Centralize dependencies in kibana_services.ts (#49293) (#49940)
* [Visualize] Centralize dependencies in kibana_services.ts (#49293)

* Centralize dependencies for Visualize  plugin

* Centralizing dependencies in editor and embeddable

* Remove unused deps, move imports

* Fix dangerouslyGetActiveInjector

* Move loading directive to kibana_services.ts

* Fix exceptions

* Get rid of injectI18n; fix chrome method invocation

* Update unit tests

* Fix TS

* Move data and Embeddable import

* Import VISUALIZE_EMBEDDABLE_TYPE directly

* Fix deps

* Remove extra dependencies
2019-11-01 16:17:12 +03:00
Maryia Lapata
96f5e77514
Add Kibana App specific URL to the help menu (#34739) (#42580) (#49941)
* Add Dashboard help menu

* Add Discover help menu

* Add Visualize help menu
2019-11-01 14:41:31 +03:00
Jean-Louis Leysens
ed27d21db4
[7.x] [SearchProfiler] SearchProfiler to NP (#48795) (#49932)
* [SearchProfiler] SearchProfiler to NP (#48795)

* Added the following components:

- highlight details (with render test)
- searchprofiler tabs
- (wip) profile tree
- (wip) shard details

* First iteration of ProfileTree component (needs render test)

* Remove space

* ProfileTree render test

* Add profile tree test to git index

* First iteration of editor component with render test

* First iteration of nearly functional public

* Fix highlight_details_flyout render test

* Move NP directory to public and fix import issue created by directly importing FormattedMessage

* Rendering and looking more normal

* Fix type issues and fix a11y for ace editor

* Added ability to do profile requests again and render into UI (styling WiP)

* Fix props in editor test

* Added empty tree placeholder component (with test), moved styling around into individual files (wip)

* Fix path

* Lots of style updates and added util for determining visible children (+test)

* Re-add missing badge and make it slightly wider (otherwise 100.00% cuts off to 100.0...)

* Delete legacy public!

* SCSS refactor + fix for re-rendering editor

* UI and server updates after license checks

* [skip ci] Add server np_ready code

* fix i18n

* Re-enable error annotations

* Minor UX improvements (focus editor after failed request and no tabindex for textarea without active license)
Added some spaces to make code more readable

* Removed xpackMain from ServerShim
Updated use of notifications -> notifications.toasts from np core setup
Removed TODO for using core.application.register (not available for legacy apps)

* Added placeholder component for loading state and implemented useReducer

* Refactor actions

* Changes after PR feedback:
- TS for unsafe utils test fixtures
- Safer use of .selfTime (no more NaN)
- Sentence case where applicable
- Cleaned up TODOs
- Fix styling issue with percentage on badges of profile tree
- Refactor name of profile hook (now useRequestProfile)
- Fixed copy paste issue in highlight flyout `Total time` -> `Self time`
- Restyled the profile button to be fill and not take up the full horizontal space
- Removed the `Type` input from the profiler query section

* Removed .type from backend and cleanup translations

* Disable responsive UI layout for now

* Remove buggy error annotation code

* - Refactored percentage badge to own component
- Updated styles after testing on IE11
- Updated styles after testing on Safari
- Chrome and FF worked on this commit

* Update missing i18n and fix use ace ui keyboard hook

* Update useEffect dependencies array for editor component

* Use absolute path to dev tools app (to fix CI)

* Remove file extensions

* Re-add missing data-test-subj

* Remove template/index.html
2019-11-01 12:10:38 +01:00
Wylie Conlon
1c3f072d04
[Lens] Fix bug with switching from subtype to subtype (#49915) (#49930) 2019-10-31 18:48:12 -04:00
Spencer
8213aae2e3
[7.x] update elasticsearch to 16.5.0 (#49911) (#49924) 2019-10-31 15:43:53 -07:00
liza-mae
b2f42c10bd
Enable visual tests (#47861) (#49800)
* Enable visual tests

* Uncomment visual tests jobs

* More testing - use dev token and only run visual tests

* Fix dev token

* Fix token again

* Skip infra tests

* Set style of table

* Try setting discover sample size

* Fix Jenkinsfile

* Remove login_page test from config (it skipped but failing)

* Remove line

* Prep to merge, revert token and update Jenkinsfile

* Try skipping at Security level, instead of removing from config
2019-10-31 15:49:17 -06:00
John Dorlus
4dc3e7c4f9
Snapshots title ie11 misalignment (#48802) (#49912)
* Removed Flexbox around header and link elements.

* Removed unused EUI component

* Added class to include the ellipses when name is truncated.

* Fixed title in policy_details.tsx

* Fixed buttons and title on policy and repository table.

* Linting fixes.

* Removed unused references.

* Added keys to arrays of elements to resolve React errors.
2019-10-31 13:32:47 -07:00
Justin Kambic
faa854edb9
Add HOC for wrapping snapshot histogram component. (#49268) (#49788) 2019-10-31 16:08:20 -04:00
Nathan Reese
d63cfea23f
[Maps] data load event handlers (#49373) (#49899)
* [Maps] data load event handlers

* update readme featuresCount to reflect variable name

* fix exception with EMS_TMS onDataLoadEnd

* wrap featuresCount in resultMeta object so different layer types can return different results
2019-10-31 14:06:19 -06:00
Justin Kambic
889c0a79d5
[Core] Add different request lib to telemetry_analytics in place of $http (#49671) (#49887)
* Add axios to telemetry_analytics in place of .

* Remove axios in favor of fetch.
2019-10-31 16:05:45 -04:00
Søren Louv-Jansen
cb13266c14
[APM] Remove redundant, custom typescript helpers (#49884) (#49901)
Replace StringMap with Record<P, Q>
Remove unused IndexAsString
Remove custom Omit
2019-10-31 21:01:19 +01:00
Vadim Dalecky
a18a0293ba
Dashboard container (#49600) (#49897)
* feat: 🎸 create dasboard embeddable NP plugin, move panel action

* refactor: 💡 pass in getFactories() fn to "replace" action

* refactor: 💡 move dashboard container actions to NP

* refactor: 💡 remove action files from dashboard container in LP

* refactor: 💡 move dashboard grid to NP plugin

* refactor: 💡 move Embeddable SASS to the NP

* refactor: 💡 move dashboard container panel to NP

* refactor: 💡 move dashboard container viewport to NP

* refactor: 💡 move dashboard constant to constants file

* refactor: 💡 move dashboard_continaer file to NP

* refactor: 💡 move dashboard_container_factory.tsx to NP

* chore: 🤖 disable injected React components

* feat: 🎸 fill in NP plugin

* feat: 🎸 move expand panel action to NP

* feat: 🎸 move replace action panel to NP

* feat: 🎸 move dashboard_contaienr to NP

* chore: 🤖 delete LP dasboard container plugin shim

* chore: 🤖 delete LP dashboard_embeddable_container plugin

* chore: 🤖 point translations to the NP plugin

* test: 💍 re-enable dashboard container tests

* chore: 🤖 fix TypeScript type errors

* chore: 🤖 fix more TypeScript tyeps

* test: 💍 fix import in .js test

* feat: 🎸 use <SavedObjectFinder> in dashboard container

* feat: 🎸 add full screen button to dashboard container

* fix: 🐛 execute Chrome hiding only once

* chore: 🤖 put back temporary type substitutions

While moving this plugin file-by-file those types were not available

* chore: 🤖 revert back kibana_react imports

* fix: 🐛 address review comments
2019-10-31 20:52:20 +01:00
Lisa Cawley
82359197c0
[DOCS] Removes Extend your use case section (#49812) (#49914) 2019-10-31 12:48:40 -07:00
Shahzad
818fa30810
[Uptime] Issue/48845 Disable filter and Add link to location docs when no location exists (#49175) (#49902)
* disable search text if no item exists

* update snaps
2019-10-31 20:41:33 +01:00
Thomas Neirynck
c46fda74b1
[Maps] Introduce typed styles (#49803) (#49904) 2019-10-31 15:41:16 -04:00
Melissa Alvarez
0f18d39a49
[ML] DataFrame Analytics: Regression results view (#49667) (#49898)
* enable analytics table view link for regression jobs

* add results table component

* can filter for training/testing

* add search functionality to table

* move shared types to analytics types file

* anchor isTraining,predicted,actual columns to left.

* ensure search string persists in search bar input

* show jobStatus badge in results view

* add jobType, status badge to outlier exploration page

* update exploration tests
2019-10-31 15:14:47 -04:00
Thomas Neirynck
50ae400b4c
[Maps] Reuse constants when registering feature (#49862) (#49879) 2019-10-31 14:51:49 -04:00
Aaron Caldwell
47cccc640c
Add buffer to chunk size to prevent risk of oversize post requests (#48595) (#49892) 2019-10-31 12:09:45 -06:00
liza-mae
e0f822a877
Add ability to whitelist visible elements in percy (#45733) (#49880)
* add ability to whitelist visible elements in percy

* allow white and blacklisting elements in visual tests

* remove unnecessary webElement methods

* refactor snapshot options to use show and hide

* refactor add/remove and visual test helpers

* [percy] rework css rules to allow hiding inside shown elements

* [percy] adjust logic to support showing inside hiding

* attach styles to hide percy when capturing the snapshot

* refactor in order to make sure all logic is executed if snapshot fails

* remove sleeps

* add back skipFirefox tag
2019-10-31 12:00:44 -06:00
Vadim Dalecky
f5600aa809
Expressions np (#47810) (#49848)
* refactor: 💡 generalize service getters and setters in expressio

* feat: 🎸 create NP-ready plugin for expressions

* refactor: 💡 flatten expressions plugin and remove service

* chore: 🤖 re-export legacy expressions service dir for Lens

* refactor: 💡 don't import renderer registry statically

* test: 💍 mock expressions service renderers registry in Mocha

* refactor: 💡 clean-up NP expressions pugin

* refactor: 💡 move Expression fonts to NP

* refactor: 💡 register Interpreter entities explicitly

* refactor: 💡 move clog Expression function to NP

* refactor: 💡 move font function and style types to NP

* refactor: 💡 remove ui/chrome from kibana_context function

* feat: 🎸 add ability to consume start core from setup life-cycle

* refactor: 💡 move kibana_context function to NP

* feat: 🎸 improve naming and delete import of missing function

* refactor: 💡 register expression clog and font fn in NP

* chore: 🤖 set AppArch as GitHub folder owners

* refactor: 💡 move Expression "kibana" function to NP

* refactor: 💡 move range function to visualizations plugin

* feat: 🎸 move visDimensions to visualizations plugin

* chore: 🤖 delete unused files

* refactor: 💡 move expression type registration to NP

* refactor: 💡 move createHandlers() function to NP

* feat: 🎸 move Expression executor to NP

* refactor: 💡 re-implement function registry

* refactor: 💡 convert expression type to class

* fix: 🐛 correct TypeScript errors

* feat: 🎸 convert Expressions type registry to class

* feat: 🎸 convert render function registry to class

* fix: 🐛 fix TypeScript errors

* fix: 🐛 fix translations after refactor

* refactor: 💡 move Expression types to NP

* test: 💍 remove unused test

* fix: 🐛 fix Lens import after merge with master

* fix: 🐛 fix TypeScript errors

* refactor: 💡 update expression types

* test: 💍 fix renderer test
2019-10-31 18:24:56 +01:00
Kaarina Tungseth
824707eb2a
[DOCS] Canvas embeddable workpads (#45027) (#49882)
* [DOCS] New Canvas snapshots documentation

* Changes from 1-Oct meeting

* Some tweaks

* Added beta tag

* Fixes to images

* Comments from Gail and Tim

* New images

* Final changes
2019-10-31 10:58:16 -05:00
Spencer
c88cad27ca
[7.x] use a custom wrapper around chance with longer defaults… (#49866)
* use a custom wrapper around chance with longer defaults to avoid conflicts

* fix a reference to chance

* fix another reference to chance service

# Conflicts:
#	x-pack/test/saml_api_integration/apis/security/saml_login.ts
2019-10-31 08:52:10 -07:00
Nathan Reese
9f4673d4ec
[Maps] fix removal of multi fields for tooltip field selection (#49816) (#49859) 2019-10-31 09:16:21 -06:00
Daniil Suleiman
5d9020a8a5
[Vis: Default editor] Create number_input with numeric value required (#48117) (#49840)
* Created number_input with numeric value required

* Remove extra license

* Make value be possibly null
2019-10-31 17:19:30 +03:00
Spencer
ca384d03dd
[7.x] FTR: fix "DevToolsActivePort file doesn't exist" error o… (#49833) 2019-10-31 07:07:38 -07:00
James Gowdy
69344a0e53
[ML] Fixing some of the eslint rule breakages in ML (#49716) (#49758) 2019-10-31 13:54:24 +00:00
Thomas Neirynck
5daaa05c6c
[Maps] Introduce Agg Source (#49782) (#49806)
This removes duplication from geogrid, pewpew and term-sources by introducing a top-level agg-source class.
2019-10-31 09:34:32 -04:00
Liza Katz
0e2e40ef3c
eslint no-restricted-path false positive: bug caused by dir names that start with "index". (#46544) (#49852)
* index* to index.{ts,tsx}

* Added test.

* Added invalid test.

* Added js.
2019-10-31 14:01:31 +02:00
Kerry Gallagher
cfd91426bb
[Logs UI] Improve data structures / access / formatting for the log rate results page (#49158) (#49850)
* Refactor data structures and data formatting

* Handle the "unknown" partition scenario in a more robust way

* Remove temporary fix for the ML link URLs

* Change Results to LogRateResults
2019-10-31 11:42:28 +00:00
Cauê Marcondes
824f53455a
[APM] Add filter option to Metadata table (#48520) (#49733)
* Flatten metadata section objects and adding filter input text

* Adding logic to filter keys and values

* Extrating Section component, adding not found message and creating HeightRetainer component to fix height and avoid the page to jump when filtering

* Adding filtered value to the url

* Refactoring dotted component extrating pathify to an external file

* Removing statefull filtered items

* Refactoring names

* Refactoring variable names

* fixing ui

* Removing space on transaction flyout and changint it to m on span flyout
2019-10-31 12:14:09 +01:00
Dima Arnautov
5a674032ae
[ML] Improve processing of groups in data recognizer wizard (#49310) (#49839)
* [ML] add support for job overrides

* [ML] disable Save button for invalid form, add translation

* [ML] add a tooltip for edit button

* [ML] fix IE flex layout issue

* [ML] conditionally set jobOverrides to the request payload

* [ML] remove hideCloseButton

* [ML] fix applyJobConfigOverrides

* [ML] processArrayValues

* [ML] check deeper arrays

* [ML] PR remarks

* [ML] check for an empty value
2019-10-31 10:59:00 +01:00
Aleh Zasypkin
697610ffd7
[7.x] Fix link to OpenID Connect Elasticsearch guide from the Kibana OpenID Connect docs. (#49774)
Co-Authored-By: Lisa Cawley <lcawley@elastic.co>
2019-10-31 06:54:41 +01:00
Spencer
02479b64e7
[7.x] [canvas] avoid progress reporting in other webpack execu… (#49811) 2019-10-30 19:43:54 -07:00
Justin Kambic
d5aeae728a
[Uptime] Add pagination functional test (#47633) (#49792)
* Remove depdency on legacy interface.

* Remove custom interface, use common breadcrumb type.

* Add HTML template for app react entry point.

* Update app props.

* Add constant for react app entry point.

* Remove dependency on legacy capabilities provider.

* Delete legacy kibana framework adapter.

* Add New Platform adapter, reference in startup code.

* Remove dependency on legacy capabilities function.

* Delete reference to obsolete interface.

* Fix busted types in new adapter.

* Add new plugin class, delete old bootstrap code.

* Update routing/functional tests.

* Provide default for potentially-undefined value.

* run x-pack-ciGroup6 40 times

* Reinsert firefox skip tag.

* Update functional tests to work with newly-merged fixtures.

* Add functional test for pagination.

* Update obsolete test snapshots.

* Return CI to normal.

* Return CI to normal.

* Fix broken test expect.

* Fix type-related issue in test and update snapshot.
2019-10-30 21:20:43 -04:00
Felix Stürmer
7778e72217
[7.x] [Logs UI] Fix log rate analysis tab title and route (#49… (#49779)
Backports the following commits to 7.x:
 - [Logs UI] Fix log rate analysis tab title and route (#49646)
2019-10-30 23:32:57 +01:00
Garrett Spong
c79a5de512
[SIEM] Fixes maps filter on array property to use single property value instead of array value (#49706) (#49783)
## Summary

Resolves https://github.com/elastic/kibana/issues/49534

Filtering on an array property within the map tooltip now uses the single property value instead of the array value. Ended up not showing more than 1 item as part of the `DefaultFieldRenderer` because of this open issue (https://github.com/elastic/ingest-dev/issues/474) which causes layout of subsequent items to be off.

<img width="715" alt="Screen Shot 2019-10-29 at 21 28 32" src="https://user-images.githubusercontent.com/2946766/67826918-c6906880-fa93-11e9-9c88-cbf85672ad99.png">


### Checklist

Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.

- [ ] ~This was checked for cross-browser compatibility, [including a check against IE11](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility)~
- [ ] ~Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md)~
- [ ] ~[Documentation](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#writing-documentation) was added for features that require explanation or tutorials~
- [X] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios
- [ ] ~This was checked for [keyboard-only and screenreader accessibility](https://developer.mozilla.org/en-US/docs/Learn/Tools_and_testing/Cross_browser_testing/Accessibility#Accessibility_testing_checklist)~

### For maintainers

- [ ] ~This was checked for breaking API changes and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)~
- [ ] ~This includes a feature addition or change that requires a release note and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)~
2019-10-30 16:31:30 -06:00
Kaarina Tungseth
90643462d6
[7.x] [DOCS] 7.4.2 Release Notes (#49761) (#49808)
* [DOCS] 7.4.2 Release Notes

* Adds 48710 and 46332

* [DOCS] 7.4.2 Release Notes for 7.5
2019-10-30 16:56:30 -05:00
Steph Milovic
7c662b117a
[SIEM] fix bug that fails to match index patterns with leading wildcard (#49735) (#49786) 2019-10-30 15:32:27 -06:00
Søren Louv-Jansen
c482522654
Allow server to start despite incompatible ES nodes in the cluster (#49490) (#49717) 2019-10-30 21:40:39 +01:00
Justin Kambic
9519deec87
Right-align IP address column in pings list. (#49449) (#49747) 2019-10-30 16:04:23 -04:00
Lisa Cawley
b0428abe00
[DOCS] Fixes link to Kibana monitoring documentation (#49528) (#49767) 2019-10-30 12:29:06 -07:00
Devin W. Hurley
d0d444119e
[SIEM] Replace Scroll query with Search After query (#48844) (#49763)
* replaces scroll with search_after query. This fixes one issue where too many scroll contexts were being created and blocking queries from running on elasticsearch. Search_after fixes that.. I think there are still issues around task manager dropping new tasks because it runs out of available workers. Bulk Index is still a very slow process. Using search_after doesn't seem to be any faster than scroll, but it does keep this from blowing up ES.

* updates sortId type to match SearchResult type of string[]

* utilizes track_total_hits to know when to end the search_after query.. with scroll the query just would return 0 hits but with search_after we are constantly getting new data with no specified point to end it. Also this updates the search query to include the filter as my original search was not including that. big bug.

* type guard for acquiring total value from search response

* removes property leftover from rebasing with master

* removes defunct getFilter function. the filter is now being passed in from the params in signals_alert_type

* removes unused imports

* parameterizes default index for bulk index request

* adds typeof to do type guarding in lieu of extra function

* removes unused TotalValue import, removes optional requirement from size type property and unions undefined, adds size as parameter to rest signal routes

* no idea what happened here

* adds franks test from review - will update with more tests

* adds BulkResponse type, updates logic for when first search result for reindexing is empty

* fixes type error after introducing new logic for when first search result is empty
2019-10-30 15:04:26 -04:00