Commit graph

27678 commits

Author SHA1 Message Date
Matt Bargar
7a1f9fbaec
Add nested field support to KQL (#47070) (#49762)
This PR adds a new syntax to KQL for querying nested fields.

Nested fields can be queried in two different ways:

Parts of the query may only match a single nested doc (bool inside nested). This is what most people want when querying on a nested field.
Parts of the query may match different nested docs (nested inside bool). This is how a regular object field works but nested fields can be queried in the same way. Although generally less useful, there are occasions where one might want to query a nested field in this way.
The new KQL syntax supports both.
2019-10-30 14:44:26 -04:00
Angela Chuang
1d49319fbf
[SIEM] fix incorrect inspected query for kpi network (#49695) (#49755)
* fix incorrect inspected query for kpi network

* update mock data
2019-10-30 13:49:17 -04:00
Liza Katz
a59856d562
Pass overlays service to createFilterAction (#49736) (#49754)
* Pass overlays service to createFilterAction

* Changed import path
2019-10-30 19:43:47 +02:00
patrykkopycinski
10a7c6993b
[SIEM] Hide popover after choosing option from Timeline Settings popover (#49578) (#49745) 2019-10-30 18:00:59 +01:00
Walter Rafelsberger
5c967308f0
[ML] Transforms: Removes temporary x-pack/legacy/plugins/transform eslint overrides. (#49744)
Re-enables linting rules related to React hooks and adapts inline code.
2019-10-30 09:35:51 -07:00
Zacqary Adam Xeper
b6e2f3f619
[Logs UI] Fix endless scrolling to load more entries (#49535) (#49662)
* [Logs UI] Fix endless scrolling to load more entries

* Make scrollable list state update more robust
2019-10-30 10:39:54 -05:00
Dario Gieselaar
a2d190274b
[7.x] [APM] Use indexPatternsService for kuery bar suggestions… (#49727)
* [APM] Use indexPatternsService for kuery bar suggestions

Closes #44487.

* Use simpler message format

* Remove missing labels

* Get index names from setup.indices
2019-10-30 16:30:32 +01:00
Joe Reuter
28314ba580
Kibana app migration: Local application service (#48898) (#49724) 2019-10-30 16:19:21 +01:00
Vadim Dalecky
af7e9fa13f
Fix eslint (#49595) (#49725)
* fix: 🐛 fix unused persistedLog object

* chore: 🤖 ignore ESLint rule

* fix: 🐛 correct dependencies in useUnmount() hook

* fix: 🐛 fix ESLint errors

* chore: 🤖 disable ESLint rule

* fix: 🐛 add savedQueryService to dependency list

* fix: 🐛 fix ESLint errors in data plugin

* chore: 🤖 fix self-closing ESLint rule

* test: 💍 update Jest snapshot

* refactor: 💡 memoize persistedLog in more idiomatic way

* chore: 🤖 remomve unused import

* chore: 🤖 revert possible test breaker

* fix: 🐛 fix query bar merge errors
2019-10-30 14:59:51 +01:00
Aaron Caldwell
cb9c58213b
[Maps] Add back removed logic copying feature properties for injected data (#49400) (#49698)
* Add back removed logic copying feature properties for injected data prior to modification

* Back out injected data and assign featureCollection to sourceDescriptor with __ prefix

* Review feedback. Ensure __featureCollection is always initialized minimally to a geojson object with an empty features array

* Check for null/undefined
2019-10-30 07:58:01 -06:00
Alejandro Fernández
afb338b811
[7.x] [Metrics UI] Tweak the z-index inventory toolbars (#4964… (#49729)
Having a z-index adds problems with the stacking of the dropdowns when
there are two toolbars together.
2019-10-30 14:36:37 +01:00
Nathan Reese
77f305fbc4
[Maps] do not re-fetch data on empty filter setting changes (#49382) (#49701)
* [Maps] do not re-fetch data on empty filter setting changes

* handle case where prev query does not exist

* add parentheses around turnary statement
2019-10-30 06:44:22 -06:00
Larry Gregory
9cbdc0f05e
[7.x] [DOCS] - fixing references to kibana_user role (#49309) (#49719)
* fixing references to kibana_user role

* Update docs/uptime-guide/security.asciidoc

Co-Authored-By: Lisa Cawley <lcawley@elastic.co>


Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2019-10-30 08:43:29 -04:00
igoristic
20e5760722
Added resize listener after handler was created (#49452) (#49707) 2019-10-30 04:31:27 -04:00
Xavier Mouligneau
8107eccea2
put back the code that make everything works (#49643) (#49675) 2019-10-29 22:09:16 -04:00
Wylie Conlon
eaf0a5395f
[Lens] Improve layer suggestions and fix layer crash in metric (#49389) (#49693)
* Add loading indicator to Lens workspace panel

* [Expressions] [Lens] Handle loading and errors in ExpressionRenderer

* Using loading$ observable and improve tests

* [Lens] Fix layer crash and improve layer suggestions

* Using CSS and to handle layout of expression renderer

Added TODO for using chart loader when area is completely empty

* Improve error handling and simplify code

* Fix cleanup behavior

* Fix double render and prevent error cases in xy chart

* Fix context for use in dashboards

* Remove className from expression rendere component

* Improve handling of additional interpreter args

* More layout fixes

- Hide chart if Empty not Loading
- Fix relative positioning for progress bar since className is no longer passed (super hacky)

* Build suggestions that remove layers

* Update tests and add keptLayerIds everywhere

* Fix bug where datatable would accept multi-layer suggestions

* Build more suggestions that work with metric/datatable

* Fix issue with chart switching from empty

* Fix datatable multiple layer issue
2019-10-29 20:48:44 -04:00
Wylie Conlon
fa0106b33a
[Lens] Link to potential docs page (#49670) (#49689) 2019-10-29 19:16:33 -04:00
Chris Cowan
3785bed0e5
[Metrics UI] Remove points from charts on Metrics Explorer and Detail Page (#49500) (#49686)
* Removing points from Metrics Explorer and Metric Detail Page; Fixing bug with metric detail page labels;

* Remove points configuration
2019-10-29 16:03:19 -07:00
Chris Davies
2b57a24629
[Lens] Format the split series in XY charts (#49494) (#49680) 2019-10-29 18:21:38 -04:00
Chris Davies
11bc693339
[Lens] Create special 'Records' field for count operation (#49376) (#49682) 2019-10-29 18:21:12 -04:00
Felix Stürmer
acc1fcca43
[7.x] [Logs UI] Fix index checkbox overlap of the analysis set… (#49659)
Backports the following commits to 7.x:
 - [Logs UI] Fix index checkbox overlap of the analysis setup dat… (#49489)
2019-10-29 22:48:38 +01:00
Garrett Spong
d3ef096415
[SIEM] Update ML incompatible jobs callout text (#49668) (#49673)
## Summary

Updates the placeholder text within the ML Anomaly Detection UI for when certain jobs are incompatible. To test, remove all `siem:defaultIndex` patterns -- this will not send any indices to the recognize API, and all jobs will be _incompatible_.

Resolves https://github.com/elastic/kibana/issues/49200

![image](https://user-images.githubusercontent.com/2946766/67798171-a4252d80-fa48-11e9-83a6-643302935ae5.png)


### Checklist

Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.

- [ ] ~This was checked for cross-browser compatibility, [including a check against IE11](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility)~
- [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md)
- [ ] ~[Documentation](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#writing-documentation) was added for features that require explanation or tutorials~
- [ ] ~[Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios~
- [ ] ~This was checked for [keyboard-only and screenreader accessibility](https://developer.mozilla.org/en-US/docs/Learn/Tools_and_testing/Cross_browser_testing/Accessibility#Accessibility_testing_checklist)~

### For maintainers

- [ ] ~This was checked for breaking API changes and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)~
- [ ] ~This includes a feature addition or change that requires a release note and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)~
2019-10-29 15:33:13 -06:00
Angela Chuang
f3076c0d5d
fix query id for tls selector (#49540) (#49632) 2019-10-29 15:52:30 -04:00
Marta Bondyra
d9dea0588b
[7.x] chore: point issue links to choose (#49616) (#49648) 2019-10-29 20:37:52 +01:00
Chandler Prall
2ee194ea5f
Upgrade EUI to v14.8.0 (#49375) (#49658)
* Upgrade EUI to v14.8.0

* update snapshot for determinism
2019-10-29 13:21:40 -06:00
Larry Gregory
964658c2c5
[7.x] Spaces - fix react hook deps (#49618) (#49656)
* fix react hook deps

* removing lint override for spaces
2019-10-29 15:18:50 -04:00
Wylie Conlon
9c7565982b
[Lens] Remove default title, tweak text for consistency (#49394) (#49665)
* [Lens] Remove default title, tweak text for consistency

* Remove unused

* Text update
2019-10-29 15:14:57 -04:00
Chris Davies
f90855e7b2
[Lens] Make date histogram interval more customizable (#49217) (#49654) 2019-10-29 14:12:31 -04:00
Clint Andrew Hall
150e822377
Fix Runtime Download in Cloud (#49538) (#49586) 2019-10-29 10:55:07 -05:00
Spencer
0ee219e375
[7.x] move react/jsx-a11y rules into shared react preset (#492… (#49631)
* move react/jsx-a11y rules into shared react preset

* autofix react/jsx-closing-tag-location

* autofix react/no-unknown-property

* manually fix react/no-unescaped-entities

* maually fix react/jsx-pascal-case

* manually fix react/prefer-stateless-function

* disable known violations in specific plugins/areas

* remove code override

# Conflicts:
#	x-pack/legacy/plugins/upgrade_assistant/public/components/tabs/checkup/deprecations/reindex/flyout/warnings_step.tsx
2019-10-29 07:45:29 -07:00
Robert Oskamp
b1f497fd78
[ML] Advanced wizard functional UI tests (#49480) (#49623)
This PR adds tests for the ML advanced wizard.
2019-10-29 15:15:20 +01:00
Alexey Antonov
d2b85636c2
Convert agg_types/__tests__ to JEST (Buckets folder) (#49333) (#49622) 2019-10-29 16:49:43 +03:00
Liza Katz
21770fd883
Move Storage ⇒ NP kibana_utils (#49448) (#49619)
* Move storage to kibana_utils

* Updated all references to Storage and replace places where it was referenced to as "store" to avoid confusion.

* fixed tests

* Delete data legacy dependencies plugin

* Imports fix

* update snapshots
2019-10-29 15:42:10 +02:00
Marjorie Jones
28c9bd747c
[DOCs] Rename some instances of Infrastructure to Metrics (#49195) (#49612)
* Renaming Infrastructure to Metrics whenever the context is the metrics app.

* More renames, and picking up a few stray references to Infrastructure/Metrics/Logs UI too.

* Fixing typo
2019-10-29 13:32:26 +00:00
Peter Pisljar
a23a6dd519
use embeddables in visualize editor (#48744) (#49607) 2019-10-29 14:20:55 +01:00
Felix Stürmer
61d48d319c
[7.x] [Logs UI] Fix chart and table state loss due to loading… (#49604)
Backports the following commits to 7.x:
 - [Logs UI] Fix chart and table state loss due to loading indica… (#49356)
2019-10-29 13:11:07 +01:00
Liza Katz
ff31e78202
Move filter manager ⇒ NP (#48391) (#49597)
* Moved filterManager to NP plugin

* Fixed applying filters to dashbaord.

* Minor fixes

* fixed types

* fix jest tests mock of filter

* Updated karma mccks

* Fixed lens test

* fixed import

* Removed comment
2019-10-29 13:13:07 +02:00
Sébastien Loix
5f8e60849d
Es ui shared updates (#46570) (#46716) 2019-10-29 11:25:50 +01:00
Ben Skelker
78b6d60a3c
Fixes title capitalisations (#49445) (#49511) 2019-10-29 08:28:24 +02:00
patrykkopycinski
9f539f1233
[SIEM] Add Authentications histogram (#48260) (#49522) 2019-10-29 06:59:18 +01:00
Oliver Gupte
7b2a586f77
[APM] Add UI Indices runtime configuration (#48079) (#49590)
* Add UI Indices runtime configuration
- index configuration in settings page
- defaults to kibana.yml configuration values

* fix tests

* Code review feedback and cleanup

* fix i18n

* Code review feedback

* Address code review feedback.

* Fixes bug where legacy data filter was including the
.apm-agent-configuration index which caused failures in those APIs
2019-10-28 21:27:33 -07:00
Nathan Reese
eb23b467ca
[Maps] hide map visualization types with default kibana.yml settings (#49103) (#49585)
* [Maps] hide map visualization types with default kibana.yml settings

* add docs explaining xpack.maps.showMapVisualizationTypes

* clean up docs

* fix docs build

* fix typescript failures

* move docs to troubleshooting section

* add message about xpack.maps.showMapVisualizationTypes in coordinate map and region map docs

* doc updates based on gchaps feedback

* Update docs/visualize/regionmap.asciidoc

Co-Authored-By: gchaps <33642766+gchaps@users.noreply.github.com>

* Update docs/visualize/tilemap.asciidoc

Co-Authored-By: gchaps <33642766+gchaps@users.noreply.github.com>
2019-10-28 20:44:19 -06:00
Frank Hassanabad
7a755d0e92
[SIEM] [Detection Engine] Adds filtering abilities to the KQL REST API (#49451) (#49583)
## Summary

* Removes the older beginner KQL type of signal creation in favor of newer version with filtering
* Adds ability to create KQL or lucene queries that will work with the UI filters
* UI state with the filters are now savable to re-hydrate UI's on the front end
* Adds `saved_id` ability so the UI can tether dynamic saved queries with signals
* Changed `it` to `test` as `it` is not the alias we use for tests 
* Updated script which converts older saved searches to work with newer mechanism
* Fixed script to accept proper ndjson lines
* Adds validation unit tests for the endpoint
* Increases validation strictness of the endpoints
* Adds more data scripts for testing scenarios
* https://github.com/elastic/kibana/issues/47013


## Testing
* Run `./hard_reset.sh` script 
* Test with both algorithms through this toggle before starting kibana:
`export USE_REINDEX_API=true`
* Convert older saved searches to compatible new query filters by running:
`./convert_saved_search_to_signals.sh ~/projects/saved_searches /tmp/signals`
* Post them`./post_signal.sh /tmp/signals/*.json`
* Hard reset again
* Test smaller set of signals and REST endpoints using the typical scripts of:
```sh
./post_signal.sh
./read_signal.sh
./find_signals.sh
./update_signal.sh
./delete_signal.sh
```
or test using POSTMAN, etc... If you want to test validation. If you see any validation issues let me know as I have validation testing files and can easily fix them add another unit test to the growing large collection we have now. 

Change in your advanced settings of SIEM to use your signals index you configured for verification that the signals show up.

### Checklist

Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.

~~- [ ] This was checked for cross-browser compatibility, [including a check against IE11](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility)~~

~~- [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md)~~

~~- [ ] [Documentation](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#writing-documentation) was added for features that require explanation or tutorials~~

- [x] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios

~~- [ ] This was checked for [keyboard-only and screenreader accessibility](https://developer.mozilla.org/en-US/docs/Learn/Tools_and_testing/Cross_browser_testing/Accessibility#Accessibility_testing_checklist)~~

### For maintainers

~~- [ ] This was checked for breaking API changes and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)~~

~~- [ ] This includes a feature addition or change that requires a release note and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)~~
2019-10-28 19:13:52 -06:00
Spencer
a11f180e97
[7.x] remove code-plugin specific build task and related node… (#49574) 2019-10-28 17:48:17 -07:00
Mikhail Shustov
c3f6af3ae3
Provide uiSettings service in NP (#48413) (#49531)
* provide ui settins client via context

* update mocks

* update types and expose setDefaults to plugins

* move ui settings routes to NP

* add typings fro test kbn server

* move integration test & improve typings

* hide client private methods, update tests

* add unit tests for get_upgradable_config

* inline writeErrors into createOrUpgradeConfig to simplify testing

* regen docs

* add functional tests for ui_settings service

* unify test suites

* add types for sipertest in core_plugin tests

* tsify core_plugins tests

* add test for empty saved config

* update renovate

* rename get/setDefaults to reguster

* regen docs

* regen docs

* Update src/core/MIGRATION.md

Co-Authored-By: Josh Dover <me@joshdover.com>
2019-10-28 20:32:51 -04:00
Spencer
07caa65860
[7.x] Update moment related packages (#46849) (#49517)
* Update moment related packages

* unify moment version in yarn.lock

* adapt ro pluralization fixes

* update some bad pluralization in fixtures/snapshots
2019-10-28 15:40:39 -07:00
Josh Dover
d939a43371
[7.x] Migrate ui/registry/feature_catalogue to New Platform pl… (#49514) 2019-10-28 15:34:34 -05:00
Josh Dover
16f7d5c78b
[7.x] Migrate necessary ui/autoload functionality to NP (#4868… (#49509) 2019-10-28 15:34:13 -05:00
Chris Davies
050fef41c6
[Lens] Pass date range to the query bar (#49485) (#49515) 2019-10-28 16:21:29 -04:00
Steph Milovic
51c3ba5912
[SIEM] optimize hosts query (#49409) (#49501) 2019-10-28 14:52:04 -05:00