Commit graph

41558 commits

Author SHA1 Message Date
Shahzad b1525f0af7
[Lens] Allow modifying curve type for line/area series charts (#94675) 2021-03-26 16:23:41 +01:00
Scotty Bollinger c5fb8ab8c2
[Workplace Search] Update global state when org nane changes (#95448)
Currently we instantiate the Workplace Search app with server props passed in from the server on initial page load. This data includes the organization name. In our settings section, we poll the server to get update information, but once the data is change, the global state does not get updated on a route change. This is only a problem in the case where a user has changed their org name and returns to the overview page before reloading the page. When this happens, the onboarding step asking the user to change thier org name is still visible.
2021-03-26 10:19:36 -05:00
Marco Liberati 3f58b185d5
[Lens] Prepare Lens for jest-environment-jsdom migration (#95327)
* 🐛 Fix activeElement issue with Jest

* 🏷️ Fix type issue

* 👌 Removed expect-errors directives

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-03-26 15:59:12 +01:00
Larry Gregory dbd4b2bac8
Unskip flaky spaces tests (#95207)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-03-26 15:08:56 +01:00
Matthew Kime ae4dae46d9
Index pattern field editor - Add warning and type 'confirm' on delete or save (#95237)
* add runtime field change/delete confirm dialog
2021-03-26 09:03:13 -05:00
Shahzad b9f5d0c2e1
[Observability] Update plugin start/setup types naming (#95301) 2021-03-26 14:48:08 +01:00
Cauê Marcondes 33b81b115c
[APM] Split All instances API adding a new API to return comparison statistics (#94767)
* adding comparison to instances table

* fixing tests

* adding api tests

* removing unnecessary files

* fixing ts issue

* fixing ts issue

* refactoring

* refactoring

* refactoring

* refactoring

* refactoring

* addressing PR comments

* addressing PR comments
2021-03-26 09:14:03 -04:00
Thomas Neirynck f99d93d506
[Maps] Remove invisible layers from querybar (#94943) 2021-03-26 09:11:47 -04:00
Jonathan Buttner f4526ad88c
[Cases] Fix _find API total bug (#95235)
* Cherry-picking 7.12 find total fix

* Starting fix for total bug in master with new field

* Adding feature flag for sub cases

* Disabling case as a connector in security solution

* Adding additional tests for pagination

* Removing other api integration tests

* Fixing up problems from merge

* Fixing sub case tests and type errors

* Renaming comment tag for case connector
2021-03-26 08:46:07 -04:00
Marco Liberati 243a7f9b2b
[Lens] Rename operations to map exposed names for Formula (#94710)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-03-26 11:54:42 +01:00
David Sánchez 2af094a63d
[Security Solution] Put Artifacts by Policy feature behind a feature flag (#95284)
* Added sync_master file for tracking/triggering PRs for merging master into feature branch

* removed unnecessary (temporary) markdown file

* Trusted apps by policy api (#88025)

* Initial version of API for trusted apps per policy.

* Fixed compilation errors because of missing new property.

* Mapping from tags to policies and back. (No testing)

* Fixed compilation error after pulling in main.

* Fixed failing tests.

* Separated out the prefix in tag for policy reference into constant.

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

* [SECURITY_SOLUTION][ENDPOINT] Ability to create a Trusted App as either Global or Policy Specific (#88707)

* Create form supports selecting policies or making Trusted app global
* New component `EffectedPolicySelect` - for selecting policies
* Enhanced `waitForAction()` test utility to provide a `validate()` option

* [SECURITY SOLUTION][ENDPOINT] UI for editing Trusted Application items (#89479)

* Add Edit button to TA card UI
* Support additional url params (`show`, `id`)
* Refactor TrustedAppForm to support Editing of an existing entry

* [SECURITY SOLUTION][ENDPOINT] API (`PUT`) for Trusted Apps Edit flow (#90333)

* New API route for Update (`PUT`)
* Connect UI to Update (PUT) API
* Add `version` to TrustedApp type and return it on the API responses
* Refactor - moved some public/server shared modules to top-level `common/*`

* [SECURITY SOLUTION][ENDPOINT] Trusted Apps API to retrieve a single Trusted App item (#90842)

* Get One Trusted App API - route, service, handler
* Adjust UI to call GET api to retrieve trusted app for edit
* Deleted ununsed trusted app types file
* Add UI handling of non-existing TA for edit or when id is missing in url

* [Security Solution][Endpoint] Multiple misc. updates/fixes for Edit Trusted Apps (#91656)

* correct trusted app schema to ensure `version` is not exposed on TS type for POST
* Added updated_by, updated_on properties to TrustedApp
* Refactored TA List view to fix bug where card was not updated on a successful edit
* Test cases for card interaction from the TA List view
* Change title of policy selection to `Assignment`
* Selectable Policy CSS adjustments based on UX feedback

* Fix failing server tests

* [Security Solution][Endpoint] Trusted Apps list API KQL filtering support (#92611)

* Fix bad merge from master
* Fix trusted apps generator
* Add `kuery` to the GET (list) Trusted Apps api

* Refactor schema with Put method after merging changes with master

* WIP: allow effectScope only when feature flag is enabled

* Fixes errors with non declared logger

* Uses experimental features module to allow or not effectScope on create/update trusted app schema

* Set default value for effectScope when feature flag is disabled

* Adds experimentals into redux store. Also creates hook to retrieve a feature flag value from state

* Hides effectPolicy when feature flag is not enabled

* Fixes unit test mocking hook and adds new test case

* Changes file extension for custom hook

* Adds new unit test for custom hook

* Hides horizontal bar with feature flag

* Compress text area depending on feature flag

* Fixes failing test because feature flag

* Fixes wrong import and unit test

* Thwrows error if invalid feature flag check

* Adds snapshoot checks with feature flag enabled/disabled

* Test snapshots

* Changes type name

* Add experimentalFeatures in app context

* Fixes type checks due AppContext changes

* Fixes test due changes on custom hook

Co-authored-by: Paul Tavares <paul.tavares@elastic.co>
Co-authored-by: Bohdan Tsymbala <bohdan.tsymbala@elastic.co>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Paul Tavares <56442535+paul-tavares@users.noreply.github.com>
2021-03-26 11:32:46 +01:00
Alexey Antonov 02a8f11ec8
[Timelion] Allow import/export of timelion-sheet saved object (#95048)
* [Timelion] Allow import/export of timelion-sheet saved  object

Closes: #9107

* visualize.show -> timelion.show

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-03-26 11:50:21 +03:00
Pierre Gayvallet 32212644da
[Application Usage] use incrementCounter on daily reports instead of creating transactional documents (#94923)
* initial implementation

* add test for upsertAttributes

* update generated doc

* remove comment

* removal transactional documents from the collector aggregation logic

* rename generic type

* add missing doc file

* split rollups into distinct files

* for api integ test

* extract types to their own file

* only roll transactional documents during startup

* proper fix is better fix

* perform daily rolling until success

* unskip flaky test

* fix unit tests
2021-03-26 08:11:35 +01:00
Stacey Gammon 5d59c2c8e1
Add section on developer documentation into best practices docs (#95473)
* add section on dev docs to best pratices.

* Update best_practices.mdx

* Update dev_docs/best_practices.mdx

Co-authored-by: Brandon Kobel <brandon.kobel@gmail.com>

Co-authored-by: Brandon Kobel <brandon.kobel@gmail.com>
2021-03-25 18:52:07 -04:00
Nathan Reese ba029aa95e
[Maps] split out DrawFilterControl and DrawControl (#95255)
* [Maps] split out DrawFilterControl and DrawControl

* clean up

* update i18n id

* give 'global_index_pattern_management_all' permission to functional test because new check blocks access without it

* revert last change

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-03-25 16:22:02 -06:00
Greg Back e01f317d9c
Add Vega help link to DocLinksService (#87721)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-03-25 17:57:25 -04:00
Søren Louv-Jansen bd3f5d4863
Update APM readme (#95383)
* Update APM readme

* Update readme.md

* Update x-pack/plugins/apm/readme.md

Co-authored-by: Cauê Marcondes <55978943+cauemarcondes@users.noreply.github.com>

Co-authored-by: Cauê Marcondes <55978943+cauemarcondes@users.noreply.github.com>
2021-03-25 21:19:48 +01:00
Jonathan Budzenski 724e21e007 skip flaky test. #95345 2021-03-25 15:11:40 -05:00
Matthew Kime 306a42c03c
Index pattern management - use new es client instead of legacy (#95293)
* use new es client instead of legacy

* use resolve api on client
2021-03-25 14:59:14 -05:00
Spencer dd10c8b5f2
[kbn/test] switch to @elastic/elasticsearch (#95443)
Co-authored-by: spalger <spalger@users.noreply.github.com>
2021-03-25 14:57:32 -05:00
restrry 3bb9220db9 add about section for link in github issue template 2021-03-25 20:29:21 +01:00
Lukas Olson a10c4188b7
Re-enable skipped test (discover with async scripted fields) (#94653)
* Re-enable skipped test

* remove comment

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-03-25 12:24:36 -07:00
Mikhail Shustov 6eb31178ed
blank_issues_enabled: false. it seems contact_links not supported otherwise (#95423) 2021-03-25 20:20:01 +01:00
Ece Özalp d70d02ee83
Add a11y test coverage to Rule Creation Flow for Detections tab (#94377)
[Security Solution] Add a11y test coverage to Detections rule creation flow (#80060)
2021-03-25 15:05:23 -04:00
Nathan Reese c5e3e78de8
[Maps] do not track total hits for elasticsearch search requests (#91754)
* [Maps] do not track total hits for elasticsearch search requests

* set track_total_hits for es_search_source tooltip fetch

* tslint

* searchSource doc updates, set track_total_hits in MVT requests

* revert changes made to searchsourcefields docs

* tslint

* review feedback

* tslint

* remove Hits (Total) from functional tests

* remove sleep in functional test

* tslint

* fix method name

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-03-25 13:00:16 -06:00
Kerry Gallagher 6b6404954e
[Logs / Metrics UI] Separate logs / metrics source configuration awareness (#95334)
* Remove metrics awareness of logs fields
2021-03-25 18:59:18 +00:00
Alison Goryachev 43e3d558fd
[Snapshot + Restore] Add callout when restoring snapshot (#95104) 2021-03-25 14:41:58 -04:00
Matthias Wilhelm fad3b74f2f
[Discover] Unskip functional test of saved queries (#94705) 2021-03-25 19:33:16 +01:00
MadameSheema 6a571486fc
[Security Solution][Detections] Improves indicator match Cypress tests (#94913)
* updates the data used in the test

* adds matches test

* adds enrichment test

* improves speed and adds missing files

* fixes type check issue

* adds 'data-test-subj' for the json view tab

* refactor

* fixes typecheck issue

* updates tests with latest master changes

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-03-25 19:25:49 +01:00
Jonathan Budzenski 02fce98254 skip flaky test. #89389 2021-03-25 12:51:05 -05:00
Devon Thomson 50bdbfc18e
[Dashboard] Fix Title BWC (#95355)
* allow saving blank string to panel title
2021-03-25 13:47:15 -04:00
Jonathan Buttner 07f32d03b3
[Cases] Adding feature flag for sub cases (#95122)
* Adding feature flag for sub cases

* Disabling case as a connector in security solution

* Fix connector test

* Switching feature flag to global variable

* Removing this.config use

* Fixing circular import and renaming flag
2021-03-25 13:36:25 -04:00
Constance b9ef084130
[App Search] API Logs - set up basic view & routing (#95369)
* Add basic API Logs view

* Update engine router + nav link
2021-03-25 09:19:39 -07:00
Scotty Bollinger 50d7cea812
[Workplace Search] Add UI logic for GitHub Configure Step (#95254)
* Fix typo

This was mis-copied from ent-search

* No longer store preContentSourceId in query param

In ent-search, we had the Rails server redirect with this param. Now, it is contained in the server response as JSON and is persisted in the logic file

* Pass query params to SourceAdded component

The entire state is stored in query params now and must be passed when doing a manual redirect

* Redirect to config view if config needed

* Don’t redirect if the config has already been completed

This was really tricky and could use a refactor in the future, perhaps. The issue is that the persisted query params will contain the `preContentSourceId` even after the config has been completed. This caused the UI to attempt to navigate back to the config screen after it had been completed. This sets a prop once that has been completed and bypasses the redirect.

* Use correct key to determine if config needed

* Update tests
2021-03-25 11:12:53 -05:00
Tiago Costa c042968b33
chore(NA): upgrade bazel rules nodejs to v3.2.3 (#95413) 2021-03-25 12:08:34 -04:00
Nathan Reese 373a108cfe
[Maps] upgrade server to use new elasticsearch-js client (#95314)
* [Maps] upgrade server to use new elasticsearch-js client

* update functional test expect
2021-03-25 10:06:56 -06:00
Mikhail Shustov 6d6ef0092a
Revert "do not allow creating Question issue (#95396)" (#95427)
This reverts commit 9a64354db2.
2021-03-25 16:56:51 +01:00
Mikhail Shustov 9a64354db2
do not allow creating Question issue (#95396) 2021-03-25 16:23:25 +01:00
Dima Arnautov a8b04d7c54
[ML] Extract job selection resolver (#95394) 2021-03-25 11:21:10 -04:00
Shahzad e0534e42ae
Expose xy chart types component (#95275) 2021-03-25 15:27:30 +01:00
Casper Hübertz e894ee973f
[Observability] Change icon ref (#95367) 2021-03-25 14:29:51 +01:00
Nicolas Chaulet 00c53c56b8
[Fleet] Replace INTERNAL_POLICY_REASSIGN by POLICY_REASSIGN (#94116) 2021-03-25 09:15:59 -04:00
igoristic 80e53d5fe6
[Monitoring] Remove license check for alerting (#94874)
* Removed license check for alerting

* Fixed tests and CR feedback

* Fixed test
2021-03-25 09:02:51 -04:00
Patrick Mueller 9d47330ccf
[alerting] add user facing doc on event log ILM policy (#92736)
resolves https://github.com/elastic/kibana/issues/82435

Just provided a brief description, name of the policy, mentioned
we create it but never modify it, provided the default values, and mentioned
it could be updated by customers for their environment.  Not sure we want to
provide more info than that.
2021-03-25 08:30:46 -04:00
Peter Pisljar 1e87cef3e0
handling references for kibana_context and get_index_pattern expression functions (#95224) 2021-03-25 12:34:38 +01:00
Tomas Della Vedova 238791b942
ES client : use the new type definitions (#83808)
* Use client from branch

* Get type checking working in core

* Fix types in other plugins

* Update client types + remove type errors from core

* migrate Task Manager Elasticsearch typing from legacy library to client library

* use SortOrder instead o string in alerts

* Update client types + fix core type issues

* fix maps ts errors

* Update Lens types

* Convert Search Profiler body from a string to an object to conform to SearchRequest type.

* Fix SOT types

* Fix/mute Security/Spaces plugins type errors.

* Fix bootstrap types

* Fix painless_lab

* corrected es typing in Event Log

* Use new types from client for inferred search responses

* Latest type defs

* Integrate latest type defs for APM/UX

* fix core errors

* fix telemetry errors

* fix canvas errors

* fix data_enhanced errors

* fix event_log errors

* mute lens errors

* fix or mute maps errors

* fix reporting errors

* fix security errors

* mute errors in task_manager

* fix errors in telemetry_collection_xpack

* fix errors in data plugins

* fix errors in alerts

* mute errors in index_management

* fix task_manager errors

* mute or fix lens errors

* fix upgrade_assistant errors

* fix or mute errors in index_lifecycle_management

* fix discover errors

* fix core tests

* ML changes

* fix core type errors

* mute error in kbn-es-archiver

* fix error in data plugin

* fix error in telemetry plugin

* fix error in discover

* fix discover errors

* fix errors in task_manager

* fix security errors

* fix wrong conflict resolution

* address errors with upstream code

* update deps to the last commit

* remove outdated comments

* fix core errors

* fix errors after update

* adding more expect errors to ML

* pull the lastest changes

* fix core errors

* fix errors in infra plugin

* fix errors in uptime plugin

* fix errors in ml

* fix errors in xpack telemetry

* fix or mute errors in transform

* fix errors in upgrade assistant

* fix or mute fleet errors

* start fixing apm errors

* fix errors in osquery

* fix telemetry tests

* core cleanup

* fix asMutableArray imports

* cleanup

* data_enhanced cleanup

* cleanup events_log

* cleaup

* fix error in kbn-es-archiver

* fix errors in kbn-es-archiver

* fix errors in kbn-es-archiver

* fix ES typings for Hit

* fix SO

* fix actions plugin

* fix fleet

* fix maps

* fix stack_alerts

* fix eslint problems

* fix event_log unit tests

* fix failures in data_enhanced tests

* fix test failure in kbn-es-archiver

* fix test failures in index_pattern_management

* fixing ML test

* remove outdated comment in kbn-es-archiver

* fix error type in ml

* fix eslint errors in osquery plugin

* fix runtime error in infra plugin

* revert changes to event_log cluser exist check

* fix eslint error in osquery

* fixing ML endpoint argument types

* fx types

* Update api-extractor docs

* attempt fix for ese test

* Fix lint error

* Fix types for ts refs

* Fix data_enhanced unit test

* fix lens types

* generate docs

* Fix a number of type issues in monitoring and ml

* fix triggers_actions_ui

* Fix ILM functional test

* Put search.d.ts typings back

* fix data plugin

* Update typings in typings/elasticsearch

* Update snapshots

* mute errors in task_manager

* mute fleet errors

* lens. remove unnecessary ts-expect-errors

* fix errors in stack_alerts

* mute errors in osquery

* fix errors in security_solution

* fix errors in lists

* fix errors in cases

* mute errors in search_examples

* use KibanaClient to enforce promise-based API

* fix errors in test/ folder

* update comment

* fix errors in x-pack/test folder

* fix errors in ml plugin

* fix optional fields in ml api_integartoon tests

* fix another casting problem in ml tests

* fix another ml test failure

* fix fleet problem after conflict resolution

* rollback changes in security_solution. trying to fix test

* Update type for discover rows

* uncomment runtime_mappings as its outdated

* address comments from Wylie

* remove eslint error due to any

* mute error due to incompatibility

* Apply suggestions from code review

Co-authored-by: John Schulz <github.com@jfsiii.org>

* fix type error in lens tests

* Update x-pack/plugins/upgrade_assistant/server/lib/reindexing/reindex_service.ts

Co-authored-by: Alison Goryachev <alisonmllr20@gmail.com>

* Update x-pack/plugins/upgrade_assistant/server/lib/reindexing/reindex_service.test.ts

Co-authored-by: Alison Goryachev <alisonmllr20@gmail.com>

* update deps

* fix errors in core types

* fix errors for the new elastic/elasticsearch version

* remove unused type

* remove unnecessary manual type cast and put optional chaining back

* ML: mute Datafeed is missing indices_options

* Apply suggestions from code review

Co-authored-by: Josh Dover <1813008+joshdover@users.noreply.github.com>

* use canary pacakge instead of git commit

Co-authored-by: Josh Dover <me@joshdover.com>
Co-authored-by: Josh Dover <1813008+joshdover@users.noreply.github.com>
Co-authored-by: Gidi Meir Morris <github@gidi.io>
Co-authored-by: Nathan Reese <reese.nathan@gmail.com>
Co-authored-by: Wylie Conlon <wylieconlon@gmail.com>
Co-authored-by: CJ Cenizal <cj@cenizal.com>
Co-authored-by: Aleh Zasypkin <aleh.zasypkin@gmail.com>
Co-authored-by: Dario Gieselaar <dario.gieselaar@elastic.co>
Co-authored-by: restrry <restrry@gmail.com>
Co-authored-by: James Gowdy <jgowdy@elastic.co>
Co-authored-by: John Schulz <github.com@jfsiii.org>
Co-authored-by: Alison Goryachev <alisonmllr20@gmail.com>
2021-03-25 04:47:16 -04:00
Shahzad 9724051f92
[Observability] add loading state in use fetcher (#95292) 2021-03-25 09:06:58 +01:00
Shahzad b88f02ffb4
[Uptime] unskip overview test (#95290) 2021-03-25 09:05:26 +01:00
Shahzad 69bb5979ce
[Uptime] Support agent data streams (#91469)
Co-authored-by: Dominique Clarke <doclarke71@gmail.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-03-25 09:04:40 +01:00
Matthias Wilhelm 6b5023a681
[Discover] Deangularize controller part 1 (#93896)
* Refactor minimumVisibleRows

* Extract setupVisualization function

* Extract getDimensions function

* Inline breadcrumb and help menu function exec to discover.tsx

* Extract getStateDefault 

* Remove unnecessary code

* Improve performance by React.memo
2021-03-25 07:34:01 +01:00