* Removing circular dependency between spaces and security
* Apply suggestions from code review
Co-authored-by: Constance <constancecchen@users.noreply.github.com>
Co-authored-by: Aleh Zasypkin <aleh.zasypkin@gmail.com>
* Tests refactor
- Reorganize top level describes into 3 space-based blocks into based on spaces:
- space disabled
- spaces plugin unavailable
- space enabled (most previous tests go under this new block) with new beforeEach
- wrote new tests for uncovered lines 58, 66-69
* Review1: address PR feedback
* changing fake requests for alerts/actions
* Fixing tests
* fixing more tests
* Additional testing and refactoring
* Apply suggestions from code review
Co-authored-by: Aleh Zasypkin <aleh.zasypkin@gmail.com>
* Review 2: Address feedback
* Make ESLint happy again
Co-authored-by: Constance <constancecchen@users.noreply.github.com>
Co-authored-by: Aleh Zasypkin <aleh.zasypkin@gmail.com>
Co-authored-by: Constance Chen <constance.chen.3@gmail.com>
* create empty plugin + move home feature registration to it
* move the so action_registry to new plugin
* adapt existing calls to the registry
* fix i18n namespace
* fix table unit tests
* update codeowners
* rename plugin to match other PRs
* remove registerLegacyAPI from spaces public plugin
* fix typo
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
* first iteration
* local collection ready
* type check
* fix collectorSet tests
* unskip test
* ordering
* collectors as array in constructor
* update README files
* update README and canvas to check for optional dep
* update README with more details
* Add file path for README example
* type UsageCollectionSetup
* run type check after refactor
* [NP:Kibana:homeAPI] initializes a new plugin (WIP)
* Typing
* New plugin tutorials not needing server working
* Retains legacy tutorial registration and adds new route for new platform tutorial plugin registrations
* Adds comment on where to pre-register general non-plugin specific tutorials
* Converts TutorialsPlugin to TutorialsRegistry service in new Home plugin
* Changes call to location of registerTutorial in registerTutorials
* Adds console log for the home plugin that's returning an empty object
* Removes async from setup and start methods in the home plugin and the tutorials service
* Starts writing tests and creating mocks
* Adds basic tests for TutorialRegistry service
* Adds basic tests for TutorialRegistry service
* Adds test for route
* Adds mocks and tests for the home plugin
* Adds home plugin to security plugin and registers scoped tutorials service
* Removes incorrect addition to src core server
* Fixes type errors
* Deletes unused code
* Deletes duplicate golangMetricsSpecProvider registration
* Nests tutorials service in a tutorials key in the home plugin, changes api http routes for legacy platform and NP
* Changes url variable names