Commit graph

28690 commits

Author SHA1 Message Date
Walter Rafelsberger b368c6acba
[ML] Transforms: Removes temporary x-pack/legacy/plugins/transform eslint overrides.
Re-enables linting rules related to React hooks and adapts inline code.
2019-10-30 08:07:09 -07:00
patrykkopycinski 0efe6a2f16
[SIEM] Hide popover after choosing option from Timeline Settings popover (#49578) 2019-10-30 15:40:53 +01:00
Vadim Dalecky a38223d890
Expressions np (#47810)
* refactor: 💡 generalize service getters and setters in expressio

* feat: 🎸 create NP-ready plugin for expressions

* refactor: 💡 flatten expressions plugin and remove service

* chore: 🤖 re-export legacy expressions service dir for Lens

* refactor: 💡 don't import renderer registry statically

* test: 💍 mock expressions service renderers registry in Mocha

* refactor: 💡 clean-up NP expressions pugin

* refactor: 💡 move Expression fonts to NP

* refactor: 💡 register Interpreter entities explicitly

* refactor: 💡 move clog Expression function to NP

* refactor: 💡 move font function and style types to NP

* refactor: 💡 remove ui/chrome from kibana_context function

* feat: 🎸 add ability to consume start core from setup life-cycle

* refactor: 💡 move kibana_context function to NP

* feat: 🎸 improve naming and delete import of missing function

* refactor: 💡 register expression clog and font fn in NP

* chore: 🤖 set AppArch as GitHub folder owners

* refactor: 💡 move Expression "kibana" function to NP

* refactor: 💡 move range function to visualizations plugin

* feat: 🎸 move visDimensions to visualizations plugin

* chore: 🤖 delete unused files

* refactor: 💡 move expression type registration to NP

* refactor: 💡 move createHandlers() function to NP

* feat: 🎸 move Expression executor to NP

* refactor: 💡 re-implement function registry

* refactor: 💡 convert expression type to class

* fix: 🐛 correct TypeScript errors

* feat: 🎸 convert Expressions type registry to class

* feat: 🎸 convert render function registry to class

* fix: 🐛 fix TypeScript errors

* fix: 🐛 fix translations after refactor

* refactor: 💡 move Expression types to NP

* test: 💍 remove unused test

* fix: 🐛 fix Lens import after merge with master

* fix: 🐛 fix TypeScript errors

* refactor: 💡 update expression types

* test: 💍 fix renderer test
2019-10-30 14:57:53 +01:00
Mikhail Shustov e665574c30
add platform team as a licensing owner (#49617) 2019-10-30 09:45:20 -04:00
Dario Gieselaar 46304f0ce9
[APM] Use indexPatternsService for kuery bar suggestions (#49169)
* [APM] Use indexPatternsService for kuery bar suggestions

Closes #44487.

* Use simpler message format

* Remove missing labels

* Get index names from setup.indices
2019-10-30 12:52:52 +01:00
Vadim Dalecky a10cf388c1
Fix eslint (#49595)
* fix: 🐛 fix unused persistedLog object

* chore: 🤖 ignore ESLint rule

* fix: 🐛 correct dependencies in useUnmount() hook

* fix: 🐛 fix ESLint errors

* chore: 🤖 disable ESLint rule

* fix: 🐛 add savedQueryService to dependency list

* fix: 🐛 fix ESLint errors in data plugin

* chore: 🤖 fix self-closing ESLint rule

* test: 💍 update Jest snapshot

* refactor: 💡 memoize persistedLog in more idiomatic way

* chore: 🤖 remomve unused import

* chore: 🤖 revert possible test breaker

* fix: 🐛 fix query bar merge errors
2019-10-30 12:44:38 +01:00
Joe Reuter 1fab577f8a
Kibana app migration: Local application service (#48898) 2019-10-30 12:15:34 +01:00
Larry Gregory 29c5b44403
[DOCS] - fixing references to kibana_user role (#49309)
* fixing references to kibana_user role

* Update docs/uptime-guide/security.asciidoc

Co-Authored-By: Lisa Cawley <lcawley@elastic.co>


Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2019-10-30 07:08:01 -04:00
Jaime Soriano Pastor ed9cdd7afe
Add CockroachDB Metricbeat module to Kibana Home (#49672) 2019-10-30 11:43:27 +01:00
Søren Louv-Jansen e3b0fc0626
Allow server to start despite incompatible ES nodes in the cluster (#49490) 2019-10-30 10:55:26 +01:00
Alejandro Fernández d955797f1f
[Metrics UI] Tweak the z-index inventory toolbars (#49642)
Having a z-index adds problems with the stacking of the dropdowns when
there are two toolbars together.
2019-10-30 09:26:53 +01:00
igoristic e61ee759f5
Added resize listener after handler was created (#49452) 2019-10-30 00:18:36 -04:00
Nathan Reese 904eb32ae2
[Maps] do not re-fetch data on empty filter setting changes (#49382)
* [Maps] do not re-fetch data on empty filter setting changes

* handle case where prev query does not exist

* add parentheses around turnary statement
2019-10-29 20:55:38 -06:00
Aaron Caldwell e02b092114
[Maps] Add back removed logic copying feature properties for injected data (#49400)
* Add back removed logic copying feature properties for injected data prior to modification

* Back out injected data and assign featureCollection to sourceDescriptor with __ prefix

* Review feedback. Ensure __featureCollection is always initialized minimally to a geojson object with an empty features array

* Check for null/undefined
2019-10-29 19:28:57 -06:00
Wylie Conlon dad9d6b1b9
[Lens] Improve layer suggestions and fix layer crash in metric (#49389)
* Add loading indicator to Lens workspace panel

* [Expressions] [Lens] Handle loading and errors in ExpressionRenderer

* Using loading$ observable and improve tests

* [Lens] Fix layer crash and improve layer suggestions

* Using CSS and to handle layout of expression renderer

Added TODO for using chart loader when area is completely empty

* Improve error handling and simplify code

* Fix cleanup behavior

* Fix double render and prevent error cases in xy chart

* Fix context for use in dashboards

* Remove className from expression rendere component

* Improve handling of additional interpreter args

* More layout fixes

- Hide chart if Empty not Loading
- Fix relative positioning for progress bar since className is no longer passed (super hacky)

* Build suggestions that remove layers

* Update tests and add keptLayerIds everywhere

* Fix bug where datatable would accept multi-layer suggestions

* Build more suggestions that work with metric/datatable

* Fix issue with chart switching from empty

* Fix datatable multiple layer issue
2019-10-29 19:05:03 -04:00
Wylie Conlon c35365109e
[Lens] Link to potential docs page (#49670) 2019-10-29 17:43:39 -04:00
Chris Cowan 871212e1de
[Metrics UI] Remove points from charts on Metrics Explorer and Detail Page (#49500)
* Removing points from Metrics Explorer and Metric Detail Page; Fixing bug with metric detail page labels;

* Remove points configuration
2019-10-29 14:12:55 -07:00
Chris Davies 92d2e4e68a
[Lens] Create special 'Records' field for count operation (#49376) 2019-10-29 16:36:45 -04:00
Chris Davies 5f1c621698
[Lens] Format the split series in XY charts (#49494) 2019-10-29 16:36:11 -04:00
Cauê Marcondes 7fd6499138
[APM] Add filter option to Metadata table (#48520)
* Flatten metadata section objects and adding filter input text

* Adding logic to filter keys and values

* Extrating Section component, adding not found message and creating HeightRetainer component to fix height and avoid the page to jump when filtering

* Adding filtered value to the url

* Refactoring dotted component extrating pathify to an external file

* Removing statefull filtered items

* Refactoring names

* Refactoring variable names

* fixing ui

* Removing space on transaction flyout and changint it to m on span flyout
2019-10-29 21:14:41 +01:00
Garrett Spong 895c0d865b
[SIEM] Update ML incompatible jobs callout text (#49668)
## Summary

Updates the placeholder text within the ML Anomaly Detection UI for when certain jobs are incompatible. To test, remove all `siem:defaultIndex` patterns -- this will not send any indices to the recognize API, and all jobs will be _incompatible_.

Resolves https://github.com/elastic/kibana/issues/49200

![image](https://user-images.githubusercontent.com/2946766/67798171-a4252d80-fa48-11e9-83a6-643302935ae5.png)


### Checklist

Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.

- [ ] ~This was checked for cross-browser compatibility, [including a check against IE11](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility)~
- [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md)
- [ ] ~[Documentation](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#writing-documentation) was added for features that require explanation or tutorials~
- [ ] ~[Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios~
- [ ] ~This was checked for [keyboard-only and screenreader accessibility](https://developer.mozilla.org/en-US/docs/Learn/Tools_and_testing/Cross_browser_testing/Accessibility#Accessibility_testing_checklist)~

### For maintainers

- [ ] ~This was checked for breaking API changes and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)~
- [ ] ~This includes a feature addition or change that requires a release note and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)~
2019-10-29 13:57:18 -06:00
Xavier Mouligneau 9cc09a09b8
put back the code that make everything works (#49643) 2019-10-29 15:21:40 -04:00
Wylie Conlon e3ec773004
[Lens] Remove default title, tweak text for consistency (#49394)
* [Lens] Remove default title, tweak text for consistency

* Remove unused

* Text update
2019-10-29 13:51:53 -04:00
Zacqary Adam Xeper 77792af7b4
[Logs UI] Fix endless scrolling to load more entries (#49535)
* [Logs UI] Fix endless scrolling to load more entries

* Make scrollable list state update more robust
2019-10-29 12:16:36 -05:00
Felix Stürmer 215ac207fa
[Logs UI] Fix index checkbox overlap of the analysis setup dat… (#49489)
This slightly increases the datepicker popover `z-index` to avoid the checkbox labels (which for some reason have an increased `z-index`) from underneath showing through.

fixes #49245
2019-10-29 18:05:40 +01:00
Chandler Prall 94202a9eab
Upgrade EUI to v14.8.0 (#49375)
* Upgrade EUI to v14.8.0

* update snapshot for determinism
2019-10-29 11:04:24 -06:00
Larry Gregory 8bd0aacc5f
Spaces - fix react hook deps (#49618)
* fix react hook deps

* removing lint override for spaces
2019-10-29 12:54:21 -04:00
Chris Davies ebb494478a
[Lens] Make date histogram interval more customizable (#49217) 2019-10-29 12:48:30 -04:00
John Dorlus f72be334ec
Snapshots title ie11 misalignment (#48802)
* Removed Flexbox around header and link elements.

* Removed unused EUI component

* Added class to include the ellipses when name is truncated.

* Fixed title in policy_details.tsx

* Fixed buttons and title on policy and repository table.

* Linting fixes.

* Removed unused references.

* Added keys to arrays of elements to resolve React errors.
2019-10-29 09:13:13 -07:00
Marta Bondyra 6c4f3cbb5c
chore: point issue links to choose (#49616) 2019-10-29 15:54:27 +01:00
Angela Chuang 529945bf42
fix query id for tls selector (#49540) 2019-10-29 09:22:53 -04:00
Spencer 19ea92abb7
move react/jsx-a11y rules into shared react preset (#49244)
* move react/jsx-a11y rules into shared react preset

* autofix react/jsx-closing-tag-location

* autofix react/no-unknown-property

* manually fix react/no-unescaped-entities

* maually fix react/jsx-pascal-case

* manually fix react/prefer-stateless-function

* disable known violations in specific plugins/areas

* remove code override
2019-10-29 06:15:33 -07:00
Robert Oskamp 75384e1bcd
[ML] Advanced wizard functional UI tests (#49480)
This PR adds tests for the ML advanced wizard.
2019-10-29 13:36:45 +01:00
Alexey Antonov 80d17b744d
Convert agg_types/__tests__ to JEST (Buckets folder) (#49333) 2019-10-29 15:28:54 +03:00
Liza Katz a6d0b6018b
Move Storage ⇒ NP kibana_utils (#49448)
* Move storage to kibana_utils

* Updated all references to Storage and replace places where it was referenced to as "store" to avoid confusion.

* fixed tests

* Delete data legacy dependencies plugin

* Imports fix

* update snapshots
2019-10-29 14:16:08 +02:00
Marjorie Jones 5e05bbd05f
[DOCs] Rename some instances of Infrastructure to Metrics (#49195)
* Renaming Infrastructure to Metrics whenever the context is the metrics app.

* More renames, and picking up a few stray references to Infrastructure/Metrics/Logs UI too.

* Fixing typo
2019-10-29 11:29:21 +00:00
Peter Pisljar c09e1cd477
use embeddables in visualize editor (#48744) 2019-10-29 12:00:35 +01:00
Felix Stürmer 51df8afd7e
[Logs UI] Fix chart and table state loss due to loading indica… (#49356)
This changes the result loading indicators of the log rate analysis page such that they are rendered as an overlay to the existing panels. This has the advantage that the page layout doesn't jump during the loading process and the charts and table maintain their filter and expansion states.
2019-10-29 11:51:54 +01:00
Liza Katz 19c4f872cc
Move filter manager ⇒ NP (#48391)
* Moved filterManager to NP plugin

* Fixed applying filters to dashbaord.

* Minor fixes

* fixed types

* fix jest tests mock of filter

* Updated karma mccks

* Fixed lens test

* fixed import

* Removed comment
2019-10-29 11:55:24 +02:00
Oliver Gupte c3996e293c
[APM] Add UI Indices runtime configuration (#48079)
* Add UI Indices runtime configuration
- index configuration in settings page
- defaults to kibana.yml configuration values

* fix tests

* Code review feedback and cleanup

* fix i18n

* Code review feedback

* Address code review feedback.

* Fixes bug where legacy data filter was including the
.apm-agent-configuration index which caused failures in those APIs
2019-10-28 20:00:53 -07:00
Clint Andrew Hall 13fb20f533
Fix Runtime Download in Cloud (#49538) 2019-10-28 19:46:20 -05:00
Nathan Reese ce521bb281
[Maps] hide map visualization types with default kibana.yml settings (#49103)
* [Maps] hide map visualization types with default kibana.yml settings

* add docs explaining xpack.maps.showMapVisualizationTypes

* clean up docs

* fix docs build

* fix typescript failures

* move docs to troubleshooting section

* add message about xpack.maps.showMapVisualizationTypes in coordinate map and region map docs

* doc updates based on gchaps feedback

* Update docs/visualize/regionmap.asciidoc

Co-Authored-By: gchaps <33642766+gchaps@users.noreply.github.com>

* Update docs/visualize/tilemap.asciidoc

Co-Authored-By: gchaps <33642766+gchaps@users.noreply.github.com>
2019-10-28 18:30:25 -06:00
Frank Hassanabad a4f37cd9e0
[SIEM] [Detection Engine] Adds filtering abilities to the KQL REST API (#49451)
## Summary

* Removes the older beginner KQL type of signal creation in favor of newer version with filtering
* Adds ability to create KQL or lucene queries that will work with the UI filters
* UI state with the filters are now savable to re-hydrate UI's on the front end
* Adds `saved_id` ability so the UI can tether dynamic saved queries with signals
* Changed `it` to `test` as `it` is not the alias we use for tests 
* Updated script which converts older saved searches to work with newer mechanism
* Fixed script to accept proper ndjson lines
* Adds validation unit tests for the endpoint
* Increases validation strictness of the endpoints
* Adds more data scripts for testing scenarios
* https://github.com/elastic/kibana/issues/47013


## Testing
* Run `./hard_reset.sh` script 
* Test with both algorithms through this toggle before starting kibana:
`export USE_REINDEX_API=true`
* Convert older saved searches to compatible new query filters by running:
`./convert_saved_search_to_signals.sh ~/projects/saved_searches /tmp/signals`
* Post them`./post_signal.sh /tmp/signals/*.json`
* Hard reset again
* Test smaller set of signals and REST endpoints using the typical scripts of:
```sh
./post_signal.sh
./read_signal.sh
./find_signals.sh
./update_signal.sh
./delete_signal.sh
```
or test using POSTMAN, etc... If you want to test validation. If you see any validation issues let me know as I have validation testing files and can easily fix them add another unit test to the growing large collection we have now. 

Change in your advanced settings of SIEM to use your signals index you configured for verification that the signals show up.

### Checklist

Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.

~~- [ ] This was checked for cross-browser compatibility, [including a check against IE11](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility)~~

~~- [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md)~~

~~- [ ] [Documentation](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#writing-documentation) was added for features that require explanation or tutorials~~

- [x] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios

~~- [ ] This was checked for [keyboard-only and screenreader accessibility](https://developer.mozilla.org/en-US/docs/Learn/Tools_and_testing/Cross_browser_testing/Accessibility#Accessibility_testing_checklist)~~

### For maintainers

~~- [ ] This was checked for breaking API changes and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)~~

~~- [ ] This includes a feature addition or change that requires a release note and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)~~
2019-10-28 17:27:39 -06:00
Spencer 69f47a9b90
remove code-plugin specific build task and related node module (#49525) 2019-10-28 15:40:11 -07:00
Mikhail Shustov b6591eb0bd
Provide uiSettings service in NP (#48413)
* provide ui settins client via context

* update mocks

* update types and expose setDefaults to plugins

* move ui settings routes to NP

* add typings fro test kbn server

* move integration test & improve typings

* hide client private methods, update tests

* add unit tests for get_upgradable_config

* inline writeErrors into createOrUpgradeConfig to simplify testing

* regen docs

* add functional tests for ui_settings service

* unify test suites

* add types for sipertest in core_plugin tests

* tsify core_plugins tests

* add test for empty saved config

* update renovate

* rename get/setDefaults to reguster

* regen docs

* regen docs

* Update src/core/MIGRATION.md

Co-Authored-By: Josh Dover <me@joshdover.com>
2019-10-28 16:06:12 -04:00
renovate[bot] 5b375df8e9 Update moment related packages (#46849)
* Update moment related packages

* unify moment version in yarn.lock

* adapt ro pluralization fixes

* update some bad pluralization in fixtures/snapshots
2019-10-28 12:07:35 -07:00
Chris Davies 6d23793489
[Lens] Pass date range to the query bar (#49485) 2019-10-28 15:04:03 -04:00
Ben Skelker e3b6da981b
Fixes title capitalisations (#49445) 2019-10-28 20:26:15 +02:00
Josh Dover 23a9058cc4
Migrate ui/registry/feature_catalogue to New Platform plugin (#48818) 2019-10-28 13:08:30 -05:00
Josh Dover 2d1c239fdd
Migrate necessary ui/autoload functionality to NP (#48689) 2019-10-28 12:58:29 -05:00