Commit graph

43446 commits

Author SHA1 Message Date
Tiago Costa b60a438dd3
skip flaky suite (#100438) 2021-06-14 12:51:58 +01:00
James Gowdy f6ce964d9c
[ML] Switching to new datafeed preview (#101780)
* [ML] Switching to new datafeed preview

* fixing wizard test button

* adding schema validator

* fixing tests

* adding check for empty detectors list

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-06-14 12:31:55 +01:00
Justin Kambic 85710b344f
[Uptime] Add owner and description properties to Uptime's kibana.json (#101963)
Co-authored-by: Shahzad <shahzad31comp@gmail.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-06-14 13:29:46 +02:00
David Sánchez ec2ec6ab40
[Security solution][Endpoint] Removes zip compression when creating artifacts (#101379)
* Removes zlib compression when creating artifacts. Also fixes related unit tests and removes old code

* Replaces artifact in new manifest using the ones from fleet client with zlip compression

* Fixes create_policy_artifact_manifest pushArtifacts missing new manifest. Also fixes unit tests

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-06-14 12:25:42 +02:00
Stratoula Kalafateli 06aaa529d4
[Dashboard]: Fixes disabled viz filter is applied (#101859)
* Fixes filter is applied even if is disabled on a dashboard

* Fix 18n problem

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-06-14 13:04:04 +03:00
Maja Grubic 80b109f95c
[Discover] Deangularization of search embeddable (#100552)
* [Discover] Render empty embeddable

* First version of grid embeddable

* More search embeddable

* Almost stable version

* Fixing typescript errors

* Fixing filtering and sorting

* Add data-shared-item to DiscoverGridEmbeddable

* Trigger rerender when title changes

* Fixing incorrectly touched files

* Remove search_embeddable

* Remove lodash

* Fixing imports

* Minor fixes

* Removing unnecessary files

* Minor fix

* Remove unused import

* Applying PR comments

* Applying PR comments

* Removing search embeddable

* Fix missing import

* Addressing PR comments

* Do not memoize saved search component

* Applying Matthias's suggestion

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-06-14 09:33:58 +01:00
Tiago Costa 012bb4490b
skip flaky suite (#94043) 2021-06-12 16:08:21 +01:00
Tyler Smalley 344b6310d7 skip flaky suite (#102012) 2021-06-12 06:49:27 -07:00
Tyler Smalley f9fbfc508b
[esArchive] Persists updates for management/saved_objects/* (#101992)
Same as #101950 - these archives are causing issues with a non-oss build https://github.com/elastic/kibana/issues/101654

Last remaining fix for https://github.com/elastic/kibana/pull/101118

Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
2021-06-11 20:44:20 -07:00
Tyler Smalley 8ffebe8c75 skip flaky suite (#101449) 2021-06-11 12:18:24 -07:00
Mikhail Shustov c28b5e922b
remove unnecessary hack (#101909) 2021-06-11 19:16:34 +02:00
Shahzad 724ca2d896
[Exploratory View] Use human readable formats (#101520)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-06-11 12:09:24 +02:00
Michael Dokolin 9bcae4d9cb
[Expressions] Refactor expression functions to use observables underneath (#100409) 2021-06-11 09:53:04 +02:00
Tyler Smalley 9c37a6798f
[esArchives] Persist migrated Kibana archives (#101950)
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
2021-06-10 20:47:09 -07:00
Spencer bdaea87aa6
[kbnArchiver] fix save to non-existent file (#101974)
Co-authored-by: spalger <spalger@users.noreply.github.com>
2021-06-10 21:16:15 -04:00
Scotty Bollinger f28777f3ba
[Enterprise Search] Add owner and description properties to kibana.json (#101957)
* [Enterprise Search] Add owner and description properties to kibana.json

Adds owner and description properties to kibana.json

* Reorder to match other plugins

Both others have the props at the end of the file:

https://github.com/elastic/kibana/blob/master/src/plugins/bfetch/kibana.json

Also removes redundant prefix from description

* Copy change

Co-authored-by: Constance <constancecchen@users.noreply.github.com>

Co-authored-by: Constance <constancecchen@users.noreply.github.com>
2021-06-10 20:04:37 -04:00
Lisa Cawley 95604fdd22
[DOCS] Fixes terminology in Stack Monitoring:Kibana alerts (#101696) 2021-06-10 15:48:08 -07:00
Steph Milovic de07e98663
[Observability] [Cases] Cases in the observability app (#101487) 2021-06-10 16:39:27 -06:00
ymao1 b242765654
[Alerting][Docs] Combine rule creation and management pages (#101498)
* Combining rule management stuff into single page

* Cleaning up image widths and header sizes

* Adding in placeholder pages

* Adding in placeholder pages

* Apply suggestions from code review

Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>

* PR and test fixes

* Apply suggestions from code review

Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>

* PR fixes

* PR fixes

Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-06-10 17:46:53 -04:00
spalger a51b4a12e8 temporarily disable build-buddy 2021-06-10 14:37:14 -07:00
Nicolas Chaulet 6df58dd7ca
[Fleet] Fix fleet server collector in case settings are not set (#101752) 2021-06-10 16:32:23 -04:00
Yuliia Naumenko e55a93ce58
[Event Log] Populated rule.* ECS fields for alert events. (#101132)
* [Event Log] Populated rule.* ECS fields for alert events.

* added mappings

* changed the params passing

* fixed tests

* fixed type checks

* used kibanaVersion for version event rule

* fixed typos

* fixed tests

* fixed tests

* fixed tests

* fixed tests

* fixed jest tests

* removed references

* removed not populated fields

* fixed tests

* fixed tests

* fixed tests
2021-06-10 12:33:32 -07:00
Oliver Gupte befd30ff6c
[APM] Fleet support for merging input.config values with other nested properties in the policy input (#101690)
* [APM] Improvments in the APM fleet integration (#95501)

* added unit test and line comment

* fixes eslint issues
2021-06-10 15:27:11 -04:00
Stacey Gammon e9a4028005
Add comments to some alerting plugin public API items (#101551)
* Add comments. Remove ruleType as the second param, not needed.

* Add comments. Remove ruleType as the second param, not needed.

* Fix bad type check and update docs

* update docs

* Remove unused import

* change exports to type to avoid increasing bundle size

* Update x-pack/plugins/alerting/public/plugin.ts

Co-authored-by: ymao1 <ying.mao@elastic.co>

* Update x-pack/plugins/alerting/public/plugin.ts

Co-authored-by: ymao1 <ying.mao@elastic.co>

* Update x-pack/plugins/alerting/public/plugin.ts

Co-authored-by: ymao1 <ying.mao@elastic.co>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: ymao1 <ying.mao@elastic.co>
2021-06-10 15:15:53 -04:00
ymao1 5a1f370580
[Alerting][Docs] Moving alerting setup to its own page (#101323)
* Restructuring main alerting page. Adding separate setup page

* Fixing links

* Moving suppressing duplicate notifications section

* Adding redirect

* Reverting redirect. Adding placeholder link

* Adding placeholder text

* Apply suggestions from code review

Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>

* Setup page PR fixes

* Alerting page PR fixes

* Update docs/user/alerting/alerting-setup.asciidoc

Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>
2021-06-10 15:14:07 -04:00
Stacey Gammon 9417b699b8
remove uptime public API, it's not used. (#101799) 2021-06-10 14:47:55 -04:00
Scotty Bollinger 797c0c90b0
[Enterprise Search] Refactor RoleMappingsTable to use EuiInMemoryTable (#101918)
* Add shared actions component

Both tables use the same actions

* Refactor RoleMappingsTable to use EuiInMemoryTable

This is way better than the bespoke one I wrote and it comes with pagination for free

- Also fixes a typo in the i18n id
2021-06-10 14:20:54 -04:00
Caroline Horn 61677f7a77
Fix AppContainer layout (#101793)
* Fixing app_container
* Use EUI mixin  `euiHeaderAffordForFixed()` to maintain parity
* Adding `aria-busy` when `showSpinner`
* i18n for the loading aria-label
2021-06-10 14:18:35 -04:00
Shahzad ddccace87e
[Uptime] Unskip alert functional test (#101562) 2021-06-10 20:01:21 +02:00
Wylie Conlon 542fe02e1f
Update aggregation reference docs for 7.13 (#101913)
* Update aggregation reference docs for 7.13

* Add more reference about filtered metrics
2021-06-10 13:42:55 -04:00
Scotty Bollinger d7d67df5eb
[Enterprise Search] Create reusable Group and Engine assignment selectors (#101790)
* Create AssignmentSelectors

These components will be used in both the Role Mapping and User flyouts to create and edit role mappings and users, respectively

* Implement AssignmentSelectors in components
2021-06-10 14:36:11 -03:00
Vadim Yakhin a9a834a105
[Workplace Search] Add Account Settings page imported from Security plugin (#99791)
* Copy lazy_wrapper and suspense_error_boundary from Spaces plugin

These components are needed to enable async loading of Security components into Enterprise Search.

The components are copied without any changes except for i18n ids, so it's easier to DRY out in the future if needed.

* Create async versions of personal_info and change_password components

* Create ui_api that allows to load Security components asuncronously

The patterns were mostly copied from Spaces plugin

* Make ui_api available through Security components's lifecycle methods

* Import Security plugin into Enterprise Search

* Add Security plugin and Notifications service to Kibana Logic file

* Export the required components from the Security plugin and
use them in the new AccountSettings component

* Update link to the Account Settings page

* Move getUiApi call to security start and pass core instead of getStartServices

* Simplify import of change_password_async component by providing...
... `notifications` and `userAPIClient` props in the security plugin

* Remove UserAPIClient from ui_api

It's not needed anymore since the components are initiated with this prop already passed

* Export ChangePasswordProps and PersonalInfoProps from account_management/index.ts

This makes it easier to import these props from outside the account_management folder

* Remove notifications service from kibana_logic

It is not needed anymore since we're initializing security components with notifications already provided

* Add UiApi to SecurityPluginStart interface

* Utilize index files for exporting Props types

* Replace Pick<...> with two separate interfaces as it doesn't work well with our docs

* Add a comment explaining why we're not loading async components through index file
2021-06-10 14:20:30 -03:00
Jonathan Budzenski 5ee5720cb7
[plugin cli] Remove settings argument from warnings log (#101824)
The plugin CLI watches for warnings with a function taking the logger as
an argument.  There are two cases where we're passing a settings object
as the first argument, causing syntax errors instead of properly
logging.  This removes the extra argument.
2021-06-10 12:03:37 -05:00
Jonathan Budzenski 00089bf85a skip flaky runtime fields test. #100966 2021-06-10 12:00:38 -05:00
Jean-Louis Leysens 92bd5c6424
[Fleet] Adjustments to the "Add agent" flyout (#101576)
* updated add agent flyout buttons

* move close button to left

* added new optional prop for the add agent flyout and factored out a component from the index.tsx file

* quite a big refactor, moved the agent policy authentication to own component and reused in two places

* fixed layout on view where policy was not selected, also fixed a render cycle

* removed unnecessary filter

* move handler to function body instead of in JSX

* remove unused i18n

* added jest test for agent enrollment flyout steps behaviour

* fix issues after master merge

* Fix bad import in type file

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-06-10 18:17:41 +02:00
Alison Goryachev 7dfb086343
[Upgrade Assistant] Migrate to new page layout (#101691) 2021-06-10 11:50:08 -04:00
István Zoltán Szabó 85fa7c8791
[ML] Adds popover help for multiclass confusion matrix (#101732)
Co-authored-by: Lisa Cawley <lcawley@elastic.co>
2021-06-10 17:37:57 +02:00
Melissa Alvarez 305f12708d
[ML] Anomaly Detection: Visualize delayed - data Part 1 (#101236)
* wip: add datafeed modal for chart

* Add arrows to navigate through time in the chart

* ensure runtime_mapping and indices_options in search query

* move chart data fetching behind single server endpoint

* remove success check as it is not returned in result

* load necessary modal data in modal

* remove extra legend and add text to action icons

* remove unused endpoint and types

* handle job not found and fix types

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-06-10 11:03:17 -04:00
Dima Arnautov ef8eb321cf
[ML] Add usage collection for pages in the ML app (#101886)
* [ML] setup usageCollection provider

* [ML] track page usage
2021-06-10 10:36:14 -04:00
Joe Reuter fe3c761b40
stabilize opening of Lens from listing page (#101569) 2021-06-10 16:30:37 +02:00
Wylie Conlon b35cde568b
[Lens] Formula editor (#99297)
* 💄 Hack to fix suggestion box

* 🐛 Fix validation messages

* 🐛 Relax operations check for managedReferences

* Change completion params

* 🏷️ Fix missing arg issue

*  Add more tinymath fns

* 🐛 Improved validation around math operations + multiple named arguments

* 🐛 Use new onError feature in math expression

* ♻️ Refactor namedArguments validation

* 🐛 Fix circular dependency issue in tests + minor fixes

* Move formula into a tab

* 🔥 Leftovers from previous merge

*  Move over namedArgs from previous function

*  Add tests for transferable scenarios

*  Fixed broken test

*  Use custom label for axis

* Allow switching back and forth to formula tab

* Add a section for the function reference

* Add modal editor and markdown docs

* Change the way math nodes are validated

* Use custom portal to fix monaco positioning

* Fix model sharing issues

* Provide signature help

* 🐛 Fix small test issue

* 🐛 Mark pow arguments as required

* 🐛 validate on first render only if a formula is present

* 🔥 Remove log10 fn for now

*  Improved math validation + add tests for math functions

* Fix mount/unmount issues with Monaco

* [Lens] Fully unmount React when flyout closes

* Fix bug with editor frame unmounting

* Fix type

* Add tests for monaco providers, add hover provider

* Add test for last_value

* Usability improvements

* Add KQL and Lucene named parameters

* Add kql, lucene completion and validation

* Fix autocomplete on weird characters and properly connect KQL

* Highlight functions that have additional requirements after validating

* Fix type error and move help text to popover

* Fix escape characters inside KQL

* 🐛 Fix dataType issue when moving over to Formula

* Automatically insert single quotes on every named param

* Only insert single quotes when typing kql= or lucene=

* Reorganize help popover

* Fix merge issues

* Update grammar for formulas

* Fix bad merge

* Rough fullscreen mode

* Type updates

* Pass through fullscreen state

* Remove more chrome from full screen mode

* Fix minor bugs in formula typing

* 🐛 Decouple column order of references and output

* 🔧 Fix tests and types

*  Add first functional test

* Fix copying formulas and empty formula

* Trigger suggestion prompt when hitting enter on function or typing kql=

* 🐛 Prevent flyout from closing while interacting with monaco

* refactoring

* move main column generation into parse module

* fix tests

* refactor small formula styles and markup

* documentation

* adjustments in formula footer

* Formula refactoring (#12)

* refactoring

* move main column generation into parse module

* fix tests

* more style and markup tweak for custom formula

* Fix tests

* [Expressions] Use table column ID instead of name when set

* [Lens] Create managedReference type for formulas

* Fix test failures

* Fix i18n types

* fix fullscreen flex issues

* Delete managedReference when replacing

* refactor css and markup; add button placeholders

* [Lens] Formulas

* Tests for formula

Co-authored-by: Marco Liberati <marco.liberati@elastic.co>

* added error count placeholder

* Add tooltips

* Refactoring from code review

* Fix some editor issues

* Update ID matching to match by name sometimes

* Improve performance of Monaco, fix formulas with 0, update labels

* Improve performance of full screen toggle

* Fix formula tests

* fix stuff

* Add an extra case to prevent insertion of duplicate column

* Simplify logic and add test for output ID

* add telemetry for Lens formula (#15)

* Respond to review comments

*  Improve the signatures with better documentation and examples

* adjust border styles to account for docs collapse

* refactor docs markup; restructure docs obj; styles

* Fix formula auto reordering (#18)

* fix formula auto reordering

* add unit test

* Fix and improve suggestion experience in Formula (#19)

*  Revisit documentation and suggestions

* 👌 Integrated feedback

*  Add query validation for quotes

* Usability updates & type fixes

* add search to formula

* fix form styles to match designs

* fix text styles; revert to Markdown for control

* 👌 Integrated more feedback

* improve search

* improve suggestions

* improve suggestions even more

* 🐛 Fix i18n issues (#22)

* Persist formula on leave, fix fullscreen and popovers

* Fix documentation tests

* 🏷️ fix type issue

* 🐛 Remove hidden operations from valid functions list

* 🐛 Fix empty string query edge case

* 🐛 Enable more suggestions + extends validation

* Fix tests that depended on setState being called without function

* Error state and text wrapping updates

*  Add new module to CodeEditor for brackets matching (#25)

* Fix type

* show warning

* keep current quick function

*  Improve suggestions within kql query

* 📷 Fix snapshot editor test

* 🐛 Improved suggestion for single quote and refactored debounce

* Fix lodash usage

* Fix tests

* Revert "keep current quick function"

This reverts commit ed477054c5.

* Improve performance of dispatch by using timeout

* Improve memoization of datapanel

* Fix escape characters

* fix reduced suggestions

* fix responsiveness

* fix unit test

* Fix autocomplete on nested math

* Show errors and warnings on first render

* fix transposing column crash

* Update comment

* 🐛 Fix field error message

* fix test types

* 📝 Fix i18n name

* 💄 Manage wordwrap via react component

* Fix selector for palettes that interferes with quick functions

* Use word wrapping by default

* Errors for managed references are handled at the top level

* 🐛 Move the cursor just next to new inserted text

* ⚗️ First pass for performance

* 🐛 Fix unwanted change

*  Memoize as many combobox props as possible

*  More memoization

* Show errors in hover

* Use temporary invalid state when moving away from formula

* Remove setActiveDimension and shouldClose, fixed by async setters

* Fix test dependency

* do not show quick functions tab

* increase documentation popover width

* fix functional test

* Call setActiveDimension when updating visualization

* Simplify handling of flyout with incomplete columns

* Fix test issues

* add description to formula telemetry

* fix schema

* Update from design feedback

* More review comments

* Hide callout border from v7 theme

Co-authored-by: dej611 <dej611@gmail.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Joe Reuter <johannes.reuter@elastic.co>
Co-authored-by: Michael Marcialis <michael.marcialis@elastic.co>
Co-authored-by: Joe Reuter <email@johannes-reuter.de>
Co-authored-by: Marco Liberati <marco.liberati@elastic.co>
Co-authored-by: Marco Liberati <dej611@users.noreply.github.com>
2021-06-10 10:09:16 -04:00
Christiane (Tina) Heiligers 412fe40d74
Uses default distribution for rewriting ids integration test (#101813) 2021-06-10 06:45:37 -07:00
Christiane (Tina) Heiligers 1fe7840ad9
[so-migrations] Integration test fixes: Use default distribution for cleanup fixture creation (#101698) 2021-06-10 06:44:44 -07:00
Michael Dokolin bde81c2090
[Expressions] Create expressions function to get UI settings (#101317) 2021-06-10 15:17:52 +02:00
Marco Liberati 49ea272240
[Lens] Memoize operationMatrix computation (#101745) 2021-06-10 14:53:25 +02:00
Marco Liberati baef85575d
[Lens] Do not use dynamic coloring for array values (#101750) 2021-06-10 14:52:24 +02:00
David Sánchez e0f817c854
Cleans comment state when submiting and when init the store (#101861) 2021-06-10 14:45:38 +02:00
Stacey Gammon b2903e9f8f
Small clean up with Cases plugin API (#101668)
* Clean up public API of cases plugin

1. Don't use export * on index.ts files that define the public API
2. Add comments to the interface show they show up in the API docs
3. Export types that are part of the public API so they show up in the API docs.
4. Fill in information for the up and coming `description` and `owner` items in kibana.json.

* Update returns comments to be more descriptive

* update api docs

* Remove kibana.json attributes, until PR supporting them is merged.

* Change all exports to export type to avoid increase page bundle size
2021-06-10 08:43:07 -04:00
Stacey Gammon 65d3f49f00
address code review comments (#101764) 2021-06-10 08:36:43 -04:00
SoNice! f804585ec7
[FieldFormatters] Human-readable duration inconsistent unit casing (#101479) 2021-06-10 14:16:34 +02:00