Commit graph

16458 commits

Author SHA1 Message Date
Walter Rafelsberger
b709ee989a
[DOCS] Add Kibana Milestones Visualization plugin to list of known plugins. (#15841)
This PR adds a link to the Milestones Visualization plugin (https://github.com/walterra/kibana-milestones-vis) to the list of known Kibana plugins.
2018-01-05 10:08:59 +01:00
Spencer
4dee8fce79
[ui/bundles][optimizer] only use caches when in dev mode (#15780)
* [ui/bundles][optimizer] only use caches when in dev mode

* [optimize/caching] make cache-loader disabling more explicit

* [optimize/caching] clarify why we only want caching in dev
2018-01-04 14:59:49 -07:00
Brandon Kobel
f332c8a3e3
Sharing render-complete (#15574)
* Naively switching to Observables

* Dispatching native renderStart and renderComplete events

* Emitting actual event...

* Removing the visualize debounce

* Fixing unsubscribe

* Dispatching correct event for the metric visualization

* Moving the $scope.$apply to right after the call to render so it does
what it's supposed to

* Switching angularjs attribute name

* Removing the renderStart since it doesn't do anything

* Removing the renderComplete trigger from visualize, since no one listens
at this level

* Using vis.requestError to communicate when there's a request error

* Grabbing the container when creating the observable

* Dispatching renderStart as soon as we can

* Only emitting renderComplete after we wait for a new animation frame

* Can't ignore the first resize, sometimes it's actually a resize

* Use $timeout in visualiationEditor render, it can be in a digest already

* Calling renderComplete in componentDidUpdate as well

* Switching tests to use render-complete

* Fixing peer review corrections from @gammon

* Removing visDiv reference, we don't need it anymore

* Removing requestAnimationFrame

* Removing unused $timeout

* Removing test that was testing an implementation detail

* Adding $timeout.flush

* Moving the failures to the actual tests don't work.

* Deleting tests that weren't running before

* Removing import of removed test

* Consolidating the dispatchRenderComplete/dispatchRenderStart
2018-01-04 15:20:41 -05:00
Peter Pisljar
f7e79da980
refactoring vis uiState (#15709) 2018-01-04 19:04:52 +01:00
Brandon Kobel
e69f5cd8a5
Update color field formatter (#15837)
* Updating color field formatter

* Just using single quotes, back-ticks no longer necessary

* Revising the tests
2018-01-04 10:39:51 -05:00
Peter Pisljar
604787cf50
fixing collapsible side bar editor (#15826) 2018-01-04 15:39:18 +01:00
Brandon Kobel
51c005cf3a
Using ng-src so a request isn't made before angular compiles template (#15836) 2018-01-04 07:38:58 -05:00
Spencer
2aa25e8e02
[server] remove server.getKibanaStats() (#15834)
* [server] remove server.getKibanaStats()

* [clusterManager] support ignoring args passed to process (for tests)
2018-01-03 19:05:47 -07:00
Spencer
e4edbae2d6
[eslint-config-kibana] upgrade to v0.15.0 (#15831) 2018-01-03 10:59:59 -07:00
spalger
7a72506eb9 [eslint-config-kibana] v0.15.0 2018-01-03 10:54:08 -07:00
Spencer
28663f6f8e
[eslint-config-kibana] expand list of restricted globals (#15798) 2018-01-03 10:52:30 -07:00
Nathan Reese
d72c9a57ae
Set list-style-type for list items in markdown-body (#15827)
* fix markdown list style broken by EUI

* apply style to list element instead of item element
2018-01-03 10:35:13 -07:00
Brandon Kobel
4b0a9fc26a
Advanced Settings - Image Input (#15342)
* Beginning to work on image advanced setting type

* Making the maxSize code and UI more user-friendly (hopefully).

* Getting rid of that border, I was using the wrong class

* Displaying an image for the preview

* Not displaying the image if we don't have a value

* Removing no longer used code

* Adding explicit throw in the subscription to make our intents more clear

* Changing some of the Observable style based on  input from the peer review

* Using the maxSizeKB option to enforce the size

* Adding support for no max

* Throwing better errors

* No longer duplicated the multiple usage error message

* Using the maxSize attribute to control the max size of the settings

* No longer using JSON.stringify, it's already a string and that approach
won't really do anything for other data-types

* Extracting validate to it's own method

* No longer hardcoding the maxLength validation in the uiSettings

* Using a Joi schema instead

* Punting on server-side validation for the time being
2018-01-03 11:11:30 -05:00
Søren Louv-Jansen
aec701815c
[KUI] Add defaultValue to KuiToolBarSearchBox (#15797) 2018-01-03 11:01:35 +01:00
Nathan Reese
0465335fbb
replace element selector with class selector (#15702) 2018-01-02 15:23:23 -07:00
Shaunak Kashyap
6397616d5a
Bumping EUI version + updating code for breaking changes (#15815) 2018-01-02 12:05:08 -08:00
CJ Cenizal
ee2fd5b51d
Add caret icon to time field select control. (#15811) 2018-01-02 10:03:35 -08:00
Chris Roberson
6fb7d52386
First pass at applying EUI styles to the index pattern creation page (#15722)
* First pass at applying EUI styles to the index pattern creation page

* PR feedback

* PR feedback

* PR feedback
2018-01-02 10:40:40 -05:00
Nathan Reese
000a431038
Fix z-index and clipping of panels while dragging (#15670)
* fix z-indexing so dashboard panels are below left nav when dragging

* make dragged panel be on top
2018-01-02 08:31:07 -07:00
Matt Bargar
3134a69fcc
Update known-plugins.asciidoc (#14370) (#15806)
Add my new plugin 'Markdown Doc View'. And add sign to my plugin 'Notification Center'.
2018-01-02 09:52:15 -05:00
Spencer
d29a3e2cde
Upgrade eslint (#15796)
* [eslint] upgrade eslint-related deps

* [eslint] remove snake_case destructured keys
2017-12-30 02:03:28 -07:00
Mike Lutz
df6db13875 Adding SPG Conveyor as a known Kibana plugin (#15772) 2017-12-29 11:09:33 -05:00
Shaunak Kashyap
1a467fee15
Adding autocomplete rules for composite agg (#15787) 2017-12-28 11:36:51 -08:00
Thomas Neirynck
a6f7434265
Add svg screenshot comparison test (#15777)
Extend ImageComparator to allow for SVG-comparisons, add sample test in tag-cloud.
2017-12-28 11:21:04 -05:00
Thomas Neirynck
66a6fbfdab
Add more automated map tests (#15507)
Adds screenshot tests for the region maps.

This also closes https://github.com/elastic/kibana/pull/15483, https://github.com/elastic/kibana/issues/13293
2017-12-26 12:13:33 -05:00
Tim Roes
b8dc4cc8a2
Only apply forced max mode when panel is shown (#15752) 2017-12-23 18:40:36 +01:00
CJ Cenizal
17c9f0d1bc
Remove unused pattern-checker directive. (#15756) 2017-12-22 12:08:18 -08:00
Yuri Astrakhan
a1a8aacc22
Upgrade to jQuery 3.2.1 (#15674)
* Upgrade to jQuery 3.2.1

The jquery-migrate showed a number of warnings,
but no errors, so it should be safe to use.

Warnings mostly related to bind, unbind, focus, ...
https://github.com/jquery/jquery-migrate/blob/master/warnings.md

To enable jquery-migrate, I added it to package.json, and added
a require('jquery-migrate') to the webpackShims/jquery.js right
after the require('jquery').

* Breaks in jQuery3: $(window).offset()

* await field.type(), update chromedriver
2017-12-22 12:46:39 -05:00
Chris Cowan
6c92c10b92
Fixes #15501 - Change xaxis formatter to honor dateFormat:tz; fix tick count to accommodate new formatting rules (#15512) 2017-12-21 14:35:42 -07:00
Nathan Reese
c4d5018c43
add button to enter dashboard edit mode from listing page (#15645)
* add button to enter dashboard edit mode from listing page

* do not show actions column when dashboard is in read only mode
2017-12-21 11:57:32 -07:00
Chris Cowan
b445389b79
Revert Resize and FlotChart compontents to 6.0 (#15717)
- fixes #15672
- fixes #14353
2017-12-21 11:21:56 -07:00
Tim Roes
79e134ccb1
Refactor spy panels (#15682)
* Fix design of debug spy panel

* Simplify the debug spy panel

* Fix height of spy content

* Use scope bindings for spy

* Allow modes to be enabled/disabled based on vis

* Make showSpyPanel docs for loader more detailed

* Only show default panels when using courier

* Fix styling of req/resp spies

* Fix title styling in spy panel

* Get rid of visData in spy panels

* Use tabs instead of select box

* Ensure uiState in spy

* Restyle code in default editor

* Remove unnecessary if protection

* Use local scope variable for rowsPerPage

Due to issues with primitive datatype bindings in Angular this anyway
didn't save it correctly back into the variable.

* Pull all logic into spy directive

* Fix bug when closing panel

* Check for minimum chart size

* Skip spy tests for now

* Fix functional tests

* Improve uiState mock

* Create unit tests

* Remove dead scope binding
2017-12-21 12:01:23 +01:00
Chris Earle
592ac5e085
Use auto_expand_replicas to stay green on 1 node clusters (#15694)
This makes use of the `auto_expand_replicas` setting to keep `.kibana` green on one node clusters, which should help to create a better starting experience.
2017-12-20 17:39:36 -05:00
CJ Cenizal
92bafdd47a
Import K6-themed CSS from EUI. (#15725) 2017-12-20 12:35:28 -08:00
Nathan Reese
e515127113
Link to format section of numeraljs page (#15715) 2017-12-20 11:57:51 -07:00
Stacey Gammon
fbb4412a63
Stabilize dashboard view_edit tests post EUI CSS merge (#15689)
* bring back the tests and run 30x

* Remove extra tests
2017-12-20 13:37:18 -05:00
Yuri Astrakhan
1d92807a18
Doc fix: editorController -> editor (#15607)
There is no `editorController` param in createBaseVisualization.
I think `editor` was meant instead.
2017-12-19 21:04:35 -05:00
CJ Cenizal
c55beed24f
Remove testing style guide. (#15699) 2017-12-19 11:28:30 -08:00
Peter Pisljar
4941590354
few enhancements to default sidebar editor (#15619) 2017-12-19 20:27:54 +01:00
CJ Cenizal
3bd256c1c4
Reinstate and skip Dashboard and Visualize tests (#15687)
* Reinstate and skip flaky Dashboard view edit tests.
* Reinstate and skip flaky Visualize gauge chart tests.
2017-12-19 10:23:32 -08:00
Brandon Kobel
c6a1ce4987
Removing axis_label titlePadding magic number (#15691)
* Adjusting the titlePadding because eui uses a different font

* No more magic numbers
2017-12-19 12:59:15 -05:00
CJ Cenizal
7840bd453a
EUI css reset fixes (#15685)
* EUI css reset fixes
* Fix linting errors.
2017-12-19 07:02:42 -08:00
CJ Cenizal
d654fed93e
Migrate all KUI test helpers dependents to EUI test helpers (#15684)
* Migrate all KUI test helpers dependents to EUI test helpers.
* Remove TestSubjects test helper from KUI.
* Remove test helpers from the KUI public interface.
2017-12-19 05:53:28 -08:00
CJ Cenizal
429bf734f9
Migrate all KUI services dependents to EUI services. (#15677)
* Migrate all KUI services dependents to EUI services.
* Remove KUI services from public interface.
* Add KUI deprecation notice to docs site.
2017-12-18 22:20:44 -08:00
CJ Cenizal
b0e25a9466
EUI: Reset CSS #2 (#15657)
* Add EUI v0.0.7 as a dependency.
- Add support for using dark theme EUI CSS in Dashboard.
- Set light theme as the default.
- Add comments to chrome.jade about role of theme node.
- Add (WTFPL OR MIT) to acceptable licenses.

* Remove old reset CSS.
- Remove naked element selectors from base.less.
- Remove Bootstrap resets.
- Remove UI Framework reset.
- Remove unused reset styles from UI Framework.

* Fix CSS regressions caused by removal of CSS reset.
- Replace usage of sr-only with euiScreenReaderOnly.
- Apply euiButtonEmpty classes to the 'Add a filter' button.
- Fix Notification padding and layout.
- Apply euiTabs styles to Timepicker mode tabs.
- Fix layout of Available Fields heading in Discover.
- Add padding to Popular Fields container in Discover.
- Push down Selected Fields heading in Discover sidebar.
- Fix appearance of links in Discover sidebar.
- Fix height of pills in Filter Bar.

* Fix timepicker tests.
- Remove kbn-accessible-click from timepicker buttons.

* Fix functional tests.
- Use byCssSelector inside of testSubjects.find.
- Delete flaky view_edit.js test: 'when time changed is stored with dashboard'.
- Delete flaky view_edit.js test: 'and preserves edits on cancel > when time changed is stored with dashboard'.
- Delete flake Gauge Chart tests. EUI changed the font size, and the text within the gauges doesn't render when the window is too small.
2017-12-18 16:43:32 -08:00
Yuri Astrakhan
1ade6d7c48
Preparing for jQuery 3: size() -> length (#15648)
Per https://api.jquery.com/size/ - .size() is deprecated,
and should be changed to .length

Making this change alone already makes Kibana run with jQuery master.
2017-12-18 14:22:28 -05:00
Stacey Gammon
74c3ddf78c
Investigate flaky add new visualization test (#15506)
* try to repro

* try 30 times

* some clean up and extra tests

Don’t see how this should help, but switch to using data-test-subj and
add a wait until loading line.

Still, I don’t see that it would actually help.

Also it took 50 test run to hit it once, so doubling the amount of
times the test suite runs to improve chances of hitting it.

* Throw the function in a retry

Unfortunately it’s probably not worth investigating why the click
sometimes fails, given how rare it is and that it’s only reproducible
in the test environment.

* Remove extra test loops

* remove skip and check multiple times again

* Fix issue with flaky field toggle selection

* forgot await

* More stabilizations

* Stabilize by disabling toast auto hides on all dashboard tests

* avoid all the retries to see if disabling toast auto hides was what was messing everything up

* remove comment that is no longer relevant

* Remove extra tests
2017-12-18 10:36:48 -05:00
Peter Pisljar
f4ed330399
fixes pie chart size to normal if labels are not applied (#15641) 2017-12-18 15:40:41 +01:00
Peter Pisljar
7c90b859f2
fixes angular vis type so it correctly propagates events up to visualize (#15629) 2017-12-18 08:52:37 +01:00
Tim Roes
4671aa5824
Fix bug where negative time offsets in visual builder will shift x-axis range (#15554)
* Shift negative series before drawing, fix #15553

* Add tests fot TSVB markdown

* Use waitUntilLoadingHasFinished

* Remove forgotten skip

* Switch test order

* Use generic seriesOption

* Rename test from chart to metric

* Use test subj to find metric tabs

* Improve TSVB tests
2017-12-16 11:07:30 +01:00