Commit graph

40055 commits

Author SHA1 Message Date
Robert Oskamp bdca03dcfd [ML] Functional tests - skip DFA clone tests 2021-02-02 09:47:23 +01:00
Justin Kambic c38d9b0011
[Uptime] Fix synthetics detail step count (#89940)
* Add parameter to allow filtering by step type. Write tests.

* Delete unneeded fields.

* PR feedback.
2021-02-02 00:22:05 -05:00
Frank Hassanabad 2e5341d3db
Fixes the permissions to require cluster.manage in order to create an index and in order to update an index (#89947)
## Summary

Fixes error toaster on signals upgrades as well as creation of new signals if you have a user without a cluster manage privilege.

Simplest way to manually test both situations of a user on creating a new signal as well as upgrade is to first create a new role like so in dev tools:

```ts
PUT _security/role/reduced_permissions
{
   "indices":[
      {
         "names":[
            ".siem-signals-*",
            ".lists-*",
            ".items-*"
         ],
         "privileges":[
            "all"
         ],
         "field_security":{
            "grant":[
               "*"
            ]
         },
         "allow_restricted_indices":false
      }
   ],
   "applications":[
      {
         "application":"kibana-.kibana",
         "privileges":[
            "space_all"
         ],
         "resources":[
            "space:default"
         ]
      }
   ]
}
```

You might have to change this line above to match what your `kibana.index` is set to if it is set:
```ts
 "application" : "kibana-.kibana-hassanabad8",
```

Double check things in Stack Management to ensure you have access to at least default space:
<img width="1304" alt="Screen Shot 2021-02-01 at 5 45 54 PM" src="https://user-images.githubusercontent.com/1151048/106536383-906f3f00-64b5-11eb-97d3-060fa6f6206e.png">

Next add a user which has this role of `reduced_permissions` to login as that user. Next for testing that this causes an error toaster when there is no signals index is to either manually delete your signals index or change your `kibana.dev.yml` so that it thinks you have a new index:

```ts
xpack.securitySolution.signalsIndex: .siem-signals-some-new-index-name
```

Start up Kibana, login with the new user and visit any page and notice you get an error toaster like below:
<img width="808" alt="Screen Shot 2021-02-01 at 5 04 17 PM" src="https://user-images.githubusercontent.com/1151048/106535815-4afe4200-64b4-11eb-89b3-947b0e4ff7d5.png">

And also notice that you are blocked from viewing signals at this point:
<img width="1195" alt="Screen Shot 2021-02-01 at 5 04 43 PM" src="https://user-images.githubusercontent.com/1151048/106535835-56516d80-64b4-11eb-883c-2745b68843cf.png">

For upgrading signals manually, you can change the version number from dev tools or increment the number directly within this file and restart Kibana:
https://github.com/elastic/kibana/blob/master/x-pack/plugins/security_solution/server/lib/detection_engine/routes/index/get_signals_template.ts#L10

When you visit the detection page you will see the same error toaster and also be blocked. With this PR you will no longer be blocked.

### Checklist

Delete any items that are not applicable to this PR.

- [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
2021-02-01 21:35:45 -07:00
Devin W. Hurley 0283ca031d
[Security Solution] [Detections] adds log info level for logging in cloud (#89941) 2021-02-01 22:50:42 -05:00
Devon Thomson 151457cd0d
[Time to Visualize] Dashboard By Value Testing Lens (#89581)
* added lens by value tests
2021-02-01 22:38:16 -05:00
Justin Kambic 1712387b8d
[Uptime] Expand synthetic journey step thumbnail on hover (#89179)
* Add desired hover functionality and a test.

* Switch render from img to EuiImage for step view.

* Create new module for ping_timestamp. Extract a function. Add a test.

* Extract nav buttons, translations. Add tests.

* Fix a typo.

* Extract caption to own file. Add tests.

* Extract no image display to dedicated file. Add aria label. Add tests.

* Make import path more explicit.

* Move step image popover to dedicated file. Add tests.

* Clean up inline code in timestamp component.

* Explicit var names.

* Simplicity.

* Fix refactoring issues in test files.

* Move translations to central file.

* Rename test for better accuracy.
2021-02-01 22:00:41 -05:00
Christiane (Tina) Heiligers 09c2ee7203
TS project refs: Migrates snapshot_restore to a TS Project (#89653)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-02-01 18:56:59 -07:00
Brandon Morelli f91d7bf188
docs: APM 7.11 updates (#89789) 2021-02-01 17:03:14 -08:00
spalger 541637993f move skip to higher level (#86952) 2021-02-01 17:52:53 -07:00
spalger f97958043f Revert "Migrations v2: don't auto-create indices + FTR/esArchiver support (#85778)"
This reverts commit 03636a07fe.
2021-02-01 17:46:45 -07:00
spalger e051345765 Revert "Revert "Enable v2 so migrations, disable in FTR tests (#89297)""
This reverts commit 850c03c3a8.
2021-02-01 17:45:54 -07:00
spalger 850c03c3a8 Revert "Enable v2 so migrations, disable in FTR tests (#89297)"
This reverts commit c8afae8a51.
2021-02-01 17:45:24 -07:00
Lukas Olson 29e3886bcd
[data.search] Allow search response to follow new hits format (#88115)
* [data.search] Allow search response to follow new hits format

* Update docs

* Fix types

* Fix types

* Doc updates

* Remove declare module

* Remove declare module

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-02-01 17:06:32 -07:00
Kent Marten 2b0053ab6f
[Maps] Change 'create multi-layer map' title to be use-case focused (#89520)
* [maps] Top hits per entity--change to title to use recent, minor edits

* Updated TopHitsPerEntity title and description to use the term relevant

* Change create multi-layer map tutorial title to be use-case driven

* reverting change to TopHits topic

* Updated title of getting started with maps tutorial

* Updated title of getting started with maps tutorial

Co-authored-by: Kent Marten <kmartastic@users.noreply.github.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-02-01 16:02:20 -08:00
spalger af6ed3f556 skip flaky suite (#86952) 2021-02-01 16:49:27 -07:00
Angela Chuang 69752fab37
[Security Solution] Remove focustrap (#89905)
* remove focustrap

* remove focustrap

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-02-01 23:09:53 +00:00
Scotty Bollinger 0d5554591f
[Workplace Search] Add remaining i18n support for the Content Sources tree (#89910)
* Add i18n for Org Sources

Refactored a bit as well.
- Removed unnecessary variable declarations for constants.
- Removed empty strings for optional props passed to ContentSection

* Add i18n for private sources

* Add router i18n

* Add i18n to SourcesView

* Fix duplicate IDd

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-02-01 16:55:00 -06:00
Spencer 6cf1951b53
[esArchiver] log when migrations complete and we're done loading data (#89938)
Co-authored-by: spalger <spalger@users.noreply.github.com>
2021-02-01 15:51:00 -07:00
Kevin Qualters 3c0d30cbfd
Add --ssl flag to make resolver generator use ssl with kbn and elasticsearch clients (#89873) 2021-02-01 17:34:57 -05:00
Christiane (Tina) Heiligers da28bd214c
TS project refs: Migrates grokdebugger (#89652) 2021-02-01 15:05:42 -07:00
Dmitry 2498f5719f
[load testing] add env vars to pass simulations and repo rootPath (#89544)
* [load testing] add env vars to pass simulations and repo rootPath

* pass simulation to sript as argument

* export GATLING_SIMULATIONS

* fix export

* add validation
2021-02-01 22:33:50 +01:00
Alison Goryachev bae179eb32
[Upgrade Assistant] Fix getFlatSettings() request (#89616) 2021-02-01 15:36:25 -05:00
Larry Gregory 7b06c13087
Prevent autocompleting the username field (#88682)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-02-01 15:31:21 -05:00
Bhavya RM d981391410
Addressing skipped a11y test on home with new data test subjects and redesign (#86531)
a11y tests for home page under default distribution
2021-02-01 15:21:54 -05:00
Nathan L Smith 5884daeba5
Remove circular dependecy between apm and infra (#89739)
* Move `getTraceUrl` in the APM plugin to `getApmTraceUrl` in the observability plugin and use that instead in infra.
* Remove unused APM plugin depenency in infra.
* Use `pathname` instead of `hash` in infra to apm link to avoid unnecessary redirect.
2021-02-01 14:09:33 -06:00
Oliver Gupte 07f8e48692
[APM] Consolidate various throughput calculations to a utility function (#89486) (#89578) 2021-02-01 12:05:56 -08:00
Alison Goryachev 6ea5889687
[Upgrade Assistant] Use kibana version value from core context (#89774) 2021-02-01 14:47:43 -05:00
Christiane (Tina) Heiligers 5c96da1e20
Migrate indexPatternManagement to TS project ref (#89759) 2021-02-01 12:24:07 -07:00
Quynh Nguyen 2f54078aed
[ML] Update cloning for jobs to use exclude_generated (#88898) 2021-02-01 13:06:37 -06:00
Mike Côté 51cfa90dc5
Add support for custom alert ids (#89814)
* Add support for custom alert ids

* UUID v4 also supported

* Change ESO custom id error message

* Update api integration test

* Use errors.createBadRequestError
2021-02-01 14:00:33 -05:00
Spencer 3f96892430
[jenkins/prs] report docs changes url in PR comments (#89454)
Co-authored-by: spalger <spalger@users.noreply.github.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-02-01 11:43:38 -07:00
Mikhail Shustov 4380c49d38
remove type dependency between index_management and fleet (#89699)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-02-01 19:32:55 +01:00
Thomas Neirynck 391ab72be1
[Maps] Add table source for choropleth mapping (#89263) 2021-02-01 12:43:03 -05:00
Sandra Gonzales 16500d89c2
[Metrics UI] remove middle number in legend and adjust calculation of max number (#89020)
* get midpoint of max and min instead of half of max number

* remove middle tick from stepped gradient legend

* use value instead of max values to calculate bounds

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-02-01 12:27:36 -05:00
Christiane (Tina) Heiligers 9787911c5f
Migrates ingest_pipelines to a TS project ref (#89505)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-02-01 10:26:33 -07:00
Jen Huang cb16a5c042
[Fleet] Update data streams mappings directly instead of against backing indices (#89660)
* Update data streams mappings directly instead of querying for backing indices, update integration tests to test with multiple namespaces

* Add flag to only update mappings of the current write index

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-02-01 09:24:12 -08:00
Patrick Mueller e4c344ada6
[data] change KQL node builder to not generate recursive and/or clauses (#89345)
resolves https://github.com/elastic/kibana/issues/88367

Prior to this PR, the KQL node_builder code was using recursion to generate
"and" & "or" expressions.  Eg, `and(foo1=bar1, foo2=bar2, foo3=bar3)` would
be generated as if was specified as `and(foo1=bar1, and(foo2=bar2, foo3=bar3))`.

Calls to the builder with long lists of expressions would generate nested JSON
as deep as the lists are long.  This is problematic, as Elasticsearch is
changing the default limit on nested bools to 20 levels, and alerting already
generates nested bools greater than that limit.
See: https://github.com/elastic/elasticsearch/issues/55303

This PR changes the generated shape of above, so that all the nodes are at the
same level, instead of the previous "recursive" treatment.
2021-02-01 12:22:29 -05:00
Tim Sullivan 8701ac85d3
Deprecate CSV job type (#89794)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-02-01 09:36:49 -07:00
Angela Chuang 9f4dae82c5
[Security Solution] Push new case to the connector when created (#89131)
* init push case

* fix connectorToUpdate

* add unit test

* revert change

* remove useEffect after case created

* add unit test

* add cancel flag

* update unit test

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-02-01 16:35:37 +00:00
James Gowdy 178637ce29
[ML] Fixing saved object authorization check when security is disabled (#89850)
* [ML] Fixing saved object authorization check when security is disabled

* updating to use mode.useRbacForRequest for check
2021-02-01 16:19:56 +00:00
Josh Dover 19332c097a
Deprecate and remove usages of elasticsearch.logQueries (#89296)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-02-01 08:40:25 -07:00
ymao1 57453f1709
Some fixes from backport (#89746)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-02-01 10:17:59 -05:00
Pierre Gayvallet 688b918888
migrate legacy_export plugin to tsproject ref (#89858) 2021-02-01 16:00:48 +01:00
Rudolf Meijering 03636a07fe
Migrations v2: don't auto-create indices + FTR/esArchiver support (#85778)
* Migrations V2 on by default

* esArchiver delete migrations v2 indices

* Fix saved_objects_management api_integration tests

* Try to fix v2 migrations for pre-release builds

* esArchiver delete auto-created v2 migration indices like .kibana_8.0.0

* Try to fix v2 migrations for pre-release builds

* Use require_alias to prevent auto-created saved objects index

* Wrap SO routes until core logs all internal errors

* Fix api_integration tests requiring an empty kibana index

* Delete corrupt saved object from lens archives

* Update docs

* Fix ui_settings tests

* Fix core jest tests

* Fix type errors

* Fix accessibility tests

* Fix plugin functional tests

* Fix api_integration tests after merging in master

* Fix plugin functional tests #2

* EsArchiver: Don't reset ui settings after the .kibana index was deleted

* Fix functional management/visualize tests

* Fix oss security functional tests

* EsArchiver clean task manager indices to fix alerting api integration tests

* migrationsv2 correctly handle unknown saved object type mappings

* Revert "Try to fix v2 migrations for pre-release builds"

This reverts commit a1a1567501.

* Revert "Try to fix v2 migrations for pre-release builds"

This reverts commit a9a935558c.

* Re-enable v2 migrations in tests after merging in master

* Try to fix async dashboard functional test

* Restore UiSettings defaults after emptyKibanaIndex()

* Review feedback: rename test to match behaviour
2021-02-01 15:46:16 +01:00
Marco Liberati c66124e170
[Lens] Make Lens intervals default value adapt to histogram:maxBars Advanced Setting changes (#89305)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-02-01 15:25:16 +01:00
Dario Gieselaar 3255f905c0
[APM] Remove value_count aggregations (#89408)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-02-01 15:14:17 +01:00
Alejandro Fernández Gómez 53637d0158
[Logs UI] <LogStream /> as a kibana embeddable (#88618)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-02-01 14:48:30 +01:00
Walter Rafelsberger fb19aab307
[ML] Data Frame Analytics: Adds scatterplot matrix to regression/classification results pages. (#88353)
- Adds support for scatterplot matrices to regression/classification results pages
- Lazy loads the scatterplot matrix including Vega code using Suspense. The approach is taken from the Kibana Vega plugin, creating this separate bundle means you'll load the 600kb+ Vega code only on pages where actually needed and not e.g. already on the analytics job list. Note for reviews: The file scatterplot_matrix_view.tsx did not change besides the default export, it just shows up as a new file because of the refactoring to support lazy loading.
- Adds support for analytics configuration that use the excludes instead of includes field list.
- Adds the field used for color legends to tooltips.
2021-02-01 12:30:58 +01:00
Marta Bondyra 1b8c3c1dcc
[Lens] Refactor reorder drag and drop (#88578) 2021-02-01 11:54:16 +01:00
Joe Reuter e31b6a8c91
[Lens] Add smoke test for lens in canvas (#88657) 2021-02-01 11:52:57 +01:00