* Convert remaining export default's in ui/public
* Chunk 2
* Part 3
* Part 4
* Part 5
Note: Must check in https://github.com/elastic/x-pack-kibana/pull/938
first
* Part 6
* Part 6
* Part 8
* Part 9
* address code review comments
Previously, when viewing some time series visual builder panels on a
Dashboard and doing a hard-refresh, all the calls to flot_chart.js's
renderChart method were early returning because the resize.clientHeight
and resize.clientWidth were 0; then a call to handleResize was coming
and it wasn't triggering the initial drawing of the chart. This modifies
the logic to keep track of whether the chart has been rendered yet, and
if it hasn't calls renderChart from the resize handler.
* Adding attributes and prefixer to visualization elements for reporting
- adding data-shared-item attribute to visualization element
- Adding render-counter attribute
- Moving inline to reactcss for prefixing; moving inline to less files where applicable
* Fixing reactcss calls
Sharing relies upon appStatus.dirty to determine whether changes
have been made that must be saved. This wasn't being set correctly in
Discover and Visualize when the user first creates a new object and
hasn't saved it yet.
* Move Index Pattern Creation files into create_index_pattern directory.
* Group Edit Index Pattern files in edit_index_pattern directory.
* Make import paths for refresh_kibana_index relative.
* Remove unused field_popularity.html and add_data_wizard.less files.
* Add index.js files for new directories.
* Change index.js exports to imports.
It's possible that the cgroup file is either empty or does not include the referenced cpu/cpuacct paths.
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
The previous behavior was writing empty directories to a separate
location when the plugin installer was being invoked from outside the
main kibana directory.
* Convert default to named exports starting with agg_response code
* Default to Named: Agg Response - Chunk 2
Committing in chunks so I can check test passes
* Default to Named: Agg Response - Chunk 3
* Default to Named: Agg Response - Chunk 4
* Default to named: AggTypes - Chunk 1
* Introduce a custom kibana estlint rule for no default exports
Turn it on only at the level of /kibana/src/core_plugins/public/ for
now, just to keep the PR sizes manageable.
* Don't call functions directly on the import
* Create a packages dir and move the custom rule in there
* Remove copied package.json portions, use minimal info necessary
* [functional_test_runner] replace functional testing tools with custom/pluggable solution
* [functional_test_runner] Convert unit tests to commonjs format
* [functional_test_runner] Fix dashboard test in wrong mode
* [functional_test_runner] Add dashboardLandingPage test subject
* [functional_test_runner] Get Visualize page object
* [functional_test_runner] Fix outdated references
* [functional_test_runner] Fix more outdated refs
* [functional_test_runner] Remove duplicate tests
* [functional_test_runner] Improve test readability
* [functional_test_runner] 😞 So many duplicate methods
* [functional_test_runner] Move mgmt `before` outside toplevel describe
* [functional_test_runner] Settings page obj missing methods
* [functional_test_runner] Add improvements from @gammon
* [functional_test_runner] Fix return statements in async funcs
* [functional_test_runner] Move before() to correct scope
* [functional_test_runner] Add after() hooks to remove index patterns
* [functional_test_runner] Attempt to fix vertical bar chart tests
* [functional_test_runner] Clean up
* [functional_test_runner] Reinstate unit tests
* [functional_test_runner] Set default loglevel back to info
* [functional_test_runner] Replace `context`s with `describe`s
* [functional_test_runner] Better error handling
* [functional_test_runner] Add in new Tile Map tests
* Incorporate changes from master
* [functional_test_runner] validate that every test file has a single top-level suite
* Update contributing doc with link to full doc
* [docs] Spelling and grammar fixes
* docs: writing and running functional tests
* [docs] Move plugin doc to plugin area
* [docs] Housekeeping. Doc in wrong place
* [docs] Remove dup doc file
* [grunt] Only run mocha_setup when running tests, not every grunt task
Previously our plugin installation used over 5,000 file descriptors when analyzing and extracting the archive. To mitigate this, we are moving to a more supported zip library, Yauzl.
In addition to the replacement of the zip library, this refactors the getPackData method. It was extracting the plugin package.json files, reading them, then finally deleting them. This commit performs this all in memory, removing the need for any file system operations during this step.
These changes reduced the installation time by an average of 35%, from 211.18 seconds to 137.8 seconds. The majority of this time is now spent during optimize.
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
* Timepicker step forward/backward should not overlap
This PR fixes the step forward/backward buttons in the timepicker so that the ranges do not overlap. Prior to this PR, if you stepped forward/backward, the new range would include one millisecond of time in both ranges, which could result in documents being visible in both time ranges.
* Add unit for add/subtract methods
* Use better logic for detecting non-default values
* Use a positive name for the boolean function to increase readability
* Adding comment describing conf.isCustom
* Make trash button logic consistent with default text logic
Updates the management screen for index patterns to make the field_stats behavior opt-in rather than the default. Also removes now-inaccurate warning about non-expanded wildcard patterns being non-performant.
* Refactor sorting capabilities
* clean up and comments
* Move to ui_framework/services
- add tests
- address code review feedback
- Include new folders in build output.
* Rename to sortableProperties
Require initial sorted property name.
* fix a refactor miss
* stop importing if JSON parsing fails
* fail early if improper JSON
we expect to get an array of objects, so show an error message if we find something that is not an array
* clarify import error message
* Format the totals row
* Add tests and format count results
* Handle the new metrics better
* Rename variable to isFieldNumeric and isFieldDate
* Add pipeline tests
* Fix timezone issues in tests
