* Remove uiState from dashboard - communicate via the panelState instead
* migrate old app state from the url
* Add comment about migration and why the unused uiStateJSON field is kept around still
* get wiring done for timelion application functional tests
* add tests for expression type ahead functions, arguments, and argument values
* provide argument suggestions when argument name not provided
* updates from cjcenizal review
* [es][savedObjects/index] put template on each savedObject write
The elasticsearch plugin currently checks for the Kibana index on each iteration of the healthCheck, and creates it if it does not exist. This removes that step from the healthCheck and instead, before each savedObject is written to elasticsearch, ensures that Elasticsearch has the necessary index template should the write result in index creation.
The healthCheck still has the `patchKibanaIndex()` logic, which checks the type in the Kibana index and adds any missing types. This step now does nothing when the Kibana index does not exist, and does what it has always done when it does.
* [ftr] remove unused kibanaIndex service
(cherry picked from commit b1ef897dafeb6d43fe279776e44a9d793a389dc3)
* [savedObjects/integration] create now creates kibana index
* [es/healthCheck] remove use of format()
* [es/healthCheck/tests] use sinon assertions
* [es/patchKibanaIndex] test for kibana index missing behavior
* [savedObjects/errors] add tests for EsAutoCreateIndexError
* [savedObjects/config] deprecate and remove savedObjects.indexCheckTimeout config
* use dangling commas consistently
* [ui/error_auto_create_index] fix class names
* [ui/savedObjectsClient] no need to specify basePath
* [eslint] fix linting issue
Also adds some stabilization by refactoring some retries and
expectations.
and fixes a bug that snuck in between two PRS where the pie slice css
changed.
* [ftr/mocha] revert Mocha UI assigments after loading test files
* [ftr] add beforeTopLevelSuite and afterTopLevelSuite lifecycle hooks
* [ftr] add defaultWindowWidth and defaultWindowHeight options
Adds two configuration parameters to the functional test runner which
will set the windowSize before running the tests in any file and
restores the original window size when the tests complete.
Individual test files can set the windowSize within its own before() or
beforeEach() handlers using the same `command.setWindowSize()` command.
* [ftr/assignmentProxy] use better naming
* [ftr] restore initial window size after each suite
* [ftr] improve error message for unexpected suite definitions
* [ftr/remote] remove configuration option, rely on suite-level changes
* [ftr] fix stack manipulation order
* [ftr/remote] write tests for window size management
* Add a couple tests with queries and saved searches linked to visualizations
Fix issue when edit link is clicked too soon and embeddable hasn't finished loading
* attempt to fix flakiness
* remove duplicate lines
* pie labels
* add simple unit test
* fixing dashboard test
* fixing basedo on review
* simplifying conflict resolution
* removing unused code
* cleanup code
* minor changes based on review
* updating option templates to match new design
* updating truncate_labels to work with chars instead pixels
* [eslint] upgrade to 4.10.0
* [eslint-config-kibana] limit jest config to jest test files
* [ui_framework] remove trailing comma from rest-spreads
* [dashboard/tests] tag jest helpers with .test.js suffix
* explicitly import expect.js where used
* [eslint] apply auto-fixes
* [eslint] manually add/wrap some parens for compliance
* [npm] point to local packages for testing/review
* [jest] remove .test extension from jest helpers
* [ui_framework] fix trailing comma removal from 3bc661a1c8
* [packages] upgrade eslint packages
This PR removes the ability to create scripted fields with the expression language. It also adds an error message to the scripted field list page if any expression scripts already exist which instructs the user to convert all their scripts to painless.
* introduce a mechanism to load a dashboard by title is a single one is found, if not, to refill the search box on the listing page
* Make case insensitive and prevent listing page from "blipping" up on the screen before the redirect
* Add tests
* add a test that will fail due to the current TSVB bug
* add a test to catch the latest bug with saved searches
* reorder array so tests pass
* Update tests since the first panel is TSVB and won't have a spy pane toggle
* Don't update panels in state one at a time when layout changes
* Add test that would have caught the bug
* fix test
Hmmm, I thought grabbing the panels the second time would change their
order predictably but seems no. Still unsure if the order is
garaunteed.
* Need to split out merging panel updates action and setting panels
Tests caught this issue, woot.
* Fix remaining setState warnings by not calling getEmbeddableHander in render
* Add an option to add margins between panels
Make it a boolean useMargins to make this even simpler
* Fix issue with undefined not matching false and triggering a dirty state
* add some test helpers and css for plugin use-age
* default to margins on for new dashboards.
* use const variable syntax for margins
* Fix issue with older dashboards being bumped into useMargins: true mode
* Add tests to catch error
* Fix test
* Don't store column and sort state in panel uiState unless explicitly overridden in a dashboard.
* add debug messages
* Elements can go stale between the find by and the click event so wrap in a retry
* fix bad merge with master
* Adding a check to make sure everything is available to render
* Adding some safety
* Fixing a bug with the label
* Adding an additional sleep to wait for the new data to arrive.
* Refactor focus state logic to use the React lifecycle correctly.
* Update KuiPopover snapshots.
* Remove unnecessary isVisible prop from KuiContextMenu.
* Allow user to both tab AND use the arrow keys for navigation.
* Reinstate ability to tab and shift-tab to the title of KuiContextMenuPanel.
* Release focus from Dashboard panel options KuiContextMenu by closing it when you select an option.
* Update KuiContextMenu example to demonstrate best practice of closing the menu when an item is clicked.
* Replace native transitionend event handler with onAnimationEnd React event handler.
* update histogram agg to fetch min and max when search request started
* scale interval when too many buckets are created
* move min and max params into autoBounds param, remove typo in help text
* use decorated property instead of params to avoid changing agg state, add functional test
* remove sleep from functional test
* make args for onSearchRequest functions specific. Add getters and setters for autoBounds to AggConfig. Protect against divide by zero
* add unused arguments with eslint comment
* Initial check in of introducing redux in dashboard
* Use redux-actions and redux-thunks to reduce boilerplate
* Make sure all panels are minimized from the start when a dashboard is loaded - we don't want a panel id from a different dashboard in the state tree on a fresh open.
* Remove unused file
* use classnames dependency instead of manual logic
* First pass on selectors, handleActions, and more segmented reducers.
* Fix bugs with selectors and reducers and add tests that would have caught them.
* Fix issue plus tests
discover was not returning a promise
* Make expanding a panel purely a css modification which avoids all re-renders
* Found another bug with initial state not being set correctly on a hard refresh
* Remove check for change handlers now that the event handler bug is fixed
* rename dashboardState => dashboard for reducers and redux state tree
* Remove unnecessary top level describe in jest tests
* Navigate back to landing page at the end of the newly added test suite
* Fix lint errors
* Stabilize flaky tests by waiting until saved object search is finished loading results
* Don't leak subscriptions to the store.
* use selectors to grab dashboard panel off state.
* Remove use of getState in dispatcher to avoid circular reference and still use selectors
* use spread over object.assign
* No need to pass second param in when the input is simply returned as-is.
Integration tests should go into the corresponding directory under
`test` and should use the appropriate testing framework that is designed
for long-running tests like those. Tests under __tests__ directories
should be fast-running unit tests only.
Integration tests should go into the corresponding directory under
test and should use the appropriate testing framework that is designed
for long-running tests like those. Tests under tests directories
should be fast-running unit tests only.
* [uiSettings] auto upgrade savedConfig doc when missing
* naming tweaks
* fix comments
* ensure that rcVersions are not found within a version
* add some tests for non-single digit versions/rcs/betas
* return the condition, rather than using an if()
* assert that getUpgradeableConfig() is always called once
* [uiSettingsService] remove excess space
* [savedObjectsClient] only attempt to createOrUpgradeSavedConfig once
* [uiSettings/routes/tests] remove unused assert helper
* [functional/console] correct test title
* [ftr/kibanaServer/uiSettings] fix disableToastAutohide timeout
* Adds ability to change index pattern on import
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
* UI changes. Use a table in the modal grouped by index pattern id instead of multiple modals.
* PR feedback
* PR feedback
* PR updates
* Handle skip properly
* Fix error when there were no existing index patterns
* Tests for the new import conflict logic
* Fix invisible filters caused by missing index pattern (#14131)
"invisible filters" occur when the mapping chain throws an error. If a single filter throws an error, the entire chain rejects. As a result, not even the valid filters appear in the filter bar because they never get added to the scope. However the filters still exist in app state and still get sent with each search request.
The most common error occurs when the filter's meta.index property points to a non-existing index pattern. Since this property is only used for looking up field formatters and it is not essential for a working filter, we now fall back on raw values instead of failing if the index pattern is not found. See the PR this one replaces for discussion about other solutions we tried and why we chose to go this route.
* Show query and filter bars even when there's a linked search (#14212)
The query bar used to be hidden in the presence of a linked search because unlike filters, queries didn't get merged when flattening a SearchSource hierarchy. That means a query in the query bar would override the query in the linked search. This is no longer the case. As of 6.0 we include all queries in the SearchSource hierarchy in the final request, so there's no longer any reason to hide the query bar.
Since filters created via a Vis show up in the query bar when Kuery is selected, these filters now appear correctly even when there's a linked search in the vis editor.
Previously when unlinking a saved search visualize would insert the query and filters from the saved search into app state before removing the SearchSource from the hierarcy. This posed a problem because combining two lucene query strings isn't as easy as combing two sets of filters. We decided this behavior was a bit counterintuitive anyway. If the user wants to unlink the saved search, they probably want to discard it, not combine it with their local changes. So I've also updated the unlinking functionality to discard the saved search.
* limit wait time for baselayer (#14047)
* adding scope appy back (#14269)
* remove junk tests (#14191)
* We are using the index pattern id now
* Use the index pattern id here too
* Use an isolated es env for these tests
* Revert "Fix invisible filters caused by missing index pattern (#14131)"
This reverts commit e09d7ad1f9.
* Revert "Show query and filter bars even when there's a linked search (#14212)"
This reverts commit 3aee7c2bf0.
* Revert "limit wait time for baselayer (#14047)"
This reverts commit 44a71071ac.
* Revert "adding scope appy back (#14269)"
This reverts commit 51b6b51aac.
* Revert "remove junk tests (#14191)"
This reverts commit f06c18332b.
* Revert these
* [savedObjects/delete+bulk_get] add failing tests
* [savedObjects/delete+bulk_get] improve 404 handling
* [savedObjects/client] fix mocha tests
* [savedObjects/tests] remove extra test wrapper
* [apiIntegration/kbnServer] basically disable es healthcheck
* [savedObjects/create] add integration test
* [savedObjects/find] add failing integration tests
* [savedObjects/find] fix failing test
* [savedObjects/client] explain reason for generic 404s
* [savedObjects/get] add integration tests
* [savedObjects/find] test request with unkown type
* [savedObjects/find] add some more weird param tests
* [savedObjects/find] test that weird params pass when no index
* [savedObjects/update] use generic 404
* fix typos
* [savedObjects/update] add integration tests
* remove debugging uncomment
* [savedObjects/tests] move backup kibana index delete out of tests
* [savedObjects/tests/esArchives] remove logstash data
* [savedObjects] update test
* [uiSettings] remove detailed previously leaked from API
* [functional/dashboard] wrap check that is only failing on Jenkins
* [savedObjects/error] replace decorateNotFound with createGenericNotFound
* fix typo
* [savedObjectsClient/errors] fix decorateEsError() test
* [savedObjectsClient] fix typos
* [savedObjects/tests/functional] delete document that would normally exist
* [savedObjectsClient/tests] use sinon assertions
* [savedObjects/apiTests] create without index responds with 503 after #14202
* Initial check-in to replace gridster with react-grid-layout and reactify panels
* # This is a combination of 3 commits.
# This is the 1st commit message:
Add margin of error to test determining panel widths
# This is the commit message #2:
use real kibana version when creating panel data. Will make future conversions easier.
# This is the commit message #3:
Fix lint errors
* Add margin of error to test determining panel widths
use real kibana version when creating panel data. Will make future conversions easier.
Move default height and width to dashboard_constants so those that need it don't end up including extra stuff like ui/chrome
* Remove unnecessary _.once when creating react directives in dashboard.js
* Remove unnecessary constructors
* Use componentDidMount instead of componentWillMount bc of async calls, and handle case where destroyEmbeddable is not defined.
* Remove unnecessary null in classNames
* Use loads defaultsDeep instead of Object.assign
* use render* instead of get* for functions returning an element
* use relative css paths
* Use local import path
* Switch to local imports and remove need for plugins path in jest tests
* Improve accessibility of max/min panel toggle icon
* remove unused css
Had to implement this via code
* disable eslint rule for setState in componentDidMount
Am not aware of a better way to handle this, aside from switching to
redux, since it’s recommended not to put async calls in
componentWillMount. Since I plan to investigate redux next, disabling
for now. Open to other’s opinions on the matter.
* Use native map instead of lodash
* Have the grid handle setting the z-indexes of the right reactgriditem
* Make the draggable handle the title, not the whole heading
Otherwise the drag event often takes over click events when trying to
open the panel options menu and it gets really annoying.
* Change from click to mouse down detector in KuiOutsideClickDector so drags also close pop ups.
* Fix mistaken commit
Code from the redux PR snuck into this one.
* Run getEditPath and getTitle async calls in parallel - no need to wait on the return value of one before starting the others.
* Fix tests: update snapshots, add promise returns.
* version being added to panelData in the wrong spot caused isDirty flag to be true when it shouldn't be
* Fix unmounting/mounting problem with panels due to view/edit mode switch
* Fix bug where panels get squashed to one side when view mode is changed while a panel is expanded.
* Update snapshots to match wrong view mode comparison
* Improve naming of a variable
* Fix issue with pop over hiding behind tile maps
* Previous panel.js included ui/doc_table and ui/visualize - needed to include them in the chain for Dash only mode but not in that file.
* Fix bad merge: remove baseline screenshots
* react editor example
* ensure props are not updated
* use new stageEditorParams method to stage parameter changes
* make component stateless
* use terms_vis_editor component
* get add button to work
* update vis controller to display terms input controls
* update componenent when query bar updates
* add functional test
* lay ground work for different control types in single visulization
* make editors for range and text controls
* text control
* implement type ahead suggestor for text control
* add range slider
* some CSS work
* add submit button, move control init functionallity under control_factory
* add custom options for control types
* provide buttons to move controls up and down
* Make ControlEditor component and clean up styling of editor
* styling work
* multi select for terms dropdown control
* add option to disable filter staging, only enable submit button when filters are staged
* clean up range styling
* rename top level vis folder
* cleanup
* move control type select out of each control editor
* dark theme styling
* use ui/public/filter_manager/lib/phrases.js to build phrases filter, add tests to range filter manager
* use savedObjectsClient to get index patterns
* remove text control and add id to controls for react tracking
* ensure fields get updated when index pattern changes
* update PropTypes for react 15.6.1
* update to latest react-select to avoid isMounted deprecation warnings
* fix input controls functional test
* rename termsControl to listControl to be more generic
* add function test for clear button, refactor directory structure
* functional tests for updateFiltersOnChange is true
* fix react-select clipping problem in dashboard
* try clicking option instead of pressing enter to set react-select value in functional tests
* react-select css
* clean up control_editor component, make ListControlEditor component be function
* add jest test for vis_editor component and accessibility
* add decimal places option to range slider
* add jest test for InputControlVis component
* add default to switch blocks, split editor into seperate tabs, use shallow in snapshot tests
* fix race condition in field_select, update index_pattern_select to fetch indexPatterns on each filter
* clean up control initialization
* use htmlIdGenerator to avoid html element id conflicts
* update functional test to support new editor tabs
* finish jest tests for sub componenets
* mark vis as experimental, refactor buttons for better usability
* fix bug in list control where unable to select options containing numbers and options containing commas. Truncate display of long list options
* fix chart types functional test
* fix jest tests, add margin to action buttons
* remove binds from render functions
* experement with native input range sliders
* Revert "experement with native input range sliders"
This reverts commit aed599e88a.
* Use Promise.resolve in tests and replace _createRequest with searchSource.fetch
* add inputs to range control
* [babel] create babel-preset and babel-register modules
* [babel-preset] add comments to babel-preset-env.target choices
* [babel-preset] use more normal BUILT_WITH_BABEL signal
* [babel-register] extended comment about filtering ./src in dist
* [babel-preset] stage of class properties has changed, sorta
index.mapper.dynamic should not be used for 6.0+ indices, so this commit
removes it from the esArchiver mappings.json for kibana
Related elastic/elasticsearch#25734
* Add failing tests
* Add fix by preventing uiState from being directly updated in visualization.
* Add test that would catch error caused by this PR in regards to filter agg
* Fix issue with uiState triggering dirty dashboard state by introducing temporary "sessionState" on a vis
* Click go after toggling the switch
* add more tests to ensure getRequestAggs functions as intented
* Go back to old zoom calculations. Update vis test data
I think because mapCollar is no longer saved in uiState, the save
recenters the data and we get slightly different data points from the
test data. As far as my eye can tell, everything is working as
intended.
* fixes and tests
- incorporate the new init function which fixes the bug where we lose
map bounds data on a fresh save
- add a test that would have caught that
- adjust tests due to bug where map bounds is changing slightly. File
another issue for that separately as it doesn’t actually affect the
users map experience.
* Fix tests
Tests relied on my original logic of defaulting to the saved zoom state
and not relying on uiState, so I went back to that logic. Also found
another bug where mapZoom of 0 was being considered invalid, but it is
actually a valid zoom level.
* Since leaflet upgrade 'path.leaflet-clickable' can't be used to retrieve circles anymore
* Avoid stale element reference
I suspect because the page is changing, you have to keep fetching the
element afresh. I don’t see this error on my local but saw it on
jenkins.
* remove spy select from PageObjects.visualize.getDataTableData
The function is used in the Data Table visualization where the spy pane
select doesn’t exist.
* Use aria-expanded and better labels for agg collapsables
* Fix all agg options collapsables, fix#12892
* Label all vis editor inputs correctly, fix#11859
* Fix broken functional test
* Re-enable filter editor suggestions
* Use search instead of include
* Escape query
* Show spinner
* Use include rather than search
* Add additional regex and explanation for parameters
* Add suggestions API test
* Make sure test actually runs
* Use send instead of query
* Fix suggestions API test
* Create Index Pattern Creation wizard.
- Create a directive for each step in the wizard.
- Reorganize files into conventional folder structure.
- Rename files with more conventional and consistent naming patterns.
- Display indices, partial matches, exact matches.
- Add loading, empty, and success states.
- Add option to include system indices.
* Temp: comment out and mock getIndices functionality.
* Hook up data seaching
* Add for/id connections for form inputs and labels
* Automatically append a wildcard
* Highlight the index pattern in the results
* Ensure we only remove the last character if it's a `*`
* Auto hide index pattern id controls
* Ensure this link is tabbable
* Move the advanced fields down
* Use toggle button
* This shouldn't ever be required
* Revert "This shouldn't ever be required"
This reverts commit b6e31e79308271e7f04ea1d42ce66e32e7aa0612.
* Update based on comments in PR
* Ffew more changes
* Port changes from Tyler's PR, https://github.com/elastic/kibana/pull/13353
* Remove unnecessary file
* Fix broken functional tests
* Copy changes
* Fix functional tests
* Remove loading from the main select, and move to an additional select
* Show help text when loading
* Fix sorting
* Fixing broken functional tests
* Couple changes from PR review
* Ensure input field does not show a red border until touched
* More descriptive and consistent copy
* upgrade leaflet modules to 1.x latest
* fix css for leaflet controls
* update draw options so it is easier to see polygon when drawing
* fix chrome touch issues with closing polygon in leaflet draw
* use canvas renderer
* use leaflet-responsive-popup to avoid tooltip cutoff
* remove radius configuration from leaflet heatmap
* make blur a factor of radius. Set maxZoom to map zoom since new values are calculated per precision
* use _.get to avoid error, cannot read property of undefined
* add cluster size slider
* experiments with image differences
* onload not onLoad
* use canvas dimensions
* compare map canvas to stored PNG of map canvas
* remove pixelmatch from project dependecies
* fix broken test - rounding error
* add expected image tests for geohash layers shaded circles and geohash grids
* bump z-index of vis-spy
* update functional test expected data
* update to leaflet 1.2.0
* revert to leaflet 1.0.3 and update expected data set for map functional tests
* test geohash_layer heatmap in unit test
* update region_map functional test since it can not longer pluck map vectors from DOM
* update documentation
* add markdown functional test
* update markdown vis to use markdown-it
* migrate markdown angular filter to markdown-it
* place other uses of marked and remove dependency
* update breaking changes documenation and set linkify to true
* Make table pagination controls keyboard-accessible. Update KuiLink so it can be used on a button element.
* Add additional properties to link mixin to make kuiLink look the same for both buttons and anchor tags.
* Fix tests.
* [SavedObjectClient] emit detectable errors
* [uiSettingsService] consume new SavedObjectsClient errors
* [SavedObjectsClient] expose errorTypeHelpers as such
* [elasticsearch/tests] recreate error for each test
* [http] wait for elasticsearch plugin to be ready
* [shortUrl/tests] ensure that create request responds with 200
* [shortUrl] use errorTypeHelpers to filter errors
* [uiSettings/savedObjectsClientStub] stub errorTypeHelpers
* [SavedObjectsClient/errors] expose error module so tests can make errors
* [shortUrl/tests] use actual SavedObjectsClient errors
* [uiSettings/savedObjectsClientStub] use actual errors lib
* [SavedObjectsClient] use decorate instead of "wrap"
* [server/routes/uiSettings] refactor routes to forward Boom errors from uiSettings
* [uiSettings] colocate routes and service
* [testUtils/esTestCluster] use more standard api style
* [testUtils/es] add createCallCluster util
* [testUtils/esTestCluster] add getters for client/callCluster
* [es/healthcheck] ensure that healtcheck stops when server is stopped
* [uiSettings/routes] add param/payload validation
* [uiSettings/routes] add tests that verify error behaviors
Fixes#12639
It's now possible to tab to each filter's actions and interact with them via the keyboard.
In order to get the actions to show/hide on both mouse hover and action focus I had to create a new filter-pill component that could manage a bit of state to track whether the user was interacting with a given pill or not.
* Use find service instead of remote which doesn't have built in safety checks for stale elements
* use data-test-subj instead of id
* add missing function and awaits
* Did not realize WebElements could find descendants
Added some extra functionality for this in find and testSubjects
service, and using in the one place it’s required.
* Move dashboard panel rendering logic to each registered type.
* Remove dashboard knowledge of click and brush handlers for visualizations
Move it to the VisualizeEmbeddableHandler.
* merge master with manual changes
* No need to use lodash
* Add EmbeddableHandler base class
* Use correct path to embeddable_handlers_registry
* clean up
* Set visualize scope uiState that is of type PersistedState, otherwise it won't actually be set.
* add retry to loading saved search data
* Fix handleError param and remove unnecessary private param
* Rename savePanelState updatePanel and return the new object rather than mutating the original
* Make ContainerAPI a base class and move the dashboard specific functionality into a new class
* Make api's async and clean up documentation
* Fix panel tests
* Fix bug which broke tests - need to pass container-api to dashboard-panel
* Address code comments
- Rename onFilter to addFilter
- Use angular promises instead of async/await
- fix jsdoc
- rename createChildUiState to getInitialState
* changed the wrong variable name
* no need for async or Promise.reject on interface
* add tests that will fail due to spy pane issue in this PR
* Fix logic with spy pane toggle
There is still a bit of a bug here as mentioned in
https://github.com/elastic/kibana/issues/13340 but it will be fixed
separately as it’s also an issue in master
* Fix failing test
* Use ui-select for agg selector
* Fix functional tests
* Fix functional tests
* Fix test
* Fix visualize page object
* Use sortPrefixFirst in agg selector
* Fix unit tests
* Fix unit test
* Use not(.ng-hide) rather than last-child
* Make sure no one can show the chrome if the default setting is hidden.
add tests
Fixes https://github.com/elastic/kibana/issues/13040
* Improve variable and function names and fix tests
* update paginated table headers with columns update
* remove unneeded sleep
* update getDataTableHeaders to preffered format
* use data-test-subj attribute for functional tests instead of CSS selectors
* [es/tests] remove unused module
* [testUtil/es] add utility for starting es nodes in tests
* [ftr/tests] use esTestCluster util to start es
* [es/tests/routes] use esTestCluster to start own es
* [testUtils/kbnServer] disable uiSettings unless plugins are enabled
* [testUtils/esTestCluster] use standard test es port by default
* [server/http/tests] add esTestCluster to setup
* [test/config] unify es test config into a single module
* [testUtils/esTestCluster] directory is no longer configurable
* [testUtils/esTestCluster] throw when es.start() is called again without es.stop()
* [testUtils/esTestCluster] is* checks should not mutate state
* Ensure that conflict fields can be searchable and/or aggregatable in the UI
* Use `some` instead of `reduce`
* Revert UI changes
* Attempt to convert multiple ES types to kibana types, and if they all resolve to the same kibana type, there is no conflict
* Add comma back
* Cleaner code
* Add tests
* Update failing test to handle searchable and aggregatable properly
* Add functional test to ensure similar ES types are properly merged
* Update tests
* Revert shard size
* Stabalize tests and bring back flaky test
* Try to fix flaky map radius visualize test
* fix flaky tile map zoom test
* Try to fix flaky zoom test by avoiding zooming in and out with spy panel open
* Remove duplicate wrapped retry around find methods
The retry was moved internally, around a check for stale elements as
well, so this should no longer be neccessary.
* ensure timezone attribute is adhered to
Two issues - one the archiver was loading the visualize mapping after
the config setting so it was bring overwritten, and two,
uiSettings.replace wasn’t working correctly to begin with.
* extra line to ensure server is stabilized to prevent transitory failures
* remove inline awaits
* testSubjects.find now always returns a promise, so we need to make sure there is no more inlining
* more find conversions
* need to pass property name
* Make sure async functions are awaited on.
* add time to toggleSpyTable to give time for tab to open and map to adjust
* make open and close spy panel functions that retry until panel is in correct state
* filter geo hash agg - merged with vis refactor
* get collar size from geohash aggregation
* fix getBounds
* add test for _buckets to handle single bucket case
* use _getGeoHashAgg to update precision
* call reload when map bounds outside of map collar
* update fit control to use geo_bounds aggregation metric
* remove geo_hash param collarScale
* fix precision parameter test
* refactor _geo_hash.js test for readability
* do not trim map bounds
* only change aggregation state when data needs to be refected because zoom changed or map bounds are outside of collar
* remove extra geo_utils.js file from tile_map plugin
* only filter geoJson layer on client when results are not filtered on server
* set up layer options before creating geoJson layer
* add updateExtent back
* add getUntrimmedBounds, clean up filter option verbage, remove scale param from scaleBounds function
* move check for server-side filtering for updateExtent into geohash_layer
* move fetchBounds to geohash_layer
* fix _tile_map functional test, response data is different because of added filter aggregation
This updates the function tests by:
Changing logstash_functional's _type from docs (changed in #13001) to doc.
Adding the original _type (apache or nginx) as a new field named type to logstash_functional's documents.
Updated the mappings to include the expected type field.
Did the same for makelogs by removing _default_ and other _types in favor of doc and the new type field.
Dropped the single_type setting from makelogs.
Updated associated tests that were looking for _type values of apache and nginx.
* Remove field_stats pre-flight option for index patterns
This feature was originally added to make searches against Elasticsearch
more performant when searching across many indices, such as when dealing
with daily indices that have accumulated for years. Elasticsearch now
automatically optimizes index access once a certain amount of shards are
in play, so Kibana doesn't need to hack its own solution.
This option can be removed entirely as existing index patterns that had
this option configured will degrade gracefully.
* test: fix parse error test to account for multiple shards
* [elasticsearch] patch mappings that are missing types
* [elasticsearch/healthCheck] fix tests
* fix doc typo
* [tests/functional/dashboard] fix suite name
* [es/healthCheck/ensureTypesExist] limit randomness a bit
* [test/functional] update es archives with complete mappings
(cherry picked from commit 929aa8efae)
* Index pattern is created, by default, with a random ID by Elasticsearch
* Updated all references requiring the pattern itself to use indexPattern.title
* Advanced options toggle added to index pattern creation page to provide a specified ID
* If an index pattern does not exist, the user is given a link to create a pattern with the referenced ID.
This reorganizes the internals of Visualize. The main contributions are:
- separation of Editor from Visualization. This allows users to create editors separate from their Visualization. Both Timelion and TSVB are examples of visualizations not using the sidebar editor
- no longer restricted to just use angular as a rendering technology
- introduction of API object, which avoids the need to pull in modules directly, like time-filter or filter-bar
* converting Vis to es6 class
* <visualize>, <visualization> and <visualization-editor>
* editor, responseHandler and requestHandler registries
* updating visualize editor app
* vis, default editor, request handlers and vis types
* updating vis types
* updating kibana to work with new visualize
* migrating existing visualizations
* fixing bugs with rebase
fixing tests
fixing tsvb auto apply button
fix tsvb resizing issue
update scope.$apply for react editor components
re-render react component when vis.params are updated (#12347)
fixing heatmap
remove obsolete maps_renderbot indirection
remove cruft/ remove custom resizing and hook into global event
fixing brush event
fixing resize event for vislib_vis_type
fixing legend
changing based on nathans review
* fixing tests
* fixing renderComplete issues with editor
* map updates
* fixing maps zoom
* fixing based on nathans review
* fixing render complete issue and doulbe rendering with maps
* trying to get maps in order .... wip
* removing resize method from visualizations
* changing the rendering process a bit
* fixing metric chart type auto changing
* minor simplifications in coordinate map viz
* more simplications now we only have single render
* minor fixes
* do not recreate layer when not necessary
* minor changes
* fixing maps bounding box filter
* fixing desaturation option
* fix zoom settings when toggling between WMS/basemap
* adding status to the render method (to figure out what changed)
* fixing legend open icon going out of page
* skip index selection for timelion
* timelion brush fix
* fixing circular json issue
* fix faulty rebase
* fixing updateStatus
* removing timelion requesthandler registration
* removing double slash
* fixing maps
* add debug statement
* test CI with guard statement
* fixing rebase
* show the spy toggle in an expanded panel on hover
the css was wrong because the expanded panel is no longer inside
gridster. Added tests that would have caught this.
* rename toggleSpyPane to toggleSpyPanel
This fixes issues where properties from the visualizations saved in older versions were not applied to the Visualization.
This also addressed the fontSize of metrics not being applied on the Dashboard.
* provide getFormat function to date_histogram
* move format object creation to time_buckets
* fix broken test
* pass getConfig to field format constructor since field formatters no longer manage config themselves
* fix _agg_config testing of agg without getFormat method. Old test used date_histogram which now has getFormat, so needed a new agg type
* update expect values for area chart data
* fix expect for visualize app vertical bar
* fix expect for visualize app heatmap chart
* [indexPatterns] remove support for time patterns
* Revert "[indexPatterns] remove support for time patterns"
This reverts commit 4263e37c66.
* [indexPatterns] remove ability to create time-based patterns
* [indexPattern/routes] fix export of routes for stub
* [Storage] export Storage class for testing
* [indexPatterns/unsupportedTimePatterns] add tests
* [indexPatterns] focus warning check module
* [indexPatterns/tests] fix method name
* add metion of this change to migration docs
* disable warnings by default until we have a migration tool
* prevent the warning from disapearing
* fix grammar
* enabled warnings in the tests
Recolor Kibana for Accessibility. Attempt to clean up spacing / layout irregularities by adding some level of global variable control. Major changes are:
* better animation against login
* switch to colored kibana logo
* add docs for secondary buttons in kui, addjust hover states
* simplify focus states
* adjust svg rects for discover graph to be lighter
* add ui select overwrite file, adjust new filter selector to match palette changes
* make spy usable in discovery
* panel withHeader removed completely, tests updated
* force timeout, logs indicate that pings are getting stuck
(cherry picked from commit ff6a71819be272253d969a0be681dc9749a0f00d)
* actually reject the promise
* Preserve the saved vis url when using the add new vis link from dashboard
Fixes https://github.com/elastic/kibana/issues/11078
* Store the edit url in browser history as well
* Fix tests by reordering them.
* add a more explanatory comment
* Revert "When on an embedded page, bypass Getting Started gate check (#12040)"
This reverts commit 05293f1c8d.
* Revert "Making tweaks. (#12003)"
This reverts commit aa3fa06f61.
* Revert "Functional tests for the Getting Started page (#11850)"
This reverts commit 099178a7ca.
* Revert "Prevent flicker on Getting Started page (#11826)"
This reverts commit c4b3ade27d.
* Revert "Getting Started page (#11805)"
This reverts commit 32eff371f2.
* Remove check for Getting Started page from navigateToApp
* [indexPatterns] support cross cluster patterns
* [vis] remove unused `hasTimeField` param
* [indexPatterns/create] fix method name in view
* [indexPatterns/create] disallow expanding with ccs
* [indexPatterns/create] field fetching is cheaper, react faster
* [indexPatterns/resolveTimePattern/tests] increase readability
* [tests/apiIntegration/indexPatterns] test conflict field output
* [indexPatterns/fieldCaps/readFieldCapsResponse] add unit tests
* [test/apiIntegration] ensure random word will not be valid
* [indexPatterns/ui/client] remove unused import
* remove use of auto-release-sinon
* [indexPatterns/create] don't allow expand when cross cluster
* [indexPatternsApiClient/stub] use angular promises
* [indexPatterns/create] add tests for base create ui behaviors
- Users can now create choropleth maps. This requires configuring an inner join between the results of a term-aggregation and a reference vector layer. This vector layer needs to be in the GeoJson format. By default, Kibana uses vector layers serverd by a data service hosted by Elastic. Users can also bring in their own layers by adding configuration entries in the kibana.yml. These need to point to a CORS-enabled data service that accepts requests from the Kibana application.
- For clarity, the tilemap is renamed to Coordinate Map.
- A new manifest is published by Elastic. this includes metadata for the available tilemap services, as well as metadata for the available vector data layers.
* attempt to fix dashboard view/edit flaky test
hope to fix https://github.com/elastic/kibana/issues/12014
* Need to wait for global loading indicator to be hidden once top nav is visible
* use Error object for throw
* inline function only used once
* gauge chart
* adding ranges and color options
* adding green to red color pallete
* adding more options
* fixing based on tanya's review
* fixing label positions
* improving range settings
* percentage mode applies to legend
* hidding labels when too long
* updating based on ui rview
* rebasing on master
* adding unit tests
* adding selenium tests
* fixing tests
* adding metric gauge type
* removing metric vis
* adding metric and goal charts
* updating options
* fixing bugs
* fixing based on review from Thomas
* updating icons
* fixing tests
* updating based on last review
* hide some settings if only one range
* fixing tests
* removing unsupported aggs
* fixing defaults
* fixing options
* fixing error with inverse color schema
* adding spacing to info icon
* fixing some tiny issues
* [indexPatterns/field] replace mapping awareness with readFromDocValues
* move link to more details to proper location
* Address kjbekkelund's feedback
* let the prs speak for themselves
* Implement a way to hide write controls from dashboard
* Add roles definition to the saved dashboard object
* Remove roles from dashboard
* Use an angular provider to control the hideWriteControls flag
* Add an api to chrome to show only a single app by id
* Refactor injectVars logic
* Fix tests
* Refactor kibana root controller
* add additional test functionality
* Missed a couple spots for hiding edit controls
* add retry and help text for dash only mode failures
See if it helps. Tests pass locally.
* Move element into screen when clicking
* use shorthand for object creation
* Hide checkboxes, show 'no dashboard' message with the button
* Adding some more functionality to the Getting Started page object
* Using optOut method from Getting Started page object
* Adding functional tests for Getting Started page
This set of tests specifically tests the scenarios under which a user should or should not get redirected to the Getting Started page
* Adding log.debug message
* Conforming to HTML style guide
* Using new GettingStarted page object methods + opting out
* Adding test for nav being shown
* Removing unnecessary line
* Navigate to Discover expecting to be redirected to the Getting Started page
* Trying beforeEach instead of before
* Remove LS data index + load empty kibana index
* Removing unnecessary line
* Fixing order of operations
* Introduce Clone feature in view mode
* Use a new react modal for cloning dashboards
* Fix focus issues and tests
Unfortunately can’t run jest tests outside of the ui_framework at this
time.
* Add tests for dashboard clone modal
* move the jest tests out of the __tests__ directory
It’ll cause failures for the normal unit test runs
* use react instead of angular for overlay and loading of dom element
* Append 'Copy' to the title in the clone dialog so by default it doesn't clash
* address code comments
* [tests/functional] automatically opt-out of getting started page on navigation
* [test/functional/commonPage] avoid circular reference
* [test/functional/commonPage] move check for getting started after url has settled
* [gettingStarted] prevent route resolution by returning halt promises
* [test/functional/commonPage] wait for kibana to load before checking for getting started
* [uiRoutes/setupWork] provide a token that can be thrown to halt setup work
* [ui/routes] rename reference to WAIT_FOR_URL_CHANGE_TOKEN
* address review feedback
This adds the ability to display a filter bar in the Context view and to apply those filters to the queries. It also modifies the link from the Discover view to the Context view to copy the currently defined filters when switching. New filters can be added from within the Context view using the icons in the expanded detail rows.
* fix focused button not being set
Need to do it in a timeout because ng-react hasn’t loaded the react
code yet, so it can’t find the buttons.
* add a test
that would have caught the issue, and also change the default focused
button for the listing delete page since it’s a destructive action.
* Add a comment
* Push focusing of default button into react code
* Push ESC key handling into react as well
* Remove ESC tests in angular form
They don’t pass, I’m guessing because of the way it’s triggered, but
these test cases should now be handled in jest. Also confirmed it
works as expected with the modal.
* Address code review comments
* Use autoFocus
* Getting Started page (#11673)
* Initial code
* Renaming files/folders
* Notes and changes from HTML/CSS review
* CSS changes
* Fixing transform units
* Fleshing out logo circle
* Adding logos
* Un-nesting styles
* Adding kuiText class on <p> elements
* Making shield icon 404 go away
* Using trustAsHtml filter; using registry
* Adding code for registry
* Adding images
* Hooking up the opt-out link
* Fixing linter issues
* Fix issue with refresh bringing back nav
* Removing load_default module
* Use GETTING_STARTED_ROUTE constant
* Allow topMessage to be a directive
* Adding kuiLink CSS class to anchor elements
* Adding alt text to images
* Replace getters with regular methods
* Remove leftover comment
* Removing unnecessary comment
* Fixing typo in comment
* Adding comments for message properties
* Fixing typo in method name
* Defining custom CSS class
* Fixing method call
* Creating custom CSS classes
* Adding documentation links
* Use a instead of button for demo link
* Allow directives in manage and monitor messages
* Refactoring shared code into single ui/public/getting_started folder
* Adding README
* Fixing whitespace in/around links
* Trim messages before setting them
* Decorate in-app links with opt-out attribute
* Opt out of the Getting Started page if the user already has index patterns
* Adding more commentary around expectations of setTopMessage use
* Using ng-src and ng-href attributes where attr values are angular expressions
* Importing the directive before using it
* Using ui/registry for message registries
* Renaming service => helpers to clarify intent
* Adding explanatory comment
* Adding "or"
* Fixing div id
* Breaks out the inject logic into another directive
* Adding Getting Started page object for functional tests
* Consolidate into one registry
* Fixes incorrect classes
* Changes how styles are applied to injected-items items
* Modifying class name per CSS style guide
* Adding getting started doc link
* Removing unused import
* Attempting to fix breaking build
Apparently the Getting Started page is preventing access to Console (Dev Tools, really) so the functional tests for Console are failing. This commit opts the user out of the Getting Started page before attempting to navigate to Console.
* Cleanup on aisle testbed! (#11765)
* Navigate to getting started page so we can opt out of it
* Initial code
* Renaming files/folders
* Notes and changes from HTML/CSS review
* CSS changes
* Fixing transform units
* Fleshing out logo circle
* Adding logos
* Un-nesting styles
* Adding kuiText class on <p> elements
* Making shield icon 404 go away
* Using trustAsHtml filter; using registry
* Adding code for registry
* Adding images
* Hooking up the opt-out link
* Fixing linter issues
* Fix issue with refresh bringing back nav
* Removing load_default module
* Use GETTING_STARTED_ROUTE constant
* Allow topMessage to be a directive
* Adding kuiLink CSS class to anchor elements
* Adding alt text to images
* Replace getters with regular methods
* Remove leftover comment
* Removing unnecessary comment
* Fixing typo in comment
* Adding comments for message properties
* Fixing typo in method name
* Defining custom CSS class
* Fixing method call
* Creating custom CSS classes
* Adding documentation links
* Use a instead of button for demo link
* Allow directives in manage and monitor messages
* Refactoring shared code into single ui/public/getting_started folder
* Adding README
* Fixing whitespace in/around links
* Trim messages before setting them
* Decorate in-app links with opt-out attribute
* Opt out of the Getting Started page if the user already has index patterns
* Adding more commentary around expectations of setTopMessage use
* Using ng-src and ng-href attributes where attr values are angular expressions
* Importing the directive before using it
* Using ui/registry for message registries
* Renaming service => helpers to clarify intent
* Adding explanatory comment
* Adding "or"
* Fixing div id
* Breaks out the inject logic into another directive
* Adding Getting Started page object for functional tests
* Consolidate into one registry
* Fixes incorrect classes
* Changes how styles are applied to injected-items items
* Modifying class name per CSS style guide
* Adding getting started doc link
* Removing unused import
- Add aria-label to Tile Map visualization's 'Fit Data Bounds' button.
- Add aria-label for Visualize Editor sidebar index pattern.
- Add aria-label to Time Series Visual Builder Annotation icon options.
- Add aria-label for Time Series Visual Builder AggSelectOption.
- Add aria-label to Time Series Visual Builder Annotation selected icon option.
- Adjust aria-labels for Heatmap visualization options.
- Adjust aria-labels for ValueAxes add and remove buttons.
* [tests/functional] move screenshots to their own service
* [ftr] add testFailure and testHookFailure lifecycle hooks
* [tests/functional/screenshots] cleanup old screenshots at startup
* [test/functional/screenshots] take screenshots when tests fail
* [cli_plugin/install] fix test
* [ui/scanner] fix test
When a user configures a WMS, we should not use the zoom-settings from the manifest. These depend on the user's license level, and are not relevant when using a 3rd party WMS service.
* [indexPattern/create] fix test subject
* [indexPattern/create] only auto-select when there is more than one time field
* [indexPatterns/create] describe weird timeField auto-selection
* [indexPattern/create] update no-date-field text
* restore functional test changes in 02787e3df5
* Hide the second toast when adding a new visualization straight from dashboard
* fix tests that assume two notifications
* fix another tests that assumes two toasts
* using ui-select for field selection in visualize
* adding a limit and infinite scroll
* fixing based on CJ's comments
* Add sort prefix first utility
* Add sortPrefixFirst tests
* updating uiSelect to use the new filter
* rebasing on master
* adding uiSelect to top hits sort-on input
* fixing tests
* Create CollapseButton component class to standardize appearance of this button.
* Fix positioning of LocalSearch icon.
* Update collapsible-sidebar directive and Discover page object to use test subject selector.
* Refactor 'closed' class assignment.
* [ftr] remove digdug, use chromedriver directly
why?
- digdug is meant to be used by intern, and expects a certain lifecycle that the FTR has tried and continuously fails to mimic
- rather than continue trying to force digdug into the stack, just spawn chromedriver ourselves. We know how to handle it
- cleans up verbose remote logging while we're in there, since selenium-standalone-server went with digdug, which was previously doing the verbose logging
- deprecate config.servers.webdriver
- add config.chromedriver.url
- if url at config.chromedriver.url points to a server that responds to http requests use it as the chromedriver instance, enables running chrome in a VM or container
- if pings to config.chromedriver.url fail a local chromedriver is started
* address review requests
* Change expected data to match change in table UI
* fix more expected results for data UI change
* Revert one previous change and fix one other test
* fix last issues
* missed splitting the last array element
* missed splitting the last array element
* [git] ignore the entire root optimize directory
* [ftr] fix readConfigFile export
* [ftr/config] set default hostname and protocols for urls
* [chrome] make top-level chrome a test-subject
* [ftr/CommonPage] only auto-login when not navigating to the login page
* Removing "Index contains time-based events" checkbox
* Rename label
* Adding "No Time Filter field" to time field select list
* Using translation for i18n and consistency with label on create form
* More useful verbiage
* Updating copy
* Adding help block below select for added clarity
* Removing functional tests that used time-based events checkbox
* s/INDEX/INDICES/ to be reflect reality
* Fixing logic error
* Updating functional test to match new behavior
* Use controller property instead of inline expression
* More readable variable name
* Migrate Console to kuiButton.
* Convert angular-bootstrap Timepicker and Tabs components to use kuiButtons.
* Convert Timelion to use kuiButtons.
* Convert Visualize and visTypes to use kuiButtons.
- Convert Heatmap vistype to use kuiButtons.
- Convert Visualize editor, AggTypes controls, and Heatmap options to use kuiButtons.
- Convert VisType control rows_or_columns to kuiButton.
- Adjust formatting of kuiButtons in AggTypes controls and Heatmap options.
- Convert Visualization save prompt to use kuiButtons.
- Convert visualize legend to use kuiButtons.
- Convert Visualize Spy to use kuiSelect instead of Bootstrap buttons.
* Convert Notify to use kuiButtons.
- Fix appearance of Notifier countdown.
* - Convert Dashboard to use kuiButtons and kuiMenuButtons.
- Convert Dashboard save panel to use KuiButtons.
* Convert Discover sidebar to use kuiButtons, and have an improved UX and accessibility.
- Convert Discover field chooser to use kuiButtons.
- Convert Discover no-results to use kuiButtons.
- Convert Discover save panel to use KuiButtons.
* Convert filter bar to use kuiButtons.
* Convert fatal splash screen to use UI Framework components.
* Convert number list to use kuiButtons.
* Convert stringify color editor to use kuiButtons.
* Convert timepicker directive to use kuiButtons.
* Convert Index Pattern Management to use kuiButtons.
- Convert Index Pattern Management field editor to use kuiButtons.
- Remove unnecessary ng-class from Create Index Pattern submit button.
* Remove unused global_config.html partial.
* Fix functional tests.
- Rename discover-save-search-btn test subject selector to discoverSaveSearchButton.
- Convert Notifier tests to use kuiButtons.
- Convert functional tests to use test subject selectors instead of relying on btn classes.
- Update HeaderPage and VisualizePage page objects to refer to timePickerGoButton.
- Fix broken functional tests for Discover, Visualize, and Settings.
- Fix failing Discover scripted fields tests.
* Fix visual bugs with FieldChooser string, Notifier buttons, and NumberList.
* Fix Number List so the 'remove' buttons are small.
* Fix FieldEditor to have space between Popularity input and dec/increment buttons.
* Update FieldChooser string partial to have padding around 'Visualize' button.
* build before running selenium
* change directory into built snapshot
* WIP: what is in the build dir
* WIP: skip unit tests
* run selenium on build
* [functional tests on build] Derive version
* [functional tests on build] Missing folder name prefix
* WIP: debug on ubuntu VM
* WIP: double kibana stabilize timeout
* WIP: remove ubuntu VM debug change
* WIP: add logs for docParams
* WIP: add logs for es
* build release version without -SNAPSHOT-
* [functional test release] Cleanup
* Reorder Create Index Pattern logic so local functions are before scope methods.
* Extract some Index Pattern Creation logic into sendCreateIndexPatternRequest and getDefaultPatternForInterval services.
* Use UI Framework typography components for Index Pattern Creation header.
* Separate user-specified variables for configuring the index pattern from controller variables, which just change the UI state.
* Rename index to newIndexPattern for clarity.
* Use controllerAs and fat arrow functions in Create Index Pattern.
* [functional_test_runner] replace functional testing tools with custom/pluggable solution
* [functional_test_runner] Convert unit tests to commonjs format
* [functional_test_runner] Fix dashboard test in wrong mode
* [functional_test_runner] Add dashboardLandingPage test subject
* [functional_test_runner] Get Visualize page object
* [functional_test_runner] Fix outdated references
* [functional_test_runner] Fix more outdated refs
* [functional_test_runner] Remove duplicate tests
* [functional_test_runner] Improve test readability
* [functional_test_runner] 😞 So many duplicate methods
* [functional_test_runner] Move mgmt `before` outside toplevel describe
* [functional_test_runner] Settings page obj missing methods
* [functional_test_runner] Add improvements from @gammon
* [functional_test_runner] Fix return statements in async funcs
* [functional_test_runner] Move before() to correct scope
* [functional_test_runner] Add after() hooks to remove index patterns
* [functional_test_runner] Attempt to fix vertical bar chart tests
* [functional_test_runner] Clean up
* [functional_test_runner] Reinstate unit tests
* [functional_test_runner] Set default loglevel back to info
* [functional_test_runner] Replace `context`s with `describe`s
* [functional_test_runner] Better error handling
* [functional_test_runner] Add in new Tile Map tests
* Incorporate changes from master
* [functional_test_runner] validate that every test file has a single top-level suite
* Update contributing doc with link to full doc
* [docs] Spelling and grammar fixes
* docs: writing and running functional tests
* [docs] Move plugin doc to plugin area
* [docs] Housekeeping. Doc in wrong place
* [docs] Remove dup doc file
* [grunt] Only run mocha_setup when running tests, not every grunt task
* Put share link back in edit mode
See https://github.com/elastic/kibana/issues/10951 for background and
reasoning
* Preserve backward compatibility with pre 5.3 dashboard links
* Fix paths so create and edit use landing page as a substring
Apparently it has to be this way for the chrome nav to handle app
navigation the right way.
* Replace more strings with constants
* Update tests to point to new default dashboard url landing page
* [utils] move encodeQueryComponent into shared utils
* [uiNavLink] allow specifying subUrl pattern
* [dashboards] use dashboard urls that are more like before 5.3
* update comments
* Remove one comment, add another
* Remove failing toJSON test since the function was removed
Submitting now, but pending feedback that toJSON was removed
intentionally.
* Fix tests that need subUrlBase set manually
* fix bad markup in breadcrumbs
* Preserve 5.3 create dashboard links!
* add a comment
* Convert default to named exports - errors
* Make all error classes use class syntax and extends
add tests
* Extending Error apparently doesn't work
* Merge PR #11004 to try to fix test failures
* Factor out column manipulation in the doc table
This refactoring effort turns the implicit manipulation of the set of
columns that was scattered throughout the doc table and the field
chooser into explicit function calls. This brings with it the following
improvements:
* The column manipulation code is not duplicated (DRY)
* The controller stays in control (IOC)
* If the required functions are not provided by the controller,
manipulation of the columns is disabled.
Additionally, the `discover_field` now uses a properly isolated scope
instead of accessing inherited properties of the scope.
* Make filter addition and removal in tests more reliable
* Change function name to plural, move up ng-if
* Remove inconsistent variable initialization
* Fix function name typo
* Save the state in the action instead of a $watch
- adds the geo-centroid metric as the new default for visualizations
- various bug fixes and improvements
- avoid unnecessary calls to manifest
- avoid map flicker when zooming
- enable scroll/pinch/touch zooming
- avoid heatmap errors
- ensure map fills screen in dashboard
- ensure fit works consistently
- relax tilemap constraints
- remove support for multi-maps
- this refactor sets the stage for new vector map visualization which will reuse the same map components
* Hide the time interval select on blur
* Show scale warning on discover and keep drop-down
* Show scale without need to hover over info icon
* Remove unused variables
* Fix discover page object tests
* Fix getChartInterval in functional test
* As a part of bringing functional testing to plugins, esArchiver gives these plugins a way to capture and reload es indexes without needing to write a bunch of custom code. It works similarly to the elasticDump and ScenarioManager tools that it replaces.
Differences:
- Streaming implementation allows for much larger archives
- CLI for creating and using archives
- Configurable archive location
- Stores the data in gzipped files (better for source control, searching, large archives)
- Automatically identifies and upgrades Kibana config documents
Methods:
- `#load(name)`: import an archive
- `#loadIfNeeded(name)`: import an archive, but skip the documents what belong to any existing index
- `#unload(name)`: delete the indexes stored in an archive
CLI operations:
- `./bin/es_archiver save <name> [index patterns...]`: save the mapping and documents in one or more indexes that match the wild-card patterns into an the `<name>` archive
- `./bin/es_archiver load <name>`: load the mapping and documents from the `<name>` archive
* [functional_tests/common/nagivate] check for statusPage
* [es_archiver] move bins into new scripts dir
* [functional_tests/apps/context] use esArchiver
* [esArchiver] general improvements after showing to a few folks
- remove auto-upgrading config doc logic (until we have better access to kibana version info)
- export unload command
- remove preemptive checks in favor of reacting to errors
- use type "doc" vs "hit" for doc records (consistency)
- wrote a bunch of pending tests to think though and plan
* [esArchiver] make log a stream that writes to itself
* [esArchiver] fill in stats and archive format tests
* [esArchiver] splitup action logic
* [esArchiver/cli] fix cli --help output and comment
* [esArchiver] remove type-based param coercion
* [esArchiver/log] use strings for log levels
* [esArchvier] remove unused var
* [esArchiver/indexDocRecordsStream] add tests
* [esArchive] fill in remaining tests
* [esArchiver] fix dem tests
* [eslint] remove unused vars
* [esArchiver/loadIfNeeded] fix call to load()
* [esArchiver] remove loadDumpData helpers
* Start at view/edit mode 4
* Revert back to save panel
- Get rid of `clone`
- Get rid of rename
* Move order of top nav component around so no chance of hitting Edit -> Cancel
* Update "lose changes" confirmation dialog
- Change the string and button text
- Set default focus on the cancel button.
* Remove DashboardViewMode
It was previously used when viewMode wasn’t stored in appState, in
order to keep an unsaved dashboard, that was just saved, in Edit mode.
This is unnecessary in the latest iteration.
* Pull time filter out of dashboard_state
* Fix edit controls bug, add more tests, make other tests more stable.
* Remove unnecessary logic, unapplied query bug fix, code clean up
* Fix bug on filter reloading, add tests & clean up
* Fix issue with move and remove icons showing up in expanded panel mode
and add tests to catch it.
* Fix issue with lose changes not resetting panel state
and add tests.
* General Clean Up
- Merge function only used in one spot inline.
Add comments
* address code review comments
* Stop using static + class to namespace functions
Instead, export each function individually.
* Show dashed border on maximized panels in edit mode.
* Be more methodical about ensuring the modal dialog hides before continuing.
* abide by new no unused vars rule
* Add a dropdown to filter indexed fields by type
Added tests and test subjects for index pattern filters
Use UI Framework components
Change index field filter to use kuiFieldGroup, move filters below tabs
* Dynamically load indexed type filter based on existing field types
* Iterate over fields once to get types / languages
* Only check scripted flag for checking scripted lang fields, all other
fields should have their type added to type filter
We always run the build task now in jenkins jobs rather than only in the
core builds. This ensures that the build task runs in PR builds even
though the build artifacts are not used for anything.
Ideally all the selenium tests would run against this build rather than
it just being something that gets ran and forgotten about, but this is a
first step.
* Initial import
* updating the editor width to match the new specs
* Adding tribe node support
* Adding tests for server libs
* removing bluebird
* removing extra cruft
* Fixing the font sizes
* Fixed the updating code
* Adding brushing
* Fixing linting issues
* Adding global filters
* Adding missing packages
* Default gauge style to half circle
* Fixing the markdown css bug
* Adding tests for the get_vis_data api
* Adding time offset
* Adding time offset to each type
* fixing bugs from time offset
* adding index pattern option to series
* Adding index pattern overrides
* Adding index pattern overrides
* Fixing tests
* Fixing brushing in the vis editor
* Changing the label
* Change the behavior of selecting a pipeline agg when only one exists.
* Refactoring series a bit
* Changing series options to just options
* Making sure we honor the toaster container height
* Adding first tests
* renaming vis_config to panel_config
* renaming vis_config to panel_config
* Adding more tests
* adding more tests
* removing api subdirectory
* refactoring get_vis_data (breaking it up and removing unused imports)
* reorganizing the visualization directory
* Re-organizing directory layouts and moving things to more logical places
* Refactoring React compontents to use ES6 syntax and adding propTypes for each. Also refactored out splats as much as possible.
* Adding serial differencing
* Refactored gauge to use 2 components instead of 4
* Finishing react refactor on visualizations. Consolidated legned funtionality
* Refactoring series config and removing a bunch of duplicate code
* fixing series config name
* Fixing numbers and strings (doesnt matter which it is); Fixing classname
* Changing the way the dark theme works
* Adding new vis into list for test
* Adding empty bucket check
* Fixing the index patterns in the aggs
* Fixing typo
* Refactoring vis_data
* Fixing std_metric
* Fixing refresh-hack
* Adding tests for get_splits, get_last_metric, map_bucket
* Fixing the error handing
* removing restrictions
* Sometimes values are strings or numbers... it doesn't matter
* Adding new color options for splits
* Fixing colors
* fixing size
* Adding support for fitlers agg
* Fixing tests
* Fixing splits for filters
* Fixing Top N to work better with fitlers
* Adding annotation editor
* initial work for annotations
* Finalizing annotations
* Fixing label
* making it expandable
* Fixing hacks fixed by #10175
* Fixing bars to use the same stacking options as lines
* Getting rid of align by colons
* removing unused depends
* removing unused depends
* Changing to readable lodash function
* Adding missing parens
* refactoring custom color picker
* Removing string refs and converting uncontrolled components
* Fixing the controlled components where value maybe null; converting error to css
* refactoring styles from components
* fixing the refresh behavoir borked by fullEditor
* Adding the executor service
* Fixing the test directories
* fixing save
* Adding filter ratios
* Fixing controlled components
* Trying to fix the weird typing
* Fixing offset bug with days
* Adding percentile rank
* Fixing yaxis updates; fixing percentile rank layout; adding steps to line chart
* removing unused depends
* Fixed a bug with the index patterns updating; fixed bug with charts rendering too much
* Fixing tests
* Commenting out React tests because the ENV must have change and they are no longer working
* Moving bucket transform
* moving calculate auto
* Moving calculate_indices
* moving extended_stats_types && get_agg_value
* moving get_buckets_path
* moving get_sibling_agg_value
* moving parse_settings
* moving series_agg
* Moving unit_to_seconds
* Fixing tests
* Fixing per PR
* Renaming vars to make it more clear what's happening
* Changing the way testible functions are exported
* fixing tests
* removing unused imports; fixing typos; fixing package name
* Name has to match the plugin path
* Fixing typos; removing unused imports
* fixing tests
* rearanging and removing unused imports
* Fixing a bug with unque names for radio buttons on the same form
* Fixing filter ratio to use a metric instead of just count
* fixing a bug with the new filter ratios
* Fixing the file path from the #8
* Fixing renderComplete trigger; Fixing embedded mode; Changing names for Timelion and Time Series Visual Builder
* Fixing name
* Fixing docs
* Fixing a typo for the field select for terms splits
* Fixing tests
Calling `.findTestSubject().click()` seems to be particularly error prone. This helper combines to the two actions and wraps them in a retry so we don't have to keep scattering `PageObject.common.try()` calls throughout the tests.
* Warn if the title is a duplicate
* warn when copyOnSave is checked. add a test
* update message
* fix tests
* Fix issues with substring matching
add more tests.
* make case insensitive and return matching title
* Fix bug caused by subtle difference between this.type and type
Add a comment and rename one of the variables to make the distinction
clearer.
* add debug messages.
* fix tests again
* uncomment out tests
* more debug messages
* save more screenshots
* Need to wait till save finishes or the page may redirect the url after the page has navigated away
* address code review comments
This adds a link to the detail view of discover rows to switch to a view of the documents immediately before and after the selected document. Since that view uses the timestamp field of the index pattern, it is only available for time-based indices.
See #9198 for detailed screenshots.
* Adding attributes to be used by sharing
* Moving the shared-item tags for dashboard panels
* Switching from shared-item-title/description to just title/description
* Removing move noise
* Fixing typo
* Adding data- prefix before attributes, began writing tests
Adding shared-item title tests
Switching up the panel tests
Adding description tests
Fixing linting
Adding dashboard timefilter test
Adding visualization shared-item tests
Adding shared-timefilter tests
Adding discover shared-item tests
* Fixing shared-items-count on dashboard
* Fixing functional test data for discover and visualize
* adding vislib chart grid
* updating vislib to correctly render all new features
* adding new options to kibana visualizations
* update vis icon on save
* updating documentation
* fixing unit tests
* cleaning up
* updating based on UI review
* adding visualize editor unit tests
* selenium tests
* additional option tabs
* some more changes to the tabs/options [thanks CJ]
* going back from Category/Value axis to X/Y axis
* fixing unselected dropdown options
* updating based on last UI review
* updating based on last review
* updating based on last review
* fixing issue with axis titles
* allowing to specify only upper or only lower data bound
* updating based on brandons review
* fixing horizontal bar chart labels
* fixing test
* adding backward compatibility
* updating based on last review
* fixing selenium tests
* Stabilize tests involving absolute timepicker
The asynchronous nature of angular's digest cycle and the page rendering
in the browser can lead to situations in which
`isGlobalLoadingIndicatorHidden()` returns true because the loading
triggered by the previous action has not yet started. In this case
subsequent actions incorrectly assume the loading has already been
completed. This is probably responsible for the flakiness described in #10302.
The newly introduced `waitUntilLoadingHasFinished` first waits for a
duration up to `defaultTimeout` for the loading indicator to appear
before waiting for it to be hidden again. In the best case this will
reduce the false positive rate of `setAbsoluteTimerange()`. In the worst
case the function will wait `defaultTimeout` longer than when just using
`isGlobalLoadingIndicatorHidden`.
fixes#10302
* [npm] upgrade babel
The upgrade to babel 6 requires an upgrade to all of the associated modules, which meant that a few other things changed at the same time. The most notable is the way that we handle our babel-options, which is now done with an npm module and includes using the babel-loader's "presets" query string param.
This meant changes to the babel_options.js module and extending it to help setting up the "babel-register" module, which was previously copy-pasted in several places.
* [mtodules] upgrade to support babel6 module semantics
* [eslint] fix lint errors
* [babel] ignoer massive fixture files
* [cli/errors] use Object.setPrototypeOf since subclassing Error is broken
* [babel] Upgrading core babel libraries
[babel] Use WIP babel-6-fix branch of babel-preset-kibana
* Fix broken test
* [babel] Reverse unnecessary module.exports changes
* Fix notifier
* Use babel presets and plugins directly
* [babel/options] resolve preset/plugins paths for better plugin compatibility
* [babel/options] use babel-preset-env for correct node settings
* [babel] cache babel compilation in webpack like we thought we were
* Add a sleep to Header page object's clickTimepicker method, to wait for the page to render on Jenkins.
* Add a sleep to Visualize page object's clickNewSearch method, to wait for the page to render on Jenkins.
* Wait for loading indicator to disappear to signify completion of clickNewSearch() in Visualize page object.
* Wrapper Header page object's clickTimepicker method in a try block.
* Refactor Visualize Wizard to use explicit controller names, instead of defining them dynamically.
* Add landing page with table to Visualize app.
* Update Visualize wizard UI.
* Add kuiIcon--basic and support icons in Table component. Display icons in Visualize landing page.
* Refactor Visualize Wizard templates to use import syntax.
* Set kuiViewContent width to 100% to avoid it shrink wrapping its content.
* Move ToolBar buttons to the right side. Remove labels and add tooltips.
* Remove unused Visualize load menu template.
* Disable timepicker in Visualization listing.
* Change Visualize route names. Add omitPages attribute to breadcrumbs directive. Make Visualize breadcrumbs into links.
* Remove Open and New menu buttons from Visualize.
* Add ConfirmationModal for deleting visualizations.
* Implement sorting for name and type columns in Visualize listing.
* Refactor Visualize routes into VisualizeConstants file. Fix functional tests.
* Add pager_controls directive and pager service. Add pagination to Dashboard and Visualize landing pages. Change Dashboard listing to use hrefs for each dashboard.
* Use ng-if instead of ng-hide to hide/reveal Table action buttons in Dashboard listing.
* Redirect from old Visualize wizard routes to new ones.
* Use ViewContent and Title components in Visualize wizard.
* Fix Visualize and Dashboard listing table logic so that selection only applies to the current page of items.
* Paging clears the selection.
* Searching clears the selection.
* Sorting clears the selection.
* Use consistent "Create" terminology in both Visualize and Dashboard for creating new items.
* Use NoItems and PromptForItems components in Visualize listing view.
* Use $injector to inject dependencies in Visualize and Dashboard listing.
Rather than wrapping two discrete webdriver requests in a single try()
block, we do each request in its own block to help prevent inconsistent
failures.
* Introduce dashboard landing page
Still TODO:
- Add clickable breadcrumbs
- Remove New and Open top nav options
* use clickable breadcrumbs instead of 'New' and 'Open' nav items
* code cleanup
improve tests
* Add new empty dashboard styling
* Fix selenium tests
* Address code review comments
- rename bread_crumb_url => bread_crumb_urls
- fix reporting link in dash (separate PR)
- Use NoItems instead of PromptForItems when searching
- Style fixes
* Use a constant for the landing page url
* Fix tests
* Use better confirm button text. rename safe confirm.
Use confirm_modal_promise only when it’s easier than using
confirm_modal directly.
change all native confirmations to the new dialog
* address code review comments
* Be consistent with the confirm button text pattern
Address other code review comments
* remove default option for confirmButtonText
Require onConfirm and confirmButtonText for confirmModal
* fix tests for no longer using alertText
* address code review comments Round 2
* Restructure dashboard files and folders
* Try to stay DRY
avoid duplicate ‘dashboard’ naming when unnecessary
* rename index => dashboard and add an index.js with imports
rename style
* un-dig
* Close timepicker when a filter/interval is selected
* Copy absolute variables before sending
* Use & instead of = for directive binding
* Fix timepicker tests
* Fix timepicker tests and remove tests that no longer apply
This modifies the way Kibana reads out metadata about the TMS service used in the Tilemap Visualization.
- Kibana now uses an external service that exposes a 'manifest'. This contains metadata about one or more available TMS services
- Kibana continues to respect the configuration of the kibana.yml file. If a custom TMS service is set here, the manifest will not be consulted
- This also adds an API extension point for other plugins to add additional query parameters to the requests to the manifest service and for the individual tile requests to the TMS.
* adding UI styles (should extract)
* adding heatmap vislib type
* adding heatmap visualization
* adding documentation
* renaming heatmap options
* fixing options issues
* fixing color selection
* fixing / adding tests
* adding more color schemas
* adding more options
* adding cell labels
* fixing selenium test
* only allow to rotate labels by 90 degrees
* converting color number slider to number input
* hide labels if they don't fit
* fixing small issues
* improved range options
* fixing based on Thomas' review
* rebasing on master and fixing linting issues
* adding selenium tests
* fixing alerts
* fixing padding
* fixing based on review
* fixing math
* fixing custom range options
* removing $timeout
* notification in case labels were hidden
* fixing tests
* fixing based on last review
* fixing based on thomas' review
* [WIP] new scripted field tests
* Final improvements on 12 new tests for 1 expression and 2 painless scripted fields
* Add try loops around testing first Discover doc
* Set timezone to UTC and adjusted data accordingly
* Added boolean and date Painless scripted field types
* Remove unused (non-working) methods
* Fix lint error
* Added several data-test-subj attributes and used them in the tests
* Reverting previous change to getBarChartData
* upgrade eslint, all related deps, and config files
* replace gruntify-eslint with basic eslint-cli wrapper
* arrow-IIFEs must be invoked outside of the parens
* move import statements before their use
* reindent to satisfy new indentation check algorithm
* place missing semicolon
* ignore copy-pasted decode geohash code
* [grunt/eslint] fix argument spacing
* [gurnt/eslint] add comment about contents of report
* [grunt/tasks] use `export default`
Multiple changes to the Vislib point series charts. Before each of the chart (bar/area/line) would be an independent unit responsible for drawing all of its parts (axes, titles). This change splits things up so we can have greater control and better code reuse.
converting to ES6
moving axes out of each chart
joining both axes types (x and y) into a common axis type
allowing multiple axes
allowing top/bottom/left/right axis positioning
introducing new chart type 'point_series' which can combine bar/line/area series
making each of the series (bar/line/area) direction independent (vertical/horizontal charts)
A tag cloud visualization is a visual representation of text data, typically used to visualize free form text. Tags are usually single words. The font size of word corresponds with its importance.
* Update PageObjects for Visualize, Dashboard, and Discover to use data-test-subj selectors for menu items.
* Run checkPlugins task as part of test:ui:runner task.
* added source filtering
* ditched the new 'retrieved fields' tab and added checkbox to exclude a field in the field control
* disable field exclusion checkbox if field is a metafield
* [indexPattern] copy excluded field property when refreshing fields
* [indexPattern/field] move isMetaField consideration into Field
* [indexPattern/edit] invert the "retreived" column, for accuracy
* [indexPattern/field] touchup the field.exclude message
* Fix typo
* [indexPattern] handle index patterns without fields
* [courier/searchSource] auto add source filter for index pattern
* [docTable] remove irrelevant test about source filtering
* [settings/indices] cleanup imports
* [settings/indexPattern/fields] add "field filters" tab
* [imports] fix old testUtils import
* [ui/fieldWildcard] add lib to match names based on field-style wildcards
* [settings/fieldFilters] list filter matches, remove excluded fields from fieldata_fields
* [fieldWildcard] properly escape regexp control chars
* [settings/indexPatterns] mark fields excluded if they match an exclude pattern
* [fieldWildcard] properly bind the regexp to the ends
* [indexPattern] remove unneeded lodash chain
* [settings/indices] use settings-indices- prefix for tab direcives
* corrected rebase on master
* Do not match exclusion on meta/scripted fields. Disable filter bar when on 'Filter fields' tab. Removed exclusion checkbox in the field controls page. Corrected typos. Improved documentation phrasing.
* corrected error in merge with _index_pattern
* removed unused code
* added missing fieldFilters to test dumps
* corrected merge with master
* removed default empty array in the index pattern schema, and check if fieldFilters exists
* restricts the source with the exclusion patterns set for that index pattern
* renamed field filters to source filters and explicitely retrieve the source in the doc controller
* renamed variables/moved files from field filters to source filters
* Renamed _field_types.js to _edit_sections.js to better reflect what it is for. Corrected editting typo. Renamed exclude column name to excluded. Corrected HTML styling. Removed unused config parameters in field_wildcard.
* Removed lines that were specifying the _source field since they were made unnecessary by https://github.com/elastic/kibana/pull/7402/files#diff-d1695ba2026ff89878f9e4f4de683758R50
* moved fielddata_fields source filtering to where it is initialized
* two-column layout for the source filters indices section
* corrected tests
* use the same table layout as in the other index sections.
Filter input correctly restricts source filters.
Do not match .keyword fields.
* Filter out .raw suffix from possible matches.
Removed unused HTML file.
Corrected bug that allowed to save an empty source filter.
* exclude is deprecated, should be excludes
* improved description
* changed as per code review
* removed filtering logic for keyword and raw fields
* Fix bug where the loading indicator was wider than the screen, allowing you to drag a dashboard panel very wide and break the UI.
* Refactor kbnLoadingIndicator to be a standalone component.
* Make loadingIndicator fixed position so it doesn't disrupt the layout when it appears and disappears.
* Uncouple from .spinner styles.
* Set a max-width on it.
* Rename Common PageObject getSpinnerDone method to isGlobalLoadingIndicatorHidden.
- Migrate to new localNav component and subcomponent styles.
- Add support for multi-slot transclusion to kbnTopNav.
- Update Dashboard, Discover, Management, Visualize, Dev Tools, Timelion to use kbnTopNav consistently.
- Update these apps to also display localNavDropdowns consistently, including Timepicker (this mostly meant adding titles).
- Add checkLicenses npm script.
- Add .fullWidth utility class and use it to make search forms 100% width.
